]> git.sesse.net Git - bcachefs-tools-debian/blob - libbcachefs/journal_io.c
0e6fbe2f6a7542ac24495a8a02864af35638fa48
[bcachefs-tools-debian] / libbcachefs / journal_io.c
1 // SPDX-License-Identifier: GPL-2.0
2 #include "bcachefs.h"
3 #include "alloc_foreground.h"
4 #include "btree_io.h"
5 #include "btree_update_interior.h"
6 #include "buckets.h"
7 #include "checksum.h"
8 #include "error.h"
9 #include "io.h"
10 #include "journal.h"
11 #include "journal_io.h"
12 #include "journal_reclaim.h"
13 #include "journal_seq_blacklist.h"
14 #include "replicas.h"
15
16 #include <trace/events/bcachefs.h>
17
18 static void __journal_replay_free(struct journal_replay *i)
19 {
20         list_del(&i->list);
21         kvpfree(i, offsetof(struct journal_replay, j) +
22                 vstruct_bytes(&i->j));
23
24 }
25
26 static void journal_replay_free(struct bch_fs *c, struct journal_replay *i)
27 {
28         i->ignore = true;
29
30         if (!c->opts.read_entire_journal)
31                 __journal_replay_free(i);
32 }
33
34 struct journal_list {
35         struct closure          cl;
36         struct mutex            lock;
37         struct list_head        *head;
38         int                     ret;
39 };
40
41 #define JOURNAL_ENTRY_ADD_OK            0
42 #define JOURNAL_ENTRY_ADD_OUT_OF_RANGE  5
43
44 /*
45  * Given a journal entry we just read, add it to the list of journal entries to
46  * be replayed:
47  */
48 static int journal_entry_add(struct bch_fs *c, struct bch_dev *ca,
49                              struct journal_list *jlist, struct jset *j,
50                              bool bad)
51 {
52         struct journal_replay *i, *pos;
53         struct bch_devs_list devs = { .nr = 0 };
54         struct list_head *where;
55         size_t bytes = vstruct_bytes(j);
56         u64 last_seq = 0;
57         int ret;
58
59         list_for_each_entry_reverse(i, jlist->head, list) {
60                 if (!JSET_NO_FLUSH(&i->j)) {
61                         last_seq = le64_to_cpu(i->j.last_seq);
62                         break;
63                 }
64         }
65
66         /* Is this entry older than the range we need? */
67         if (!c->opts.read_entire_journal &&
68             le64_to_cpu(j->seq) < last_seq) {
69                 ret = JOURNAL_ENTRY_ADD_OUT_OF_RANGE;
70                 goto out;
71         }
72
73         /* Drop entries we don't need anymore */
74         if (!JSET_NO_FLUSH(j)) {
75                 list_for_each_entry_safe(i, pos, jlist->head, list) {
76                         if (le64_to_cpu(i->j.seq) >= le64_to_cpu(j->last_seq))
77                                 break;
78                         journal_replay_free(c, i);
79                 }
80         }
81
82         list_for_each_entry_reverse(i, jlist->head, list) {
83                 if (le64_to_cpu(j->seq) > le64_to_cpu(i->j.seq)) {
84                         where = &i->list;
85                         goto add;
86                 }
87         }
88
89         where = jlist->head;
90 add:
91         i = where->next != jlist->head
92                 ? container_of(where->next, struct journal_replay, list)
93                 : NULL;
94
95         /*
96          * Duplicate journal entries? If so we want the one that didn't have a
97          * checksum error:
98          */
99         if (i && le64_to_cpu(j->seq) == le64_to_cpu(i->j.seq)) {
100                 if (i->bad) {
101                         devs = i->devs;
102                         __journal_replay_free(i);
103                 } else if (bad) {
104                         goto found;
105                 } else {
106                         fsck_err_on(bytes != vstruct_bytes(&i->j) ||
107                                     memcmp(j, &i->j, bytes), c,
108                                     "found duplicate but non identical journal entries (seq %llu)",
109                                     le64_to_cpu(j->seq));
110                         goto found;
111                 }
112
113         }
114
115         i = kvpmalloc(offsetof(struct journal_replay, j) + bytes, GFP_KERNEL);
116         if (!i) {
117                 ret = -ENOMEM;
118                 goto out;
119         }
120
121         list_add(&i->list, where);
122         i->devs = devs;
123         i->bad  = bad;
124         i->ignore = false;
125         memcpy(&i->j, j, bytes);
126 found:
127         if (!bch2_dev_list_has_dev(i->devs, ca->dev_idx))
128                 bch2_dev_list_add_dev(&i->devs, ca->dev_idx);
129         else
130                 fsck_err_on(1, c, "duplicate journal entries on same device");
131         ret = JOURNAL_ENTRY_ADD_OK;
132 out:
133 fsck_err:
134         return ret;
135 }
136
137 static struct nonce journal_nonce(const struct jset *jset)
138 {
139         return (struct nonce) {{
140                 [0] = 0,
141                 [1] = ((__le32 *) &jset->seq)[0],
142                 [2] = ((__le32 *) &jset->seq)[1],
143                 [3] = BCH_NONCE_JOURNAL,
144         }};
145 }
146
147 /* this fills in a range with empty jset_entries: */
148 static void journal_entry_null_range(void *start, void *end)
149 {
150         struct jset_entry *entry;
151
152         for (entry = start; entry != end; entry = vstruct_next(entry))
153                 memset(entry, 0, sizeof(*entry));
154 }
155
156 #define JOURNAL_ENTRY_REREAD    5
157 #define JOURNAL_ENTRY_NONE      6
158 #define JOURNAL_ENTRY_BAD       7
159
160 #define journal_entry_err(c, msg, ...)                                  \
161 ({                                                                      \
162         switch (write) {                                                \
163         case READ:                                                      \
164                 mustfix_fsck_err(c, msg, ##__VA_ARGS__);                \
165                 break;                                                  \
166         case WRITE:                                                     \
167                 bch_err(c, "corrupt metadata before write:\n"           \
168                         msg, ##__VA_ARGS__);                            \
169                 if (bch2_fs_inconsistent(c)) {                          \
170                         ret = BCH_FSCK_ERRORS_NOT_FIXED;                \
171                         goto fsck_err;                                  \
172                 }                                                       \
173                 break;                                                  \
174         }                                                               \
175         true;                                                           \
176 })
177
178 #define journal_entry_err_on(cond, c, msg, ...)                         \
179         ((cond) ? journal_entry_err(c, msg, ##__VA_ARGS__) : false)
180
181 #define FSCK_DELETED_KEY        5
182
183 static int journal_validate_key(struct bch_fs *c, struct jset *jset,
184                                 struct jset_entry *entry,
185                                 unsigned level, enum btree_id btree_id,
186                                 struct bkey_i *k,
187                                 const char *type, int write)
188 {
189         void *next = vstruct_next(entry);
190         const char *invalid;
191         unsigned version = le32_to_cpu(jset->version);
192         int ret = 0;
193
194         if (journal_entry_err_on(!k->k.u64s, c,
195                         "invalid %s in jset %llu offset %zi/%u entry offset %zi/%u: k->u64s 0",
196                         type, le64_to_cpu(jset->seq),
197                         (u64 *) entry - jset->_data,
198                         le32_to_cpu(jset->u64s),
199                         (u64 *) k - entry->_data,
200                         le16_to_cpu(entry->u64s))) {
201                 entry->u64s = cpu_to_le16((u64 *) k - entry->_data);
202                 journal_entry_null_range(vstruct_next(entry), next);
203                 return FSCK_DELETED_KEY;
204         }
205
206         if (journal_entry_err_on((void *) bkey_next(k) >
207                                 (void *) vstruct_next(entry), c,
208                         "invalid %s in jset %llu offset %zi/%u entry offset %zi/%u: extends past end of journal entry",
209                         type, le64_to_cpu(jset->seq),
210                         (u64 *) entry - jset->_data,
211                         le32_to_cpu(jset->u64s),
212                         (u64 *) k - entry->_data,
213                         le16_to_cpu(entry->u64s))) {
214                 entry->u64s = cpu_to_le16((u64 *) k - entry->_data);
215                 journal_entry_null_range(vstruct_next(entry), next);
216                 return FSCK_DELETED_KEY;
217         }
218
219         if (journal_entry_err_on(k->k.format != KEY_FORMAT_CURRENT, c,
220                         "invalid %s in jset %llu offset %zi/%u entry offset %zi/%u: bad format %u",
221                         type, le64_to_cpu(jset->seq),
222                         (u64 *) entry - jset->_data,
223                         le32_to_cpu(jset->u64s),
224                         (u64 *) k - entry->_data,
225                         le16_to_cpu(entry->u64s),
226                         k->k.format)) {
227                 le16_add_cpu(&entry->u64s, -((u16) k->k.u64s));
228                 memmove(k, bkey_next(k), next - (void *) bkey_next(k));
229                 journal_entry_null_range(vstruct_next(entry), next);
230                 return FSCK_DELETED_KEY;
231         }
232
233         if (!write)
234                 bch2_bkey_compat(level, btree_id, version,
235                             JSET_BIG_ENDIAN(jset), write,
236                             NULL, bkey_to_packed(k));
237
238         invalid = bch2_bkey_invalid(c, bkey_i_to_s_c(k),
239                                     __btree_node_type(level, btree_id));
240         if (invalid) {
241                 char buf[160];
242
243                 bch2_bkey_val_to_text(&PBUF(buf), c, bkey_i_to_s_c(k));
244                 mustfix_fsck_err(c, "invalid %s in jset %llu offset %zi/%u entry offset %zi/%u: %s\n%s",
245                                  type, le64_to_cpu(jset->seq),
246                                  (u64 *) entry - jset->_data,
247                                  le32_to_cpu(jset->u64s),
248                                  (u64 *) k - entry->_data,
249                                  le16_to_cpu(entry->u64s),
250                                  invalid, buf);
251
252                 le16_add_cpu(&entry->u64s, -((u16) k->k.u64s));
253                 memmove(k, bkey_next(k), next - (void *) bkey_next(k));
254                 journal_entry_null_range(vstruct_next(entry), next);
255                 return FSCK_DELETED_KEY;
256         }
257
258         if (write)
259                 bch2_bkey_compat(level, btree_id, version,
260                             JSET_BIG_ENDIAN(jset), write,
261                             NULL, bkey_to_packed(k));
262 fsck_err:
263         return ret;
264 }
265
266 static int journal_entry_validate_btree_keys(struct bch_fs *c,
267                                              struct jset *jset,
268                                              struct jset_entry *entry,
269                                              int write)
270 {
271         struct bkey_i *k = entry->start;
272
273         while (k != vstruct_last(entry)) {
274                 int ret = journal_validate_key(c, jset, entry,
275                                                entry->level,
276                                                entry->btree_id,
277                                                k, "key", write);
278                 if (ret == FSCK_DELETED_KEY)
279                         continue;
280
281                 k = bkey_next(k);
282         }
283
284         return 0;
285 }
286
287 static int journal_entry_validate_btree_root(struct bch_fs *c,
288                                              struct jset *jset,
289                                              struct jset_entry *entry,
290                                              int write)
291 {
292         struct bkey_i *k = entry->start;
293         int ret = 0;
294
295         if (journal_entry_err_on(!entry->u64s ||
296                                  le16_to_cpu(entry->u64s) != k->k.u64s, c,
297                                  "invalid btree root journal entry: wrong number of keys")) {
298                 void *next = vstruct_next(entry);
299                 /*
300                  * we don't want to null out this jset_entry,
301                  * just the contents, so that later we can tell
302                  * we were _supposed_ to have a btree root
303                  */
304                 entry->u64s = 0;
305                 journal_entry_null_range(vstruct_next(entry), next);
306                 return 0;
307         }
308
309         return journal_validate_key(c, jset, entry, 1, entry->btree_id, k,
310                                     "btree root", write);
311 fsck_err:
312         return ret;
313 }
314
315 static int journal_entry_validate_prio_ptrs(struct bch_fs *c,
316                                             struct jset *jset,
317                                             struct jset_entry *entry,
318                                             int write)
319 {
320         /* obsolete, don't care: */
321         return 0;
322 }
323
324 static int journal_entry_validate_blacklist(struct bch_fs *c,
325                                             struct jset *jset,
326                                             struct jset_entry *entry,
327                                             int write)
328 {
329         int ret = 0;
330
331         if (journal_entry_err_on(le16_to_cpu(entry->u64s) != 1, c,
332                 "invalid journal seq blacklist entry: bad size")) {
333                 journal_entry_null_range(entry, vstruct_next(entry));
334         }
335 fsck_err:
336         return ret;
337 }
338
339 static int journal_entry_validate_blacklist_v2(struct bch_fs *c,
340                                                struct jset *jset,
341                                                struct jset_entry *entry,
342                                                int write)
343 {
344         struct jset_entry_blacklist_v2 *bl_entry;
345         int ret = 0;
346
347         if (journal_entry_err_on(le16_to_cpu(entry->u64s) != 2, c,
348                 "invalid journal seq blacklist entry: bad size")) {
349                 journal_entry_null_range(entry, vstruct_next(entry));
350                 goto out;
351         }
352
353         bl_entry = container_of(entry, struct jset_entry_blacklist_v2, entry);
354
355         if (journal_entry_err_on(le64_to_cpu(bl_entry->start) >
356                                  le64_to_cpu(bl_entry->end), c,
357                 "invalid journal seq blacklist entry: start > end")) {
358                 journal_entry_null_range(entry, vstruct_next(entry));
359         }
360 out:
361 fsck_err:
362         return ret;
363 }
364
365 static int journal_entry_validate_usage(struct bch_fs *c,
366                                         struct jset *jset,
367                                         struct jset_entry *entry,
368                                         int write)
369 {
370         struct jset_entry_usage *u =
371                 container_of(entry, struct jset_entry_usage, entry);
372         unsigned bytes = jset_u64s(le16_to_cpu(entry->u64s)) * sizeof(u64);
373         int ret = 0;
374
375         if (journal_entry_err_on(bytes < sizeof(*u),
376                                  c,
377                                  "invalid journal entry usage: bad size")) {
378                 journal_entry_null_range(entry, vstruct_next(entry));
379                 return ret;
380         }
381
382 fsck_err:
383         return ret;
384 }
385
386 static int journal_entry_validate_data_usage(struct bch_fs *c,
387                                         struct jset *jset,
388                                         struct jset_entry *entry,
389                                         int write)
390 {
391         struct jset_entry_data_usage *u =
392                 container_of(entry, struct jset_entry_data_usage, entry);
393         unsigned bytes = jset_u64s(le16_to_cpu(entry->u64s)) * sizeof(u64);
394         int ret = 0;
395
396         if (journal_entry_err_on(bytes < sizeof(*u) ||
397                                  bytes < sizeof(*u) + u->r.nr_devs,
398                                  c,
399                                  "invalid journal entry usage: bad size")) {
400                 journal_entry_null_range(entry, vstruct_next(entry));
401                 return ret;
402         }
403
404 fsck_err:
405         return ret;
406 }
407
408 struct jset_entry_ops {
409         int (*validate)(struct bch_fs *, struct jset *,
410                         struct jset_entry *, int);
411 };
412
413 static const struct jset_entry_ops bch2_jset_entry_ops[] = {
414 #define x(f, nr)                                                \
415         [BCH_JSET_ENTRY_##f]    = (struct jset_entry_ops) {     \
416                 .validate       = journal_entry_validate_##f,   \
417         },
418         BCH_JSET_ENTRY_TYPES()
419 #undef x
420 };
421
422 static int journal_entry_validate(struct bch_fs *c, struct jset *jset,
423                                   struct jset_entry *entry, int write)
424 {
425         return entry->type < BCH_JSET_ENTRY_NR
426                 ? bch2_jset_entry_ops[entry->type].validate(c, jset,
427                                                             entry, write)
428                 : 0;
429 }
430
431 static int jset_validate_entries(struct bch_fs *c, struct jset *jset,
432                                  int write)
433 {
434         struct jset_entry *entry;
435         int ret = 0;
436
437         vstruct_for_each(jset, entry) {
438                 if (journal_entry_err_on(vstruct_next(entry) >
439                                          vstruct_last(jset), c,
440                                 "journal entry extends past end of jset")) {
441                         jset->u64s = cpu_to_le32((u64 *) entry - jset->_data);
442                         break;
443                 }
444
445                 ret = journal_entry_validate(c, jset, entry, write);
446                 if (ret)
447                         break;
448         }
449 fsck_err:
450         return ret;
451 }
452
453 static int jset_validate(struct bch_fs *c,
454                          struct bch_dev *ca,
455                          struct jset *jset, u64 sector,
456                          unsigned bucket_sectors_left,
457                          unsigned sectors_read,
458                          int write)
459 {
460         size_t bytes = vstruct_bytes(jset);
461         struct bch_csum csum;
462         unsigned version;
463         int ret = 0;
464
465         if (le64_to_cpu(jset->magic) != jset_magic(c))
466                 return JOURNAL_ENTRY_NONE;
467
468         version = le32_to_cpu(jset->version);
469         if (journal_entry_err_on((version != BCH_JSET_VERSION_OLD &&
470                                   version < bcachefs_metadata_version_min) ||
471                                  version >= bcachefs_metadata_version_max, c,
472                         "%s sector %llu seq %llu: unknown journal entry version %u",
473                         ca->name, sector, le64_to_cpu(jset->seq),
474                         version)) {
475                 /* don't try to continue: */
476                 return EINVAL;
477         }
478
479         if (bytes > (sectors_read << 9) &&
480             sectors_read < bucket_sectors_left)
481                 return JOURNAL_ENTRY_REREAD;
482
483         if (journal_entry_err_on(bytes > bucket_sectors_left << 9, c,
484                         "%s sector %llu seq %llu: journal entry too big (%zu bytes)",
485                         ca->name, sector, le64_to_cpu(jset->seq), bytes)) {
486                 ret = JOURNAL_ENTRY_BAD;
487                 le32_add_cpu(&jset->u64s,
488                              -((bytes - (bucket_sectors_left << 9)) / 8));
489         }
490
491         if (fsck_err_on(!bch2_checksum_type_valid(c, JSET_CSUM_TYPE(jset)), c,
492                         "%s sector %llu seq %llu: journal entry with unknown csum type %llu",
493                         ca->name, sector, le64_to_cpu(jset->seq),
494                         JSET_CSUM_TYPE(jset))) {
495                 ret = JOURNAL_ENTRY_BAD;
496                 goto bad_csum_type;
497         }
498
499         csum = csum_vstruct(c, JSET_CSUM_TYPE(jset), journal_nonce(jset), jset);
500         if (journal_entry_err_on(bch2_crc_cmp(csum, jset->csum), c,
501                                  "%s sector %llu seq %llu: journal checksum bad",
502                                  ca->name, sector, le64_to_cpu(jset->seq)))
503                 ret = JOURNAL_ENTRY_BAD;
504
505         bch2_encrypt(c, JSET_CSUM_TYPE(jset), journal_nonce(jset),
506                      jset->encrypted_start,
507                      vstruct_end(jset) - (void *) jset->encrypted_start);
508 bad_csum_type:
509         if (journal_entry_err_on(le64_to_cpu(jset->last_seq) > le64_to_cpu(jset->seq), c,
510                                  "invalid journal entry: last_seq > seq")) {
511                 jset->last_seq = jset->seq;
512                 return JOURNAL_ENTRY_BAD;
513         }
514 fsck_err:
515         return ret;
516 }
517
518 struct journal_read_buf {
519         void            *data;
520         size_t          size;
521 };
522
523 static int journal_read_buf_realloc(struct journal_read_buf *b,
524                                     size_t new_size)
525 {
526         void *n;
527
528         /* the bios are sized for this many pages, max: */
529         if (new_size > JOURNAL_ENTRY_SIZE_MAX)
530                 return -ENOMEM;
531
532         new_size = roundup_pow_of_two(new_size);
533         n = kvpmalloc(new_size, GFP_KERNEL);
534         if (!n)
535                 return -ENOMEM;
536
537         kvpfree(b->data, b->size);
538         b->data = n;
539         b->size = new_size;
540         return 0;
541 }
542
543 static int journal_read_bucket(struct bch_dev *ca,
544                                struct journal_read_buf *buf,
545                                struct journal_list *jlist,
546                                unsigned bucket)
547 {
548         struct bch_fs *c = ca->fs;
549         struct journal_device *ja = &ca->journal;
550         struct jset *j = NULL;
551         unsigned sectors, sectors_read = 0;
552         u64 offset = bucket_to_sector(ca, ja->buckets[bucket]),
553             end = offset + ca->mi.bucket_size;
554         bool saw_bad = false;
555         int ret = 0;
556
557         pr_debug("reading %u", bucket);
558
559         while (offset < end) {
560                 if (!sectors_read) {
561                         struct bio *bio;
562 reread:
563                         sectors_read = min_t(unsigned,
564                                 end - offset, buf->size >> 9);
565
566                         bio = bio_kmalloc(GFP_KERNEL,
567                                           buf_pages(buf->data,
568                                                     sectors_read << 9));
569                         bio_set_dev(bio, ca->disk_sb.bdev);
570                         bio->bi_iter.bi_sector  = offset;
571                         bio_set_op_attrs(bio, REQ_OP_READ, 0);
572                         bch2_bio_map(bio, buf->data, sectors_read << 9);
573
574                         ret = submit_bio_wait(bio);
575                         bio_put(bio);
576
577                         if (bch2_dev_io_err_on(ret, ca,
578                                                "journal read error: sector %llu",
579                                                offset) ||
580                             bch2_meta_read_fault("journal"))
581                                 return -EIO;
582
583                         j = buf->data;
584                 }
585
586                 ret = jset_validate(c, ca, j, offset,
587                                     end - offset, sectors_read,
588                                     READ);
589                 switch (ret) {
590                 case BCH_FSCK_OK:
591                         sectors = vstruct_sectors(j, c->block_bits);
592                         break;
593                 case JOURNAL_ENTRY_REREAD:
594                         if (vstruct_bytes(j) > buf->size) {
595                                 ret = journal_read_buf_realloc(buf,
596                                                         vstruct_bytes(j));
597                                 if (ret)
598                                         return ret;
599                         }
600                         goto reread;
601                 case JOURNAL_ENTRY_NONE:
602                         if (!saw_bad)
603                                 return 0;
604                         sectors = c->opts.block_size;
605                         goto next_block;
606                 case JOURNAL_ENTRY_BAD:
607                         saw_bad = true;
608                         /*
609                          * On checksum error we don't really trust the size
610                          * field of the journal entry we read, so try reading
611                          * again at next block boundary:
612                          */
613                         sectors = c->opts.block_size;
614                         break;
615                 default:
616                         return ret;
617                 }
618
619                 /*
620                  * This happens sometimes if we don't have discards on -
621                  * when we've partially overwritten a bucket with new
622                  * journal entries. We don't need the rest of the
623                  * bucket:
624                  */
625                 if (le64_to_cpu(j->seq) < ja->bucket_seq[bucket])
626                         return 0;
627
628                 ja->bucket_seq[bucket] = le64_to_cpu(j->seq);
629
630                 mutex_lock(&jlist->lock);
631                 ret = journal_entry_add(c, ca, jlist, j, ret != 0);
632                 mutex_unlock(&jlist->lock);
633
634                 switch (ret) {
635                 case JOURNAL_ENTRY_ADD_OK:
636                         break;
637                 case JOURNAL_ENTRY_ADD_OUT_OF_RANGE:
638                         break;
639                 default:
640                         return ret;
641                 }
642 next_block:
643                 pr_debug("next");
644                 offset          += sectors;
645                 sectors_read    -= sectors;
646                 j = ((void *) j) + (sectors << 9);
647         }
648
649         return 0;
650 }
651
652 static void bch2_journal_read_device(struct closure *cl)
653 {
654         struct journal_device *ja =
655                 container_of(cl, struct journal_device, read);
656         struct bch_dev *ca = container_of(ja, struct bch_dev, journal);
657         struct journal_list *jlist =
658                 container_of(cl->parent, struct journal_list, cl);
659         struct journal_read_buf buf = { NULL, 0 };
660         u64 min_seq = U64_MAX;
661         unsigned i;
662         int ret;
663
664         if (!ja->nr)
665                 goto out;
666
667         ret = journal_read_buf_realloc(&buf, PAGE_SIZE);
668         if (ret)
669                 goto err;
670
671         pr_debug("%u journal buckets", ja->nr);
672
673         for (i = 0; i < ja->nr; i++) {
674                 ret = journal_read_bucket(ca, &buf, jlist, i);
675                 if (ret)
676                         goto err;
677         }
678
679         /* Find the journal bucket with the highest sequence number: */
680         for (i = 0; i < ja->nr; i++) {
681                 if (ja->bucket_seq[i] > ja->bucket_seq[ja->cur_idx])
682                         ja->cur_idx = i;
683
684                 min_seq = min(ja->bucket_seq[i], min_seq);
685         }
686
687         /*
688          * If there's duplicate journal entries in multiple buckets (which
689          * definitely isn't supposed to happen, but...) - make sure to start
690          * cur_idx at the last of those buckets, so we don't deadlock trying to
691          * allocate
692          */
693         while (ja->bucket_seq[ja->cur_idx] > min_seq &&
694                ja->bucket_seq[ja->cur_idx] >
695                ja->bucket_seq[(ja->cur_idx + 1) % ja->nr])
696                 ja->cur_idx = (ja->cur_idx + 1) % ja->nr;
697
698         ja->sectors_free = 0;
699
700         /*
701          * Set dirty_idx to indicate the entire journal is full and needs to be
702          * reclaimed - journal reclaim will immediately reclaim whatever isn't
703          * pinned when it first runs:
704          */
705         ja->discard_idx = ja->dirty_idx_ondisk =
706                 ja->dirty_idx = (ja->cur_idx + 1) % ja->nr;
707 out:
708         kvpfree(buf.data, buf.size);
709         percpu_ref_put(&ca->io_ref);
710         closure_return(cl);
711         return;
712 err:
713         mutex_lock(&jlist->lock);
714         jlist->ret = ret;
715         mutex_unlock(&jlist->lock);
716         goto out;
717 }
718
719 int bch2_journal_read(struct bch_fs *c, struct list_head *list,
720                       u64 *blacklist_seq, u64 *start_seq)
721 {
722         struct journal_list jlist;
723         struct journal_replay *i, *t;
724         struct bch_dev *ca;
725         unsigned iter;
726         size_t keys = 0, entries = 0;
727         bool degraded = false;
728         u64 seq, last_seq = 0;
729         int ret = 0;
730
731         closure_init_stack(&jlist.cl);
732         mutex_init(&jlist.lock);
733         jlist.head = list;
734         jlist.ret = 0;
735
736         for_each_member_device(ca, c, iter) {
737                 if (!test_bit(BCH_FS_REBUILD_REPLICAS, &c->flags) &&
738                     !(bch2_dev_has_data(c, ca) & (1 << BCH_DATA_journal)))
739                         continue;
740
741                 if ((ca->mi.state == BCH_MEMBER_STATE_RW ||
742                      ca->mi.state == BCH_MEMBER_STATE_RO) &&
743                     percpu_ref_tryget(&ca->io_ref))
744                         closure_call(&ca->journal.read,
745                                      bch2_journal_read_device,
746                                      system_unbound_wq,
747                                      &jlist.cl);
748                 else
749                         degraded = true;
750         }
751
752         closure_sync(&jlist.cl);
753
754         if (jlist.ret)
755                 return jlist.ret;
756
757         if (list_empty(list)) {
758                 bch_info(c, "journal read done, but no entries found");
759                 return 0;
760         }
761
762         i = list_last_entry(list, struct journal_replay, list);
763         *start_seq = le64_to_cpu(i->j.seq) + 1;
764
765         /*
766          * Find most recent flush entry, and ignore newer non flush entries -
767          * those entries will be blacklisted:
768          */
769         list_for_each_entry_safe_reverse(i, t, list, list) {
770                 if (i->ignore)
771                         continue;
772
773                 if (!JSET_NO_FLUSH(&i->j)) {
774                         last_seq        = le64_to_cpu(i->j.last_seq);
775                         *blacklist_seq  = le64_to_cpu(i->j.seq) + 1;
776                         break;
777                 }
778
779                 journal_replay_free(c, i);
780         }
781
782         if (!last_seq) {
783                 fsck_err(c, "journal read done, but no entries found after dropping non-flushes");
784                 return -1;
785         }
786
787         /* Drop blacklisted entries and entries older than last_seq: */
788         list_for_each_entry_safe(i, t, list, list) {
789                 if (i->ignore)
790                         continue;
791
792                 seq = le64_to_cpu(i->j.seq);
793                 if (seq < last_seq) {
794                         journal_replay_free(c, i);
795                         continue;
796                 }
797
798                 if (bch2_journal_seq_is_blacklisted(c, seq, true)) {
799                         fsck_err_on(!JSET_NO_FLUSH(&i->j), c,
800                                     "found blacklisted journal entry %llu", seq);
801
802                         journal_replay_free(c, i);
803                 }
804         }
805
806         /* Check for missing entries: */
807         seq = last_seq;
808         list_for_each_entry(i, list, list) {
809                 if (i->ignore)
810                         continue;
811
812                 BUG_ON(seq > le64_to_cpu(i->j.seq));
813
814                 while (seq < le64_to_cpu(i->j.seq)) {
815                         u64 missing_start, missing_end;
816
817                         while (seq < le64_to_cpu(i->j.seq) &&
818                                bch2_journal_seq_is_blacklisted(c, seq, false))
819                                 seq++;
820
821                         if (seq == le64_to_cpu(i->j.seq))
822                                 break;
823
824                         missing_start = seq;
825
826                         while (seq < le64_to_cpu(i->j.seq) &&
827                                !bch2_journal_seq_is_blacklisted(c, seq, false))
828                                 seq++;
829
830                         missing_end = seq - 1;
831                         fsck_err(c, "journal entries %llu-%llu missing! (replaying %llu-%llu)",
832                                  missing_start, missing_end,
833                                  last_seq, *blacklist_seq - 1);
834                 }
835
836                 seq++;
837         }
838
839         list_for_each_entry(i, list, list) {
840                 struct jset_entry *entry;
841                 struct bkey_i *k, *_n;
842                 struct bch_replicas_padded replicas;
843                 char buf[80];
844
845                 if (i->ignore)
846                         continue;
847
848                 ret = jset_validate_entries(c, &i->j, READ);
849                 if (ret)
850                         goto fsck_err;
851
852                 /*
853                  * If we're mounting in degraded mode - if we didn't read all
854                  * the devices - this is wrong:
855                  */
856
857                 bch2_devlist_to_replicas(&replicas.e, BCH_DATA_journal, i->devs);
858
859                 if (!degraded &&
860                     (test_bit(BCH_FS_REBUILD_REPLICAS, &c->flags) ||
861                      fsck_err_on(!bch2_replicas_marked(c, &replicas.e), c,
862                                  "superblock not marked as containing replicas %s",
863                                  (bch2_replicas_entry_to_text(&PBUF(buf),
864                                                               &replicas.e), buf)))) {
865                         ret = bch2_mark_replicas(c, &replicas.e);
866                         if (ret)
867                                 return ret;
868                 }
869
870                 for_each_jset_key(k, _n, entry, &i->j)
871                         keys++;
872                 entries++;
873         }
874
875         bch_info(c, "journal read done, %zu keys in %zu entries, seq %llu",
876                  keys, entries, *start_seq);
877
878         if (*start_seq != *blacklist_seq)
879                 bch_info(c, "dropped unflushed entries %llu-%llu",
880                          *blacklist_seq, *start_seq - 1);
881 fsck_err:
882         return ret;
883 }
884
885 /* journal write: */
886
887 static void __journal_write_alloc(struct journal *j,
888                                   struct journal_buf *w,
889                                   struct dev_alloc_list *devs_sorted,
890                                   unsigned sectors,
891                                   unsigned *replicas,
892                                   unsigned replicas_want)
893 {
894         struct bch_fs *c = container_of(j, struct bch_fs, journal);
895         struct journal_device *ja;
896         struct bch_dev *ca;
897         unsigned i;
898
899         if (*replicas >= replicas_want)
900                 return;
901
902         for (i = 0; i < devs_sorted->nr; i++) {
903                 ca = rcu_dereference(c->devs[devs_sorted->devs[i]]);
904                 if (!ca)
905                         continue;
906
907                 ja = &ca->journal;
908
909                 /*
910                  * Check that we can use this device, and aren't already using
911                  * it:
912                  */
913                 if (!ca->mi.durability ||
914                     ca->mi.state != BCH_MEMBER_STATE_RW ||
915                     !ja->nr ||
916                     bch2_bkey_has_device(bkey_i_to_s_c(&w->key),
917                                          ca->dev_idx) ||
918                     sectors > ja->sectors_free)
919                         continue;
920
921                 bch2_dev_stripe_increment(ca, &j->wp.stripe);
922
923                 bch2_bkey_append_ptr(&w->key,
924                         (struct bch_extent_ptr) {
925                                   .offset = bucket_to_sector(ca,
926                                         ja->buckets[ja->cur_idx]) +
927                                         ca->mi.bucket_size -
928                                         ja->sectors_free,
929                                   .dev = ca->dev_idx,
930                 });
931
932                 ja->sectors_free -= sectors;
933                 ja->bucket_seq[ja->cur_idx] = le64_to_cpu(w->data->seq);
934
935                 *replicas += ca->mi.durability;
936
937                 if (*replicas >= replicas_want)
938                         break;
939         }
940 }
941
942 /**
943  * journal_next_bucket - move on to the next journal bucket if possible
944  */
945 static int journal_write_alloc(struct journal *j, struct journal_buf *w,
946                                unsigned sectors)
947 {
948         struct bch_fs *c = container_of(j, struct bch_fs, journal);
949         struct journal_device *ja;
950         struct bch_dev *ca;
951         struct dev_alloc_list devs_sorted;
952         unsigned i, replicas = 0, replicas_want =
953                 READ_ONCE(c->opts.metadata_replicas);
954
955         rcu_read_lock();
956
957         devs_sorted = bch2_dev_alloc_list(c, &j->wp.stripe,
958                                           &c->rw_devs[BCH_DATA_journal]);
959
960         __journal_write_alloc(j, w, &devs_sorted,
961                               sectors, &replicas, replicas_want);
962
963         if (replicas >= replicas_want)
964                 goto done;
965
966         for (i = 0; i < devs_sorted.nr; i++) {
967                 ca = rcu_dereference(c->devs[devs_sorted.devs[i]]);
968                 if (!ca)
969                         continue;
970
971                 ja = &ca->journal;
972
973                 if (sectors > ja->sectors_free &&
974                     sectors <= ca->mi.bucket_size &&
975                     bch2_journal_dev_buckets_available(j, ja,
976                                         journal_space_discarded)) {
977                         ja->cur_idx = (ja->cur_idx + 1) % ja->nr;
978                         ja->sectors_free = ca->mi.bucket_size;
979
980                         /*
981                          * ja->bucket_seq[ja->cur_idx] must always have
982                          * something sensible:
983                          */
984                         ja->bucket_seq[ja->cur_idx] = le64_to_cpu(w->data->seq);
985                 }
986         }
987
988         __journal_write_alloc(j, w, &devs_sorted,
989                               sectors, &replicas, replicas_want);
990 done:
991         rcu_read_unlock();
992
993         return replicas >= c->opts.metadata_replicas_required ? 0 : -EROFS;
994 }
995
996 static void journal_write_compact(struct jset *jset)
997 {
998         struct jset_entry *i, *next, *prev = NULL;
999
1000         /*
1001          * Simple compaction, dropping empty jset_entries (from journal
1002          * reservations that weren't fully used) and merging jset_entries that
1003          * can be.
1004          *
1005          * If we wanted to be really fancy here, we could sort all the keys in
1006          * the jset and drop keys that were overwritten - probably not worth it:
1007          */
1008         vstruct_for_each_safe(jset, i, next) {
1009                 unsigned u64s = le16_to_cpu(i->u64s);
1010
1011                 /* Empty entry: */
1012                 if (!u64s)
1013                         continue;
1014
1015                 /* Can we merge with previous entry? */
1016                 if (prev &&
1017                     i->btree_id == prev->btree_id &&
1018                     i->level    == prev->level &&
1019                     i->type     == prev->type &&
1020                     i->type     == BCH_JSET_ENTRY_btree_keys &&
1021                     le16_to_cpu(prev->u64s) + u64s <= U16_MAX) {
1022                         memmove_u64s_down(vstruct_next(prev),
1023                                           i->_data,
1024                                           u64s);
1025                         le16_add_cpu(&prev->u64s, u64s);
1026                         continue;
1027                 }
1028
1029                 /* Couldn't merge, move i into new position (after prev): */
1030                 prev = prev ? vstruct_next(prev) : jset->start;
1031                 if (i != prev)
1032                         memmove_u64s_down(prev, i, jset_u64s(u64s));
1033         }
1034
1035         prev = prev ? vstruct_next(prev) : jset->start;
1036         jset->u64s = cpu_to_le32((u64 *) prev - jset->_data);
1037 }
1038
1039 static void journal_buf_realloc(struct journal *j, struct journal_buf *buf)
1040 {
1041         /* we aren't holding j->lock: */
1042         unsigned new_size = READ_ONCE(j->buf_size_want);
1043         void *new_buf;
1044
1045         if (buf->buf_size >= new_size)
1046                 return;
1047
1048         new_buf = kvpmalloc(new_size, GFP_NOIO|__GFP_NOWARN);
1049         if (!new_buf)
1050                 return;
1051
1052         memcpy(new_buf, buf->data, buf->buf_size);
1053         kvpfree(buf->data, buf->buf_size);
1054         buf->data       = new_buf;
1055         buf->buf_size   = new_size;
1056 }
1057
1058 static inline struct journal_buf *journal_last_unwritten_buf(struct journal *j)
1059 {
1060         return j->buf + j->reservations.unwritten_idx;
1061 }
1062
1063 static void journal_write_done(struct closure *cl)
1064 {
1065         struct journal *j = container_of(cl, struct journal, io);
1066         struct bch_fs *c = container_of(j, struct bch_fs, journal);
1067         struct journal_buf *w = journal_last_unwritten_buf(j);
1068         struct bch_devs_list devs =
1069                 bch2_bkey_devs(bkey_i_to_s_c(&w->key));
1070         struct bch_replicas_padded replicas;
1071         union journal_res_state old, new;
1072         u64 seq = le64_to_cpu(w->data->seq);
1073         u64 last_seq = le64_to_cpu(w->data->last_seq);
1074         u64 v;
1075         int err = 0;
1076
1077         bch2_time_stats_update(j->write_time, j->write_start_time);
1078
1079         if (!devs.nr) {
1080                 bch_err(c, "unable to write journal to sufficient devices");
1081                 err = -EIO;
1082         } else {
1083                 bch2_devlist_to_replicas(&replicas.e, BCH_DATA_journal, devs);
1084                 if (bch2_mark_replicas(c, &replicas.e))
1085                         err = -EIO;
1086         }
1087
1088         if (err)
1089                 bch2_fatal_error(c);
1090
1091         spin_lock(&j->lock);
1092         if (seq >= j->pin.front)
1093                 journal_seq_pin(j, seq)->devs = devs;
1094
1095         j->seq_ondisk           = seq;
1096         if (err && (!j->err_seq || seq < j->err_seq))
1097                 j->err_seq      = seq;
1098
1099         if (!w->noflush) {
1100                 j->flushed_seq_ondisk = seq;
1101                 j->last_seq_ondisk = last_seq;
1102         }
1103
1104         /*
1105          * Updating last_seq_ondisk may let bch2_journal_reclaim_work() discard
1106          * more buckets:
1107          *
1108          * Must come before signaling write completion, for
1109          * bch2_fs_journal_stop():
1110          */
1111         journal_reclaim_kick(&c->journal);
1112
1113         /* also must come before signalling write completion: */
1114         closure_debug_destroy(cl);
1115
1116         v = atomic64_read(&j->reservations.counter);
1117         do {
1118                 old.v = new.v = v;
1119                 BUG_ON(new.idx == new.unwritten_idx);
1120
1121                 new.unwritten_idx++;
1122         } while ((v = atomic64_cmpxchg(&j->reservations.counter,
1123                                        old.v, new.v)) != old.v);
1124
1125         bch2_journal_space_available(j);
1126
1127         closure_wake_up(&w->wait);
1128         journal_wake(j);
1129
1130         if (test_bit(JOURNAL_NEED_WRITE, &j->flags))
1131                 mod_delayed_work(system_freezable_wq, &j->write_work, 0);
1132         spin_unlock(&j->lock);
1133
1134         if (new.unwritten_idx != new.idx &&
1135             !journal_state_count(new, new.unwritten_idx))
1136                 closure_call(&j->io, bch2_journal_write, system_highpri_wq, NULL);
1137 }
1138
1139 static void journal_write_endio(struct bio *bio)
1140 {
1141         struct bch_dev *ca = bio->bi_private;
1142         struct journal *j = &ca->fs->journal;
1143
1144         if (bch2_dev_io_err_on(bio->bi_status, ca, "journal write error: %s",
1145                                bch2_blk_status_to_str(bio->bi_status)) ||
1146             bch2_meta_write_fault("journal")) {
1147                 struct journal_buf *w = journal_last_unwritten_buf(j);
1148                 unsigned long flags;
1149
1150                 spin_lock_irqsave(&j->err_lock, flags);
1151                 bch2_bkey_drop_device(bkey_i_to_s(&w->key), ca->dev_idx);
1152                 spin_unlock_irqrestore(&j->err_lock, flags);
1153         }
1154
1155         closure_put(&j->io);
1156         percpu_ref_put(&ca->io_ref);
1157 }
1158
1159 void bch2_journal_write(struct closure *cl)
1160 {
1161         struct journal *j = container_of(cl, struct journal, io);
1162         struct bch_fs *c = container_of(j, struct bch_fs, journal);
1163         struct bch_dev *ca;
1164         struct journal_buf *w = journal_last_unwritten_buf(j);
1165         struct jset_entry *start, *end;
1166         struct jset *jset;
1167         struct bio *bio;
1168         struct bch_extent_ptr *ptr;
1169         bool validate_before_checksum = false;
1170         unsigned i, sectors, bytes, u64s;
1171         int ret;
1172
1173         BUG_ON(BCH_SB_CLEAN(c->disk_sb.sb));
1174
1175         journal_buf_realloc(j, w);
1176         jset = w->data;
1177
1178         j->write_start_time = local_clock();
1179
1180         spin_lock(&j->lock);
1181         if (c->sb.features & (1ULL << BCH_FEATURE_journal_no_flush) &&
1182             !w->must_flush &&
1183             (jiffies - j->last_flush_write) < msecs_to_jiffies(j->write_delay_ms) &&
1184             test_bit(JOURNAL_MAY_SKIP_FLUSH, &j->flags)) {
1185                 w->noflush = true;
1186                 SET_JSET_NO_FLUSH(jset, true);
1187                 jset->last_seq = cpu_to_le64(j->last_seq_ondisk);
1188
1189                 j->nr_noflush_writes++;
1190         } else {
1191                 j->last_flush_write = jiffies;
1192                 j->nr_flush_writes++;
1193         }
1194         spin_unlock(&j->lock);
1195
1196         /*
1197          * New btree roots are set by journalling them; when the journal entry
1198          * gets written we have to propagate them to c->btree_roots
1199          *
1200          * But, every journal entry we write has to contain all the btree roots
1201          * (at least for now); so after we copy btree roots to c->btree_roots we
1202          * have to get any missing btree roots and add them to this journal
1203          * entry:
1204          */
1205
1206         bch2_journal_entries_to_btree_roots(c, jset);
1207
1208         start = end = vstruct_last(jset);
1209
1210         end     = bch2_btree_roots_to_journal_entries(c, jset->start, end);
1211
1212         end     = bch2_journal_super_entries_add_common(c, end,
1213                                                 le64_to_cpu(jset->seq));
1214         u64s    = (u64 *) end - (u64 *) start;
1215         BUG_ON(u64s > j->entry_u64s_reserved);
1216
1217         le32_add_cpu(&jset->u64s, u64s);
1218         BUG_ON(vstruct_sectors(jset, c->block_bits) > w->sectors);
1219
1220         journal_write_compact(jset);
1221
1222         jset->read_clock        = cpu_to_le16(c->bucket_clock[READ].hand);
1223         jset->write_clock       = cpu_to_le16(c->bucket_clock[WRITE].hand);
1224         jset->magic             = cpu_to_le64(jset_magic(c));
1225
1226         jset->version           = c->sb.version < bcachefs_metadata_version_new_versioning
1227                 ? cpu_to_le32(BCH_JSET_VERSION_OLD)
1228                 : cpu_to_le32(c->sb.version);
1229
1230         SET_JSET_BIG_ENDIAN(jset, CPU_BIG_ENDIAN);
1231         SET_JSET_CSUM_TYPE(jset, bch2_meta_checksum_type(c));
1232
1233         if (journal_entry_empty(jset))
1234                 j->last_empty_seq = le64_to_cpu(jset->seq);
1235
1236         if (bch2_csum_type_is_encryption(JSET_CSUM_TYPE(jset)))
1237                 validate_before_checksum = true;
1238
1239         if (le32_to_cpu(jset->version) < bcachefs_metadata_version_max)
1240                 validate_before_checksum = true;
1241
1242         if (validate_before_checksum &&
1243             jset_validate_entries(c, jset, WRITE))
1244                 goto err;
1245
1246         bch2_encrypt(c, JSET_CSUM_TYPE(jset), journal_nonce(jset),
1247                     jset->encrypted_start,
1248                     vstruct_end(jset) - (void *) jset->encrypted_start);
1249
1250         jset->csum = csum_vstruct(c, JSET_CSUM_TYPE(jset),
1251                                   journal_nonce(jset), jset);
1252
1253         if (!validate_before_checksum &&
1254             jset_validate_entries(c, jset, WRITE))
1255                 goto err;
1256
1257         sectors = vstruct_sectors(jset, c->block_bits);
1258         BUG_ON(sectors > w->sectors);
1259
1260         bytes = vstruct_bytes(jset);
1261         memset((void *) jset + bytes, 0, (sectors << 9) - bytes);
1262
1263 retry_alloc:
1264         spin_lock(&j->lock);
1265         ret = journal_write_alloc(j, w, sectors);
1266
1267         if (ret && j->can_discard) {
1268                 spin_unlock(&j->lock);
1269                 bch2_journal_do_discards(j);
1270                 goto retry_alloc;
1271         }
1272
1273         /*
1274          * write is allocated, no longer need to account for it in
1275          * bch2_journal_space_available():
1276          */
1277         w->sectors = 0;
1278
1279         /*
1280          * journal entry has been compacted and allocated, recalculate space
1281          * available:
1282          */
1283         bch2_journal_space_available(j);
1284         spin_unlock(&j->lock);
1285
1286         if (ret) {
1287                 bch_err(c, "Unable to allocate journal write");
1288                 bch2_fatal_error(c);
1289                 continue_at(cl, journal_write_done, system_highpri_wq);
1290                 return;
1291         }
1292
1293         /*
1294          * XXX: we really should just disable the entire journal in nochanges
1295          * mode
1296          */
1297         if (c->opts.nochanges)
1298                 goto no_io;
1299
1300         extent_for_each_ptr(bkey_i_to_s_extent(&w->key), ptr) {
1301                 ca = bch_dev_bkey_exists(c, ptr->dev);
1302                 if (!percpu_ref_tryget(&ca->io_ref)) {
1303                         /* XXX: fix this */
1304                         bch_err(c, "missing device for journal write\n");
1305                         continue;
1306                 }
1307
1308                 this_cpu_add(ca->io_done->sectors[WRITE][BCH_DATA_journal],
1309                              sectors);
1310
1311                 bio = ca->journal.bio;
1312                 bio_reset(bio);
1313                 bio_set_dev(bio, ca->disk_sb.bdev);
1314                 bio->bi_iter.bi_sector  = ptr->offset;
1315                 bio->bi_end_io          = journal_write_endio;
1316                 bio->bi_private         = ca;
1317                 bio->bi_opf             = REQ_OP_WRITE|REQ_SYNC|REQ_META;
1318                 if (!JSET_NO_FLUSH(jset))
1319                         bio->bi_opf    |= REQ_PREFLUSH|REQ_FUA;
1320                 bch2_bio_map(bio, jset, sectors << 9);
1321
1322                 trace_journal_write(bio);
1323                 closure_bio_submit(bio, cl);
1324
1325                 ca->journal.bucket_seq[ca->journal.cur_idx] = le64_to_cpu(jset->seq);
1326         }
1327
1328         if (!JSET_NO_FLUSH(jset)) {
1329                 for_each_rw_member(ca, c, i)
1330                         if (journal_flushes_device(ca) &&
1331                             !bch2_bkey_has_device(bkey_i_to_s_c(&w->key), i)) {
1332                                 percpu_ref_get(&ca->io_ref);
1333
1334                                 bio = ca->journal.bio;
1335                                 bio_reset(bio);
1336                                 bio_set_dev(bio, ca->disk_sb.bdev);
1337                                 bio->bi_opf             = REQ_OP_FLUSH;
1338                                 bio->bi_end_io          = journal_write_endio;
1339                                 bio->bi_private         = ca;
1340                                 closure_bio_submit(bio, cl);
1341                         }
1342         }
1343 no_io:
1344         bch2_bucket_seq_cleanup(c);
1345
1346         continue_at(cl, journal_write_done, system_highpri_wq);
1347         return;
1348 err:
1349         bch2_inconsistent_error(c);
1350         continue_at(cl, journal_write_done, system_highpri_wq);
1351 }