]> git.sesse.net Git - vlc/blob - modules/codec/avcodec/dxva2.c
aes3: use lookup table to speed up bit order inversion
[vlc] / modules / codec / avcodec / dxva2.c
1 /*****************************************************************************
2  * dxva2.c: Video Acceleration helpers
3  *****************************************************************************
4  * Copyright (C) 2009 Geoffroy Couprie
5  * Copyright (C) 2009 Laurent Aimar
6  * $Id$
7  *
8  * Authors: Geoffroy Couprie <geal@videolan.org>
9  *          Laurent Aimar <fenrir _AT_ videolan _DOT_ org>
10  *
11  * This program is free software; you can redistribute it and/or modify it
12  * under the terms of the GNU Lesser General Public License as published by
13  * the Free Software Foundation; either version 2.1 of the License, or
14  * (at your option) any later version.
15  *
16  * This program is distributed in the hope that it will be useful,
17  * but WITHOUT ANY WARRANTY; without even the implied warranty of
18  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19  * GNU Lesser General Public License for more details.
20  *
21  * You should have received a copy of the GNU Lesser General Public License
22  * along with this program; if not, write to the Free Software Foundation,
23  * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
24  *****************************************************************************/
25
26 #ifdef HAVE_CONFIG_H
27 # include "config.h"
28 #endif
29
30
31 # if _WIN32_WINNT < 0x600
32 /* dxva2 needs Vista support */
33 #  undef _WIN32_WINNT
34 #  define _WIN32_WINNT 0x600
35 # endif
36
37 #include <assert.h>
38
39 #include <vlc_common.h>
40 #include <vlc_picture.h>
41 #include <vlc_fourcc.h>
42 #include <vlc_cpu.h>
43 #include <vlc_plugin.h>
44
45 #include <libavcodec/avcodec.h>
46 #    define DXVA2API_USE_BITFIELDS
47 #    define COBJMACROS
48 #    include <libavcodec/dxva2.h>
49
50 #include "avcodec.h"
51 #include "va.h"
52 #include "copy.h"
53
54 static int Open(vlc_va_t *, int, const es_format_t *);
55 static void Close(vlc_va_t *);
56
57 vlc_module_begin()
58     set_description(N_("DirectX Video Acceleration (DXVA) 2.0"))
59     set_capability("hw decoder", 50)
60     set_category(CAT_INPUT)
61     set_subcategory(SUBCAT_INPUT_VCODEC)
62     set_callbacks(Open, Close)
63 vlc_module_end()
64
65 #include <windows.h>
66 #include <windowsx.h>
67 #include <ole2.h>
68 #include <commctrl.h>
69 #include <shlwapi.h>
70 #include <d3d9.h>
71 #include <dxva2api.h>
72
73 #include <initguid.h> /* must be last included to not redefine existing GUIDs */
74
75 /* dxva2api.h GUIDs: http://msdn.microsoft.com/en-us/library/windows/desktop/ms697067(v=vs100).aspx
76  * assume that they are declared in dxva2api.h */
77 #define MS_GUID(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8)
78
79 #ifdef __MINGW32__
80 # include <_mingw.h>
81
82 # if !defined(__MINGW64_VERSION_MAJOR)
83 #  undef MS_GUID
84 #  define MS_GUID DEFINE_GUID /* dxva2api.h fails to declare those, redefine as static */
85 #  define DXVA2_E_NEW_VIDEO_DEVICE MAKE_HRESULT(1, 4, 4097)
86 # else
87 #  include <dxva.h>
88 # endif
89
90 #endif /* __MINGW32__ */
91
92 MS_GUID(IID_IDirectXVideoDecoderService, 0xfc51a551, 0xd5e7, 0x11d9, 0xaf,0x55,0x00,0x05,0x4e,0x43,0xff,0x02);
93 MS_GUID(IID_IDirectXVideoAccelerationService, 0xfc51a550, 0xd5e7, 0x11d9, 0xaf,0x55,0x00,0x05,0x4e,0x43,0xff,0x02);
94
95 MS_GUID    (DXVA_NoEncrypt,                         0x1b81bed0, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
96
97 /* Codec capabilities GUID, sorted by codec */
98 MS_GUID    (DXVA2_ModeMPEG2_MoComp,                 0xe6a9f44b, 0x61b0, 0x4563, 0x9e, 0xa4, 0x63, 0xd2, 0xa3, 0xc6, 0xfe, 0x66);
99 MS_GUID    (DXVA2_ModeMPEG2_IDCT,                   0xbf22ad00, 0x03ea, 0x4690, 0x80, 0x77, 0x47, 0x33, 0x46, 0x20, 0x9b, 0x7e);
100 MS_GUID    (DXVA2_ModeMPEG2_VLD,                    0xee27417f, 0x5e28, 0x4e65, 0xbe, 0xea, 0x1d, 0x26, 0xb5, 0x08, 0xad, 0xc9);
101 DEFINE_GUID(DXVA2_ModeMPEG2and1_VLD,                0x86695f12, 0x340e, 0x4f04, 0x9f, 0xd3, 0x92, 0x53, 0xdd, 0x32, 0x74, 0x60);
102 DEFINE_GUID(DXVA2_ModeMPEG1_VLD,                    0x6f3ec719, 0x3735, 0x42cc, 0x80, 0x63, 0x65, 0xcc, 0x3c, 0xb3, 0x66, 0x16);
103
104 MS_GUID    (DXVA2_ModeH264_A,                       0x1b81be64, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
105 MS_GUID    (DXVA2_ModeH264_B,                       0x1b81be65, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
106 MS_GUID    (DXVA2_ModeH264_C,                       0x1b81be66, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
107 MS_GUID    (DXVA2_ModeH264_D,                       0x1b81be67, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
108 MS_GUID    (DXVA2_ModeH264_E,                       0x1b81be68, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
109 MS_GUID    (DXVA2_ModeH264_F,                       0x1b81be69, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
110 DEFINE_GUID(DXVA_ModeH264_VLD_Multiview,            0x9901CCD3, 0xca12, 0x4b7e, 0x86, 0x7a, 0xe2, 0x22, 0x3d, 0x92, 0x55, 0xc3); // MVC
111 DEFINE_GUID(DXVA_ModeH264_VLD_WithFMOASO_NoFGT,     0xd5f04ff9, 0x3418, 0x45d8, 0x95, 0x61, 0x32, 0xa7, 0x6a, 0xae, 0x2d, 0xdd);
112 DEFINE_GUID(DXVADDI_Intel_ModeH264_A,               0x604F8E64, 0x4951, 0x4c54, 0x88, 0xFE, 0xAB, 0xD2, 0x5C, 0x15, 0xB3, 0xD6);
113 DEFINE_GUID(DXVADDI_Intel_ModeH264_C,               0x604F8E66, 0x4951, 0x4c54, 0x88, 0xFE, 0xAB, 0xD2, 0x5C, 0x15, 0xB3, 0xD6);
114 DEFINE_GUID(DXVADDI_Intel_ModeH264_E,               0x604F8E68, 0x4951, 0x4c54, 0x88, 0xFE, 0xAB, 0xD2, 0x5C, 0x15, 0xB3, 0xD6); // DXVA_Intel_H264_NoFGT_ClearVideo
115 DEFINE_GUID(DXVA_ModeH264_VLD_NoFGT_Flash,          0x4245F676, 0x2BBC, 0x4166, 0xa0, 0xBB, 0x54, 0xE7, 0xB8, 0x49, 0xC3, 0x80);
116
117 MS_GUID    (DXVA2_ModeWMV8_A,                       0x1b81be80, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
118 MS_GUID    (DXVA2_ModeWMV8_B,                       0x1b81be81, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
119
120 MS_GUID    (DXVA2_ModeWMV9_A,                       0x1b81be90, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
121 MS_GUID    (DXVA2_ModeWMV9_B,                       0x1b81be91, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
122 MS_GUID    (DXVA2_ModeWMV9_C,                       0x1b81be94, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
123
124 MS_GUID    (DXVA2_ModeVC1_A,                        0x1b81beA0, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
125 MS_GUID    (DXVA2_ModeVC1_B,                        0x1b81beA1, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
126 MS_GUID    (DXVA2_ModeVC1_C,                        0x1b81beA2, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
127 MS_GUID    (DXVA2_ModeVC1_D,                        0x1b81beA3, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
128 DEFINE_GUID(DXVA2_ModeVC1_D2010,                    0x1b81beA4, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5); // August 2010 update
129 DEFINE_GUID(DXVA_Intel_VC1_ClearVideo,              0xBCC5DB6D, 0xA2B6, 0x4AF0, 0xAC, 0xE4, 0xAD, 0xB1, 0xF7, 0x87, 0xBC, 0x89);
130 DEFINE_GUID(DXVA_Intel_VC1_ClearVideo_2,            0xE07EC519, 0xE651, 0x4CD6, 0xAC, 0x84, 0x13, 0x70, 0xCC, 0xEE, 0xC8, 0x51);
131
132 DEFINE_GUID(DXVA_nVidia_MPEG4_ASP,                  0x9947EC6F, 0x689B, 0x11DC, 0xA3, 0x20, 0x00, 0x19, 0xDB, 0xBC, 0x41, 0x84);
133 DEFINE_GUID(DXVA_ModeMPEG4pt2_VLD_Simple,           0xefd64d74, 0xc9e8, 0x41d7, 0xa5, 0xe9, 0xe9, 0xb0, 0xe3, 0x9f, 0xa3, 0x19);
134 DEFINE_GUID(DXVA_ModeMPEG4pt2_VLD_AdvSimple_NoGMC,  0xed418a9f, 0x010d, 0x4eda, 0x9a, 0xe3, 0x9a, 0x65, 0x35, 0x8d, 0x8d, 0x2e);
135 DEFINE_GUID(DXVA_ModeMPEG4pt2_VLD_AdvSimple_GMC,    0xab998b5b, 0x4258, 0x44a9, 0x9f, 0xeb, 0x94, 0xe5, 0x97, 0xa6, 0xba, 0xae);
136 DEFINE_GUID(DXVA_ModeMPEG4pt2_VLD_AdvSimple_Avivo,  0x7C74ADC6, 0xe2ba, 0x4ade, 0x86, 0xde, 0x30, 0xbe, 0xab, 0xb4, 0x0c, 0xc1);
137
138
139 /* */
140 typedef struct {
141     const char   *name;
142     const GUID   *guid;
143     int          codec;
144 } dxva2_mode_t;
145 /* XXX Prefered modes must come first */
146 static const dxva2_mode_t dxva2_modes[] = {
147     /* MPEG-1/2 */
148     { "MPEG-2 variable-length decoder",                                               &DXVA2_ModeMPEG2_VLD,                   CODEC_ID_MPEG2VIDEO },
149     { "MPEG-2 & MPEG-1 variable-length decoder",                                      &DXVA2_ModeMPEG2and1_VLD,               CODEC_ID_MPEG2VIDEO },
150     { "MPEG-2 motion compensation",                                                   &DXVA2_ModeMPEG2_MoComp,                0 },
151     { "MPEG-2 inverse discrete cosine transform",                                     &DXVA2_ModeMPEG2_IDCT,                  0 },
152
153     { "MPEG-1 variable-length decoder",                                               &DXVA2_ModeMPEG1_VLD,                   0 },
154
155     /* H.264 */
156     { "H.264 variable-length decoder, film grain technology",                         &DXVA2_ModeH264_F,                      CODEC_ID_H264 },
157     { "H.264 variable-length decoder, no film grain technology",                      &DXVA2_ModeH264_E,                      CODEC_ID_H264 },
158     { "H.264 variable-length decoder, no film grain technology (Intel ClearVideo)",   &DXVADDI_Intel_ModeH264_E,              CODEC_ID_H264 },
159     { "H.264 variable-length decoder, no film grain technology, FMO/ASO",             &DXVA_ModeH264_VLD_WithFMOASO_NoFGT,    CODEC_ID_H264 },
160     { "H.264 variable-length decoder, no film grain technology, Flash",               &DXVA_ModeH264_VLD_NoFGT_Flash,         CODEC_ID_H264 },
161
162     { "H.264 inverse discrete cosine transform, film grain technology",               &DXVA2_ModeH264_D,                      0 },
163     { "H.264 inverse discrete cosine transform, no film grain technology",            &DXVA2_ModeH264_C,                      0 },
164     { "H.264 inverse discrete cosine transform, no film grain technology (Intel)",    &DXVADDI_Intel_ModeH264_C,              0 },
165
166     { "H.264 motion compensation, film grain technology",                             &DXVA2_ModeH264_B,                      0 },
167     { "H.264 motion compensation, no film grain technology",                          &DXVA2_ModeH264_A,                      0 },
168     { "H.264 motion compensation, no film grain technology (Intel)",                  &DXVADDI_Intel_ModeH264_A,              0 },
169
170     /* WMV */
171     { "Windows Media Video 8 motion compensation",                                    &DXVA2_ModeWMV8_B,                      0 },
172     { "Windows Media Video 8 post processing",                                        &DXVA2_ModeWMV8_A,                      0 },
173
174     { "Windows Media Video 9 IDCT",                                                   &DXVA2_ModeWMV9_C,                      0 },
175     { "Windows Media Video 9 motion compensation",                                    &DXVA2_ModeWMV9_B,                      0 },
176     { "Windows Media Video 9 post processing",                                        &DXVA2_ModeWMV9_A,                      0 },
177
178     /* VC-1 */
179     { "VC-1 variable-length decoder",                                                 &DXVA2_ModeVC1_D,                       CODEC_ID_VC1 },
180     { "VC-1 variable-length decoder",                                                 &DXVA2_ModeVC1_D,                       CODEC_ID_WMV3 },
181     { "VC-1 variable-length decoder",                                                 &DXVA2_ModeVC1_D2010,                   CODEC_ID_VC1 },
182     { "VC-1 variable-length decoder",                                                 &DXVA2_ModeVC1_D2010,                   CODEC_ID_WMV3 },
183     { "VC-1 variable-length decoder 2 (Intel)",                                       &DXVA_Intel_VC1_ClearVideo_2,           0 },
184     { "VC-1 variable-length decoder (Intel)",                                         &DXVA_Intel_VC1_ClearVideo,             0 },
185
186     { "VC-1 inverse discrete cosine transform",                                       &DXVA2_ModeVC1_C,                       0 },
187     { "VC-1 motion compensation",                                                     &DXVA2_ModeVC1_B,                       0 },
188     { "VC-1 post processing",                                                         &DXVA2_ModeVC1_A,                       0 },
189
190     /* Xvid/Divx: TODO */
191     { "MPEG-4 Part 2 nVidia bitstream decoder",                                       &DXVA_nVidia_MPEG4_ASP,                 0 },
192     { "MPEG-4 Part 2 variable-length decoder, Simple Profile",                        &DXVA_ModeMPEG4pt2_VLD_Simple,          0 },
193     { "MPEG-4 Part 2 variable-length decoder, Simple&Advanced Profile, no GMC",       &DXVA_ModeMPEG4pt2_VLD_AdvSimple_NoGMC, 0 },
194     { "MPEG-4 Part 2 variable-length decoder, Simple&Advanced Profile, GMC",          &DXVA_ModeMPEG4pt2_VLD_AdvSimple_GMC,   0 },
195     { "MPEG-4 Part 2 variable-length decoder, Simple&Advanced Profile, Avivo",        &DXVA_ModeMPEG4pt2_VLD_AdvSimple_Avivo, 0 },
196
197     { NULL, NULL, 0 }
198 };
199
200 static const dxva2_mode_t *Dxva2FindMode(const GUID *guid)
201 {
202     for (unsigned i = 0; dxva2_modes[i].name; i++) {
203         if (IsEqualGUID(dxva2_modes[i].guid, guid))
204             return &dxva2_modes[i];
205     }
206     return NULL;
207 }
208
209 /* */
210 typedef struct {
211     const char   *name;
212     D3DFORMAT    format;
213     vlc_fourcc_t codec;
214 } d3d_format_t;
215 /* XXX Prefered format must come first */
216 static const d3d_format_t d3d_formats[] = {
217     { "YV12",   MAKEFOURCC('Y','V','1','2'),    VLC_CODEC_YV12 },
218     { "NV12",   MAKEFOURCC('N','V','1','2'),    VLC_CODEC_NV12 },
219     { "IMC3",   MAKEFOURCC('I','M','C','3'),    VLC_CODEC_YV12 },
220
221     { NULL, 0, 0 }
222 };
223
224 static const d3d_format_t *D3dFindFormat(D3DFORMAT format)
225 {
226     for (unsigned i = 0; d3d_formats[i].name; i++) {
227         if (d3d_formats[i].format == format)
228             return &d3d_formats[i];
229     }
230     return NULL;
231 }
232
233 /* */
234 typedef struct {
235     LPDIRECT3DSURFACE9 d3d;
236     int                refcount;
237     unsigned int       order;
238 } vlc_va_surface_t;
239
240 #define VA_DXVA2_MAX_SURFACE_COUNT (64)
241 struct vlc_va_sys_t
242 {
243     vlc_object_t *log;
244     int          codec_id;
245     int          width;
246     int          height;
247
248     /* DLL */
249     HINSTANCE             hd3d9_dll;
250     HINSTANCE             hdxva2_dll;
251
252     /* Direct3D */
253     D3DPRESENT_PARAMETERS  d3dpp;
254     LPDIRECT3D9            d3dobj;
255     D3DADAPTER_IDENTIFIER9 d3dai;
256     LPDIRECT3DDEVICE9      d3ddev;
257
258     /* Device manager */
259     UINT                     token;
260     IDirect3DDeviceManager9  *devmng;
261     HANDLE                   device;
262
263     /* Video service */
264     IDirectXVideoDecoderService  *vs;
265     GUID                         input;
266     D3DFORMAT                    render;
267
268     /* Video decoder */
269     DXVA2_ConfigPictureDecode    cfg;
270     IDirectXVideoDecoder         *decoder;
271
272     /* Option conversion */
273     D3DFORMAT                    output;
274     copy_cache_t                 surface_cache;
275
276     /* */
277     struct dxva_context hw;
278
279     /* */
280     unsigned     surface_count;
281     unsigned     surface_order;
282     int          surface_width;
283     int          surface_height;
284     vlc_fourcc_t surface_chroma;
285
286     vlc_va_surface_t surface[VA_DXVA2_MAX_SURFACE_COUNT];
287     LPDIRECT3DSURFACE9 hw_surface[VA_DXVA2_MAX_SURFACE_COUNT];
288 };
289 typedef struct vlc_va_sys_t vlc_va_dxva2_t;
290
291 /* */
292 static vlc_va_dxva2_t *vlc_va_dxva2_Get(vlc_va_t *external)
293 {
294     vlc_va_dxva2_t *va = external->sys;
295     assert(VLC_OBJECT(external) == va->log);
296     return va;
297 }
298
299 /* */
300 static int D3dCreateDevice(vlc_va_dxva2_t *);
301 static void D3dDestroyDevice(vlc_va_dxva2_t *);
302 static char *DxDescribe(vlc_va_dxva2_t *);
303
304 static int D3dCreateDeviceManager(vlc_va_dxva2_t *);
305 static void D3dDestroyDeviceManager(vlc_va_dxva2_t *);
306
307 static int DxCreateVideoService(vlc_va_dxva2_t *);
308 static void DxDestroyVideoService(vlc_va_dxva2_t *);
309 static int DxFindVideoServiceConversion(vlc_va_dxva2_t *, GUID *input, D3DFORMAT *output);
310
311 static int DxCreateVideoDecoder(vlc_va_dxva2_t *,
312                                 int codec_id, const video_format_t *);
313 static void DxDestroyVideoDecoder(vlc_va_dxva2_t *);
314 static int DxResetVideoDecoder(vlc_va_dxva2_t *);
315
316 static void DxCreateVideoConversion(vlc_va_dxva2_t *);
317 static void DxDestroyVideoConversion(vlc_va_dxva2_t *);
318
319 /* */
320 static int Setup(vlc_va_t *external, void **hw, vlc_fourcc_t *chroma,
321                  int width, int height)
322 {
323     vlc_va_dxva2_t *va = vlc_va_dxva2_Get(external);
324
325     if (va->width == width && va->height == height && va->decoder)
326         goto ok;
327
328     /* */
329     DxDestroyVideoConversion(va);
330     DxDestroyVideoDecoder(va);
331
332     *hw = NULL;
333     *chroma = 0;
334     if (width <= 0 || height <= 0)
335         return VLC_EGENERIC;
336
337     /* FIXME transmit a video_format_t by VaSetup directly */
338     video_format_t fmt;
339     memset(&fmt, 0, sizeof(fmt));
340     fmt.i_width = width;
341     fmt.i_height = height;
342
343     if (DxCreateVideoDecoder(va, va->codec_id, &fmt))
344         return VLC_EGENERIC;
345     /* */
346     va->hw.decoder = va->decoder;
347     va->hw.cfg = &va->cfg;
348     va->hw.surface_count = va->surface_count;
349     va->hw.surface = va->hw_surface;
350     for (unsigned i = 0; i < va->surface_count; i++)
351         va->hw.surface[i] = va->surface[i].d3d;
352
353     /* */
354     DxCreateVideoConversion(va);
355
356     /* */
357 ok:
358     *hw = &va->hw;
359     const d3d_format_t *output = D3dFindFormat(va->output);
360     *chroma = output->codec;
361
362     return VLC_SUCCESS;
363 }
364
365 static int Extract(vlc_va_t *external, picture_t *picture, AVFrame *ff)
366 {
367     vlc_va_dxva2_t *va = vlc_va_dxva2_Get(external);
368     LPDIRECT3DSURFACE9 d3d = (LPDIRECT3DSURFACE9)(uintptr_t)ff->data[3];
369
370     if (!va->surface_cache.buffer)
371         return VLC_EGENERIC;
372
373     /* */
374     assert(va->output == MAKEFOURCC('Y','V','1','2'));
375
376     /* */
377     D3DLOCKED_RECT lock;
378     if (FAILED(IDirect3DSurface9_LockRect(d3d, &lock, NULL, D3DLOCK_READONLY))) {
379         msg_Err(va->log, "Failed to lock surface");
380         return VLC_EGENERIC;
381     }
382
383     if (va->render == MAKEFOURCC('Y','V','1','2') ||
384         va->render == MAKEFOURCC('I','M','C','3')) {
385         bool imc3 = va->render == MAKEFOURCC('I','M','C','3');
386         size_t chroma_pitch = imc3 ? lock.Pitch : (lock.Pitch / 2);
387
388         size_t pitch[3] = {
389             lock.Pitch,
390             chroma_pitch,
391             chroma_pitch,
392         };
393
394         uint8_t *plane[3] = {
395             (uint8_t*)lock.pBits,
396             (uint8_t*)lock.pBits + pitch[0] * va->surface_height,
397             (uint8_t*)lock.pBits + pitch[0] * va->surface_height
398                                  + pitch[1] * va->surface_height / 2,
399         };
400
401         if (imc3) {
402             uint8_t *V = plane[1];
403             plane[1] = plane[2];
404             plane[2] = V;
405         }
406         CopyFromYv12(picture, plane, pitch,
407                      va->width, va->height,
408                      &va->surface_cache);
409     } else {
410         assert(va->render == MAKEFOURCC('N','V','1','2'));
411         uint8_t *plane[2] = {
412             lock.pBits,
413             (uint8_t*)lock.pBits + lock.Pitch * va->surface_height
414         };
415         size_t  pitch[2] = {
416             lock.Pitch,
417             lock.Pitch,
418         };
419         CopyFromNv12(picture, plane, pitch,
420                      va->width, va->height,
421                      &va->surface_cache);
422     }
423
424     /* */
425     IDirect3DSurface9_UnlockRect(d3d);
426     return VLC_SUCCESS;
427 }
428 /* FIXME it is nearly common with VAAPI */
429 static int Get(vlc_va_t *external, AVFrame *ff)
430 {
431     vlc_va_dxva2_t *va = vlc_va_dxva2_Get(external);
432
433     /* Check the device */
434     HRESULT hr = IDirect3DDeviceManager9_TestDevice(va->devmng, va->device);
435     if (hr == DXVA2_E_NEW_VIDEO_DEVICE) {
436         if (DxResetVideoDecoder(va))
437             return VLC_EGENERIC;
438     } else if (FAILED(hr)) {
439         msg_Err(va->log, "IDirect3DDeviceManager9_TestDevice %u", (unsigned)hr);
440         return VLC_EGENERIC;
441     }
442
443     /* Grab an unused surface, in case none are, try the oldest
444      * XXX using the oldest is a workaround in case a problem happens with libavcodec */
445     unsigned i, old;
446     for (i = 0, old = 0; i < va->surface_count; i++) {
447         vlc_va_surface_t *surface = &va->surface[i];
448
449         if (!surface->refcount)
450             break;
451
452         if (surface->order < va->surface[old].order)
453             old = i;
454     }
455     if (i >= va->surface_count)
456         i = old;
457
458     vlc_va_surface_t *surface = &va->surface[i];
459
460     surface->refcount = 1;
461     surface->order = va->surface_order++;
462
463     /* */
464     for (int i = 0; i < 4; i++) {
465         ff->data[i] = NULL;
466         ff->linesize[i] = 0;
467
468         if (i == 0 || i == 3)
469             ff->data[i] = (void*)surface->d3d;/* Yummie */
470     }
471     return VLC_SUCCESS;
472 }
473 static void Release(vlc_va_t *external, AVFrame *ff)
474 {
475     vlc_va_dxva2_t *va = vlc_va_dxva2_Get(external);
476     LPDIRECT3DSURFACE9 d3d = (LPDIRECT3DSURFACE9)(uintptr_t)ff->data[3];
477
478     for (unsigned i = 0; i < va->surface_count; i++) {
479         vlc_va_surface_t *surface = &va->surface[i];
480
481         if (surface->d3d == d3d)
482             surface->refcount--;
483     }
484 }
485 static void Close(vlc_va_t *external)
486 {
487     vlc_va_dxva2_t *va = vlc_va_dxva2_Get(external);
488
489     DxDestroyVideoConversion(va);
490     DxDestroyVideoDecoder(va);
491     DxDestroyVideoService(va);
492     D3dDestroyDeviceManager(va);
493     D3dDestroyDevice(va);
494
495     if (va->hdxva2_dll)
496         FreeLibrary(va->hdxva2_dll);
497     if (va->hd3d9_dll)
498         FreeLibrary(va->hd3d9_dll);
499
500     free(external->description);
501     free(va);
502 }
503
504 static int Open(vlc_va_t *external, int codec_id, const es_format_t *fmt)
505 {
506     vlc_va_dxva2_t *va = calloc(1, sizeof(*va));
507     if (!va)
508         return NULL;
509
510     external->sys = va;
511     /* */
512     va->log = VLC_OBJECT(external);
513     va->codec_id = codec_id;
514     (void) fmt;
515
516     /* Load dll*/
517     va->hd3d9_dll = LoadLibrary(TEXT("D3D9.DLL"));
518     if (!va->hd3d9_dll) {
519         msg_Warn(va->log, "cannot load d3d9.dll");
520         goto error;
521     }
522     va->hdxva2_dll = LoadLibrary(TEXT("DXVA2.DLL"));
523     if (!va->hdxva2_dll) {
524         msg_Warn(va->log, "cannot load dxva2.dll");
525         goto error;
526     }
527     msg_Dbg(va->log, "DLLs loaded");
528
529     /* */
530     if (D3dCreateDevice(va)) {
531         msg_Err(va->log, "Failed to create Direct3D device");
532         goto error;
533     }
534     msg_Dbg(va->log, "D3dCreateDevice succeed");
535
536     if (D3dCreateDeviceManager(va)) {
537         msg_Err(va->log, "D3dCreateDeviceManager failed");
538         goto error;
539     }
540
541     if (DxCreateVideoService(va)) {
542         msg_Err(va->log, "DxCreateVideoService failed");
543         goto error;
544     }
545
546     /* */
547     if (DxFindVideoServiceConversion(va, &va->input, &va->render)) {
548         msg_Err(va->log, "DxFindVideoServiceConversion failed");
549         goto error;
550     }
551
552     /* TODO print the hardware name/vendor for debugging purposes */
553     external->description = DxDescribe(va);
554     external->pix_fmt = PIX_FMT_DXVA2_VLD;
555     external->setup   = Setup;
556     external->get     = Get;
557     external->release = Release;
558     external->extract = Extract;
559     return VLC_SUCCESS;
560
561 error:
562     Close(va);
563     return VLC_EGENERIC;
564 }
565 /* */
566
567 /**
568  * It creates a Direct3D device usable for DXVA 2
569  */
570 static int D3dCreateDevice(vlc_va_dxva2_t *va)
571 {
572     /* */
573     LPDIRECT3D9 (WINAPI *Create9)(UINT SDKVersion);
574     Create9 = (void *)GetProcAddress(va->hd3d9_dll,
575                                      TEXT("Direct3DCreate9"));
576     if (!Create9) {
577         msg_Err(va->log, "Cannot locate reference to Direct3DCreate9 ABI in DLL");
578         return VLC_EGENERIC;
579     }
580
581     /* */
582     LPDIRECT3D9 d3dobj;
583     d3dobj = Create9(D3D_SDK_VERSION);
584     if (!d3dobj) {
585         msg_Err(va->log, "Direct3DCreate9 failed");
586         return VLC_EGENERIC;
587     }
588     va->d3dobj = d3dobj;
589
590     /* */
591     D3DADAPTER_IDENTIFIER9 *d3dai = &va->d3dai;
592     if (FAILED(IDirect3D9_GetAdapterIdentifier(va->d3dobj,
593                                                D3DADAPTER_DEFAULT, 0, d3dai))) {
594         msg_Warn(va->log, "IDirect3D9_GetAdapterIdentifier failed");
595         ZeroMemory(d3dai, sizeof(*d3dai));
596     }
597
598     /* */
599     D3DPRESENT_PARAMETERS *d3dpp = &va->d3dpp;
600     ZeroMemory(d3dpp, sizeof(*d3dpp));
601     d3dpp->Flags                  = D3DPRESENTFLAG_VIDEO;
602     d3dpp->Windowed               = TRUE;
603     d3dpp->hDeviceWindow          = NULL;
604     d3dpp->SwapEffect             = D3DSWAPEFFECT_DISCARD;
605     d3dpp->MultiSampleType        = D3DMULTISAMPLE_NONE;
606     d3dpp->PresentationInterval   = D3DPRESENT_INTERVAL_DEFAULT;
607     d3dpp->BackBufferCount        = 0;                  /* FIXME what to put here */
608     d3dpp->BackBufferFormat       = D3DFMT_X8R8G8B8;    /* FIXME what to put here */
609     d3dpp->BackBufferWidth        = 0;
610     d3dpp->BackBufferHeight       = 0;
611     d3dpp->EnableAutoDepthStencil = FALSE;
612
613     /* Direct3D needs a HWND to create a device, even without using ::Present
614     this HWND is used to alert Direct3D when there's a change of focus window.
615     For now, use GetDesktopWindow, as it looks harmless */
616     LPDIRECT3DDEVICE9 d3ddev;
617     if (FAILED(IDirect3D9_CreateDevice(d3dobj, D3DADAPTER_DEFAULT,
618                                        D3DDEVTYPE_HAL, GetDesktopWindow(),
619                                        D3DCREATE_SOFTWARE_VERTEXPROCESSING |
620                                        D3DCREATE_MULTITHREADED,
621                                        d3dpp, &d3ddev))) {
622         msg_Err(va->log, "IDirect3D9_CreateDevice failed");
623         return VLC_EGENERIC;
624     }
625     va->d3ddev = d3ddev;
626
627     return VLC_SUCCESS;
628 }
629 /**
630  * It releases a Direct3D device and its resources.
631  */
632 static void D3dDestroyDevice(vlc_va_dxva2_t *va)
633 {
634     if (va->d3ddev)
635         IDirect3DDevice9_Release(va->d3ddev);
636     if (va->d3dobj)
637         IDirect3D9_Release(va->d3dobj);
638 }
639 /**
640  * It describes our Direct3D object
641  */
642 static char *DxDescribe(vlc_va_dxva2_t *va)
643 {
644     static const struct {
645         unsigned id;
646         char     name[32];
647     } vendors [] = {
648         { 0x1002, "ATI" },
649         { 0x10DE, "NVIDIA" },
650         { 0x1106, "VIA" },
651         { 0x8086, "Intel" },
652         { 0x5333, "S3 Graphics" },
653         { 0, "" }
654     };
655     D3DADAPTER_IDENTIFIER9 *id = &va->d3dai;
656
657     const char *vendor = "Unknown";
658     for (int i = 0; vendors[i].id != 0; i++) {
659         if (vendors[i].id == id->VendorId) {
660             vendor = vendors[i].name;
661             break;
662         }
663     }
664
665     char *description;
666     if (asprintf(&description, "DXVA2 (%.*s, vendor %lu(%s), device %lu, revision %lu)",
667                  sizeof(id->Description), id->Description,
668                  id->VendorId, vendor, id->DeviceId, id->Revision) < 0)
669         return NULL;
670     return description;
671 }
672
673 /**
674  * It creates a Direct3D device manager
675  */
676 static int D3dCreateDeviceManager(vlc_va_dxva2_t *va)
677 {
678     HRESULT (WINAPI *CreateDeviceManager9)(UINT *pResetToken,
679                                            IDirect3DDeviceManager9 **);
680     CreateDeviceManager9 =
681       (void *)GetProcAddress(va->hdxva2_dll,
682                              TEXT("DXVA2CreateDirect3DDeviceManager9"));
683
684     if (!CreateDeviceManager9) {
685         msg_Err(va->log, "cannot load function");
686         return VLC_EGENERIC;
687     }
688     msg_Dbg(va->log, "OurDirect3DCreateDeviceManager9 Success!");
689
690     UINT token;
691     IDirect3DDeviceManager9 *devmng;
692     if (FAILED(CreateDeviceManager9(&token, &devmng))) {
693         msg_Err(va->log, " OurDirect3DCreateDeviceManager9 failed");
694         return VLC_EGENERIC;
695     }
696     va->token  = token;
697     va->devmng = devmng;
698     msg_Info(va->log, "obtained IDirect3DDeviceManager9");
699
700     HRESULT hr = IDirect3DDeviceManager9_ResetDevice(devmng, va->d3ddev, token);
701     if (FAILED(hr)) {
702         msg_Err(va->log, "IDirect3DDeviceManager9_ResetDevice failed: %08x", (unsigned)hr);
703         return VLC_EGENERIC;
704     }
705     return VLC_SUCCESS;
706 }
707 /**
708  * It destroys a Direct3D device manager
709  */
710 static void D3dDestroyDeviceManager(vlc_va_dxva2_t *va)
711 {
712     if (va->devmng)
713         IDirect3DDeviceManager9_Release(va->devmng);
714 }
715
716 /**
717  * It creates a DirectX video service
718  */
719 static int DxCreateVideoService(vlc_va_dxva2_t *va)
720 {
721     HRESULT (WINAPI *CreateVideoService)(IDirect3DDevice9 *,
722                                          REFIID riid,
723                                          void **ppService);
724     CreateVideoService =
725       (void *)GetProcAddress(va->hdxva2_dll,
726                              TEXT("DXVA2CreateVideoService"));
727
728     if (!CreateVideoService) {
729         msg_Err(va->log, "cannot load function");
730         return 4;
731     }
732     msg_Info(va->log, "DXVA2CreateVideoService Success!");
733
734     HRESULT hr;
735
736     HANDLE device;
737     hr = IDirect3DDeviceManager9_OpenDeviceHandle(va->devmng, &device);
738     if (FAILED(hr)) {
739         msg_Err(va->log, "OpenDeviceHandle failed");
740         return VLC_EGENERIC;
741     }
742     va->device = device;
743
744     IDirectXVideoDecoderService *vs;
745     hr = IDirect3DDeviceManager9_GetVideoService(va->devmng, device,
746                                                  &IID_IDirectXVideoDecoderService,
747                                                  (void**)&vs);
748     if (FAILED(hr)) {
749         msg_Err(va->log, "GetVideoService failed");
750         return VLC_EGENERIC;
751     }
752     va->vs = vs;
753
754     return VLC_SUCCESS;
755 }
756 /**
757  * It destroys a DirectX video service
758  */
759 static void DxDestroyVideoService(vlc_va_dxva2_t *va)
760 {
761     if (va->device)
762         IDirect3DDeviceManager9_CloseDeviceHandle(va->devmng, va->device);
763     if (va->vs)
764         IDirectXVideoDecoderService_Release(va->vs);
765 }
766 /**
767  * Find the best suited decoder mode GUID and render format.
768  */
769 static int DxFindVideoServiceConversion(vlc_va_dxva2_t *va, GUID *input, D3DFORMAT *output)
770 {
771     /* Retreive supported modes from the decoder service */
772     UINT input_count = 0;
773     GUID *input_list = NULL;
774     if (FAILED(IDirectXVideoDecoderService_GetDecoderDeviceGuids(va->vs,
775                                                                  &input_count,
776                                                                  &input_list))) {
777         msg_Err(va->log, "IDirectXVideoDecoderService_GetDecoderDeviceGuids failed");
778         return VLC_EGENERIC;
779     }
780     for (unsigned i = 0; i < input_count; i++) {
781         const GUID *g = &input_list[i];
782         const dxva2_mode_t *mode = Dxva2FindMode(g);
783         if (mode) {
784             msg_Dbg(va->log, "- '%s' is supported by hardware", mode->name);
785         } else {
786             msg_Warn(va->log, "- Unknown GUID = %08X-%04x-%04x-XXXX",
787                      (unsigned)g->Data1, g->Data2, g->Data3);
788         }
789     }
790
791     /* Try all supported mode by our priority */
792     for (unsigned i = 0; dxva2_modes[i].name; i++) {
793         const dxva2_mode_t *mode = &dxva2_modes[i];
794         if (!mode->codec || mode->codec != va->codec_id)
795             continue;
796
797         /* */
798         bool is_suported = false;
799         for (const GUID *g = &input_list[0]; !is_suported && g < &input_list[input_count]; g++) {
800             is_suported = IsEqualGUID(mode->guid, g);
801         }
802         if (!is_suported)
803             continue;
804
805         /* */
806         msg_Dbg(va->log, "Trying to use '%s' as input", mode->name);
807         UINT      output_count = 0;
808         D3DFORMAT *output_list = NULL;
809         if (FAILED(IDirectXVideoDecoderService_GetDecoderRenderTargets(va->vs, mode->guid,
810                                                                        &output_count,
811                                                                        &output_list))) {
812             msg_Err(va->log, "IDirectXVideoDecoderService_GetDecoderRenderTargets failed");
813             continue;
814         }
815         for (unsigned j = 0; j < output_count; j++) {
816             const D3DFORMAT f = output_list[j];
817             const d3d_format_t *format = D3dFindFormat(f);
818             if (format) {
819                 msg_Dbg(va->log, "%s is supported for output", format->name);
820             } else {
821                 msg_Dbg(va->log, "%d is supported for output (%4.4s)", f, (const char*)&f);
822             }
823         }
824
825         /* */
826         for (unsigned j = 0; d3d_formats[j].name; j++) {
827             const d3d_format_t *format = &d3d_formats[j];
828
829             /* */
830             bool is_suported = false;
831             for (unsigned k = 0; !is_suported && k < output_count; k++) {
832                 is_suported = format->format == output_list[k];
833             }
834             if (!is_suported)
835                 continue;
836
837             /* We have our solution */
838             msg_Dbg(va->log, "Using '%s' to decode to '%s'", mode->name, format->name);
839             *input  = *mode->guid;
840             *output = format->format;
841             CoTaskMemFree(output_list);
842             CoTaskMemFree(input_list);
843             return VLC_SUCCESS;
844         }
845         CoTaskMemFree(output_list);
846     }
847     CoTaskMemFree(input_list);
848     return VLC_EGENERIC;
849 }
850
851 /**
852  * It creates a DXVA2 decoder using the given video format
853  */
854 static int DxCreateVideoDecoder(vlc_va_dxva2_t *va,
855                                 int codec_id, const video_format_t *fmt)
856 {
857     /* */
858     msg_Dbg(va->log, "DxCreateVideoDecoder id %d %dx%d",
859             codec_id, fmt->i_width, fmt->i_height);
860
861     va->width  = fmt->i_width;
862     va->height = fmt->i_height;
863
864     /* Allocates all surfaces needed for the decoder */
865     va->surface_width  = (fmt->i_width  + 15) & ~15;
866     va->surface_height = (fmt->i_height + 15) & ~15;
867     switch (codec_id) {
868     case CODEC_ID_H264:
869         va->surface_count = 16 + 1;
870         break;
871     default:
872         va->surface_count = 2 + 1;
873         break;
874     }
875     LPDIRECT3DSURFACE9 surface_list[VA_DXVA2_MAX_SURFACE_COUNT];
876     if (FAILED(IDirectXVideoDecoderService_CreateSurface(va->vs,
877                                                          va->surface_width,
878                                                          va->surface_height,
879                                                          va->surface_count - 1,
880                                                          va->render,
881                                                          D3DPOOL_DEFAULT,
882                                                          0,
883                                                          DXVA2_VideoDecoderRenderTarget,
884                                                          surface_list,
885                                                          NULL))) {
886         msg_Err(va->log, "IDirectXVideoAccelerationService_CreateSurface failed");
887         va->surface_count = 0;
888         return VLC_EGENERIC;
889     }
890     for (unsigned i = 0; i < va->surface_count; i++) {
891         vlc_va_surface_t *surface = &va->surface[i];
892         surface->d3d = surface_list[i];
893         surface->refcount = 0;
894         surface->order = 0;
895     }
896     msg_Dbg(va->log, "IDirectXVideoAccelerationService_CreateSurface succeed with %d surfaces (%dx%d)",
897             va->surface_count, fmt->i_width, fmt->i_height);
898
899     /* */
900     DXVA2_VideoDesc dsc;
901     ZeroMemory(&dsc, sizeof(dsc));
902     dsc.SampleWidth     = fmt->i_width;
903     dsc.SampleHeight    = fmt->i_height;
904     dsc.Format          = va->render;
905     if (fmt->i_frame_rate > 0 && fmt->i_frame_rate_base > 0) {
906         dsc.InputSampleFreq.Numerator   = fmt->i_frame_rate;
907         dsc.InputSampleFreq.Denominator = fmt->i_frame_rate_base;
908     } else {
909         dsc.InputSampleFreq.Numerator   = 0;
910         dsc.InputSampleFreq.Denominator = 0;
911     }
912     dsc.OutputFrameFreq = dsc.InputSampleFreq;
913     dsc.UABProtectionLevel = FALSE;
914     dsc.Reserved = 0;
915
916     /* FIXME I am unsure we can let unknown everywhere */
917     DXVA2_ExtendedFormat *ext = &dsc.SampleFormat;
918     ext->SampleFormat = 0;//DXVA2_SampleUnknown;
919     ext->VideoChromaSubsampling = 0;//DXVA2_VideoChromaSubsampling_Unknown;
920     ext->NominalRange = 0;//DXVA2_NominalRange_Unknown;
921     ext->VideoTransferMatrix = 0;//DXVA2_VideoTransferMatrix_Unknown;
922     ext->VideoLighting = 0;//DXVA2_VideoLighting_Unknown;
923     ext->VideoPrimaries = 0;//DXVA2_VideoPrimaries_Unknown;
924     ext->VideoTransferFunction = 0;//DXVA2_VideoTransFunc_Unknown;
925
926     /* List all configurations available for the decoder */
927     UINT                      cfg_count = 0;
928     DXVA2_ConfigPictureDecode *cfg_list = NULL;
929     if (FAILED(IDirectXVideoDecoderService_GetDecoderConfigurations(va->vs,
930                                                                     &va->input,
931                                                                     &dsc,
932                                                                     NULL,
933                                                                     &cfg_count,
934                                                                     &cfg_list))) {
935         msg_Err(va->log, "IDirectXVideoDecoderService_GetDecoderConfigurations failed");
936         return VLC_EGENERIC;
937     }
938     msg_Dbg(va->log, "we got %d decoder configurations", cfg_count);
939
940     /* Select the best decoder configuration */
941     int cfg_score = 0;
942     for (unsigned i = 0; i < cfg_count; i++) {
943         const DXVA2_ConfigPictureDecode *cfg = &cfg_list[i];
944
945         /* */
946         msg_Dbg(va->log, "configuration[%d] ConfigBitstreamRaw %d",
947                 i, cfg->ConfigBitstreamRaw);
948
949         /* */
950         int score;
951         if (cfg->ConfigBitstreamRaw == 1)
952             score = 1;
953         else if (codec_id == CODEC_ID_H264 && cfg->ConfigBitstreamRaw == 2)
954             score = 2;
955         else
956             continue;
957         if (IsEqualGUID(&cfg->guidConfigBitstreamEncryption, &DXVA_NoEncrypt))
958             score += 16;
959
960         if (cfg_score < score) {
961             va->cfg = *cfg;
962             cfg_score = score;
963         }
964     }
965     CoTaskMemFree(cfg_list);
966     if (cfg_score <= 0) {
967         msg_Err(va->log, "Failed to find a supported decoder configuration");
968         return VLC_EGENERIC;
969     }
970
971     /* Create the decoder */
972     IDirectXVideoDecoder *decoder;
973     if (FAILED(IDirectXVideoDecoderService_CreateVideoDecoder(va->vs,
974                                                               &va->input,
975                                                               &dsc,
976                                                               &va->cfg,
977                                                               surface_list,
978                                                               va->surface_count,
979                                                               &decoder))) {
980         msg_Err(va->log, "IDirectXVideoDecoderService_CreateVideoDecoder failed");
981         return VLC_EGENERIC;
982     }
983     va->decoder = decoder;
984     msg_Dbg(va->log, "IDirectXVideoDecoderService_CreateVideoDecoder succeed");
985     return VLC_SUCCESS;
986 }
987 static void DxDestroyVideoDecoder(vlc_va_dxva2_t *va)
988 {
989     if (va->decoder)
990         IDirectXVideoDecoder_Release(va->decoder);
991     va->decoder = NULL;
992
993     for (unsigned i = 0; i < va->surface_count; i++)
994         IDirect3DSurface9_Release(va->surface[i].d3d);
995     va->surface_count = 0;
996 }
997 static int DxResetVideoDecoder(vlc_va_dxva2_t *va)
998 {
999     msg_Err(va->log, "DxResetVideoDecoder unimplemented");
1000     return VLC_EGENERIC;
1001 }
1002
1003 static void DxCreateVideoConversion(vlc_va_dxva2_t *va)
1004 {
1005     switch (va->render) {
1006     case MAKEFOURCC('N','V','1','2'):
1007     case MAKEFOURCC('I','M','C','3'):
1008         va->output = MAKEFOURCC('Y','V','1','2');
1009         break;
1010     default:
1011         va->output = va->render;
1012         break;
1013     }
1014     CopyInitCache(&va->surface_cache, va->surface_width);
1015 }
1016 static void DxDestroyVideoConversion(vlc_va_dxva2_t *va)
1017 {
1018     CopyCleanCache(&va->surface_cache);
1019 }