git.sesse.net Git - vlc/blob - modules/codec/avcodec/dxva2.c

   1 /*****************************************************************************
   2  * dxva2.c: Video Acceleration helpers
   3  *****************************************************************************
   4  * Copyright (C) 2009 Geoffroy Couprie
   5  * Copyright (C) 2009 Laurent Aimar
   6  * $Id$
   7  *
   8  * Authors: Geoffroy Couprie <geal@videolan.org>
   9  *          Laurent Aimar <fenrir _AT_ videolan _DOT_ org>
  10  *
  11  * This program is free software; you can redistribute it and/or modify it
  12  * under the terms of the GNU Lesser General Public License as published by
  13  * the Free Software Foundation; either version 2.1 of the License, or
  14  * (at your option) any later version.
  15  *
  16  * This program is distributed in the hope that it will be useful,
  17  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  18  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  19  * GNU Lesser General Public License for more details.
  20  *
  21  * You should have received a copy of the GNU Lesser General Public License
  22  * along with this program; if not, write to the Free Software Foundation,
  23  * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  24  *****************************************************************************/
  25
  26 #ifdef HAVE_CONFIG_H
  27 # include "config.h"
  28 #endif
  29
  30
  31 # if _WIN32_WINNT < 0x600
  32 /* dxva2 needs Vista support */
  33 #  undef _WIN32_WINNT
  34 #  define _WIN32_WINNT 0x600
  35 # endif
  36
  37 #include <assert.h>
  38
  39 #include <vlc_common.h>
  40 #include <vlc_picture.h>
  41 #include <vlc_fourcc.h>
  42 #include <vlc_cpu.h>
  43 #include <vlc_plugin.h>
  44
  45 #include <libavcodec/avcodec.h>
  46 #    define DXVA2API_USE_BITFIELDS
  47 #    define COBJMACROS
  48 #    include <libavcodec/dxva2.h>
  49
  50 #include "avcodec.h"
  51 #include "va.h"
  52 #include "../../video_chroma/copy.h"
  53
  54 static int Open(vlc_va_t *, int, const es_format_t *);
  55 static void Close(vlc_va_t *);
  56
  57 vlc_module_begin()
  58     set_description(N_("DirectX Video Acceleration (DXVA) 2.0"))
  59     set_capability("hw decoder", 0)
  60     set_category(CAT_INPUT)
  61     set_subcategory(SUBCAT_INPUT_VCODEC)
  62     set_callbacks(Open, Close)
  63 vlc_module_end()
  64
  65 #include <windows.h>
  66 #include <windowsx.h>
  67 #include <ole2.h>
  68 #include <commctrl.h>
  69 #include <shlwapi.h>
  70 #include <d3d9.h>
  71 #include <dxva2api.h>
  72
  73 #include <initguid.h> /* must be last included to not redefine existing GUIDs */
  74
  75 /* dxva2api.h GUIDs: http://msdn.microsoft.com/en-us/library/windows/desktop/ms697067(v=vs100).aspx
  76  * assume that they are declared in dxva2api.h */
  77 #define MS_GUID(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8)
  78
  79 #ifdef __MINGW32__
  80 # include <_mingw.h>
  81
  82 # if !defined(__MINGW64_VERSION_MAJOR)
  83 #  undef MS_GUID
  84 #  define MS_GUID DEFINE_GUID /* dxva2api.h fails to declare those, redefine as static */
  85 #  define DXVA2_E_NEW_VIDEO_DEVICE MAKE_HRESULT(1, 4, 4097)
  86 # else
  87 #  include <dxva.h>
  88 # endif
  89
  90 #endif /* __MINGW32__ */
  91
  92 MS_GUID(IID_IDirectXVideoDecoderService, 0xfc51a551, 0xd5e7, 0x11d9, 0xaf,0x55,0x00,0x05,0x4e,0x43,0xff,0x02);
  93 MS_GUID(IID_IDirectXVideoAccelerationService, 0xfc51a550, 0xd5e7, 0x11d9, 0xaf,0x55,0x00,0x05,0x4e,0x43,0xff,0x02);
  94
  95 MS_GUID    (DXVA_NoEncrypt,                         0x1b81bed0, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
  96
  97 /* Codec capabilities GUID, sorted by codec */
  98 MS_GUID    (DXVA2_ModeMPEG2_MoComp,                 0xe6a9f44b, 0x61b0, 0x4563, 0x9e, 0xa4, 0x63, 0xd2, 0xa3, 0xc6, 0xfe, 0x66);
  99 MS_GUID    (DXVA2_ModeMPEG2_IDCT,                   0xbf22ad00, 0x03ea, 0x4690, 0x80, 0x77, 0x47, 0x33, 0x46, 0x20, 0x9b, 0x7e);
 100 MS_GUID    (DXVA2_ModeMPEG2_VLD,                    0xee27417f, 0x5e28, 0x4e65, 0xbe, 0xea, 0x1d, 0x26, 0xb5, 0x08, 0xad, 0xc9);
 101 DEFINE_GUID(DXVA2_ModeMPEG2and1_VLD,                0x86695f12, 0x340e, 0x4f04, 0x9f, 0xd3, 0x92, 0x53, 0xdd, 0x32, 0x74, 0x60);
 102 DEFINE_GUID(DXVA2_ModeMPEG1_VLD,                    0x6f3ec719, 0x3735, 0x42cc, 0x80, 0x63, 0x65, 0xcc, 0x3c, 0xb3, 0x66, 0x16);
 103
 104 MS_GUID    (DXVA2_ModeH264_A,                       0x1b81be64, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 105 MS_GUID    (DXVA2_ModeH264_B,                       0x1b81be65, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 106 MS_GUID    (DXVA2_ModeH264_C,                       0x1b81be66, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 107 MS_GUID    (DXVA2_ModeH264_D,                       0x1b81be67, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 108 MS_GUID    (DXVA2_ModeH264_E,                       0x1b81be68, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 109 MS_GUID    (DXVA2_ModeH264_F,                       0x1b81be69, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 110 DEFINE_GUID(DXVA_ModeH264_VLD_Multiview,            0x9901CCD3, 0xca12, 0x4b7e, 0x86, 0x7a, 0xe2, 0x22, 0x3d, 0x92, 0x55, 0xc3); // MVC
 111 DEFINE_GUID(DXVA_ModeH264_VLD_WithFMOASO_NoFGT,     0xd5f04ff9, 0x3418, 0x45d8, 0x95, 0x61, 0x32, 0xa7, 0x6a, 0xae, 0x2d, 0xdd);
 112 DEFINE_GUID(DXVADDI_Intel_ModeH264_A,               0x604F8E64, 0x4951, 0x4c54, 0x88, 0xFE, 0xAB, 0xD2, 0x5C, 0x15, 0xB3, 0xD6);
 113 DEFINE_GUID(DXVADDI_Intel_ModeH264_C,               0x604F8E66, 0x4951, 0x4c54, 0x88, 0xFE, 0xAB, 0xD2, 0x5C, 0x15, 0xB3, 0xD6);
 114 DEFINE_GUID(DXVADDI_Intel_ModeH264_E,               0x604F8E68, 0x4951, 0x4c54, 0x88, 0xFE, 0xAB, 0xD2, 0x5C, 0x15, 0xB3, 0xD6); // DXVA_Intel_H264_NoFGT_ClearVideo
 115 DEFINE_GUID(DXVA_ModeH264_VLD_NoFGT_Flash,          0x4245F676, 0x2BBC, 0x4166, 0xa0, 0xBB, 0x54, 0xE7, 0xB8, 0x49, 0xC3, 0x80);
 116
 117 MS_GUID    (DXVA2_ModeWMV8_A,                       0x1b81be80, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 118 MS_GUID    (DXVA2_ModeWMV8_B,                       0x1b81be81, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 119
 120 MS_GUID    (DXVA2_ModeWMV9_A,                       0x1b81be90, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 121 MS_GUID    (DXVA2_ModeWMV9_B,                       0x1b81be91, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 122 MS_GUID    (DXVA2_ModeWMV9_C,                       0x1b81be94, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 123
 124 MS_GUID    (DXVA2_ModeVC1_A,                        0x1b81beA0, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 125 MS_GUID    (DXVA2_ModeVC1_B,                        0x1b81beA1, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 126 MS_GUID    (DXVA2_ModeVC1_C,                        0x1b81beA2, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 127 MS_GUID    (DXVA2_ModeVC1_D,                        0x1b81beA3, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
 128 DEFINE_GUID(DXVA2_ModeVC1_D2010,                    0x1b81beA4, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5); // August 2010 update
 129 DEFINE_GUID(DXVA_Intel_VC1_ClearVideo,              0xBCC5DB6D, 0xA2B6, 0x4AF0, 0xAC, 0xE4, 0xAD, 0xB1, 0xF7, 0x87, 0xBC, 0x89);
 130 DEFINE_GUID(DXVA_Intel_VC1_ClearVideo_2,            0xE07EC519, 0xE651, 0x4CD6, 0xAC, 0x84, 0x13, 0x70, 0xCC, 0xEE, 0xC8, 0x51);
 131
 132 DEFINE_GUID(DXVA_nVidia_MPEG4_ASP,                  0x9947EC6F, 0x689B, 0x11DC, 0xA3, 0x20, 0x00, 0x19, 0xDB, 0xBC, 0x41, 0x84);
 133 DEFINE_GUID(DXVA_ModeMPEG4pt2_VLD_Simple,           0xefd64d74, 0xc9e8, 0x41d7, 0xa5, 0xe9, 0xe9, 0xb0, 0xe3, 0x9f, 0xa3, 0x19);
 134 DEFINE_GUID(DXVA_ModeMPEG4pt2_VLD_AdvSimple_NoGMC,  0xed418a9f, 0x010d, 0x4eda, 0x9a, 0xe3, 0x9a, 0x65, 0x35, 0x8d, 0x8d, 0x2e);
 135 DEFINE_GUID(DXVA_ModeMPEG4pt2_VLD_AdvSimple_GMC,    0xab998b5b, 0x4258, 0x44a9, 0x9f, 0xeb, 0x94, 0xe5, 0x97, 0xa6, 0xba, 0xae);
 136 DEFINE_GUID(DXVA_ModeMPEG4pt2_VLD_AdvSimple_Avivo,  0x7C74ADC6, 0xe2ba, 0x4ade, 0x86, 0xde, 0x30, 0xbe, 0xab, 0xb4, 0x0c, 0xc1);
 137
 138
 139 /* */
 140 typedef struct {
 141     const char   *name;
 142     const GUID   *guid;
 143     int          codec;
 144 } dxva2_mode_t;
 145 /* XXX Prefered modes must come first */
 146 static const dxva2_mode_t dxva2_modes[] = {
 147     /* MPEG-1/2 */
 148     { "MPEG-2 variable-length decoder",                                               &DXVA2_ModeMPEG2_VLD,                   AV_CODEC_ID_MPEG2VIDEO },
 149     { "MPEG-2 & MPEG-1 variable-length decoder",                                      &DXVA2_ModeMPEG2and1_VLD,               AV_CODEC_ID_MPEG2VIDEO },
 150     { "MPEG-2 motion compensation",                                                   &DXVA2_ModeMPEG2_MoComp,                0 },
 151     { "MPEG-2 inverse discrete cosine transform",                                     &DXVA2_ModeMPEG2_IDCT,                  0 },
 152
 153     { "MPEG-1 variable-length decoder",                                               &DXVA2_ModeMPEG1_VLD,                   0 },
 154
 155     /* H.264 */
 156     { "H.264 variable-length decoder, film grain technology",                         &DXVA2_ModeH264_F,                      AV_CODEC_ID_H264 },
 157     { "H.264 variable-length decoder, no film grain technology (Intel ClearVideo)",   &DXVADDI_Intel_ModeH264_E,              AV_CODEC_ID_H264 },
 158     { "H.264 variable-length decoder, no film grain technology",                      &DXVA2_ModeH264_E,                      AV_CODEC_ID_H264 },
 159     { "H.264 variable-length decoder, no film grain technology, FMO/ASO",             &DXVA_ModeH264_VLD_WithFMOASO_NoFGT,    AV_CODEC_ID_H264 },
 160     { "H.264 variable-length decoder, no film grain technology, Flash",               &DXVA_ModeH264_VLD_NoFGT_Flash,         AV_CODEC_ID_H264 },
 161
 162     { "H.264 inverse discrete cosine transform, film grain technology",               &DXVA2_ModeH264_D,                      0 },
 163     { "H.264 inverse discrete cosine transform, no film grain technology",            &DXVA2_ModeH264_C,                      0 },
 164     { "H.264 inverse discrete cosine transform, no film grain technology (Intel)",    &DXVADDI_Intel_ModeH264_C,              0 },
 165
 166     { "H.264 motion compensation, film grain technology",                             &DXVA2_ModeH264_B,                      0 },
 167     { "H.264 motion compensation, no film grain technology",                          &DXVA2_ModeH264_A,                      0 },
 168     { "H.264 motion compensation, no film grain technology (Intel)",                  &DXVADDI_Intel_ModeH264_A,              0 },
 169
 170     /* WMV */
 171     { "Windows Media Video 8 motion compensation",                                    &DXVA2_ModeWMV8_B,                      0 },
 172     { "Windows Media Video 8 post processing",                                        &DXVA2_ModeWMV8_A,                      0 },
 173
 174     { "Windows Media Video 9 IDCT",                                                   &DXVA2_ModeWMV9_C,                      0 },
 175     { "Windows Media Video 9 motion compensation",                                    &DXVA2_ModeWMV9_B,                      0 },
 176     { "Windows Media Video 9 post processing",                                        &DXVA2_ModeWMV9_A,                      0 },
 177
 178     /* VC-1 */
 179     { "VC-1 variable-length decoder",                                                 &DXVA2_ModeVC1_D,                       AV_CODEC_ID_VC1 },
 180     { "VC-1 variable-length decoder",                                                 &DXVA2_ModeVC1_D,                       AV_CODEC_ID_WMV3 },
 181     { "VC-1 variable-length decoder",                                                 &DXVA2_ModeVC1_D2010,                   AV_CODEC_ID_VC1 },
 182     { "VC-1 variable-length decoder",                                                 &DXVA2_ModeVC1_D2010,                   AV_CODEC_ID_WMV3 },
 183     { "VC-1 variable-length decoder 2 (Intel)",                                       &DXVA_Intel_VC1_ClearVideo_2,           0 },
 184     { "VC-1 variable-length decoder (Intel)",                                         &DXVA_Intel_VC1_ClearVideo,             0 },
 185
 186     { "VC-1 inverse discrete cosine transform",                                       &DXVA2_ModeVC1_C,                       0 },
 187     { "VC-1 motion compensation",                                                     &DXVA2_ModeVC1_B,                       0 },
 188     { "VC-1 post processing",                                                         &DXVA2_ModeVC1_A,                       0 },
 189
 190     /* Xvid/Divx: TODO */
 191     { "MPEG-4 Part 2 nVidia bitstream decoder",                                       &DXVA_nVidia_MPEG4_ASP,                 0 },
 192     { "MPEG-4 Part 2 variable-length decoder, Simple Profile",                        &DXVA_ModeMPEG4pt2_VLD_Simple,          0 },
 193     { "MPEG-4 Part 2 variable-length decoder, Simple&Advanced Profile, no GMC",       &DXVA_ModeMPEG4pt2_VLD_AdvSimple_NoGMC, 0 },
 194     { "MPEG-4 Part 2 variable-length decoder, Simple&Advanced Profile, GMC",          &DXVA_ModeMPEG4pt2_VLD_AdvSimple_GMC,   0 },
 195     { "MPEG-4 Part 2 variable-length decoder, Simple&Advanced Profile, Avivo",        &DXVA_ModeMPEG4pt2_VLD_AdvSimple_Avivo, 0 },
 196
 197     { NULL, NULL, 0 }
 198 };
 199
 200 static const dxva2_mode_t *Dxva2FindMode(const GUID *guid)
 201 {
 202     for (unsigned i = 0; dxva2_modes[i].name; i++) {
 203         if (IsEqualGUID(dxva2_modes[i].guid, guid))
 204             return &dxva2_modes[i];
 205     }
 206     return NULL;
 207 }
 208
 209 /* */
 210 typedef struct {
 211     const char   *name;
 212     D3DFORMAT    format;
 213     vlc_fourcc_t codec;
 214 } d3d_format_t;
 215 /* XXX Prefered format must come first */
 216 static const d3d_format_t d3d_formats[] = {
 217     { "YV12",   MAKEFOURCC('Y','V','1','2'),    VLC_CODEC_YV12 },
 218     { "NV12",   MAKEFOURCC('N','V','1','2'),    VLC_CODEC_NV12 },
 219     { "IMC3",   MAKEFOURCC('I','M','C','3'),    VLC_CODEC_YV12 },
 220
 221     { NULL, 0, 0 }
 222 };
 223
 224 static const d3d_format_t *D3dFindFormat(D3DFORMAT format)
 225 {
 226     for (unsigned i = 0; d3d_formats[i].name; i++) {
 227         if (d3d_formats[i].format == format)
 228             return &d3d_formats[i];
 229     }
 230     return NULL;
 231 }
 232
 233 /* */
 234 typedef struct {
 235     LPDIRECT3DSURFACE9 d3d;
 236     int                refcount;
 237     unsigned int       order;
 238 } vlc_va_surface_t;
 239
 240 #define VA_DXVA2_MAX_SURFACE_COUNT (64)
 241 struct vlc_va_sys_t
 242 {
 243     vlc_object_t *log;
 244     int          codec_id;
 245     int          width;
 246     int          height;
 247
 248     /* DLL */
 249     HINSTANCE             hd3d9_dll;
 250     HINSTANCE             hdxva2_dll;
 251
 252     /* Direct3D */
 253     D3DPRESENT_PARAMETERS  d3dpp;
 254     LPDIRECT3D9            d3dobj;
 255     D3DADAPTER_IDENTIFIER9 d3dai;
 256     LPDIRECT3DDEVICE9      d3ddev;
 257
 258     /* Device manager */
 259     UINT                     token;
 260     IDirect3DDeviceManager9  *devmng;
 261     HANDLE                   device;
 262
 263     /* Video service */
 264     IDirectXVideoDecoderService  *vs;
 265     GUID                         input;
 266     D3DFORMAT                    render;
 267
 268     /* Video decoder */
 269     DXVA2_ConfigPictureDecode    cfg;
 270     IDirectXVideoDecoder         *decoder;
 271
 272     /* Option conversion */
 273     D3DFORMAT                    output;
 274     copy_cache_t                 surface_cache;
 275
 276     /* */
 277     struct dxva_context hw;
 278
 279     /* */
 280     unsigned     surface_count;
 281     unsigned     surface_order;
 282     int          surface_width;
 283     int          surface_height;
 284     vlc_fourcc_t surface_chroma;
 285
 286     vlc_va_surface_t surface[VA_DXVA2_MAX_SURFACE_COUNT];
 287     LPDIRECT3DSURFACE9 hw_surface[VA_DXVA2_MAX_SURFACE_COUNT];
 288 };
 289 typedef struct vlc_va_sys_t vlc_va_dxva2_t;
 290
 291 /* */
 292 static vlc_va_dxva2_t *vlc_va_dxva2_Get(vlc_va_t *external)
 293 {
 294     vlc_va_dxva2_t *va = external->sys;
 295     assert(VLC_OBJECT(external) == va->log);
 296     return va;
 297 }
 298
 299 /* */
 300 static int D3dCreateDevice(vlc_va_dxva2_t *);
 301 static void D3dDestroyDevice(vlc_va_dxva2_t *);
 302 static char *DxDescribe(vlc_va_dxva2_t *);
 303
 304 static int D3dCreateDeviceManager(vlc_va_dxva2_t *);
 305 static void D3dDestroyDeviceManager(vlc_va_dxva2_t *);
 306
 307 static int DxCreateVideoService(vlc_va_dxva2_t *);
 308 static void DxDestroyVideoService(vlc_va_dxva2_t *);
 309 static int DxFindVideoServiceConversion(vlc_va_dxva2_t *, GUID *input, D3DFORMAT *output);
 310
 311 static int DxCreateVideoDecoder(vlc_va_dxva2_t *,
 312                                 int codec_id, const video_format_t *);
 313 static void DxDestroyVideoDecoder(vlc_va_dxva2_t *);
 314 static int DxResetVideoDecoder(vlc_va_dxva2_t *);
 315
 316 static void DxCreateVideoConversion(vlc_va_dxva2_t *);
 317 static void DxDestroyVideoConversion(vlc_va_dxva2_t *);
 318
 319 /* */
 320 static int Setup(vlc_va_t *external, void **hw, vlc_fourcc_t *chroma,
 321                  int width, int height)
 322 {
 323     vlc_va_dxva2_t *va = vlc_va_dxva2_Get(external);
 324
 325     if (va->width == width && va->height == height && va->decoder)
 326         goto ok;
 327
 328     /* */
 329     DxDestroyVideoConversion(va);
 330     DxDestroyVideoDecoder(va);
 331
 332     *hw = NULL;
 333     *chroma = 0;
 334     if (width <= 0 || height <= 0)
 335         return VLC_EGENERIC;
 336
 337     /* FIXME transmit a video_format_t by VaSetup directly */
 338     video_format_t fmt;
 339     memset(&fmt, 0, sizeof(fmt));
 340     fmt.i_width = width;
 341     fmt.i_height = height;
 342
 343     if (DxCreateVideoDecoder(va, va->codec_id, &fmt))
 344         return VLC_EGENERIC;
 345     /* */
 346     va->hw.decoder = va->decoder;
 347     va->hw.cfg = &va->cfg;
 348     va->hw.surface_count = va->surface_count;
 349     va->hw.surface = va->hw_surface;
 350     for (unsigned i = 0; i < va->surface_count; i++)
 351         va->hw.surface[i] = va->surface[i].d3d;
 352
 353     /* */
 354     DxCreateVideoConversion(va);
 355
 356     /* */
 357 ok:
 358     *hw = &va->hw;
 359     const d3d_format_t *output = D3dFindFormat(va->output);
 360     *chroma = output->codec;
 361
 362     return VLC_SUCCESS;
 363 }
 364
 365 static int Extract(vlc_va_t *external, picture_t *picture, void *opaque,
 366                     uint8_t *data)
 367 {
 368     vlc_va_dxva2_t *va = vlc_va_dxva2_Get(external);
 369     LPDIRECT3DSURFACE9 d3d = (LPDIRECT3DSURFACE9)(uintptr_t)data;
 370
 371     if (!va->surface_cache.buffer)
 372         return VLC_EGENERIC;
 373
 374     /* */
 375     assert(va->output == MAKEFOURCC('Y','V','1','2'));
 376
 377     /* */
 378     D3DLOCKED_RECT lock;
 379     if (FAILED(IDirect3DSurface9_LockRect(d3d, &lock, NULL, D3DLOCK_READONLY))) {
 380         msg_Err(va->log, "Failed to lock surface");
 381         return VLC_EGENERIC;
 382     }
 383
 384     if (va->render == MAKEFOURCC('Y','V','1','2') ||
 385         va->render == MAKEFOURCC('I','M','C','3')) {
 386         bool imc3 = va->render == MAKEFOURCC('I','M','C','3');
 387         size_t chroma_pitch = imc3 ? lock.Pitch : (lock.Pitch / 2);
 388
 389         size_t pitch[3] = {
 390             lock.Pitch,
 391             chroma_pitch,
 392             chroma_pitch,
 393         };
 394
 395         uint8_t *plane[3] = {
 396             (uint8_t*)lock.pBits,
 397             (uint8_t*)lock.pBits + pitch[0] * va->surface_height,
 398             (uint8_t*)lock.pBits + pitch[0] * va->surface_height
 399                                  + pitch[1] * va->surface_height / 2,
 400         };
 401
 402         if (imc3) {
 403             uint8_t *V = plane[1];
 404             plane[1] = plane[2];
 405             plane[2] = V;
 406         }
 407         CopyFromYv12(picture, plane, pitch,
 408                      va->width, va->height,
 409                      &va->surface_cache);
 410     } else {
 411         assert(va->render == MAKEFOURCC('N','V','1','2'));
 412         uint8_t *plane[2] = {
 413             lock.pBits,
 414             (uint8_t*)lock.pBits + lock.Pitch * va->surface_height
 415         };
 416         size_t  pitch[2] = {
 417             lock.Pitch,
 418             lock.Pitch,
 419         };
 420         CopyFromNv12(picture, plane, pitch,
 421                      va->width, va->height,
 422                      &va->surface_cache);
 423     }
 424
 425     /* */
 426     IDirect3DSurface9_UnlockRect(d3d);
 427     (void) opaque;
 428     return VLC_SUCCESS;
 429 }
 430
 431 /* FIXME it is nearly common with VAAPI */
 432 static int Get(vlc_va_t *external, void **opaque, uint8_t **data)
 433 {
 434     vlc_va_dxva2_t *va = vlc_va_dxva2_Get(external);
 435
 436     /* Check the device */
 437     HRESULT hr = IDirect3DDeviceManager9_TestDevice(va->devmng, va->device);
 438     if (hr == DXVA2_E_NEW_VIDEO_DEVICE) {
 439         if (DxResetVideoDecoder(va))
 440             return VLC_EGENERIC;
 441     } else if (FAILED(hr)) {
 442         msg_Err(va->log, "IDirect3DDeviceManager9_TestDevice %u", (unsigned)hr);
 443         return VLC_EGENERIC;
 444     }
 445
 446     /* Grab an unused surface, in case none are, try the oldest
 447      * XXX using the oldest is a workaround in case a problem happens with libavcodec */
 448     unsigned i, old;
 449     for (i = 0, old = 0; i < va->surface_count; i++) {
 450         vlc_va_surface_t *surface = &va->surface[i];
 451
 452         if (!surface->refcount)
 453             break;
 454
 455         if (surface->order < va->surface[old].order)
 456             old = i;
 457     }
 458     if (i >= va->surface_count)
 459         i = old;
 460
 461     vlc_va_surface_t *surface = &va->surface[i];
 462
 463     surface->refcount = 1;
 464     surface->order = va->surface_order++;
 465     *data = (void *)surface->d3d;
 466     *opaque = surface;
 467     return VLC_SUCCESS;
 468 }
 469
 470 static void Release(void *opaque, uint8_t *data)
 471 {
 472     vlc_va_surface_t *surface = opaque;
 473
 474     surface->refcount--;
 475     (void) data;
 476 }
 477
 478 static void Close(vlc_va_t *external)
 479 {
 480     vlc_va_dxva2_t *va = vlc_va_dxva2_Get(external);
 481
 482     DxDestroyVideoConversion(va);
 483     DxDestroyVideoDecoder(va);
 484     DxDestroyVideoService(va);
 485     D3dDestroyDeviceManager(va);
 486     D3dDestroyDevice(va);
 487
 488     if (va->hdxva2_dll)
 489         FreeLibrary(va->hdxva2_dll);
 490     if (va->hd3d9_dll)
 491         FreeLibrary(va->hd3d9_dll);
 492
 493     free(external->description);
 494     free(va);
 495 }
 496
 497 static int Open(vlc_va_t *external, int codec_id, const es_format_t *fmt)
 498 {
 499     vlc_va_dxva2_t *va = calloc(1, sizeof(*va));
 500     if (!va)
 501         return VLC_EGENERIC;
 502
 503     external->sys = va;
 504     /* */
 505     va->log = VLC_OBJECT(external);
 506     va->codec_id = codec_id;
 507     (void) fmt;
 508
 509     /* Load dll*/
 510     va->hd3d9_dll = LoadLibrary(TEXT("D3D9.DLL"));
 511     if (!va->hd3d9_dll) {
 512         msg_Warn(va->log, "cannot load d3d9.dll");
 513         goto error;
 514     }
 515     va->hdxva2_dll = LoadLibrary(TEXT("DXVA2.DLL"));
 516     if (!va->hdxva2_dll) {
 517         msg_Warn(va->log, "cannot load dxva2.dll");
 518         goto error;
 519     }
 520     msg_Dbg(va->log, "DLLs loaded");
 521
 522     /* */
 523     if (D3dCreateDevice(va)) {
 524         msg_Err(va->log, "Failed to create Direct3D device");
 525         goto error;
 526     }
 527     msg_Dbg(va->log, "D3dCreateDevice succeed");
 528
 529     if (D3dCreateDeviceManager(va)) {
 530         msg_Err(va->log, "D3dCreateDeviceManager failed");
 531         goto error;
 532     }
 533
 534     if (DxCreateVideoService(va)) {
 535         msg_Err(va->log, "DxCreateVideoService failed");
 536         goto error;
 537     }
 538
 539     /* */
 540     if (DxFindVideoServiceConversion(va, &va->input, &va->render)) {
 541         msg_Err(va->log, "DxFindVideoServiceConversion failed");
 542         goto error;
 543     }
 544
 545     /* TODO print the hardware name/vendor for debugging purposes */
 546     external->description = DxDescribe(va);
 547     external->pix_fmt = PIX_FMT_DXVA2_VLD;
 548     external->setup   = Setup;
 549     external->get     = Get;
 550     external->release = Release;
 551     external->extract = Extract;
 552     return VLC_SUCCESS;
 553
 554 error:
 555     Close(external);
 556     return VLC_EGENERIC;
 557 }
 558 /* */
 559
 560 /**
 561  * It creates a Direct3D device usable for DXVA 2
 562  */
 563 static int D3dCreateDevice(vlc_va_dxva2_t *va)
 564 {
 565     /* */
 566     LPDIRECT3D9 (WINAPI *Create9)(UINT SDKVersion);
 567     Create9 = (void *)GetProcAddress(va->hd3d9_dll,
 568                                      "Direct3DCreate9");
 569     if (!Create9) {
 570         msg_Err(va->log, "Cannot locate reference to Direct3DCreate9 ABI in DLL");
 571         return VLC_EGENERIC;
 572     }
 573
 574     /* */
 575     LPDIRECT3D9 d3dobj;
 576     d3dobj = Create9(D3D_SDK_VERSION);
 577     if (!d3dobj) {
 578         msg_Err(va->log, "Direct3DCreate9 failed");
 579         return VLC_EGENERIC;
 580     }
 581     va->d3dobj = d3dobj;
 582
 583     /* */
 584     D3DADAPTER_IDENTIFIER9 *d3dai = &va->d3dai;
 585     if (FAILED(IDirect3D9_GetAdapterIdentifier(va->d3dobj,
 586                                                D3DADAPTER_DEFAULT, 0, d3dai))) {
 587         msg_Warn(va->log, "IDirect3D9_GetAdapterIdentifier failed");
 588         ZeroMemory(d3dai, sizeof(*d3dai));
 589     }
 590
 591     /* */
 592     D3DPRESENT_PARAMETERS *d3dpp = &va->d3dpp;
 593     ZeroMemory(d3dpp, sizeof(*d3dpp));
 594     d3dpp->Flags                  = D3DPRESENTFLAG_VIDEO;
 595     d3dpp->Windowed               = TRUE;
 596     d3dpp->hDeviceWindow          = NULL;
 597     d3dpp->SwapEffect             = D3DSWAPEFFECT_DISCARD;
 598     d3dpp->MultiSampleType        = D3DMULTISAMPLE_NONE;
 599     d3dpp->PresentationInterval   = D3DPRESENT_INTERVAL_DEFAULT;
 600     d3dpp->BackBufferCount        = 0;                  /* FIXME what to put here */
 601     d3dpp->BackBufferFormat       = D3DFMT_X8R8G8B8;    /* FIXME what to put here */
 602     d3dpp->BackBufferWidth        = 0;
 603     d3dpp->BackBufferHeight       = 0;
 604     d3dpp->EnableAutoDepthStencil = FALSE;
 605
 606     /* Direct3D needs a HWND to create a device, even without using ::Present
 607     this HWND is used to alert Direct3D when there's a change of focus window.
 608     For now, use GetDesktopWindow, as it looks harmless */
 609     LPDIRECT3DDEVICE9 d3ddev;
 610     if (FAILED(IDirect3D9_CreateDevice(d3dobj, D3DADAPTER_DEFAULT,
 611                                        D3DDEVTYPE_HAL, GetDesktopWindow(),
 612                                        D3DCREATE_SOFTWARE_VERTEXPROCESSING |
 613                                        D3DCREATE_MULTITHREADED,
 614                                        d3dpp, &d3ddev))) {
 615         msg_Err(va->log, "IDirect3D9_CreateDevice failed");
 616         return VLC_EGENERIC;
 617     }
 618     va->d3ddev = d3ddev;
 619
 620     return VLC_SUCCESS;
 621 }
 622 /**
 623  * It releases a Direct3D device and its resources.
 624  */
 625 static void D3dDestroyDevice(vlc_va_dxva2_t *va)
 626 {
 627     if (va->d3ddev)
 628         IDirect3DDevice9_Release(va->d3ddev);
 629     if (va->d3dobj)
 630         IDirect3D9_Release(va->d3dobj);
 631 }
 632 /**
 633  * It describes our Direct3D object
 634  */
 635 static char *DxDescribe(vlc_va_dxva2_t *va)
 636 {
 637     static const struct {
 638         unsigned id;
 639         char     name[32];
 640     } vendors [] = {
 641         { 0x1002, "ATI" },
 642         { 0x10DE, "NVIDIA" },
 643         { 0x1106, "VIA" },
 644         { 0x8086, "Intel" },
 645         { 0x5333, "S3 Graphics" },
 646         { 0, "" }
 647     };
 648     D3DADAPTER_IDENTIFIER9 *id = &va->d3dai;
 649
 650     const char *vendor = "Unknown";
 651     for (int i = 0; vendors[i].id != 0; i++) {
 652         if (vendors[i].id == id->VendorId) {
 653             vendor = vendors[i].name;
 654             break;
 655         }
 656     }
 657
 658     char *description;
 659     if (asprintf(&description, "DXVA2 (%.*s, vendor %lu(%s), device %lu, revision %lu)",
 660                  sizeof(id->Description), id->Description,
 661                  id->VendorId, vendor, id->DeviceId, id->Revision) < 0)
 662         return NULL;
 663     return description;
 664 }
 665
 666 /**
 667  * It creates a Direct3D device manager
 668  */
 669 static int D3dCreateDeviceManager(vlc_va_dxva2_t *va)
 670 {
 671     HRESULT (WINAPI *CreateDeviceManager9)(UINT *pResetToken,
 672                                            IDirect3DDeviceManager9 **);
 673     CreateDeviceManager9 =
 674       (void *)GetProcAddress(va->hdxva2_dll,
 675                              "DXVA2CreateDirect3DDeviceManager9");
 676
 677     if (!CreateDeviceManager9) {
 678         msg_Err(va->log, "cannot load function");
 679         return VLC_EGENERIC;
 680     }
 681     msg_Dbg(va->log, "OurDirect3DCreateDeviceManager9 Success!");
 682
 683     UINT token;
 684     IDirect3DDeviceManager9 *devmng;
 685     if (FAILED(CreateDeviceManager9(&token, &devmng))) {
 686         msg_Err(va->log, " OurDirect3DCreateDeviceManager9 failed");
 687         return VLC_EGENERIC;
 688     }
 689     va->token  = token;
 690     va->devmng = devmng;
 691     msg_Info(va->log, "obtained IDirect3DDeviceManager9");
 692
 693     HRESULT hr = IDirect3DDeviceManager9_ResetDevice(devmng, va->d3ddev, token);
 694     if (FAILED(hr)) {
 695         msg_Err(va->log, "IDirect3DDeviceManager9_ResetDevice failed: %08x", (unsigned)hr);
 696         return VLC_EGENERIC;
 697     }
 698     return VLC_SUCCESS;
 699 }
 700 /**
 701  * It destroys a Direct3D device manager
 702  */
 703 static void D3dDestroyDeviceManager(vlc_va_dxva2_t *va)
 704 {
 705     if (va->devmng)
 706         IDirect3DDeviceManager9_Release(va->devmng);
 707 }
 708
 709 /**
 710  * It creates a DirectX video service
 711  */
 712 static int DxCreateVideoService(vlc_va_dxva2_t *va)
 713 {
 714     HRESULT (WINAPI *CreateVideoService)(IDirect3DDevice9 *,
 715                                          REFIID riid,
 716                                          void **ppService);
 717     CreateVideoService =
 718       (void *)GetProcAddress(va->hdxva2_dll,
 719                              "DXVA2CreateVideoService");
 720
 721     if (!CreateVideoService) {
 722         msg_Err(va->log, "cannot load function");
 723         return 4;
 724     }
 725     msg_Info(va->log, "DXVA2CreateVideoService Success!");
 726
 727     HRESULT hr;
 728
 729     HANDLE device;
 730     hr = IDirect3DDeviceManager9_OpenDeviceHandle(va->devmng, &device);
 731     if (FAILED(hr)) {
 732         msg_Err(va->log, "OpenDeviceHandle failed");
 733         return VLC_EGENERIC;
 734     }
 735     va->device = device;
 736
 737     IDirectXVideoDecoderService *vs;
 738     hr = IDirect3DDeviceManager9_GetVideoService(va->devmng, device,
 739                                                  &IID_IDirectXVideoDecoderService,
 740                                                  (void**)&vs);
 741     if (FAILED(hr)) {
 742         msg_Err(va->log, "GetVideoService failed");
 743         return VLC_EGENERIC;
 744     }
 745     va->vs = vs;
 746
 747     return VLC_SUCCESS;
 748 }
 749 /**
 750  * It destroys a DirectX video service
 751  */
 752 static void DxDestroyVideoService(vlc_va_dxva2_t *va)
 753 {
 754     if (va->device)
 755         IDirect3DDeviceManager9_CloseDeviceHandle(va->devmng, va->device);
 756     if (va->vs)
 757         IDirectXVideoDecoderService_Release(va->vs);
 758 }
 759 /**
 760  * Find the best suited decoder mode GUID and render format.
 761  */
 762 static int DxFindVideoServiceConversion(vlc_va_dxva2_t *va, GUID *input, D3DFORMAT *output)
 763 {
 764     /* Retreive supported modes from the decoder service */
 765     UINT input_count = 0;
 766     GUID *input_list = NULL;
 767     if (FAILED(IDirectXVideoDecoderService_GetDecoderDeviceGuids(va->vs,
 768                                                                  &input_count,
 769                                                                  &input_list))) {
 770         msg_Err(va->log, "IDirectXVideoDecoderService_GetDecoderDeviceGuids failed");
 771         return VLC_EGENERIC;
 772     }
 773     for (unsigned i = 0; i < input_count; i++) {
 774         const GUID *g = &input_list[i];
 775         const dxva2_mode_t *mode = Dxva2FindMode(g);
 776         if (mode) {
 777             msg_Dbg(va->log, "- '%s' is supported by hardware", mode->name);
 778         } else {
 779             msg_Warn(va->log, "- Unknown GUID = %08X-%04x-%04x-XXXX",
 780                      (unsigned)g->Data1, g->Data2, g->Data3);
 781         }
 782     }
 783
 784     /* Try all supported mode by our priority */
 785     for (unsigned i = 0; dxva2_modes[i].name; i++) {
 786         const dxva2_mode_t *mode = &dxva2_modes[i];
 787         if (!mode->codec || mode->codec != va->codec_id)
 788             continue;
 789
 790         /* */
 791         bool is_suported = false;
 792         for (const GUID *g = &input_list[0]; !is_suported && g < &input_list[input_count]; g++) {
 793             is_suported = IsEqualGUID(mode->guid, g);
 794         }
 795         if (!is_suported)
 796             continue;
 797
 798         /* */
 799         msg_Dbg(va->log, "Trying to use '%s' as input", mode->name);
 800         UINT      output_count = 0;
 801         D3DFORMAT *output_list = NULL;
 802         if (FAILED(IDirectXVideoDecoderService_GetDecoderRenderTargets(va->vs, mode->guid,
 803                                                                        &output_count,
 804                                                                        &output_list))) {
 805             msg_Err(va->log, "IDirectXVideoDecoderService_GetDecoderRenderTargets failed");
 806             continue;
 807         }
 808         for (unsigned j = 0; j < output_count; j++) {
 809             const D3DFORMAT f = output_list[j];
 810             const d3d_format_t *format = D3dFindFormat(f);
 811             if (format) {
 812                 msg_Dbg(va->log, "%s is supported for output", format->name);
 813             } else {
 814                 msg_Dbg(va->log, "%d is supported for output (%4.4s)", f, (const char*)&f);
 815             }
 816         }
 817
 818         /* */
 819         for (unsigned j = 0; d3d_formats[j].name; j++) {
 820             const d3d_format_t *format = &d3d_formats[j];
 821
 822             /* */
 823             bool is_suported = false;
 824             for (unsigned k = 0; !is_suported && k < output_count; k++) {
 825                 is_suported = format->format == output_list[k];
 826             }
 827             if (!is_suported)
 828                 continue;
 829
 830             /* We have our solution */
 831             msg_Dbg(va->log, "Using '%s' to decode to '%s'", mode->name, format->name);
 832             *input  = *mode->guid;
 833             *output = format->format;
 834             CoTaskMemFree(output_list);
 835             CoTaskMemFree(input_list);
 836             return VLC_SUCCESS;
 837         }
 838         CoTaskMemFree(output_list);
 839     }
 840     CoTaskMemFree(input_list);
 841     return VLC_EGENERIC;
 842 }
 843
 844 /**
 845  * It creates a DXVA2 decoder using the given video format
 846  */
 847 static int DxCreateVideoDecoder(vlc_va_dxva2_t *va,
 848                                 int codec_id, const video_format_t *fmt)
 849 {
 850     /* */
 851     msg_Dbg(va->log, "DxCreateVideoDecoder id %d %dx%d",
 852             codec_id, fmt->i_width, fmt->i_height);
 853
 854     va->width  = fmt->i_width;
 855     va->height = fmt->i_height;
 856
 857     /* Allocates all surfaces needed for the decoder */
 858     va->surface_width  = (fmt->i_width  + 15) & ~15;
 859     va->surface_height = (fmt->i_height + 15) & ~15;
 860     switch (codec_id) {
 861     case AV_CODEC_ID_H264:
 862         va->surface_count = 16 + 1;
 863         break;
 864     default:
 865         va->surface_count = 2 + 1;
 866         break;
 867     }
 868     LPDIRECT3DSURFACE9 surface_list[VA_DXVA2_MAX_SURFACE_COUNT];
 869     if (FAILED(IDirectXVideoDecoderService_CreateSurface(va->vs,
 870                                                          va->surface_width,
 871                                                          va->surface_height,
 872                                                          va->surface_count - 1,
 873                                                          va->render,
 874                                                          D3DPOOL_DEFAULT,
 875                                                          0,
 876                                                          DXVA2_VideoDecoderRenderTarget,
 877                                                          surface_list,
 878                                                          NULL))) {
 879         msg_Err(va->log, "IDirectXVideoAccelerationService_CreateSurface failed");
 880         va->surface_count = 0;
 881         return VLC_EGENERIC;
 882     }
 883     for (unsigned i = 0; i < va->surface_count; i++) {
 884         vlc_va_surface_t *surface = &va->surface[i];
 885         surface->d3d = surface_list[i];
 886         surface->refcount = 0;
 887         surface->order = 0;
 888     }
 889     msg_Dbg(va->log, "IDirectXVideoAccelerationService_CreateSurface succeed with %d surfaces (%dx%d)",
 890             va->surface_count, fmt->i_width, fmt->i_height);
 891
 892     /* */
 893     DXVA2_VideoDesc dsc;
 894     ZeroMemory(&dsc, sizeof(dsc));
 895     dsc.SampleWidth     = fmt->i_width;
 896     dsc.SampleHeight    = fmt->i_height;
 897     dsc.Format          = va->render;
 898     if (fmt->i_frame_rate > 0 && fmt->i_frame_rate_base > 0) {
 899         dsc.InputSampleFreq.Numerator   = fmt->i_frame_rate;
 900         dsc.InputSampleFreq.Denominator = fmt->i_frame_rate_base;
 901     } else {
 902         dsc.InputSampleFreq.Numerator   = 0;
 903         dsc.InputSampleFreq.Denominator = 0;
 904     }
 905     dsc.OutputFrameFreq = dsc.InputSampleFreq;
 906     dsc.UABProtectionLevel = FALSE;
 907     dsc.Reserved = 0;
 908
 909     /* FIXME I am unsure we can let unknown everywhere */
 910     DXVA2_ExtendedFormat *ext = &dsc.SampleFormat;
 911     ext->SampleFormat = 0;//DXVA2_SampleUnknown;
 912     ext->VideoChromaSubsampling = 0;//DXVA2_VideoChromaSubsampling_Unknown;
 913     ext->NominalRange = 0;//DXVA2_NominalRange_Unknown;
 914     ext->VideoTransferMatrix = 0;//DXVA2_VideoTransferMatrix_Unknown;
 915     ext->VideoLighting = 0;//DXVA2_VideoLighting_Unknown;
 916     ext->VideoPrimaries = 0;//DXVA2_VideoPrimaries_Unknown;
 917     ext->VideoTransferFunction = 0;//DXVA2_VideoTransFunc_Unknown;
 918
 919     /* List all configurations available for the decoder */
 920     UINT                      cfg_count = 0;
 921     DXVA2_ConfigPictureDecode *cfg_list = NULL;
 922     if (FAILED(IDirectXVideoDecoderService_GetDecoderConfigurations(va->vs,
 923                                                                     &va->input,
 924                                                                     &dsc,
 925                                                                     NULL,
 926                                                                     &cfg_count,
 927                                                                     &cfg_list))) {
 928         msg_Err(va->log, "IDirectXVideoDecoderService_GetDecoderConfigurations failed");
 929         return VLC_EGENERIC;
 930     }
 931     msg_Dbg(va->log, "we got %d decoder configurations", cfg_count);
 932
 933     /* Select the best decoder configuration */
 934     int cfg_score = 0;
 935     for (unsigned i = 0; i < cfg_count; i++) {
 936         const DXVA2_ConfigPictureDecode *cfg = &cfg_list[i];
 937
 938         /* */
 939         msg_Dbg(va->log, "configuration[%d] ConfigBitstreamRaw %d",
 940                 i, cfg->ConfigBitstreamRaw);
 941
 942         /* */
 943         int score;
 944         if (cfg->ConfigBitstreamRaw == 1)
 945             score = 1;
 946         else if (codec_id == AV_CODEC_ID_H264 && cfg->ConfigBitstreamRaw == 2)
 947             score = 2;
 948         else
 949             continue;
 950         if (IsEqualGUID(&cfg->guidConfigBitstreamEncryption, &DXVA_NoEncrypt))
 951             score += 16;
 952
 953         if (cfg_score < score) {
 954             va->cfg = *cfg;
 955             cfg_score = score;
 956         }
 957     }
 958     CoTaskMemFree(cfg_list);
 959     if (cfg_score <= 0) {
 960         msg_Err(va->log, "Failed to find a supported decoder configuration");
 961         return VLC_EGENERIC;
 962     }
 963
 964     /* Create the decoder */
 965     IDirectXVideoDecoder *decoder;
 966     if (FAILED(IDirectXVideoDecoderService_CreateVideoDecoder(va->vs,
 967                                                               &va->input,
 968                                                               &dsc,
 969                                                               &va->cfg,
 970                                                               surface_list,
 971                                                               va->surface_count,
 972                                                               &decoder))) {
 973         msg_Err(va->log, "IDirectXVideoDecoderService_CreateVideoDecoder failed");
 974         return VLC_EGENERIC;
 975     }
 976     va->decoder = decoder;
 977     msg_Dbg(va->log, "IDirectXVideoDecoderService_CreateVideoDecoder succeed");
 978     return VLC_SUCCESS;
 979 }
 980 static void DxDestroyVideoDecoder(vlc_va_dxva2_t *va)
 981 {
 982     if (va->decoder)
 983         IDirectXVideoDecoder_Release(va->decoder);
 984     va->decoder = NULL;
 985
 986     for (unsigned i = 0; i < va->surface_count; i++)
 987         IDirect3DSurface9_Release(va->surface[i].d3d);
 988     va->surface_count = 0;
 989 }
 990 static int DxResetVideoDecoder(vlc_va_dxva2_t *va)
 991 {
 992     msg_Err(va->log, "DxResetVideoDecoder unimplemented");
 993     return VLC_EGENERIC;
 994 }
 995
 996 static void DxCreateVideoConversion(vlc_va_dxva2_t *va)
 997 {
 998     switch (va->render) {
 999     case MAKEFOURCC('N','V','1','2'):
1000     case MAKEFOURCC('I','M','C','3'):
1001         va->output = MAKEFOURCC('Y','V','1','2');
1002         break;
1003     default:
1004         va->output = va->render;
1005         break;
1006     }
1007     CopyInitCache(&va->surface_cache, va->surface_width);
1008 }
1009 static void DxDestroyVideoConversion(vlc_va_dxva2_t *va)
1010 {
1011     CopyCleanCache(&va->surface_cache);
1012 }