]> git.sesse.net Git - vlc/blob - modules/codec/avcodec/vda.c
vda: fix major memory leak which killed decoding shortly after start (close #8440)
[vlc] / modules / codec / avcodec / vda.c
1 /*****************************************************************************
2  * vda.c: VDA helpers for the libavcodec decoder
3  *****************************************************************************
4  * Copyright © 2012 VideoLAN
5  *
6  * Authors: Sebastien Zwickert <dilaroga@free.fr>
7  *
8  * This program is free software; you can redistribute it and/or modify it
9  * under the terms of the GNU Lesser General Public License as published by
10  * the Free Software Foundation; either version 2.1 of the License, or
11  * (at your option) any later version.
12  *
13  * This program is distributed in the hope that it will be useful,
14  * but WITHOUT ANY WARRANTY; without even the implied warranty of
15  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16  * GNU Lesser General Public License for more details.
17  *
18  * You should have received a copy of the GNU Lesser General Public License
19  * along with this program; if not, write to the Free Software Foundation,
20  * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
21  *****************************************************************************/
22
23 #ifdef HAVE_CONFIG_H
24 # include "config.h"
25 #endif
26
27 #include <assert.h>
28
29 #include <vlc_common.h>
30 #include <vlc_vout.h>
31 #include <vlc_plugin.h>
32
33 #include <libavcodec/avcodec.h>
34
35 #include "avcodec.h"
36 #include "va.h"
37 #include "copy.h"
38
39 #include <libavcodec/vda.h>
40 #include <VideoDecodeAcceleration/VDADecoder.h>
41
42 static int Open( vlc_va_t *, int, const es_format_t * );
43 static void Close( vlc_va_t * );
44
45 static const int  nvda_pix_fmt_list[] = { 0, 1 };
46 static const char *const nvda_pix_fmt_list_text[] =
47   { N_("420YpCbCr8Planar"), N_("422YpCbCr8") };
48
49 vlc_module_begin ()
50     set_description( N_("Video Decode Acceleration Framework (VDA)") )
51     set_capability( "hw decoder", 50 )
52     set_category( CAT_INPUT )
53     set_subcategory( SUBCAT_INPUT_VCODEC )
54     set_callbacks( Open, Close )
55     add_integer ( "avcodec-vda-pix-fmt", 0, VDA_PIX_FMT_TEXT,
56                   VDA_PIX_FMT_LONGTEXT, false)
57         change_integer_list( nvda_pix_fmt_list, nvda_pix_fmt_list_text )
58 vlc_module_end ()
59
60 struct vlc_va_sys_t
61 {
62     struct vda_context  hw_ctx;
63
64     uint8_t             *p_extradata;
65     int                 i_extradata;
66
67     vlc_fourcc_t        i_chroma;
68
69     copy_cache_t        image_cache;
70
71     vlc_object_t        *p_log;
72
73 };
74
75 typedef struct vlc_va_sys_t vlc_va_vda_t;
76
77 static vlc_va_vda_t *vlc_va_vda_Get( vlc_va_t *p_va )
78 {
79     return p_va->sys;
80 }
81
82 /*****************************************************************************
83  * vda_Copy420YpCbCr8Planar: copy y420 CVPixelBuffer to picture_t
84  *****************************************************************************/
85 static void vda_Copy420YpCbCr8Planar( picture_t *p_pic,
86                                       CVPixelBufferRef buffer,
87                                       unsigned i_width,
88                                       unsigned i_height,
89                                       copy_cache_t *cache )
90 {
91     uint8_t *pp_plane[3];
92     size_t  pi_pitch[3];
93
94     CVPixelBufferLockBaseAddress( buffer, 0 );
95
96     for( int i = 0; i < 3; i++ )
97     {
98         pp_plane[i] = CVPixelBufferGetBaseAddressOfPlane( buffer, i );
99         pi_pitch[i] = CVPixelBufferGetBytesPerRowOfPlane( buffer, i );
100     }
101
102     CopyFromYv12( p_pic, pp_plane, pi_pitch,
103                   i_width, i_height, cache );
104
105     CVPixelBufferUnlockBaseAddress( buffer, 0 );
106     CVPixelBufferRelease( buffer );
107 }
108
109 /*****************************************************************************
110  * vda_Copy422YpCbCr8: copy 2vuy CVPixelBuffer to picture_t
111  *****************************************************************************/
112 static void vda_Copy422YpCbCr8( picture_t *p_pic,
113                                 CVPixelBufferRef buffer )
114 {
115     int i_plane, i_line, i_dst_stride, i_src_stride;
116     uint8_t *p_dst, *p_src;
117
118     CVPixelBufferLockBaseAddress( buffer, 0 );
119
120     for( i_plane = 0; i_plane < p_pic->i_planes; i_plane++ )
121     {
122         p_dst = p_pic->p[i_plane].p_pixels;
123         p_src = CVPixelBufferGetBaseAddressOfPlane( buffer, i_plane );
124         i_dst_stride  = p_pic->p[i_plane].i_pitch;
125         i_src_stride  = CVPixelBufferGetBytesPerRowOfPlane( buffer, i_plane );
126
127         for( i_line = 0; i_line < p_pic->p[i_plane].i_visible_lines ; i_line++ )
128         {
129             memcpy( p_dst, p_src, i_src_stride );
130
131             p_src += i_src_stride;
132             p_dst += i_dst_stride;
133         }
134     }
135
136     CVPixelBufferUnlockBaseAddress( buffer, 0 );
137     CVPixelBufferRelease( buffer );
138 }
139
140 static int Setup( vlc_va_t *p_external, void **pp_hw_ctx, vlc_fourcc_t *pi_chroma,
141                   int i_width, int i_height )
142 {
143
144     vlc_va_vda_t *p_va = vlc_va_vda_Get( p_external );
145
146     if( p_va->hw_ctx.width == i_width
147         && p_va->hw_ctx.height == i_height
148         && p_va->hw_ctx.decoder )
149     {
150         *pp_hw_ctx = &p_va->hw_ctx;
151         *pi_chroma = p_va->i_chroma;
152         return VLC_SUCCESS;
153     }
154
155     if( p_va->hw_ctx.decoder )
156     {
157         ff_vda_destroy_decoder( &p_va->hw_ctx );
158         goto ok;
159     }
160
161     memset( &p_va->hw_ctx, 0, sizeof(p_va->hw_ctx) );
162     p_va->hw_ctx.width = i_width;
163     p_va->hw_ctx.height = i_height;
164     p_va->hw_ctx.format = 'avc1';
165
166     int i_pix_fmt = var_CreateGetInteger( p_va->p_log, "avcodec-vda-pix-fmt" );
167
168     switch( i_pix_fmt )
169     {
170         case 1 :
171             p_va->hw_ctx.cv_pix_fmt_type = kCVPixelFormatType_422YpCbCr8;
172             p_va->i_chroma = VLC_CODEC_UYVY;
173             msg_Dbg(p_va->p_log, "using pixel format 422YpCbCr8");
174             break;
175         case 0 :
176         default :
177             p_va->hw_ctx.cv_pix_fmt_type = kCVPixelFormatType_420YpCbCr8Planar;
178             p_va->i_chroma = VLC_CODEC_I420;
179             CopyInitCache( &p_va->image_cache, i_width );
180             msg_Dbg(p_va->p_log, "using pixel format 420YpCbCr8Planar");
181     }
182
183 ok:
184     /* Setup the libavcodec hardware context */
185     *pp_hw_ctx = &p_va->hw_ctx;
186     *pi_chroma = p_va->i_chroma;
187
188     /* create the decoder */
189     int status = ff_vda_create_decoder( &p_va->hw_ctx,
190                                         p_va->p_extradata,
191                                         p_va->i_extradata );
192     if( status )
193     {
194         msg_Err( p_va->p_log, "Failed to create decoder: %i", status );
195         return VLC_EGENERIC;
196     }
197     else
198         msg_Dbg( p_va->p_log, "VDA decoder created");
199
200     return VLC_SUCCESS;
201 }
202
203 static int Get( vlc_va_t *p_external, AVFrame *p_ff )
204 {
205     VLC_UNUSED( p_external );
206
207     /* */
208     for( int i = 0; i < 4; i++ )
209     {
210         p_ff->data[i] = NULL;
211         p_ff->linesize[i] = 0;
212
213         if( i == 0 || i == 3 )
214         p_ff->data[i] = (uint8_t *)1; // dummy
215     }
216
217     return VLC_SUCCESS;
218 }
219
220 static int Extract( vlc_va_t *p_external, picture_t *p_picture, AVFrame *p_ff )
221 {
222     vlc_va_vda_t *p_va = vlc_va_vda_Get( p_external );
223     CVPixelBufferRef cv_buffer = ( CVPixelBufferRef )p_ff->data[3];
224
225     if( !cv_buffer )
226     {
227         msg_Dbg( p_va->p_log, "Frame buffer is empty.");
228         return VLC_EGENERIC;
229     }
230
231     if( p_va->hw_ctx.cv_pix_fmt_type == kCVPixelFormatType_420YpCbCr8Planar )
232     {
233         if( !p_va->image_cache.buffer )
234             return VLC_EGENERIC;
235
236         vda_Copy420YpCbCr8Planar( p_picture,
237                                   cv_buffer,
238                                   p_va->hw_ctx.width,
239                                   p_va->hw_ctx.height,
240                                   &p_va->image_cache );
241     }
242     else
243         vda_Copy422YpCbCr8( p_picture, cv_buffer );
244
245     return VLC_SUCCESS;
246 }
247
248 static void Release( vlc_va_t *p_external, AVFrame *p_ff )
249 {
250     VLC_UNUSED( p_external );
251     CVPixelBufferRef cv_buffer = ( CVPixelBufferRef )p_ff->data[3];
252
253     if ( cv_buffer )
254         CFRelease( cv_buffer );
255 }
256
257 static void Close( vlc_va_t *p_external )
258 {
259     vlc_va_vda_t *p_va = vlc_va_vda_Get( p_external );
260
261     msg_Dbg(p_va->p_log, "destroying VDA decoder");
262
263     ff_vda_destroy_decoder( &p_va->hw_ctx ) ;
264
265     if( p_va->hw_ctx.cv_pix_fmt_type == kCVPixelFormatType_420YpCbCr8Planar )
266         CopyCleanCache( &p_va->image_cache );
267
268     free( p_va );
269 }
270
271 static int Open( vlc_va_t *external, int i_codec_id, const es_format_t *fmt )
272 {
273     msg_Dbg( external, "opening VDA module" );
274     if( i_codec_id != AV_CODEC_ID_H264 )
275     {
276         msg_Warn( external, "input codec isn't H264, canceling VDA decoding" );
277         return VLC_EGENERIC;
278     }
279
280     if( fmt->p_extra == NULL || fmt->i_extra < 7 )
281     {
282         msg_Warn( external, "VDA requires extradata." );
283         return VLC_EGENERIC;
284     }
285
286     vlc_va_vda_t *p_va = calloc( 1, sizeof(*p_va) );
287     if( !p_va )
288         return VLC_EGENERIC;
289
290     p_va->p_log = VLC_OBJECT(external);
291     p_va->p_extradata = fmt->p_extra;
292     p_va->i_extradata = fmt->i_extra;
293
294     external->sys = p_va;
295     external->description = (char *)"VDA";
296     external->pix_fmt = PIX_FMT_VDA_VLD;
297     external->setup = Setup;
298     external->get = Get;
299     external->release = Release;
300     external->extract = Extract;
301
302     return VLC_SUCCESS;
303 }