]> git.sesse.net Git - vlc/blob - src/video_output/display.c
filter_t: use struct of non-anymous unions, seems more portable
[vlc] / src / video_output / display.c
1 /*****************************************************************************
2  * display.c: "vout display" managment
3  *****************************************************************************
4  * Copyright (C) 2009 Laurent Aimar
5  * $Id$
6  *
7  * Authors: Laurent Aimar <fenrir _AT_ videolan _DOT_ org>
8  *
9  * This program is free software; you can redistribute it and/or modify
10  * it under the terms of the GNU General Public License as published by
11  * the Free Software Foundation; either version 2 of the License, or
12  * (at your option) any later version.
13  *
14  * This program is distributed in the hope that it will be useful,
15  * but WITHOUT ANY WARRANTY; without even the implied warranty of
16  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17  * GNU General Public License for more details.
18  *
19  * You should have received a copy of the GNU General Public License
20  * along with this program; if not, write to the Free Software
21  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
22  *****************************************************************************/
23
24 /*****************************************************************************
25  * Preamble
26  *****************************************************************************/
27 #ifdef HAVE_CONFIG_H
28 # include "config.h"
29 #endif
30 #include <assert.h>
31
32 #include <vlc_common.h>
33 #include <vlc_video_splitter.h>
34 #include <vlc_vout_display.h>
35 #include <vlc_vout.h>
36
37 #include <libvlc.h>
38
39 #include "display.h"
40
41 #include "event.h"
42
43 /* It must be present as long as a vout_display_t must be created using a dummy
44  * vout (as an opengl provider) */
45 #define ALLOW_DUMMY_VOUT
46
47 static void SplitterClose(vout_display_t *vd);
48
49 /*****************************************************************************
50  * FIXME/TODO see how to have direct rendering here (interact with vout.c)
51  *****************************************************************************/
52 static picture_t *VideoBufferNew(filter_t *filter)
53 {
54     vout_display_t *vd = (vout_display_t*)filter->p_owner;
55     const video_format_t *fmt = &filter->fmt_out.video;
56
57     assert(vd->fmt.i_chroma == fmt->i_chroma &&
58            vd->fmt.i_width  == fmt->i_width  &&
59            vd->fmt.i_height == fmt->i_height);
60
61     picture_pool_t *pool = vout_display_Pool(vd, 1);
62     if (!pool)
63         return NULL;
64     return picture_pool_Get(pool);
65 }
66 static void VideoBufferDelete(filter_t *filter, picture_t *picture)
67 {
68     VLC_UNUSED(filter);
69     picture_Release(picture);
70 }
71
72 static int  FilterAllocationInit(filter_t *filter, void *vd)
73 {
74     filter->pf_video_buffer_new = VideoBufferNew;
75     filter->pf_video_buffer_del = VideoBufferDelete;
76     filter->p_owner             = vd;
77
78     return VLC_SUCCESS;
79 }
80 static void FilterAllocationClean(filter_t *filter)
81 {
82     filter->pf_video_buffer_new = NULL;
83     filter->pf_video_buffer_del = NULL;
84     filter->p_owner             = NULL;
85 }
86
87 /*****************************************************************************
88  *
89  *****************************************************************************/
90
91 /**
92  * It creates a new vout_display_t using the given configuration.
93  */
94 static vout_display_t *vout_display_New(vlc_object_t *obj,
95                                         const char *module, bool load_module,
96                                         const video_format_t *fmt,
97                                         const vout_display_cfg_t *cfg,
98                                         vout_display_owner_t *owner)
99 {
100     /* */
101     vout_display_t *vd = vlc_object_create(obj, sizeof(*vd));
102
103     /* */
104     video_format_Copy(&vd->source, fmt);
105
106     /* Picture buffer does not have the concept of aspect ratio */
107     video_format_Copy(&vd->fmt, fmt);
108     vd->fmt.i_sar_num = 0;
109     vd->fmt.i_sar_den = 0;
110
111     vd->info.is_slow = false;
112     vd->info.has_double_click = false;
113     vd->info.has_hide_mouse = false;
114     vd->info.has_pictures_invalid = false;
115
116     vd->cfg = cfg;
117     vd->pool = NULL;
118     vd->prepare = NULL;
119     vd->display = NULL;
120     vd->control = NULL;
121     vd->manage = NULL;
122     vd->sys = NULL;
123
124     vd->owner = *owner;
125
126     vlc_object_attach(vd, obj);
127
128     if (load_module) {
129         vd->module = module_need(vd, "vout display", module, module && *module != '\0');
130         if (!vd->module) {
131             vlc_object_detach(vd);
132             vlc_object_release(vd);
133             return NULL;
134         }
135     } else {
136         vd->module = NULL;
137     }
138     return vd;
139 }
140
141 /**
142  * It deletes a vout_display_t
143  */
144 static void vout_display_Delete(vout_display_t *vd)
145 {
146     vlc_object_detach(vd);
147
148     if (vd->module)
149         module_unneed(vd, vd->module);
150
151     vlc_object_release(vd);
152 }
153
154 /**
155  * It controls a vout_display_t
156  */
157 static int vout_display_Control(vout_display_t *vd, int query, ...)
158 {
159     va_list args;
160     int result;
161
162     va_start(args, query);
163     result = vd->control(vd, query, args);
164     va_end(args);
165
166     return result;
167 }
168 static void vout_display_Manage(vout_display_t *vd)
169 {
170     if (vd->manage)
171         vd->manage(vd);
172 }
173
174 /* */
175 void vout_display_GetDefaultDisplaySize(unsigned *width, unsigned *height,
176                                         const video_format_t *source,
177                                         const vout_display_cfg_t *cfg)
178 {
179     if (cfg->display.width > 0 && cfg->display.height > 0) {
180         *width  = cfg->display.width;
181         *height = cfg->display.height;
182     } else if (cfg->display.width > 0) {
183         *width  = cfg->display.width;
184         *height = (int64_t)source->i_visible_height * source->i_sar_den * cfg->display.width * cfg->display.sar.num /
185             source->i_visible_width / source->i_sar_num / cfg->display.sar.den;
186     } else if (cfg->display.height > 0) {
187         *width  = (int64_t)source->i_visible_width * source->i_sar_num * cfg->display.height * cfg->display.sar.den /
188             source->i_visible_height / source->i_sar_den / cfg->display.sar.num;
189         *height = cfg->display.height;
190     } else if (source->i_sar_num >= source->i_sar_den) {
191         *width  = (int64_t)source->i_visible_width * source->i_sar_num * cfg->display.sar.den / source->i_sar_den / cfg->display.sar.num;
192         *height = source->i_visible_height;
193     } else {
194         *width  = source->i_visible_width;
195         *height = (int64_t)source->i_visible_height * source->i_sar_den * cfg->display.sar.num / source->i_sar_num / cfg->display.sar.den;
196     }
197
198     *width  = *width  * cfg->zoom.num / cfg->zoom.den;
199     *height = *height * cfg->zoom.num / cfg->zoom.den;
200 }
201
202 /* */
203 void vout_display_PlacePicture(vout_display_place_t *place,
204                                const video_format_t *source,
205                                const vout_display_cfg_t *cfg,
206                                bool do_clipping)
207 {
208     /* */
209     memset(place, 0, sizeof(*place));
210     if (cfg->display.width <= 0 || cfg->display.height <= 0)
211         return;
212
213     /* */
214     unsigned width;
215     unsigned height;
216     unsigned display_width;
217     unsigned display_height;
218
219     if (cfg->is_display_filled) {
220         width  = source->i_visible_width;
221         height = source->i_visible_height;
222         display_width  = cfg->display.width;
223         display_height = cfg->display.height;
224     } else {
225         vout_display_cfg_t cfg_tmp = *cfg;
226
227         cfg_tmp.display.width  = 0;
228         cfg_tmp.display.height = 0;
229         vout_display_GetDefaultDisplaySize(&width, &height,
230                                            source, &cfg_tmp);
231
232         display_width  = width;
233         display_height = height;
234         if (do_clipping) {
235             display_width  = __MIN(display_width,  cfg->display.width);
236             display_height = __MIN(display_height, cfg->display.height);
237         }
238     }
239
240     /* Compute the height if we use the width to fill up display_width */
241     const int64_t scaled_height = (int64_t)height * display_width  * cfg->display.sar.num * source->i_sar_den / width  / source->i_sar_num / cfg->display.sar.den;
242     /* And the same but switching width/height */
243     const int64_t scaled_width  = (int64_t)width  * display_height * cfg->display.sar.den * source->i_sar_num / height / source->i_sar_den / cfg->display.sar.num;
244
245     /* We keep the solution that avoid filling outside the display */
246     if (scaled_width <= cfg->display.width) {
247         place->width  = scaled_width;
248         place->height = display_height;
249     } else {
250         place->width  = display_width;
251         place->height = scaled_height;
252     }
253
254     /*  Compute position */
255     switch (cfg->align.horizontal) {
256     case VOUT_DISPLAY_ALIGN_LEFT:
257         place->x = 0;
258         break;
259     case VOUT_DISPLAY_ALIGN_RIGHT:
260         place->x = cfg->display.width - place->width;
261         break;
262     default:
263         place->x = (cfg->display.width - place->width) / 2;
264         break;
265     }
266
267     switch (cfg->align.vertical) {
268     case VOUT_DISPLAY_ALIGN_TOP:
269         place->y = 0;
270         break;
271     case VOUT_DISPLAY_ALIGN_BOTTOM:
272         place->y = cfg->display.height - place->height;
273         break;
274     default:
275         place->y = (cfg->display.height - place->height) / 2;
276         break;
277     }
278 }
279
280 struct vout_display_owner_sys_t {
281     vout_thread_t   *vout;
282     bool            is_wrapper;  /* Is the current display a wrapper */
283     vout_display_t  *wrapper; /* Vout display wrapper */
284
285     /* */
286     vout_display_cfg_t cfg;
287     unsigned     wm_state_initial;
288     struct {
289         unsigned num;
290         unsigned den;
291     } sar_initial;
292
293     /* */
294     int  width_saved;
295     int  height_saved;
296
297     struct {
298         unsigned num;
299         unsigned den;
300     } crop_saved;
301
302     /* */
303     bool ch_display_filled;
304     bool is_display_filled;
305
306     bool ch_zoom;
307     struct {
308         int  num;
309         int  den;
310     } zoom;
311
312     bool ch_wm_state;
313     unsigned wm_state;
314
315     bool ch_sar;
316     struct {
317         unsigned num;
318         unsigned den;
319     } sar;
320
321     bool ch_crop;
322     struct {
323         unsigned x;
324         unsigned y;
325         unsigned width;
326         unsigned height;
327         unsigned num;
328         unsigned den;
329     } crop;
330
331     /* */
332     video_format_t source;
333     filter_chain_t *filters;
334
335     /* Lock protecting the variables used by
336      * VoutDisplayEvent(ie vout_display_SendEvent) */
337     vlc_mutex_t lock;
338
339     /* mouse state */
340     struct {
341         vlc_mouse_t state;
342
343         mtime_t last_pressed;
344         mtime_t last_moved;
345         bool    is_hidden;
346         bool    ch_activity;
347
348         /* */
349         mtime_t double_click_timeout;
350         mtime_t hide_timeout;
351     } mouse;
352
353     bool reset_pictures;
354
355     bool ch_fullscreen;
356     bool is_fullscreen;
357
358     bool ch_display_size;
359     int  display_width;
360     int  display_height;
361     bool display_is_fullscreen;
362     bool display_is_forced;
363
364 #ifdef ALLOW_DUMMY_VOUT
365     vlc_mouse_t vout_mouse;
366 #endif
367 };
368
369 static void DummyVoutSendDisplayEventMouse(vout_thread_t *, vlc_mouse_t *fallback, const vlc_mouse_t *m);
370
371 static void VoutDisplayCreateRender(vout_display_t *vd)
372 {
373     vout_display_owner_sys_t *osys = vd->owner.sys;
374
375     osys->filters = NULL;
376
377     video_format_t v_src = vd->source;
378     v_src.i_sar_num = 0;
379     v_src.i_sar_den = 0;
380
381     video_format_t v_dst = vd->fmt;
382     v_dst.i_sar_num = 0;
383     v_dst.i_sar_den = 0;
384
385     video_format_t v_dst_cmp = v_dst;
386     if ((v_src.i_chroma == VLC_CODEC_J420 && v_dst.i_chroma == VLC_CODEC_I420) ||
387         (v_src.i_chroma == VLC_CODEC_J422 && v_dst.i_chroma == VLC_CODEC_I422) ||
388         (v_src.i_chroma == VLC_CODEC_J440 && v_dst.i_chroma == VLC_CODEC_I440) ||
389         (v_src.i_chroma == VLC_CODEC_J444 && v_dst.i_chroma == VLC_CODEC_I444))
390         v_dst_cmp.i_chroma = v_src.i_chroma;
391
392     const bool convert = memcmp(&v_src, &v_dst_cmp, sizeof(v_src)) != 0;
393     if (!convert)
394         return;
395
396     msg_Err(vd, "A filter to adapt decoder to display is needed");
397
398     osys->filters = filter_chain_New(vd, "video filter2", false,
399                                      FilterAllocationInit,
400                                      FilterAllocationClean, vd);
401     assert(osys->filters); /* TODO critical */
402
403     /* */
404     es_format_t src;
405     es_format_InitFromVideo(&src, &v_src);
406
407     /* */
408     es_format_t dst;
409
410     filter_t *filter;
411     for (int i = 0; i < 1 + (v_dst_cmp.i_chroma != v_dst.i_chroma); i++) {
412
413         es_format_InitFromVideo(&dst, i == 0 ? &v_dst : &v_dst_cmp);
414
415         filter_chain_Reset(osys->filters, &src, &dst);
416         filter = filter_chain_AppendFilter(osys->filters,
417                                            NULL, NULL, &src, &dst);
418         if (filter)
419             break;
420     }
421     if (!filter)
422     {
423         msg_Err(vd, "VoutDisplayCreateRender FAILED");
424         /* TODO */
425         assert(0);
426     }
427 }
428
429 static void VoutDisplayDestroyRender(vout_display_t *vd)
430 {
431     vout_display_owner_sys_t *osys = vd->owner.sys;
432
433     if (osys->filters)
434         filter_chain_Delete(osys->filters);
435 }
436
437 static void VoutDisplayResetRender(vout_display_t *vd)
438 {
439     VoutDisplayDestroyRender(vd);
440     VoutDisplayCreateRender(vd);
441 }
442 static void VoutDisplayEventMouse(vout_display_t *vd, int event, va_list args)
443 {
444     vout_display_owner_sys_t *osys = vd->owner.sys;
445
446     vlc_mutex_lock(&osys->lock);
447
448     /* */
449     vlc_mouse_t m = osys->mouse.state;
450     bool is_ignored = false;
451
452     switch (event) {
453     case VOUT_DISPLAY_EVENT_MOUSE_STATE: {
454         const int x = (int)va_arg(args, int);
455         const int y = (int)va_arg(args, int);
456         const int button_mask = (int)va_arg(args, int);
457
458         vlc_mouse_Init(&m);
459         m.i_x = x;
460         m.i_y = y;
461         m.i_pressed = button_mask;
462         break;
463     }
464     case VOUT_DISPLAY_EVENT_MOUSE_MOVED: {
465         const int x = (int)va_arg(args, int);
466         const int y = (int)va_arg(args, int);
467         if (x != osys->mouse.state.i_x || y != osys->mouse.state.i_y) {
468             //msg_Dbg(vd, "VoutDisplayEvent 'mouse' @%d,%d", x, y);
469
470             m.i_x = x;
471             m.i_y = y;
472             m.b_double_click = false;
473         } else {
474             is_ignored = true;
475         }
476         break;
477     }
478     case VOUT_DISPLAY_EVENT_MOUSE_PRESSED:
479     case VOUT_DISPLAY_EVENT_MOUSE_RELEASED: {
480         const int button = (int)va_arg(args, int);
481         const int button_mask = 1 << button;
482
483         /* Ignore inconsistent event */
484         if ((event == VOUT_DISPLAY_EVENT_MOUSE_PRESSED  &&  (osys->mouse.state.i_pressed & button_mask)) ||
485             (event == VOUT_DISPLAY_EVENT_MOUSE_RELEASED && !(osys->mouse.state.i_pressed & button_mask))) {
486             is_ignored = true;
487             break;
488         }
489
490         /* */
491         msg_Dbg(vd, "VoutDisplayEvent 'mouse button' %d t=%d", button, event);
492
493         m.b_double_click = false;
494         if (event == VOUT_DISPLAY_EVENT_MOUSE_PRESSED)
495             m.i_pressed |= button_mask;
496         else
497             m.i_pressed &= ~button_mask;
498         break;
499     }
500     case VOUT_DISPLAY_EVENT_MOUSE_DOUBLE_CLICK:
501         msg_Dbg(vd, "VoutDisplayEvent 'double click'");
502
503         m.b_double_click = true;
504         break;
505     default:
506         assert(0);
507     }
508
509     if (is_ignored) {
510         vlc_mutex_unlock(&osys->lock);
511         return;
512     }
513
514     /* Emulate double-click if needed */
515     if (!vd->info.has_double_click &&
516         vlc_mouse_HasPressed(&osys->mouse.state, &m, MOUSE_BUTTON_LEFT)) {
517         const mtime_t i_date = mdate();
518
519         if (i_date - osys->mouse.last_pressed < osys->mouse.double_click_timeout ) {
520             m.b_double_click = true;
521             osys->mouse.last_pressed = 0;
522         } else {
523             osys->mouse.last_pressed = mdate();
524         }
525     }
526
527     /* */
528     osys->mouse.state = m;
529
530     /* */
531     osys->mouse.ch_activity = true;
532     if (!vd->info.has_hide_mouse)
533         osys->mouse.last_moved = mdate();
534
535     /* */
536     vlc_mutex_unlock(&osys->lock);
537
538     /* */
539     vout_SendEventMouseVisible(osys->vout);
540 #ifdef ALLOW_DUMMY_VOUT
541     DummyVoutSendDisplayEventMouse(osys->vout, &osys->vout_mouse, &m);
542 #else
543     vout_SendDisplayEventMouse(osys->vout, &m);
544 #endif
545 }
546
547 static void VoutDisplayEvent(vout_display_t *vd, int event, va_list args)
548 {
549     vout_display_owner_sys_t *osys = vd->owner.sys;
550
551     switch (event) {
552     case VOUT_DISPLAY_EVENT_CLOSE: {
553         msg_Dbg(vd, "VoutDisplayEvent 'close'");
554         vout_SendEventClose(osys->vout);
555         break;
556     }
557     case VOUT_DISPLAY_EVENT_KEY: {
558         const int key = (int)va_arg(args, int);
559         msg_Dbg(vd, "VoutDisplayEvent 'key' 0x%2.2x", key);
560         vout_SendEventKey(osys->vout, key);
561         break;
562     }
563     case VOUT_DISPLAY_EVENT_MOUSE_STATE:
564     case VOUT_DISPLAY_EVENT_MOUSE_MOVED:
565     case VOUT_DISPLAY_EVENT_MOUSE_PRESSED:
566     case VOUT_DISPLAY_EVENT_MOUSE_RELEASED:
567     case VOUT_DISPLAY_EVENT_MOUSE_DOUBLE_CLICK:
568         VoutDisplayEventMouse(vd, event, args);
569         break;
570
571     case VOUT_DISPLAY_EVENT_FULLSCREEN: {
572         const int is_fullscreen = (int)va_arg(args, int);
573
574         msg_Dbg(vd, "VoutDisplayEvent 'fullscreen' %d", is_fullscreen);
575
576         vlc_mutex_lock(&osys->lock);
577         if (!is_fullscreen != !osys->is_fullscreen) {
578             osys->ch_fullscreen = true;
579             osys->is_fullscreen = is_fullscreen;
580         }
581         vlc_mutex_unlock(&osys->lock);
582         break;
583     }
584
585     case VOUT_DISPLAY_EVENT_WINDOW_STATE: {
586         const unsigned state = va_arg(args, unsigned);
587
588         msg_Dbg(vd, "VoutDisplayEvent 'window state' %u", state);
589
590         vlc_mutex_lock(&osys->lock);
591         if (state != osys->wm_state) {
592             osys->ch_wm_state = true;
593             osys->wm_state = state;
594         }
595         vlc_mutex_unlock(&osys->lock);
596         break;
597     }
598
599     case VOUT_DISPLAY_EVENT_DISPLAY_SIZE: {
600         const int width  = (int)va_arg(args, int);
601         const int height = (int)va_arg(args, int);
602         const bool is_fullscreen = (bool)va_arg(args, int);
603         msg_Dbg(vd, "VoutDisplayEvent 'resize' %dx%d %s",
604                 width, height, is_fullscreen ? "fullscreen" : "window");
605
606         /* */
607         vlc_mutex_lock(&osys->lock);
608
609         osys->ch_display_size       = true;
610         osys->display_width         = width;
611         osys->display_height        = height;
612         osys->display_is_fullscreen = is_fullscreen;
613         osys->display_is_forced     = false;
614
615         vlc_mutex_unlock(&osys->lock);
616         break;
617     }
618
619     case VOUT_DISPLAY_EVENT_PICTURES_INVALID: {
620         msg_Warn(vd, "VoutDisplayEvent 'pictures invalid'");
621
622         /* */
623         assert(vd->info.has_pictures_invalid);
624
625         vlc_mutex_lock(&osys->lock);
626         osys->reset_pictures = true;
627         vlc_mutex_unlock(&osys->lock);
628         break;
629     }
630     default:
631         msg_Err(vd, "VoutDisplayEvent received event %d", event);
632         /* TODO add an assert when all event are handled */
633         break;
634     }
635 }
636
637 static vout_window_t *VoutDisplayNewWindow(vout_display_t *vd, const vout_window_cfg_t *cfg)
638 {
639     vout_display_owner_sys_t *osys = vd->owner.sys;
640
641     return vout_NewDisplayWindow(osys->vout, vd, cfg);
642 }
643 static void VoutDisplayDelWindow(vout_display_t *vd, vout_window_t *window)
644 {
645     vout_display_owner_sys_t *osys = vd->owner.sys;
646
647     vout_DeleteDisplayWindow(osys->vout, vd, window);
648 }
649
650 void vout_ManageDisplay(vout_display_t *vd, bool allow_reset_pictures)
651 {
652     vout_display_owner_sys_t *osys = vd->owner.sys;
653
654     vout_display_Manage(vd);
655
656     /* Handle mouse timeout */
657     const mtime_t date = mdate();
658     bool  hide_mouse = false;
659
660     vlc_mutex_lock(&osys->lock);
661
662     if (!osys->mouse.is_hidden &&
663         osys->mouse.last_moved + osys->mouse.hide_timeout < date) {
664         osys->mouse.is_hidden = hide_mouse = true;
665     } else if (osys->mouse.ch_activity) {
666         osys->mouse.is_hidden = false;
667     }
668     osys->mouse.ch_activity = false;
669     vlc_mutex_unlock(&osys->lock);
670
671     if (hide_mouse) {
672         if (!vd->info.has_hide_mouse) {
673             msg_Dbg(vd, "auto hidding mouse");
674             vout_display_Control(vd, VOUT_DISPLAY_HIDE_MOUSE);
675         }
676         vout_SendEventMouseHidden(osys->vout);
677     }
678
679     bool reset_render = false;
680     for (;;) {
681
682         vlc_mutex_lock(&osys->lock);
683
684         bool ch_fullscreen  = osys->ch_fullscreen;
685         bool is_fullscreen  = osys->is_fullscreen;
686         osys->ch_fullscreen = false;
687
688         bool ch_wm_state  = osys->ch_wm_state;
689         unsigned wm_state  = osys->wm_state;
690         osys->ch_wm_state = false;
691
692         bool ch_display_size       = osys->ch_display_size;
693         int  display_width         = osys->display_width;
694         int  display_height        = osys->display_height;
695         bool display_is_fullscreen = osys->display_is_fullscreen;
696         bool display_is_forced     = osys->display_is_forced;
697         osys->ch_display_size = false;
698
699         bool reset_pictures;
700         if (allow_reset_pictures) {
701             reset_pictures = osys->reset_pictures;
702             osys->reset_pictures = false;
703         } else {
704             reset_pictures = false;
705         }
706
707         vlc_mutex_unlock(&osys->lock);
708
709         if (!ch_fullscreen &&
710             !ch_display_size &&
711             !reset_pictures &&
712             !osys->ch_display_filled &&
713             !osys->ch_zoom &&
714             !ch_wm_state &&
715             !osys->ch_sar &&
716             !osys->ch_crop)
717             break;
718
719         /* */
720         if (ch_fullscreen) {
721             vout_display_cfg_t cfg = osys->cfg;
722
723             cfg.is_fullscreen  = is_fullscreen;
724             cfg.display.width  = cfg.is_fullscreen ? 0 : osys->width_saved;
725             cfg.display.height = cfg.is_fullscreen ? 0 : osys->height_saved;
726
727             if (vout_display_Control(vd, VOUT_DISPLAY_CHANGE_FULLSCREEN, &cfg)) {
728                 msg_Err(vd, "Failed to set fullscreen");
729                 is_fullscreen = osys->cfg.is_fullscreen;
730             }
731             osys->cfg.is_fullscreen = is_fullscreen;
732
733             /* */
734             vout_SendEventFullscreen(osys->vout, osys->cfg.is_fullscreen);
735         }
736
737         /* */
738         if (ch_display_size) {
739             vout_display_cfg_t cfg = osys->cfg;
740             cfg.display.width  = display_width;
741             cfg.display.height = display_height;
742
743             if (!cfg.is_fullscreen != !display_is_fullscreen ||
744                 vout_display_Control(vd, VOUT_DISPLAY_CHANGE_DISPLAY_SIZE, &cfg, display_is_forced)) {
745                 if (!cfg.is_fullscreen == !display_is_fullscreen)
746                     msg_Err(vd, "Failed to resize display");
747
748                 /* We ignore the resized */
749                 display_width  = osys->cfg.display.width;
750                 display_height = osys->cfg.display.height;
751             }
752             osys->cfg.display.width  = display_width;
753             osys->cfg.display.height = display_height;
754
755             if (!display_is_fullscreen) {
756                 osys->width_saved  = display_width;
757                 osys->height_saved = display_height;
758             }
759         }
760         /* */
761         if (osys->ch_display_filled) {
762             vout_display_cfg_t cfg = osys->cfg;
763
764             cfg.is_display_filled = osys->is_display_filled;
765
766             if (vout_display_Control(vd, VOUT_DISPLAY_CHANGE_DISPLAY_FILLED, &cfg)) {
767                 msg_Err(vd, "Failed to change display filled state");
768                 osys->is_display_filled = osys->cfg.is_display_filled;
769             }
770             osys->cfg.is_display_filled = osys->is_display_filled;
771             osys->ch_display_filled = false;
772
773             vout_SendEventDisplayFilled(osys->vout, osys->cfg.is_display_filled);
774         }
775         /* */
776         if (osys->ch_zoom) {
777             vout_display_cfg_t cfg = osys->cfg;
778
779             cfg.zoom.num = osys->zoom.num;
780             cfg.zoom.den = osys->zoom.den;
781
782             if (10 * cfg.zoom.num <= cfg.zoom.den) {
783                 cfg.zoom.num = 1;
784                 cfg.zoom.den = 10;
785             } else if (cfg.zoom.num >= 10 * cfg.zoom.den) {
786                 cfg.zoom.num = 10;
787                 cfg.zoom.den = 1;
788             }
789
790             if (vout_display_Control(vd, VOUT_DISPLAY_CHANGE_ZOOM, &cfg)) {
791                 msg_Err(vd, "Failed to change zoom");
792                 osys->zoom.num = osys->cfg.zoom.num;
793                 osys->zoom.den = osys->cfg.zoom.den;
794             } else if (cfg.is_display_filled) {
795                 const int display_width  = (int64_t)vd->source.i_width  * osys->zoom.num / osys->zoom.den;
796                 const int display_height = (int64_t)vd->source.i_height * osys->zoom.num / osys->zoom.den;
797
798                 vlc_mutex_lock(&osys->lock);
799
800                 osys->ch_display_size       = true;
801                 osys->display_width         = display_width;
802                 osys->display_height        = display_height;
803                 osys->display_is_fullscreen = osys->cfg.is_fullscreen;
804                 osys->display_is_forced     = true;
805
806                 vlc_mutex_unlock(&osys->lock);
807             }
808
809             osys->cfg.zoom.num = osys->zoom.num;
810             osys->cfg.zoom.den = osys->zoom.den;
811             osys->ch_zoom = false;
812
813             vout_SendEventZoom(osys->vout, osys->cfg.zoom.num, osys->cfg.zoom.den);
814         }
815         /* */
816         if (ch_wm_state) {
817             if (vout_display_Control(vd, VOUT_DISPLAY_CHANGE_WINDOW_STATE, wm_state)) {
818                 msg_Err(vd, "Failed to set on top");
819                 wm_state = osys->wm_state;
820             }
821             osys->wm_state_initial = wm_state;
822
823             /* */
824             vout_SendEventOnTop(osys->vout, osys->wm_state_initial);
825         }
826         /* */
827         if (osys->ch_sar) {
828             video_format_t source = vd->source;
829
830             if (osys->sar.num > 0 && osys->sar.den > 0) {
831                 source.i_sar_num = osys->sar.num;
832                 source.i_sar_den = osys->sar.den;
833             } else {
834                 source.i_sar_num = osys->source.i_sar_num;
835                 source.i_sar_den = osys->source.i_sar_den;
836             }
837
838             if (vout_display_Control(vd, VOUT_DISPLAY_CHANGE_SOURCE_ASPECT, &source)) {
839                 /* There nothing much we can do. The only reason a vout display
840                  * does not support it is because it need the core to add black border
841                  * to the video for it.
842                  * TODO add black borders ?
843                  */
844                 msg_Err(vd, "Failed to change source AR");
845                 source = vd->source;
846             }
847             vd->source = source;
848             osys->sar.num = source.i_sar_num;
849             osys->sar.den = source.i_sar_den;
850             osys->ch_sar  = false;
851
852             /* */
853             if (osys->sar.num == osys->source.i_sar_num &&
854                 osys->sar.den == osys->source.i_sar_den)
855             {
856                 vout_SendEventSourceAspect(osys->vout, 0, 0);
857             }
858             else
859             {
860                 unsigned dar_num, dar_den;
861                 vlc_ureduce( &dar_num, &dar_den,
862                              osys->sar.num * vd->source.i_visible_width,
863                              osys->sar.den * vd->source.i_visible_height,
864                              65536);
865                 vout_SendEventSourceAspect(osys->vout, dar_num, dar_den);
866             }
867         }
868         /* */
869         if (osys->ch_crop) {
870             video_format_t source = vd->source;
871             unsigned crop_num = osys->crop.num;
872             unsigned crop_den = osys->crop.den;
873
874             source.i_x_offset       = osys->crop.x;
875             source.i_y_offset       = osys->crop.y;
876             source.i_visible_width  = osys->crop.width;
877             source.i_visible_height = osys->crop.height;
878
879             /* */
880             const bool is_valid = source.i_x_offset < source.i_width &&
881                                   source.i_y_offset < source.i_height &&
882                                   source.i_x_offset + source.i_visible_width  <= source.i_width &&
883                                   source.i_y_offset + source.i_visible_height <= source.i_height &&
884                                   source.i_visible_width > 0 && source.i_visible_height > 0;
885
886             if (!is_valid || vout_display_Control(vd, VOUT_DISPLAY_CHANGE_SOURCE_CROP, &source)) {
887                 if (is_valid)
888                     msg_Err(vd, "Failed to change source crop TODO implement crop at core");
889                 else
890                     msg_Err(vd, "Invalid crop requested");
891
892                 source = vd->source;
893                 crop_num = osys->crop_saved.num;
894                 crop_den = osys->crop_saved.den;
895                 /* FIXME implement cropping in the core if not supported by the
896                  * vout module (easy)
897                  */
898             }
899             vd->source = source;
900             osys->crop.x      = source.i_x_offset;
901             osys->crop.y      = source.i_y_offset;
902             osys->crop.width  = source.i_visible_width;
903             osys->crop.height = source.i_visible_height;
904             osys->crop.num    = crop_num;
905             osys->crop.den    = crop_den;
906             osys->ch_crop = false;
907
908             /* TODO fix when a ratio is used (complicated). */
909             const unsigned left   = osys->crop.x - osys->source.i_x_offset;
910             const unsigned top    = osys->crop.y - osys->source.i_y_offset;
911             const unsigned right  = osys->source.i_visible_width  - (osys->crop.width  + osys->crop.x);
912             const unsigned bottom = osys->source.i_visible_height - (osys->crop.height + osys->crop.y);
913             vout_SendEventSourceCrop(osys->vout,
914                                      osys->crop.num, osys->crop.den,
915                                      left, top, right, bottom);
916         }
917
918         /* */
919         if (reset_pictures) {
920             if (vout_display_Control(vd, VOUT_DISPLAY_RESET_PICTURES)) {
921                 /* FIXME what to do here ? */
922                 msg_Err(vd, "Failed to reset pictures (probably fatal)");
923             }
924             reset_render = true;
925         }
926     }
927     if (reset_render)
928         VoutDisplayResetRender(vd);
929 }
930
931 bool vout_AreDisplayPicturesInvalid(vout_display_t *vd)
932 {
933     vout_display_owner_sys_t *osys = vd->owner.sys;
934
935     vlc_mutex_lock(&osys->lock);
936     const bool reset_pictures = osys->reset_pictures;
937     vlc_mutex_unlock(&osys->lock);
938
939     return reset_pictures;
940 }
941
942 bool vout_IsDisplayFiltered(vout_display_t *vd)
943 {
944     vout_display_owner_sys_t *osys = vd->owner.sys;
945
946     return osys->filters != NULL;
947 }
948
949 picture_t *vout_FilterDisplay(vout_display_t *vd, picture_t *picture)
950 {
951     vout_display_owner_sys_t *osys = vd->owner.sys;
952
953     assert(osys->filters);
954     return filter_chain_VideoFilter(osys->filters, picture);
955 }
956
957 void vout_SetDisplayFullscreen(vout_display_t *vd, bool is_fullscreen)
958 {
959     vout_display_owner_sys_t *osys = vd->owner.sys;
960
961     vlc_mutex_lock(&osys->lock);
962     if (!osys->is_fullscreen != !is_fullscreen) {
963         osys->ch_fullscreen = true;
964         osys->is_fullscreen = is_fullscreen;
965     }
966     vlc_mutex_unlock(&osys->lock);
967 }
968
969 void vout_SetDisplayFilled(vout_display_t *vd, bool is_filled)
970 {
971     vout_display_owner_sys_t *osys = vd->owner.sys;
972
973     if (!osys->is_display_filled != !is_filled) {
974         osys->ch_display_filled = true;
975         osys->is_display_filled = is_filled;
976     }
977 }
978
979 void vout_SetDisplayZoom(vout_display_t *vd, int num, int den)
980 {
981     vout_display_owner_sys_t *osys = vd->owner.sys;
982
983     if (osys->zoom.num != num || osys->zoom.den != den) {
984         osys->ch_zoom = true;
985         osys->zoom.num = num;
986         osys->zoom.den = den;
987     }
988 }
989
990 void vout_SetWindowState(vout_display_t *vd, unsigned state)
991 {
992     vout_display_owner_sys_t *osys = vd->owner.sys;
993
994     vlc_mutex_lock(&osys->lock);
995     if (osys->wm_state != state) {
996         osys->ch_wm_state = true;
997         osys->wm_state = state;
998     }
999     vlc_mutex_unlock(&osys->lock);
1000 }
1001
1002 void vout_SetDisplayAspect(vout_display_t *vd, unsigned sar_num, unsigned sar_den)
1003 {
1004     vout_display_owner_sys_t *osys = vd->owner.sys;
1005
1006     if (osys->sar.num != sar_num || osys->sar.den != sar_den) {
1007         osys->ch_sar = true;
1008         osys->sar.num = sar_num;
1009         osys->sar.den = sar_den;
1010     }
1011 }
1012 void vout_SetDisplayCrop(vout_display_t *vd,
1013                          unsigned crop_num, unsigned crop_den,
1014                          unsigned x, unsigned y, unsigned width, unsigned height)
1015 {
1016     vout_display_owner_sys_t *osys = vd->owner.sys;
1017
1018     if (osys->crop.x != x || osys->crop.y != y ||
1019         osys->crop.width  != width || osys->crop.height != height) {
1020
1021         osys->crop.x      = x;
1022         osys->crop.y      = y;
1023         osys->crop.width  = width;
1024         osys->crop.height = height;
1025         osys->crop.num    = crop_num;
1026         osys->crop.den    = crop_den;
1027
1028         osys->ch_crop = true;
1029     }
1030 }
1031 vout_opengl_t *vout_GetDisplayOpengl(vout_display_t *vd)
1032 {
1033     vout_opengl_t *gl;
1034     if (vout_display_Control(vd, VOUT_DISPLAY_GET_OPENGL, &gl))
1035         return NULL;
1036     return gl;
1037 }
1038
1039 static vout_display_t *DisplayNew(vout_thread_t *vout,
1040                                   const video_format_t *source_org,
1041                                   const vout_display_state_t *state,
1042                                   const char *module,
1043                                   bool is_wrapper, vout_display_t *wrapper,
1044                                   mtime_t double_click_timeout,
1045                                   mtime_t hide_timeout,
1046                                   const vout_display_owner_t *owner_ptr)
1047 {
1048     /* */
1049     vout_display_owner_sys_t *osys = calloc(1, sizeof(*osys));
1050     vout_display_cfg_t *cfg = &osys->cfg;
1051
1052     *cfg = state->cfg;
1053     osys->wm_state_initial = state->is_on_top
1054         ? VOUT_WINDOW_STATE_ABOVE : VOUT_WINDOW_STATE_NORMAL;
1055     osys->sar_initial.num = state->sar.num;
1056     osys->sar_initial.den = state->sar.den;
1057     vout_display_GetDefaultDisplaySize(&cfg->display.width, &cfg->display.height,
1058                                        source_org, cfg);
1059
1060     osys->vout = vout;
1061     osys->is_wrapper = is_wrapper;
1062     osys->wrapper = wrapper;
1063
1064     vlc_mutex_init(&osys->lock);
1065
1066     vlc_mouse_Init(&osys->mouse.state);
1067     osys->mouse.last_moved = mdate();
1068     osys->mouse.double_click_timeout = double_click_timeout;
1069     osys->mouse.hide_timeout = hide_timeout;
1070     osys->is_fullscreen  = cfg->is_fullscreen;
1071     osys->width_saved    =
1072     osys->display_width  = cfg->display.width;
1073     osys->height_saved   =
1074     osys->display_height = cfg->display.height;
1075     osys->is_display_filled = cfg->is_display_filled;
1076     osys->zoom.num = cfg->zoom.num;
1077     osys->zoom.den = cfg->zoom.den;
1078
1079     osys->source = *source_org;
1080
1081     video_format_t source = *source_org;
1082
1083     source.i_x_offset =
1084     osys->crop.x  = 0;
1085     source.i_y_offset =
1086     osys->crop.y  = 0;
1087     source.i_visible_width  =
1088     osys->crop.width    = source.i_width;
1089     source.i_visible_height =
1090     osys->crop.height   = source.i_height;
1091     osys->crop_saved.num = 0;
1092     osys->crop_saved.den = 0;
1093     osys->crop.num = 0;
1094     osys->crop.den = 0;
1095
1096     osys->sar.num = osys->sar_initial.num ? osys->sar_initial.num : source.i_sar_num;
1097     osys->sar.den = osys->sar_initial.den ? osys->sar_initial.den : source.i_sar_den;
1098 #ifdef ALLOW_DUMMY_VOUT
1099     vlc_mouse_Init(&osys->vout_mouse);
1100 #endif
1101
1102     vout_display_owner_t owner;
1103     if (owner_ptr) {
1104         owner = *owner_ptr;
1105     } else {
1106         owner.event      = VoutDisplayEvent;
1107         owner.window_new = VoutDisplayNewWindow;
1108         owner.window_del = VoutDisplayDelWindow;
1109     }
1110     owner.sys = osys;
1111
1112     /* */
1113     vout_display_t *p_display = vout_display_New(VLC_OBJECT(vout),
1114                                                  module, !is_wrapper,
1115                                                  &source, cfg, &owner);
1116     if (!p_display) {
1117         free(osys);
1118         return NULL;
1119     }
1120
1121     VoutDisplayCreateRender(p_display);
1122
1123     /* Setup delayed request */
1124     if (osys->sar.num != source_org->i_sar_num ||
1125         osys->sar.den != source_org->i_sar_den)
1126         osys->ch_sar = true;
1127     if (osys->wm_state != VOUT_WINDOW_STATE_NORMAL)
1128         osys->ch_wm_state = true;
1129     if (osys->crop.x      != source_org->i_x_offset ||
1130         osys->crop.y      != source_org->i_y_offset ||
1131         osys->crop.width  != source_org->i_visible_width ||
1132         osys->crop.height != source_org->i_visible_height)
1133         osys->ch_crop = true;
1134
1135     return p_display;
1136 }
1137
1138 void vout_DeleteDisplay(vout_display_t *vd, vout_display_state_t *state)
1139 {
1140     vout_display_owner_sys_t *osys = vd->owner.sys;
1141
1142     if (state) {
1143         if (!osys->is_wrapper )
1144             state->cfg = osys->cfg;
1145         state->is_on_top = (osys->wm_state & VOUT_WINDOW_STATE_ABOVE) != 0;
1146         state->sar.num   = osys->sar_initial.num;
1147         state->sar.den   = osys->sar_initial.den;
1148     }
1149
1150     VoutDisplayDestroyRender(vd);
1151     if (osys->is_wrapper)
1152         SplitterClose(vd);
1153     vout_display_Delete(vd);
1154     vlc_mutex_destroy(&osys->lock);
1155     free(osys);
1156 }
1157
1158 /*****************************************************************************
1159  *
1160  *****************************************************************************/
1161 vout_display_t *vout_NewDisplay(vout_thread_t *vout,
1162                                 const video_format_t *source,
1163                                 const vout_display_state_t *state,
1164                                 const char *module,
1165                                 mtime_t double_click_timeout,
1166                                 mtime_t hide_timeout)
1167 {
1168     return DisplayNew(vout, source, state, module, false, NULL,
1169                       double_click_timeout, hide_timeout, NULL);
1170 }
1171
1172 static void SplitterClose(vout_display_t *vd)
1173 {
1174     VLC_UNUSED(vd);
1175     assert(0);
1176 }
1177
1178 #if 0
1179 /*****************************************************************************
1180  *
1181  *****************************************************************************/
1182 struct vout_display_sys_t {
1183     video_splitter_t *splitter;
1184
1185     /* */
1186     int            count;
1187     picture_t      **picture;
1188     vout_display_t **display;
1189 };
1190 struct video_splitter_owner_t {
1191     vout_display_t *wrapper;
1192 };
1193
1194 static vout_window_t *SplitterNewWindow(vout_display_t *vd, const vout_window_cfg_t *cfg_ptr)
1195 {
1196     vout_display_owner_sys_t *osys = vd->owner.sys;
1197
1198     vout_window_cfg_t cfg = *cfg_ptr;
1199     cfg.is_standalone = true;
1200     cfg.x += 0;//output->window.i_x; FIXME
1201     cfg.y += 0;//output->window.i_y;
1202
1203     return vout_NewDisplayWindow(osys->vout, vd, &cfg);
1204 }
1205 static void SplitterDelWindow(vout_display_t *vd, vout_window_t *window)
1206 {
1207     vout_display_owner_sys_t *osys = vd->owner.sys;
1208
1209     vout_DeleteDisplayWindow(osys->vout, vd, window);
1210 }
1211 static void SplitterEvent(vout_display_t *vd, int event, va_list args)
1212 {
1213     vout_display_owner_sys_t *osys = vd->owner.sys;
1214
1215     switch (event) {
1216 #if 0
1217     case VOUT_DISPLAY_EVENT_MOUSE_STATE:
1218     case VOUT_DISPLAY_EVENT_MOUSE_MOVED:
1219     case VOUT_DISPLAY_EVENT_MOUSE_PRESSED:
1220     case VOUT_DISPLAY_EVENT_MOUSE_RELEASED:
1221         /* TODO */
1222         break;
1223 #endif
1224     case VOUT_DISPLAY_EVENT_MOUSE_DOUBLE_CLICK:
1225     case VOUT_DISPLAY_EVENT_KEY:
1226     case VOUT_DISPLAY_EVENT_CLOSE:
1227     case VOUT_DISPLAY_EVENT_FULLSCREEN:
1228     case VOUT_DISPLAY_EVENT_DISPLAY_SIZE:
1229     case VOUT_DISPLAY_EVENT_PICTURES_INVALID:
1230         VoutDisplayEvent(vd, event, args);
1231         break;
1232
1233     default:
1234         msg_Err(vd, "SplitterEvent TODO");
1235         break;
1236     }
1237 }
1238
1239 static picture_t *SplitterGet(vout_display_t *vd)
1240 {
1241     /* TODO pool ? */
1242     return picture_NewFromFormat(&vd->fmt);
1243 }
1244 static void SplitterPrepare(vout_display_t *vd, picture_t *picture)
1245 {
1246     vout_display_sys_t *sys = vd->sys;
1247
1248     picture_Hold(picture);
1249
1250     if (video_splitter_Filter(sys->splitter, sys->picture, picture)) {
1251         for (int i = 0; i < sys->count; i++)
1252             sys->picture[i] = NULL;
1253         picture_Release(picture);
1254         return;
1255     }
1256
1257     for (int i = 0; i < sys->count; i++) {
1258         /* */
1259         /* FIXME now vout_FilterDisplay already return a direct buffer FIXME */
1260         sys->picture[i] = vout_FilterDisplay(sys->display[i], sys->picture[i]);
1261         if (!sys->picture[i])
1262             continue;
1263
1264         /* */
1265         picture_t *direct = vout_display_Get(sys->display[i]);
1266         if (!direct) {
1267             msg_Err(vd, "Failed to get a direct buffer");
1268             picture_Release(sys->picture[i]);
1269             sys->picture[i] = NULL;
1270             continue;
1271         }
1272
1273         /* FIXME not always needed (easy when there is a osys->filters) */
1274         picture_Copy(direct, sys->picture[i]);
1275         picture_Release(sys->picture[i]);
1276         sys->picture[i] = direct;
1277
1278         vout_display_Prepare(sys->display[i], sys->picture[i]);
1279     }
1280 }
1281 static void SplitterDisplay(vout_display_t *vd, picture_t *picture)
1282 {
1283     vout_display_sys_t *sys = vd->sys;
1284
1285     for (int i = 0; i < sys->count; i++) {
1286         if (sys->picture[i])
1287             vout_display_Display(sys->display[i], sys->picture[i]);
1288     }
1289     picture_Release(picture);
1290 }
1291 static int SplitterControl(vout_display_t *vd, int query, va_list args)
1292 {
1293     return VLC_EGENERIC;
1294 }
1295 static void SplitterManage(vout_display_t *vd)
1296 {
1297     vout_display_sys_t *sys = vd->sys;
1298
1299     for (int i = 0; i < sys->count; i++)
1300         vout_ManageDisplay(sys->display[i]);
1301 }
1302
1303 static int SplitterPictureNew(video_splitter_t *splitter, picture_t *picture[])
1304 {
1305     vout_display_sys_t *wsys = splitter->p_owner->wrapper->sys;
1306
1307     for (int i = 0; i < wsys->count; i++) {
1308         /* TODO pool ? */
1309         picture[i] = picture_NewFromFormat(&wsys->display[i]->source);
1310         if (!picture[i]) {
1311             for (int j = 0; j < i; j++)
1312                 picture_Release(picture[j]);
1313             return VLC_EGENERIC;
1314         }
1315     }
1316     return VLC_SUCCESS;
1317 }
1318 static void SplitterPictureDel(video_splitter_t *splitter, picture_t *picture[])
1319 {
1320     vout_display_sys_t *wsys = splitter->p_owner->wrapper->sys;
1321
1322     for (int i = 0; i < wsys->count; i++)
1323         picture_Release(picture[i]);
1324 }
1325 static void SplitterClose(vout_display_t *vd)
1326 {
1327     vout_display_sys_t *sys = vd->sys;
1328
1329     /* */
1330     video_splitter_t *splitter = sys->splitter;
1331     free(splitter->p_owner);
1332     video_splitter_Delete(splitter);
1333
1334     /* */
1335     for (int i = 0; i < sys->count; i++)
1336         vout_DeleteDisplay(sys->display[i], NULL);
1337     TAB_CLEAN(sys->count, sys->display);
1338     free(sys->picture);
1339
1340     free(sys);
1341 }
1342
1343 vout_display_t *vout_NewSplitter(vout_thread_t *vout,
1344                                  const video_format_t *source,
1345                                  const vout_display_state_t *state,
1346                                  const char *module,
1347                                  const char *splitter_module,
1348                                  mtime_t double_click_timeout,
1349                                  mtime_t hide_timeout)
1350 {
1351     video_splitter_t *splitter =
1352         video_splitter_New(VLC_OBJECT(vout), splitter_module, source);
1353     if (!splitter)
1354         return NULL;
1355
1356     /* */
1357     vout_display_t *wrapper =
1358         DisplayNew(vout, source, state, module, true, NULL,
1359                     double_click_timeout, hide_timeout, NULL);
1360     if (!wrapper) {
1361         video_splitter_Delete(splitter);
1362         return NULL;
1363     }
1364     vout_display_sys_t *sys = malloc(sizeof(*sys));
1365     if (!sys)
1366         abort();
1367     sys->picture = calloc(splitter->i_output, sizeof(*sys->picture));
1368     if (!sys->picture )
1369         abort();
1370     sys->splitter = splitter;
1371
1372     wrapper->get     = SplitterGet;
1373     wrapper->prepare = SplitterPrepare;
1374     wrapper->display = SplitterDisplay;
1375     wrapper->control = SplitterControl;
1376     wrapper->manage  = SplitterManage;
1377     wrapper->sys     = sys;
1378
1379     /* */
1380     video_splitter_owner_t *owner = malloc(sizeof(*owner));
1381     if (!owner)
1382         abort();
1383     owner->wrapper = wrapper;
1384     splitter->p_owner = owner;
1385     splitter->pf_picture_new = SplitterPictureNew;
1386     splitter->pf_picture_del = SplitterPictureDel;
1387
1388     /* */
1389     TAB_INIT(sys->count, sys->display);
1390     for (int i = 0; i < splitter->i_output; i++) {
1391         vout_display_owner_t owner;
1392
1393         owner.event      = SplitterEvent;
1394         owner.window_new = SplitterNewWindow;
1395         owner.window_del = SplitterDelWindow;
1396
1397         const video_splitter_output_t *output = &splitter->p_output[i];
1398         vout_display_state_t ostate;
1399
1400         memset(&ostate, 0, sizeof(ostate));
1401         ostate.cfg.is_fullscreen = false;
1402         ostate.cfg.display = state->cfg.display;
1403         ostate.cfg.align.horizontal = 0; /* TODO */
1404         ostate.cfg.align.vertical = 0; /* TODO */
1405         ostate.cfg.is_display_filled = true;
1406         ostate.cfg.zoom.num = 1;
1407         ostate.cfg.zoom.den = 1;
1408
1409         vout_display_t *vd = DisplayNew(vout, &output->fmt, &ostate,
1410                                            output->psz_module ? output->psz_module : module,
1411                                            false, wrapper,
1412                                            double_click_timeout, hide_timeout, &owner);
1413         if (!vd) {
1414             vout_DeleteDisplay(wrapper, NULL);
1415             return NULL;
1416         }
1417         TAB_APPEND(sys->count, sys->display, vd);
1418     }
1419
1420     return wrapper;
1421 }
1422 #endif
1423
1424 /*****************************************************************************
1425  * TODO move out
1426  *****************************************************************************/
1427 #include "vout_internal.h"
1428 void vout_SendDisplayEventMouse(vout_thread_t *vout, const vlc_mouse_t *m)
1429 {
1430     if (vlc_mouse_HasMoved(&vout->p->mouse, m)) {
1431         vout_SendEventMouseMoved(vout, m->i_x, m->i_y);
1432     }
1433     if (vlc_mouse_HasButton(&vout->p->mouse, m)) {
1434         static const int buttons[] = {
1435             MOUSE_BUTTON_LEFT,
1436             MOUSE_BUTTON_CENTER,
1437             MOUSE_BUTTON_RIGHT,
1438             MOUSE_BUTTON_WHEEL_UP,
1439             MOUSE_BUTTON_WHEEL_DOWN,
1440             -1
1441         };
1442         for (int i = 0; buttons[i] >= 0; i++) {
1443             const int button = buttons[i];
1444             if (vlc_mouse_HasPressed(&vout->p->mouse, m, button))
1445                 vout_SendEventMousePressed(vout, button);
1446             else if (vlc_mouse_HasReleased(&vout->p->mouse, m, button))
1447                 vout_SendEventMouseReleased(vout, button);
1448         }
1449     }
1450     if (m->b_double_click)
1451         vout_SendEventMouseDoubleClick(vout);
1452     vout->p->mouse = *m;
1453 }
1454 #ifdef ALLOW_DUMMY_VOUT
1455 static void DummyVoutSendDisplayEventMouse(vout_thread_t *vout, vlc_mouse_t *fallback, const vlc_mouse_t *m)
1456 {
1457     vout_thread_sys_t p;
1458
1459     if (!vout->p) {
1460         p.mouse = *fallback;
1461         vout->p = &p;
1462     }
1463     vout_SendDisplayEventMouse(vout, m);
1464     if (vout->p == &p) {
1465         *fallback = p.mouse;
1466         vout->p = NULL;
1467     }
1468 }
1469 #endif
1470 vout_window_t * vout_NewDisplayWindow(vout_thread_t *vout, vout_display_t *vd, const vout_window_cfg_t *cfg)
1471 {
1472     VLC_UNUSED(vd);
1473     vout_window_cfg_t cfg_override = *cfg;
1474
1475     if( !var_InheritBool( vout, "embedded-video" ) )
1476         cfg_override.is_standalone = true;
1477
1478     return vout_window_New(VLC_OBJECT(vout), NULL, &cfg_override);
1479 }
1480 void vout_DeleteDisplayWindow(vout_thread_t *vout, vout_display_t *vd, vout_window_t *window)
1481 {
1482     VLC_UNUSED(vout);
1483     VLC_UNUSED(vd);
1484     vout_window_Delete(window);
1485 }
1486