git.sesse.net Git - vlc/blob - src/video_output/video_output.c

   1 /*****************************************************************************
   2  * video_output.c : video output thread
   3  *
   4  * This module describes the programming interface for video output threads.
   5  * It includes functions allowing to open a new thread, send pictures to a
   6  * thread, and destroy a previously oppened video output thread.
   7  *****************************************************************************
   8  * Copyright (C) 2000-2007 the VideoLAN team
   9  * $Id$
  10  *
  11  * Authors: Vincent Seguin <seguin@via.ecp.fr>
  12  *          Gildas Bazin <gbazin@videolan.org>
  13  *
  14  * This program is free software; you can redistribute it and/or modify
  15  * it under the terms of the GNU General Public License as published by
  16  * the Free Software Foundation; either version 2 of the License, or
  17  * (at your option) any later version.
  18  *
  19  * This program is distributed in the hope that it will be useful,
  20  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  21  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  22  * GNU General Public License for more details.
  23  *
  24  * You should have received a copy of the GNU General Public License
  25  * along with this program; if not, write to the Free Software
  26  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  27  *****************************************************************************/
  28
  29 /*****************************************************************************
  30  * Preamble
  31  *****************************************************************************/
  32 #ifdef HAVE_CONFIG_H
  33 # include "config.h"
  34 #endif
  35
  36 #include <vlc_common.h>
  37
  38 #include <stdlib.h>                                                /* free() */
  39 #include <string.h>
  40
  41 #include <vlc_vout.h>
  42
  43 #include <vlc_filter.h>
  44 #include <vlc_osd.h>
  45 #include <assert.h>
  46
  47 #if defined( __APPLE__ )
  48 /* Include darwin_specific.h here if needed */
  49 #endif
  50
  51 /** FIXME This is quite ugly but needed while we don't have counters
  52  * helpers */
  53 //#include "input/input_internal.h"
  54
  55 #include <libvlc.h>
  56 #include <vlc_input.h>
  57 #include "vout_pictures.h"
  58 #include "vout_internal.h"
  59
  60 /*****************************************************************************
  61  * Local prototypes
  62  *****************************************************************************/
  63 static int      InitThread        ( vout_thread_t * );
  64 static void*    RunThread         ( void *  );
  65 static void     ErrorThread       ( vout_thread_t * );
  66 static void     CleanThread       ( vout_thread_t * );
  67 static void     EndThread         ( vout_thread_t * );
  68
  69 static void VideoFormatImportRgb( video_format_t *, const picture_heap_t * );
  70 static void PictureHeapFixRgb( picture_heap_t * );
  71
  72 static void     vout_Destructor   ( vlc_object_t * p_this );
  73
  74 /* Object variables callbacks */
  75 static int FilterCallback( vlc_object_t *, char const *,
  76                            vlc_value_t, vlc_value_t, void * );
  77 static int VideoFilter2Callback( vlc_object_t *, char const *,
  78                                  vlc_value_t, vlc_value_t, void * );
  79
  80 /* */
  81 static void PostProcessEnable( vout_thread_t * );
  82 static void PostProcessDisable( vout_thread_t * );
  83 static void PostProcessSetFilterQuality( vout_thread_t *p_vout );
  84 static int  PostProcessCallback( vlc_object_t *, char const *,
  85                                  vlc_value_t, vlc_value_t, void * );
  86 /* */
  87 static void DeinterlaceEnable( vout_thread_t * );
  88 static void DeinterlaceNeeded( vout_thread_t *, bool );
  89
  90 /* From vout_intf.c */
  91 int vout_Snapshot( vout_thread_t *, picture_t * );
  92
  93 /* Display media title in OSD */
  94 static void DisplayTitleOnOSD( vout_thread_t *p_vout );
  95
  96 /* Time during which the thread will sleep if it has nothing to
  97  * display (in micro-seconds) */
  98 #define VOUT_IDLE_SLEEP                 ((int)(0.020*CLOCK_FREQ))
  99
 100 /* Maximum lap of time allowed between the beginning of rendering and
 101  * display. If, compared to the current date, the next image is too
 102  * late, the thread will perform an idle loop. This time should be
 103  * at least VOUT_IDLE_SLEEP plus the time required to render a few
 104  * images, to avoid trashing of decoded images */
 105 #define VOUT_DISPLAY_DELAY              ((int)(0.200*CLOCK_FREQ))
 106
 107 /* Better be in advance when awakening than late... */
 108 #define VOUT_MWAIT_TOLERANCE            ((mtime_t)(0.020*CLOCK_FREQ))
 109
 110 /* Minimum number of direct pictures the video output will accept without
 111  * creating additional pictures in system memory */
 112 #ifdef OPTIMIZE_MEMORY
 113 #   define VOUT_MIN_DIRECT_PICTURES        (VOUT_MAX_PICTURES/2)
 114 #else
 115 #   define VOUT_MIN_DIRECT_PICTURES        (3*VOUT_MAX_PICTURES/4)
 116 #endif
 117
 118 /*****************************************************************************
 119  * Video Filter2 functions
 120  *****************************************************************************/
 121 static picture_t *video_new_buffer_filter( filter_t *p_filter )
 122 {
 123     vout_thread_t *p_vout = (vout_thread_t*)p_filter->p_owner;
 124     picture_t *p_picture = vout_CreatePicture( p_vout, 0, 0, 0 );
 125
 126     p_picture->i_status = READY_PICTURE;
 127
 128     return p_picture;
 129 }
 130
 131 static void video_del_buffer_filter( filter_t *p_filter, picture_t *p_pic )
 132 {
 133     vout_thread_t *p_vout = (vout_thread_t*)p_filter->p_owner;
 134
 135     vlc_mutex_lock( &p_vout->picture_lock );
 136     vout_UsePictureLocked( p_vout, p_pic );
 137     vlc_mutex_unlock( &p_vout->picture_lock );
 138 }
 139
 140 static int video_filter_buffer_allocation_init( filter_t *p_filter, void *p_data )
 141 {
 142     p_filter->pf_video_buffer_new = video_new_buffer_filter;
 143     p_filter->pf_video_buffer_del = video_del_buffer_filter;
 144     p_filter->p_owner = p_data; /* p_vout */
 145     return VLC_SUCCESS;
 146 }
 147
 148 #undef vout_Request
 149 /*****************************************************************************
 150  * vout_Request: find a video output thread, create one, or destroy one.
 151  *****************************************************************************
 152  * This function looks for a video output thread matching the current
 153  * properties. If not found, it spawns a new one.
 154  *****************************************************************************/
 155 vout_thread_t *vout_Request( vlc_object_t *p_this, vout_thread_t *p_vout,
 156                              video_format_t *p_fmt )
 157 {
 158     if( !p_fmt )
 159     {
 160         /* Video output is no longer used.
 161          * TODO: support for reusing video outputs with proper _thread-safe_
 162          * reference handling. */
 163         if( p_vout )
 164             vout_CloseAndRelease( p_vout );
 165         return NULL;
 166     }
 167
 168     /* If a video output was provided, lock it, otherwise look for one. */
 169     if( p_vout )
 170     {
 171         vlc_object_hold( p_vout );
 172     }
 173
 174     /* TODO: find a suitable unused video output */
 175
 176     /* If we now have a video output, check it has the right properties */
 177     if( p_vout )
 178     {
 179         vlc_mutex_lock( &p_vout->change_lock );
 180
 181         /* We don't directly check for the "vout-filter" variable for obvious
 182          * performance reasons. */
 183         if( p_vout->p->b_filter_change )
 184         {
 185             char *psz_filter_chain = var_GetString( p_vout, "vout-filter" );
 186
 187             if( psz_filter_chain && !*psz_filter_chain )
 188             {
 189                 free( psz_filter_chain );
 190                 psz_filter_chain = NULL;
 191             }
 192             if( p_vout->p->psz_filter_chain && !*p_vout->p->psz_filter_chain )
 193             {
 194                 free( p_vout->p->psz_filter_chain );
 195                 p_vout->p->psz_filter_chain = NULL;
 196             }
 197
 198             if( !psz_filter_chain && !p_vout->p->psz_filter_chain )
 199             {
 200                 p_vout->p->b_filter_change = false;
 201             }
 202
 203             free( psz_filter_chain );
 204         }
 205
 206         if( p_vout->fmt_render.i_chroma != vlc_fourcc_GetCodec( VIDEO_ES, p_fmt->i_chroma ) ||
 207             p_vout->fmt_render.i_width != p_fmt->i_width ||
 208             p_vout->fmt_render.i_height != p_fmt->i_height ||
 209             p_vout->p->b_filter_change )
 210         {
 211             vlc_mutex_unlock( &p_vout->change_lock );
 212
 213             /* We are not interested in this format, close this vout */
 214             vout_CloseAndRelease( p_vout );
 215             vlc_object_release( p_vout );
 216             p_vout = NULL;
 217         }
 218         else
 219         {
 220             /* This video output is cool! Hijack it. */
 221             /* Correct aspect ratio on change
 222              * FIXME factorize this code with other aspect ration related code */
 223             unsigned int i_sar_num;
 224             unsigned int i_sar_den;
 225             vlc_ureduce( &i_sar_num, &i_sar_den,
 226                          p_fmt->i_sar_num, p_fmt->i_sar_den, 50000 );
 227 #if 0
 228             /* What's that, it does not seems to be used correcly everywhere */
 229             if( p_vout->i_par_num > 0 && p_vout->i_par_den > 0 )
 230             {
 231                 i_sar_num *= p_vout->i_par_den;
 232                 i_sar_den *= p_vout->i_par_num;
 233             }
 234 #endif
 235
 236             if( i_sar_num > 0 && i_sar_den > 0 &&
 237                 ( i_sar_num != p_vout->fmt_render.i_sar_num ||
 238                   i_sar_den != p_vout->fmt_render.i_sar_den ) )
 239             {
 240                 p_vout->fmt_in.i_sar_num = i_sar_num;
 241                 p_vout->fmt_in.i_sar_den = i_sar_den;
 242
 243                 p_vout->fmt_render.i_sar_num = i_sar_num;
 244                 p_vout->fmt_render.i_sar_den = i_sar_den;
 245
 246                 p_vout->render.i_aspect = (int64_t)i_sar_num *
 247                                                    p_vout->fmt_render.i_width *
 248                                                    VOUT_ASPECT_FACTOR /
 249                                                    i_sar_den /
 250                                                    p_vout->fmt_render.i_height;
 251                 p_vout->i_changes |= VOUT_ASPECT_CHANGE;
 252             }
 253             vlc_mutex_unlock( &p_vout->change_lock );
 254
 255             vlc_object_release( p_vout );
 256         }
 257
 258         if( p_vout )
 259         {
 260             msg_Dbg( p_this, "reusing provided vout" );
 261
 262             spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), false );
 263             vlc_object_detach( p_vout );
 264
 265             vlc_object_attach( p_vout, p_this );
 266             spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), true );
 267         }
 268     }
 269
 270     if( !p_vout )
 271     {
 272         msg_Dbg( p_this, "no usable vout present, spawning one" );
 273
 274         p_vout = vout_Create( p_this, p_fmt );
 275     }
 276
 277     return p_vout;
 278 }
 279
 280 #undef vout_Create
 281 /*****************************************************************************
 282  * vout_Create: creates a new video output thread
 283  *****************************************************************************
 284  * This function creates a new video output thread, and returns a pointer
 285  * to its description. On error, it returns NULL.
 286  *****************************************************************************/
 287 vout_thread_t * vout_Create( vlc_object_t *p_parent, video_format_t *p_fmt )
 288 {
 289     vout_thread_t  * p_vout;                            /* thread descriptor */
 290     int              i_index;                               /* loop variable */
 291     vlc_value_t      text;
 292
 293     unsigned int i_width = p_fmt->i_width;
 294     unsigned int i_height = p_fmt->i_height;
 295     vlc_fourcc_t i_chroma = vlc_fourcc_GetCodec( VIDEO_ES, p_fmt->i_chroma );
 296
 297     config_chain_t *p_cfg;
 298     char *psz_parser;
 299     char *psz_name;
 300
 301     if( i_width <= 0 || i_height <= 0 )
 302         return NULL;
 303
 304     vlc_ureduce( &p_fmt->i_sar_num, &p_fmt->i_sar_den,
 305                  p_fmt->i_sar_num, p_fmt->i_sar_den, 50000 );
 306     if( p_fmt->i_sar_num <= 0 || p_fmt->i_sar_den <= 0 )
 307         return NULL;
 308     unsigned int i_aspect = (int64_t)p_fmt->i_sar_num *
 309                                      i_width *
 310                                      VOUT_ASPECT_FACTOR /
 311                                      p_fmt->i_sar_den /
 312                                      i_height;
 313
 314     /* Allocate descriptor */
 315     static const char typename[] = "video output";
 316     p_vout = vlc_custom_create( p_parent, sizeof( *p_vout ), VLC_OBJECT_VOUT,
 317                                 typename );
 318     if( p_vout == NULL )
 319         return NULL;
 320
 321     /* */
 322     p_vout->p = calloc( 1, sizeof(*p_vout->p) );
 323     if( !p_vout->p )
 324     {
 325         vlc_object_release( p_vout );
 326         return NULL;
 327     }
 328
 329     /* Initialize pictures - translation tables and functions
 330      * will be initialized later in InitThread */
 331     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++)
 332     {
 333         p_vout->p_picture[i_index].i_status = FREE_PICTURE;
 334         p_vout->p_picture[i_index].i_type   = EMPTY_PICTURE;
 335         p_vout->p_picture[i_index].b_slow   = 0;
 336     }
 337
 338     /* No images in the heap */
 339     p_vout->i_heap_size = 0;
 340
 341     /* Initialize the rendering heap */
 342     I_RENDERPICTURES = 0;
 343
 344     p_vout->fmt_render        = *p_fmt;   /* FIXME palette */
 345     p_vout->fmt_in            = *p_fmt;   /* FIXME palette */
 346
 347     p_vout->render.i_width    = i_width;
 348     p_vout->render.i_height   = i_height;
 349     p_vout->render.i_chroma   = i_chroma;
 350     p_vout->render.i_aspect   = i_aspect;
 351
 352     p_vout->render.i_rmask    = p_fmt->i_rmask;
 353     p_vout->render.i_gmask    = p_fmt->i_gmask;
 354     p_vout->render.i_bmask    = p_fmt->i_bmask;
 355
 356     p_vout->render.i_last_used_pic = -1;
 357     p_vout->render.b_allow_modify_pics = 1;
 358
 359     /* Zero the output heap */
 360     I_OUTPUTPICTURES = 0;
 361     p_vout->output.i_width    = 0;
 362     p_vout->output.i_height   = 0;
 363     p_vout->output.i_chroma   = 0;
 364     p_vout->output.i_aspect   = 0;
 365
 366     p_vout->output.i_rmask    = 0;
 367     p_vout->output.i_gmask    = 0;
 368     p_vout->output.i_bmask    = 0;
 369
 370     /* Initialize misc stuff */
 371     p_vout->i_changes    = 0;
 372     p_vout->b_autoscale  = 1;
 373     p_vout->i_zoom      = ZOOM_FP_FACTOR;
 374     p_vout->b_fullscreen = 0;
 375     p_vout->i_alignment  = 0;
 376     p_vout->p->render_time  = 10;
 377     p_vout->p->c_fps_samples = 0;
 378     vout_statistic_Init( &p_vout->p->statistic );
 379     p_vout->p->b_filter_change = 0;
 380     p_vout->p->b_paused = false;
 381     p_vout->p->i_pause_date = 0;
 382     p_vout->p->i_par_num =
 383     p_vout->p->i_par_den = 1;
 384     p_vout->p->p_picture_displayed = NULL;
 385     p_vout->p->i_picture_displayed_date = 0;
 386     p_vout->p->b_picture_displayed = false;
 387     p_vout->p->b_picture_empty = false;
 388     p_vout->p->i_picture_qtype = QTYPE_NONE;
 389     p_vout->p->b_picture_interlaced = false;
 390
 391     vlc_mouse_Init( &p_vout->p->mouse );
 392
 393     vout_snapshot_Init( &p_vout->p->snapshot );
 394
 395     /* Initialize locks */
 396     vlc_mutex_init( &p_vout->picture_lock );
 397     vlc_cond_init( &p_vout->p->picture_wait );
 398     vlc_mutex_init( &p_vout->change_lock );
 399     vlc_mutex_init( &p_vout->p->vfilter_lock );
 400
 401     /* Mouse coordinates */
 402     var_Create( p_vout, "mouse-button-down", VLC_VAR_INTEGER );
 403     var_Create( p_vout, "mouse-moved", VLC_VAR_COORDS );
 404     var_Create( p_vout, "mouse-clicked", VLC_VAR_COORDS );
 405     /* Mouse object (area of interest in a video filter) */
 406     var_Create( p_vout, "mouse-object", VLC_VAR_BOOL );
 407
 408     /* Attach the new object now so we can use var inheritance below */
 409     vlc_object_attach( p_vout, p_parent );
 410
 411     /* Initialize subpicture unit */
 412     p_vout->p_spu = spu_Create( p_vout );
 413
 414     /* */
 415     spu_Init( p_vout->p_spu );
 416
 417     spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), true );
 418
 419     /* Take care of some "interface/control" related initialisations */
 420     vout_IntfInit( p_vout );
 421
 422     /* If the parent is not a VOUT object, that means we are at the start of
 423      * the video output pipe */
 424     if( vlc_internals( p_parent )->i_object_type != VLC_OBJECT_VOUT )
 425     {
 426         /* Look for the default filter configuration */
 427         p_vout->p->psz_filter_chain =
 428             var_CreateGetStringCommand( p_vout, "vout-filter" );
 429
 430         /* Apply video filter2 objects on the first vout */
 431         p_vout->p->psz_vf2 =
 432             var_CreateGetStringCommand( p_vout, "video-filter" );
 433
 434         p_vout->p->b_first_vout = true;
 435     }
 436     else
 437     {
 438         /* continue the parent's filter chain */
 439         char *psz_tmp;
 440
 441         /* Ugly hack to jump to our configuration chain */
 442         p_vout->p->psz_filter_chain
 443             = ((vout_thread_t *)p_parent)->p->psz_filter_chain;
 444         p_vout->p->psz_filter_chain
 445             = config_ChainCreate( &psz_tmp, &p_cfg, p_vout->p->psz_filter_chain );
 446         config_ChainDestroy( p_cfg );
 447         free( psz_tmp );
 448
 449         /* Create a video filter2 var ... but don't inherit values */
 450         var_Create( p_vout, "video-filter",
 451                     VLC_VAR_STRING | VLC_VAR_ISCOMMAND );
 452         p_vout->p->psz_vf2 = var_GetString( p_vout, "video-filter" );
 453
 454         /* */
 455         p_vout->p->b_first_vout = false;
 456     }
 457
 458     var_AddCallback( p_vout, "video-filter", VideoFilter2Callback, NULL );
 459     p_vout->p->p_vf2_chain = filter_chain_New( p_vout, "video filter2",
 460         false, video_filter_buffer_allocation_init, NULL, p_vout );
 461
 462     /* Choose the video output module */
 463     if( !p_vout->p->psz_filter_chain || !*p_vout->p->psz_filter_chain )
 464     {
 465         psz_parser = NULL;
 466     }
 467     else
 468     {
 469         psz_parser = strdup( p_vout->p->psz_filter_chain );
 470         p_vout->p->b_title_show = false;
 471     }
 472
 473     /* Create the vout thread */
 474     char *psz_tmp = config_ChainCreate( &psz_name, &p_cfg, psz_parser );
 475     free( psz_parser );
 476     free( psz_tmp );
 477     p_vout->p_cfg = p_cfg;
 478
 479     /* Create a few object variables for interface interaction */
 480     var_Create( p_vout, "vout-filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
 481     text.psz_string = _("Filters");
 482     var_Change( p_vout, "vout-filter", VLC_VAR_SETTEXT, &text, NULL );
 483     var_AddCallback( p_vout, "vout-filter", FilterCallback, NULL );
 484
 485     /* */
 486     DeinterlaceEnable( p_vout );
 487
 488     if( p_vout->p->psz_filter_chain && *p_vout->p->psz_filter_chain )
 489     {
 490         char *psz_tmp;
 491         if( asprintf( &psz_tmp, "%s,none", psz_name ) < 0 )
 492             psz_tmp = strdup( "" );
 493         free( psz_name );
 494         psz_name = psz_tmp;
 495     }
 496     p_vout->p->psz_module_name = psz_name;
 497
 498     /* */
 499     vlc_object_set_destructor( p_vout, vout_Destructor );
 500
 501     /* */
 502     vlc_cond_init( &p_vout->p->change_wait );
 503     if( vlc_clone( &p_vout->p->thread, RunThread, p_vout,
 504                    VLC_THREAD_PRIORITY_OUTPUT ) )
 505     {
 506         spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), false );
 507         spu_Destroy( p_vout->p_spu );
 508         p_vout->p_spu = NULL;
 509         vlc_object_release( p_vout );
 510         return NULL;
 511     }
 512
 513     vlc_mutex_lock( &p_vout->change_lock );
 514     while( !p_vout->p->b_ready )
 515     {   /* We are (ab)using the same condition in opposite directions for
 516          * b_ready and b_done. This works because of the strict ordering. */
 517         assert( !p_vout->p->b_done );
 518         vlc_cond_wait( &p_vout->p->change_wait, &p_vout->change_lock );
 519     }
 520     vlc_mutex_unlock( &p_vout->change_lock );
 521
 522     if( p_vout->b_error )
 523     {
 524         msg_Err( p_vout, "video output creation failed" );
 525         vout_CloseAndRelease( p_vout );
 526         return NULL;
 527     }
 528
 529     return p_vout;
 530 }
 531
 532 /*****************************************************************************
 533  * vout_Close: Close a vout created by vout_Create.
 534  *****************************************************************************
 535  * You HAVE to call it on vout created by vout_Create before vlc_object_release.
 536  * You should NEVER call it on vout not obtained through vout_Create
 537  * (like with vout_Request or vlc_object_find.)
 538  * You can use vout_CloseAndRelease() as a convenience method.
 539  *****************************************************************************/
 540 void vout_Close( vout_thread_t *p_vout )
 541 {
 542     assert( p_vout );
 543
 544     vlc_mutex_lock( &p_vout->change_lock );
 545     p_vout->p->b_done = true;
 546     vlc_cond_signal( &p_vout->p->change_wait );
 547     vlc_mutex_unlock( &p_vout->change_lock );
 548
 549     vout_snapshot_End( &p_vout->p->snapshot );
 550
 551     vlc_join( p_vout->p->thread, NULL );
 552 }
 553
 554 /* */
 555 static void vout_Destructor( vlc_object_t * p_this )
 556 {
 557     vout_thread_t *p_vout = (vout_thread_t *)p_this;
 558
 559     /* Make sure the vout was stopped first */
 560     //assert( !p_vout->p_module );
 561
 562     free( p_vout->p->psz_module_name );
 563
 564     /* */
 565     if( p_vout->p_spu )
 566         spu_Destroy( p_vout->p_spu );
 567
 568     /* Destroy the locks */
 569     vlc_cond_destroy( &p_vout->p->change_wait );
 570     vlc_cond_destroy( &p_vout->p->picture_wait );
 571     vlc_mutex_destroy( &p_vout->picture_lock );
 572     vlc_mutex_destroy( &p_vout->change_lock );
 573     vlc_mutex_destroy( &p_vout->p->vfilter_lock );
 574
 575     /* */
 576     vout_statistic_Clean( &p_vout->p->statistic );
 577
 578     /* */
 579     vout_snapshot_Clean( &p_vout->p->snapshot );
 580
 581     /* */
 582     free( p_vout->p->psz_filter_chain );
 583     free( p_vout->p->psz_title );
 584
 585     config_ChainDestroy( p_vout->p_cfg );
 586
 587     free( p_vout->p );
 588
 589 }
 590
 591 /* */
 592 void vout_ChangePause( vout_thread_t *p_vout, bool b_paused, mtime_t i_date )
 593 {
 594     vlc_mutex_lock( &p_vout->change_lock );
 595
 596     assert( !p_vout->p->b_paused || !b_paused );
 597
 598     vlc_mutex_lock( &p_vout->picture_lock );
 599
 600     p_vout->p->i_picture_displayed_date = 0;
 601
 602     if( p_vout->p->b_paused )
 603     {
 604         const mtime_t i_duration = i_date - p_vout->p->i_pause_date;
 605
 606         for( int i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
 607         {
 608             picture_t *p_pic = PP_RENDERPICTURE[i_index];
 609
 610             if( p_pic->i_status == READY_PICTURE )
 611                 p_pic->date += i_duration;
 612         }
 613         vlc_cond_signal( &p_vout->p->picture_wait );
 614         vlc_mutex_unlock( &p_vout->picture_lock );
 615
 616         spu_OffsetSubtitleDate( p_vout->p_spu, i_duration );
 617     }
 618     else
 619     {
 620         vlc_mutex_unlock( &p_vout->picture_lock );
 621     }
 622     p_vout->p->b_paused = b_paused;
 623     p_vout->p->i_pause_date = i_date;
 624
 625     vlc_mutex_unlock( &p_vout->change_lock );
 626 }
 627
 628 void vout_GetResetStatistic( vout_thread_t *p_vout, int *pi_displayed, int *pi_lost )
 629 {
 630     vout_statistic_GetReset( &p_vout->p->statistic,
 631                              pi_displayed, pi_lost );
 632 }
 633
 634 void vout_Flush( vout_thread_t *p_vout, mtime_t i_date )
 635 {
 636     vlc_mutex_lock( &p_vout->picture_lock );
 637     p_vout->p->i_picture_displayed_date = 0;
 638     for( int i = 0; i < p_vout->render.i_pictures; i++ )
 639     {
 640         picture_t *p_pic = p_vout->render.pp_picture[i];
 641
 642         if( p_pic->i_status == READY_PICTURE ||
 643             p_pic->i_status == DISPLAYED_PICTURE )
 644         {
 645             /* We cannot change picture status if it is in READY_PICTURE state,
 646              * Just make sure they won't be displayed */
 647             if( p_pic->date > i_date )
 648                 p_pic->date = i_date;
 649         }
 650     }
 651     vlc_cond_signal( &p_vout->p->picture_wait );
 652     vlc_mutex_unlock( &p_vout->picture_lock );
 653 }
 654
 655 void vout_FixLeaks( vout_thread_t *p_vout, bool b_forced )
 656 {
 657     int i_pic, i_ready_pic;
 658
 659     vlc_mutex_lock( &p_vout->picture_lock );
 660
 661     for( i_pic = 0, i_ready_pic = 0; i_pic < p_vout->render.i_pictures && !b_forced; i_pic++ )
 662     {
 663         const picture_t *p_pic = p_vout->render.pp_picture[i_pic];
 664
 665         if( p_pic->i_status == READY_PICTURE )
 666         {
 667             i_ready_pic++;
 668             /* If we have at least 2 ready pictures, wait for the vout thread to
 669              * process one */
 670             if( i_ready_pic >= 2 )
 671                 break;
 672
 673             continue;
 674         }
 675
 676         if( p_pic->i_status == DISPLAYED_PICTURE )
 677         {
 678             /* If at least one displayed picture is not referenced
 679              * let vout free it */
 680             if( p_pic->i_refcount == 0 )
 681                 break;
 682         }
 683     }
 684     if( i_pic < p_vout->render.i_pictures && !b_forced )
 685     {
 686         vlc_mutex_unlock( &p_vout->picture_lock );
 687         return;
 688     }
 689
 690     /* Too many pictures are still referenced, there is probably a bug
 691      * with the decoder */
 692     if( !b_forced )
 693         msg_Err( p_vout, "pictures leaked, resetting the heap" );
 694
 695     /* Just free all the pictures */
 696     for( i_pic = 0; i_pic < p_vout->render.i_pictures; i_pic++ )
 697     {
 698         picture_t *p_pic = p_vout->render.pp_picture[i_pic];
 699
 700         msg_Dbg( p_vout, "[%d] %d %d", i_pic, p_pic->i_status, p_pic->i_refcount );
 701         p_pic->i_refcount = 0;
 702
 703         switch( p_pic->i_status )
 704         {
 705         case READY_PICTURE:
 706         case DISPLAYED_PICTURE:
 707         case RESERVED_PICTURE:
 708             if( p_pic != p_vout->p->p_picture_displayed )
 709                 vout_UsePictureLocked( p_vout, p_pic );
 710             break;
 711         }
 712     }
 713     vlc_cond_signal( &p_vout->p->picture_wait );
 714     vlc_mutex_unlock( &p_vout->picture_lock );
 715 }
 716 void vout_NextPicture( vout_thread_t *p_vout, mtime_t *pi_duration )
 717 {
 718     vlc_mutex_lock( &p_vout->picture_lock );
 719
 720     const mtime_t i_displayed_date = p_vout->p->i_picture_displayed_date;
 721
 722     p_vout->p->b_picture_displayed = false;
 723     p_vout->p->b_picture_empty = false;
 724     if( p_vout->p->p_picture_displayed )
 725     {
 726         p_vout->p->p_picture_displayed->date = 1;
 727         vlc_cond_signal( &p_vout->p->picture_wait );
 728     }
 729
 730     while( !p_vout->p->b_picture_displayed && !p_vout->p->b_picture_empty )
 731         vlc_cond_wait( &p_vout->p->picture_wait, &p_vout->picture_lock );
 732
 733     *pi_duration = __MAX( p_vout->p->i_picture_displayed_date - i_displayed_date, 0 );
 734
 735     /* TODO advance subpicture by the duration ... */
 736
 737     vlc_mutex_unlock( &p_vout->picture_lock );
 738 }
 739
 740 void vout_DisplayTitle( vout_thread_t *p_vout, const char *psz_title )
 741 {
 742     assert( psz_title );
 743
 744     if( !var_InheritBool( p_vout, "osd" ) )
 745         return;
 746
 747     vlc_mutex_lock( &p_vout->change_lock );
 748     free( p_vout->p->psz_title );
 749     p_vout->p->psz_title = strdup( psz_title );
 750     vlc_mutex_unlock( &p_vout->change_lock );
 751 }
 752
 753 spu_t *vout_GetSpu( vout_thread_t *p_vout )
 754 {
 755     return p_vout->p_spu;
 756 }
 757
 758 /*****************************************************************************
 759  * InitThread: initialize video output thread
 760  *****************************************************************************
 761  * This function is called from RunThread and performs the second step of the
 762  * initialization. It returns 0 on success. Note that the thread's flag are not
 763  * modified inside this function.
 764  * XXX You have to enter it with change_lock taken.
 765  *****************************************************************************/
 766 static int ChromaCreate( vout_thread_t *p_vout );
 767 static void ChromaDestroy( vout_thread_t *p_vout );
 768
 769 static int InitThread( vout_thread_t *p_vout )
 770 {
 771     int i;
 772
 773     /* Initialize output method, it allocates direct buffers for us */
 774     if( vout_InitWrapper( p_vout ) )
 775         return VLC_EGENERIC;
 776
 777     p_vout->p->p_picture_displayed = NULL;
 778
 779     if( !I_OUTPUTPICTURES )
 780     {
 781         msg_Err( p_vout, "plugin was unable to allocate at least "
 782                          "one direct buffer" );
 783         vout_EndWrapper( p_vout );
 784         return VLC_EGENERIC;
 785     }
 786
 787     if( I_OUTPUTPICTURES > VOUT_MAX_PICTURES )
 788     {
 789         msg_Err( p_vout, "plugin allocated too many direct buffers, "
 790                          "our internal buffers must have overflown." );
 791         vout_EndWrapper( p_vout );
 792         return VLC_EGENERIC;
 793     }
 794
 795     msg_Dbg( p_vout, "got %i direct buffer(s)", I_OUTPUTPICTURES );
 796
 797     if( !p_vout->fmt_out.i_width || !p_vout->fmt_out.i_height )
 798     {
 799         p_vout->fmt_out.i_width = p_vout->fmt_out.i_visible_width =
 800             p_vout->output.i_width;
 801         p_vout->fmt_out.i_height = p_vout->fmt_out.i_visible_height =
 802             p_vout->output.i_height;
 803         p_vout->fmt_out.i_x_offset =  p_vout->fmt_out.i_y_offset = 0;
 804
 805         p_vout->fmt_out.i_chroma = p_vout->output.i_chroma;
 806     }
 807     if( !p_vout->fmt_out.i_sar_num || !p_vout->fmt_out.i_sar_num )
 808     {
 809         p_vout->fmt_out.i_sar_num = p_vout->output.i_aspect *
 810             p_vout->fmt_out.i_height;
 811         p_vout->fmt_out.i_sar_den = VOUT_ASPECT_FACTOR *
 812             p_vout->fmt_out.i_width;
 813     }
 814
 815     vlc_ureduce( &p_vout->fmt_out.i_sar_num, &p_vout->fmt_out.i_sar_den,
 816                  p_vout->fmt_out.i_sar_num, p_vout->fmt_out.i_sar_den, 0 );
 817
 818     /* FIXME removed the need of both fmt_* and heap infos */
 819     /* Calculate shifts from system-updated masks */
 820     PictureHeapFixRgb( &p_vout->render );
 821     VideoFormatImportRgb( &p_vout->fmt_render, &p_vout->render );
 822
 823     PictureHeapFixRgb( &p_vout->output );
 824     VideoFormatImportRgb( &p_vout->fmt_out, &p_vout->output );
 825
 826     /* print some usefull debug info about different vout formats
 827      */
 828     msg_Dbg( p_vout, "pic render sz %ix%i, of (%i,%i), vsz %ix%i, 4cc %4.4s, sar %i:%i, msk r0x%x g0x%x b0x%x",
 829              p_vout->fmt_render.i_width, p_vout->fmt_render.i_height,
 830              p_vout->fmt_render.i_x_offset, p_vout->fmt_render.i_y_offset,
 831              p_vout->fmt_render.i_visible_width,
 832              p_vout->fmt_render.i_visible_height,
 833              (char*)&p_vout->fmt_render.i_chroma,
 834              p_vout->fmt_render.i_sar_num, p_vout->fmt_render.i_sar_den,
 835              p_vout->fmt_render.i_rmask, p_vout->fmt_render.i_gmask, p_vout->fmt_render.i_bmask );
 836
 837     msg_Dbg( p_vout, "pic in sz %ix%i, of (%i,%i), vsz %ix%i, 4cc %4.4s, sar %i:%i, msk r0x%x g0x%x b0x%x",
 838              p_vout->fmt_in.i_width, p_vout->fmt_in.i_height,
 839              p_vout->fmt_in.i_x_offset, p_vout->fmt_in.i_y_offset,
 840              p_vout->fmt_in.i_visible_width,
 841              p_vout->fmt_in.i_visible_height,
 842              (char*)&p_vout->fmt_in.i_chroma,
 843              p_vout->fmt_in.i_sar_num, p_vout->fmt_in.i_sar_den,
 844              p_vout->fmt_in.i_rmask, p_vout->fmt_in.i_gmask, p_vout->fmt_in.i_bmask );
 845
 846     msg_Dbg( p_vout, "pic out sz %ix%i, of (%i,%i), vsz %ix%i, 4cc %4.4s, sar %i:%i, msk r0x%x g0x%x b0x%x",
 847              p_vout->fmt_out.i_width, p_vout->fmt_out.i_height,
 848              p_vout->fmt_out.i_x_offset, p_vout->fmt_out.i_y_offset,
 849              p_vout->fmt_out.i_visible_width,
 850              p_vout->fmt_out.i_visible_height,
 851              (char*)&p_vout->fmt_out.i_chroma,
 852              p_vout->fmt_out.i_sar_num, p_vout->fmt_out.i_sar_den,
 853              p_vout->fmt_out.i_rmask, p_vout->fmt_out.i_gmask, p_vout->fmt_out.i_bmask );
 854
 855     assert( p_vout->output.i_width == p_vout->render.i_width &&
 856             p_vout->output.i_height == p_vout->render.i_height &&
 857             p_vout->output.i_chroma == p_vout->render.i_chroma );
 858     /* Check whether we managed to create direct buffers similar to
 859      * the render buffers, ie same size and chroma */
 860
 861     /* Cool ! We have direct buffers, we can ask the decoder to
 862      * directly decode into them ! Map the first render buffers to
 863      * the first direct buffers, but keep the first direct buffer
 864      * for memcpy operations */
 865     for( i = 1; i < VOUT_MAX_PICTURES; i++ )
 866     {
 867         if( p_vout->p_picture[ i ].i_type != DIRECT_PICTURE &&
 868             I_RENDERPICTURES >= VOUT_MIN_DIRECT_PICTURES - 1 &&
 869             p_vout->p_picture[ i - 1 ].i_type == DIRECT_PICTURE )
 870         {
 871             /* We have enough direct buffers so there's no need to
 872              * try to use system memory buffers. */
 873             break;
 874         }
 875         PP_RENDERPICTURE[ I_RENDERPICTURES ] = &p_vout->p_picture[ i ];
 876         I_RENDERPICTURES++;
 877     }
 878
 879     msg_Dbg( p_vout, "direct render, mapping "
 880              "render pictures 0-%i to system pictures 1-%i",
 881              VOUT_MAX_PICTURES - 2, VOUT_MAX_PICTURES - 1 );
 882
 883     return VLC_SUCCESS;
 884 }
 885
 886 /*****************************************************************************
 887  * RunThread: video output thread
 888  *****************************************************************************
 889  * Video output thread. This function does only returns when the thread is
 890  * terminated. It handles the pictures arriving in the video heap and the
 891  * display device events.
 892  *****************************************************************************/
 893 static void* RunThread( void *p_this )
 894 {
 895     vout_thread_t *p_vout = p_this;
 896     bool            b_has_wrapper;
 897     int             i_idle_loops = 0;  /* loops without displaying a picture */
 898     int             i_picture_qtype_last = QTYPE_NONE;
 899     bool            b_picture_interlaced_last = false;
 900     mtime_t         i_picture_interlaced_last_date;
 901
 902     /*
 903      * Initialize thread
 904      */
 905     b_has_wrapper = !vout_OpenWrapper( p_vout, p_vout->p->psz_module_name );
 906
 907     vlc_mutex_lock( &p_vout->change_lock );
 908
 909     if( b_has_wrapper )
 910         p_vout->b_error = InitThread( p_vout );
 911     else
 912         p_vout->b_error = true;
 913
 914     /* signal the creation of the vout */
 915     p_vout->p->b_ready = true;
 916     vlc_cond_signal( &p_vout->p->change_wait );
 917
 918     if( p_vout->b_error )
 919         goto exit_thread;
 920
 921     /* */
 922     const bool b_drop_late = var_CreateGetBool( p_vout, "drop-late-frames" );
 923     i_picture_interlaced_last_date = mdate();
 924
 925     /*
 926      * Main loop - it is not executed if an error occurred during
 927      * initialization
 928      */
 929     while( !p_vout->p->b_done && !p_vout->b_error )
 930     {
 931         /* Initialize loop variables */
 932         const mtime_t current_date = mdate();
 933         picture_t *p_picture;
 934         picture_t *p_filtered_picture;
 935         mtime_t display_date;
 936         picture_t *p_directbuffer;
 937         int i_index;
 938
 939         if( p_vout->p->b_title_show && p_vout->p->psz_title )
 940             DisplayTitleOnOSD( p_vout );
 941
 942         vlc_mutex_lock( &p_vout->picture_lock );
 943
 944         /* Look for the earliest picture but after the last displayed one */
 945         picture_t *p_last = p_vout->p->p_picture_displayed;;
 946
 947         p_picture = NULL;
 948         for( i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
 949         {
 950             picture_t *p_pic = PP_RENDERPICTURE[i_index];
 951
 952             if( p_pic->i_status != READY_PICTURE )
 953                 continue;
 954
 955             if( p_vout->p->b_paused && p_last && p_last->date > 1 )
 956                 continue;
 957
 958             if( p_last && p_pic != p_last && p_pic->date <= p_last->date )
 959             {
 960                 /* Drop old picture */
 961                 vout_UsePictureLocked( p_vout, p_pic );
 962             }
 963             else if( !p_vout->p->b_paused && !p_pic->b_force && p_pic != p_last &&
 964                      p_pic->date < current_date + p_vout->p->render_time &&
 965                      b_drop_late )
 966             {
 967                 /* Picture is late: it will be destroyed and the thread
 968                  * will directly choose the next picture */
 969                 vout_UsePictureLocked( p_vout, p_pic );
 970                 vout_statistic_Update( &p_vout->p->statistic, 0, 1 );
 971
 972                 msg_Warn( p_vout, "late picture skipped (%"PRId64" > %d)",
 973                                   current_date - p_pic->date, - p_vout->p->render_time );
 974             }
 975             else if( ( !p_last || p_last->date < p_pic->date ) &&
 976                      ( p_picture == NULL || p_pic->date < p_picture->date ) )
 977             {
 978                 p_picture = p_pic;
 979             }
 980         }
 981         if( !p_picture )
 982         {
 983             p_picture = p_last;
 984
 985             if( !p_vout->p->b_picture_empty )
 986             {
 987                 p_vout->p->b_picture_empty = true;
 988                 vlc_cond_signal( &p_vout->p->picture_wait );
 989             }
 990         }
 991
 992         display_date = 0;
 993         if( p_picture )
 994         {
 995             display_date = p_picture->date;
 996
 997             /* If we found better than the last picture, destroy it */
 998             if( p_last && p_picture != p_last )
 999             {
1000                 vout_UsePictureLocked( p_vout, p_last );
1001                 p_vout->p->p_picture_displayed = p_last = NULL;
1002             }
1003
1004             /* Compute FPS rate */
1005             p_vout->p->p_fps_sample[ p_vout->p->c_fps_samples++ % VOUT_FPS_SAMPLES ] = display_date;
1006
1007             if( !p_vout->p->b_paused && display_date > current_date + VOUT_DISPLAY_DELAY )
1008             {
1009                 /* A picture is ready to be rendered, but its rendering date
1010                  * is far from the current one so the thread will perform an
1011                  * empty loop as if no picture were found. The picture state
1012                  * is unchanged */
1013                 p_picture    = NULL;
1014                 display_date = 0;
1015             }
1016             else if( p_picture == p_last )
1017             {
1018                 /* We are asked to repeat the previous picture, but we first
1019                  * wait for a couple of idle loops */
1020                 if( i_idle_loops < 4 )
1021                 {
1022                     p_picture    = NULL;
1023                     display_date = 0;
1024                 }
1025                 else
1026                 {
1027                     /* We set the display date to something high, otherwise
1028                      * we'll have lots of problems with late pictures */
1029                     display_date = current_date + p_vout->p->render_time;
1030                 }
1031             }
1032             else if( p_vout->p->b_paused && display_date > current_date + VOUT_DISPLAY_DELAY )
1033             {
1034                 display_date = current_date + VOUT_DISPLAY_DELAY;
1035             }
1036
1037             if( p_picture )
1038             {
1039                 if( p_picture->date > 1 )
1040                 {
1041                     p_vout->p->i_picture_displayed_date = p_picture->date;
1042                     if( p_picture != p_last && !p_vout->p->b_picture_displayed )
1043                     {
1044                         p_vout->p->b_picture_displayed = true;
1045                         vlc_cond_signal( &p_vout->p->picture_wait );
1046                     }
1047                 }
1048                 p_vout->p->p_picture_displayed = p_picture;
1049             }
1050         }
1051
1052         /* */
1053         const int i_postproc_type = p_vout->p->i_picture_qtype;
1054         const int i_postproc_state = (p_vout->p->i_picture_qtype != QTYPE_NONE) - (i_picture_qtype_last != QTYPE_NONE);
1055
1056         const bool b_picture_interlaced = p_vout->p->b_picture_interlaced;
1057         const int  i_picture_interlaced_state = (!!p_vout->p->b_picture_interlaced) - (!!b_picture_interlaced_last);
1058
1059         vlc_mutex_unlock( &p_vout->picture_lock );
1060
1061         if( p_picture == NULL )
1062             i_idle_loops++;
1063
1064         p_filtered_picture = NULL;
1065         if( p_picture )
1066         {
1067             vlc_mutex_lock( &p_vout->p->vfilter_lock );
1068             p_filtered_picture = filter_chain_VideoFilter( p_vout->p->p_vf2_chain,
1069                                                            p_picture );
1070             vlc_mutex_unlock( &p_vout->p->vfilter_lock );
1071         }
1072
1073         const bool b_snapshot = vout_snapshot_IsRequested( &p_vout->p->snapshot );
1074
1075         /*
1076          * Check for subpictures to display
1077          */
1078         mtime_t spu_render_time;
1079         if( p_vout->p->b_paused )
1080             spu_render_time = p_vout->p->i_pause_date;
1081         else if( p_picture )
1082             spu_render_time = p_picture->date > 1 ? p_picture->date : mdate();
1083         else
1084             spu_render_time = 0;
1085
1086         subpicture_t *p_subpic = spu_SortSubpictures( p_vout->p_spu,
1087                                                       spu_render_time,
1088                                                       b_snapshot );
1089         /*
1090          * Perform rendering
1091          */
1092         vout_statistic_Update( &p_vout->p->statistic, 1, 0 );
1093         p_directbuffer = vout_RenderPicture( p_vout,
1094                                              p_filtered_picture, p_subpic,
1095                                              spu_render_time );
1096
1097         /*
1098          * Take a snapshot if requested
1099          */
1100         if( p_directbuffer && b_snapshot )
1101             vout_snapshot_Set( &p_vout->p->snapshot,
1102                                &p_vout->fmt_out, p_directbuffer );
1103
1104         /*
1105          * Call the plugin-specific rendering method if there is one
1106          */
1107         if( p_filtered_picture != NULL && p_directbuffer != NULL )
1108         {
1109             /* Render the direct buffer returned by vout_RenderPicture */
1110             vout_RenderWrapper( p_vout, p_directbuffer );
1111         }
1112
1113         /*
1114          * Sleep, wake up
1115          */
1116         if( display_date != 0 && p_directbuffer != NULL )
1117         {
1118             mtime_t current_render_time = mdate() - current_date;
1119             /* if render time is very large we don't include it in the mean */
1120             if( current_render_time < p_vout->p->render_time +
1121                 VOUT_DISPLAY_DELAY )
1122             {
1123                 /* Store render time using a sliding mean weighting to
1124                  * current value in a 3 to 1 ratio*/
1125                 p_vout->p->render_time *= 3;
1126                 p_vout->p->render_time += current_render_time;
1127                 p_vout->p->render_time >>= 2;
1128             }
1129             else
1130                 msg_Dbg( p_vout, "skipped big render time %d > %d", (int) current_render_time,
1131                  (int) (p_vout->p->render_time +VOUT_DISPLAY_DELAY ) ) ;
1132         }
1133
1134         /* Give back change lock */
1135         vlc_mutex_unlock( &p_vout->change_lock );
1136
1137         /* Sleep a while or until a given date */
1138         if( display_date != 0 )
1139         {
1140             /* If there are *vout* filters in the chain, better give them the picture
1141              * in advance */
1142             if( !p_vout->p->psz_filter_chain || !*p_vout->p->psz_filter_chain )
1143             {
1144                 mwait( display_date - VOUT_MWAIT_TOLERANCE );
1145             }
1146         }
1147         else
1148         {
1149             /* Wait until a frame is being sent or a spurious wakeup (not a problem here) */
1150             vlc_mutex_lock( &p_vout->picture_lock );
1151             vlc_cond_timedwait( &p_vout->p->picture_wait, &p_vout->picture_lock, current_date + VOUT_IDLE_SLEEP );
1152             vlc_mutex_unlock( &p_vout->picture_lock );
1153         }
1154
1155         /* On awakening, take back lock and send immediately picture
1156          * to display. */
1157         /* Note: p_vout->p->b_done could be true here and now */
1158         vlc_mutex_lock( &p_vout->change_lock );
1159
1160         /*
1161          * Display the previously rendered picture
1162          */
1163         if( p_filtered_picture != NULL && p_directbuffer != NULL )
1164         {
1165             /* Display the direct buffer returned by vout_RenderPicture */
1166             vout_DisplayWrapper( p_vout, p_directbuffer );
1167
1168             /* Tell the vout this was the last picture and that it does not
1169              * need to be forced anymore. */
1170             p_picture->b_force = false;
1171         }
1172
1173         /* Drop the filtered picture if created by video filters */
1174         if( p_filtered_picture != NULL && p_filtered_picture != p_picture )
1175         {
1176             vlc_mutex_lock( &p_vout->picture_lock );
1177             vout_UsePictureLocked( p_vout, p_filtered_picture );
1178             vlc_mutex_unlock( &p_vout->picture_lock );
1179         }
1180
1181         if( p_picture != NULL )
1182         {
1183             /* Reinitialize idle loop count */
1184             i_idle_loops = 0;
1185         }
1186
1187         /*
1188          * Check events and manage thread
1189          */
1190         if( vout_ManageWrapper( p_vout ) )
1191         {
1192             /* A fatal error occurred, and the thread must terminate
1193              * immediately, without displaying anything - setting b_error to 1
1194              * causes the immediate end of the main while() loop. */
1195             // FIXME pf_end
1196             p_vout->b_error = 1;
1197             break;
1198         }
1199
1200         if( p_vout->i_changes & VOUT_ON_TOP_CHANGE )
1201             p_vout->i_changes &= ~VOUT_ON_TOP_CHANGE;
1202
1203         if( p_vout->i_changes & VOUT_PICTURE_BUFFERS_CHANGE )
1204         {
1205             /* This happens when the picture buffers need to be recreated.
1206              * This is useful on multimonitor displays for instance.
1207              *
1208              * Warning: This only works when the vout creates only 1 picture
1209              * buffer!! */
1210             p_vout->i_changes &= ~VOUT_PICTURE_BUFFERS_CHANGE;
1211
1212             vlc_mutex_lock( &p_vout->picture_lock );
1213
1214             vout_EndWrapper( p_vout );
1215
1216             I_OUTPUTPICTURES = I_RENDERPICTURES = 0;
1217
1218             p_vout->b_error = InitThread( p_vout );
1219             if( p_vout->b_error )
1220                 msg_Err( p_vout, "InitThread after VOUT_PICTURE_BUFFERS_CHANGE failed" );
1221
1222             vlc_cond_signal( &p_vout->p->picture_wait );
1223             vlc_mutex_unlock( &p_vout->picture_lock );
1224
1225             if( p_vout->b_error )
1226                 break;
1227         }
1228
1229         /* Post processing */
1230         if( i_postproc_state == 1 )
1231             PostProcessEnable( p_vout );
1232         else if( i_postproc_state == -1 )
1233             PostProcessDisable( p_vout );
1234         if( i_postproc_state != 0 )
1235             i_picture_qtype_last = i_postproc_type;
1236
1237         /* Deinterlacing
1238          * Wait 30s before quiting interlacing mode */
1239         if( ( i_picture_interlaced_state == 1 ) ||
1240             ( i_picture_interlaced_state == -1 && i_picture_interlaced_last_date + 30000000 < current_date ) )
1241         {
1242             DeinterlaceNeeded( p_vout, b_picture_interlaced );
1243             b_picture_interlaced_last = b_picture_interlaced;
1244         }
1245         if( b_picture_interlaced )
1246             i_picture_interlaced_last_date = current_date;
1247
1248
1249         /* Check for "video filter2" changes */
1250         vlc_mutex_lock( &p_vout->p->vfilter_lock );
1251         if( p_vout->p->psz_vf2 )
1252         {
1253             es_format_t fmt;
1254
1255             es_format_Init( &fmt, VIDEO_ES, p_vout->fmt_render.i_chroma );
1256             fmt.video = p_vout->fmt_render;
1257             filter_chain_Reset( p_vout->p->p_vf2_chain, &fmt, &fmt );
1258
1259             if( filter_chain_AppendFromString( p_vout->p->p_vf2_chain,
1260                                                p_vout->p->psz_vf2 ) < 0 )
1261                 msg_Err( p_vout, "Video filter chain creation failed" );
1262
1263             free( p_vout->p->psz_vf2 );
1264             p_vout->p->psz_vf2 = NULL;
1265
1266             if( i_picture_qtype_last != QTYPE_NONE )
1267                 PostProcessSetFilterQuality( p_vout );
1268         }
1269         vlc_mutex_unlock( &p_vout->p->vfilter_lock );
1270     }
1271
1272     /*
1273      * Error loop - wait until the thread destruction is requested
1274      */
1275     if( p_vout->b_error )
1276         ErrorThread( p_vout );
1277
1278     /* Clean thread */
1279     CleanThread( p_vout );
1280
1281 exit_thread:
1282     /* End of thread */
1283     EndThread( p_vout );
1284     vlc_mutex_unlock( &p_vout->change_lock );
1285
1286     if( b_has_wrapper )
1287         vout_CloseWrapper( p_vout );
1288
1289     return NULL;
1290 }
1291
1292 /*****************************************************************************
1293  * ErrorThread: RunThread() error loop
1294  *****************************************************************************
1295  * This function is called when an error occurred during thread main's loop.
1296  * The thread can still receive feed, but must be ready to terminate as soon
1297  * as possible.
1298  *****************************************************************************/
1299 static void ErrorThread( vout_thread_t *p_vout )
1300 {
1301     /* Wait until a `close' order */
1302     while( !p_vout->p->b_done )
1303         vlc_cond_wait( &p_vout->p->change_wait, &p_vout->change_lock );
1304 }
1305
1306 /*****************************************************************************
1307  * CleanThread: clean up after InitThread
1308  *****************************************************************************
1309  * This function is called after a sucessful
1310  * initialization. It frees all resources allocated by InitThread.
1311  * XXX You have to enter it with change_lock taken.
1312  *****************************************************************************/
1313 static void CleanThread( vout_thread_t *p_vout )
1314 {
1315     int     i_index;                                        /* index in heap */
1316
1317     /* Destroy all remaining pictures */
1318     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++ )
1319     {
1320         if ( p_vout->p_picture[i_index].i_type == MEMORY_PICTURE )
1321         {
1322             free( p_vout->p_picture[i_index].p_data_orig );
1323         }
1324     }
1325
1326     /* Destroy translation tables */
1327     if( !p_vout->b_error )
1328         vout_EndWrapper( p_vout );
1329 }
1330
1331 /*****************************************************************************
1332  * EndThread: thread destruction
1333  *****************************************************************************
1334  * This function is called when the thread ends.
1335  * It frees all resources not allocated by InitThread.
1336  * XXX You have to enter it with change_lock taken.
1337  *****************************************************************************/
1338 static void EndThread( vout_thread_t *p_vout )
1339 {
1340     /* FIXME does that function *really* need to be called inside the thread ? */
1341
1342     /* Detach subpicture unit from both input and vout */
1343     spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), false );
1344     vlc_object_detach( p_vout->p_spu );
1345
1346     /* Destroy the video filters2 */
1347     filter_chain_Delete( p_vout->p->p_vf2_chain );
1348 }
1349
1350 /* following functions are local */
1351
1352 /**
1353  * This function copies all RGB informations from a picture_heap_t into
1354  * a video_format_t
1355  */
1356 static void VideoFormatImportRgb( video_format_t *p_fmt, const picture_heap_t *p_heap )
1357 {
1358     p_fmt->i_rmask = p_heap->i_rmask;
1359     p_fmt->i_gmask = p_heap->i_gmask;
1360     p_fmt->i_bmask = p_heap->i_bmask;
1361     p_fmt->i_rrshift = p_heap->i_rrshift;
1362     p_fmt->i_lrshift = p_heap->i_lrshift;
1363     p_fmt->i_rgshift = p_heap->i_rgshift;
1364     p_fmt->i_lgshift = p_heap->i_lgshift;
1365     p_fmt->i_rbshift = p_heap->i_rbshift;
1366     p_fmt->i_lbshift = p_heap->i_lbshift;
1367 }
1368
1369 /**
1370  * This funtion copes all RGB informations from a video_format_t into
1371  * a picture_heap_t
1372  */
1373 static void VideoFormatExportRgb( const video_format_t *p_fmt, picture_heap_t *p_heap )
1374 {
1375     p_heap->i_rmask = p_fmt->i_rmask;
1376     p_heap->i_gmask = p_fmt->i_gmask;
1377     p_heap->i_bmask = p_fmt->i_bmask;
1378     p_heap->i_rrshift = p_fmt->i_rrshift;
1379     p_heap->i_lrshift = p_fmt->i_lrshift;
1380     p_heap->i_rgshift = p_fmt->i_rgshift;
1381     p_heap->i_lgshift = p_fmt->i_lgshift;
1382     p_heap->i_rbshift = p_fmt->i_rbshift;
1383     p_heap->i_lbshift = p_fmt->i_lbshift;
1384 }
1385
1386 /**
1387  * This function computes rgb shifts from masks
1388  */
1389 static void PictureHeapFixRgb( picture_heap_t *p_heap )
1390 {
1391     video_format_t fmt;
1392
1393     /* */
1394     fmt.i_chroma = p_heap->i_chroma;
1395     VideoFormatImportRgb( &fmt, p_heap );
1396
1397     /* */
1398     video_format_FixRgb( &fmt );
1399
1400     VideoFormatExportRgb( &fmt, p_heap );
1401 }
1402
1403 /*****************************************************************************
1404  * object variables callbacks: a bunch of object variables are used by the
1405  * interfaces to interact with the vout.
1406  *****************************************************************************/
1407 static int FilterCallback( vlc_object_t *p_this, char const *psz_cmd,
1408                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1409 {
1410     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1411     input_thread_t *p_input;
1412     (void)psz_cmd; (void)oldval; (void)p_data;
1413
1414     p_input = (input_thread_t *)vlc_object_find( p_this, VLC_OBJECT_INPUT,
1415                                                  FIND_PARENT );
1416     if (!p_input)
1417     {
1418         msg_Err( p_vout, "Input not found" );
1419         return VLC_EGENERIC;
1420     }
1421
1422     var_SetBool( p_vout, "intf-change", true );
1423
1424     /* Modify input as well because the vout might have to be restarted */
1425     var_Create( p_input, "vout-filter", VLC_VAR_STRING );
1426     var_SetString( p_input, "vout-filter", newval.psz_string );
1427
1428     /* Now restart current video stream */
1429     input_Control( p_input, INPUT_RESTART_ES, -VIDEO_ES );
1430     vlc_object_release( p_input );
1431
1432     return VLC_SUCCESS;
1433 }
1434
1435 /*****************************************************************************
1436  * Video Filter2 stuff
1437  *****************************************************************************/
1438 static int VideoFilter2Callback( vlc_object_t *p_this, char const *psz_cmd,
1439                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1440 {
1441     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1442     (void)psz_cmd; (void)oldval; (void)p_data;
1443
1444     vlc_mutex_lock( &p_vout->p->vfilter_lock );
1445     p_vout->p->psz_vf2 = strdup( newval.psz_string );
1446     vlc_mutex_unlock( &p_vout->p->vfilter_lock );
1447
1448     return VLC_SUCCESS;
1449 }
1450
1451 /*****************************************************************************
1452  * Post-processing
1453  *****************************************************************************/
1454 static bool PostProcessIsPresent( const char *psz_filter )
1455 {
1456     const char  *psz_pp = "postproc";
1457     const size_t i_pp = strlen(psz_pp);
1458     return psz_filter &&
1459            !strncmp( psz_filter, psz_pp, strlen(psz_pp) ) &&
1460            ( psz_filter[i_pp] == '\0' || psz_filter[i_pp] == ':' );
1461 }
1462
1463 static int PostProcessCallback( vlc_object_t *p_this, char const *psz_cmd,
1464                                 vlc_value_t oldval, vlc_value_t newval, void *p_data )
1465 {
1466     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1467     VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data);
1468
1469     static const char *psz_pp = "postproc";
1470
1471     char *psz_vf2 = var_GetString( p_vout, "video-filter" );
1472
1473     if( newval.i_int <= 0 )
1474     {
1475         if( PostProcessIsPresent( psz_vf2 ) )
1476         {
1477             strcpy( psz_vf2, &psz_vf2[strlen(psz_pp)] );
1478             if( *psz_vf2 == ':' )
1479                 strcpy( psz_vf2, &psz_vf2[1] );
1480         }
1481     }
1482     else
1483     {
1484         if( !PostProcessIsPresent( psz_vf2 ) )
1485         {
1486             if( psz_vf2 )
1487             {
1488                 char *psz_tmp = psz_vf2;
1489                 if( asprintf( &psz_vf2, "%s:%s", psz_pp, psz_tmp ) < 0 )
1490                     psz_vf2 = psz_tmp;
1491                 else
1492                     free( psz_tmp );
1493             }
1494             else
1495             {
1496                 psz_vf2 = strdup( psz_pp );
1497             }
1498         }
1499     }
1500     if( psz_vf2 )
1501     {
1502         var_SetString( p_vout, "video-filter", psz_vf2 );
1503         free( psz_vf2 );
1504     }
1505
1506     return VLC_SUCCESS;
1507 }
1508 static void PostProcessEnable( vout_thread_t *p_vout )
1509 {
1510     vlc_value_t text;
1511     msg_Dbg( p_vout, "Post-processing available" );
1512     var_Create( p_vout, "postprocess", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE );
1513     text.psz_string = _("Post processing");
1514     var_Change( p_vout, "postprocess", VLC_VAR_SETTEXT, &text, NULL );
1515
1516     for( int i = 0; i <= 6; i++ )
1517     {
1518         vlc_value_t val;
1519         vlc_value_t text;
1520         char psz_text[1+1];
1521
1522         val.i_int = i;
1523         snprintf( psz_text, sizeof(psz_text), "%d", i );
1524         if( i == 0 )
1525             text.psz_string = _("Disable");
1526         else
1527             text.psz_string = psz_text;
1528         var_Change( p_vout, "postprocess", VLC_VAR_ADDCHOICE, &val, &text );
1529     }
1530     var_AddCallback( p_vout, "postprocess", PostProcessCallback, NULL );
1531
1532     /* */
1533     char *psz_filter = var_GetNonEmptyString( p_vout, "video-filter" );
1534     int i_postproc_q = 0;
1535     if( PostProcessIsPresent( psz_filter ) )
1536         i_postproc_q = var_CreateGetInteger( p_vout, "postproc-q" );
1537
1538     var_SetInteger( p_vout, "postprocess", i_postproc_q );
1539
1540     free( psz_filter );
1541 }
1542 static void PostProcessDisable( vout_thread_t *p_vout )
1543 {
1544     msg_Dbg( p_vout, "Post-processing no more available" );
1545     var_Destroy( p_vout, "postprocess" );
1546 }
1547 static void PostProcessSetFilterQuality( vout_thread_t *p_vout )
1548 {
1549     vlc_object_t *p_pp = vlc_object_find_name( p_vout, "postproc", FIND_CHILD );
1550     if( !p_pp )
1551         return;
1552
1553     var_SetInteger( p_pp, "postproc-q", var_GetInteger( p_vout, "postprocess" ) );
1554     vlc_object_release( p_pp );
1555 }
1556
1557
1558 static void DisplayTitleOnOSD( vout_thread_t *p_vout )
1559 {
1560     const mtime_t i_start = mdate();
1561     const mtime_t i_stop = i_start + INT64_C(1000) * p_vout->p->i_title_timeout;
1562
1563     if( i_stop <= i_start )
1564         return;
1565
1566     vlc_assert_locked( &p_vout->change_lock );
1567
1568     vout_ShowTextAbsolute( p_vout, DEFAULT_CHAN,
1569                            p_vout->p->psz_title, NULL,
1570                            p_vout->p->i_title_position,
1571                            30 + p_vout->fmt_in.i_width
1572                               - p_vout->fmt_in.i_visible_width
1573                               - p_vout->fmt_in.i_x_offset,
1574                            20 + p_vout->fmt_in.i_y_offset,
1575                            i_start, i_stop );
1576
1577     free( p_vout->p->psz_title );
1578
1579     p_vout->p->psz_title = NULL;
1580 }
1581
1582 /*****************************************************************************
1583  * Deinterlacing
1584  *****************************************************************************/
1585 typedef struct
1586 {
1587     const char *psz_mode;
1588     bool       b_vout_filter;
1589 } deinterlace_mode_t;
1590
1591 /* XXX
1592  * You can use the non vout filter if and only if the video properties stay the
1593  * same (width/height/chroma/fps), at least for now.
1594  */
1595 static const deinterlace_mode_t p_deinterlace_mode[] = {
1596     { "",        false },
1597     //{ "discard", true },
1598     { "blend",   false },
1599     //{ "mean",    true  },
1600     //{ "bob",     true },
1601     //{ "linear",  true },
1602     { "x",       false },
1603     //{ "yadif",   true },
1604     //{ "yadif2x", true },
1605     { NULL,      false }
1606 };
1607 static const deinterlace_mode_t *DeinterlaceGetMode( const char *psz_mode )
1608 {
1609     for( const deinterlace_mode_t *p_mode = &p_deinterlace_mode[0]; p_mode->psz_mode; p_mode++ )
1610     {
1611         if( !strcmp( p_mode->psz_mode, psz_mode ) )
1612             return p_mode;
1613     }
1614     return NULL;
1615 }
1616
1617 static char *FilterFind( char *psz_filter_base, const char *psz_module )
1618 {
1619     const size_t i_module = strlen( psz_module );
1620     const char *psz_filter = psz_filter_base;
1621
1622     if( !psz_filter || i_module <= 0 )
1623         return NULL;
1624
1625     for( ;; )
1626     {
1627         char *psz_find = strstr( psz_filter, psz_module );
1628         if( !psz_find )
1629             return NULL;
1630         if( psz_find[i_module] == '\0' || psz_find[i_module] == ':' )
1631             return psz_find;
1632         psz_filter = &psz_find[i_module];
1633     }
1634 }
1635
1636 static bool DeinterlaceIsPresent( vout_thread_t *p_vout, bool b_vout_filter )
1637 {
1638     char *psz_filter = var_GetNonEmptyString( p_vout, b_vout_filter ? "vout-filter" : "video-filter" );
1639
1640     bool b_found = FilterFind( psz_filter, "deinterlace" ) != NULL;
1641
1642     free( psz_filter );
1643
1644     return b_found;
1645 }
1646
1647 static void DeinterlaceRemove( vout_thread_t *p_vout, bool b_vout_filter )
1648 {
1649     const char *psz_variable = b_vout_filter ? "vout-filter" : "video-filter";
1650     char *psz_filter = var_GetNonEmptyString( p_vout, psz_variable );
1651
1652     char *psz = FilterFind( psz_filter, "deinterlace" );
1653     if( !psz )
1654     {
1655         free( psz_filter );
1656         return;
1657     }
1658
1659     /* */
1660     strcpy( &psz[0], &psz[strlen("deinterlace")] );
1661     if( *psz == ':' )
1662         strcpy( &psz[0], &psz[1] );
1663
1664     var_SetString( p_vout, psz_variable, psz_filter );
1665     free( psz_filter );
1666 }
1667 static void DeinterlaceAdd( vout_thread_t *p_vout, bool b_vout_filter )
1668 {
1669     const char *psz_variable = b_vout_filter ? "vout-filter" : "video-filter";
1670
1671     char *psz_filter = var_GetNonEmptyString( p_vout, psz_variable );
1672
1673     if( FilterFind( psz_filter, "deinterlace" ) )
1674     {
1675         free( psz_filter );
1676         return;
1677     }
1678
1679     /* */
1680     if( psz_filter )
1681     {
1682         char *psz_tmp = psz_filter;
1683         if( asprintf( &psz_filter, "%s:%s", psz_tmp, "deinterlace" ) < 0 )
1684             psz_filter = psz_tmp;
1685         else
1686             free( psz_tmp );
1687     }
1688     else
1689     {
1690         psz_filter = strdup( "deinterlace" );
1691     }
1692
1693     if( psz_filter )
1694     {
1695         var_SetString( p_vout, psz_variable, psz_filter );
1696         free( psz_filter );
1697     }
1698 }
1699
1700 static void DeinterlaceSave( vout_thread_t *p_vout, int i_deinterlace, const char *psz_mode, bool is_needed )
1701 {
1702     /* We have to set input variable to ensure restart support
1703      * XXX it is only needed because of vout-filter but must be done
1704      * for non video filter anyway */
1705     vlc_object_t *p_input = vlc_object_find( p_vout, VLC_OBJECT_INPUT, FIND_PARENT );
1706     if( !p_input )
1707         return;
1708
1709     /* Another hack for "vout filter" mode */
1710     if( i_deinterlace < 0 )
1711         i_deinterlace = is_needed ? -2 : -3;
1712
1713     var_Create( p_input, "deinterlace", VLC_VAR_INTEGER );
1714     var_SetInteger( p_input, "deinterlace", i_deinterlace );
1715
1716     static const char * const ppsz_variable[] = {
1717         "deinterlace-mode",
1718         "filter-deinterlace-mode",
1719         "sout-deinterlace-mode",
1720         NULL
1721     };
1722     for( int i = 0; ppsz_variable[i]; i++ )
1723     {
1724         var_Create( p_input, ppsz_variable[i], VLC_VAR_STRING );
1725         var_SetString( p_input, ppsz_variable[i], psz_mode );
1726     }
1727
1728     vlc_object_release( p_input );
1729 }
1730 static int DeinterlaceCallback( vlc_object_t *p_this, char const *psz_cmd,
1731                                 vlc_value_t oldval, vlc_value_t newval, void *p_data )
1732 {
1733     VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(newval); VLC_UNUSED(p_data);
1734     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1735
1736     /* */
1737     const int  i_deinterlace = var_GetInteger( p_this, "deinterlace" );
1738     char       *psz_mode     = var_GetString( p_this, "deinterlace-mode" );
1739     const bool is_needed     = var_GetBool( p_this, "deinterlace-needed" );
1740     if( !psz_mode )
1741         return VLC_EGENERIC;
1742
1743     DeinterlaceSave( p_vout, i_deinterlace, psz_mode, is_needed );
1744
1745     /* */
1746     bool b_vout_filter = false;
1747     const deinterlace_mode_t *p_mode = DeinterlaceGetMode( psz_mode );
1748     if( p_mode )
1749         b_vout_filter = p_mode->b_vout_filter;
1750
1751     /* */
1752     char *psz_old;
1753     if( b_vout_filter )
1754     {
1755         psz_old = var_CreateGetString( p_vout, "filter-deinterlace-mode" );
1756     }
1757     else
1758     {
1759         psz_old = var_CreateGetString( p_vout, "sout-deinterlace-mode" );
1760         var_SetString( p_vout, "sout-deinterlace-mode", psz_mode );
1761     }
1762
1763     msg_Dbg( p_vout, "deinterlace %d, mode %s, is_needed %d", i_deinterlace, psz_mode, is_needed );
1764     if( i_deinterlace == 0 || ( i_deinterlace == -1 && !is_needed ) )
1765     {
1766         DeinterlaceRemove( p_vout, false );
1767         DeinterlaceRemove( p_vout, true );
1768     }
1769     else
1770     {
1771         if( !DeinterlaceIsPresent( p_vout, b_vout_filter ) )
1772         {
1773             DeinterlaceRemove( p_vout, !b_vout_filter );
1774             DeinterlaceAdd( p_vout, b_vout_filter );
1775         }
1776         else
1777         {
1778             /* The deinterlace filter was already inserted but we have changed the mode */
1779             DeinterlaceRemove( p_vout, !b_vout_filter );
1780             if( psz_old && strcmp( psz_old, psz_mode ) )
1781                 var_TriggerCallback( p_vout, b_vout_filter ? "vout-filter" : "video-filter" );
1782         }
1783     }
1784
1785     /* */
1786     free( psz_old );
1787     free( psz_mode );
1788     return VLC_SUCCESS;
1789 }
1790
1791 static void DeinterlaceEnable( vout_thread_t *p_vout )
1792 {
1793     vlc_value_t val, text;
1794
1795     if( !p_vout->p->b_first_vout )
1796         return;
1797
1798     msg_Dbg( p_vout, "Deinterlacing available" );
1799
1800     /* Create the configuration variables */
1801     /* */
1802     var_Create( p_vout, "deinterlace", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT | VLC_VAR_HASCHOICE );
1803     int i_deinterlace = var_GetInteger( p_vout, "deinterlace" );
1804
1805     text.psz_string = _("Deinterlace");
1806     var_Change( p_vout, "deinterlace", VLC_VAR_SETTEXT, &text, NULL );
1807
1808     const module_config_t *p_optd = config_FindConfig( VLC_OBJECT(p_vout), "deinterlace" );
1809     var_Change( p_vout, "deinterlace", VLC_VAR_CLEARCHOICES, NULL, NULL );
1810     for( int i = 0; p_optd && i < p_optd->i_list; i++ )
1811     {
1812         val.i_int  = p_optd->pi_list[i];
1813         text.psz_string = (char*)vlc_gettext(p_optd->ppsz_list_text[i]);
1814         var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
1815     }
1816     var_AddCallback( p_vout, "deinterlace", DeinterlaceCallback, NULL );
1817     /* */
1818     var_Create( p_vout, "deinterlace-mode", VLC_VAR_STRING | VLC_VAR_DOINHERIT | VLC_VAR_HASCHOICE );
1819     char *psz_deinterlace = var_GetNonEmptyString( p_vout, "deinterlace-mode" );
1820
1821     text.psz_string = _("Deinterlace mode");
1822     var_Change( p_vout, "deinterlace-mode", VLC_VAR_SETTEXT, &text, NULL );
1823
1824     const module_config_t *p_optm = config_FindConfig( VLC_OBJECT(p_vout), "deinterlace-mode" );
1825     var_Change( p_vout, "deinterlace-mode", VLC_VAR_CLEARCHOICES, NULL, NULL );
1826     for( int i = 0; p_optm && i < p_optm->i_list; i++ )
1827     {
1828         if( !DeinterlaceGetMode( p_optm->ppsz_list[i] ) )
1829             continue;
1830
1831         val.psz_string  = p_optm->ppsz_list[i];
1832         text.psz_string = (char*)vlc_gettext(p_optm->ppsz_list_text[i]);
1833         var_Change( p_vout, "deinterlace-mode", VLC_VAR_ADDCHOICE, &val, &text );
1834     }
1835     var_AddCallback( p_vout, "deinterlace-mode", DeinterlaceCallback, NULL );
1836     /* */
1837     var_Create( p_vout, "deinterlace-needed", VLC_VAR_BOOL );
1838     var_AddCallback( p_vout, "deinterlace-needed", DeinterlaceCallback, NULL );
1839
1840     /* Override the initial value from filters if present */
1841     char *psz_filter_mode = NULL;
1842     if( DeinterlaceIsPresent( p_vout, true ) )
1843         psz_filter_mode = var_CreateGetNonEmptyString( p_vout, "filter-deinterlace-mode" );
1844     else if( DeinterlaceIsPresent( p_vout, false ) )
1845         psz_filter_mode = var_CreateGetNonEmptyString( p_vout, "sout-deinterlace-mode" );
1846     if( psz_filter_mode )
1847     {
1848         free( psz_deinterlace );
1849         if( i_deinterlace >= -1 )
1850             i_deinterlace = 1;
1851         psz_deinterlace = psz_filter_mode;
1852     }
1853
1854     /* */
1855     if( i_deinterlace == -2 )
1856         p_vout->p->b_picture_interlaced = true;
1857     else if( i_deinterlace == -3 )
1858         p_vout->p->b_picture_interlaced = false;
1859     if( i_deinterlace < 0 )
1860         i_deinterlace = -1;
1861
1862     /* */
1863     val.psz_string = psz_deinterlace ? psz_deinterlace : p_optm->orig.psz;
1864     var_Change( p_vout, "deinterlace-mode", VLC_VAR_SETVALUE, &val, NULL );
1865     val.b_bool = p_vout->p->b_picture_interlaced;
1866     var_Change( p_vout, "deinterlace-needed", VLC_VAR_SETVALUE, &val, NULL );
1867
1868     var_SetInteger( p_vout, "deinterlace", i_deinterlace );
1869     free( psz_deinterlace );
1870 }
1871
1872 static void DeinterlaceNeeded( vout_thread_t *p_vout, bool is_interlaced )
1873 {
1874     msg_Dbg( p_vout, "Detected %s video",
1875              is_interlaced ? "interlaced" : "progressive" );
1876     var_SetBool( p_vout, "deinterlace-needed", is_interlaced );
1877 }
1878