git.sesse.net Git - vlc/blob - src/video_output/video_output.c

   1 /*****************************************************************************
   2  * video_output.c : video output thread
   3  *
   4  * This module describes the programming interface for video output threads.
   5  * It includes functions allowing to open a new thread, send pictures to a
   6  * thread, and destroy a previously oppened video output thread.
   7  *****************************************************************************
   8  * Copyright (C) 2000-2007 the VideoLAN team
   9  * $Id$
  10  *
  11  * Authors: Vincent Seguin <seguin@via.ecp.fr>
  12  *          Gildas Bazin <gbazin@videolan.org>
  13  *
  14  * This program is free software; you can redistribute it and/or modify
  15  * it under the terms of the GNU General Public License as published by
  16  * the Free Software Foundation; either version 2 of the License, or
  17  * (at your option) any later version.
  18  *
  19  * This program is distributed in the hope that it will be useful,
  20  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  21  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  22  * GNU General Public License for more details.
  23  *
  24  * You should have received a copy of the GNU General Public License
  25  * along with this program; if not, write to the Free Software
  26  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  27  *****************************************************************************/
  28
  29 /*****************************************************************************
  30  * Preamble
  31  *****************************************************************************/
  32 #ifdef HAVE_CONFIG_H
  33 # include "config.h"
  34 #endif
  35
  36 #include <vlc_common.h>
  37
  38 #include <stdlib.h>                                                /* free() */
  39 #include <string.h>
  40
  41 #include <vlc_vout.h>
  42
  43 #include <vlc_filter.h>
  44 #include <vlc_osd.h>
  45 #include <assert.h>
  46
  47 #if defined( __APPLE__ )
  48 /* Include darwin_specific.h here if needed */
  49 #endif
  50
  51 /** FIXME This is quite ugly but needed while we don't have counters
  52  * helpers */
  53 //#include "input/input_internal.h"
  54
  55 #include <libvlc.h>
  56 #include <vlc_input.h>
  57 #include "vout_pictures.h"
  58 #include "vout_internal.h"
  59
  60 /*****************************************************************************
  61  * Local prototypes
  62  *****************************************************************************/
  63 static int      InitThread        ( vout_thread_t * );
  64 static void*    RunThread         ( void *  );
  65 static void     ErrorThread       ( vout_thread_t * );
  66 static void     CleanThread       ( vout_thread_t * );
  67 static void     EndThread         ( vout_thread_t * );
  68
  69 static void VideoFormatImportRgb( video_format_t *, const picture_heap_t * );
  70 static void PictureHeapFixRgb( picture_heap_t * );
  71
  72 static void     vout_Destructor   ( vlc_object_t * p_this );
  73
  74 /* Object variables callbacks */
  75 static int FilterCallback( vlc_object_t *, char const *,
  76                            vlc_value_t, vlc_value_t, void * );
  77 static int VideoFilter2Callback( vlc_object_t *, char const *,
  78                                  vlc_value_t, vlc_value_t, void * );
  79
  80 /* */
  81 static void PostProcessEnable( vout_thread_t * );
  82 static void PostProcessDisable( vout_thread_t * );
  83 static void PostProcessSetFilterQuality( vout_thread_t *p_vout );
  84 static int  PostProcessCallback( vlc_object_t *, char const *,
  85                                  vlc_value_t, vlc_value_t, void * );
  86 /* */
  87 static void DeinterlaceEnable( vout_thread_t * );
  88 static void DeinterlaceNeeded( vout_thread_t *, bool );
  89
  90 /* From vout_intf.c */
  91 int vout_Snapshot( vout_thread_t *, picture_t * );
  92
  93 /* Display media title in OSD */
  94 static void DisplayTitleOnOSD( vout_thread_t *p_vout );
  95
  96 /* Time during which the thread will sleep if it has nothing to
  97  * display (in micro-seconds) */
  98 #define VOUT_IDLE_SLEEP                 ((int)(0.020*CLOCK_FREQ))
  99
 100 /* Maximum lap of time allowed between the beginning of rendering and
 101  * display. If, compared to the current date, the next image is too
 102  * late, the thread will perform an idle loop. This time should be
 103  * at least VOUT_IDLE_SLEEP plus the time required to render a few
 104  * images, to avoid trashing of decoded images */
 105 #define VOUT_DISPLAY_DELAY              ((int)(0.200*CLOCK_FREQ))
 106
 107 /* Better be in advance when awakening than late... */
 108 #define VOUT_MWAIT_TOLERANCE            ((mtime_t)(0.020*CLOCK_FREQ))
 109
 110 /* Minimum number of direct pictures the video output will accept without
 111  * creating additional pictures in system memory */
 112 #ifdef OPTIMIZE_MEMORY
 113 #   define VOUT_MIN_DIRECT_PICTURES        (VOUT_MAX_PICTURES/2)
 114 #else
 115 #   define VOUT_MIN_DIRECT_PICTURES        (3*VOUT_MAX_PICTURES/4)
 116 #endif
 117
 118 /*****************************************************************************
 119  * Video Filter2 functions
 120  *****************************************************************************/
 121 static picture_t *video_new_buffer_filter( filter_t *p_filter )
 122 {
 123     vout_thread_t *p_vout = (vout_thread_t*)p_filter->p_owner;
 124     picture_t *p_picture = vout_CreatePicture( p_vout, 0, 0, 0 );
 125
 126     p_picture->i_status = READY_PICTURE;
 127
 128     return p_picture;
 129 }
 130
 131 static void video_del_buffer_filter( filter_t *p_filter, picture_t *p_pic )
 132 {
 133     vout_thread_t *p_vout = (vout_thread_t*)p_filter->p_owner;
 134
 135     vlc_mutex_lock( &p_vout->picture_lock );
 136     vout_UsePictureLocked( p_vout, p_pic );
 137     vlc_mutex_unlock( &p_vout->picture_lock );
 138 }
 139
 140 static int video_filter_buffer_allocation_init( filter_t *p_filter, void *p_data )
 141 {
 142     p_filter->pf_video_buffer_new = video_new_buffer_filter;
 143     p_filter->pf_video_buffer_del = video_del_buffer_filter;
 144     p_filter->p_owner = p_data; /* p_vout */
 145     return VLC_SUCCESS;
 146 }
 147
 148 #undef vout_Request
 149 /*****************************************************************************
 150  * vout_Request: find a video output thread, create one, or destroy one.
 151  *****************************************************************************
 152  * This function looks for a video output thread matching the current
 153  * properties. If not found, it spawns a new one.
 154  *****************************************************************************/
 155 vout_thread_t *vout_Request( vlc_object_t *p_this, vout_thread_t *p_vout,
 156                              video_format_t *p_fmt )
 157 {
 158     if( !p_fmt )
 159     {
 160         /* Video output is no longer used.
 161          * TODO: support for reusing video outputs with proper _thread-safe_
 162          * reference handling. */
 163         if( p_vout )
 164             vout_CloseAndRelease( p_vout );
 165         return NULL;
 166     }
 167
 168     /* If a video output was provided, lock it, otherwise look for one. */
 169     if( p_vout )
 170     {
 171         vlc_object_hold( p_vout );
 172     }
 173
 174     /* TODO: find a suitable unused video output */
 175
 176     /* If we now have a video output, check it has the right properties */
 177     if( p_vout )
 178     {
 179         vlc_mutex_lock( &p_vout->change_lock );
 180
 181         /* We don't directly check for the "vout-filter" variable for obvious
 182          * performance reasons. */
 183         if( p_vout->p->b_filter_change )
 184         {
 185             char *psz_filter_chain = var_GetString( p_vout, "vout-filter" );
 186
 187             if( psz_filter_chain && !*psz_filter_chain )
 188             {
 189                 free( psz_filter_chain );
 190                 psz_filter_chain = NULL;
 191             }
 192             if( p_vout->p->psz_filter_chain && !*p_vout->p->psz_filter_chain )
 193             {
 194                 free( p_vout->p->psz_filter_chain );
 195                 p_vout->p->psz_filter_chain = NULL;
 196             }
 197
 198             if( !psz_filter_chain && !p_vout->p->psz_filter_chain )
 199             {
 200                 p_vout->p->b_filter_change = false;
 201             }
 202
 203             free( psz_filter_chain );
 204         }
 205
 206         if( p_vout->fmt_render.i_chroma != vlc_fourcc_GetCodec( VIDEO_ES, p_fmt->i_chroma ) ||
 207             p_vout->fmt_render.i_width != p_fmt->i_width ||
 208             p_vout->fmt_render.i_height != p_fmt->i_height ||
 209             p_vout->p->b_filter_change )
 210         {
 211             vlc_mutex_unlock( &p_vout->change_lock );
 212
 213             /* We are not interested in this format, close this vout */
 214             vout_CloseAndRelease( p_vout );
 215             vlc_object_release( p_vout );
 216             p_vout = NULL;
 217         }
 218         else
 219         {
 220             /* This video output is cool! Hijack it. */
 221             /* Correct aspect ratio on change
 222              * FIXME factorize this code with other aspect ration related code */
 223             unsigned int i_sar_num;
 224             unsigned int i_sar_den;
 225             vlc_ureduce( &i_sar_num, &i_sar_den,
 226                          p_fmt->i_sar_num, p_fmt->i_sar_den, 50000 );
 227 #if 0
 228             /* What's that, it does not seems to be used correcly everywhere */
 229             if( p_vout->i_par_num > 0 && p_vout->i_par_den > 0 )
 230             {
 231                 i_sar_num *= p_vout->i_par_den;
 232                 i_sar_den *= p_vout->i_par_num;
 233             }
 234 #endif
 235
 236             if( i_sar_num > 0 && i_sar_den > 0 &&
 237                 ( i_sar_num != p_vout->fmt_render.i_sar_num ||
 238                   i_sar_den != p_vout->fmt_render.i_sar_den ) )
 239             {
 240                 p_vout->fmt_in.i_sar_num = i_sar_num;
 241                 p_vout->fmt_in.i_sar_den = i_sar_den;
 242
 243                 p_vout->fmt_render.i_sar_num = i_sar_num;
 244                 p_vout->fmt_render.i_sar_den = i_sar_den;
 245
 246                 p_vout->render.i_aspect = (int64_t)i_sar_num *
 247                                                    p_vout->fmt_render.i_width *
 248                                                    VOUT_ASPECT_FACTOR /
 249                                                    i_sar_den /
 250                                                    p_vout->fmt_render.i_height;
 251                 p_vout->i_changes |= VOUT_ASPECT_CHANGE;
 252             }
 253             vlc_mutex_unlock( &p_vout->change_lock );
 254
 255             vlc_object_release( p_vout );
 256         }
 257
 258         if( p_vout )
 259         {
 260             msg_Dbg( p_this, "reusing provided vout" );
 261
 262             spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), false );
 263             vlc_object_detach( p_vout );
 264
 265             vlc_object_attach( p_vout, p_this );
 266             spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), true );
 267         }
 268     }
 269
 270     if( !p_vout )
 271     {
 272         msg_Dbg( p_this, "no usable vout present, spawning one" );
 273
 274         p_vout = vout_Create( p_this, p_fmt );
 275     }
 276
 277     return p_vout;
 278 }
 279
 280 #undef vout_Create
 281 /*****************************************************************************
 282  * vout_Create: creates a new video output thread
 283  *****************************************************************************
 284  * This function creates a new video output thread, and returns a pointer
 285  * to its description. On error, it returns NULL.
 286  *****************************************************************************/
 287 vout_thread_t * vout_Create( vlc_object_t *p_parent, video_format_t *p_fmt )
 288 {
 289     vout_thread_t  * p_vout;                            /* thread descriptor */
 290     int              i_index;                               /* loop variable */
 291     vlc_value_t      text;
 292
 293     unsigned int i_width = p_fmt->i_width;
 294     unsigned int i_height = p_fmt->i_height;
 295     vlc_fourcc_t i_chroma = vlc_fourcc_GetCodec( VIDEO_ES, p_fmt->i_chroma );
 296
 297     config_chain_t *p_cfg;
 298     char *psz_parser;
 299     char *psz_name;
 300
 301     if( i_width <= 0 || i_height <= 0 )
 302         return NULL;
 303
 304     vlc_ureduce( &p_fmt->i_sar_num, &p_fmt->i_sar_den,
 305                  p_fmt->i_sar_num, p_fmt->i_sar_den, 50000 );
 306     if( p_fmt->i_sar_num <= 0 || p_fmt->i_sar_den <= 0 )
 307         return NULL;
 308     unsigned int i_aspect = (int64_t)p_fmt->i_sar_num *
 309                                      i_width *
 310                                      VOUT_ASPECT_FACTOR /
 311                                      p_fmt->i_sar_den /
 312                                      i_height;
 313
 314     /* Allocate descriptor */
 315     static const char typename[] = "video output";
 316     p_vout = vlc_custom_create( p_parent, sizeof( *p_vout ), VLC_OBJECT_VOUT,
 317                                 typename );
 318     if( p_vout == NULL )
 319         return NULL;
 320
 321     /* */
 322     p_vout->p = calloc( 1, sizeof(*p_vout->p) );
 323     if( !p_vout->p )
 324     {
 325         vlc_object_release( p_vout );
 326         return NULL;
 327     }
 328
 329     /* Initialize pictures - translation tables and functions
 330      * will be initialized later in InitThread */
 331     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++)
 332     {
 333         p_vout->p_picture[i_index].i_status = FREE_PICTURE;
 334         p_vout->p_picture[i_index].i_type   = EMPTY_PICTURE;
 335         p_vout->p_picture[i_index].b_slow   = 0;
 336     }
 337
 338     /* No images in the heap */
 339     p_vout->i_heap_size = 0;
 340
 341     /* Initialize the rendering heap */
 342     I_RENDERPICTURES = 0;
 343
 344     p_vout->fmt_render        = *p_fmt;   /* FIXME palette */
 345     p_vout->fmt_in            = *p_fmt;   /* FIXME palette */
 346
 347     p_vout->render.i_width    = i_width;
 348     p_vout->render.i_height   = i_height;
 349     p_vout->render.i_chroma   = i_chroma;
 350     p_vout->render.i_aspect   = i_aspect;
 351
 352     p_vout->render.i_rmask    = p_fmt->i_rmask;
 353     p_vout->render.i_gmask    = p_fmt->i_gmask;
 354     p_vout->render.i_bmask    = p_fmt->i_bmask;
 355
 356     p_vout->render.i_last_used_pic = -1;
 357     p_vout->render.b_allow_modify_pics = 1;
 358
 359     /* Zero the output heap */
 360     I_OUTPUTPICTURES = 0;
 361     p_vout->output.i_width    = 0;
 362     p_vout->output.i_height   = 0;
 363     p_vout->output.i_chroma   = 0;
 364     p_vout->output.i_aspect   = 0;
 365
 366     p_vout->output.i_rmask    = 0;
 367     p_vout->output.i_gmask    = 0;
 368     p_vout->output.i_bmask    = 0;
 369
 370     /* Initialize misc stuff */
 371     p_vout->i_changes    = 0;
 372     p_vout->b_autoscale  = 1;
 373     p_vout->i_zoom      = ZOOM_FP_FACTOR;
 374     p_vout->b_fullscreen = 0;
 375     p_vout->i_alignment  = 0;
 376     p_vout->p->render_time  = 10;
 377     p_vout->p->c_fps_samples = 0;
 378     vout_statistic_Init( &p_vout->p->statistic );
 379     p_vout->p->b_filter_change = 0;
 380     p_vout->p->b_paused = false;
 381     p_vout->p->i_pause_date = 0;
 382     p_vout->p->i_par_num =
 383     p_vout->p->i_par_den = 1;
 384     p_vout->p->p_picture_displayed = NULL;
 385     p_vout->p->i_picture_displayed_date = 0;
 386     p_vout->p->b_picture_displayed = false;
 387     p_vout->p->b_picture_empty = false;
 388     p_vout->p->i_picture_qtype = QTYPE_NONE;
 389     p_vout->p->b_picture_interlaced = false;
 390
 391     vlc_mouse_Init( &p_vout->p->mouse );
 392
 393     vout_snapshot_Init( &p_vout->p->snapshot );
 394
 395     /* Initialize locks */
 396     vlc_mutex_init( &p_vout->picture_lock );
 397     vlc_cond_init( &p_vout->p->picture_wait );
 398     vlc_mutex_init( &p_vout->change_lock );
 399     vlc_mutex_init( &p_vout->p->vfilter_lock );
 400
 401     /* Mouse coordinates */
 402     var_Create( p_vout, "mouse-button-down", VLC_VAR_INTEGER );
 403     var_Create( p_vout, "mouse-moved", VLC_VAR_COORDS );
 404     var_Create( p_vout, "mouse-clicked", VLC_VAR_COORDS );
 405     /* Mouse object (area of interest in a video filter) */
 406     var_Create( p_vout, "mouse-object", VLC_VAR_BOOL );
 407
 408     /* Attach the new object now so we can use var inheritance below */
 409     vlc_object_attach( p_vout, p_parent );
 410
 411     /* Initialize subpicture unit */
 412     p_vout->p_spu = spu_Create( p_vout );
 413
 414     /* */
 415     spu_Init( p_vout->p_spu );
 416
 417     spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), true );
 418
 419     /* Take care of some "interface/control" related initialisations */
 420     vout_IntfInit( p_vout );
 421
 422     /* If the parent is not a VOUT object, that means we are at the start of
 423      * the video output pipe */
 424     if( vlc_internals( p_parent )->i_object_type != VLC_OBJECT_VOUT )
 425     {
 426         /* Look for the default filter configuration */
 427         p_vout->p->psz_filter_chain =
 428             var_CreateGetStringCommand( p_vout, "vout-filter" );
 429
 430         /* Apply video filter2 objects on the first vout */
 431         p_vout->p->psz_vf2 =
 432             var_CreateGetStringCommand( p_vout, "video-filter" );
 433
 434         p_vout->p->b_first_vout = true;
 435     }
 436     else
 437     {
 438         /* continue the parent's filter chain */
 439         char *psz_tmp;
 440
 441         /* Ugly hack to jump to our configuration chain */
 442         p_vout->p->psz_filter_chain
 443             = ((vout_thread_t *)p_parent)->p->psz_filter_chain;
 444         p_vout->p->psz_filter_chain
 445             = config_ChainCreate( &psz_tmp, &p_cfg, p_vout->p->psz_filter_chain );
 446         config_ChainDestroy( p_cfg );
 447         free( psz_tmp );
 448
 449         /* Create a video filter2 var ... but don't inherit values */
 450         var_Create( p_vout, "video-filter",
 451                     VLC_VAR_STRING | VLC_VAR_ISCOMMAND );
 452         p_vout->p->psz_vf2 = var_GetString( p_vout, "video-filter" );
 453
 454         /* */
 455         p_vout->p->b_first_vout = false;
 456     }
 457
 458     var_AddCallback( p_vout, "video-filter", VideoFilter2Callback, NULL );
 459     p_vout->p->p_vf2_chain = filter_chain_New( p_vout, "video filter2",
 460         false, video_filter_buffer_allocation_init, NULL, p_vout );
 461
 462     /* Choose the video output module */
 463     if( !p_vout->p->psz_filter_chain || !*p_vout->p->psz_filter_chain )
 464     {
 465         psz_parser = NULL;
 466     }
 467     else
 468     {
 469         psz_parser = strdup( p_vout->p->psz_filter_chain );
 470         p_vout->p->b_title_show = false;
 471     }
 472
 473     /* Create the vout thread */
 474     char *psz_tmp = config_ChainCreate( &psz_name, &p_cfg, psz_parser );
 475     free( psz_parser );
 476     free( psz_tmp );
 477     p_vout->p_cfg = p_cfg;
 478
 479     /* Create a few object variables for interface interaction */
 480     var_Create( p_vout, "vout-filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
 481     text.psz_string = _("Filters");
 482     var_Change( p_vout, "vout-filter", VLC_VAR_SETTEXT, &text, NULL );
 483     var_AddCallback( p_vout, "vout-filter", FilterCallback, NULL );
 484
 485     /* */
 486     DeinterlaceEnable( p_vout );
 487
 488     if( p_vout->p->psz_filter_chain && *p_vout->p->psz_filter_chain )
 489     {
 490         char *psz_tmp;
 491         if( asprintf( &psz_tmp, "%s,none", psz_name ) < 0 )
 492             psz_tmp = strdup( "" );
 493         free( psz_name );
 494         psz_name = psz_tmp;
 495     }
 496     p_vout->p->psz_module_name = psz_name;
 497
 498     /* */
 499     vlc_object_set_destructor( p_vout, vout_Destructor );
 500
 501     /* */
 502     vlc_cond_init( &p_vout->p->change_wait );
 503     if( vlc_clone( &p_vout->p->thread, RunThread, p_vout,
 504                    VLC_THREAD_PRIORITY_OUTPUT ) )
 505     {
 506         spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), false );
 507         spu_Destroy( p_vout->p_spu );
 508         p_vout->p_spu = NULL;
 509         vlc_object_release( p_vout );
 510         return NULL;
 511     }
 512
 513     vlc_mutex_lock( &p_vout->change_lock );
 514     while( !p_vout->p->b_ready )
 515     {   /* We are (ab)using the same condition in opposite directions for
 516          * b_ready and b_done. This works because of the strict ordering. */
 517         assert( !p_vout->p->b_done );
 518         vlc_cond_wait( &p_vout->p->change_wait, &p_vout->change_lock );
 519     }
 520     vlc_mutex_unlock( &p_vout->change_lock );
 521
 522     if( p_vout->b_error )
 523     {
 524         msg_Err( p_vout, "video output creation failed" );
 525         vout_CloseAndRelease( p_vout );
 526         return NULL;
 527     }
 528
 529     return p_vout;
 530 }
 531
 532 /*****************************************************************************
 533  * vout_Close: Close a vout created by vout_Create.
 534  *****************************************************************************
 535  * You HAVE to call it on vout created by vout_Create before vlc_object_release.
 536  * You should NEVER call it on vout not obtained through vout_Create
 537  * (like with vout_Request or vlc_object_find.)
 538  * You can use vout_CloseAndRelease() as a convenience method.
 539  *****************************************************************************/
 540 void vout_Close( vout_thread_t *p_vout )
 541 {
 542     assert( p_vout );
 543
 544     vlc_mutex_lock( &p_vout->change_lock );
 545     p_vout->p->b_done = true;
 546     vlc_cond_signal( &p_vout->p->change_wait );
 547     vlc_mutex_unlock( &p_vout->change_lock );
 548
 549     vout_snapshot_End( &p_vout->p->snapshot );
 550
 551     vlc_join( p_vout->p->thread, NULL );
 552 }
 553
 554 /* */
 555 static void vout_Destructor( vlc_object_t * p_this )
 556 {
 557     vout_thread_t *p_vout = (vout_thread_t *)p_this;
 558
 559     /* Make sure the vout was stopped first */
 560     //assert( !p_vout->p_module );
 561
 562     free( p_vout->p->psz_module_name );
 563
 564     /* */
 565     if( p_vout->p_spu )
 566         spu_Destroy( p_vout->p_spu );
 567
 568     /* Destroy the locks */
 569     vlc_cond_destroy( &p_vout->p->change_wait );
 570     vlc_cond_destroy( &p_vout->p->picture_wait );
 571     vlc_mutex_destroy( &p_vout->picture_lock );
 572     vlc_mutex_destroy( &p_vout->change_lock );
 573     vlc_mutex_destroy( &p_vout->p->vfilter_lock );
 574
 575     /* */
 576     vout_statistic_Clean( &p_vout->p->statistic );
 577
 578     /* */
 579     vout_snapshot_Clean( &p_vout->p->snapshot );
 580
 581     /* */
 582     free( p_vout->p->psz_filter_chain );
 583     free( p_vout->p->psz_title );
 584
 585     config_ChainDestroy( p_vout->p_cfg );
 586
 587     free( p_vout->p );
 588
 589 }
 590
 591 /* */
 592 void vout_ChangePause( vout_thread_t *p_vout, bool b_paused, mtime_t i_date )
 593 {
 594     vlc_mutex_lock( &p_vout->change_lock );
 595
 596     assert( !p_vout->p->b_paused || !b_paused );
 597
 598     vlc_mutex_lock( &p_vout->picture_lock );
 599
 600     p_vout->p->i_picture_displayed_date = 0;
 601
 602     if( p_vout->p->b_paused )
 603     {
 604         const mtime_t i_duration = i_date - p_vout->p->i_pause_date;
 605
 606         for( int i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
 607         {
 608             picture_t *p_pic = PP_RENDERPICTURE[i_index];
 609
 610             if( p_pic->i_status == READY_PICTURE )
 611                 p_pic->date += i_duration;
 612         }
 613         vlc_cond_signal( &p_vout->p->picture_wait );
 614         vlc_mutex_unlock( &p_vout->picture_lock );
 615
 616         spu_OffsetSubtitleDate( p_vout->p_spu, i_duration );
 617     }
 618     else
 619     {
 620         vlc_mutex_unlock( &p_vout->picture_lock );
 621     }
 622     p_vout->p->b_paused = b_paused;
 623     p_vout->p->i_pause_date = i_date;
 624
 625     vlc_mutex_unlock( &p_vout->change_lock );
 626 }
 627
 628 void vout_GetResetStatistic( vout_thread_t *p_vout, int *pi_displayed, int *pi_lost )
 629 {
 630     vout_statistic_GetReset( &p_vout->p->statistic,
 631                              pi_displayed, pi_lost );
 632 }
 633
 634 void vout_Flush( vout_thread_t *p_vout, mtime_t i_date )
 635 {
 636     vlc_mutex_lock( &p_vout->picture_lock );
 637     p_vout->p->i_picture_displayed_date = 0;
 638     for( int i = 0; i < p_vout->render.i_pictures; i++ )
 639     {
 640         picture_t *p_pic = p_vout->render.pp_picture[i];
 641
 642         if( p_pic->i_status == READY_PICTURE ||
 643             p_pic->i_status == DISPLAYED_PICTURE )
 644         {
 645             /* We cannot change picture status if it is in READY_PICTURE state,
 646              * Just make sure they won't be displayed */
 647             if( p_pic->date > i_date )
 648                 p_pic->date = i_date;
 649         }
 650     }
 651     vlc_cond_signal( &p_vout->p->picture_wait );
 652     vlc_mutex_unlock( &p_vout->picture_lock );
 653 }
 654
 655 void vout_FixLeaks( vout_thread_t *p_vout, bool b_forced )
 656 {
 657     int i_pic, i_ready_pic;
 658
 659     vlc_mutex_lock( &p_vout->picture_lock );
 660
 661     for( i_pic = 0, i_ready_pic = 0; i_pic < p_vout->render.i_pictures && !b_forced; i_pic++ )
 662     {
 663         const picture_t *p_pic = p_vout->render.pp_picture[i_pic];
 664
 665         if( p_pic->i_status == READY_PICTURE )
 666         {
 667             i_ready_pic++;
 668             /* If we have at least 2 ready pictures, wait for the vout thread to
 669              * process one */
 670             if( i_ready_pic >= 2 )
 671                 break;
 672
 673             continue;
 674         }
 675
 676         if( p_pic->i_status == DISPLAYED_PICTURE )
 677         {
 678             /* If at least one displayed picture is not referenced
 679              * let vout free it */
 680             if( p_pic->i_refcount == 0 )
 681                 break;
 682         }
 683     }
 684     if( i_pic < p_vout->render.i_pictures && !b_forced )
 685     {
 686         vlc_mutex_unlock( &p_vout->picture_lock );
 687         return;
 688     }
 689
 690     /* Too many pictures are still referenced, there is probably a bug
 691      * with the decoder */
 692     if( !b_forced )
 693         msg_Err( p_vout, "pictures leaked, resetting the heap" );
 694
 695     /* Just free all the pictures */
 696     for( i_pic = 0; i_pic < p_vout->render.i_pictures; i_pic++ )
 697     {
 698         picture_t *p_pic = p_vout->render.pp_picture[i_pic];
 699
 700         msg_Dbg( p_vout, "[%d] %d %d", i_pic, p_pic->i_status, p_pic->i_refcount );
 701         p_pic->i_refcount = 0;
 702
 703         switch( p_pic->i_status )
 704         {
 705         case READY_PICTURE:
 706         case DISPLAYED_PICTURE:
 707         case RESERVED_PICTURE:
 708             if( p_pic != p_vout->p->p_picture_displayed )
 709                 vout_UsePictureLocked( p_vout, p_pic );
 710             break;
 711         }
 712     }
 713     vlc_cond_signal( &p_vout->p->picture_wait );
 714     vlc_mutex_unlock( &p_vout->picture_lock );
 715 }
 716 void vout_NextPicture( vout_thread_t *p_vout, mtime_t *pi_duration )
 717 {
 718     vlc_mutex_lock( &p_vout->picture_lock );
 719
 720     const mtime_t i_displayed_date = p_vout->p->i_picture_displayed_date;
 721
 722     p_vout->p->b_picture_displayed = false;
 723     p_vout->p->b_picture_empty = false;
 724     if( p_vout->p->p_picture_displayed )
 725     {
 726         p_vout->p->p_picture_displayed->date = 1;
 727         vlc_cond_signal( &p_vout->p->picture_wait );
 728     }
 729
 730     while( !p_vout->p->b_picture_displayed && !p_vout->p->b_picture_empty )
 731         vlc_cond_wait( &p_vout->p->picture_wait, &p_vout->picture_lock );
 732
 733     *pi_duration = __MAX( p_vout->p->i_picture_displayed_date - i_displayed_date, 0 );
 734
 735     /* TODO advance subpicture by the duration ... */
 736
 737     vlc_mutex_unlock( &p_vout->picture_lock );
 738 }
 739
 740 void vout_DisplayTitle( vout_thread_t *p_vout, const char *psz_title )
 741 {
 742     assert( psz_title );
 743
 744     if( !var_InheritBool( p_vout, "osd" ) )
 745         return;
 746
 747     vlc_mutex_lock( &p_vout->change_lock );
 748     free( p_vout->p->psz_title );
 749     p_vout->p->psz_title = strdup( psz_title );
 750     vlc_mutex_unlock( &p_vout->change_lock );
 751 }
 752
 753 spu_t *vout_GetSpu( vout_thread_t *p_vout )
 754 {
 755     return p_vout->p_spu;
 756 }
 757
 758 /*****************************************************************************
 759  * InitThread: initialize video output thread
 760  *****************************************************************************
 761  * This function is called from RunThread and performs the second step of the
 762  * initialization. It returns 0 on success. Note that the thread's flag are not
 763  * modified inside this function.
 764  * XXX You have to enter it with change_lock taken.
 765  *****************************************************************************/
 766 static int ChromaCreate( vout_thread_t *p_vout );
 767 static void ChromaDestroy( vout_thread_t *p_vout );
 768
 769 static bool ChromaIsEqual( const picture_heap_t *p_output, const picture_heap_t *p_render )
 770 {
 771      if( !vout_ChromaCmp( p_output->i_chroma, p_render->i_chroma ) )
 772          return false;
 773
 774      if( p_output->i_chroma != VLC_CODEC_RGB15 &&
 775          p_output->i_chroma != VLC_CODEC_RGB16 &&
 776          p_output->i_chroma != VLC_CODEC_RGB24 &&
 777          p_output->i_chroma != VLC_CODEC_RGB32 )
 778          return true;
 779
 780      return p_output->i_rmask == p_render->i_rmask &&
 781             p_output->i_gmask == p_render->i_gmask &&
 782             p_output->i_bmask == p_render->i_bmask;
 783 }
 784
 785 static int InitThread( vout_thread_t *p_vout )
 786 {
 787     int i;
 788
 789     /* Initialize output method, it allocates direct buffers for us */
 790     if( vout_InitWrapper( p_vout ) )
 791         return VLC_EGENERIC;
 792
 793     p_vout->p->p_picture_displayed = NULL;
 794
 795     if( !I_OUTPUTPICTURES )
 796     {
 797         msg_Err( p_vout, "plugin was unable to allocate at least "
 798                          "one direct buffer" );
 799         vout_EndWrapper( p_vout );
 800         return VLC_EGENERIC;
 801     }
 802
 803     if( I_OUTPUTPICTURES > VOUT_MAX_PICTURES )
 804     {
 805         msg_Err( p_vout, "plugin allocated too many direct buffers, "
 806                          "our internal buffers must have overflown." );
 807         vout_EndWrapper( p_vout );
 808         return VLC_EGENERIC;
 809     }
 810
 811     msg_Dbg( p_vout, "got %i direct buffer(s)", I_OUTPUTPICTURES );
 812
 813     if( !p_vout->fmt_out.i_width || !p_vout->fmt_out.i_height )
 814     {
 815         p_vout->fmt_out.i_width = p_vout->fmt_out.i_visible_width =
 816             p_vout->output.i_width;
 817         p_vout->fmt_out.i_height = p_vout->fmt_out.i_visible_height =
 818             p_vout->output.i_height;
 819         p_vout->fmt_out.i_x_offset =  p_vout->fmt_out.i_y_offset = 0;
 820
 821         p_vout->fmt_out.i_chroma = p_vout->output.i_chroma;
 822     }
 823     if( !p_vout->fmt_out.i_sar_num || !p_vout->fmt_out.i_sar_num )
 824     {
 825         p_vout->fmt_out.i_sar_num = p_vout->output.i_aspect *
 826             p_vout->fmt_out.i_height;
 827         p_vout->fmt_out.i_sar_den = VOUT_ASPECT_FACTOR *
 828             p_vout->fmt_out.i_width;
 829     }
 830
 831     vlc_ureduce( &p_vout->fmt_out.i_sar_num, &p_vout->fmt_out.i_sar_den,
 832                  p_vout->fmt_out.i_sar_num, p_vout->fmt_out.i_sar_den, 0 );
 833
 834     /* FIXME removed the need of both fmt_* and heap infos */
 835     /* Calculate shifts from system-updated masks */
 836     PictureHeapFixRgb( &p_vout->render );
 837     VideoFormatImportRgb( &p_vout->fmt_render, &p_vout->render );
 838
 839     PictureHeapFixRgb( &p_vout->output );
 840     VideoFormatImportRgb( &p_vout->fmt_out, &p_vout->output );
 841
 842     /* print some usefull debug info about different vout formats
 843      */
 844     msg_Dbg( p_vout, "pic render sz %ix%i, of (%i,%i), vsz %ix%i, 4cc %4.4s, sar %i:%i, msk r0x%x g0x%x b0x%x",
 845              p_vout->fmt_render.i_width, p_vout->fmt_render.i_height,
 846              p_vout->fmt_render.i_x_offset, p_vout->fmt_render.i_y_offset,
 847              p_vout->fmt_render.i_visible_width,
 848              p_vout->fmt_render.i_visible_height,
 849              (char*)&p_vout->fmt_render.i_chroma,
 850              p_vout->fmt_render.i_sar_num, p_vout->fmt_render.i_sar_den,
 851              p_vout->fmt_render.i_rmask, p_vout->fmt_render.i_gmask, p_vout->fmt_render.i_bmask );
 852
 853     msg_Dbg( p_vout, "pic in sz %ix%i, of (%i,%i), vsz %ix%i, 4cc %4.4s, sar %i:%i, msk r0x%x g0x%x b0x%x",
 854              p_vout->fmt_in.i_width, p_vout->fmt_in.i_height,
 855              p_vout->fmt_in.i_x_offset, p_vout->fmt_in.i_y_offset,
 856              p_vout->fmt_in.i_visible_width,
 857              p_vout->fmt_in.i_visible_height,
 858              (char*)&p_vout->fmt_in.i_chroma,
 859              p_vout->fmt_in.i_sar_num, p_vout->fmt_in.i_sar_den,
 860              p_vout->fmt_in.i_rmask, p_vout->fmt_in.i_gmask, p_vout->fmt_in.i_bmask );
 861
 862     msg_Dbg( p_vout, "pic out sz %ix%i, of (%i,%i), vsz %ix%i, 4cc %4.4s, sar %i:%i, msk r0x%x g0x%x b0x%x",
 863              p_vout->fmt_out.i_width, p_vout->fmt_out.i_height,
 864              p_vout->fmt_out.i_x_offset, p_vout->fmt_out.i_y_offset,
 865              p_vout->fmt_out.i_visible_width,
 866              p_vout->fmt_out.i_visible_height,
 867              (char*)&p_vout->fmt_out.i_chroma,
 868              p_vout->fmt_out.i_sar_num, p_vout->fmt_out.i_sar_den,
 869              p_vout->fmt_out.i_rmask, p_vout->fmt_out.i_gmask, p_vout->fmt_out.i_bmask );
 870
 871     /* Check whether we managed to create direct buffers similar to
 872      * the render buffers, ie same size and chroma */
 873     if( ( p_vout->output.i_width == p_vout->render.i_width )
 874      && ( p_vout->output.i_height == p_vout->render.i_height )
 875      && ( ChromaIsEqual( &p_vout->output, &p_vout->render ) ) )
 876     {
 877         /* Cool ! We have direct buffers, we can ask the decoder to
 878          * directly decode into them ! Map the first render buffers to
 879          * the first direct buffers, but keep the first direct buffer
 880          * for memcpy operations */
 881         p_vout->p->b_direct = true;
 882
 883         for( i = 1; i < VOUT_MAX_PICTURES; i++ )
 884         {
 885             if( p_vout->p_picture[ i ].i_type != DIRECT_PICTURE &&
 886                 I_RENDERPICTURES >= VOUT_MIN_DIRECT_PICTURES - 1 &&
 887                 p_vout->p_picture[ i - 1 ].i_type == DIRECT_PICTURE )
 888             {
 889                 /* We have enough direct buffers so there's no need to
 890                  * try to use system memory buffers. */
 891                 break;
 892             }
 893             PP_RENDERPICTURE[ I_RENDERPICTURES ] = &p_vout->p_picture[ i ];
 894             I_RENDERPICTURES++;
 895         }
 896
 897         msg_Dbg( p_vout, "direct render, mapping "
 898                  "render pictures 0-%i to system pictures 1-%i",
 899                  VOUT_MAX_PICTURES - 2, VOUT_MAX_PICTURES - 1 );
 900     }
 901     else
 902     {
 903         /* Rats... Something is wrong here, we could not find an output
 904          * plugin able to directly render what we decode. See if we can
 905          * find a chroma plugin to do the conversion */
 906         p_vout->p->b_direct = false;
 907
 908         if( ChromaCreate( p_vout ) )
 909         {
 910             vout_EndWrapper( p_vout );
 911             return VLC_EGENERIC;
 912         }
 913
 914         msg_Dbg( p_vout, "indirect render, mapping "
 915                  "render pictures 0-%i to system pictures %i-%i",
 916                  VOUT_MAX_PICTURES - 1, I_OUTPUTPICTURES,
 917                  I_OUTPUTPICTURES + VOUT_MAX_PICTURES - 1 );
 918
 919         /* Append render buffers after the direct buffers */
 920         for( i = I_OUTPUTPICTURES; i < 2 * VOUT_MAX_PICTURES; i++ )
 921         {
 922             PP_RENDERPICTURE[ I_RENDERPICTURES ] = &p_vout->p_picture[ i ];
 923             I_RENDERPICTURES++;
 924
 925             /* Check if we have enough render pictures */
 926             if( I_RENDERPICTURES == VOUT_MAX_PICTURES )
 927                 break;
 928         }
 929     }
 930
 931     return VLC_SUCCESS;
 932 }
 933
 934 /*****************************************************************************
 935  * RunThread: video output thread
 936  *****************************************************************************
 937  * Video output thread. This function does only returns when the thread is
 938  * terminated. It handles the pictures arriving in the video heap and the
 939  * display device events.
 940  *****************************************************************************/
 941 static void* RunThread( void *p_this )
 942 {
 943     vout_thread_t *p_vout = p_this;
 944     bool            b_has_wrapper;
 945     int             i_idle_loops = 0;  /* loops without displaying a picture */
 946     int             i_picture_qtype_last = QTYPE_NONE;
 947     bool            b_picture_interlaced_last = false;
 948     mtime_t         i_picture_interlaced_last_date;
 949
 950     /*
 951      * Initialize thread
 952      */
 953     b_has_wrapper = !vout_OpenWrapper( p_vout, p_vout->p->psz_module_name );
 954
 955     vlc_mutex_lock( &p_vout->change_lock );
 956
 957     if( b_has_wrapper )
 958         p_vout->b_error = InitThread( p_vout );
 959     else
 960         p_vout->b_error = true;
 961
 962     /* signal the creation of the vout */
 963     p_vout->p->b_ready = true;
 964     vlc_cond_signal( &p_vout->p->change_wait );
 965
 966     if( p_vout->b_error )
 967         goto exit_thread;
 968
 969     /* */
 970     const bool b_drop_late = var_CreateGetBool( p_vout, "drop-late-frames" );
 971     i_picture_interlaced_last_date = mdate();
 972
 973     /*
 974      * Main loop - it is not executed if an error occurred during
 975      * initialization
 976      */
 977     while( !p_vout->p->b_done && !p_vout->b_error )
 978     {
 979         /* Initialize loop variables */
 980         const mtime_t current_date = mdate();
 981         picture_t *p_picture;
 982         picture_t *p_filtered_picture;
 983         mtime_t display_date;
 984         picture_t *p_directbuffer;
 985         int i_index;
 986
 987         if( p_vout->p->b_title_show && p_vout->p->psz_title )
 988             DisplayTitleOnOSD( p_vout );
 989
 990         vlc_mutex_lock( &p_vout->picture_lock );
 991
 992         /* Look for the earliest picture but after the last displayed one */
 993         picture_t *p_last = p_vout->p->p_picture_displayed;;
 994
 995         p_picture = NULL;
 996         for( i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
 997         {
 998             picture_t *p_pic = PP_RENDERPICTURE[i_index];
 999
1000             if( p_pic->i_status != READY_PICTURE )
1001                 continue;
1002
1003             if( p_vout->p->b_paused && p_last && p_last->date > 1 )
1004                 continue;
1005
1006             if( p_last && p_pic != p_last && p_pic->date <= p_last->date )
1007             {
1008                 /* Drop old picture */
1009                 vout_UsePictureLocked( p_vout, p_pic );
1010             }
1011             else if( !p_vout->p->b_paused && !p_pic->b_force && p_pic != p_last &&
1012                      p_pic->date < current_date + p_vout->p->render_time &&
1013                      b_drop_late )
1014             {
1015                 /* Picture is late: it will be destroyed and the thread
1016                  * will directly choose the next picture */
1017                 vout_UsePictureLocked( p_vout, p_pic );
1018                 vout_statistic_Update( &p_vout->p->statistic, 0, 1 );
1019
1020                 msg_Warn( p_vout, "late picture skipped (%"PRId64" > %d)",
1021                                   current_date - p_pic->date, - p_vout->p->render_time );
1022             }
1023             else if( ( !p_last || p_last->date < p_pic->date ) &&
1024                      ( p_picture == NULL || p_pic->date < p_picture->date ) )
1025             {
1026                 p_picture = p_pic;
1027             }
1028         }
1029         if( !p_picture )
1030         {
1031             p_picture = p_last;
1032
1033             if( !p_vout->p->b_picture_empty )
1034             {
1035                 p_vout->p->b_picture_empty = true;
1036                 vlc_cond_signal( &p_vout->p->picture_wait );
1037             }
1038         }
1039
1040         display_date = 0;
1041         if( p_picture )
1042         {
1043             display_date = p_picture->date;
1044
1045             /* If we found better than the last picture, destroy it */
1046             if( p_last && p_picture != p_last )
1047             {
1048                 vout_UsePictureLocked( p_vout, p_last );
1049                 p_vout->p->p_picture_displayed = p_last = NULL;
1050             }
1051
1052             /* Compute FPS rate */
1053             p_vout->p->p_fps_sample[ p_vout->p->c_fps_samples++ % VOUT_FPS_SAMPLES ] = display_date;
1054
1055             if( !p_vout->p->b_paused && display_date > current_date + VOUT_DISPLAY_DELAY )
1056             {
1057                 /* A picture is ready to be rendered, but its rendering date
1058                  * is far from the current one so the thread will perform an
1059                  * empty loop as if no picture were found. The picture state
1060                  * is unchanged */
1061                 p_picture    = NULL;
1062                 display_date = 0;
1063             }
1064             else if( p_picture == p_last )
1065             {
1066                 /* We are asked to repeat the previous picture, but we first
1067                  * wait for a couple of idle loops */
1068                 if( i_idle_loops < 4 )
1069                 {
1070                     p_picture    = NULL;
1071                     display_date = 0;
1072                 }
1073                 else
1074                 {
1075                     /* We set the display date to something high, otherwise
1076                      * we'll have lots of problems with late pictures */
1077                     display_date = current_date + p_vout->p->render_time;
1078                 }
1079             }
1080             else if( p_vout->p->b_paused && display_date > current_date + VOUT_DISPLAY_DELAY )
1081             {
1082                 display_date = current_date + VOUT_DISPLAY_DELAY;
1083             }
1084
1085             if( p_picture )
1086             {
1087                 if( p_picture->date > 1 )
1088                 {
1089                     p_vout->p->i_picture_displayed_date = p_picture->date;
1090                     if( p_picture != p_last && !p_vout->p->b_picture_displayed )
1091                     {
1092                         p_vout->p->b_picture_displayed = true;
1093                         vlc_cond_signal( &p_vout->p->picture_wait );
1094                     }
1095                 }
1096                 p_vout->p->p_picture_displayed = p_picture;
1097             }
1098         }
1099
1100         /* */
1101         const int i_postproc_type = p_vout->p->i_picture_qtype;
1102         const int i_postproc_state = (p_vout->p->i_picture_qtype != QTYPE_NONE) - (i_picture_qtype_last != QTYPE_NONE);
1103
1104         const bool b_picture_interlaced = p_vout->p->b_picture_interlaced;
1105         const int  i_picture_interlaced_state = (!!p_vout->p->b_picture_interlaced) - (!!b_picture_interlaced_last);
1106
1107         vlc_mutex_unlock( &p_vout->picture_lock );
1108
1109         if( p_picture == NULL )
1110             i_idle_loops++;
1111
1112         p_filtered_picture = NULL;
1113         if( p_picture )
1114         {
1115             vlc_mutex_lock( &p_vout->p->vfilter_lock );
1116             p_filtered_picture = filter_chain_VideoFilter( p_vout->p->p_vf2_chain,
1117                                                            p_picture );
1118             vlc_mutex_unlock( &p_vout->p->vfilter_lock );
1119         }
1120
1121         const bool b_snapshot = vout_snapshot_IsRequested( &p_vout->p->snapshot );
1122
1123         /*
1124          * Check for subpictures to display
1125          */
1126         mtime_t spu_render_time;
1127         if( p_vout->p->b_paused )
1128             spu_render_time = p_vout->p->i_pause_date;
1129         else if( p_picture )
1130             spu_render_time = p_picture->date > 1 ? p_picture->date : mdate();
1131         else
1132             spu_render_time = 0;
1133
1134         subpicture_t *p_subpic = spu_SortSubpictures( p_vout->p_spu,
1135                                                       spu_render_time,
1136                                                       b_snapshot );
1137         /*
1138          * Perform rendering
1139          */
1140         vout_statistic_Update( &p_vout->p->statistic, 1, 0 );
1141         p_directbuffer = vout_RenderPicture( p_vout,
1142                                              p_filtered_picture, p_subpic,
1143                                              spu_render_time );
1144
1145         /*
1146          * Take a snapshot if requested
1147          */
1148         if( p_directbuffer && b_snapshot )
1149             vout_snapshot_Set( &p_vout->p->snapshot,
1150                                &p_vout->fmt_out, p_directbuffer );
1151
1152         /*
1153          * Call the plugin-specific rendering method if there is one
1154          */
1155         if( p_filtered_picture != NULL && p_directbuffer != NULL )
1156         {
1157             /* Render the direct buffer returned by vout_RenderPicture */
1158             vout_RenderWrapper( p_vout, p_directbuffer );
1159         }
1160
1161         /*
1162          * Sleep, wake up
1163          */
1164         if( display_date != 0 && p_directbuffer != NULL )
1165         {
1166             mtime_t current_render_time = mdate() - current_date;
1167             /* if render time is very large we don't include it in the mean */
1168             if( current_render_time < p_vout->p->render_time +
1169                 VOUT_DISPLAY_DELAY )
1170             {
1171                 /* Store render time using a sliding mean weighting to
1172                  * current value in a 3 to 1 ratio*/
1173                 p_vout->p->render_time *= 3;
1174                 p_vout->p->render_time += current_render_time;
1175                 p_vout->p->render_time >>= 2;
1176             }
1177             else
1178                 msg_Dbg( p_vout, "skipped big render time %d > %d", (int) current_render_time,
1179                  (int) (p_vout->p->render_time +VOUT_DISPLAY_DELAY ) ) ;
1180         }
1181
1182         /* Give back change lock */
1183         vlc_mutex_unlock( &p_vout->change_lock );
1184
1185         /* Sleep a while or until a given date */
1186         if( display_date != 0 )
1187         {
1188             /* If there are *vout* filters in the chain, better give them the picture
1189              * in advance */
1190             if( !p_vout->p->psz_filter_chain || !*p_vout->p->psz_filter_chain )
1191             {
1192                 mwait( display_date - VOUT_MWAIT_TOLERANCE );
1193             }
1194         }
1195         else
1196         {
1197             /* Wait until a frame is being sent or a spurious wakeup (not a problem here) */
1198             vlc_mutex_lock( &p_vout->picture_lock );
1199             vlc_cond_timedwait( &p_vout->p->picture_wait, &p_vout->picture_lock, current_date + VOUT_IDLE_SLEEP );
1200             vlc_mutex_unlock( &p_vout->picture_lock );
1201         }
1202
1203         /* On awakening, take back lock and send immediately picture
1204          * to display. */
1205         /* Note: p_vout->p->b_done could be true here and now */
1206         vlc_mutex_lock( &p_vout->change_lock );
1207
1208         /*
1209          * Display the previously rendered picture
1210          */
1211         if( p_filtered_picture != NULL && p_directbuffer != NULL )
1212         {
1213             /* Display the direct buffer returned by vout_RenderPicture */
1214             vout_DisplayWrapper( p_vout, p_directbuffer );
1215
1216             /* Tell the vout this was the last picture and that it does not
1217              * need to be forced anymore. */
1218             p_picture->b_force = false;
1219         }
1220
1221         /* Drop the filtered picture if created by video filters */
1222         if( p_filtered_picture != NULL && p_filtered_picture != p_picture )
1223         {
1224             vlc_mutex_lock( &p_vout->picture_lock );
1225             vout_UsePictureLocked( p_vout, p_filtered_picture );
1226             vlc_mutex_unlock( &p_vout->picture_lock );
1227         }
1228
1229         if( p_picture != NULL )
1230         {
1231             /* Reinitialize idle loop count */
1232             i_idle_loops = 0;
1233         }
1234
1235         /*
1236          * Check events and manage thread
1237          */
1238         if( vout_ManageWrapper( p_vout ) )
1239         {
1240             /* A fatal error occurred, and the thread must terminate
1241              * immediately, without displaying anything - setting b_error to 1
1242              * causes the immediate end of the main while() loop. */
1243             // FIXME pf_end
1244             p_vout->b_error = 1;
1245             break;
1246         }
1247
1248         if( p_vout->i_changes & VOUT_ON_TOP_CHANGE )
1249             p_vout->i_changes &= ~VOUT_ON_TOP_CHANGE;
1250
1251         if( p_vout->i_changes & VOUT_SIZE_CHANGE )
1252         {
1253             /* this must only happen when the vout plugin is incapable of
1254              * rescaling the picture itself. In this case we need to destroy
1255              * the current picture buffers and recreate new ones with the right
1256              * dimensions */
1257             int i;
1258
1259             p_vout->i_changes &= ~VOUT_SIZE_CHANGE;
1260
1261             assert( !p_vout->p->b_direct );
1262
1263             ChromaDestroy( p_vout );
1264
1265             vlc_mutex_lock( &p_vout->picture_lock );
1266
1267             vout_EndWrapper( p_vout );
1268
1269             p_vout->p->p_picture_displayed = NULL;
1270             for( i = 0; i < I_OUTPUTPICTURES; i++ )
1271                  p_vout->p_picture[ i ].i_status = FREE_PICTURE;
1272             vlc_cond_signal( &p_vout->p->picture_wait );
1273
1274             I_OUTPUTPICTURES = 0;
1275
1276             if( vout_InitWrapper( p_vout ) )
1277             {
1278                 msg_Err( p_vout, "cannot resize display" );
1279                 /* FIXME: pf_end will be called again in CleanThread()? */
1280                 p_vout->b_error = 1;
1281             }
1282
1283             vlc_mutex_unlock( &p_vout->picture_lock );
1284
1285             /* Need to reinitialise the chroma plugin. Since we might need
1286              * resizing too and it's not sure that we already had it,
1287              * recreate the chroma plugin chain from scratch. */
1288             /* dionoea */
1289             if( ChromaCreate( p_vout ) )
1290             {
1291                 msg_Err( p_vout, "WOW THIS SUCKS BIG TIME!!!!!" );
1292                 p_vout->b_error = 1;
1293             }
1294             if( p_vout->b_error )
1295                 break;
1296         }
1297
1298         if( p_vout->i_changes & VOUT_PICTURE_BUFFERS_CHANGE )
1299         {
1300             /* This happens when the picture buffers need to be recreated.
1301              * This is useful on multimonitor displays for instance.
1302              *
1303              * Warning: This only works when the vout creates only 1 picture
1304              * buffer!! */
1305             p_vout->i_changes &= ~VOUT_PICTURE_BUFFERS_CHANGE;
1306
1307             if( !p_vout->p->b_direct )
1308                 ChromaDestroy( p_vout );
1309
1310             vlc_mutex_lock( &p_vout->picture_lock );
1311
1312             vout_EndWrapper( p_vout );
1313
1314             I_OUTPUTPICTURES = I_RENDERPICTURES = 0;
1315
1316             p_vout->b_error = InitThread( p_vout );
1317             if( p_vout->b_error )
1318                 msg_Err( p_vout, "InitThread after VOUT_PICTURE_BUFFERS_CHANGE failed" );
1319
1320             vlc_cond_signal( &p_vout->p->picture_wait );
1321             vlc_mutex_unlock( &p_vout->picture_lock );
1322
1323             if( p_vout->b_error )
1324                 break;
1325         }
1326
1327         /* Post processing */
1328         if( i_postproc_state == 1 )
1329             PostProcessEnable( p_vout );
1330         else if( i_postproc_state == -1 )
1331             PostProcessDisable( p_vout );
1332         if( i_postproc_state != 0 )
1333             i_picture_qtype_last = i_postproc_type;
1334
1335         /* Deinterlacing
1336          * Wait 30s before quiting interlacing mode */
1337         if( ( i_picture_interlaced_state == 1 ) ||
1338             ( i_picture_interlaced_state == -1 && i_picture_interlaced_last_date + 30000000 < current_date ) )
1339         {
1340             DeinterlaceNeeded( p_vout, b_picture_interlaced );
1341             b_picture_interlaced_last = b_picture_interlaced;
1342         }
1343         if( b_picture_interlaced )
1344             i_picture_interlaced_last_date = current_date;
1345
1346
1347         /* Check for "video filter2" changes */
1348         vlc_mutex_lock( &p_vout->p->vfilter_lock );
1349         if( p_vout->p->psz_vf2 )
1350         {
1351             es_format_t fmt;
1352
1353             es_format_Init( &fmt, VIDEO_ES, p_vout->fmt_render.i_chroma );
1354             fmt.video = p_vout->fmt_render;
1355             filter_chain_Reset( p_vout->p->p_vf2_chain, &fmt, &fmt );
1356
1357             if( filter_chain_AppendFromString( p_vout->p->p_vf2_chain,
1358                                                p_vout->p->psz_vf2 ) < 0 )
1359                 msg_Err( p_vout, "Video filter chain creation failed" );
1360
1361             free( p_vout->p->psz_vf2 );
1362             p_vout->p->psz_vf2 = NULL;
1363
1364             if( i_picture_qtype_last != QTYPE_NONE )
1365                 PostProcessSetFilterQuality( p_vout );
1366         }
1367         vlc_mutex_unlock( &p_vout->p->vfilter_lock );
1368     }
1369
1370     /*
1371      * Error loop - wait until the thread destruction is requested
1372      */
1373     if( p_vout->b_error )
1374         ErrorThread( p_vout );
1375
1376     /* Clean thread */
1377     CleanThread( p_vout );
1378
1379 exit_thread:
1380     /* End of thread */
1381     EndThread( p_vout );
1382     vlc_mutex_unlock( &p_vout->change_lock );
1383
1384     if( b_has_wrapper )
1385         vout_CloseWrapper( p_vout );
1386
1387     return NULL;
1388 }
1389
1390 /*****************************************************************************
1391  * ErrorThread: RunThread() error loop
1392  *****************************************************************************
1393  * This function is called when an error occurred during thread main's loop.
1394  * The thread can still receive feed, but must be ready to terminate as soon
1395  * as possible.
1396  *****************************************************************************/
1397 static void ErrorThread( vout_thread_t *p_vout )
1398 {
1399     /* Wait until a `close' order */
1400     while( !p_vout->p->b_done )
1401         vlc_cond_wait( &p_vout->p->change_wait, &p_vout->change_lock );
1402 }
1403
1404 /*****************************************************************************
1405  * CleanThread: clean up after InitThread
1406  *****************************************************************************
1407  * This function is called after a sucessful
1408  * initialization. It frees all resources allocated by InitThread.
1409  * XXX You have to enter it with change_lock taken.
1410  *****************************************************************************/
1411 static void CleanThread( vout_thread_t *p_vout )
1412 {
1413     int     i_index;                                        /* index in heap */
1414
1415     if( !p_vout->p->b_direct )
1416         ChromaDestroy( p_vout );
1417
1418     /* Destroy all remaining pictures */
1419     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++ )
1420     {
1421         if ( p_vout->p_picture[i_index].i_type == MEMORY_PICTURE )
1422         {
1423             free( p_vout->p_picture[i_index].p_data_orig );
1424         }
1425     }
1426
1427     /* Destroy translation tables */
1428     if( !p_vout->b_error )
1429         vout_EndWrapper( p_vout );
1430 }
1431
1432 /*****************************************************************************
1433  * EndThread: thread destruction
1434  *****************************************************************************
1435  * This function is called when the thread ends.
1436  * It frees all resources not allocated by InitThread.
1437  * XXX You have to enter it with change_lock taken.
1438  *****************************************************************************/
1439 static void EndThread( vout_thread_t *p_vout )
1440 {
1441     /* FIXME does that function *really* need to be called inside the thread ? */
1442
1443     /* Detach subpicture unit from both input and vout */
1444     spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), false );
1445     vlc_object_detach( p_vout->p_spu );
1446
1447     /* Destroy the video filters2 */
1448     filter_chain_Delete( p_vout->p->p_vf2_chain );
1449 }
1450
1451 /* Thread helpers */
1452 static picture_t *ChromaGetPicture( filter_t *p_filter )
1453 {
1454     picture_t *p_pic = (picture_t *)p_filter->p_owner;
1455     p_filter->p_owner = NULL;
1456     return p_pic;
1457 }
1458
1459 static int ChromaCreate( vout_thread_t *p_vout )
1460 {
1461     static const char typename[] = "chroma";
1462     filter_t *p_chroma;
1463
1464     /* Choose the best module */
1465     p_chroma = p_vout->p->p_chroma =
1466         vlc_custom_create( p_vout, sizeof(filter_t), VLC_OBJECT_GENERIC,
1467                            typename );
1468
1469     vlc_object_attach( p_chroma, p_vout );
1470
1471     /* TODO: Set the fmt_in and fmt_out stuff here */
1472     p_chroma->fmt_in.video = p_vout->fmt_render;
1473     p_chroma->fmt_out.video = p_vout->fmt_out;
1474     VideoFormatImportRgb( &p_chroma->fmt_in.video, &p_vout->render );
1475     VideoFormatImportRgb( &p_chroma->fmt_out.video, &p_vout->output );
1476
1477     p_chroma->p_module = module_need( p_chroma, "video filter2", NULL, false );
1478
1479     if( p_chroma->p_module == NULL )
1480     {
1481         msg_Err( p_vout, "no chroma module for %4.4s to %4.4s i=%dx%d o=%dx%d",
1482                  (char*)&p_vout->render.i_chroma,
1483                  (char*)&p_vout->output.i_chroma,
1484                  p_chroma->fmt_in.video.i_width, p_chroma->fmt_in.video.i_height,
1485                  p_chroma->fmt_out.video.i_width, p_chroma->fmt_out.video.i_height
1486                  );
1487
1488         vlc_object_release( p_vout->p->p_chroma );
1489         p_vout->p->p_chroma = NULL;
1490
1491         return VLC_EGENERIC;
1492     }
1493     p_chroma->pf_video_buffer_new = ChromaGetPicture;
1494     return VLC_SUCCESS;
1495 }
1496
1497 static void ChromaDestroy( vout_thread_t *p_vout )
1498 {
1499     assert( !p_vout->p->b_direct );
1500
1501     if( !p_vout->p->p_chroma )
1502         return;
1503
1504     module_unneed( p_vout->p->p_chroma, p_vout->p->p_chroma->p_module );
1505     vlc_object_release( p_vout->p->p_chroma );
1506     p_vout->p->p_chroma = NULL;
1507 }
1508
1509 /* following functions are local */
1510
1511 /**
1512  * This function copies all RGB informations from a picture_heap_t into
1513  * a video_format_t
1514  */
1515 static void VideoFormatImportRgb( video_format_t *p_fmt, const picture_heap_t *p_heap )
1516 {
1517     p_fmt->i_rmask = p_heap->i_rmask;
1518     p_fmt->i_gmask = p_heap->i_gmask;
1519     p_fmt->i_bmask = p_heap->i_bmask;
1520     p_fmt->i_rrshift = p_heap->i_rrshift;
1521     p_fmt->i_lrshift = p_heap->i_lrshift;
1522     p_fmt->i_rgshift = p_heap->i_rgshift;
1523     p_fmt->i_lgshift = p_heap->i_lgshift;
1524     p_fmt->i_rbshift = p_heap->i_rbshift;
1525     p_fmt->i_lbshift = p_heap->i_lbshift;
1526 }
1527
1528 /**
1529  * This funtion copes all RGB informations from a video_format_t into
1530  * a picture_heap_t
1531  */
1532 static void VideoFormatExportRgb( const video_format_t *p_fmt, picture_heap_t *p_heap )
1533 {
1534     p_heap->i_rmask = p_fmt->i_rmask;
1535     p_heap->i_gmask = p_fmt->i_gmask;
1536     p_heap->i_bmask = p_fmt->i_bmask;
1537     p_heap->i_rrshift = p_fmt->i_rrshift;
1538     p_heap->i_lrshift = p_fmt->i_lrshift;
1539     p_heap->i_rgshift = p_fmt->i_rgshift;
1540     p_heap->i_lgshift = p_fmt->i_lgshift;
1541     p_heap->i_rbshift = p_fmt->i_rbshift;
1542     p_heap->i_lbshift = p_fmt->i_lbshift;
1543 }
1544
1545 /**
1546  * This function computes rgb shifts from masks
1547  */
1548 static void PictureHeapFixRgb( picture_heap_t *p_heap )
1549 {
1550     video_format_t fmt;
1551
1552     /* */
1553     fmt.i_chroma = p_heap->i_chroma;
1554     VideoFormatImportRgb( &fmt, p_heap );
1555
1556     /* */
1557     video_format_FixRgb( &fmt );
1558
1559     VideoFormatExportRgb( &fmt, p_heap );
1560 }
1561
1562 /*****************************************************************************
1563  * object variables callbacks: a bunch of object variables are used by the
1564  * interfaces to interact with the vout.
1565  *****************************************************************************/
1566 static int FilterCallback( vlc_object_t *p_this, char const *psz_cmd,
1567                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1568 {
1569     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1570     input_thread_t *p_input;
1571     (void)psz_cmd; (void)oldval; (void)p_data;
1572
1573     p_input = (input_thread_t *)vlc_object_find( p_this, VLC_OBJECT_INPUT,
1574                                                  FIND_PARENT );
1575     if (!p_input)
1576     {
1577         msg_Err( p_vout, "Input not found" );
1578         return VLC_EGENERIC;
1579     }
1580
1581     var_SetBool( p_vout, "intf-change", true );
1582
1583     /* Modify input as well because the vout might have to be restarted */
1584     var_Create( p_input, "vout-filter", VLC_VAR_STRING );
1585     var_SetString( p_input, "vout-filter", newval.psz_string );
1586
1587     /* Now restart current video stream */
1588     input_Control( p_input, INPUT_RESTART_ES, -VIDEO_ES );
1589     vlc_object_release( p_input );
1590
1591     return VLC_SUCCESS;
1592 }
1593
1594 /*****************************************************************************
1595  * Video Filter2 stuff
1596  *****************************************************************************/
1597 static int VideoFilter2Callback( vlc_object_t *p_this, char const *psz_cmd,
1598                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1599 {
1600     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1601     (void)psz_cmd; (void)oldval; (void)p_data;
1602
1603     vlc_mutex_lock( &p_vout->p->vfilter_lock );
1604     p_vout->p->psz_vf2 = strdup( newval.psz_string );
1605     vlc_mutex_unlock( &p_vout->p->vfilter_lock );
1606
1607     return VLC_SUCCESS;
1608 }
1609
1610 /*****************************************************************************
1611  * Post-processing
1612  *****************************************************************************/
1613 static bool PostProcessIsPresent( const char *psz_filter )
1614 {
1615     const char  *psz_pp = "postproc";
1616     const size_t i_pp = strlen(psz_pp);
1617     return psz_filter &&
1618            !strncmp( psz_filter, psz_pp, strlen(psz_pp) ) &&
1619            ( psz_filter[i_pp] == '\0' || psz_filter[i_pp] == ':' );
1620 }
1621
1622 static int PostProcessCallback( vlc_object_t *p_this, char const *psz_cmd,
1623                                 vlc_value_t oldval, vlc_value_t newval, void *p_data )
1624 {
1625     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1626     VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data);
1627
1628     static const char *psz_pp = "postproc";
1629
1630     char *psz_vf2 = var_GetString( p_vout, "video-filter" );
1631
1632     if( newval.i_int <= 0 )
1633     {
1634         if( PostProcessIsPresent( psz_vf2 ) )
1635         {
1636             strcpy( psz_vf2, &psz_vf2[strlen(psz_pp)] );
1637             if( *psz_vf2 == ':' )
1638                 strcpy( psz_vf2, &psz_vf2[1] );
1639         }
1640     }
1641     else
1642     {
1643         if( !PostProcessIsPresent( psz_vf2 ) )
1644         {
1645             if( psz_vf2 )
1646             {
1647                 char *psz_tmp = psz_vf2;
1648                 if( asprintf( &psz_vf2, "%s:%s", psz_pp, psz_tmp ) < 0 )
1649                     psz_vf2 = psz_tmp;
1650                 else
1651                     free( psz_tmp );
1652             }
1653             else
1654             {
1655                 psz_vf2 = strdup( psz_pp );
1656             }
1657         }
1658     }
1659     if( psz_vf2 )
1660     {
1661         var_SetString( p_vout, "video-filter", psz_vf2 );
1662         free( psz_vf2 );
1663     }
1664
1665     return VLC_SUCCESS;
1666 }
1667 static void PostProcessEnable( vout_thread_t *p_vout )
1668 {
1669     vlc_value_t text;
1670     msg_Dbg( p_vout, "Post-processing available" );
1671     var_Create( p_vout, "postprocess", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE );
1672     text.psz_string = _("Post processing");
1673     var_Change( p_vout, "postprocess", VLC_VAR_SETTEXT, &text, NULL );
1674
1675     for( int i = 0; i <= 6; i++ )
1676     {
1677         vlc_value_t val;
1678         vlc_value_t text;
1679         char psz_text[1+1];
1680
1681         val.i_int = i;
1682         snprintf( psz_text, sizeof(psz_text), "%d", i );
1683         if( i == 0 )
1684             text.psz_string = _("Disable");
1685         else
1686             text.psz_string = psz_text;
1687         var_Change( p_vout, "postprocess", VLC_VAR_ADDCHOICE, &val, &text );
1688     }
1689     var_AddCallback( p_vout, "postprocess", PostProcessCallback, NULL );
1690
1691     /* */
1692     char *psz_filter = var_GetNonEmptyString( p_vout, "video-filter" );
1693     int i_postproc_q = 0;
1694     if( PostProcessIsPresent( psz_filter ) )
1695         i_postproc_q = var_CreateGetInteger( p_vout, "postproc-q" );
1696
1697     var_SetInteger( p_vout, "postprocess", i_postproc_q );
1698
1699     free( psz_filter );
1700 }
1701 static void PostProcessDisable( vout_thread_t *p_vout )
1702 {
1703     msg_Dbg( p_vout, "Post-processing no more available" );
1704     var_Destroy( p_vout, "postprocess" );
1705 }
1706 static void PostProcessSetFilterQuality( vout_thread_t *p_vout )
1707 {
1708     vlc_object_t *p_pp = vlc_object_find_name( p_vout, "postproc", FIND_CHILD );
1709     if( !p_pp )
1710         return;
1711
1712     var_SetInteger( p_pp, "postproc-q", var_GetInteger( p_vout, "postprocess" ) );
1713     vlc_object_release( p_pp );
1714 }
1715
1716
1717 static void DisplayTitleOnOSD( vout_thread_t *p_vout )
1718 {
1719     const mtime_t i_start = mdate();
1720     const mtime_t i_stop = i_start + INT64_C(1000) * p_vout->p->i_title_timeout;
1721
1722     if( i_stop <= i_start )
1723         return;
1724
1725     vlc_assert_locked( &p_vout->change_lock );
1726
1727     vout_ShowTextAbsolute( p_vout, DEFAULT_CHAN,
1728                            p_vout->p->psz_title, NULL,
1729                            p_vout->p->i_title_position,
1730                            30 + p_vout->fmt_in.i_width
1731                               - p_vout->fmt_in.i_visible_width
1732                               - p_vout->fmt_in.i_x_offset,
1733                            20 + p_vout->fmt_in.i_y_offset,
1734                            i_start, i_stop );
1735
1736     free( p_vout->p->psz_title );
1737
1738     p_vout->p->psz_title = NULL;
1739 }
1740
1741 /*****************************************************************************
1742  * Deinterlacing
1743  *****************************************************************************/
1744 typedef struct
1745 {
1746     const char *psz_mode;
1747     bool       b_vout_filter;
1748 } deinterlace_mode_t;
1749
1750 /* XXX
1751  * You can use the non vout filter if and only if the video properties stay the
1752  * same (width/height/chroma/fps), at least for now.
1753  */
1754 static const deinterlace_mode_t p_deinterlace_mode[] = {
1755     { "",        false },
1756     //{ "discard", true },
1757     { "blend",   false },
1758     //{ "mean",    true  },
1759     //{ "bob",     true },
1760     //{ "linear",  true },
1761     { "x",       false },
1762     //{ "yadif",   true },
1763     //{ "yadif2x", true },
1764     { NULL,      false }
1765 };
1766 static const deinterlace_mode_t *DeinterlaceGetMode( const char *psz_mode )
1767 {
1768     for( const deinterlace_mode_t *p_mode = &p_deinterlace_mode[0]; p_mode->psz_mode; p_mode++ )
1769     {
1770         if( !strcmp( p_mode->psz_mode, psz_mode ) )
1771             return p_mode;
1772     }
1773     return NULL;
1774 }
1775
1776 static char *FilterFind( char *psz_filter_base, const char *psz_module )
1777 {
1778     const size_t i_module = strlen( psz_module );
1779     const char *psz_filter = psz_filter_base;
1780
1781     if( !psz_filter || i_module <= 0 )
1782         return NULL;
1783
1784     for( ;; )
1785     {
1786         char *psz_find = strstr( psz_filter, psz_module );
1787         if( !psz_find )
1788             return NULL;
1789         if( psz_find[i_module] == '\0' || psz_find[i_module] == ':' )
1790             return psz_find;
1791         psz_filter = &psz_find[i_module];
1792     }
1793 }
1794
1795 static bool DeinterlaceIsPresent( vout_thread_t *p_vout, bool b_vout_filter )
1796 {
1797     char *psz_filter = var_GetNonEmptyString( p_vout, b_vout_filter ? "vout-filter" : "video-filter" );
1798
1799     bool b_found = FilterFind( psz_filter, "deinterlace" ) != NULL;
1800
1801     free( psz_filter );
1802
1803     return b_found;
1804 }
1805
1806 static void DeinterlaceRemove( vout_thread_t *p_vout, bool b_vout_filter )
1807 {
1808     const char *psz_variable = b_vout_filter ? "vout-filter" : "video-filter";
1809     char *psz_filter = var_GetNonEmptyString( p_vout, psz_variable );
1810
1811     char *psz = FilterFind( psz_filter, "deinterlace" );
1812     if( !psz )
1813     {
1814         free( psz_filter );
1815         return;
1816     }
1817
1818     /* */
1819     strcpy( &psz[0], &psz[strlen("deinterlace")] );
1820     if( *psz == ':' )
1821         strcpy( &psz[0], &psz[1] );
1822
1823     var_SetString( p_vout, psz_variable, psz_filter );
1824     free( psz_filter );
1825 }
1826 static void DeinterlaceAdd( vout_thread_t *p_vout, bool b_vout_filter )
1827 {
1828     const char *psz_variable = b_vout_filter ? "vout-filter" : "video-filter";
1829
1830     char *psz_filter = var_GetNonEmptyString( p_vout, psz_variable );
1831
1832     if( FilterFind( psz_filter, "deinterlace" ) )
1833     {
1834         free( psz_filter );
1835         return;
1836     }
1837
1838     /* */
1839     if( psz_filter )
1840     {
1841         char *psz_tmp = psz_filter;
1842         if( asprintf( &psz_filter, "%s:%s", psz_tmp, "deinterlace" ) < 0 )
1843             psz_filter = psz_tmp;
1844         else
1845             free( psz_tmp );
1846     }
1847     else
1848     {
1849         psz_filter = strdup( "deinterlace" );
1850     }
1851
1852     if( psz_filter )
1853     {
1854         var_SetString( p_vout, psz_variable, psz_filter );
1855         free( psz_filter );
1856     }
1857 }
1858
1859 static void DeinterlaceSave( vout_thread_t *p_vout, int i_deinterlace, const char *psz_mode, bool is_needed )
1860 {
1861     /* We have to set input variable to ensure restart support
1862      * XXX it is only needed because of vout-filter but must be done
1863      * for non video filter anyway */
1864     vlc_object_t *p_input = vlc_object_find( p_vout, VLC_OBJECT_INPUT, FIND_PARENT );
1865     if( !p_input )
1866         return;
1867
1868     /* Another hack for "vout filter" mode */
1869     if( i_deinterlace < 0 )
1870         i_deinterlace = is_needed ? -2 : -3;
1871
1872     var_Create( p_input, "deinterlace", VLC_VAR_INTEGER );
1873     var_SetInteger( p_input, "deinterlace", i_deinterlace );
1874
1875     static const char * const ppsz_variable[] = {
1876         "deinterlace-mode",
1877         "filter-deinterlace-mode",
1878         "sout-deinterlace-mode",
1879         NULL
1880     };
1881     for( int i = 0; ppsz_variable[i]; i++ )
1882     {
1883         var_Create( p_input, ppsz_variable[i], VLC_VAR_STRING );
1884         var_SetString( p_input, ppsz_variable[i], psz_mode );
1885     }
1886
1887     vlc_object_release( p_input );
1888 }
1889 static int DeinterlaceCallback( vlc_object_t *p_this, char const *psz_cmd,
1890                                 vlc_value_t oldval, vlc_value_t newval, void *p_data )
1891 {
1892     VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(newval); VLC_UNUSED(p_data);
1893     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1894
1895     /* */
1896     const int  i_deinterlace = var_GetInteger( p_this, "deinterlace" );
1897     char       *psz_mode     = var_GetString( p_this, "deinterlace-mode" );
1898     const bool is_needed     = var_GetBool( p_this, "deinterlace-needed" );
1899     if( !psz_mode )
1900         return VLC_EGENERIC;
1901
1902     DeinterlaceSave( p_vout, i_deinterlace, psz_mode, is_needed );
1903
1904     /* */
1905     bool b_vout_filter = false;
1906     const deinterlace_mode_t *p_mode = DeinterlaceGetMode( psz_mode );
1907     if( p_mode )
1908         b_vout_filter = p_mode->b_vout_filter;
1909
1910     /* */
1911     char *psz_old;
1912     if( b_vout_filter )
1913     {
1914         psz_old = var_CreateGetString( p_vout, "filter-deinterlace-mode" );
1915     }
1916     else
1917     {
1918         psz_old = var_CreateGetString( p_vout, "sout-deinterlace-mode" );
1919         var_SetString( p_vout, "sout-deinterlace-mode", psz_mode );
1920     }
1921
1922     msg_Dbg( p_vout, "deinterlace %d, mode %s, is_needed %d", i_deinterlace, psz_mode, is_needed );
1923     if( i_deinterlace == 0 || ( i_deinterlace == -1 && !is_needed ) )
1924     {
1925         DeinterlaceRemove( p_vout, false );
1926         DeinterlaceRemove( p_vout, true );
1927     }
1928     else
1929     {
1930         if( !DeinterlaceIsPresent( p_vout, b_vout_filter ) )
1931         {
1932             DeinterlaceRemove( p_vout, !b_vout_filter );
1933             DeinterlaceAdd( p_vout, b_vout_filter );
1934         }
1935         else
1936         {
1937             /* The deinterlace filter was already inserted but we have changed the mode */
1938             DeinterlaceRemove( p_vout, !b_vout_filter );
1939             if( psz_old && strcmp( psz_old, psz_mode ) )
1940                 var_TriggerCallback( p_vout, b_vout_filter ? "vout-filter" : "video-filter" );
1941         }
1942     }
1943
1944     /* */
1945     free( psz_old );
1946     free( psz_mode );
1947     return VLC_SUCCESS;
1948 }
1949
1950 static void DeinterlaceEnable( vout_thread_t *p_vout )
1951 {
1952     vlc_value_t val, text;
1953
1954     if( !p_vout->p->b_first_vout )
1955         return;
1956
1957     msg_Dbg( p_vout, "Deinterlacing available" );
1958
1959     /* Create the configuration variables */
1960     /* */
1961     var_Create( p_vout, "deinterlace", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT | VLC_VAR_HASCHOICE );
1962     int i_deinterlace = var_GetInteger( p_vout, "deinterlace" );
1963
1964     text.psz_string = _("Deinterlace");
1965     var_Change( p_vout, "deinterlace", VLC_VAR_SETTEXT, &text, NULL );
1966
1967     const module_config_t *p_optd = config_FindConfig( VLC_OBJECT(p_vout), "deinterlace" );
1968     var_Change( p_vout, "deinterlace", VLC_VAR_CLEARCHOICES, NULL, NULL );
1969     for( int i = 0; p_optd && i < p_optd->i_list; i++ )
1970     {
1971         val.i_int  = p_optd->pi_list[i];
1972         text.psz_string = (char*)vlc_gettext(p_optd->ppsz_list_text[i]);
1973         var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
1974     }
1975     var_AddCallback( p_vout, "deinterlace", DeinterlaceCallback, NULL );
1976     /* */
1977     var_Create( p_vout, "deinterlace-mode", VLC_VAR_STRING | VLC_VAR_DOINHERIT | VLC_VAR_HASCHOICE );
1978     char *psz_deinterlace = var_GetNonEmptyString( p_vout, "deinterlace-mode" );
1979
1980     text.psz_string = _("Deinterlace mode");
1981     var_Change( p_vout, "deinterlace-mode", VLC_VAR_SETTEXT, &text, NULL );
1982
1983     const module_config_t *p_optm = config_FindConfig( VLC_OBJECT(p_vout), "deinterlace-mode" );
1984     var_Change( p_vout, "deinterlace-mode", VLC_VAR_CLEARCHOICES, NULL, NULL );
1985     for( int i = 0; p_optm && i < p_optm->i_list; i++ )
1986     {
1987         if( !DeinterlaceGetMode( p_optm->ppsz_list[i] ) )
1988             continue;
1989
1990         val.psz_string  = p_optm->ppsz_list[i];
1991         text.psz_string = (char*)vlc_gettext(p_optm->ppsz_list_text[i]);
1992         var_Change( p_vout, "deinterlace-mode", VLC_VAR_ADDCHOICE, &val, &text );
1993     }
1994     var_AddCallback( p_vout, "deinterlace-mode", DeinterlaceCallback, NULL );
1995     /* */
1996     var_Create( p_vout, "deinterlace-needed", VLC_VAR_BOOL );
1997     var_AddCallback( p_vout, "deinterlace-needed", DeinterlaceCallback, NULL );
1998
1999     /* Override the initial value from filters if present */
2000     char *psz_filter_mode = NULL;
2001     if( DeinterlaceIsPresent( p_vout, true ) )
2002         psz_filter_mode = var_CreateGetNonEmptyString( p_vout, "filter-deinterlace-mode" );
2003     else if( DeinterlaceIsPresent( p_vout, false ) )
2004         psz_filter_mode = var_CreateGetNonEmptyString( p_vout, "sout-deinterlace-mode" );
2005     if( psz_filter_mode )
2006     {
2007         free( psz_deinterlace );
2008         if( i_deinterlace >= -1 )
2009             i_deinterlace = 1;
2010         psz_deinterlace = psz_filter_mode;
2011     }
2012
2013     /* */
2014     if( i_deinterlace == -2 )
2015         p_vout->p->b_picture_interlaced = true;
2016     else if( i_deinterlace == -3 )
2017         p_vout->p->b_picture_interlaced = false;
2018     if( i_deinterlace < 0 )
2019         i_deinterlace = -1;
2020
2021     /* */
2022     val.psz_string = psz_deinterlace ? psz_deinterlace : p_optm->orig.psz;
2023     var_Change( p_vout, "deinterlace-mode", VLC_VAR_SETVALUE, &val, NULL );
2024     val.b_bool = p_vout->p->b_picture_interlaced;
2025     var_Change( p_vout, "deinterlace-needed", VLC_VAR_SETVALUE, &val, NULL );
2026
2027     var_SetInteger( p_vout, "deinterlace", i_deinterlace );
2028     free( psz_deinterlace );
2029 }
2030
2031 static void DeinterlaceNeeded( vout_thread_t *p_vout, bool is_interlaced )
2032 {
2033     msg_Dbg( p_vout, "Detected %s video",
2034              is_interlaced ? "interlaced" : "progressive" );
2035     var_SetBool( p_vout, "deinterlace-needed", is_interlaced );
2036 }
2037