- if(args) {
- if(sscanf(args, "%d:%d", &aspect->aspect.num, &aspect->aspect.den) < 2) {
- if(sscanf(args, "%lf", &ratio) < 1)
- return -1;
- aspect->aspect = av_d2q(ratio, 100);
- } else {
- gcd = av_gcd(FFABS(aspect->aspect.num), FFABS(aspect->aspect.den));
- if(gcd) {
- aspect->aspect.num /= gcd;
- aspect->aspect.den /= gcd;
- }
+ if (args) {
+ if (sscanf(args, "%d:%d%c", &aspect->aspect.num, &aspect->aspect.den, &c) != 2)
+ if (sscanf(args, "%lf%c", &ratio, &c) == 1)
+ aspect->aspect = av_d2q(ratio, 100);
+
+ if (c || aspect->aspect.num <= 0 || aspect->aspect.den <= 0) {
+ av_log(ctx, AV_LOG_ERROR,
+ "Invalid string '%s' for aspect ratio.\n", args);
+ return AVERROR(EINVAL);
+ }
+
+ gcd = av_gcd(FFABS(aspect->aspect.num), FFABS(aspect->aspect.den));
+ if (gcd) {
+ aspect->aspect.num /= gcd;
+ aspect->aspect.den /= gcd;