#include <stdio.h>
#include <stdlib.h>
#include <stdbool.h>
+#include <string.h>
#include <locale.h>
#include <signal.h>
-#include <pthread.h>
+#ifdef HAVE_PTHREAD_H
+# include <pthread.h>
+#endif
#include <unistd.h>
-#ifdef __APPLE__
-#include <string.h>
+#ifdef __OS2__
+# define pthread_t int
+# define pthread_self() _gettid()
#endif
-/* Explicit HACK */
-extern void LocaleFree (const char *);
-extern char *FromLocale (const char *);
extern void vlc_enable_override (void);
-#ifdef HAVE_MAEMO
-static void dummy_handler (int signum)
-{
- (void) signum;
-}
-#endif
-
static bool signal_ignored (int signum)
{
struct sigaction sa;
static void vlc_kill (void *data)
{
+#ifndef __OS2__
pthread_t *ps = data;
pthread_kill (*ps, SIGTERM);
+#else
+ // send a signal to the main thread
+ kill (getpid(), SIGTERM);
+#endif
}
static void exit_timeout (int signum)
/* Restore SIGCHLD in case our parent process ignores it. */
signal (SIGCHLD, SIG_DFL);
-#ifdef HAVE_SETENV
-# ifndef NDEBUG
+#ifndef NDEBUG
/* Activate malloc checking routines to detect heap corruptions. */
setenv ("MALLOC_CHECK_", "2", 1);
/* Disable the ugly Gnome crash dialog so that we properly segfault */
setenv ("GNOME_DISABLE_CRASH_DIALOG", "1", 1);
-# endif
+#endif
+
+#ifdef TOP_BUILDDIR
+ setenv ("VLC_PLUGIN_PATH", TOP_BUILDDIR"/modules", 1);
+ setenv ("VLC_DATA_PATH", TOP_SRCDIR"/share", 1);
+#endif
/* Clear the X.Org startup notification ID. Otherwise the UI might try to
* change the environment while the process is multi-threaded. That could
* crash. Screw you X.Org. Next time write a thread-safe specification. */
unsetenv ("DESKTOP_STARTUP_ID");
-#endif
#ifndef ALLOW_RUN_AS_ROOT
if (geteuid () == 0)
setlocale (LC_ALL, "");
-#ifndef __APPLE__
- /* This clutters OSX GUI error logs */
- fprintf( stderr, "VLC media player %s (revision %s)\n",
- libvlc_get_version(), libvlc_get_changeset() );
-#endif
+ if (isatty (STDERR_FILENO))
+ /* This message clutters error logs. It is printed only on a TTY.
+ * Fortunately, LibVLC prints version info with -vv anyway. */
+ fprintf (stderr, "VLC media player %s (revision %s)\n",
+ libvlc_get_version(), libvlc_get_changeset());
sigset_t set;
sigaddset (&set, SIGPIPE);
/* SIGCHLD must be dequeued to clean up zombie child processes.
- * Furthermore the handler must not be set to SIG_IGN (see above). */
- /* Unfortunately, the QProcess class from Qt4 has a bug. It installs a
- * custom signal handlers and gets stuck if it is not called. So we cannot
- * use sigwait() for SIGCHLD:
- * http://bugs.kde.org/show_bug.cgi?id=260719 */
- //sigaddset (&set, SIGCHLD);
-
-#ifdef HAVE_MAEMO
- sigaddset (&set, SIGRTMIN);
- {
- struct sigaction act = { .sa_handler = dummy_handler, };
- sigaction (SIGRTMIN, &act, NULL);
- }
-#endif
+ * Furthermore the handler must not be set to SIG_IGN (see above).
+ * We cannot pragmatically handle EINTR, short reads and short writes
+ * in every code paths (including underlying libraries). So we just
+ * block SIGCHLD in all threads, and dequeue it below. */
+ sigaddset (&set, SIGCHLD);
+
/* Block all these signals */
- pthread_sigmask (SIG_BLOCK, &set, NULL);
+ pthread_sigmask (SIG_SETMASK, &set, NULL);
- /* Note that FromLocale() can be used before libvlc is initialized */
- const char *argv[i_argc + 4];
+ const char *argv[i_argc + 2];
int argc = 0;
argv[argc++] = "--no-ignore-config";
argv[argc++] = "--media-library";
-#ifdef TOP_BUILDDIR
- argv[argc++] = FromLocale ("--plugin-path="TOP_BUILDDIR"/modules");
-#endif
-#ifdef TOP_SRCDIR
- argv[argc++] = FromLocale ("--data-path="TOP_SRCDIR"/share");
-#endif
-
- int i = 1;
+ ppsz_argv++; i_argc--; /* skip executable path */
#ifdef __APPLE__
/* When VLC.app is run by double clicking in Mac OS X, the 2nd arg
* is the PSN - process serial number (a unique PID-ish thingie)
* still ok for real Darwin & when run from command line
* for example -psn_0_9306113 */
- if(i_argc >= 2 && !strncmp( ppsz_argv[1] , "-psn" , 4 ))
- i = 2;
+ if (i_argc >= 1 && !strncmp (*ppsz_argv, "-psn" , 4))
+ ppsz_argv++, i_argc--;
#endif
- for (; i < i_argc; i++)
- if ((argv[argc++] = FromLocale (ppsz_argv[i])) == NULL)
- return 1; // BOOM!
+ memcpy (argv + argc, ppsz_argv, i_argc * sizeof (*argv));
+ argc += i_argc;
argv[argc] = NULL;
vlc_enable_override ();
libvlc_set_user_agent (vlc, "VLC media player", "VLC/"PACKAGE_VERSION);
-#if !defined (HAVE_MAEMO) && !defined __APPLE__
+#if !defined (HAVE_MAEMO) && !defined __APPLE__ && !defined (__OS2__)
libvlc_add_intf (vlc, "globalhotkeys,none");
+#endif
+#ifdef HAVE_DBUS
+ libvlc_add_intf (vlc, "dbus,none");
+ libvlc_add_intf (vlc, "inhibit,none");
#endif
if (libvlc_add_intf (vlc, NULL))
goto out;
pthread_t self = pthread_self ();
libvlc_set_exit_handler (vlc, vlc_kill, &self);
- if (signal_ignored (SIGHUP)) /* <- needed to handle nohup properly */
+ /* Qt4 insists on catching SIGCHLD via signal handler. To work around that,
+ * unblock it after all our child threads are created. */
+ sigdelset (&set, SIGCHLD);
+ pthread_sigmask (SIG_SETMASK, &set, NULL);
+
+ /* Do not dequeue SIGHUP if it is ignored (nohup) */
+ if (signal_ignored (SIGHUP))
sigdelset (&set, SIGHUP);
+ /* Ignore SIGPIPE */
sigdelset (&set, SIGPIPE);
int signum;
- do
- sigwait (&set, &signum);
- while (signum == SIGCHLD);
+ sigwait (&set, &signum);
/* Restore default signal behaviour after 3 seconds */
sigemptyset (&set);
out:
if (vlc != NULL)
libvlc_release (vlc);
- for (int i = 1; i < argc; i++)
- LocaleFree (argv[i]);
return 0;
}