linux shim: Fix dropped O_DIRECT flag

[bcachefs-tools-debian] / cmd_fsck.c

diff --git a/cmd_fsck.c b/cmd_fsck.c
index e0961b99694c3e71765f97191c6fc1235cb9b7df..54ace957050c3e445abf50359c684cec6901755c 100644 (file)
--- a/cmd_fsck.c
+++ b/cmd_fsck.c
@@ -1,4 +1,5 @@
 
+#include <getopt.h>
 #include "cmds.h"
 #include "libbcachefs/error.h"
 #include "libbcachefs.h"
@@ -11,25 +12,36 @@ static void usage(void)
             "Usage: bcachefs fsck [OPTION]... <devices>\n"
             "\n"
             "Options:\n"
-            "  -p     Automatic repair (no questions)\n"
-            "  -n     Don't repair, only check for errors\n"
-            "  -y     Assume \"yes\" to all questions\n"
-            "  -f     Force checking even if filesystem is marked clean\n"
-            "  -v     Be verbose\n"
-            " --h     Display this help and exit\n"
-            "Report bugs to <linux-bcache@vger.kernel.org>");
+            "  -p                      Automatic repair (no questions)\n"
+            "  -n                      Don't repair, only check for errors\n"
+            "  -y                      Assume \"yes\" to all questions\n"
+            "  -f                      Force checking even if filesystem is marked clean\n"
+            "  -r, --ratelimit_errors  Don't display more than 10 errors of a given type\n"
+            "  -R, --reconstruct_alloc Reconstruct the alloc btree\n"
+            "  -v                      Be verbose\n"
+            "  -h, --help              Display this help and exit\n"
+            "Report bugs to <linux-bcachefs@vger.kernel.org>");
 }
 
 int cmd_fsck(int argc, char *argv[])
 {
+       static const struct option longopts[] = {
+               { "ratelimit_errors",   no_argument,            NULL, 'r' },
+               { "reconstruct_alloc",  no_argument,            NULL, 'R' },
+               { "help",               no_argument,            NULL, 'h' },
+               { NULL }
+       };
        struct bch_opts opts = bch2_opts_empty();
        unsigned i;
        int opt, ret = 0;
 
        opt_set(opts, degraded, true);
+       opt_set(opts, fsck, true);
        opt_set(opts, fix_errors, FSCK_OPT_ASK);
 
-       while ((opt = getopt(argc, argv, "apynfvh")) != -1)
+       while ((opt = getopt_long(argc, argv,
+                                 "apynfo:rvh",
+                                 longopts, NULL)) != -1)
                switch (opt) {
                case 'a': /* outdated alias for -p */
                case 'p':
@@ -45,30 +57,56 @@ int cmd_fsck(int argc, char *argv[])
                case 'f':
                        /* force check, even if filesystem marked clean: */
                        break;
+               case 'o':
+                       ret = bch2_parse_mount_opts(NULL, &opts, optarg);
+                       if (ret)
+                               return ret;
+                       break;
+               case 'r':
+                       opt_set(opts, ratelimit_errors, true);
+                       break;
+               case 'R':
+                       opt_set(opts, reconstruct_alloc, true);
+                       break;
                case 'v':
                        opt_set(opts, verbose, true);
                        break;
                case 'h':
                        usage();
-                       exit(EXIT_SUCCESS);
+                       exit(16);
                }
        args_shift(optind);
 
-       if (!argc)
-               die("Please supply device(s) to check");
+       if (!argc) {
+               fprintf(stderr, "Please supply device(s) to check\n");
+               exit(8);
+       }
 
-       for (i = 0; i < argc; i++)
-               if (dev_mounted_rw(argv[i]))
-                       die("%s is mounted read-write - aborting", argv[i]);
+       for (i = 0; i < argc; i++) {
+               switch (dev_mounted(argv[i])) {
+               case 1:
+                       ret |= 2;
+                       break;
+               case 2:
+                       fprintf(stderr, "%s is mounted read-write - aborting\n", argv[i]);
+                       exit(8);
+               }
+       }
 
        struct bch_fs *c = bch2_fs_open(argv, argc, opts);
-       if (IS_ERR(c))
-               die("error opening %s: %s", argv[0], strerror(-PTR_ERR(c)));
+       if (IS_ERR(c)) {
+               fprintf(stderr, "error opening %s: %s\n", argv[0], bch2_err_str(PTR_ERR(c)));
+               exit(8);
+       }
 
-       if (test_bit(BCH_FS_FSCK_FIXED_ERRORS, &c->flags))
-               ret = 2;
-       if (test_bit(BCH_FS_FSCK_UNFIXED_ERRORS, &c->flags))
-               ret = 4;
+       if (test_bit(BCH_FS_ERRORS_FIXED, &c->flags)) {
+               fprintf(stderr, "%s: errors fixed\n", c->name);
+               ret |= 1;
+       }
+       if (test_bit(BCH_FS_ERROR, &c->flags)) {
+               fprintf(stderr, "%s: still has errors\n", c->name);
+               ret |= 4;
+       }
 
        bch2_fs_stop(c);
        return ret;