2.1.0: Make auto-play-delta a boost::optional instead of magic number int.

[casparcg] / core / producer / layer.cpp

diff --git a/core/producer/layer.cpp b/core/producer/layer.cpp
index 27732d69e2af10c1a24591d6e309e2c015443679..c2fa8a69a611a11196da9297dcc1ebdb8339d8b2 100644 (file)
--- a/core/producer/layer.cpp
+++ b/core/producer/layer.cpp
@@ -27,24 +27,24 @@
 #include "frame/basic_frame.h"\r
 #include "frame/frame_transform.h"\r
 \r
+#include <boost/optional.hpp>\r
 #include <boost/property_tree/ptree.hpp>\r
 \r
 namespace caspar { namespace core {\r
 \r
-struct layer::implementation\r
+struct layer::impl\r
 {                              \r
        safe_ptr<frame_producer>        foreground_;\r
        safe_ptr<frame_producer>        background_;\r
        int64_t                                         frame_number_;\r
-       int32_t                                         auto_play_delta_;\r
+       boost::optional<int32_t>        auto_play_delta_;\r
        bool                                            is_paused_;\r
 \r
 public:\r
-       implementation() \r
+       impl() \r
                : foreground_(frame_producer::empty())\r
                , background_(frame_producer::empty())\r
                , frame_number_(0)\r
-               , auto_play_delta_(-1)\r
                , is_paused_(false)\r
        {\r
        }\r
@@ -59,12 +59,12 @@ public:
                is_paused_ = false;\r
        }\r
 \r
-       void load(const safe_ptr<frame_producer>& producer, bool preview, int auto_play_delta)\r
+       void load(const safe_ptr<frame_producer>& producer, bool preview, const boost::optional<int32_t>& auto_play_delta)\r
        {               \r
                background_              = producer;\r
                auto_play_delta_ = auto_play_delta;\r
 \r
-               if(auto_play_delta_ > -1 && foreground_ == frame_producer::empty())\r
+               if(auto_play_delta_ && foreground_ == frame_producer::empty())\r
                        play();\r
 \r
                if(preview) // Play the first frame and pause.\r
@@ -84,7 +84,7 @@ public:
                        foreground_                     = background_;\r
                        background_                     = frame_producer::empty();\r
                        frame_number_           = 0;\r
-                       auto_play_delta_        = -1;   \r
+                       auto_play_delta_        = nullptr;      \r
                }\r
 \r
                is_paused_                      = false;\r
@@ -95,7 +95,7 @@ public:
                foreground_                     = frame_producer::empty();\r
                background_                     = background_;\r
                frame_number_           = 0;\r
-               auto_play_delta_        = -1;\r
+               auto_play_delta_        = nullptr;      \r
 \r
                is_paused_                      = true;\r
        }\r
@@ -111,11 +111,14 @@ public:
                        if(frame == core::basic_frame::late())\r
                                return disable_audio(foreground_->last_frame());\r
 \r
-                       auto frames_left = static_cast<int64_t>(foreground_->nb_frames()) - static_cast<int64_t>(++frame_number_) - static_cast<int64_t>(auto_play_delta_);\r
-                       if(auto_play_delta_ > -1 && frames_left < 1)\r
+                       if(auto_play_delta_)\r
                        {\r
-                               play();\r
-                               return receive(flags);\r
+                               auto frames_left = static_cast<int64_t>(foreground_->nb_frames()) - static_cast<int64_t>(++frame_number_) - static_cast<int64_t>(*auto_play_delta_);\r
+                               if(frames_left < 1)\r
+                               {\r
+                                       play();\r
+                                       return receive(flags);\r
+                               }\r
                        }\r
                                \r
                        return frame;\r
@@ -155,14 +158,14 @@ public:
        }\r
 };\r
 \r
-layer::layer() : impl_(new implementation()){}\r
+layer::layer() : impl_(new impl()){}\r
 layer::layer(layer&& other) : impl_(std::move(other.impl_)){}\r
 layer& layer::operator=(layer&& other)\r
 {\r
        impl_ = std::move(other.impl_);\r
        return *this;\r
 }\r
-layer::layer(const layer& other) : impl_(new implementation(*other.impl_)){}\r
+layer::layer(const layer& other) : impl_(new impl(*other.impl_)){}\r
 layer& layer::operator=(const layer& other)\r
 {\r
        layer temp(other);\r
@@ -173,7 +176,7 @@ void layer::swap(layer& other)
 {      \r
        impl_.swap(other.impl_);\r
 }\r
-void layer::load(const safe_ptr<frame_producer>& frame_producer, bool preview, int auto_play_delta){return impl_->load(frame_producer, preview, auto_play_delta);}     \r
+void layer::load(const safe_ptr<frame_producer>& frame_producer, bool preview, const boost::optional<int32_t>& auto_play_delta){return impl_->load(frame_producer, preview, auto_play_delta);} \r
 void layer::play(){impl_->play();}\r
 void layer::pause(){impl_->pause();}\r
 void layer::stop(){impl_->stop();}\r