#include "internal.h"
#include "aandcttab.h"
+#define CBP_VLC_BITS 9
+
typedef struct MV30Context {
GetBitContext gb;
}
}
-static inline void idct_1d(int *blk, int step)
+static inline void idct_1d(unsigned *blk, int step)
{
- const int t0 = blk[0 * step] + blk[4 * step];
- const int t1 = blk[0 * step] - blk[4 * step];
- const int t2 = blk[2 * step] + blk[6 * step];
- const int t3 = (((blk[2 * step] - blk[6 * step]) * 362) >> 8) - t2;
- const int t4 = t0 + t2;
- const int t5 = t0 - t2;
- const int t6 = t1 + t3;
- const int t7 = t1 - t3;
- const int t8 = blk[5 * step] + blk[3 * step];
- const int t9 = blk[5 * step] - blk[3 * step];
- const int tA = blk[1 * step] + blk[7 * step];
- const int tB = blk[1 * step] - blk[7 * step];
- const int tC = t8 + tA;
- const int tD = (tB + t9) * 473 >> 8;
- const int tE = ((t9 * -669 >> 8) - tC) + tD;
- const int tF = ((tA - t8) * 362 >> 8) - tE;
- const int t10 = ((tB * 277 >> 8) - tD) + tF;
+ const unsigned t0 = blk[0 * step] + blk[4 * step];
+ const unsigned t1 = blk[0 * step] - blk[4 * step];
+ const unsigned t2 = blk[2 * step] + blk[6 * step];
+ const unsigned t3 = ((int)((blk[2 * step] - blk[6 * step]) * 362U) >> 8) - t2;
+ const unsigned t4 = t0 + t2;
+ const unsigned t5 = t0 - t2;
+ const unsigned t6 = t1 + t3;
+ const unsigned t7 = t1 - t3;
+ const unsigned t8 = blk[5 * step] + blk[3 * step];
+ const unsigned t9 = blk[5 * step] - blk[3 * step];
+ const unsigned tA = blk[1 * step] + blk[7 * step];
+ const unsigned tB = blk[1 * step] - blk[7 * step];
+ const unsigned tC = t8 + tA;
+ const unsigned tD = (int)((tB + t9) * 473U) >> 8;
+ const unsigned tE = (((int)(t9 * -669U) >> 8) - tC) + tD;
+ const unsigned tF = ((int)((tA - t8) * 362U) >> 8) - tE;
+ const unsigned t10 = (((int)(tB * 277U) >> 8) - tD) + tF;
blk[0 * step] = t4 + tC;
blk[1 * step] = t6 + tE;
static inline void idct2_1d(int *blk, int step)
{
- const int t0 = blk[0 * step];
- const int t1 = blk[1 * step];
- const int t2 = t1 * 473 >> 8;
- const int t3 = t2 - t1;
- const int t4 = (t1 * 362 >> 8) - t3;
- const int t5 = ((t1 * 277 >> 8) - t2) + t4;
+ const unsigned int t0 = blk[0 * step];
+ const unsigned int t1 = blk[1 * step];
+ const unsigned int t2 = (int)(t1 * 473U) >> 8;
+ const unsigned int t3 = t2 - t1;
+ const unsigned int t4 = ((int)(t1 * 362U) >> 8) - t3;
+ const unsigned int t5 = (((int)(t1 * 277U) >> 8) - t2) + t4;
blk[0 * step] = t1 + t0;
blk[1 * step] = t0 + t3;
case 1:
fill = sign_extend(bytestream2_get_ne16(gbyte), 16);
pfill[0] += fill;
- block[0] = ((pfill[0] * qtab[0]) >> 5) + 128;
+ block[0] = ((int)((unsigned)pfill[0] * qtab[0]) >> 5) + 128;
s->bdsp.fill_block_tab[1](dst, block[0], linesize, 8);
break;
case 2:
memset(block, 0, sizeof(*block) * 64);
fill = sign_extend(bytestream2_get_ne16(gbyte), 16);
pfill[0] += fill;
- block[0] = pfill[0] * qtab[0];
+ block[0] = (unsigned)pfill[0] * qtab[0];
block[1] = sign_extend(bytestream2_get_ne16(gbyte), 16) * qtab[1];
block[8] = sign_extend(bytestream2_get_ne16(gbyte), 16) * qtab[8];
block[9] = sign_extend(bytestream2_get_ne16(gbyte), 16) * qtab[9];
case 3:
fill = sign_extend(bytestream2_get_ne16(gbyte), 16);
pfill[0] += fill;
- block[0] = pfill[0] * qtab[0];
+ block[0] = (unsigned)pfill[0] * qtab[0];
for (int i = 1; i < 64; i++)
block[zigzag[i]] = sign_extend(bytestream2_get_ne16(gbyte), 16) * qtab[zigzag[i]];
idct_put(dst, linesize, block);
case 1:
fill = sign_extend(bytestream2_get_ne16(gbyte), 16);
pfill[0] += fill;
- block[0] = (pfill[0] * qtab[0]) >> 5;
+ block[0] = (int)((unsigned)pfill[0] * qtab[0]) >> 5;
update_inter_block(dst, linesize, src, in_linesize, block[0]);
break;
case 2:
memset(block, 0, sizeof(*block) * 64);
fill = sign_extend(bytestream2_get_ne16(gbyte), 16);
pfill[0] += fill;
- block[0] = pfill[0] * qtab[0];
+ block[0] = (unsigned)pfill[0] * qtab[0];
block[1] = sign_extend(bytestream2_get_ne16(gbyte), 16) * qtab[1];
block[8] = sign_extend(bytestream2_get_ne16(gbyte), 16) * qtab[8];
block[9] = sign_extend(bytestream2_get_ne16(gbyte), 16) * qtab[9];
case 3:
fill = sign_extend(bytestream2_get_ne16(gbyte), 16);
pfill[0] += fill;
- block[0] = pfill[0] * qtab[0];
+ block[0] = (unsigned)pfill[0] * qtab[0];
for (int i = 1; i < 64; i++)
block[zigzag[i]] = sign_extend(bytestream2_get_ne16(gbyte), 16) * qtab[zigzag[i]];
idct_add(dst, linesize, src, in_linesize, block);
memset(coeffs, 0, nb_codes * sizeof(*coeffs));
for (int i = 0; i < nb_codes;) {
- int value = get_vlc2(gb, cbp_tab.table, cbp_tab.bits, 1);
-
- if (value < 0)
- return AVERROR_INVALIDDATA;
+ int value = get_vlc2(gb, cbp_tab.table, CBP_VLC_BITS, 1);
if (value > 0) {
int x = get_bits(gb, value);
int ret;
mgb = *gb;
+ if (get_bits_left(gb) < s->mode_size * 8)
+ return AVERROR_INVALIDDATA;
+
skip_bits_long(gb, s->mode_size * 8);
linesize[0] = frame->linesize[0];
for (int x = 0; x < avctx->width; x += 16) {
if (cnt >= 4)
cnt = 0;
- if (cnt == 0)
+ if (cnt == 0) {
+ if (get_bits_left(&mask) < 8) {
+ ret = AVERROR_INVALIDDATA;
+ goto fail;
+ }
flags = get_bits(&mask, 8);
+ }
dst[0] = frame->data[0] + linesize[0] * y + x;
dst[1] = frame->data[0] + linesize[0] * y + x + 8;
int px = x + mv_x;
int py = y + mv_y;
- if (px < 0 || px >= avctx->width ||
- py < 0 || py >= avctx->height)
+ if (px < 0 || px > FFALIGN(avctx->width , 16) - 16 ||
+ py < 0 || py > FFALIGN(avctx->height, 16) - 16)
return AVERROR_INVALIDDATA;
src[0] = prev->data[0] + in_linesize[0] * py + px;
return avpkt->size;
}
-static const uint16_t cbp_codes[] = {
- 0, 1, 4, 5, 6, 0xE, 0x1E, 0x3E, 0x7E, 0xFE, 0x1FE, 0x1FF,
-};
-
static const uint8_t cbp_bits[] = {
2, 2, 3, 3, 3, 4, 5, 6, 7, 8, 9, 9,
};
static av_cold void init_static_data(void)
{
- INIT_VLC_SPARSE_STATIC(&cbp_tab, 9, FF_ARRAY_ELEMS(cbp_bits),
- cbp_bits, 1, 1, cbp_codes, 2, 2, NULL, 0, 0, 512);
+ INIT_VLC_STATIC_FROM_LENGTHS(&cbp_tab, CBP_VLC_BITS, FF_ARRAY_ELEMS(cbp_bits),
+ cbp_bits, 1, NULL, 0, 0, 0, 0, 1 << CBP_VLC_BITS);
}
static av_cold int decode_init(AVCodecContext *avctx)
return 0;
}
-AVCodec ff_mv30_decoder = {
+const AVCodec ff_mv30_decoder = {
.name = "mv30",
.long_name = NULL_IF_CONFIG_SMALL("MidiVid 3.0"),
.type = AVMEDIA_TYPE_VIDEO,
projects / ffmpeg / blobdiff