]> git.sesse.net Git - ffmpeg/blobdiff - libavcodec/qcelpdec.c
dashenc: Simplify code by using a local variable
[ffmpeg] / libavcodec / qcelpdec.c
index 4394ec472db63416cf707f7c34c3ae88a2eaa873..d4a82ee9010de51d6ddfaf4f554e789013c4dbf2 100644 (file)
@@ -2,20 +2,20 @@
  * QCELP decoder
  * Copyright (c) 2007 Reynaldo H. Verdejo Pinochet
  *
- * This file is part of FFmpeg.
+ * This file is part of Libav.
  *
- * FFmpeg is free software; you can redistribute it and/or
+ * Libav is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
  * version 2.1 of the License, or (at your option) any later version.
  *
- * FFmpeg is distributed in the hope that it will be useful,
+ * Libav is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Lesser General Public License for more details.
  *
  * You should have received a copy of the GNU Lesser General Public
- * License along with FFmpeg; if not, write to the Free Software
+ * License along with Libav; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
  * @file
  * QCELP decoder
  * @author Reynaldo H. Verdejo Pinochet
- * @remark FFmpeg merging spearheaded by Kenan Gillet
+ * @remark Libav merging spearheaded by Kenan Gillet
  * @remark Development mentored by Benjamin Larson
  */
 
 #include <stddef.h>
 
+#include "libavutil/channel_layout.h"
+#include "libavutil/float_dsp.h"
 #include "avcodec.h"
 #include "internal.h"
 #include "get_bits.h"
-
 #include "qcelpdata.h"
-
-#include "celp_math.h"
 #include "celp_filters.h"
 #include "acelp_filters.h"
 #include "acelp_vectors.h"
@@ -44,9 +43,8 @@
 #undef NDEBUG
 #include <assert.h>
 
-typedef enum
-{
-    I_F_Q = -1,    /*!< insufficient frame quality */
+typedef enum {
+    I_F_Q = -1,    /**< insufficient frame quality */
     SILENCE,
     RATE_OCTAVE,
     RATE_QUARTER,
@@ -54,16 +52,15 @@ typedef enum
     RATE_FULL
 } qcelp_packet_rate;
 
-typedef struct
-{
+typedef struct QCELPContext {
     GetBitContext     gb;
     qcelp_packet_rate bitrate;
-    QCELPFrame        frame;    /*!< unpacked data frame */
+    QCELPFrame        frame;    /**< unpacked data frame */
 
     uint8_t  erasure_count;
-    uint8_t  octave_count;      /*!< count the consecutive RATE_OCTAVE frames */
+    uint8_t  octave_count;      /**< count the consecutive RATE_OCTAVE frames */
     float    prev_lspf[10];
-    float    predictor_lspf[10];/*!< LSP predictor for RATE_OCTAVE and I_F_Q */
+    float    predictor_lspf[10];/**< LSP predictor for RATE_OCTAVE and I_F_Q */
     float    pitch_synthesis_filter_mem[303];
     float    pitch_pre_filter_mem[303];
     float    rnd_fir_filter_mem[180];
@@ -92,10 +89,12 @@ static av_cold int qcelp_decode_init(AVCodecContext *avctx)
     QCELPContext *q = avctx->priv_data;
     int i;
 
-    avctx->sample_fmt = SAMPLE_FMT_FLT;
+    avctx->channels       = 1;
+    avctx->channel_layout = AV_CH_LAYOUT_MONO;
+    avctx->sample_fmt     = AV_SAMPLE_FMT_FLT;
 
-    for(i=0; i<10; i++)
-        q->prev_lspf[i] = (i+1)/11.;
+    for (i = 0; i < 10; i++)
+        q->prev_lspf[i] = (i + 1) / 11.0;
 
     return 0;
 }
@@ -117,79 +116,70 @@ static int decode_lspf(QCELPContext *q, float *lspf)
     float tmp_lspf, smooth, erasure_coeff;
     const float *predictors;
 
-    if(q->bitrate == RATE_OCTAVE || q->bitrate == I_F_Q)
-    {
-        predictors = (q->prev_bitrate != RATE_OCTAVE &&
-                       q->prev_bitrate != I_F_Q ?
-                       q->prev_lspf : q->predictor_lspf);
+    if (q->bitrate == RATE_OCTAVE || q->bitrate == I_F_Q) {
+        predictors = q->prev_bitrate != RATE_OCTAVE &&
+                     q->prev_bitrate != I_F_Q ? q->prev_lspf
+                                              : q->predictor_lspf;
 
-        if(q->bitrate == RATE_OCTAVE)
-        {
+        if (q->bitrate == RATE_OCTAVE) {
             q->octave_count++;
 
-            for(i=0; i<10; i++)
-            {
+            for (i = 0; i < 10; i++) {
                 q->predictor_lspf[i] =
                              lspf[i] = (q->frame.lspv[i] ?  QCELP_LSP_SPREAD_FACTOR
-                                                         : -QCELP_LSP_SPREAD_FACTOR)
-                                     + predictors[i] * QCELP_LSP_OCTAVE_PREDICTOR
-                                     + (i + 1) * ((1 - QCELP_LSP_OCTAVE_PREDICTOR)/11);
+                                                         : -QCELP_LSP_SPREAD_FACTOR) +
+                                        predictors[i] * QCELP_LSP_OCTAVE_PREDICTOR   +
+                                        (i + 1) * ((1 - QCELP_LSP_OCTAVE_PREDICTOR) / 11);
             }
-            smooth = (q->octave_count < 10 ? .875 : 0.1);
-        }else
-        {
+            smooth = q->octave_count < 10 ? .875 : 0.1;
+        } else {
             erasure_coeff = QCELP_LSP_OCTAVE_PREDICTOR;
 
             assert(q->bitrate == I_F_Q);
 
-            if(q->erasure_count > 1)
-                erasure_coeff *= (q->erasure_count < 4 ? 0.9 : 0.7);
+            if (q->erasure_count > 1)
+                erasure_coeff *= q->erasure_count < 4 ? 0.9 : 0.7;
 
-            for(i=0; i<10; i++)
-            {
+            for (i = 0; i < 10; i++) {
                 q->predictor_lspf[i] =
-                             lspf[i] = (i + 1) * ( 1 - erasure_coeff)/11
-                                     + erasure_coeff * predictors[i];
+                             lspf[i] = (i + 1) * (1 - erasure_coeff) / 11 +
+                                       erasure_coeff * predictors[i];
             }
             smooth = 0.125;
         }
 
         // Check the stability of the LSP frequencies.
         lspf[0] = FFMAX(lspf[0], QCELP_LSP_SPREAD_FACTOR);
-        for(i=1; i<10; i++)
-            lspf[i] = FFMAX(lspf[i], (lspf[i-1] + QCELP_LSP_SPREAD_FACTOR));
+        for (i = 1; i < 10; i++)
+            lspf[i] = FFMAX(lspf[i], lspf[i - 1] + QCELP_LSP_SPREAD_FACTOR);
 
-        lspf[9] = FFMIN(lspf[9], (1.0 - QCELP_LSP_SPREAD_FACTOR));
-        for(i=9; i>0; i--)
-            lspf[i-1] = FFMIN(lspf[i-1], (lspf[i] - QCELP_LSP_SPREAD_FACTOR));
+        lspf[9] = FFMIN(lspf[9], 1.0 - QCELP_LSP_SPREAD_FACTOR);
+        for (i = 9; i > 0; i--)
+            lspf[i - 1] = FFMIN(lspf[i - 1], lspf[i] - QCELP_LSP_SPREAD_FACTOR);
 
         // Low-pass filter the LSP frequencies.
-        ff_weighted_vector_sumf(lspf, lspf, q->prev_lspf, smooth, 1.0-smooth, 10);
-    }else
-    {
+        ff_weighted_vector_sumf(lspf, lspf, q->prev_lspf, smooth, 1.0 - smooth, 10);
+    } else {
         q->octave_count = 0;
 
-        tmp_lspf = 0.;
-        for(i=0; i<5 ; i++)
-        {
-            lspf[2*i+0] = tmp_lspf += qcelp_lspvq[i][q->frame.lspv[i]][0] * 0.0001;
-            lspf[2*i+1] = tmp_lspf += qcelp_lspvq[i][q->frame.lspv[i]][1] * 0.0001;
+        tmp_lspf = 0.0;
+        for (i = 0; i < 5; i++) {
+            lspf[2 * i + 0] = tmp_lspf += qcelp_lspvq[i][q->frame.lspv[i]][0] * 0.0001;
+            lspf[2 * i + 1] = tmp_lspf += qcelp_lspvq[i][q->frame.lspv[i]][1] * 0.0001;
         }
 
         // Check for badly received packets.
-        if(q->bitrate == RATE_QUARTER)
-        {
-            if(lspf[9] <= .70 || lspf[9] >=  .97)
+        if (q->bitrate == RATE_QUARTER) {
+            if (lspf[9] <= .70 || lspf[9] >= .97)
                 return -1;
-            for(i=3; i<10; i++)
-                if(fabs(lspf[i] - lspf[i-2]) < .08)
+            for (i = 3; i < 10; i++)
+                if (fabs(lspf[i] - lspf[i - 2]) < .08)
                     return -1;
-        }else
-        {
-            if(lspf[9] <= .66 || lspf[9] >= .985)
+        } else {
+            if (lspf[9] <= .66 || lspf[9] >= .985)
                 return -1;
-            for(i=4; i<10; i++)
-                if (fabs(lspf[i] - lspf[i-4]) < .0931)
+            for (i = 4; i < 10; i++)
+                if (fabs(lspf[i] - lspf[i - 4]) < .0931)
                     return -1;
         }
     }
@@ -204,82 +194,72 @@ static int decode_lspf(QCELPContext *q, float *lspf)
  *
  * TIA/EIA/IS-733 2.4.6.2
  */
-static void decode_gain_and_index(QCELPContext  *q,
-                                  float *gain) {
-    int   i, subframes_count, g1[16];
+static void decode_gain_and_index(QCELPContext *q, float *gain)
+{
+    int i, subframes_count, g1[16];
     float slope;
 
-    if(q->bitrate >= RATE_QUARTER)
-    {
-        switch(q->bitrate)
-        {
-            case RATE_FULL: subframes_count = 16; break;
-            case RATE_HALF: subframes_count = 4;  break;
-            default:        subframes_count = 5;
+    if (q->bitrate >= RATE_QUARTER) {
+        switch (q->bitrate) {
+        case RATE_FULL: subframes_count = 16; break;
+        case RATE_HALF: subframes_count =  4; break;
+        default:        subframes_count =  5;
         }
-        for(i=0; i<subframes_count; i++)
-        {
+        for (i = 0; i < subframes_count; i++) {
             g1[i] = 4 * q->frame.cbgain[i];
-            if(q->bitrate == RATE_FULL && !((i+1) & 3))
-            {
-                g1[i] += av_clip((g1[i-1] + g1[i-2] + g1[i-3]) / 3 - 6, 0, 32);
+            if (q->bitrate == RATE_FULL && !((i + 1) & 3)) {
+                g1[i] += av_clip((g1[i - 1] + g1[i - 2] + g1[i - 3]) / 3 - 6, 0, 32);
             }
 
             gain[i] = qcelp_g12ga[g1[i]];
 
-            if(q->frame.cbsign[i])
-            {
+            if (q->frame.cbsign[i]) {
                 gain[i] = -gain[i];
-                q->frame.cindex[i] = (q->frame.cindex[i]-89) & 127;
+                q->frame.cindex[i] = (q->frame.cindex[i] - 89) & 127;
             }
         }
 
-        q->prev_g1[0] = g1[i-2];
-        q->prev_g1[1] = g1[i-1];
-        q->last_codebook_gain = qcelp_g12ga[g1[i-1]];
+        q->prev_g1[0]         = g1[i - 2];
+        q->prev_g1[1]         = g1[i - 1];
+        q->last_codebook_gain = qcelp_g12ga[g1[i - 1]];
 
-        if(q->bitrate == RATE_QUARTER)
-        {
+        if (q->bitrate == RATE_QUARTER) {
             // Provide smoothing of the unvoiced excitation energy.
-            gain[7] =     gain[4];
-            gain[6] = 0.4*gain[3] + 0.6*gain[4];
-            gain[5] =     gain[3];
-            gain[4] = 0.8*gain[2] + 0.2*gain[3];
-            gain[3] = 0.2*gain[1] + 0.8*gain[2];
-            gain[2] =     gain[1];
-            gain[1] = 0.6*gain[0] + 0.4*gain[1];
+            gain[7] =       gain[4];
+            gain[6] = 0.4 * gain[3] + 0.6 * gain[4];
+            gain[5] =       gain[3];
+            gain[4] = 0.8 * gain[2] + 0.2 * gain[3];
+            gain[3] = 0.2 * gain[1] + 0.8 * gain[2];
+            gain[2] =       gain[1];
+            gain[1] = 0.6 * gain[0] + 0.4 * gain[1];
         }
-    }else if (q->bitrate != SILENCE)
-    {
-        if(q->bitrate == RATE_OCTAVE)
-        {
-            g1[0] = 2 * q->frame.cbgain[0]
-                  + av_clip((q->prev_g1[0] + q->prev_g1[1]) / 2 - 5, 0, 54);
+    } else if (q->bitrate != SILENCE) {
+        if (q->bitrate == RATE_OCTAVE) {
+            g1[0] = 2 * q->frame.cbgain[0] +
+                    av_clip((q->prev_g1[0] + q->prev_g1[1]) / 2 - 5, 0, 54);
             subframes_count = 8;
-        }else
-        {
+        } else {
             assert(q->bitrate == I_F_Q);
 
             g1[0] = q->prev_g1[1];
-            switch(q->erasure_count)
-            {
-                case 1 : break;
-                case 2 : g1[0] -= 1; break;
-                case 3 : g1[0] -= 2; break;
-                default: g1[0] -= 6;
+            switch (q->erasure_count) {
+            case 1 : break;
+            case 2 : g1[0] -= 1; break;
+            case 3 : g1[0] -= 2; break;
+            default: g1[0] -= 6;
             }
-            if(g1[0] < 0)
+            if (g1[0] < 0)
                 g1[0] = 0;
             subframes_count = 4;
         }
         // This interpolation is done to produce smoother background noise.
-        slope = 0.5*(qcelp_g12ga[g1[0]] - q->last_codebook_gain) / subframes_count;
-        for(i=1; i<=subframes_count; i++)
-            gain[i-1] = q->last_codebook_gain + slope * i;
+        slope = 0.5 * (qcelp_g12ga[g1[0]] - q->last_codebook_gain) / subframes_count;
+        for (i = 1; i <= subframes_count; i++)
+                gain[i - 1] = q->last_codebook_gain + slope * i;
 
-        q->last_codebook_gain = gain[i-2];
-        q->prev_g1[0] = q->prev_g1[1];
-        q->prev_g1[1] = g1[0];
+        q->last_codebook_gain = gain[i - 2];
+        q->prev_g1[0]         = q->prev_g1[1];
+        q->prev_g1[1]         = g1[0];
     }
 }
 
@@ -294,14 +274,13 @@ static void decode_gain_and_index(QCELPContext  *q,
  */
 static int codebook_sanity_check_for_rate_quarter(const uint8_t *cbgain)
 {
-    int i, diff, prev_diff=0;
+    int i, diff, prev_diff = 0;
 
-    for(i=1; i<5; i++)
-    {
+    for (i = 1; i < 5; i++) {
         diff = cbgain[i] - cbgain[i-1];
-        if(FFABS(diff) > 10)
+        if (FFABS(diff) > 10)
             return -1;
-        else if(FFABS(diff - prev_diff) > 12)
+        else if (FFABS(diff - prev_diff) > 12)
             return -1;
         prev_diff = diff;
     }
@@ -332,81 +311,74 @@ static int codebook_sanity_check_for_rate_quarter(const uint8_t *cbgain)
 static void compute_svector(QCELPContext *q, const float *gain,
                             float *cdn_vector)
 {
-    int      i, j, k;
+    int i, j, k;
     uint16_t cbseed, cindex;
-    float    *rnd, tmp_gain, fir_filter_value;
-
-    switch(q->bitrate)
-    {
-        case RATE_FULL:
-            for(i=0; i<16; i++)
-            {
-                tmp_gain = gain[i] * QCELP_RATE_FULL_CODEBOOK_RATIO;
-                cindex = -q->frame.cindex[i];
-                for(j=0; j<10; j++)
-                    *cdn_vector++ = tmp_gain * qcelp_rate_full_codebook[cindex++ & 127];
-            }
+    float *rnd, tmp_gain, fir_filter_value;
+
+    switch (q->bitrate) {
+    case RATE_FULL:
+        for (i = 0; i < 16; i++) {
+            tmp_gain = gain[i] * QCELP_RATE_FULL_CODEBOOK_RATIO;
+            cindex   = -q->frame.cindex[i];
+            for (j = 0; j < 10; j++)
+                *cdn_vector++ = tmp_gain * qcelp_rate_full_codebook[cindex++ & 127];
+        }
         break;
-        case RATE_HALF:
-            for(i=0; i<4; i++)
-            {
-                tmp_gain = gain[i] * QCELP_RATE_HALF_CODEBOOK_RATIO;
-                cindex = -q->frame.cindex[i];
-                for (j = 0; j < 40; j++)
+    case RATE_HALF:
+        for (i = 0; i < 4; i++) {
+            tmp_gain = gain[i] * QCELP_RATE_HALF_CODEBOOK_RATIO;
+            cindex   = -q->frame.cindex[i];
+            for (j = 0; j < 40; j++)
                 *cdn_vector++ = tmp_gain * qcelp_rate_half_codebook[cindex++ & 127];
-            }
+        }
         break;
-        case RATE_QUARTER:
-            cbseed = (0x0003 & q->frame.lspv[4])<<14 |
-                     (0x003F & q->frame.lspv[3])<< 8 |
-                     (0x0060 & q->frame.lspv[2])<< 1 |
-                     (0x0007 & q->frame.lspv[1])<< 3 |
-                     (0x0038 & q->frame.lspv[0])>> 3 ;
-            rnd = q->rnd_fir_filter_mem + 20;
-            for(i=0; i<8; i++)
-            {
-                tmp_gain = gain[i] * (QCELP_SQRT1887 / 32768.0);
-                for(k=0; k<20; k++)
-                {
-                    cbseed = 521 * cbseed + 259;
-                    *rnd = (int16_t)cbseed;
+    case RATE_QUARTER:
+        cbseed = (0x0003 & q->frame.lspv[4]) << 14 |
+                 (0x003F & q->frame.lspv[3]) <<  8 |
+                 (0x0060 & q->frame.lspv[2]) <<  1 |
+                 (0x0007 & q->frame.lspv[1]) <<  3 |
+                 (0x0038 & q->frame.lspv[0]) >>  3;
+        rnd    = q->rnd_fir_filter_mem + 20;
+        for (i = 0; i < 8; i++) {
+            tmp_gain = gain[i] * (QCELP_SQRT1887 / 32768.0);
+            for (k = 0; k < 20; k++) {
+                cbseed = 521 * cbseed + 259;
+                *rnd   = (int16_t) cbseed;
 
                     // FIR filter
-                    fir_filter_value = 0.0;
-                    for(j=0; j<10; j++)
-                        fir_filter_value += qcelp_rnd_fir_coefs[j ]
-                                          * (rnd[-j ] + rnd[-20+j]);
-
-                    fir_filter_value += qcelp_rnd_fir_coefs[10] * rnd[-10];
-                    *cdn_vector++ = tmp_gain * fir_filter_value;
-                    rnd++;
-                }
+                fir_filter_value = 0.0;
+                for (j = 0; j < 10; j++)
+                    fir_filter_value += qcelp_rnd_fir_coefs[j] *
+                                        (rnd[-j] + rnd[-20+j]);
+
+                fir_filter_value += qcelp_rnd_fir_coefs[10] * rnd[-10];
+                *cdn_vector++     = tmp_gain * fir_filter_value;
+                rnd++;
             }
-            memcpy(q->rnd_fir_filter_mem, q->rnd_fir_filter_mem + 160, 20 * sizeof(float));
+        }
+        memcpy(q->rnd_fir_filter_mem, q->rnd_fir_filter_mem + 160,
+               20 * sizeof(float));
         break;
-        case RATE_OCTAVE:
-            cbseed = q->first16bits;
-            for(i=0; i<8; i++)
-            {
-                tmp_gain = gain[i] * (QCELP_SQRT1887 / 32768.0);
-                for(j=0; j<20; j++)
-                {
-                    cbseed = 521 * cbseed + 259;
-                    *cdn_vector++ = tmp_gain * (int16_t)cbseed;
-                }
+    case RATE_OCTAVE:
+        cbseed = q->first16bits;
+        for (i = 0; i < 8; i++) {
+            tmp_gain = gain[i] * (QCELP_SQRT1887 / 32768.0);
+            for (j = 0; j < 20; j++) {
+                cbseed        = 521 * cbseed + 259;
+                *cdn_vector++ = tmp_gain * (int16_t) cbseed;
             }
+        }
         break;
-        case I_F_Q:
-            cbseed = -44; // random codebook index
-            for(i=0; i<4; i++)
-            {
-                tmp_gain = gain[i] * QCELP_RATE_FULL_CODEBOOK_RATIO;
-                for(j=0; j<40; j++)
-                    *cdn_vector++ = tmp_gain * qcelp_rate_full_codebook[cbseed++ & 127];
-            }
+    case I_F_Q:
+        cbseed = -44; // random codebook index
+        for (i = 0; i < 4; i++) {
+            tmp_gain = gain[i] * QCELP_RATE_FULL_CODEBOOK_RATIO;
+            for (j = 0; j < 40; j++)
+                *cdn_vector++ = tmp_gain * qcelp_rate_full_codebook[cbseed++ & 127];
+        }
         break;
-        case SILENCE:
-            memset(cdn_vector, 0, 160 * sizeof(float));
+    case SILENCE:
+        memset(cdn_vector, 0, 160 * sizeof(float));
         break;
     }
 }
@@ -420,16 +392,14 @@ static void compute_svector(QCELPContext *q, const float *gain,
  *
  * TIA/EIA/IS-733 2.4.8.3, 2.4.8.6
  */
-static void apply_gain_ctrl(float *v_out, const float *v_ref,
-                            const float *v_in)
+static void apply_gain_ctrl(float *v_out, const float *v_ref, const float *v_in)
 {
     int i;
 
-    for (i = 0; i < 160; i += 40)
-        ff_scale_vector_to_given_sum_of_squares(v_out + i, v_in + i,
-                                                ff_dot_productf(v_ref + i,
-                                                                v_ref + i, 40),
-                                                40);
+    for (i = 0; i < 160; i += 40) {
+        float res = avpriv_scalarproduct_float_c(v_ref + i, v_ref + i, 40);
+        ff_scale_vector_to_given_sum_of_squares(v_out + i, v_in + i, res, 40);
+    }
 }
 
 /**
@@ -453,24 +423,20 @@ static const float *do_pitchfilter(float memory[303], const float v_in[160],
                                    const float gain[4], const uint8_t *lag,
                                    const uint8_t pfrac[4])
 {
-    int         i, j;
-    float       *v_lag, *v_out;
+    int i, j;
+    float *v_lag, *v_out;
     const float *v_len;
 
     v_out = memory + 143; // Output vector starts at memory[143].
 
-    for(i=0; i<4; i++)
-    {
-        if(gain[i])
-        {
+    for (i = 0; i < 4; i++) {
+        if (gain[i]) {
             v_lag = memory + 143 + 40 * i - lag[i];
-            for(v_len=v_in+40; v_in<v_len; v_in++)
-            {
-                if(pfrac[i]) // If it is a fractional lag...
-                {
-                    for(j=0, *v_out=0.; j<4; j++)
-                        *v_out += qcelp_hammsinc_table[j] * (v_lag[j-4] + v_lag[3-j]);
-                }else
+            for (v_len = v_in + 40; v_in < v_len; v_in++) {
+                if (pfrac[i]) { // If it is a fractional lag...
+                    for (j = 0, *v_out = 0.0; j < 4; j++)
+                        *v_out += qcelp_hammsinc_table[j] * (v_lag[j - 4] + v_lag[3 - j]);
+                } else
                     *v_out = *v_lag;
 
                 *v_out = *v_in + gain[i] * *v_out;
@@ -478,8 +444,7 @@ static const float *do_pitchfilter(float memory[303], const float v_in[160],
                 v_lag++;
                 v_out++;
             }
-        }else
-        {
+        } else {
             memcpy(v_out, v_in, 40 * sizeof(float));
             v_in  += 40;
             v_out += 40;
@@ -499,40 +464,32 @@ static const float *do_pitchfilter(float memory[303], const float v_in[160],
  */
 static void apply_pitch_filters(QCELPContext *q, float *cdn_vector)
 {
-    int         i;
+    int i;
     const float *v_synthesis_filtered, *v_pre_filtered;
 
-    if(q->bitrate >= RATE_HALF ||
-       q->bitrate == SILENCE ||
-       (q->bitrate == I_F_Q && (q->prev_bitrate >= RATE_HALF)))
-    {
-
-        if(q->bitrate >= RATE_HALF)
-        {
+    if (q->bitrate >= RATE_HALF || q->bitrate == SILENCE ||
+        (q->bitrate == I_F_Q && (q->prev_bitrate >= RATE_HALF))) {
 
+        if (q->bitrate >= RATE_HALF) {
             // Compute gain & lag for the whole frame.
-            for(i=0; i<4; i++)
-            {
+            for (i = 0; i < 4; i++) {
                 q->pitch_gain[i] = q->frame.plag[i] ? (q->frame.pgain[i] + 1) * 0.25 : 0.0;
 
                 q->pitch_lag[i] = q->frame.plag[i] + 16;
             }
-        }else
-        {
+        } else {
             float max_pitch_gain;
 
-            if (q->bitrate == I_F_Q)
-            {
+            if (q->bitrate == I_F_Q) {
                   if (q->erasure_count < 3)
                       max_pitch_gain = 0.9 - 0.3 * (q->erasure_count - 1);
                   else
                       max_pitch_gain = 0.0;
-            }else
-            {
+            } else {
                 assert(q->bitrate == SILENCE);
                 max_pitch_gain = 1.0;
             }
-            for(i=0; i<4; i++)
+            for (i = 0; i < 4; i++)
                 q->pitch_gain[i] = FFMIN(q->pitch_gain[i], max_pitch_gain);
 
             memset(q->frame.pfrac, 0, sizeof(q->frame.pfrac));
@@ -544,19 +501,17 @@ static void apply_pitch_filters(QCELPContext *q, float *cdn_vector)
                                               q->pitch_lag, q->frame.pfrac);
 
         // pitch prefilter update
-        for(i=0; i<4; i++)
+        for (i = 0; i < 4; i++)
             q->pitch_gain[i] = 0.5 * FFMIN(q->pitch_gain[i], 1.0);
 
-        v_pre_filtered = do_pitchfilter(q->pitch_pre_filter_mem,
-                                        v_synthesis_filtered,
-                                        q->pitch_gain, q->pitch_lag,
-                                        q->frame.pfrac);
+        v_pre_filtered       = do_pitchfilter(q->pitch_pre_filter_mem,
+                                              v_synthesis_filtered,
+                                              q->pitch_gain, q->pitch_lag,
+                                              q->frame.pfrac);
 
         apply_gain_ctrl(cdn_vector, v_synthesis_filtered, v_pre_filtered);
-    }else
-    {
-        memcpy(q->pitch_synthesis_filter_mem, cdn_vector + 17,
-               143 * sizeof(float));
+    } else {
+        memcpy(q->pitch_synthesis_filter_mem, cdn_vector + 17, 143 * sizeof(float));
         memcpy(q->pitch_pre_filter_mem, cdn_vector + 17, 143 * sizeof(float));
         memset(q->pitch_gain, 0, sizeof(q->pitch_gain));
         memset(q->pitch_lag,  0, sizeof(q->pitch_lag));
@@ -579,22 +534,21 @@ static void lspf2lpc(const float *lspf, float *lpc)
 {
     double lsp[10];
     double bandwidth_expansion_coeff = QCELP_BANDWIDTH_EXPANSION_COEFF;
-    int   i;
+    int i;
 
-    for (i=0; i<10; i++)
+    for (i = 0; i < 10; i++)
         lsp[i] = cos(M_PI * lspf[i]);
 
     ff_acelp_lspd2lpc(lsp, lpc, 5);
 
-    for (i=0; i<10; i++)
-    {
-        lpc[i] *= bandwidth_expansion_coeff;
+    for (i = 0; i < 10; i++) {
+        lpc[i]                    *= bandwidth_expansion_coeff;
         bandwidth_expansion_coeff *= QCELP_BANDWIDTH_EXPANSION_COEFF;
     }
 }
 
 /**
- * Interpolate LSP frequencies and computes LPC coefficients
+ * Interpolate LSP frequencies and compute LPC coefficients
  * for a given bitrate & pitch subframe.
  *
  * TIA/EIA/IS-733 2.4.3.3.4, 2.4.8.7.2
@@ -610,34 +564,32 @@ static void interpolate_lpc(QCELPContext *q, const float *curr_lspf,
     float interpolated_lspf[10];
     float weight;
 
-    if(q->bitrate >= RATE_QUARTER)
+    if (q->bitrate >= RATE_QUARTER)
         weight = 0.25 * (subframe_num + 1);
-    else if(q->bitrate == RATE_OCTAVE && !subframe_num)
+    else if (q->bitrate == RATE_OCTAVE && !subframe_num)
         weight = 0.625;
     else
         weight = 1.0;
 
-    if(weight != 1.0)
-    {
+    if (weight != 1.0) {
         ff_weighted_vector_sumf(interpolated_lspf, curr_lspf, q->prev_lspf,
                                 weight, 1.0 - weight, 10);
         lspf2lpc(interpolated_lspf, lpc);
-    }else if(q->bitrate >= RATE_QUARTER ||
-             (q->bitrate == I_F_Q && !subframe_num))
+    } else if (q->bitrate >= RATE_QUARTER ||
+               (q->bitrate == I_F_Q && !subframe_num))
         lspf2lpc(curr_lspf, lpc);
-    else if(q->bitrate == SILENCE && !subframe_num)
+    else if (q->bitrate == SILENCE && !subframe_num)
         lspf2lpc(q->prev_lspf, lpc);
 }
 
 static qcelp_packet_rate buf_size2bitrate(const int buf_size)
 {
-    switch(buf_size)
-    {
-        case 35: return RATE_FULL;
-        case 17: return RATE_HALF;
-        case  8: return RATE_QUARTER;
-        case  4: return RATE_OCTAVE;
-        case  1: return SILENCE;
+    switch (buf_size) {
+    case 35: return RATE_FULL;
+    case 17: return RATE_HALF;
+    case  8: return RATE_QUARTER;
+    case  4: return RATE_OCTAVE;
+    case  1: return SILENCE;
     }
 
     return I_F_Q;
@@ -655,41 +607,36 @@ static qcelp_packet_rate buf_size2bitrate(const int buf_size)
  *
  * TIA/EIA/IS-733 2.4.8.7.1
  */
-static qcelp_packet_rate determine_bitrate(AVCodecContext *avctx, const int buf_size,
-                             const uint8_t **buf)
+static qcelp_packet_rate determine_bitrate(AVCodecContext *avctx,
+                                           const int buf_size,
+                                           const uint8_t **buf)
 {
     qcelp_packet_rate bitrate;
 
-    if((bitrate = buf_size2bitrate(buf_size)) >= 0)
-    {
-        if(bitrate > **buf)
-        {
+    if ((bitrate = buf_size2bitrate(buf_size)) >= 0) {
+        if (bitrate > **buf) {
             QCELPContext *q = avctx->priv_data;
-            if (!q->warned_buf_mismatch_bitrate)
-            {
+            if (!q->warned_buf_mismatch_bitrate) {
             av_log(avctx, AV_LOG_WARNING,
                    "Claimed bitrate and buffer size mismatch.\n");
                 q->warned_buf_mismatch_bitrate = 1;
             }
             bitrate = **buf;
-        }else if(bitrate < **buf)
-        {
+        } else if (bitrate < **buf) {
             av_log(avctx, AV_LOG_ERROR,
                    "Buffer is too small for the claimed bitrate.\n");
             return I_F_Q;
         }
         (*buf)++;
-    }else if((bitrate = buf_size2bitrate(buf_size + 1)) >= 0)
-    {
+    } else if ((bitrate = buf_size2bitrate(buf_size + 1)) >= 0) {
         av_log(avctx, AV_LOG_WARNING,
                "Bitrate byte is missing, guessing the bitrate from packet size.\n");
-    }else
+    } else
         return I_F_Q;
 
-    if(bitrate == SILENCE)
-    {
-        //FIXME: Remove experimental warning when tested with samples.
-        av_log_ask_for_sample(avctx, "'Blank frame handling is experimental.");
+    if (bitrate == SILENCE) {
+        // FIXME: Remove this warning when tested with samples.
+        avpriv_request_sample(avctx, "Blank frame handling");
     }
     return bitrate;
 }
@@ -697,8 +644,8 @@ static qcelp_packet_rate determine_bitrate(AVCodecContext *avctx, const int buf_
 static void warn_insufficient_frame_quality(AVCodecContext *avctx,
                                             const char *message)
 {
-    av_log(avctx, AV_LOG_WARNING, "Frame #%d, IFQ: %s\n", avctx->frame_number,
-           message);
+    av_log(avctx, AV_LOG_WARNING, "Frame #%d, IFQ: %s\n",
+           avctx->frame_number, message);
 }
 
 static void postfilter(QCELPContext *q, float *samples, float *lpc)
@@ -720,75 +667,78 @@ static void postfilter(QCELPContext *q, float *samples, float *lpc)
 
     ff_celp_lp_zero_synthesis_filterf(zero_out, lpc_s,
                                       q->formant_mem + 10, 160, 10);
-    memcpy(pole_out, q->postfilter_synth_mem,       sizeof(float) * 10);
+    memcpy(pole_out, q->postfilter_synth_mem, sizeof(float) * 10);
     ff_celp_lp_synthesis_filterf(pole_out + 10, lpc_p, zero_out, 160, 10);
     memcpy(q->postfilter_synth_mem, pole_out + 160, sizeof(float) * 10);
 
     ff_tilt_compensation(&q->postfilter_tilt_mem, 0.3, pole_out + 10, 160);
 
     ff_adaptive_gain_control(samples, pole_out + 10,
-        ff_dot_productf(q->formant_mem + 10, q->formant_mem + 10, 160),
-        160, 0.9375, &q->postfilter_agc_mem);
+                             avpriv_scalarproduct_float_c(q->formant_mem + 10,
+                                                          q->formant_mem + 10,
+                                                          160),
+                             160, 0.9375, &q->postfilter_agc_mem);
 }
 
-static int qcelp_decode_frame(AVCodecContext *avctx, void *data, int *data_size,
-                              AVPacket *avpkt)
+static int qcelp_decode_frame(AVCodecContext *avctx, void *data,
+                              int *got_frame_ptr, AVPacket *avpkt)
 {
     const uint8_t *buf = avpkt->data;
-    int buf_size = avpkt->size;
-    QCELPContext *q = avctx->priv_data;
-    float *outbuffer = data;
-    int   i;
+    int buf_size       = avpkt->size;
+    QCELPContext *q    = avctx->priv_data;
+    AVFrame *frame     = data;
+    float *outbuffer;
+    int   i, ret;
     float quantized_lspf[10], lpc[10];
     float gain[16];
     float *formant_mem;
 
-    if((q->bitrate = determine_bitrate(avctx, buf_size, &buf)) == I_F_Q)
-    {
+    /* get output buffer */
+    frame->nb_samples = 160;
+    if ((ret = ff_get_buffer(avctx, frame, 0)) < 0) {
+        av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n");
+        return ret;
+    }
+    outbuffer = (float *)frame->data[0];
+
+    if ((q->bitrate = determine_bitrate(avctx, buf_size, &buf)) == I_F_Q) {
         warn_insufficient_frame_quality(avctx, "bitrate cannot be determined.");
         goto erasure;
     }
 
-    if(q->bitrate == RATE_OCTAVE &&
-       (q->first16bits = AV_RB16(buf)) == 0xFFFF)
-    {
+    if (q->bitrate == RATE_OCTAVE &&
+        (q->first16bits = AV_RB16(buf)) == 0xFFFF) {
         warn_insufficient_frame_quality(avctx, "Bitrate is 1/8 and first 16 bits are on.");
         goto erasure;
     }
 
-    if(q->bitrate > SILENCE)
-    {
+    if (q->bitrate > SILENCE) {
         const QCELPBitmap *bitmaps     = qcelp_unpacking_bitmaps_per_rate[q->bitrate];
-        const QCELPBitmap *bitmaps_end = qcelp_unpacking_bitmaps_per_rate[q->bitrate]
-                                       + qcelp_unpacking_bitmaps_lengths[q->bitrate];
-        uint8_t           *unpacked_data = (uint8_t *)&q->frame;
+        const QCELPBitmap *bitmaps_end = qcelp_unpacking_bitmaps_per_rate[q->bitrate] +
+                                         qcelp_unpacking_bitmaps_lengths[q->bitrate];
+        uint8_t *unpacked_data         = (uint8_t *)&q->frame;
 
-        init_get_bits(&q->gb, buf, 8*buf_size);
+        init_get_bits(&q->gb, buf, 8 * buf_size);
 
         memset(&q->frame, 0, sizeof(QCELPFrame));
 
-        for(; bitmaps < bitmaps_end; bitmaps++)
+        for (; bitmaps < bitmaps_end; bitmaps++)
             unpacked_data[bitmaps->index] |= get_bits(&q->gb, bitmaps->bitlen) << bitmaps->bitpos;
 
         // Check for erasures/blanks on rates 1, 1/4 and 1/8.
-        if(q->frame.reserved)
-        {
+        if (q->frame.reserved) {
             warn_insufficient_frame_quality(avctx, "Wrong data in reserved frame area.");
             goto erasure;
         }
-        if(q->bitrate == RATE_QUARTER &&
-           codebook_sanity_check_for_rate_quarter(q->frame.cbgain))
-        {
+        if (q->bitrate == RATE_QUARTER &&
+            codebook_sanity_check_for_rate_quarter(q->frame.cbgain)) {
             warn_insufficient_frame_quality(avctx, "Codebook gain sanity check failed.");
             goto erasure;
         }
 
-        if(q->bitrate >= RATE_HALF)
-        {
-            for(i=0; i<4; i++)
-            {
-                if(q->frame.pfrac[i] && q->frame.plag[i] >= 124)
-                {
+        if (q->bitrate >= RATE_HALF) {
+            for (i = 0; i < 4; i++) {
+                if (q->frame.pfrac[i] && q->frame.plag[i] >= 124) {
                     warn_insufficient_frame_quality(avctx, "Cannot initialize pitch filter.");
                     goto erasure;
                 }
@@ -799,17 +749,14 @@ static int qcelp_decode_frame(AVCodecContext *avctx, void *data, int *data_size,
     decode_gain_and_index(q, gain);
     compute_svector(q, gain, outbuffer);
 
-    if(decode_lspf(q, quantized_lspf) < 0)
-    {
+    if (decode_lspf(q, quantized_lspf) < 0) {
         warn_insufficient_frame_quality(avctx, "Badly received packets in frame.");
         goto erasure;
     }
 
-
     apply_pitch_filters(q, outbuffer);
 
-    if(q->bitrate == I_F_Q)
-    {
+    if (q->bitrate == I_F_Q) {
 erasure:
         q->bitrate = I_F_Q;
         q->erasure_count++;
@@ -817,15 +764,13 @@ erasure:
         compute_svector(q, gain, outbuffer);
         decode_lspf(q, quantized_lspf);
         apply_pitch_filters(q, outbuffer);
-    }else
+    } else
         q->erasure_count = 0;
 
     formant_mem = q->formant_mem + 10;
-    for(i=0; i<4; i++)
-    {
+    for (i = 0; i < 4; i++) {
         interpolate_lpc(q, quantized_lspf, lpc, i);
-        ff_celp_lp_synthesis_filterf(formant_mem, lpc, outbuffer + i * 40, 40,
-                                     10);
+        ff_celp_lp_synthesis_filterf(formant_mem, lpc, outbuffer + i * 40, 40, 10);
         formant_mem += 40;
     }
 
@@ -835,20 +780,20 @@ erasure:
     memcpy(q->formant_mem, q->formant_mem + 160, 10 * sizeof(float));
 
     memcpy(q->prev_lspf, quantized_lspf, sizeof(q->prev_lspf));
-    q->prev_bitrate = q->bitrate;
+    q->prev_bitrate  = q->bitrate;
 
-    *data_size = 160 * sizeof(*outbuffer);
+    *got_frame_ptr = 1;
 
-    return *data_size;
+    return buf_size;
 }
 
-AVCodec qcelp_decoder =
-{
-    .name   = "qcelp",
-    .type   = AVMEDIA_TYPE_AUDIO,
-    .id     = CODEC_ID_QCELP,
-    .init   = qcelp_decode_init,
-    .decode = qcelp_decode_frame,
+AVCodec ff_qcelp_decoder = {
+    .name           = "qcelp",
+    .long_name      = NULL_IF_CONFIG_SMALL("QCELP / PureVoice"),
+    .type           = AVMEDIA_TYPE_AUDIO,
+    .id             = AV_CODEC_ID_QCELP,
+    .init           = qcelp_decode_init,
+    .decode         = qcelp_decode_frame,
+    .capabilities   = CODEC_CAP_DR1,
     .priv_data_size = sizeof(QCELPContext),
-    .long_name = NULL_IF_CONFIG_SMALL("QCELP / PureVoice"),
 };