aac_adtstoasc_bsf: Check extradata memory allocation

[ffmpeg] / libavcodec / roqaudioenc.c

diff --git a/libavcodec/roqaudioenc.c b/libavcodec/roqaudioenc.c
index 6f36965c8b5452d294d1e5785ca8f4a21c7a5bd4..936b809e39ac556b2140968553480bc1d7112feb 100644 (file)
--- a/libavcodec/roqaudioenc.c
+++ b/libavcodec/roqaudioenc.c
@@ -21,9 +21,10 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
-#include "libavutil/intmath.h"
 #include "avcodec.h"
 #include "bytestream.h"
+#include "internal.h"
+#include "mathops.h"
 
 #define ROQ_FRAME_SIZE           735
 #define ROQ_HEADER_SIZE   8
@@ -31,12 +32,12 @@
 #define MAX_DPCM (127*127)
 
 
-typedef struct
-{
+typedef struct ROQDPCMContext {
     short lastSample[2];
     int input_frames;
     int buffered_samples;
     int16_t *frame_buffer;
+    int64_t first_pts;
 } ROQDPCMContext;
 
 
@@ -44,7 +45,6 @@ static av_cold int roq_dpcm_encode_close(AVCodecContext *avctx)
 {
     ROQDPCMContext *context = avctx->priv_data;
 
-    av_freep(&avctx->coded_frame);
     av_freep(&context->frame_buffer);
 
     return 0;
@@ -57,11 +57,11 @@ static av_cold int roq_dpcm_encode_init(AVCodecContext *avctx)
 
     if (avctx->channels > 2) {
         av_log(avctx, AV_LOG_ERROR, "Audio must be mono or stereo\n");
-        return -1;
+        return AVERROR(EINVAL);
     }
     if (avctx->sample_rate != 22050) {
         av_log(avctx, AV_LOG_ERROR, "Audio must be 22050 Hz\n");
-        return -1;
+        return AVERROR(EINVAL);
     }
 
     avctx->frame_size = ROQ_FRAME_SIZE;
@@ -77,12 +77,6 @@ static av_cold int roq_dpcm_encode_init(AVCodecContext *avctx)
 
     context->lastSample[0] = context->lastSample[1] = 0;
 
-    avctx->coded_frame= avcodec_alloc_frame();
-    if (!avctx->coded_frame) {
-        ret = AVERROR(ENOMEM);
-        goto error;
-    }
-
     return 0;
 error:
     roq_dpcm_encode_close(avctx);
@@ -129,44 +123,48 @@ static unsigned char dpcm_predict(short *previous, short current)
     return result;
 }
 
-static int roq_dpcm_encode_frame(AVCodecContext *avctx,
-                unsigned char *frame, int buf_size, void *data)
+static int roq_dpcm_encode_frame(AVCodecContext *avctx, AVPacket *avpkt,
+                                 const AVFrame *frame, int *got_packet_ptr)
 {
-    int i, stereo, data_size;
-    const int16_t *in = data;
-    uint8_t *out = frame;
+    int i, stereo, data_size, ret;
+    const int16_t *in = frame ? (const int16_t *)frame->data[0] : NULL;
+    uint8_t *out;
     ROQDPCMContext *context = avctx->priv_data;
 
     stereo = (avctx->channels == 2);
 
-    if (!data && context->input_frames >= 8)
+    if (!in && context->input_frames >= 8)
         return 0;
 
-    if (data && context->input_frames < 8) {
+    if (in && context->input_frames < 8) {
         memcpy(&context->frame_buffer[context->buffered_samples * avctx->channels],
                in, avctx->frame_size * avctx->channels * sizeof(*in));
         context->buffered_samples += avctx->frame_size;
+        if (context->input_frames == 0)
+            context->first_pts = frame->pts;
         if (context->input_frames < 7) {
             context->input_frames++;
             return 0;
         }
-        in = context->frame_buffer;
     }
+    if (context->input_frames < 8)
+        in = context->frame_buffer;
 
     if (stereo) {
         context->lastSample[0] &= 0xFF00;
         context->lastSample[1] &= 0xFF00;
     }
 
-    if (context->input_frames == 7 || !data)
+    if (context->input_frames == 7)
         data_size = avctx->channels * context->buffered_samples;
     else
         data_size = avctx->channels * avctx->frame_size;
 
-    if (buf_size < ROQ_HEADER_SIZE + data_size) {
-        av_log(avctx, AV_LOG_ERROR, "output buffer is too small\n");
-        return AVERROR(EINVAL);
+    if ((ret = ff_alloc_packet(avpkt, ROQ_HEADER_SIZE + data_size))) {
+        av_log(avctx, AV_LOG_ERROR, "Error getting output packet\n");
+        return ret;
     }
+    out = avpkt->data;
 
     bytestream_put_byte(&out, stereo ? 0x21 : 0x20);
     bytestream_put_byte(&out, 0x10);
@@ -182,23 +180,27 @@ static int roq_dpcm_encode_frame(AVCodecContext *avctx,
     for (i = 0; i < data_size; i++)
         *out++ = dpcm_predict(&context->lastSample[i & 1], *in++);
 
+    avpkt->pts      = context->input_frames <= 7 ? context->first_pts : frame->pts;
+    avpkt->duration = data_size / avctx->channels;
+
     context->input_frames++;
-    if (!data)
+    if (!in)
         context->input_frames = FFMAX(context->input_frames, 8);
 
-    /* Return the result size */
-    return ROQ_HEADER_SIZE + data_size;
+    *got_packet_ptr = 1;
+    return 0;
 }
 
 AVCodec ff_roq_dpcm_encoder = {
     .name           = "roq_dpcm",
+    .long_name      = NULL_IF_CONFIG_SMALL("id RoQ DPCM"),
     .type           = AVMEDIA_TYPE_AUDIO,
-    .id             = CODEC_ID_ROQ_DPCM,
+    .id             = AV_CODEC_ID_ROQ_DPCM,
     .priv_data_size = sizeof(ROQDPCMContext),
     .init           = roq_dpcm_encode_init,
-    .encode         = roq_dpcm_encode_frame,
+    .encode2        = roq_dpcm_encode_frame,
     .close          = roq_dpcm_encode_close,
     .capabilities   = CODEC_CAP_DELAY,
-    .sample_fmts = (const enum AVSampleFormat[]){AV_SAMPLE_FMT_S16,AV_SAMPLE_FMT_NONE},
-    .long_name = NULL_IF_CONFIG_SMALL("id RoQ DPCM"),
+    .sample_fmts    = (const enum AVSampleFormat[]){ AV_SAMPLE_FMT_S16,
+                                                     AV_SAMPLE_FMT_NONE },
 };