]> git.sesse.net Git - ffmpeg/blobdiff - libavfilter/avfiltergraph.c
lavfi: make formats API private on next bump.
[ffmpeg] / libavfilter / avfiltergraph.c
index 059e6a36765ea91a3ca09f36fd3aa80a3ab238c9..42bf1f7547127ddd7ba26687017a49e678c77450 100644 (file)
@@ -1,22 +1,22 @@
 /*
  * filter graphs
- * copyright (c) 2008 Vitor Sessak
- * copyright (c) 2007 Bobby Bingham
+ * Copyright (c) 2008 Vitor Sessak
+ * Copyright (c) 2007 Bobby Bingham
  *
- * This file is part of FFmpeg.
+ * This file is part of Libav.
  *
- * FFmpeg is free software; you can redistribute it and/or
+ * Libav is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
  * version 2.1 of the License, or (at your option) any later version.
  *
- * FFmpeg is distributed in the hope that it will be useful,
+ * Libav is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Lesser General Public License for more details.
  *
  * You should have received a copy of the GNU Lesser General Public
- * License along with FFmpeg; if not, write to the Free Software
+ * License along with Libav; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
 
 #include "avfilter.h"
 #include "avfiltergraph.h"
+#include "formats.h"
+#include "internal.h"
 
+#include "libavutil/audioconvert.h"
+#include "libavutil/log.h"
 
-/** Linked-list of filters to create for an AVFilterGraphDesc */
-typedef struct AVFilterGraphDescFilter
+static const AVClass filtergraph_class = {
+    .class_name = "AVFilterGraph",
+    .item_name  = av_default_item_name,
+    .version    = LIBAVUTIL_VERSION_INT,
+};
+
+AVFilterGraph *avfilter_graph_alloc(void)
+{
+    AVFilterGraph *ret = av_mallocz(sizeof(AVFilterGraph));
+    if (!ret)
+        return NULL;
+#if FF_API_GRAPH_AVCLASS
+    ret->av_class = &filtergraph_class;
+#endif
+    return ret;
+}
+
+void avfilter_graph_free(AVFilterGraph **graph)
 {
-    int index;              ///< filter instance index
-    char *filter;           ///< name of filter type
-    char *args;             ///< filter parameters
-    struct AVFilterGraphDescFilter *next;
-} AVFilterGraphDescFilter;
-
-/** Linked-list of links between filters */
-typedef struct AVFilterGraphDescLink
+    if (!*graph)
+        return;
+    for (; (*graph)->filter_count > 0; (*graph)->filter_count--)
+        avfilter_free((*graph)->filters[(*graph)->filter_count - 1]);
+    av_freep(&(*graph)->scale_sws_opts);
+    av_freep(&(*graph)->filters);
+    av_freep(graph);
+}
+
+int avfilter_graph_add_filter(AVFilterGraph *graph, AVFilterContext *filter)
 {
-    /* TODO: allow referencing pads by name, not just by index */
-    int src;                ///< index of the source filter
-    unsigned srcpad;        ///< index of the output pad on the source filter
+    AVFilterContext **filters = av_realloc(graph->filters,
+                                           sizeof(AVFilterContext*) * (graph->filter_count+1));
+    if (!filters)
+        return AVERROR(ENOMEM);
 
-    int dst;                ///< index of the dest filter
-    unsigned dstpad;        ///< index of the input pad on the dest filter
+    graph->filters = filters;
+    graph->filters[graph->filter_count++] = filter;
 
-    struct AVFilterGraphDescLink *next;
-} AVFilterGraphDescLink;
+    return 0;
+}
 
-/** Linked-list of filter pads to be exported from the graph */
-typedef struct AVFilterGraphDescExport
+int avfilter_graph_create_filter(AVFilterContext **filt_ctx, AVFilter *filt,
+                                 const char *name, const char *args, void *opaque,
+                                 AVFilterGraph *graph_ctx)
 {
-    /* TODO: allow referencing pads by name, not just by index */
-    char *name;             ///< name of the exported pad
-    int filter;             ///< index of the filter
-    unsigned pad;           ///< index of the pad to be exported
+    int ret;
 
-    struct AVFilterGraphDescExport *next;
-} AVFilterGraphDescExport;
+    if ((ret = avfilter_open(filt_ctx, filt, name)) < 0)
+        goto fail;
+    if ((ret = avfilter_init_filter(*filt_ctx, args, opaque)) < 0)
+        goto fail;
+    if ((ret = avfilter_graph_add_filter(graph_ctx, *filt_ctx)) < 0)
+        goto fail;
+    return 0;
 
-/** Description of a graph to be loaded from a file, etc */
-typedef struct
-{
-    AVFilterGraphDescFilter *filters;   ///< filters in the graph
-    AVFilterGraphDescLink   *links;     ///< links between the filters
-    AVFilterGraphDescExport *inputs;    ///< inputs to export
-    AVFilterGraphDescExport *outputs;   ///< outputs to export
-} AVFilterGraphDesc;
+fail:
+    if (*filt_ctx)
+        avfilter_free(*filt_ctx);
+    *filt_ctx = NULL;
+    return ret;
+}
 
 /**
- * For use in av_log
+ * Check for the validity of graph.
+ *
+ * A graph is considered valid if all its input and output pads are
+ * connected.
+ *
+ * @return 0 in case of success, a negative value otherwise
  */
-static const char *log_name(void *p)
+static int graph_check_validity(AVFilterGraph *graph, AVClass *log_ctx)
 {
-    return "Filter parser";
-}
+    AVFilterContext *filt;
+    int i, j;
 
-static const AVClass filter_parser_class = {
-    "Filter parser",
-    log_name
-};
+    for (i = 0; i < graph->filter_count; i++) {
+        filt = graph->filters[i];
 
-static const AVClass *log_ctx = &filter_parser_class;
+        for (j = 0; j < filt->input_count; j++) {
+            if (!filt->inputs[j] || !filt->inputs[j]->src) {
+                av_log(log_ctx, AV_LOG_ERROR,
+                       "Input pad \"%s\" for the filter \"%s\" of type \"%s\" not connected to any source\n",
+                       filt->input_pads[j].name, filt->name, filt->filter->name);
+                return AVERROR(EINVAL);
+            }
+        }
 
-static void uninit(AVFilterGraph *graph)
-{
-    for(; graph->filter_count > 0; graph->filter_count --)
-        avfilter_destroy(graph->filters[graph->filter_count - 1]);
-    av_freep(&graph->filters);
+        for (j = 0; j < filt->output_count; j++) {
+            if (!filt->outputs[j] || !filt->outputs[j]->dst) {
+                av_log(log_ctx, AV_LOG_ERROR,
+                       "Output pad \"%s\" for the filter \"%s\" of type \"%s\" not connected to any destination\n",
+                       filt->output_pads[j].name, filt->name, filt->filter->name);
+                return AVERROR(EINVAL);
+            }
+        }
+    }
+
+    return 0;
 }
 
-/* TODO: insert in sorted order */
-void avfilter_graph_add_filter(AVFilterGraph *graph, AVFilterContext *filter)
+/**
+ * Configure all the links of graphctx.
+ *
+ * @return 0 in case of success, a negative value otherwise
+ */
+static int graph_config_links(AVFilterGraph *graph, AVClass *log_ctx)
 {
-    graph->filters = av_realloc(graph->filters,
-                                sizeof(AVFilterContext*) * ++graph->filter_count);
-    graph->filters[graph->filter_count - 1] = filter;
+    AVFilterContext *filt;
+    int i, ret;
+
+    for (i=0; i < graph->filter_count; i++) {
+        filt = graph->filters[i];
+
+        if (!filt->output_count) {
+            if ((ret = avfilter_config_links(filt)))
+                return ret;
+        }
+    }
+
+    return 0;
 }
 
-/* search intelligently, once we insert in order */
 AVFilterContext *avfilter_graph_get_filter(AVFilterGraph *graph, char *name)
 {
     int i;
 
-    if(!name)
-        return NULL;
-
-    for(i = 0; i < graph->filter_count; i ++)
-        if(graph->filters[i]->name && !strcmp(name, graph->filters[i]->name))
+    for (i = 0; i < graph->filter_count; i++)
+        if (graph->filters[i]->name && !strcmp(name, graph->filters[i]->name))
             return graph->filters[i];
 
     return NULL;
 }
 
-static int query_formats(AVFilterGraph *graph)
+static int query_formats(AVFilterGraph *graph, AVClass *log_ctx)
 {
-    int i, j;
+    int i, j, ret;
+    int scaler_count = 0, resampler_count = 0;
 
-    /* ask all the sub-filters for their supported colorspaces */
-    for(i = 0; i < graph->filter_count; i ++) {
-        if(graph->filters[i]->filter->query_formats)
+    /* ask all the sub-filters for their supported media formats */
+    for (i = 0; i < graph->filter_count; i++) {
+        if (graph->filters[i]->filter->query_formats)
             graph->filters[i]->filter->query_formats(graph->filters[i]);
         else
-            avfilter_default_query_formats(graph->filters[i]);
+            ff_default_query_formats(graph->filters[i]);
     }
 
     /* go through and merge as many format lists as possible */
-    for(i = 0; i < graph->filter_count; i ++) {
+    for (i = 0; i < graph->filter_count; i++) {
         AVFilterContext *filter = graph->filters[i];
 
-        for(j = 0; j < filter->input_count; j ++) {
-            AVFilterLink *link;
-            if(!(link = filter->inputs[j]))
+        for (j = 0; j < filter->input_count; j++) {
+            AVFilterLink *link = filter->inputs[j];
+            int convert_needed = 0;
+
+            if (!link)
                 continue;
-            if(link->in_formats != link->out_formats) {
-                if(!avfilter_merge_formats(link->in_formats,
-                                           link->out_formats)) {
-                    /* couldn't merge format lists. auto-insert scale filter */
-                    AVFilterContext *scale;
-
-                    if(!(scale =
-                         avfilter_open(avfilter_get_by_name("scale"), NULL)))
-                        return -1;
-                    if(scale->filter->init(scale, NULL, NULL) ||
-                       avfilter_insert_filter(link, scale, 0, 0)) {
-                        avfilter_destroy(scale);
-                        return -1;
+
+            if (link->in_formats != link->out_formats &&
+                !ff_merge_formats(link->in_formats,
+                                        link->out_formats))
+                convert_needed = 1;
+            if (link->type == AVMEDIA_TYPE_AUDIO) {
+                if (link->in_channel_layouts != link->out_channel_layouts &&
+                    !ff_merge_channel_layouts(link->in_channel_layouts,
+                                              link->out_channel_layouts))
+                    convert_needed = 1;
+                if (link->in_samplerates != link->out_samplerates &&
+                    !ff_merge_samplerates(link->in_samplerates,
+                                          link->out_samplerates))
+                    convert_needed = 1;
+            }
+
+            if (convert_needed) {
+                AVFilterContext *convert;
+                AVFilter *filter;
+                AVFilterLink *inlink, *outlink;
+                char scale_args[256];
+                char inst_name[30];
+
+                /* couldn't merge format lists. auto-insert conversion filter */
+                switch (link->type) {
+                case AVMEDIA_TYPE_VIDEO:
+                    snprintf(inst_name, sizeof(inst_name), "auto-inserted scaler %d",
+                             scaler_count++);
+                    snprintf(scale_args, sizeof(scale_args), "0:0:%s", graph->scale_sws_opts);
+                    if ((ret = avfilter_graph_create_filter(&convert,
+                                                            avfilter_get_by_name("scale"),
+                                                            inst_name, scale_args, NULL,
+                                                            graph)) < 0)
+                        return ret;
+                    break;
+                case AVMEDIA_TYPE_AUDIO:
+                    if (!(filter = avfilter_get_by_name("resample"))) {
+                        av_log(log_ctx, AV_LOG_ERROR, "'resample' filter "
+                               "not present, cannot convert audio formats.\n");
+                        return AVERROR(EINVAL);
                     }
 
-                    avfilter_graph_add_filter(graph, scale);
-                    scale->filter->query_formats(scale);
-                    if(!avfilter_merge_formats(scale-> inputs[0]->in_formats,
-                                              scale-> inputs[0]->out_formats) ||
-                       !avfilter_merge_formats(scale->outputs[0]->in_formats,
-                                              scale->outputs[0]->out_formats))
-                        return -1;
+                    snprintf(inst_name, sizeof(inst_name), "auto-inserted resampler %d",
+                             resampler_count++);
+                    if ((ret = avfilter_graph_create_filter(&convert,
+                                                            avfilter_get_by_name("resample"),
+                                                            inst_name, NULL, NULL, graph)) < 0)
+                        return ret;
+                    break;
+                default:
+                    return AVERROR(EINVAL);
+                }
+
+                if ((ret = avfilter_insert_filter(link, convert, 0, 0)) < 0)
+                    return ret;
+
+                convert->filter->query_formats(convert);
+                inlink  = convert->inputs[0];
+                outlink = convert->outputs[0];
+                if (!ff_merge_formats( inlink->in_formats,  inlink->out_formats) ||
+                    !ff_merge_formats(outlink->in_formats, outlink->out_formats))
+                    ret |= AVERROR(ENOSYS);
+                if (inlink->type == AVMEDIA_TYPE_AUDIO &&
+                    (!ff_merge_samplerates(inlink->in_samplerates,
+                                           inlink->out_samplerates) ||
+                     !ff_merge_channel_layouts(inlink->in_channel_layouts,
+                                               inlink->out_channel_layouts)))
+                    ret |= AVERROR(ENOSYS);
+                if (outlink->type == AVMEDIA_TYPE_AUDIO &&
+                    (!ff_merge_samplerates(outlink->in_samplerates,
+                                           outlink->out_samplerates) ||
+                     !ff_merge_channel_layouts(outlink->in_channel_layouts,
+                                               outlink->out_channel_layouts)))
+                    ret |= AVERROR(ENOSYS);
+
+                if (ret < 0) {
+                    av_log(log_ctx, AV_LOG_ERROR,
+                           "Impossible to convert between the formats supported by the filter "
+                           "'%s' and the filter '%s'\n", link->src->name, link->dst->name);
+                    return ret;
                 }
             }
         }
@@ -164,490 +275,328 @@ static int query_formats(AVFilterGraph *graph)
     return 0;
 }
 
-static void pick_format(AVFilterLink *link)
+static int pick_format(AVFilterLink *link)
 {
-    if(!link || !link->in_formats)
-        return;
+    if (!link || !link->in_formats)
+        return 0;
 
     link->in_formats->format_count = 1;
     link->format = link->in_formats->formats[0];
 
-    avfilter_formats_unref(&link->in_formats);
-    avfilter_formats_unref(&link->out_formats);
-}
-
-static void pick_formats(AVFilterGraph *graph)
-{
-    int i, j;
-
-    for(i = 0; i < graph->filter_count; i ++) {
-        AVFilterContext *filter = graph->filters[i];
-
-        for(j = 0; j < filter->input_count; j ++)
-            pick_format(filter->inputs[j]);
-        for(j = 0; j < filter->output_count; j ++)
-            pick_format(filter->outputs[j]);
+    if (link->type == AVMEDIA_TYPE_AUDIO) {
+        if (!link->in_samplerates->format_count) {
+            av_log(link->src, AV_LOG_ERROR, "Cannot select sample rate for"
+                   " the link between filters %s and %s.\n", link->src->name,
+                   link->dst->name);
+            return AVERROR(EINVAL);
+        }
+        link->in_samplerates->format_count = 1;
+        link->sample_rate = link->in_samplerates->formats[0];
+
+        if (!link->in_channel_layouts->nb_channel_layouts) {
+            av_log(link->src, AV_LOG_ERROR, "Cannot select channel layout for"
+                   "the link between filters %s and %s.\n", link->src->name,
+                   link->dst->name);
+            return AVERROR(EINVAL);
+        }
+        link->in_channel_layouts->nb_channel_layouts = 1;
+        link->channel_layout = link->in_channel_layouts->channel_layouts[0];
     }
-}
 
-int avfilter_graph_config_formats(AVFilterGraph *graph)
-{
-    /* find supported formats from sub-filters, and merge along links */
-    if(query_formats(graph))
-        return -1;
-
-    /* Once everything is merged, it's possible that we'll still have
-     * multiple valid colorspace choices. We pick the first one. */
-    pick_formats(graph);
+    ff_formats_unref(&link->in_formats);
+    ff_formats_unref(&link->out_formats);
+    ff_formats_unref(&link->in_samplerates);
+    ff_formats_unref(&link->out_samplerates);
+    ff_channel_layouts_unref(&link->in_channel_layouts);
+    ff_channel_layouts_unref(&link->out_channel_layouts);
 
     return 0;
 }
 
-static int create_filter(AVFilterGraph *ctx, int index, char *name,
-                         char *args)
+#define REDUCE_FORMATS(fmt_type, list_type, list, var, nb, add_format) \
+do {                                                                   \
+    for (i = 0; i < filter->input_count; i++) {                        \
+        AVFilterLink *link = filter->inputs[i];                        \
+        fmt_type fmt;                                                  \
+                                                                       \
+        if (!link->out_ ## list || link->out_ ## list->nb != 1)        \
+            continue;                                                  \
+        fmt = link->out_ ## list->var[0];                              \
+                                                                       \
+        for (j = 0; j < filter->output_count; j++) {                   \
+            AVFilterLink *out_link = filter->outputs[j];               \
+            list_type *fmts;                                           \
+                                                                       \
+            if (link->type != out_link->type ||                        \
+                out_link->in_ ## list->nb == 1)                        \
+                continue;                                              \
+            fmts = out_link->in_ ## list;                              \
+                                                                       \
+            if (!out_link->in_ ## list->nb) {                          \
+                add_format(&out_link->in_ ##list, fmt);                \
+                break;                                                 \
+            }                                                          \
+                                                                       \
+            for (k = 0; k < out_link->in_ ## list->nb; k++)            \
+                if (fmts->var[k] == fmt) {                             \
+                    fmts->var[0]  = fmt;                               \
+                    fmts->nb = 1;                                      \
+                    ret = 1;                                           \
+                    break;                                             \
+                }                                                      \
+        }                                                              \
+    }                                                                  \
+} while (0)
+
+static int reduce_formats_on_filter(AVFilterContext *filter)
 {
-    AVFilterContext *filt;
-
-    AVFilter *filterdef;
-    char tmp[20];
+    int i, j, k, ret = 0;
 
-    snprintf(tmp, 20, "%d", index);
-    if(!(filterdef = avfilter_get_by_name(name)) ||
-       !(filt = avfilter_open(filterdef, tmp))) {
-        av_log(&log_ctx, AV_LOG_ERROR,
-               "error creating filter '%s'\n", name);
-        return -1;
-    }
-    avfilter_graph_add_filter(ctx, filt);
-    if(avfilter_init_filter(filt, args, NULL)) {
-        av_log(&log_ctx, AV_LOG_ERROR,
-               "error initializing filter '%s'\n", name);
-        return -1;
-    }
+    REDUCE_FORMATS(int,      AVFilterFormats,        formats,         formats,
+                   format_count, ff_add_format);
+    REDUCE_FORMATS(int,      AVFilterFormats,        samplerates,     formats,
+                   format_count, ff_add_format);
+    REDUCE_FORMATS(uint64_t, AVFilterChannelLayouts, channel_layouts,
+                   channel_layouts, nb_channel_layouts, ff_add_channel_layout);
 
-    return 0;
+    return ret;
 }
 
-static int link_filter(AVFilterGraph *ctx, int src, int srcpad,
-                       int dst, int dstpad)
+static void reduce_formats(AVFilterGraph *graph)
 {
-    AVFilterContext *filt, *filtb;
-
-    char tmp[20];
+    int i, reduced;
 
-    snprintf(tmp, 20, "%d", src);
-    if(!(filt = avfilter_graph_get_filter(ctx, tmp))) {
-        av_log(&log_ctx, AV_LOG_ERROR, "link source does not exist in graph\n");
-        return -1;
-    }
-    snprintf(tmp, 20, "%d", dst);
-    if(!(filtb = avfilter_graph_get_filter(ctx, tmp))) {
-        av_log(&log_ctx, AV_LOG_ERROR, "link destination does not exist in graph\n");
-        return -1;
-    }
-    if(avfilter_link(filt, srcpad, filtb, dstpad)) {
-        av_log(&log_ctx, AV_LOG_ERROR, "cannot create link between source and destination filters\n");
-        return -1;
-    }
+    do {
+        reduced = 0;
 
-    return 0;
+        for (i = 0; i < graph->filter_count; i++)
+            reduced |= reduce_formats_on_filter(graph->filters[i]);
+    } while (reduced);
 }
 
-static int load_from_desc(AVFilterGraph *graph, AVFilterGraphDesc *desc, AVFilterContext *in, int inpad, AVFilterContext *out, int outpad)
+static void swap_samplerates_on_filter(AVFilterContext *filter)
 {
-    AVFilterGraphDescExport *curpad;
-    char tmp[20];
-    AVFilterContext *filt;
-    AVFilterGraphDescFilter *curfilt;
-    AVFilterGraphDescLink   *curlink;
+    AVFilterLink *link = NULL;
+    int sample_rate;
+    int i, j;
 
+    for (i = 0; i < filter->input_count; i++) {
+        link = filter->inputs[i];
 
-    /* create all filters */
-    for(curfilt = desc->filters; curfilt; curfilt = curfilt->next) {
-        if (create_filter(graph, curfilt->index, curfilt->filter,
-                          curfilt->args) < 0)
-            goto fail;
+        if (link->type == AVMEDIA_TYPE_AUDIO &&
+            link->out_samplerates->format_count == 1)
+            break;
     }
+    if (i == filter->input_count)
+        return;
 
-    /* create all links */
-    for(curlink = desc->links; curlink; curlink = curlink->next) {
-        if (link_filter(graph, curlink->src, curlink->srcpad,
-                          curlink->dst, curlink->dstpad) < 0)
-            goto fail;
-    }
+    sample_rate = link->out_samplerates->formats[0];
 
-    /* export all input pads */
-    for(curpad = desc->inputs; curpad; curpad = curpad->next) {
-        snprintf(tmp, 20, "%d", curpad->filter);
-        if(!(filt = avfilter_graph_get_filter(graph, tmp))) {
-            av_log(&log_ctx, AV_LOG_ERROR, "filter owning exported pad does not exist\n");
-            goto fail;
-        }
-        if(avfilter_link(in, inpad, filt, curpad->pad)) {
-            av_log(&log_ctx, AV_LOG_ERROR, "cannot create link between source and destination filters\n");
-            goto fail;
-        }
-    }
+    for (i = 0; i < filter->output_count; i++) {
+        AVFilterLink *outlink = filter->outputs[i];
+        int best_idx, best_diff = INT_MAX;
 
-    /* export all output pads */
-    for(curpad = desc->outputs; curpad; curpad = curpad->next) {
-        snprintf(tmp, 20, "%d", curpad->filter);
-        if(!(filt = avfilter_graph_get_filter(graph, tmp))) {
-            av_log(&log_ctx, AV_LOG_ERROR, "filter owning exported pad does not exist\n");
-            goto fail;
-        }
+        if (outlink->type != AVMEDIA_TYPE_AUDIO ||
+            outlink->in_samplerates->format_count < 2)
+            continue;
 
-        if(avfilter_link(filt, curpad->pad, out, outpad)) {
-            av_log(&log_ctx, AV_LOG_ERROR, "cannot create link between source and destination filters\n");
-            goto fail;
+        for (j = 0; j < outlink->in_samplerates->format_count; j++) {
+            int diff = abs(sample_rate - outlink->in_samplerates->formats[j]);
+
+            if (diff < best_diff) {
+                best_diff = diff;
+                best_idx  = j;
+            }
         }
+        FFSWAP(int, outlink->in_samplerates->formats[0],
+               outlink->in_samplerates->formats[best_idx]);
     }
-
-    return 0;
-
-fail:
-    uninit(graph);
-    return -1;
-}
-
-
-static void consume_whitespace(const char **buf)
-{
-    *buf += strspn(*buf, " \n\t");
 }
 
-/**
- * get the next non-whitespace char
- */
-static char consume_char(const char **buf)
+static void swap_samplerates(AVFilterGraph *graph)
 {
-    char out;
-    consume_whitespace(buf);
-
-    out = **buf;
-
-    if (out)
-        (*buf)++;
+    int i;
 
-    return out;
+    for (i = 0; i < graph->filter_count; i++)
+        swap_samplerates_on_filter(graph->filters[i]);
 }
 
-/**
- * remove the quotation marks from a string. Ex: "aaa'bb'cc" -> "aaabbcc"
- */
-static void unquote(char *str)
+static void swap_channel_layouts_on_filter(AVFilterContext *filter)
 {
-    char *p1, *p2;
-    p1=p2=str;
-    while (*p1 != 0) {
-        if (*p1 != '\'')
-            *p2++ = *p1;
-        p1++;
-    }
+    AVFilterLink *link = NULL;
+    uint64_t chlayout;
+    int i, j;
 
-    *p2 = 0;
-}
+    for (i = 0; i < filter->input_count; i++) {
+        link = filter->inputs[i];
 
-/**
- * Consumes a string from *buf.
- * @return a copy of the consumed string, which should be free'd after use
- */
-static char *consume_string(const char **buf)
-{
-    const char *start;
-    char *ret;
-    int size;
+        if (link->type == AVMEDIA_TYPE_AUDIO &&
+            link->out_channel_layouts->nb_channel_layouts == 1)
+            break;
+    }
+    if (i == filter->input_count)
+        return;
 
-    consume_whitespace(buf);
+    chlayout = link->out_channel_layouts->channel_layouts[0];
 
-    if (!(**buf))
-        return av_mallocz(1);
+    for (i = 0; i < filter->output_count; i++) {
+        AVFilterLink *outlink = filter->outputs[i];
+        int best_idx, best_score = INT_MIN;
 
-    start = *buf;
+        if (outlink->type != AVMEDIA_TYPE_AUDIO ||
+            outlink->in_channel_layouts->nb_channel_layouts < 2)
+            continue;
 
-    *buf += strcspn(*buf, " ()=,'");
+        for (j = 0; j < outlink->in_channel_layouts->nb_channel_layouts; j++) {
+            uint64_t out_chlayout = outlink->in_channel_layouts->channel_layouts[j];
+            int matched_channels  = av_get_channel_layout_nb_channels(chlayout &
+                                                                      out_chlayout);
+            int extra_channels     = av_get_channel_layout_nb_channels(out_chlayout &
+                                                                       (~chlayout));
+            int score = matched_channels - extra_channels;
 
-    if (**buf == '\'') {
-        char *p = strchr(*buf + 1, '\'');
-        if (p)
-            *buf = p + 1;
-        else
-            *buf += strlen(*buf); // Move the pointer to the null end byte
+            if (score > best_score) {
+                best_score = score;
+                best_idx   = j;
+            }
+        }
+        FFSWAP(uint64_t, outlink->in_channel_layouts->channel_layouts[0],
+               outlink->in_channel_layouts->channel_layouts[best_idx]);
     }
 
-    size = *buf - start + 1;
-    ret = av_malloc(size);
-    memcpy(ret, start, size - 1);
-    ret[size-1] = 0;
+}
 
-    unquote(ret);
+static void swap_channel_layouts(AVFilterGraph *graph)
+{
+    int i;
 
-    return ret;
+    for (i = 0; i < graph->filter_count; i++)
+        swap_channel_layouts_on_filter(graph->filters[i]);
 }
 
-/**
- * Parse "(linkname)"
- * @arg name a pointer (that need to be free'd after use) to the name between
- *           parenthesis
- */
-static void parse_link_name(const char **buf, char **name)
+static void swap_sample_fmts_on_filter(AVFilterContext *filter)
 {
-    consume_char(buf);
+    AVFilterLink *link = NULL;
+    int format, bps;
+    int i, j;
 
-    *name = consume_string(buf);
+    for (i = 0; i < filter->input_count; i++) {
+        link = filter->inputs[i];
 
-    if (!*name[0])
-        goto fail;
+        if (link->type == AVMEDIA_TYPE_AUDIO &&
+            link->out_formats->format_count == 1)
+            break;
+    }
+    if (i == filter->input_count)
+        return;
 
-    if (consume_char(buf) != ')')
-        goto fail;
+    format = link->out_formats->formats[0];
+    bps    = av_get_bytes_per_sample(format);
 
-    return;
- fail:
-    av_freep(name);
-    av_log(&log_ctx, AV_LOG_ERROR, "Could not parse link name!\n");
-}
+    for (i = 0; i < filter->output_count; i++) {
+        AVFilterLink *outlink = filter->outputs[i];
+        int best_idx, best_score = INT_MIN;
 
-/**
- * Parse "filter=params"
- * @arg name a pointer (that need to be free'd after use) to the name of the
- *           filter
- * @arg ars  a pointer (that need to be free'd after use) to the args of the
- *           filter
- */
-static void parse_filter(const char **buf, char **name, char **opts)
-{
-    *name = consume_string(buf);
-
-    if (**buf == '=') {
-        consume_char(buf);
-        *opts = consume_string(buf);
-    } else {
-        *opts = NULL;
-    }
+        if (outlink->type != AVMEDIA_TYPE_AUDIO ||
+            outlink->in_formats->format_count < 2)
+            continue;
 
-}
+        for (j = 0; j < outlink->in_formats->format_count; j++) {
+            int out_format = outlink->in_formats->formats[j];
+            int out_bps    = av_get_bytes_per_sample(out_format);
+            int score;
 
-enum LinkType {
-    LinkTypeIn,
-    LinkTypeOut,
-};
+            if (av_get_packed_sample_fmt(out_format) == format ||
+                av_get_planar_sample_fmt(out_format) == format) {
+                best_idx   = j;
+                break;
+            }
 
-/**
- * A linked-list of the inputs/outputs of the filter chain.
- */
-typedef struct AVFilterInOut {
-    enum LinkType type;
-    char *name;
-    int instance;
-    int pad_idx;
+            /* for s32 and float prefer double to prevent loss of information */
+            if (bps == 4 && out_bps == 8) {
+                best_idx = j;
+                break;
+            }
 
-    struct AVFilterInOut *next;
-} AVFilterInOut;
+            /* prefer closest higher or equal bps */
+            score = -abs(out_bps - bps);
+            if (out_bps >= bps)
+                score += INT_MAX/2;
 
-static void free_inout(AVFilterInOut *head)
-{
-    while (head) {
-        AVFilterInOut *next;
-        next = head->next;
-        av_free(head);
-        head = next;
+            if (score > best_score) {
+                best_score = score;
+                best_idx   = j;
+            }
+        }
+        FFSWAP(int, outlink->in_formats->formats[0],
+               outlink->in_formats->formats[best_idx]);
     }
 }
 
-/**
- * Parse "(a1)(link2) ... (etc)"
- */
-static int parse_inouts(const char **buf, AVFilterInOut **inout, int firstpad,
-                        enum LinkType type, int instance)
+static void swap_sample_fmts(AVFilterGraph *graph)
 {
-    int pad = firstpad;
-    while (**buf == '(') {
-        AVFilterInOut *inoutn = av_malloc(sizeof(AVFilterInOut));
-        parse_link_name(buf, &inoutn->name);
-        inoutn->type = type;
-        inoutn->instance = instance;
-        inoutn->pad_idx = pad++;
-        inoutn->next = *inout;
-        *inout = inoutn;
-    }
-    return pad;
+    int i;
+
+    for (i = 0; i < graph->filter_count; i++)
+        swap_sample_fmts_on_filter(graph->filters[i]);
+
 }
 
-/**
- * Free a graph description.
- */
-static void free_desc(AVFilterGraphDesc *desc)
+static int pick_formats(AVFilterGraph *graph)
 {
-    void *next;
-
-    while(desc->filters) {
-        next = desc->filters->next;
-        av_free(desc->filters->filter);
-        av_free(desc->filters->args);
-        av_free(desc->filters);
-        desc->filters = next;
-    }
+    int i, j, ret;
 
-    while(desc->links) {
-        next = desc->links->next;
-        av_free(desc->links);
-        desc->links = next;
-    }
-
-    while(desc->inputs) {
-        next = desc->inputs->next;
-        av_free(desc->inputs);
-        desc->inputs = next;
-    }
+    for (i = 0; i < graph->filter_count; i++) {
+        AVFilterContext *filter = graph->filters[i];
 
-    while(desc->outputs) {
-        next = desc->outputs->next;
-        av_free(desc->outputs);
-        desc->outputs = next;
+        for (j = 0; j < filter->input_count; j++)
+            if ((ret = pick_format(filter->inputs[j])) < 0)
+                return ret;
+        for (j = 0; j < filter->output_count; j++)
+            if ((ret = pick_format(filter->outputs[j])) < 0)
+                return ret;
     }
+    return 0;
 }
 
-static AVFilterGraphDesc *parse_chain(const char *filters, int has_in)
+/**
+ * Configure the formats of all the links in the graph.
+ */
+static int graph_config_formats(AVFilterGraph *graph, AVClass *log_ctx)
 {
-    AVFilterGraphDesc        *ret;
-    AVFilterGraphDescFilter **filterp, *filtern;
-    AVFilterGraphDescLink   **linkp,   *linkn;
-    AVFilterInOut           *inout=NULL;
-    AVFilterInOut           *head;
-
-    int index = 0;
-    char chr = 0;
-    int pad = 0;
-    int has_out = 0;
-
-    consume_whitespace(&filters);
-
-    if(!(ret = av_mallocz(sizeof(AVFilterGraphDesc))))
-        return NULL;
-
-    filterp = &ret->filters;
-    linkp   = &ret->links;
+    int ret;
 
-    do {
-        if(chr == ',') {
-            linkn = av_mallocz(sizeof(AVFilterGraphDescLink));
-            linkn->src = index-1;
-            linkn->srcpad = pad;
-            linkn->dst = index;
-            linkn->dstpad = 0;
-
-            *linkp = linkn;
-            linkp = &linkn->next;
-        }
-        pad = parse_inouts(&filters, &inout, chr == ',' || (!has_in),
-                           LinkTypeIn, index);
-
-        filtern = av_mallocz(sizeof(AVFilterGraphDescFilter));
-        filtern->index = index;
-        parse_filter(&filters, &filtern->filter, &filtern->args);
-        *filterp = filtern;
-        filterp = &filtern->next;
-
-        pad = parse_inouts(&filters, &inout, 0,
-                           LinkTypeOut, index);
-        chr = consume_char(&filters);
-        index++;
-    } while (chr == ',' || chr == ';');
-
-    head = inout;
-    for (; inout != NULL; inout = inout->next) {
-        if (inout->instance == -1)
-            continue; // Already processed
-
-        if (!strcmp(inout->name, "in")) {
-            if (!has_in)
-                goto fail;
-            ret->inputs = av_mallocz(sizeof(AVFilterGraphDescExport));
-            ret->inputs->filter = inout->instance;
-            ret->inputs->pad = inout->pad_idx;
-        } else if (!strcmp(inout->name, "out")) {
-            has_out = 1;
-            ret->outputs = av_mallocz(sizeof(AVFilterGraphDescExport));
-            ret->outputs->filter = inout->instance;
-            ret->outputs->pad = inout->pad_idx;
-        } else {
-            AVFilterInOut *p, *src, *dst;
-            for (p = inout->next;
-                 p && strcmp(p->name,inout->name); p = p->next);
-
-            if (!p) {
-                av_log(&log_ctx, AV_LOG_ERROR, "Unmatched link: %s.\n",
-                       inout->name);
-                goto fail;
-            }
-
-            if (p->type == LinkTypeIn && inout->type == LinkTypeOut) {
-                src = inout;
-                dst = p;
-            } else if (p->type == LinkTypeOut && inout->type == LinkTypeIn) {
-                src = p;
-                dst = inout;
-            } else {
-                av_log(&log_ctx, AV_LOG_ERROR, "Two links named '%s' are either both input or both output\n",
-                       inout->name);
-                goto fail;
-            }
-            linkn = av_mallocz(sizeof(AVFilterGraphDescLink));
-
-            linkn->src = src->instance;
-            linkn->srcpad = src->pad_idx;
-            linkn->dst = dst->instance;
-            linkn->dstpad = dst->pad_idx;
-
-            *linkp = linkn;
-            linkp = &linkn->next;
-
-            src->instance = -1;
-            dst->instance = -1;
-        }
-    }
-
-    free_inout(head);
+    /* find supported formats from sub-filters, and merge along links */
+    if ((ret = query_formats(graph, log_ctx)) < 0)
+        return ret;
 
-    if (!has_in) {
-        ret->inputs = av_mallocz(sizeof(AVFilterGraphDescExport));
-        ret->inputs->filter = 0;
-    }
-    if (!has_out) {
-        ret->outputs = av_mallocz(sizeof(AVFilterGraphDescExport));
-        ret->outputs->filter = index-1;
-    }
+    /* Once everything is merged, it's possible that we'll still have
+     * multiple valid media format choices. We try to minimize the amount
+     * of format conversion inside filters */
+    reduce_formats(graph);
 
-    return ret;
+    /* for audio filters, ensure the best format, sample rate and channel layout
+     * is selected */
+    swap_sample_fmts(graph);
+    swap_samplerates(graph);
+    swap_channel_layouts(graph);
 
- fail:
-    free_inout(head);
+    if ((ret = pick_formats(graph)) < 0)
+        return ret;
 
-    free_desc(ret);
-    return NULL;
+    return 0;
 }
 
-/**
- * Parse a string describing a filter graph.
- */
-int avfilter_graph_parse_chain(AVFilterGraph *graph, const char *filters, AVFilterContext *in, int inpad, AVFilterContext *out, int outpad)
+int avfilter_graph_config(AVFilterGraph *graphctx, void *log_ctx)
 {
-    AVFilterGraphDesc *desc;
+    int ret;
 
-    /* Try first to parse supposing there is no (in) element */
-    if (!(desc = parse_chain(filters, 0))) {
-        /* If it didn't work, parse supposing there is an (in) element */
-        desc = parse_chain(filters, 1);
-    }
-    if (!desc)
-        return -1;
-
-    if (load_from_desc(graph, desc, in, inpad, out, outpad) < 0) {
-        free_desc(desc);
-        return -1;
-    }
+    if ((ret = graph_check_validity(graphctx, log_ctx)))
+        return ret;
+    if ((ret = graph_config_formats(graphctx, log_ctx)))
+        return ret;
+    if ((ret = graph_config_links(graphctx, log_ctx)))
+        return ret;
 
-    free_desc(desc);
     return 0;
 }