if (!value)
goto finish;
- if (type == 0) { // UTF16-LE
+ switch (type) {
+ case ASF_UNICODE:
avio_get_str16le(s->pb, len, value, 2 * len + 1);
- } else if (type == -1) { // ASCII
+ break;
+ case -1: // ASCI
avio_read(s->pb, value, len);
value[len]=0;
- } else if (type == 1) { // byte array
+ break;
+ case ASF_BYTE_ARRAY:
if (!strcmp(key, "WM/Picture")) { // handle cover art
asf_read_picture(s, len);
} else if (!strcmp(key, "ID3")) { // handle ID3 tag
av_log(s, AV_LOG_VERBOSE, "Unsupported byte array in tag %s.\n", key);
}
goto finish;
- } else if (type > 1 && type <= 5) { // boolean or DWORD or QWORD or WORD
+ case ASF_BOOL:
+ case ASF_DWORD:
+ case ASF_QWORD:
+ case ASF_WORD: {
uint64_t num = get_value(s->pb, type, type2_size);
snprintf(value, LEN, "%"PRIu64, num);
- } else if (type == 6) { // (don't) handle GUID
+ break;
+ }
+ case ASF_GUID:
av_log(s, AV_LOG_DEBUG, "Unsupported GUID value in tag %s.\n", key);
goto finish;
- } else {
+ default:
av_log(s, AV_LOG_DEBUG,
"Unsupported value type %d in tag %s.\n", type, key);
goto finish;
{
AVIOContext *pb = s->pb;
ASFContext *asf = s->priv_data;
- int n, stream_num, name_len, value_len;
+ int n, stream_num, name_len_utf16, name_len_utf8, value_len;
int ret, i;
n = avio_rl16(pb);
for (i = 0; i < n; i++) {
- char name[1024];
+ uint8_t *name;
int value_type;
avio_rl16(pb); // lang_list_index
stream_num = avio_rl16(pb);
- name_len = avio_rl16(pb);
+ name_len_utf16 = avio_rl16(pb);
value_type = avio_rl16(pb); /* value_type */
value_len = avio_rl32(pb);
- if ((ret = avio_get_str16le(pb, name_len, name, sizeof(name))) < name_len)
- avio_skip(pb, name_len - ret);
+ name_len_utf8 = 2*name_len_utf16 + 1;
+ name = av_malloc(name_len_utf8);
+ if (!name)
+ return AVERROR(ENOMEM);
+
+ if ((ret = avio_get_str16le(pb, name_len_utf16, name, name_len_utf8)) < name_len_utf16)
+ avio_skip(pb, name_len_utf16 - ret);
av_log(s, AV_LOG_TRACE, "%d stream %d name_len %2d type %d len %4d <%s>\n",
- i, stream_num, name_len, value_type, value_len, name);
+ i, stream_num, name_len_utf16, value_type, value_len, name);
if (!strcmp(name, "AspectRatioX")){
int aspect_x = get_value(s->pb, value_type, 16);
} else {
get_tag(s, name, value_type, value_len, 16);
}
+ av_freep(&name);
}
return 0;