New upstream snapshot

[bcachefs-tools-debian] / libbcachefs / acl.c

diff --git a/libbcachefs/acl.c b/libbcachefs/acl.c
index eb907e5d33d3fcf364f0f977d390d916336d391d..5070caf8f349adbec532ae966346fe22e6fda142 100644 (file)
--- a/libbcachefs/acl.c
+++ b/libbcachefs/acl.c
@@ -212,36 +212,38 @@ bch2_acl_to_xattr(struct btree_trans *trans,
        return xattr;
 }
 
-struct posix_acl *bch2_get_acl(struct inode *vinode, int type)
+struct posix_acl *bch2_get_acl(struct inode *vinode, int type, bool rcu)
 {
        struct bch_inode_info *inode = to_bch_ei(vinode);
        struct bch_fs *c = inode->v.i_sb->s_fs_info;
        struct bch_hash_info hash = bch2_hash_info_init(c, &inode->ei_inode);
        struct btree_trans trans;
-       struct btree_iter *iter;
+       struct btree_iter iter = { NULL };
        struct bkey_s_c_xattr xattr;
        struct posix_acl *acl = NULL;
        struct bkey_s_c k;
        int ret;
 
+       if (rcu)
+               return ERR_PTR(-ECHILD);
+
        bch2_trans_init(&trans, c, 0, 0);
 retry:
        bch2_trans_begin(&trans);
 
-       iter = bch2_hash_lookup(&trans, bch2_xattr_hash_desc,
-                       &hash, inode->v.i_ino,
+       ret = bch2_hash_lookup(&trans, &iter, bch2_xattr_hash_desc,
+                       &hash, inode_inum(inode),
                        &X_SEARCH(acl_to_xattr_type(type), "", 0),
                        0);
-       if (IS_ERR(iter)) {
-               if (PTR_ERR(iter) == -EINTR)
+       if (ret) {
+               if (ret == -EINTR)
                        goto retry;
-
-               if (PTR_ERR(iter) != -ENOENT)
-                       acl = ERR_CAST(iter);
+               if (ret != -ENOENT)
+                       acl = ERR_PTR(ret);
                goto out;
        }
 
-       k = bch2_btree_iter_peek_slot(iter);
+       k = bch2_btree_iter_peek_slot(&iter);
        ret = bkey_err(k);
        if (ret) {
                acl = ERR_PTR(ret);
@@ -254,17 +256,17 @@ retry:
 
        if (!IS_ERR(acl))
                set_cached_acl(&inode->v, type, acl);
-       bch2_trans_iter_put(&trans, iter);
 out:
+       bch2_trans_iter_exit(&trans, &iter);
        bch2_trans_exit(&trans);
        return acl;
 }
 
-int bch2_set_acl_trans(struct btree_trans *trans,
+int bch2_set_acl_trans(struct btree_trans *trans, subvol_inum inum,
                       struct bch_inode_unpacked *inode_u,
-                      const struct bch_hash_info *hash_info,
                       struct posix_acl *acl, int type)
 {
+       struct bch_hash_info hash_info = bch2_hash_info_init(trans->c, inode_u);
        int ret;
 
        if (type == ACL_TYPE_DEFAULT &&
@@ -277,14 +279,14 @@ int bch2_set_acl_trans(struct btree_trans *trans,
                if (IS_ERR(xattr))
                        return PTR_ERR(xattr);
 
-               ret = bch2_hash_set(trans, bch2_xattr_hash_desc, hash_info,
-                                   inode_u->bi_inum, &xattr->k_i, 0);
+               ret = bch2_hash_set(trans, bch2_xattr_hash_desc, &hash_info,
+                                   inum, &xattr->k_i, 0);
        } else {
                struct xattr_search_key search =
                        X_SEARCH(acl_to_xattr_type(type), "", 0);
 
-               ret = bch2_hash_delete(trans, bch2_xattr_hash_desc, hash_info,
-                                      inode_u->bi_inum, &search);
+               ret = bch2_hash_delete(trans, bch2_xattr_hash_desc, &hash_info,
+                                      inum, &search);
        }
 
        return ret == -ENOENT ? 0 : ret;
@@ -296,9 +298,8 @@ int bch2_set_acl(struct user_namespace *mnt_userns,
        struct bch_inode_info *inode = to_bch_ei(vinode);
        struct bch_fs *c = inode->v.i_sb->s_fs_info;
        struct btree_trans trans;
-       struct btree_iter *inode_iter;
+       struct btree_iter inode_iter = { NULL };
        struct bch_inode_unpacked inode_u;
-       struct bch_hash_info hash_info;
        struct posix_acl *acl;
        umode_t mode;
        int ret;
@@ -309,9 +310,8 @@ retry:
        bch2_trans_begin(&trans);
        acl = _acl;
 
-       inode_iter = bch2_inode_peek(&trans, &inode_u, inode->v.i_ino,
-                                    BTREE_ITER_INTENT);
-       ret = PTR_ERR_OR_ZERO(inode_iter);
+       ret = bch2_inode_peek(&trans, &inode_iter, &inode_u, inode_inum(inode),
+                             BTREE_ITER_INTENT);
        if (ret)
                goto btree_err;
 
@@ -323,27 +323,24 @@ retry:
                        goto btree_err;
        }
 
-       hash_info = bch2_hash_info_init(c, &inode_u);
-
-       ret = bch2_set_acl_trans(&trans, &inode_u, &hash_info, acl, type);
+       ret = bch2_set_acl_trans(&trans, inode_inum(inode), &inode_u, acl, type);
        if (ret)
                goto btree_err;
 
        inode_u.bi_ctime        = bch2_current_time(c);
        inode_u.bi_mode         = mode;
 
-       ret =   bch2_inode_write(&trans, inode_iter, &inode_u) ?:
-               bch2_trans_commit(&trans, NULL,
-                                 &inode->ei_journal_seq, 0);
+       ret =   bch2_inode_write(&trans, &inode_iter, &inode_u) ?:
+               bch2_trans_commit(&trans, NULL, NULL, 0);
 btree_err:
-       bch2_trans_iter_put(&trans, inode_iter);
+       bch2_trans_iter_exit(&trans, &inode_iter);
 
        if (ret == -EINTR)
                goto retry;
        if (unlikely(ret))
                goto err;
 
-       bch2_inode_update_after_write(c, inode, &inode_u,
+       bch2_inode_update_after_write(&trans, inode, &inode_u,
                                      ATTR_CTIME|ATTR_MODE);
 
        set_cached_acl(&inode->v, type, acl);
@@ -354,28 +351,27 @@ err:
        return ret;
 }
 
-int bch2_acl_chmod(struct btree_trans *trans,
+int bch2_acl_chmod(struct btree_trans *trans, subvol_inum inum,
                   struct bch_inode_unpacked *inode,
                   umode_t mode,
                   struct posix_acl **new_acl)
 {
        struct bch_hash_info hash_info = bch2_hash_info_init(trans->c, inode);
-       struct btree_iter *iter;
+       struct btree_iter iter;
        struct bkey_s_c_xattr xattr;
        struct bkey_i_xattr *new;
        struct posix_acl *acl;
        struct bkey_s_c k;
        int ret;
 
-       iter = bch2_hash_lookup(trans, bch2_xattr_hash_desc,
-                       &hash_info, inode->bi_inum,
+       ret = bch2_hash_lookup(trans, &iter, bch2_xattr_hash_desc,
+                              &hash_info, inum,
                        &X_SEARCH(KEY_TYPE_XATTR_INDEX_POSIX_ACL_ACCESS, "", 0),
                        BTREE_ITER_INTENT);
-       ret = PTR_ERR_OR_ZERO(iter);
        if (ret)
                return ret == -ENOENT ? 0 : ret;
 
-       k = bch2_btree_iter_peek_slot(iter);
+       k = bch2_btree_iter_peek_slot(&iter);
        xattr = bkey_s_c_to_xattr(k);
        if (ret)
                goto err;
@@ -396,12 +392,12 @@ int bch2_acl_chmod(struct btree_trans *trans,
                goto err;
        }
 
-       new->k.p = iter->pos;
-       ret = bch2_trans_update(trans, iter, &new->k_i, 0);
+       new->k.p = iter.pos;
+       ret = bch2_trans_update(trans, &iter, &new->k_i, 0);
        *new_acl = acl;
        acl = NULL;
 err:
-       bch2_trans_iter_put(trans, iter);
+       bch2_trans_iter_exit(trans, &iter);
        if (!IS_ERR_OR_NULL(acl))
                kfree(acl);
        return ret;