]> git.sesse.net Git - bcachefs-tools-debian/blobdiff - libbcachefs/btree_iter.h
Disable pristine-tar option in gbp.conf, since there is no pristine-tar branch.
[bcachefs-tools-debian] / libbcachefs / btree_iter.h
index 4ec873aa1f58923bd4ff0edc18799e0e6e2e3443..24772538e4cc74ada59851bd7847dd5ece5ea122 100644 (file)
@@ -4,8 +4,14 @@
 
 #include "bset.h"
 #include "btree_types.h"
+#include "trace.h"
 
-#include <trace/events/bcachefs.h>
+static inline int __bkey_err(const struct bkey *k)
+{
+       return PTR_ERR_OR_ZERO(k);
+}
+
+#define bkey_err(_k)   __bkey_err((_k).k)
 
 static inline void __btree_path_get(struct btree_path *path, bool intent)
 {
@@ -36,14 +42,7 @@ static inline struct btree *btree_path_node(struct btree_path *path,
 static inline bool btree_node_lock_seq_matches(const struct btree_path *path,
                                        const struct btree *b, unsigned level)
 {
-       /*
-        * We don't compare the low bits of the lock sequence numbers because
-        * @path might have taken a write lock on @b, and we don't want to skip
-        * the linked path if the sequence numbers were equal before taking that
-        * write lock. The lock sequence number is incremented by taking and
-        * releasing write locks and is even when unlocked:
-        */
-       return path->l[level].lock_seq >> 1 == b->c.lock.state.seq >> 1;
+       return path->l[level].lock_seq == six_lock_seq(&b->c.lock);
 }
 
 static inline struct btree *btree_node_parent(struct btree_path *path,
@@ -54,33 +53,67 @@ static inline struct btree *btree_node_parent(struct btree_path *path,
 
 /* Iterate over paths within a transaction: */
 
-static inline struct btree_path *
-__trans_next_path(struct btree_trans *trans, unsigned idx)
-{
-       u64 l;
+void __bch2_btree_trans_sort_paths(struct btree_trans *);
 
-       if (idx == BTREE_ITER_MAX)
-               return NULL;
+static inline void btree_trans_sort_paths(struct btree_trans *trans)
+{
+       if (!IS_ENABLED(CONFIG_BCACHEFS_DEBUG) &&
+           trans->paths_sorted)
+               return;
+       __bch2_btree_trans_sort_paths(trans);
+}
 
-       l = trans->paths_allocated >> idx;
-       if (!l)
-               return NULL;
+static inline unsigned long *trans_paths_nr(struct btree_path *paths)
+{
+       return &container_of(paths, struct btree_trans_paths, paths[0])->nr_paths;
+}
 
-       idx += __ffs64(l);
-       EBUG_ON(idx >= BTREE_ITER_MAX);
-       EBUG_ON(trans->paths[idx].idx != idx);
-       return &trans->paths[idx];
+static inline unsigned long *trans_paths_allocated(struct btree_path *paths)
+{
+       unsigned long *v = trans_paths_nr(paths);
+       return v - BITS_TO_LONGS(*v);
 }
 
-void bch2_btree_path_check_sort(struct btree_trans *, struct btree_path *, int);
+#define trans_for_each_path_idx_from(_paths_allocated, _nr, _idx, _start)\
+       for (_idx = _start;                                             \
+            (_idx = find_next_bit(_paths_allocated, _nr, _idx)) < _nr; \
+            _idx++)
 
-#define trans_for_each_path_from(_trans, _path, _start)                        \
-       for (_path = __trans_next_path((_trans), _start);               \
-            (_path);                                                   \
-            _path = __trans_next_path((_trans), (_path)->idx + 1))
+static inline struct btree_path *
+__trans_next_path(struct btree_trans *trans, unsigned *idx)
+{
+       unsigned long *w = trans->paths_allocated + *idx / BITS_PER_LONG;
+       /*
+        * Open coded find_next_bit(), because
+        *  - this is fast path, we can't afford the function call
+        *  - and we know that nr_paths is a multiple of BITS_PER_LONG,
+        */
+       while (*idx < trans->nr_paths) {
+               unsigned long v = *w >> (*idx & (BITS_PER_LONG - 1));
+               if (v) {
+                       *idx += __ffs(v);
+                       return trans->paths + *idx;
+               }
+
+               *idx += BITS_PER_LONG;
+               *idx &= ~(BITS_PER_LONG - 1);
+               w++;
+       }
 
-#define trans_for_each_path(_trans, _path)                             \
-       trans_for_each_path_from(_trans, _path, 0)
+       return NULL;
+}
+
+/*
+ * This version is intended to be safe for use on a btree_trans that is owned by
+ * another thread, for bch2_btree_trans_to_text();
+ */
+#define trans_for_each_path_from(_trans, _path, _idx, _start)          \
+       for (_idx = _start;                                             \
+            (_path = __trans_next_path((_trans), &_idx));              \
+            _idx++)
+
+#define trans_for_each_path(_trans, _path, _idx)                       \
+       trans_for_each_path_from(_trans, _path, _idx, 1)
 
 static inline struct btree_path *next_btree_path(struct btree_trans *trans, struct btree_path *path)
 {
@@ -95,16 +128,35 @@ static inline struct btree_path *next_btree_path(struct btree_trans *trans, stru
 
 static inline struct btree_path *prev_btree_path(struct btree_trans *trans, struct btree_path *path)
 {
-       EBUG_ON(path->sorted_idx >= trans->nr_sorted);
-       return path->sorted_idx
-               ? trans->paths + trans->sorted[path->sorted_idx - 1]
+       unsigned idx = path ? path->sorted_idx : trans->nr_sorted;
+
+       return idx
+               ? trans->paths + trans->sorted[idx - 1]
                : NULL;
 }
 
-#define trans_for_each_path_inorder(_trans, _path, _i)                 \
-       for (_i = 0;                                                    \
-            ((_path) = (_trans)->paths + trans->sorted[_i]), (_i) < (_trans)->nr_sorted;\
-            _i++)
+#define trans_for_each_path_idx_inorder(_trans, _iter)                 \
+       for (_iter = (struct trans_for_each_path_inorder_iter) { 0 };   \
+            (_iter.path_idx = trans->sorted[_iter.sorted_idx],         \
+             _iter.sorted_idx < (_trans)->nr_sorted);                  \
+            _iter.sorted_idx++)
+
+struct trans_for_each_path_inorder_iter {
+       btree_path_idx_t        sorted_idx;
+       btree_path_idx_t        path_idx;
+};
+
+#define trans_for_each_path_inorder(_trans, _path, _iter)              \
+       for (_iter = (struct trans_for_each_path_inorder_iter) { 0 };   \
+            (_iter.path_idx = trans->sorted[_iter.sorted_idx],         \
+             _path = (_trans)->paths + _iter.path_idx,                 \
+             _iter.sorted_idx < (_trans)->nr_sorted);                  \
+            _iter.sorted_idx++)
+
+#define trans_for_each_path_inorder_reverse(_trans, _path, _i)         \
+       for (_i = trans->nr_sorted - 1;                                 \
+            ((_path) = (_trans)->paths + trans->sorted[_i]), (_i) >= 0;\
+            --_i)
 
 static inline bool __path_has_node(const struct btree_path *path,
                                   const struct btree *b)
@@ -115,39 +167,97 @@ static inline bool __path_has_node(const struct btree_path *path,
 
 static inline struct btree_path *
 __trans_next_path_with_node(struct btree_trans *trans, struct btree *b,
-                           unsigned idx)
+                           unsigned *idx)
 {
-       struct btree_path *path = __trans_next_path(trans, idx);
+       struct btree_path *path;
 
-       while (path && !__path_has_node(path, b))
-               path = __trans_next_path(trans, path->idx + 1);
+       while ((path = __trans_next_path(trans, idx)) &&
+               !__path_has_node(path, b))
+              (*idx)++;
 
        return path;
 }
 
-#define trans_for_each_path_with_node(_trans, _b, _path)               \
-       for (_path = __trans_next_path_with_node((_trans), (_b), 0);    \
-            (_path);                                                   \
-            _path = __trans_next_path_with_node((_trans), (_b),        \
-                                                (_path)->idx + 1))
-
-struct btree_path * __must_check
-bch2_btree_path_make_mut(struct btree_trans *, struct btree_path *,
-                        bool, unsigned long);
-struct btree_path * __must_check
-bch2_btree_path_set_pos(struct btree_trans *, struct btree_path *,
-                       struct bpos, bool, unsigned long);
-int __must_check bch2_btree_path_traverse(struct btree_trans *,
-                                         struct btree_path *, unsigned);
-struct btree_path *bch2_path_get(struct btree_trans *, enum btree_id, struct bpos,
+#define trans_for_each_path_with_node(_trans, _b, _path, _iter)                \
+       for (_iter = 1;                                                 \
+            (_path = __trans_next_path_with_node((_trans), (_b), &_iter));\
+            _iter++)
+
+btree_path_idx_t __bch2_btree_path_make_mut(struct btree_trans *, btree_path_idx_t,
+                                           bool, unsigned long);
+
+static inline btree_path_idx_t __must_check
+bch2_btree_path_make_mut(struct btree_trans *trans,
+                        btree_path_idx_t path, bool intent,
+                        unsigned long ip)
+{
+       if (trans->paths[path].ref > 1 ||
+           trans->paths[path].preserve)
+               path = __bch2_btree_path_make_mut(trans, path, intent, ip);
+       trans->paths[path].should_be_locked = false;
+       return path;
+}
+
+btree_path_idx_t __must_check
+__bch2_btree_path_set_pos(struct btree_trans *, btree_path_idx_t,
+                         struct bpos, bool, unsigned long);
+
+static inline btree_path_idx_t __must_check
+bch2_btree_path_set_pos(struct btree_trans *trans,
+                       btree_path_idx_t path, struct bpos new_pos,
+                       bool intent, unsigned long ip)
+{
+       return !bpos_eq(new_pos, trans->paths[path].pos)
+               ? __bch2_btree_path_set_pos(trans, path, new_pos, intent, ip)
+               : path;
+}
+
+int __must_check bch2_btree_path_traverse_one(struct btree_trans *,
+                                             btree_path_idx_t,
+                                             unsigned, unsigned long);
+
+static inline int __must_check bch2_btree_path_traverse(struct btree_trans *trans,
+                                         btree_path_idx_t path, unsigned flags)
+{
+       if (trans->paths[path].uptodate < BTREE_ITER_NEED_RELOCK)
+               return 0;
+
+       return bch2_btree_path_traverse_one(trans, path, flags, _RET_IP_);
+}
+
+btree_path_idx_t bch2_path_get(struct btree_trans *, enum btree_id, struct bpos,
                                 unsigned, unsigned, unsigned, unsigned long);
-inline struct bkey_s_c bch2_btree_path_peek_slot(struct btree_path *, struct bkey *);
+struct bkey_s_c bch2_btree_path_peek_slot(struct btree_path *, struct bkey *);
+
+/*
+ * bch2_btree_path_peek_slot() for a cached iterator might return a key in a
+ * different snapshot:
+ */
+static inline struct bkey_s_c bch2_btree_path_peek_slot_exact(struct btree_path *path, struct bkey *u)
+{
+       struct bkey_s_c k = bch2_btree_path_peek_slot(path, u);
+
+       if (k.k && bpos_eq(path->pos, k.k->p))
+               return k;
+
+       bkey_init(u);
+       u->p = path->pos;
+       return (struct bkey_s_c) { u, NULL };
+}
 
 struct bkey_i *bch2_btree_journal_peek_slot(struct btree_trans *,
                                        struct btree_iter *, struct bpos);
 
-inline void bch2_btree_path_level_init(struct btree_trans *,
-                                      struct btree_path *, struct btree *);
+void bch2_btree_path_level_init(struct btree_trans *, struct btree_path *, struct btree *);
+
+int __bch2_trans_mutex_lock(struct btree_trans *, struct mutex *);
+
+static inline int bch2_trans_mutex_lock(struct btree_trans *trans, struct mutex *lock)
+{
+       return mutex_trylock(lock)
+               ? 0
+               : __bch2_trans_mutex_lock(trans, lock);
+}
 
 #ifdef CONFIG_BCACHEFS_DEBUG
 void bch2_trans_verify_paths(struct btree_trans *);
@@ -167,30 +277,51 @@ void bch2_btree_node_iter_fix(struct btree_trans *trans, struct btree_path *,
 
 int bch2_btree_path_relock_intent(struct btree_trans *, struct btree_path *);
 
-void bch2_path_put(struct btree_trans *, struct btree_path *, bool);
+void bch2_path_put(struct btree_trans *, btree_path_idx_t, bool);
 
 int bch2_trans_relock(struct btree_trans *);
+int bch2_trans_relock_notrace(struct btree_trans *);
 void bch2_trans_unlock(struct btree_trans *);
+void bch2_trans_unlock_long(struct btree_trans *);
+bool bch2_trans_locked(struct btree_trans *);
+
+static inline int trans_was_restarted(struct btree_trans *trans, u32 restart_count)
+{
+       return restart_count != trans->restart_count
+               ? -BCH_ERR_transaction_restart_nested
+               : 0;
+}
+
+void __noreturn bch2_trans_restart_error(struct btree_trans *, u32);
 
-static inline bool trans_was_restarted(struct btree_trans *trans, u32 restart_count)
+static inline void bch2_trans_verify_not_restarted(struct btree_trans *trans,
+                                                  u32 restart_count)
 {
-       return restart_count != trans->restart_count;
+       if (trans_was_restarted(trans, restart_count))
+               bch2_trans_restart_error(trans, restart_count);
 }
 
-void bch2_trans_verify_not_restarted(struct btree_trans *, u32);
+void __noreturn bch2_trans_in_restart_error(struct btree_trans *);
+
+static inline void bch2_trans_verify_not_in_restart(struct btree_trans *trans)
+{
+       if (trans->restarted)
+               bch2_trans_in_restart_error(trans);
+}
 
 __always_inline
-static inline int btree_trans_restart_nounlock(struct btree_trans *trans, int err)
+static int btree_trans_restart_nounlock(struct btree_trans *trans, int err)
 {
        BUG_ON(err <= 0);
-       BUG_ON(!bch2_err_matches(err, BCH_ERR_transaction_restart));
+       BUG_ON(!bch2_err_matches(-err, BCH_ERR_transaction_restart));
 
        trans->restarted = err;
+       trans->last_restarted_ip = _THIS_IP_;
        return -err;
 }
 
 __always_inline
-static inline int btree_trans_restart(struct btree_trans *trans, int err)
+static int btree_trans_restart(struct btree_trans *trans, int err)
 {
        btree_trans_restart_nounlock(trans, err);
        return -err;
@@ -212,20 +343,19 @@ static inline void bch2_btree_path_downgrade(struct btree_trans *trans,
 
 void bch2_trans_downgrade(struct btree_trans *);
 
-void bch2_trans_node_add(struct btree_trans *trans, struct btree *);
+void bch2_trans_node_add(struct btree_trans *trans, struct btree_path *, struct btree *);
 void bch2_trans_node_reinit_iter(struct btree_trans *, struct btree *);
 
 int __must_check __bch2_btree_iter_traverse(struct btree_iter *iter);
 int __must_check bch2_btree_iter_traverse(struct btree_iter *);
 
 struct btree *bch2_btree_iter_peek_node(struct btree_iter *);
+struct btree *bch2_btree_iter_peek_node_and_restart(struct btree_iter *);
 struct btree *bch2_btree_iter_next_node(struct btree_iter *);
 
 struct bkey_s_c bch2_btree_iter_peek_upto(struct btree_iter *, struct bpos);
 struct bkey_s_c bch2_btree_iter_next(struct btree_iter *);
 
-struct bkey_s_c bch2_btree_iter_peek_all_levels(struct btree_iter *);
-
 static inline struct bkey_s_c bch2_btree_iter_peek(struct btree_iter *iter)
 {
        return bch2_btree_iter_peek_upto(iter, SPOS_MAX);
@@ -252,10 +382,12 @@ static inline void __bch2_btree_iter_set_pos(struct btree_iter *iter, struct bpo
 
 static inline void bch2_btree_iter_set_pos(struct btree_iter *iter, struct bpos new_pos)
 {
+       struct btree_trans *trans = iter->trans;
+
        if (unlikely(iter->update_path))
-               bch2_path_put(iter->trans, iter->update_path,
+               bch2_path_put(trans, iter->update_path,
                              iter->flags & BTREE_ITER_INTENT);
-       iter->update_path = NULL;
+       iter->update_path = 0;
 
        if (!(iter->flags & BTREE_ITER_ALL_SNAPSHOTS))
                new_pos.snapshot = iter->snapshot;
@@ -279,8 +411,84 @@ static inline void bch2_btree_iter_set_snapshot(struct btree_iter *iter, u32 sna
 }
 
 void bch2_trans_iter_exit(struct btree_trans *, struct btree_iter *);
-void bch2_trans_iter_init(struct btree_trans *, struct btree_iter *,
-                         unsigned, struct bpos, unsigned);
+
+static inline unsigned __bch2_btree_iter_flags(struct btree_trans *trans,
+                                              unsigned btree_id,
+                                              unsigned flags)
+{
+       if (!(flags & (BTREE_ITER_ALL_SNAPSHOTS|BTREE_ITER_NOT_EXTENTS)) &&
+           btree_id_is_extents(btree_id))
+               flags |= BTREE_ITER_IS_EXTENTS;
+
+       if (!(flags & __BTREE_ITER_ALL_SNAPSHOTS) &&
+           !btree_type_has_snapshot_field(btree_id))
+               flags &= ~BTREE_ITER_ALL_SNAPSHOTS;
+
+       if (!(flags & BTREE_ITER_ALL_SNAPSHOTS) &&
+           btree_type_has_snapshots(btree_id))
+               flags |= BTREE_ITER_FILTER_SNAPSHOTS;
+
+       if (trans->journal_replay_not_finished)
+               flags |= BTREE_ITER_WITH_JOURNAL;
+
+       return flags;
+}
+
+static inline unsigned bch2_btree_iter_flags(struct btree_trans *trans,
+                                            unsigned btree_id,
+                                            unsigned flags)
+{
+       if (!btree_id_cached(trans->c, btree_id)) {
+               flags &= ~BTREE_ITER_CACHED;
+               flags &= ~BTREE_ITER_WITH_KEY_CACHE;
+       } else if (!(flags & BTREE_ITER_CACHED))
+               flags |= BTREE_ITER_WITH_KEY_CACHE;
+
+       return __bch2_btree_iter_flags(trans, btree_id, flags);
+}
+
+static inline void bch2_trans_iter_init_common(struct btree_trans *trans,
+                                         struct btree_iter *iter,
+                                         unsigned btree_id, struct bpos pos,
+                                         unsigned locks_want,
+                                         unsigned depth,
+                                         unsigned flags,
+                                         unsigned long ip)
+{
+       iter->trans             = trans;
+       iter->update_path       = 0;
+       iter->key_cache_path    = 0;
+       iter->btree_id          = btree_id;
+       iter->min_depth         = 0;
+       iter->flags             = flags;
+       iter->snapshot          = pos.snapshot;
+       iter->pos               = pos;
+       iter->k                 = POS_KEY(pos);
+       iter->journal_idx       = 0;
+#ifdef CONFIG_BCACHEFS_DEBUG
+       iter->ip_allocated = ip;
+#endif
+       iter->path = bch2_path_get(trans, btree_id, iter->pos,
+                                  locks_want, depth, flags, ip);
+}
+
+void bch2_trans_iter_init_outlined(struct btree_trans *, struct btree_iter *,
+                         enum btree_id, struct bpos, unsigned);
+
+static inline void bch2_trans_iter_init(struct btree_trans *trans,
+                         struct btree_iter *iter,
+                         unsigned btree_id, struct bpos pos,
+                         unsigned flags)
+{
+       if (__builtin_constant_p(btree_id) &&
+           __builtin_constant_p(flags))
+               bch2_trans_iter_init_common(trans, iter, btree_id, pos, 0, 0,
+                               bch2_btree_iter_flags(trans, btree_id, flags),
+                               _THIS_IP_);
+       else
+               bch2_trans_iter_init_outlined(trans, iter, btree_id, pos, flags);
+}
+
 void bch2_trans_node_iter_init(struct btree_trans *, struct btree_iter *,
                               enum btree_id, struct bpos,
                               unsigned, unsigned, unsigned);
@@ -288,46 +496,113 @@ void bch2_trans_copy_iter(struct btree_iter *, struct btree_iter *);
 
 static inline void set_btree_iter_dontneed(struct btree_iter *iter)
 {
-       if (!iter->trans->restarted)
-               iter->path->preserve = false;
+       struct btree_trans *trans = iter->trans;
+
+       if (!trans->restarted)
+               btree_iter_path(trans, iter)->preserve = false;
 }
 
 void *__bch2_trans_kmalloc(struct btree_trans *, size_t);
 
 static inline void *bch2_trans_kmalloc(struct btree_trans *trans, size_t size)
 {
-       unsigned new_top = trans->mem_top + size;
-       void *p = trans->mem + trans->mem_top;
+       size = roundup(size, 8);
+
+       if (likely(trans->mem_top + size <= trans->mem_bytes)) {
+               void *p = trans->mem + trans->mem_top;
 
-       if (likely(new_top <= trans->mem_bytes)) {
                trans->mem_top += size;
                memset(p, 0, size);
                return p;
        } else {
                return __bch2_trans_kmalloc(trans, size);
+       }
+}
 
+static inline void *bch2_trans_kmalloc_nomemzero(struct btree_trans *trans, size_t size)
+{
+       size = round_up(size, 8);
+
+       if (likely(trans->mem_top + size <= trans->mem_bytes)) {
+               void *p = trans->mem + trans->mem_top;
+
+               trans->mem_top += size;
+               return p;
+       } else {
+               return __bch2_trans_kmalloc(trans, size);
        }
 }
 
-u32 bch2_trans_begin(struct btree_trans *);
+static inline struct bkey_s_c __bch2_bkey_get_iter(struct btree_trans *trans,
+                               struct btree_iter *iter,
+                               unsigned btree_id, struct bpos pos,
+                               unsigned flags, unsigned type)
+{
+       struct bkey_s_c k;
 
-static inline struct btree *
-__btree_iter_peek_node_and_restart(struct btree_trans *trans, struct btree_iter *iter)
+       bch2_trans_iter_init(trans, iter, btree_id, pos, flags);
+       k = bch2_btree_iter_peek_slot(iter);
+
+       if (!bkey_err(k) && type && k.k->type != type)
+               k = bkey_s_c_err(-BCH_ERR_ENOENT_bkey_type_mismatch);
+       if (unlikely(bkey_err(k)))
+               bch2_trans_iter_exit(trans, iter);
+       return k;
+}
+
+static inline struct bkey_s_c bch2_bkey_get_iter(struct btree_trans *trans,
+                               struct btree_iter *iter,
+                               unsigned btree_id, struct bpos pos,
+                               unsigned flags)
 {
-       struct btree *b;
+       return __bch2_bkey_get_iter(trans, iter, btree_id, pos, flags, 0);
+}
 
-       while (b = bch2_btree_iter_peek_node(iter),
-              bch2_err_matches(PTR_ERR_OR_ZERO(b), BCH_ERR_transaction_restart))
-               bch2_trans_begin(trans);
+#define bch2_bkey_get_iter_typed(_trans, _iter, _btree_id, _pos, _flags, _type)\
+       bkey_s_c_to_##_type(__bch2_bkey_get_iter(_trans, _iter,                 \
+                                      _btree_id, _pos, _flags, KEY_TYPE_##_type))
 
-       return b;
+static inline int __bch2_bkey_get_val_typed(struct btree_trans *trans,
+                               unsigned btree_id, struct bpos pos,
+                               unsigned flags, unsigned type,
+                               unsigned val_size, void *val)
+{
+       struct btree_iter iter;
+       struct bkey_s_c k;
+       int ret;
+
+       k = __bch2_bkey_get_iter(trans, &iter, btree_id, pos, flags, type);
+       ret = bkey_err(k);
+       if (!ret) {
+               unsigned b = min_t(unsigned, bkey_val_bytes(k.k), val_size);
+
+               memcpy(val, k.v, b);
+               if (unlikely(b < sizeof(*val)))
+                       memset((void *) val + b, 0, sizeof(*val) - b);
+               bch2_trans_iter_exit(trans, &iter);
+       }
+
+       return ret;
 }
 
+#define bch2_bkey_get_val_typed(_trans, _btree_id, _pos, _flags, _type, _val)\
+       __bch2_bkey_get_val_typed(_trans, _btree_id, _pos, _flags,      \
+                                 KEY_TYPE_##_type, sizeof(*_val), _val)
+
+void bch2_trans_srcu_unlock(struct btree_trans *);
+
+u32 bch2_trans_begin(struct btree_trans *);
+
+/*
+ * XXX
+ * this does not handle transaction restarts from bch2_btree_iter_next_node()
+ * correctly
+ */
 #define __for_each_btree_node(_trans, _iter, _btree_id, _start,                \
                              _locks_want, _depth, _flags, _b, _ret)    \
        for (bch2_trans_node_iter_init((_trans), &(_iter), (_btree_id), \
                                _start, _locks_want, _depth, _flags);   \
-            (_b) = __btree_iter_peek_node_and_restart((_trans), &(_iter)),\
+            (_b) = bch2_btree_iter_peek_node_and_restart(&(_iter)),    \
             !((_ret) = PTR_ERR_OR_ZERO(_b)) && (_b);                   \
             (_b) = bch2_btree_iter_next_node(&(_iter)))
 
@@ -336,16 +611,9 @@ __btree_iter_peek_node_and_restart(struct btree_trans *trans, struct btree_iter
        __for_each_btree_node(_trans, _iter, _btree_id, _start,         \
                              0, 0, _flags, _b, _ret)
 
-static inline int bkey_err(struct bkey_s_c k)
-{
-       return PTR_ERR_OR_ZERO(k.k);
-}
-
 static inline struct bkey_s_c bch2_btree_iter_peek_prev_type(struct btree_iter *iter,
                                                             unsigned flags)
 {
-       BUG_ON(flags & BTREE_ITER_ALL_LEVELS);
-
        return  flags & BTREE_ITER_SLOTS      ? bch2_btree_iter_peek_slot(iter) :
                                                bch2_btree_iter_peek_prev(iter);
 }
@@ -353,8 +621,7 @@ static inline struct bkey_s_c bch2_btree_iter_peek_prev_type(struct btree_iter *
 static inline struct bkey_s_c bch2_btree_iter_peek_type(struct btree_iter *iter,
                                                        unsigned flags)
 {
-       return  flags & BTREE_ITER_ALL_LEVELS ? bch2_btree_iter_peek_all_levels(iter) :
-               flags & BTREE_ITER_SLOTS      ? bch2_btree_iter_peek_slot(iter) :
+       return  flags & BTREE_ITER_SLOTS      ? bch2_btree_iter_peek_slot(iter) :
                                                bch2_btree_iter_peek(iter);
 }
 
@@ -365,50 +632,41 @@ static inline struct bkey_s_c bch2_btree_iter_peek_upto_type(struct btree_iter *
        if (!(flags & BTREE_ITER_SLOTS))
                return bch2_btree_iter_peek_upto(iter, end);
 
-       if (bkey_cmp(iter->pos, end) > 0)
+       if (bkey_gt(iter->pos, end))
                return bkey_s_c_null;
 
        return bch2_btree_iter_peek_slot(iter);
 }
 
+int __bch2_btree_trans_too_many_iters(struct btree_trans *);
+
 static inline int btree_trans_too_many_iters(struct btree_trans *trans)
 {
-       if (hweight64(trans->paths_allocated) > BTREE_ITER_MAX - 8) {
-               trace_and_count(trans->c, trans_restart_too_many_iters, trans, _THIS_IP_);
-               return btree_trans_restart(trans, BCH_ERR_transaction_restart_too_many_iters);
-       }
+       if (bitmap_weight(trans->paths_allocated, trans->nr_paths) > BTREE_ITER_INITIAL - 8)
+               return __bch2_btree_trans_too_many_iters(trans);
 
        return 0;
 }
 
-static inline struct bkey_s_c
-__bch2_btree_iter_peek_and_restart(struct btree_trans *trans,
-                                  struct btree_iter *iter, unsigned flags)
-{
-       struct bkey_s_c k;
-
-       while (btree_trans_too_many_iters(trans) ||
-              (k = bch2_btree_iter_peek_type(iter, flags),
-               bch2_err_matches(bkey_err(k), BCH_ERR_transaction_restart)))
-               bch2_trans_begin(trans);
-
-       return k;
-}
-
+/*
+ * goto instead of loop, so that when used inside for_each_btree_key2()
+ * break/continue work correctly
+ */
 #define lockrestart_do(_trans, _do)                                    \
 ({                                                                     \
+       __label__ transaction_restart;                                  \
        u32 _restart_count;                                             \
-       int _ret;                                                       \
+       int _ret2;                                                      \
+transaction_restart:                                                   \
+       _restart_count = bch2_trans_begin(_trans);                      \
+       _ret2 = (_do);                                                  \
                                                                        \
-       do {                                                            \
-               _restart_count = bch2_trans_begin(_trans);              \
-               _ret = (_do);                                           \
-       } while (bch2_err_matches(_ret, BCH_ERR_transaction_restart));  \
+       if (bch2_err_matches(_ret2, BCH_ERR_transaction_restart))       \
+               goto transaction_restart;                               \
                                                                        \
-       if (!_ret                                                     \
+       if (!_ret2)                                                     \
                bch2_trans_verify_not_restarted(_trans, _restart_count);\
-                                                                       \
-       _ret;                                                           \
+       _ret2;                                                          \
 })
 
 /*
@@ -423,103 +681,119 @@ __bch2_btree_iter_peek_and_restart(struct btree_trans *trans,
 #define nested_lockrestart_do(_trans, _do)                             \
 ({                                                                     \
        u32 _restart_count, _orig_restart_count;                        \
-       int _ret                                                      \
+       int _ret2;                                                      \
                                                                        \
        _restart_count = _orig_restart_count = (_trans)->restart_count; \
                                                                        \
-       while (bch2_err_matches(_ret = (_do), BCH_ERR_transaction_restart))\
+       while (bch2_err_matches(_ret2 = (_do), BCH_ERR_transaction_restart))\
                _restart_count = bch2_trans_begin(_trans);              \
                                                                        \
-       if (!_ret                                                     \
+       if (!_ret2)                                                     \
                bch2_trans_verify_not_restarted(_trans, _restart_count);\
                                                                        \
-       if (!_ret && trans_was_restarted(_trans, _orig_restart_count))  \
-               _ret = -BCH_ERR_transaction_restart_nested;             \
-                                                                       \
-       _ret;                                                           \
+       _ret2 ?: trans_was_restarted(_trans, _restart_count);           \
 })
 
-#define for_each_btree_key2(_trans, _iter, _btree_id,                  \
-                           _start, _flags, _k, _do)                    \
+#define for_each_btree_key_upto(_trans, _iter, _btree_id,              \
+                               _start, _end, _flags, _k, _do)          \
 ({                                                                     \
-       int _ret = 0;                                                   \
+       struct btree_iter _iter;                                        \
+       struct bkey_s_c _k;                                             \
+       int _ret3 = 0;                                                  \
                                                                        \
        bch2_trans_iter_init((_trans), &(_iter), (_btree_id),           \
                             (_start), (_flags));                       \
                                                                        \
-       while (1) {                                                     \
-               u32 _restart_count = bch2_trans_begin(_trans);          \
-               (_k) = bch2_btree_iter_peek_type(&(_iter), (_flags));   \
-               if (!(_k).k) {                                          \
-                       _ret = 0;                                       \
-                       break;                                          \
-               }                                                       \
+       do {                                                            \
+               _ret3 = lockrestart_do(_trans, ({                       \
+                       (_k) = bch2_btree_iter_peek_upto_type(&(_iter), \
+                                               _end, (_flags));        \
+                       if (!(_k).k)                                    \
+                               break;                                  \
                                                                        \
-               _ret = bkey_err(_k) ?: (_do);                           \
-               if (bch2_err_matches(_ret, BCH_ERR_transaction_restart))\
-                       continue;                                       \
-               if (_ret)                                               \
-                       break;                                          \
-               bch2_trans_verify_not_restarted(_trans, _restart_count);\
-               if (!bch2_btree_iter_advance(&(_iter)))                 \
-                       break;                                          \
-       }                                                               \
+                       bkey_err(_k) ?: (_do);                          \
+               }));                                                    \
+       } while (!_ret3 && bch2_btree_iter_advance(&(_iter)));          \
                                                                        \
        bch2_trans_iter_exit((_trans), &(_iter));                       \
-       _ret                                                          \
+       _ret3;                                                          \
 })
 
+#define for_each_btree_key(_trans, _iter, _btree_id,                   \
+                          _start, _flags, _k, _do)                     \
+       for_each_btree_key_upto(_trans, _iter, _btree_id, _start,       \
+                                SPOS_MAX, _flags, _k, _do)
+
 #define for_each_btree_key_reverse(_trans, _iter, _btree_id,           \
                                   _start, _flags, _k, _do)             \
 ({                                                                     \
-       int _ret = 0;                                                   \
+       struct btree_iter _iter;                                        \
+       struct bkey_s_c _k;                                             \
+       int _ret3 = 0;                                                  \
                                                                        \
        bch2_trans_iter_init((_trans), &(_iter), (_btree_id),           \
                             (_start), (_flags));                       \
                                                                        \
-       while (1) {                                                     \
-               u32 _restart_count = bch2_trans_begin(_trans);          \
-               (_k) = bch2_btree_iter_peek_prev_type(&(_iter), (_flags));\
-               if (!(_k).k) {                                          \
-                       _ret = 0;                                       \
-                       break;                                          \
-               }                                                       \
+       do {                                                            \
+               _ret3 = lockrestart_do(_trans, ({                       \
+                       (_k) = bch2_btree_iter_peek_prev_type(&(_iter), \
+                                                       (_flags));      \
+                       if (!(_k).k)                                    \
+                               break;                                  \
                                                                        \
-               _ret = bkey_err(_k) ?: (_do);                           \
-               if (bch2_err_matches(_ret, BCH_ERR_transaction_restart))\
-                       continue;                                       \
-               if (_ret)                                               \
-                       break;                                          \
-               bch2_trans_verify_not_restarted(_trans, _restart_count);\
-               if (!bch2_btree_iter_rewind(&(_iter)))                  \
-                       break;                                          \
-       }                                                               \
+                       bkey_err(_k) ?: (_do);                          \
+               }));                                                    \
+       } while (!_ret3 && bch2_btree_iter_rewind(&(_iter)));           \
                                                                        \
        bch2_trans_iter_exit((_trans), &(_iter));                       \
-       _ret                                                          \
+       _ret3;                                                          \
 })
 
 #define for_each_btree_key_commit(_trans, _iter, _btree_id,            \
                                  _start, _iter_flags, _k,              \
                                  _disk_res, _journal_seq, _commit_flags,\
                                  _do)                                  \
-       for_each_btree_key2(_trans, _iter, _btree_id, _start, _iter_flags, _k,\
+       for_each_btree_key(_trans, _iter, _btree_id, _start, _iter_flags, _k,\
                            (_do) ?: bch2_trans_commit(_trans, (_disk_res),\
                                        (_journal_seq), (_commit_flags)))
 
-#define for_each_btree_key(_trans, _iter, _btree_id,                   \
-                          _start, _flags, _k, _ret)                    \
-       for (bch2_trans_iter_init((_trans), &(_iter), (_btree_id),      \
-                                 (_start), (_flags));                  \
-            (_k) = __bch2_btree_iter_peek_and_restart((_trans), &(_iter), _flags),\
-            !((_ret) = bkey_err(_k)) && (_k).k;                        \
-            bch2_btree_iter_advance(&(_iter)))
+#define for_each_btree_key_reverse_commit(_trans, _iter, _btree_id,    \
+                                 _start, _iter_flags, _k,              \
+                                 _disk_res, _journal_seq, _commit_flags,\
+                                 _do)                                  \
+       for_each_btree_key_reverse(_trans, _iter, _btree_id, _start, _iter_flags, _k,\
+                           (_do) ?: bch2_trans_commit(_trans, (_disk_res),\
+                                       (_journal_seq), (_commit_flags)))
 
-#define for_each_btree_key_norestart(_trans, _iter, _btree_id,         \
+#define for_each_btree_key_upto_commit(_trans, _iter, _btree_id,       \
+                                 _start, _end, _iter_flags, _k,        \
+                                 _disk_res, _journal_seq, _commit_flags,\
+                                 _do)                                  \
+       for_each_btree_key_upto(_trans, _iter, _btree_id, _start, _end, _iter_flags, _k,\
+                           (_do) ?: bch2_trans_commit(_trans, (_disk_res),\
+                                       (_journal_seq), (_commit_flags)))
+
+struct bkey_s_c bch2_btree_iter_peek_and_restart_outlined(struct btree_iter *);
+
+static inline struct bkey_s_c
+__bch2_btree_iter_peek_and_restart(struct btree_trans *trans,
+                                  struct btree_iter *iter, unsigned flags)
+{
+       struct bkey_s_c k;
+
+       while (btree_trans_too_many_iters(trans) ||
+              (k = bch2_btree_iter_peek_type(iter, flags),
+               bch2_err_matches(bkey_err(k), BCH_ERR_transaction_restart)))
+               bch2_trans_begin(trans);
+
+       return k;
+}
+
+#define for_each_btree_key_old(_trans, _iter, _btree_id,               \
                           _start, _flags, _k, _ret)                    \
        for (bch2_trans_iter_init((_trans), &(_iter), (_btree_id),      \
                                  (_start), (_flags));                  \
-            (_k) = bch2_btree_iter_peek_type(&(_iter), _flags),        \
+            (_k) = __bch2_btree_iter_peek_and_restart((_trans), &(_iter), _flags),\
             !((_ret) = bkey_err(_k)) && (_k).k;                        \
             bch2_btree_iter_advance(&(_iter)))
 
@@ -531,33 +805,80 @@ __bch2_btree_iter_peek_and_restart(struct btree_trans *trans,
             !((_ret) = bkey_err(_k)) && (_k).k;                        \
             bch2_btree_iter_advance(&(_iter)))
 
-#define for_each_btree_key_continue(_trans, _iter, _flags, _k, _ret)   \
-       for (;                                                          \
-            (_k) = __bch2_btree_iter_peek_and_restart((_trans), &(_iter), _flags),\
-            !((_ret) = bkey_err(_k)) && (_k).k;                        \
+#define for_each_btree_key_upto_continue_norestart(_iter, _end, _flags, _k, _ret)\
+       for (;                                                                  \
+            (_k) = bch2_btree_iter_peek_upto_type(&(_iter), _end, _flags),     \
+            !((_ret) = bkey_err(_k)) && (_k).k;                                \
             bch2_btree_iter_advance(&(_iter)))
 
+#define for_each_btree_key_norestart(_trans, _iter, _btree_id,         \
+                          _start, _flags, _k, _ret)                    \
+       for_each_btree_key_upto_norestart(_trans, _iter, _btree_id, _start,\
+                                         SPOS_MAX, _flags, _k, _ret)
+
 #define for_each_btree_key_continue_norestart(_iter, _flags, _k, _ret) \
-       for (;                                                          \
-            (_k) = bch2_btree_iter_peek_type(&(_iter), _flags),        \
-            !((_ret) = bkey_err(_k)) && (_k).k;                        \
-            bch2_btree_iter_advance(&(_iter)))
+       for_each_btree_key_upto_continue_norestart(_iter, SPOS_MAX, _flags, _k, _ret)
+
+/*
+ * This should not be used in a fastpath, without first trying _do in
+ * nonblocking mode - it will cause excessive transaction restarts and
+ * potentially livelocking:
+ */
+#define drop_locks_do(_trans, _do)                                     \
+({                                                                     \
+       bch2_trans_unlock(_trans);                                      \
+       _do ?: bch2_trans_relock(_trans);                               \
+})
+
+#define allocate_dropping_locks_errcode(_trans, _do)                   \
+({                                                                     \
+       gfp_t _gfp = GFP_NOWAIT|__GFP_NOWARN;                           \
+       int _ret = _do;                                                 \
+                                                                       \
+       if (bch2_err_matches(_ret, ENOMEM)) {                           \
+               _gfp = GFP_KERNEL;                                      \
+               _ret = drop_locks_do(trans, _do);                       \
+       }                                                               \
+       _ret;                                                           \
+})
 
-/* new multiple iterator interface: */
+#define allocate_dropping_locks(_trans, _ret, _do)                     \
+({                                                                     \
+       gfp_t _gfp = GFP_NOWAIT|__GFP_NOWARN;                           \
+       typeof(_do) _p = _do;                                           \
+                                                                       \
+       _ret = 0;                                                       \
+       if (unlikely(!_p)) {                                            \
+               _gfp = GFP_KERNEL;                                      \
+               _ret = drop_locks_do(trans, ((_p = _do), 0));           \
+       }                                                               \
+       _p;                                                             \
+})
 
 void bch2_trans_updates_to_text(struct printbuf *, struct btree_trans *);
-void bch2_btree_path_to_text(struct printbuf *, struct btree_path *);
 void bch2_trans_paths_to_text(struct printbuf *, struct btree_trans *);
 void bch2_dump_trans_updates(struct btree_trans *);
 void bch2_dump_trans_paths_updates(struct btree_trans *);
-void __bch2_trans_init(struct btree_trans *, struct bch_fs *, const char *);
-void bch2_trans_exit(struct btree_trans *);
 
-#define bch2_trans_init(_trans, _c, _nr_iters, _mem) __bch2_trans_init(_trans, _c, __func__)
+struct btree_trans *__bch2_trans_get(struct bch_fs *, unsigned);
+void bch2_trans_put(struct btree_trans *);
+
+extern const char *bch2_btree_transaction_fns[BCH_TRANSACTIONS_NR];
+unsigned bch2_trans_get_fn_idx(const char *);
+
+#define bch2_trans_get(_c)                                             \
+({                                                                     \
+       static unsigned trans_fn_idx;                                   \
+                                                                       \
+       if (unlikely(!trans_fn_idx))                                    \
+               trans_fn_idx = bch2_trans_get_fn_idx(__func__);         \
+       __bch2_trans_get(_c, trans_fn_idx);                             \
+})
 
 void bch2_btree_trans_to_text(struct printbuf *, struct btree_trans *);
 
 void bch2_fs_btree_iter_exit(struct bch_fs *);
+void bch2_fs_btree_iter_init_early(struct bch_fs *);
 int bch2_fs_btree_iter_init(struct bch_fs *);
 
 #endif /* _BCACHEFS_BTREE_ITER_H */