]> git.sesse.net Git - bcachefs-tools-debian/blobdiff - libbcachefs/extents.h
Disable pristine-tar option in gbp.conf, since there is no pristine-tar branch.
[bcachefs-tools-debian] / libbcachefs / extents.h
index 66a02f1c5e5b78de8b427fa03bd0018b20284f7e..6bf839d69e84e6e24ed3bf2bf611177fc04676e1 100644 (file)
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #ifndef _BCACHEFS_EXTENTS_H
 #define _BCACHEFS_EXTENTS_H
 
 #include "extents_types.h"
 
 struct bch_fs;
-struct journal_res;
-struct btree_node_iter;
-struct btree_node_iter_large;
-struct btree_insert;
-struct btree_insert_entry;
-struct bch_devs_mask;
-union bch_extent_crc;
-
-const char *bch2_btree_ptr_invalid(const struct bch_fs *, struct bkey_s_c);
-void bch2_btree_ptr_debugcheck(struct bch_fs *, struct btree *,
-                              struct bkey_s_c);
-int bch2_btree_ptr_to_text(struct bch_fs *, char *, size_t, struct bkey_s_c);
-void bch2_ptr_swab(const struct bkey_format *, struct bkey_packed *);
-
-#define bch2_bkey_btree_ops (struct bkey_ops) {                        \
-       .key_invalid    = bch2_btree_ptr_invalid,               \
-       .key_debugcheck = bch2_btree_ptr_debugcheck,            \
-       .val_to_text    = bch2_btree_ptr_to_text,               \
-       .swab           = bch2_ptr_swab,                        \
-}
-
-const char *bch2_extent_invalid(const struct bch_fs *, struct bkey_s_c);
-void bch2_extent_debugcheck(struct bch_fs *, struct btree *, struct bkey_s_c);
-int bch2_extent_to_text(struct bch_fs *, char *, size_t, struct bkey_s_c);
-bool bch2_ptr_normalize(struct bch_fs *, struct btree *, struct bkey_s);
-enum merge_result bch2_extent_merge(struct bch_fs *, struct btree *,
-                                   struct bkey_i *, struct bkey_i *);
-
-#define bch2_bkey_extent_ops (struct bkey_ops) {               \
-       .key_invalid    = bch2_extent_invalid,                  \
-       .key_debugcheck = bch2_extent_debugcheck,               \
-       .val_to_text    = bch2_extent_to_text,                  \
-       .swab           = bch2_ptr_swab,                        \
-       .key_normalize  = bch2_ptr_normalize,                   \
-       .key_merge      = bch2_extent_merge,                    \
-       .is_extents     = true,                                 \
-}
-
-struct btree_nr_keys bch2_key_sort_fix_overlapping(struct bset *,
-                                                 struct btree *,
-                                                 struct btree_node_iter_large *);
-struct btree_nr_keys bch2_extent_sort_fix_overlapping(struct bch_fs *c,
-                                                    struct bset *,
-                                                    struct btree *,
-                                                    struct btree_node_iter_large *);
-
-int bch2_btree_pick_ptr(struct bch_fs *, const struct btree *,
-                       struct bch_devs_mask *avoid,
-                       struct extent_pick_ptr *);
-
-int bch2_extent_pick_ptr(struct bch_fs *, struct bkey_s_c,
-                        struct bch_devs_mask *,
-                        struct extent_pick_ptr *);
-
-void bch2_extent_trim_atomic(struct bkey_i *, struct btree_iter *);
-
-static inline bool bch2_extent_is_atomic(struct bkey *k,
-                                        struct btree_iter *iter)
-{
-       struct btree *b = iter->l[0].b;
-
-       return bkey_cmp(k->p, b->key.k.p) <= 0 &&
-               bkey_cmp(bkey_start_pos(k), b->data->min_key) >= 0;
-}
-
-enum btree_insert_ret
-bch2_extent_can_insert(struct btree_insert *, struct btree_insert_entry *,
-                      unsigned *);
-enum btree_insert_ret
-bch2_insert_fixup_extent(struct btree_insert *, struct btree_insert_entry *);
-
-bool bch2_extent_normalize(struct bch_fs *, struct bkey_s);
-void bch2_extent_mark_replicas_cached(struct bch_fs *, struct bkey_s_extent,
-                                     unsigned, unsigned);
-
-const struct bch_extent_ptr *
-bch2_extent_has_device(struct bkey_s_c_extent, unsigned);
-bool bch2_extent_drop_device(struct bkey_s_extent, unsigned);
-const struct bch_extent_ptr *
-bch2_extent_has_group(struct bch_fs *, struct bkey_s_c_extent, unsigned);
-const struct bch_extent_ptr *
-bch2_extent_has_target(struct bch_fs *, struct bkey_s_c_extent, unsigned);
+struct btree_trans;
+enum bkey_invalid_flags;
 
-unsigned bch2_extent_nr_ptrs(struct bkey_s_c_extent);
-unsigned bch2_extent_nr_dirty_ptrs(struct bkey_s_c);
-unsigned bch2_extent_is_compressed(struct bkey_s_c);
+/* extent entries: */
 
-unsigned bch2_extent_ptr_durability(struct bch_fs *,
-                                   const struct bch_extent_ptr *);
-unsigned bch2_extent_durability(struct bch_fs *, struct bkey_s_c_extent);
-
-bool bch2_extent_matches_ptr(struct bch_fs *, struct bkey_s_c_extent,
-                            struct bch_extent_ptr, u64);
-
-static inline bool bkey_extent_is_data(const struct bkey *k)
-{
-       switch (k->type) {
-       case BCH_EXTENT:
-       case BCH_EXTENT_CACHED:
-               return true;
-       default:
-               return false;
-       }
-}
-
-static inline bool bkey_extent_is_allocation(const struct bkey *k)
-{
-       switch (k->type) {
-       case BCH_EXTENT:
-       case BCH_EXTENT_CACHED:
-       case BCH_RESERVATION:
-               return true;
-       default:
-               return false;
-       }
-}
-
-static inline bool bch2_extent_is_fully_allocated(struct bkey_s_c k)
-{
-       return bkey_extent_is_allocation(k.k) &&
-               !bch2_extent_is_compressed(k);
-}
+#define extent_entry_last(_e)                                          \
+       ((typeof(&(_e).v->start[0])) bkey_val_end(_e))
 
-static inline bool bkey_extent_is_cached(const struct bkey *k)
-{
-       return k->type == BCH_EXTENT_CACHED;
-}
+#define entry_to_ptr(_entry)                                           \
+({                                                                     \
+       EBUG_ON((_entry) && !extent_entry_is_ptr(_entry));              \
+                                                                       \
+       __builtin_choose_expr(                                          \
+               type_is_exact(_entry, const union bch_extent_entry *),  \
+               (const struct bch_extent_ptr *) (_entry),               \
+               (struct bch_extent_ptr *) (_entry));                    \
+})
 
-static inline void bkey_extent_set_cached(struct bkey *k, bool cached)
-{
-       EBUG_ON(k->type != BCH_EXTENT &&
-               k->type != BCH_EXTENT_CACHED);
+/* downcast, preserves const */
+#define to_entry(_entry)                                               \
+({                                                                     \
+       BUILD_BUG_ON(!type_is(_entry, union bch_extent_crc *) &&        \
+                    !type_is(_entry, struct bch_extent_ptr *) &&       \
+                    !type_is(_entry, struct bch_extent_stripe_ptr *)); \
+                                                                       \
+       __builtin_choose_expr(                                          \
+               (type_is_exact(_entry, const union bch_extent_crc *) || \
+                type_is_exact(_entry, const struct bch_extent_ptr *) ||\
+                type_is_exact(_entry, const struct bch_extent_stripe_ptr *)),\
+               (const union bch_extent_entry *) (_entry),              \
+               (union bch_extent_entry *) (_entry));                   \
+})
 
-       k->type = cached ? BCH_EXTENT_CACHED : BCH_EXTENT;
-}
+#define extent_entry_next(_entry)                                      \
+       ((typeof(_entry)) ((void *) (_entry) + extent_entry_bytes(_entry)))
 
 static inline unsigned
 __extent_entry_type(const union bch_extent_entry *e)
@@ -161,14 +62,11 @@ extent_entry_type(const union bch_extent_entry *e)
 static inline size_t extent_entry_bytes(const union bch_extent_entry *entry)
 {
        switch (extent_entry_type(entry)) {
-       case BCH_EXTENT_ENTRY_crc32:
-               return sizeof(struct bch_extent_crc32);
-       case BCH_EXTENT_ENTRY_crc64:
-               return sizeof(struct bch_extent_crc64);
-       case BCH_EXTENT_ENTRY_crc128:
-               return sizeof(struct bch_extent_crc128);
-       case BCH_EXTENT_ENTRY_ptr:
-               return sizeof(struct bch_extent_ptr);
+#define x(f, n)                                                \
+       case BCH_EXTENT_ENTRY_##f:                      \
+               return sizeof(struct bch_extent_##f);
+       BCH_EXTENT_ENTRY_TYPES()
+#undef x
        default:
                BUG();
        }
@@ -179,14 +77,50 @@ static inline size_t extent_entry_u64s(const union bch_extent_entry *entry)
        return extent_entry_bytes(entry) / sizeof(u64);
 }
 
+static inline void __extent_entry_insert(struct bkey_i *k,
+                                        union bch_extent_entry *dst,
+                                        union bch_extent_entry *new)
+{
+       union bch_extent_entry *end = bkey_val_end(bkey_i_to_s(k));
+
+       memmove_u64s_up_small((u64 *) dst + extent_entry_u64s(new),
+                             dst, (u64 *) end - (u64 *) dst);
+       k->k.u64s += extent_entry_u64s(new);
+       memcpy_u64s_small(dst, new, extent_entry_u64s(new));
+}
+
+static inline void extent_entry_drop(struct bkey_s k, union bch_extent_entry *entry)
+{
+       union bch_extent_entry *next = extent_entry_next(entry);
+
+       /* stripes have ptrs, but their layout doesn't work with this code */
+       BUG_ON(k.k->type == KEY_TYPE_stripe);
+
+       memmove_u64s_down(entry, next,
+                         (u64 *) bkey_val_end(k) - (u64 *) next);
+       k.k->u64s -= (u64 *) next - (u64 *) entry;
+}
+
 static inline bool extent_entry_is_ptr(const union bch_extent_entry *e)
 {
        return extent_entry_type(e) == BCH_EXTENT_ENTRY_ptr;
 }
 
+static inline bool extent_entry_is_stripe_ptr(const union bch_extent_entry *e)
+{
+       return extent_entry_type(e) == BCH_EXTENT_ENTRY_stripe_ptr;
+}
+
 static inline bool extent_entry_is_crc(const union bch_extent_entry *e)
 {
-       return !extent_entry_is_ptr(e);
+       switch (extent_entry_type(e)) {
+       case BCH_EXTENT_ENTRY_crc32:
+       case BCH_EXTENT_ENTRY_crc64:
+       case BCH_EXTENT_ENTRY_crc128:
+               return true;
+       default:
+               return false;
+       }
 }
 
 union bch_extent_crc {
@@ -196,19 +130,6 @@ union bch_extent_crc {
        struct bch_extent_crc128        crc128;
 };
 
-/* downcast, preserves const */
-#define to_entry(_entry)                                               \
-({                                                                     \
-       BUILD_BUG_ON(!type_is(_entry, union bch_extent_crc *) &&        \
-                    !type_is(_entry, struct bch_extent_ptr *));        \
-                                                                       \
-       __builtin_choose_expr(                                          \
-               (type_is_exact(_entry, const union bch_extent_crc *) || \
-                type_is_exact(_entry, const struct bch_extent_ptr *)), \
-               (const union bch_extent_entry *) (_entry),              \
-               (union bch_extent_entry *) (_entry));                   \
-})
-
 #define __entry_to_crc(_entry)                                         \
        __builtin_choose_expr(                                          \
                type_is_exact(_entry, const union bch_extent_entry *),  \
@@ -222,56 +143,6 @@ union bch_extent_crc {
        __entry_to_crc(_entry);                                         \
 })
 
-#define entry_to_ptr(_entry)                                           \
-({                                                                     \
-       EBUG_ON((_entry) && !extent_entry_is_ptr(_entry));              \
-                                                                       \
-       __builtin_choose_expr(                                          \
-               type_is_exact(_entry, const union bch_extent_entry *),  \
-               (const struct bch_extent_ptr *) (_entry),               \
-               (struct bch_extent_ptr *) (_entry));                    \
-})
-
-/* checksum entries: */
-
-enum bch_extent_crc_type {
-       BCH_EXTENT_CRC_NONE,
-       BCH_EXTENT_CRC32,
-       BCH_EXTENT_CRC64,
-       BCH_EXTENT_CRC128,
-};
-
-static inline enum bch_extent_crc_type
-__extent_crc_type(const union bch_extent_crc *crc)
-{
-       if (!crc)
-               return BCH_EXTENT_CRC_NONE;
-
-       switch (extent_entry_type(to_entry(crc))) {
-       case BCH_EXTENT_ENTRY_crc32:
-               return BCH_EXTENT_CRC32;
-       case BCH_EXTENT_ENTRY_crc64:
-               return BCH_EXTENT_CRC64;
-       case BCH_EXTENT_ENTRY_crc128:
-               return BCH_EXTENT_CRC128;
-       default:
-               BUG();
-       }
-}
-
-#define extent_crc_type(_crc)                                          \
-({                                                                     \
-       BUILD_BUG_ON(!type_is(_crc, struct bch_extent_crc32 *) &&       \
-                    !type_is(_crc, struct bch_extent_crc64 *) &&       \
-                    !type_is(_crc, struct bch_extent_crc128 *) &&      \
-                    !type_is(_crc, union bch_extent_crc *));           \
-                                                                       \
-         type_is(_crc, struct bch_extent_crc32 *)  ? BCH_EXTENT_CRC32  \
-       : type_is(_crc, struct bch_extent_crc64 *)  ? BCH_EXTENT_CRC64  \
-       : type_is(_crc, struct bch_extent_crc128 *) ? BCH_EXTENT_CRC128 \
-       : __extent_crc_type((union bch_extent_crc *) _crc);             \
-})
-
 static inline struct bch_extent_crc_unpacked
 bch2_extent_crc_unpack(const struct bkey *k, const union bch_extent_crc *crc)
 {
@@ -283,37 +154,34 @@ bch2_extent_crc_unpack(const struct bkey *k, const union bch_extent_crc *crc)
                .offset                 = _crc.offset,                  \
                .live_size              = k->size
 
-       switch (extent_crc_type(crc)) {
-       case BCH_EXTENT_CRC_NONE:
+       if (!crc)
                return (struct bch_extent_crc_unpacked) {
                        .compressed_size        = k->size,
                        .uncompressed_size      = k->size,
                        .live_size              = k->size,
                };
-       case BCH_EXTENT_CRC32: {
+
+       switch (extent_entry_type(to_entry(crc))) {
+       case BCH_EXTENT_ENTRY_crc32: {
                struct bch_extent_crc_unpacked ret = (struct bch_extent_crc_unpacked) {
                        common_fields(crc->crc32),
                };
 
-               *((__le32 *) &ret.csum.lo) = crc->crc32.csum;
-
-               memcpy(&ret.csum.lo, &crc->crc32.csum,
-                      sizeof(crc->crc32.csum));
-
+               *((__le32 *) &ret.csum.lo) = (__le32 __force) crc->crc32.csum;
                return ret;
        }
-       case BCH_EXTENT_CRC64: {
+       case BCH_EXTENT_ENTRY_crc64: {
                struct bch_extent_crc_unpacked ret = (struct bch_extent_crc_unpacked) {
                        common_fields(crc->crc64),
                        .nonce                  = crc->crc64.nonce,
                        .csum.lo                = (__force __le64) crc->crc64.csum_lo,
                };
 
-               *((__le16 *) &ret.csum.hi) = crc->crc64.csum_hi;
+               *((__le16 *) &ret.csum.hi) = (__le16 __force) crc->crc64.csum_hi;
 
                return ret;
        }
-       case BCH_EXTENT_CRC128: {
+       case BCH_EXTENT_ENTRY_crc128: {
                struct bch_extent_crc_unpacked ret = (struct bch_extent_crc_unpacked) {
                        common_fields(crc->crc128),
                        .nonce                  = crc->crc128.nonce,
@@ -328,223 +196,562 @@ bch2_extent_crc_unpack(const struct bkey *k, const union bch_extent_crc *crc)
 #undef common_fields
 }
 
-/* Extent entry iteration: */
+static inline bool crc_is_compressed(struct bch_extent_crc_unpacked crc)
+{
+       return (crc.compression_type != BCH_COMPRESSION_TYPE_none &&
+               crc.compression_type != BCH_COMPRESSION_TYPE_incompressible);
+}
 
-#define extent_entry_next(_entry)                                      \
-       ((typeof(_entry)) ((void *) (_entry) + extent_entry_bytes(_entry)))
+static inline bool crc_is_encoded(struct bch_extent_crc_unpacked crc)
+{
+       return crc.csum_type != BCH_CSUM_none || crc_is_compressed(crc);
+}
 
-#define extent_entry_last(_e)                                          \
-       vstruct_idx((_e).v, bkey_val_u64s((_e).k))
+/* bkey_ptrs: generically over any key type that has ptrs */
 
-/* Iterate over all entries: */
+struct bkey_ptrs_c {
+       const union bch_extent_entry    *start;
+       const union bch_extent_entry    *end;
+};
 
-#define extent_for_each_entry_from(_e, _entry, _start)                 \
-       for ((_entry) = _start;                                         \
-            (_entry) < extent_entry_last(_e);                          \
-            (_entry) = extent_entry_next(_entry))
+struct bkey_ptrs {
+       union bch_extent_entry  *start;
+       union bch_extent_entry  *end;
+};
 
-#define extent_for_each_entry(_e, _entry)                              \
-       extent_for_each_entry_from(_e, _entry, (_e).v->start)
+static inline struct bkey_ptrs_c bch2_bkey_ptrs_c(struct bkey_s_c k)
+{
+       switch (k.k->type) {
+       case KEY_TYPE_btree_ptr: {
+               struct bkey_s_c_btree_ptr e = bkey_s_c_to_btree_ptr(k);
 
-/* Iterate over crcs only: */
+               return (struct bkey_ptrs_c) {
+                       to_entry(&e.v->start[0]),
+                       to_entry(extent_entry_last(e))
+               };
+       }
+       case KEY_TYPE_extent: {
+               struct bkey_s_c_extent e = bkey_s_c_to_extent(k);
 
-#define __extent_crc_next(_e, _p)                                      \
-({                                                                     \
-       typeof(&(_e).v->start[0]) _entry = _p;                          \
-                                                                       \
-       while ((_entry) < extent_entry_last(_e) &&                      \
-              !extent_entry_is_crc(_entry))                            \
-               (_entry) = extent_entry_next(_entry);                   \
-                                                                       \
-       entry_to_crc(_entry < extent_entry_last(_e) ? _entry : NULL);   \
-})
+               return (struct bkey_ptrs_c) {
+                       e.v->start,
+                       extent_entry_last(e)
+               };
+       }
+       case KEY_TYPE_stripe: {
+               struct bkey_s_c_stripe s = bkey_s_c_to_stripe(k);
+
+               return (struct bkey_ptrs_c) {
+                       to_entry(&s.v->ptrs[0]),
+                       to_entry(&s.v->ptrs[s.v->nr_blocks]),
+               };
+       }
+       case KEY_TYPE_reflink_v: {
+               struct bkey_s_c_reflink_v r = bkey_s_c_to_reflink_v(k);
 
-#define __extent_for_each_crc(_e, _crc)                                        \
-       for ((_crc) = __extent_crc_next(_e, (_e).v->start);             \
-            (_crc);                                                    \
-            (_crc) = __extent_crc_next(_e, extent_entry_next(to_entry(_crc))))
+               return (struct bkey_ptrs_c) {
+                       r.v->start,
+                       bkey_val_end(r),
+               };
+       }
+       case KEY_TYPE_btree_ptr_v2: {
+               struct bkey_s_c_btree_ptr_v2 e = bkey_s_c_to_btree_ptr_v2(k);
 
-#define extent_crc_next(_e, _crc, _iter)                               \
+               return (struct bkey_ptrs_c) {
+                       to_entry(&e.v->start[0]),
+                       to_entry(extent_entry_last(e))
+               };
+       }
+       default:
+               return (struct bkey_ptrs_c) { NULL, NULL };
+       }
+}
+
+static inline struct bkey_ptrs bch2_bkey_ptrs(struct bkey_s k)
+{
+       struct bkey_ptrs_c p = bch2_bkey_ptrs_c(k.s_c);
+
+       return (struct bkey_ptrs) {
+               (void *) p.start,
+               (void *) p.end
+       };
+}
+
+#define __bkey_extent_entry_for_each_from(_start, _end, _entry)                \
+       for ((_entry) = (_start);                                       \
+            (_entry) < (_end);                                         \
+            (_entry) = extent_entry_next(_entry))
+
+#define __bkey_ptr_next(_ptr, _end)                                    \
 ({                                                                     \
-       extent_for_each_entry_from(_e, _iter, _iter)                    \
-               if (extent_entry_is_crc(_iter)) {                       \
-                       (_crc) = bch2_extent_crc_unpack((_e).k, entry_to_crc(_iter));\
+       typeof(_end) _entry;                                            \
+                                                                       \
+       __bkey_extent_entry_for_each_from(to_entry(_ptr), _end, _entry) \
+               if (extent_entry_is_ptr(_entry))                        \
                        break;                                          \
-               }                                                       \
                                                                        \
-       (_iter) < extent_entry_last(_e);                                \
+       _entry < (_end) ? entry_to_ptr(_entry) : NULL;                  \
 })
 
-#define extent_for_each_crc(_e, _crc, _iter)                           \
-       for ((_crc) = bch2_extent_crc_unpack((_e).k, NULL),             \
-            (_iter) = (_e).v->start;                                   \
-            extent_crc_next(_e, _crc, _iter);                          \
-            (_iter) = extent_entry_next(_iter))
+#define bkey_extent_entry_for_each_from(_p, _entry, _start)            \
+       __bkey_extent_entry_for_each_from(_start, (_p).end, _entry)
+
+#define bkey_extent_entry_for_each(_p, _entry)                         \
+       bkey_extent_entry_for_each_from(_p, _entry, _p.start)
+
+#define __bkey_for_each_ptr(_start, _end, _ptr)                                \
+       for (typeof(_start) (_ptr) = (_start);                          \
+            ((_ptr) = __bkey_ptr_next(_ptr, _end));                    \
+            (_ptr)++)
 
-/* Iterate over pointers, with crcs: */
+#define bkey_ptr_next(_p, _ptr)                                                \
+       __bkey_ptr_next(_ptr, (_p).end)
 
-#define extent_ptr_crc_next(_e, _ptr, _crc)                            \
+#define bkey_for_each_ptr(_p, _ptr)                                    \
+       __bkey_for_each_ptr(&(_p).start->ptr, (_p).end, _ptr)
+
+#define __bkey_ptr_next_decode(_k, _end, _ptr, _entry)                 \
 ({                                                                     \
        __label__ out;                                                  \
-       typeof(&(_e).v->start[0]) _entry;                               \
                                                                        \
-       extent_for_each_entry_from(_e, _entry, to_entry(_ptr))          \
-               if (extent_entry_is_crc(_entry)) {                      \
-                       (_crc) = bch2_extent_crc_unpack((_e).k, entry_to_crc(_entry));\
-               } else {                                                \
-                       _ptr = entry_to_ptr(_entry);                    \
+       (_ptr).idx      = 0;                                            \
+       (_ptr).has_ec   = false;                                        \
+                                                                       \
+       __bkey_extent_entry_for_each_from(_entry, _end, _entry)         \
+               switch (extent_entry_type(_entry)) {                    \
+               case BCH_EXTENT_ENTRY_ptr:                              \
+                       (_ptr).ptr              = _entry->ptr;          \
                        goto out;                                       \
+               case BCH_EXTENT_ENTRY_crc32:                            \
+               case BCH_EXTENT_ENTRY_crc64:                            \
+               case BCH_EXTENT_ENTRY_crc128:                           \
+                       (_ptr).crc = bch2_extent_crc_unpack(_k,         \
+                                       entry_to_crc(_entry));          \
+                       break;                                          \
+               case BCH_EXTENT_ENTRY_stripe_ptr:                       \
+                       (_ptr).ec = _entry->stripe_ptr;                 \
+                       (_ptr).has_ec   = true;                         \
+                       break;                                          \
+               default:                                                \
+                       /* nothing */                                   \
+                       break;                                          \
                }                                                       \
-                                                                       \
-       _ptr = NULL;                                                    \
 out:                                                                   \
-       _ptr;                                                           \
+       _entry < (_end);                                                \
 })
 
-#define extent_for_each_ptr_crc(_e, _ptr, _crc)                                \
-       for ((_crc) = bch2_extent_crc_unpack((_e).k, NULL),             \
-            (_ptr) = &(_e).v->start->ptr;                              \
-            ((_ptr) = extent_ptr_crc_next(_e, _ptr, _crc));            \
-            (_ptr)++)
+#define __bkey_for_each_ptr_decode(_k, _start, _end, _ptr, _entry)     \
+       for ((_ptr).crc = bch2_extent_crc_unpack(_k, NULL),             \
+            (_entry) = _start;                                         \
+            __bkey_ptr_next_decode(_k, _end, _ptr, _entry);            \
+            (_entry) = extent_entry_next(_entry))
 
-/* Iterate over pointers only, and from a given position: */
+#define bkey_for_each_ptr_decode(_k, _p, _ptr, _entry)                 \
+       __bkey_for_each_ptr_decode(_k, (_p).start, (_p).end,            \
+                                  _ptr, _entry)
 
-#define extent_ptr_next(_e, _ptr)                                      \
+#define bkey_crc_next(_k, _start, _end, _crc, _iter)                   \
 ({                                                                     \
-       struct bch_extent_crc_unpacked _crc;                            \
+       __bkey_extent_entry_for_each_from(_iter, _end, _iter)           \
+               if (extent_entry_is_crc(_iter)) {                       \
+                       (_crc) = bch2_extent_crc_unpack(_k,             \
+                                               entry_to_crc(_iter));   \
+                       break;                                          \
+               }                                                       \
                                                                        \
-       extent_ptr_crc_next(_e, _ptr, _crc);                            \
+       (_iter) < (_end);                                               \
 })
 
+#define __bkey_for_each_crc(_k, _start, _end, _crc, _iter)             \
+       for ((_crc) = bch2_extent_crc_unpack(_k, NULL),                 \
+            (_iter) = (_start);                                        \
+            bkey_crc_next(_k, _start, _end, _crc, _iter);              \
+            (_iter) = extent_entry_next(_iter))
+
+#define bkey_for_each_crc(_k, _p, _crc, _iter)                         \
+       __bkey_for_each_crc(_k, (_p).start, (_p).end, _crc, _iter)
+
+/* Iterate over pointers in KEY_TYPE_extent: */
+
+#define extent_for_each_entry_from(_e, _entry, _start)                 \
+       __bkey_extent_entry_for_each_from(_start,                       \
+                               extent_entry_last(_e), _entry)
+
+#define extent_for_each_entry(_e, _entry)                              \
+       extent_for_each_entry_from(_e, _entry, (_e).v->start)
+
+#define extent_ptr_next(_e, _ptr)                                      \
+       __bkey_ptr_next(_ptr, extent_entry_last(_e))
+
 #define extent_for_each_ptr(_e, _ptr)                                  \
-       for ((_ptr) = &(_e).v->start->ptr;                              \
-            ((_ptr) = extent_ptr_next(_e, _ptr));                      \
-            (_ptr)++)
+       __bkey_for_each_ptr(&(_e).v->start->ptr, extent_entry_last(_e), _ptr)
 
-#define extent_ptr_prev(_e, _ptr)                                      \
-({                                                                     \
-       typeof(&(_e).v->start->ptr) _p;                                 \
-       typeof(&(_e).v->start->ptr) _prev = NULL;                       \
-                                                                       \
-       extent_for_each_ptr(_e, _p) {                                   \
-               if (_p == (_ptr))                                       \
-                       break;                                          \
-               _prev = _p;                                             \
-       }                                                               \
-                                                                       \
-       _prev;                                                          \
+#define extent_for_each_ptr_decode(_e, _ptr, _entry)                   \
+       __bkey_for_each_ptr_decode((_e).k, (_e).v->start,               \
+                                  extent_entry_last(_e), _ptr, _entry)
+
+/* utility code common to all keys with pointers: */
+
+void bch2_mark_io_failure(struct bch_io_failures *,
+                         struct extent_ptr_decoded *);
+int bch2_bkey_pick_read_device(struct bch_fs *, struct bkey_s_c,
+                              struct bch_io_failures *,
+                              struct extent_ptr_decoded *);
+
+/* KEY_TYPE_btree_ptr: */
+
+int bch2_btree_ptr_invalid(struct bch_fs *, struct bkey_s_c,
+                          enum bkey_invalid_flags, struct printbuf *);
+void bch2_btree_ptr_to_text(struct printbuf *, struct bch_fs *,
+                           struct bkey_s_c);
+
+int bch2_btree_ptr_v2_invalid(struct bch_fs *, struct bkey_s_c,
+                             enum bkey_invalid_flags, struct printbuf *);
+void bch2_btree_ptr_v2_to_text(struct printbuf *, struct bch_fs *, struct bkey_s_c);
+void bch2_btree_ptr_v2_compat(enum btree_id, unsigned, unsigned,
+                             int, struct bkey_s);
+
+#define bch2_bkey_ops_btree_ptr ((struct bkey_ops) {           \
+       .key_invalid    = bch2_btree_ptr_invalid,               \
+       .val_to_text    = bch2_btree_ptr_to_text,               \
+       .swab           = bch2_ptr_swab,                        \
+       .trigger        = bch2_trigger_extent,                  \
 })
 
-/*
- * Use this when you'll be dropping pointers as you iterate. Quadratic,
- * unfortunately:
- */
-#define extent_for_each_ptr_backwards(_e, _ptr)                                \
-       for ((_ptr) = extent_ptr_prev(_e, NULL);                        \
-            (_ptr);                                                    \
-            (_ptr) = extent_ptr_prev(_e, _ptr))
+#define bch2_bkey_ops_btree_ptr_v2 ((struct bkey_ops) {                \
+       .key_invalid    = bch2_btree_ptr_v2_invalid,            \
+       .val_to_text    = bch2_btree_ptr_v2_to_text,            \
+       .swab           = bch2_ptr_swab,                        \
+       .compat         = bch2_btree_ptr_v2_compat,             \
+       .trigger        = bch2_trigger_extent,                  \
+       .min_val_size   = 40,                                   \
+})
 
-void bch2_extent_crc_append(struct bkey_i_extent *,
+/* KEY_TYPE_extent: */
+
+bool bch2_extent_merge(struct bch_fs *, struct bkey_s, struct bkey_s_c);
+
+#define bch2_bkey_ops_extent ((struct bkey_ops) {              \
+       .key_invalid    = bch2_bkey_ptrs_invalid,               \
+       .val_to_text    = bch2_bkey_ptrs_to_text,               \
+       .swab           = bch2_ptr_swab,                        \
+       .key_normalize  = bch2_extent_normalize,                \
+       .key_merge      = bch2_extent_merge,                    \
+       .trigger        = bch2_trigger_extent,                  \
+})
+
+/* KEY_TYPE_reservation: */
+
+int bch2_reservation_invalid(struct bch_fs *, struct bkey_s_c,
+                            enum bkey_invalid_flags, struct printbuf *);
+void bch2_reservation_to_text(struct printbuf *, struct bch_fs *, struct bkey_s_c);
+bool bch2_reservation_merge(struct bch_fs *, struct bkey_s, struct bkey_s_c);
+
+#define bch2_bkey_ops_reservation ((struct bkey_ops) {         \
+       .key_invalid    = bch2_reservation_invalid,             \
+       .val_to_text    = bch2_reservation_to_text,             \
+       .key_merge      = bch2_reservation_merge,               \
+       .trigger        = bch2_trigger_reservation,             \
+       .min_val_size   = 8,                                    \
+})
+
+/* Extent checksum entries: */
+
+bool bch2_can_narrow_extent_crcs(struct bkey_s_c,
+                                struct bch_extent_crc_unpacked);
+bool bch2_bkey_narrow_crcs(struct bkey_i *, struct bch_extent_crc_unpacked);
+void bch2_extent_crc_append(struct bkey_i *,
                            struct bch_extent_crc_unpacked);
 
-static inline void __extent_entry_push(struct bkey_i_extent *e)
+/* Generic code for keys with pointers: */
+
+static inline bool bkey_is_btree_ptr(const struct bkey *k)
+{
+       switch (k->type) {
+       case KEY_TYPE_btree_ptr:
+       case KEY_TYPE_btree_ptr_v2:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static inline bool bkey_extent_is_direct_data(const struct bkey *k)
+{
+       switch (k->type) {
+       case KEY_TYPE_btree_ptr:
+       case KEY_TYPE_btree_ptr_v2:
+       case KEY_TYPE_extent:
+       case KEY_TYPE_reflink_v:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static inline bool bkey_extent_is_inline_data(const struct bkey *k)
+{
+       return  k->type == KEY_TYPE_inline_data ||
+               k->type == KEY_TYPE_indirect_inline_data;
+}
+
+static inline unsigned bkey_inline_data_offset(const struct bkey *k)
+{
+       switch (k->type) {
+       case KEY_TYPE_inline_data:
+               return sizeof(struct bch_inline_data);
+       case KEY_TYPE_indirect_inline_data:
+               return sizeof(struct bch_indirect_inline_data);
+       default:
+               BUG();
+       }
+}
+
+static inline unsigned bkey_inline_data_bytes(const struct bkey *k)
+{
+       return bkey_val_bytes(k) - bkey_inline_data_offset(k);
+}
+
+#define bkey_inline_data_p(_k) (((void *) (_k).v) + bkey_inline_data_offset((_k).k))
+
+static inline bool bkey_extent_is_data(const struct bkey *k)
+{
+       return  bkey_extent_is_direct_data(k) ||
+               bkey_extent_is_inline_data(k) ||
+               k->type == KEY_TYPE_reflink_p;
+}
+
+/*
+ * Should extent be counted under inode->i_sectors?
+ */
+static inline bool bkey_extent_is_allocation(const struct bkey *k)
 {
-       union bch_extent_entry *entry = extent_entry_last(extent_i_to_s(e));
+       switch (k->type) {
+       case KEY_TYPE_extent:
+       case KEY_TYPE_reservation:
+       case KEY_TYPE_reflink_p:
+       case KEY_TYPE_reflink_v:
+       case KEY_TYPE_inline_data:
+       case KEY_TYPE_indirect_inline_data:
+       case KEY_TYPE_error:
+               return true;
+       default:
+               return false;
+       }
+}
 
-       EBUG_ON(bkey_val_u64s(&e->k) + extent_entry_u64s(entry) >
-               BKEY_EXTENT_VAL_U64s_MAX);
+static inline bool bkey_extent_is_unwritten(struct bkey_s_c k)
+{
+       struct bkey_ptrs_c ptrs = bch2_bkey_ptrs_c(k);
 
-       e->k.u64s += extent_entry_u64s(entry);
+       bkey_for_each_ptr(ptrs, ptr)
+               if (ptr->unwritten)
+                       return true;
+       return false;
 }
 
-static inline void extent_ptr_append(struct bkey_i_extent *e,
-                                    struct bch_extent_ptr ptr)
+static inline bool bkey_extent_is_reservation(struct bkey_s_c k)
 {
-       ptr.type = 1 << BCH_EXTENT_ENTRY_ptr;
-       extent_entry_last(extent_i_to_s(e))->ptr = ptr;
-       __extent_entry_push(e);
+       return k.k->type == KEY_TYPE_reservation ||
+               bkey_extent_is_unwritten(k);
 }
 
-static inline struct bch_devs_list bch2_extent_devs(struct bkey_s_c_extent e)
+static inline struct bch_devs_list bch2_bkey_devs(struct bkey_s_c k)
 {
        struct bch_devs_list ret = (struct bch_devs_list) { 0 };
-       const struct bch_extent_ptr *ptr;
+       struct bkey_ptrs_c p = bch2_bkey_ptrs_c(k);
 
-       extent_for_each_ptr(e, ptr)
-               ret.devs[ret.nr++] = ptr->dev;
+       bkey_for_each_ptr(p, ptr)
+               ret.data[ret.nr++] = ptr->dev;
 
        return ret;
 }
 
-static inline struct bch_devs_list bch2_extent_dirty_devs(struct bkey_s_c_extent e)
+static inline struct bch_devs_list bch2_bkey_dirty_devs(struct bkey_s_c k)
 {
        struct bch_devs_list ret = (struct bch_devs_list) { 0 };
-       const struct bch_extent_ptr *ptr;
+       struct bkey_ptrs_c p = bch2_bkey_ptrs_c(k);
 
-       extent_for_each_ptr(e, ptr)
+       bkey_for_each_ptr(p, ptr)
                if (!ptr->cached)
-                       ret.devs[ret.nr++] = ptr->dev;
+                       ret.data[ret.nr++] = ptr->dev;
 
        return ret;
 }
 
-static inline struct bch_devs_list bch2_extent_cached_devs(struct bkey_s_c_extent e)
+static inline struct bch_devs_list bch2_bkey_cached_devs(struct bkey_s_c k)
 {
        struct bch_devs_list ret = (struct bch_devs_list) { 0 };
-       const struct bch_extent_ptr *ptr;
+       struct bkey_ptrs_c p = bch2_bkey_ptrs_c(k);
 
-       extent_for_each_ptr(e, ptr)
+       bkey_for_each_ptr(p, ptr)
                if (ptr->cached)
-                       ret.devs[ret.nr++] = ptr->dev;
+                       ret.data[ret.nr++] = ptr->dev;
 
        return ret;
 }
 
-static inline struct bch_devs_list bch2_bkey_devs(struct bkey_s_c k)
+static inline unsigned bch2_bkey_ptr_data_type(struct bkey_s_c k, const struct bch_extent_ptr *ptr)
 {
        switch (k.k->type) {
-       case BCH_EXTENT:
-       case BCH_EXTENT_CACHED:
-               return bch2_extent_devs(bkey_s_c_to_extent(k));
+       case KEY_TYPE_btree_ptr:
+       case KEY_TYPE_btree_ptr_v2:
+               return BCH_DATA_btree;
+       case KEY_TYPE_extent:
+       case KEY_TYPE_reflink_v:
+               return BCH_DATA_user;
+       case KEY_TYPE_stripe: {
+               struct bkey_s_c_stripe s = bkey_s_c_to_stripe(k);
+
+               BUG_ON(ptr < s.v->ptrs ||
+                      ptr >= s.v->ptrs + s.v->nr_blocks);
+
+               return ptr >= s.v->ptrs + s.v->nr_blocks - s.v->nr_redundant
+                       ? BCH_DATA_parity
+                       : BCH_DATA_user;
+       }
        default:
-               return (struct bch_devs_list) { .nr = 0 };
+               BUG();
        }
 }
 
-static inline struct bch_devs_list bch2_bkey_dirty_devs(struct bkey_s_c k)
+unsigned bch2_bkey_nr_ptrs(struct bkey_s_c);
+unsigned bch2_bkey_nr_ptrs_allocated(struct bkey_s_c);
+unsigned bch2_bkey_nr_ptrs_fully_allocated(struct bkey_s_c);
+bool bch2_bkey_is_incompressible(struct bkey_s_c);
+unsigned bch2_bkey_sectors_compressed(struct bkey_s_c);
+
+unsigned bch2_bkey_replicas(struct bch_fs *, struct bkey_s_c);
+unsigned bch2_extent_ptr_desired_durability(struct bch_fs *, struct extent_ptr_decoded *);
+unsigned bch2_extent_ptr_durability(struct bch_fs *, struct extent_ptr_decoded *);
+unsigned bch2_bkey_durability(struct bch_fs *, struct bkey_s_c);
+
+void bch2_bkey_drop_device(struct bkey_s, unsigned);
+void bch2_bkey_drop_device_noerror(struct bkey_s, unsigned);
+
+const struct bch_extent_ptr *bch2_bkey_has_device_c(struct bkey_s_c, unsigned);
+
+static inline struct bch_extent_ptr *bch2_bkey_has_device(struct bkey_s k, unsigned dev)
 {
-       switch (k.k->type) {
-       case BCH_EXTENT:
-       case BCH_EXTENT_CACHED:
-               return bch2_extent_dirty_devs(bkey_s_c_to_extent(k));
-       default:
-               return (struct bch_devs_list) { .nr = 0 };
-       }
+       return (void *) bch2_bkey_has_device_c(k.s_c, dev);
 }
 
-static inline struct bch_devs_list bch2_bkey_cached_devs(struct bkey_s_c k)
+bool bch2_bkey_has_target(struct bch_fs *, struct bkey_s_c, unsigned);
+
+void bch2_bkey_extent_entry_drop(struct bkey_i *, union bch_extent_entry *);
+
+static inline void bch2_bkey_append_ptr(struct bkey_i *k, struct bch_extent_ptr ptr)
 {
-       switch (k.k->type) {
-       case BCH_EXTENT:
-       case BCH_EXTENT_CACHED:
-               return bch2_extent_cached_devs(bkey_s_c_to_extent(k));
+       struct bch_extent_ptr *dest;
+
+       EBUG_ON(bch2_bkey_has_device(bkey_i_to_s(k), ptr.dev));
+
+       switch (k->k.type) {
+       case KEY_TYPE_btree_ptr:
+       case KEY_TYPE_btree_ptr_v2:
+       case KEY_TYPE_extent:
+               EBUG_ON(bkey_val_u64s(&k->k) >= BKEY_EXTENT_VAL_U64s_MAX);
+
+               ptr.type = 1 << BCH_EXTENT_ENTRY_ptr;
+               dest = (struct bch_extent_ptr *)((void *) &k->v + bkey_val_bytes(&k->k));
+               *dest = ptr;
+               k->k.u64s++;
+               break;
        default:
-               return (struct bch_devs_list) { .nr = 0 };
+               BUG();
        }
 }
 
-bool bch2_can_narrow_extent_crcs(struct bkey_s_c_extent,
-                                struct bch_extent_crc_unpacked);
-bool bch2_extent_narrow_crcs(struct bkey_i_extent *, struct bch_extent_crc_unpacked);
-void bch2_extent_drop_redundant_crcs(struct bkey_s_extent);
+void bch2_extent_ptr_decoded_append(struct bkey_i *,
+                                   struct extent_ptr_decoded *);
+union bch_extent_entry *bch2_bkey_drop_ptr_noerror(struct bkey_s,
+                                                  struct bch_extent_ptr *);
+union bch_extent_entry *bch2_bkey_drop_ptr(struct bkey_s,
+                                          struct bch_extent_ptr *);
+
+#define bch2_bkey_drop_ptrs(_k, _ptr, _cond)                           \
+do {                                                                   \
+       struct bkey_ptrs _ptrs = bch2_bkey_ptrs(_k);                    \
+                                                                       \
+       _ptr = &_ptrs.start->ptr;                                       \
+                                                                       \
+       while ((_ptr = bkey_ptr_next(_ptrs, _ptr))) {                   \
+               if (_cond) {                                            \
+                       _ptr = (void *) bch2_bkey_drop_ptr(_k, _ptr);   \
+                       _ptrs = bch2_bkey_ptrs(_k);                     \
+                       continue;                                       \
+               }                                                       \
+                                                                       \
+               (_ptr)++;                                               \
+       }                                                               \
+} while (0)
 
-void __bch2_extent_drop_ptr(struct bkey_s_extent, struct bch_extent_ptr *);
-void bch2_extent_drop_ptr(struct bkey_s_extent, struct bch_extent_ptr *);
+bool bch2_bkey_matches_ptr(struct bch_fs *, struct bkey_s_c,
+                          struct bch_extent_ptr, u64);
+bool bch2_extents_match(struct bkey_s_c, struct bkey_s_c);
+struct bch_extent_ptr *
+bch2_extent_has_ptr(struct bkey_s_c, struct extent_ptr_decoded, struct bkey_s);
 
-bool bch2_cut_front(struct bpos, struct bkey_i *);
-bool bch2_cut_back(struct bpos, struct bkey *);
-void bch2_key_resize(struct bkey *, unsigned);
+void bch2_extent_ptr_set_cached(struct bkey_s, struct bch_extent_ptr *);
+
+bool bch2_extent_normalize(struct bch_fs *, struct bkey_s);
+void bch2_bkey_ptrs_to_text(struct printbuf *, struct bch_fs *,
+                           struct bkey_s_c);
+int bch2_bkey_ptrs_invalid(struct bch_fs *, struct bkey_s_c,
+                          enum bkey_invalid_flags, struct printbuf *);
 
-int bch2_check_range_allocated(struct bch_fs *, struct bpos, u64);
+void bch2_ptr_swab(struct bkey_s);
+
+const struct bch_extent_rebalance *bch2_bkey_rebalance_opts(struct bkey_s_c);
+unsigned bch2_bkey_ptrs_need_rebalance(struct bch_fs *, struct bkey_s_c,
+                                      unsigned, unsigned);
+bool bch2_bkey_needs_rebalance(struct bch_fs *, struct bkey_s_c);
+
+int bch2_bkey_set_needs_rebalance(struct bch_fs *, struct bkey_i *,
+                                 struct bch_io_opts *);
+
+/* Generic extent code: */
+
+enum bch_extent_overlap {
+       BCH_EXTENT_OVERLAP_ALL          = 0,
+       BCH_EXTENT_OVERLAP_BACK         = 1,
+       BCH_EXTENT_OVERLAP_FRONT        = 2,
+       BCH_EXTENT_OVERLAP_MIDDLE       = 3,
+};
+
+/* Returns how k overlaps with m */
+static inline enum bch_extent_overlap bch2_extent_overlap(const struct bkey *k,
+                                                         const struct bkey *m)
+{
+       int cmp1 = bkey_lt(k->p, m->p);
+       int cmp2 = bkey_gt(bkey_start_pos(k), bkey_start_pos(m));
+
+       return (cmp1 << 1) + cmp2;
+}
+
+int bch2_cut_front_s(struct bpos, struct bkey_s);
+int bch2_cut_back_s(struct bpos, struct bkey_s);
+
+static inline void bch2_cut_front(struct bpos where, struct bkey_i *k)
+{
+       bch2_cut_front_s(where, bkey_i_to_s(k));
+}
+
+static inline void bch2_cut_back(struct bpos where, struct bkey_i *k)
+{
+       bch2_cut_back_s(where, bkey_i_to_s(k));
+}
+
+/**
+ * bch_key_resize - adjust size of @k
+ *
+ * bkey_start_offset(k) will be preserved, modifies where the extent ends
+ */
+static inline void bch2_key_resize(struct bkey *k, unsigned new_size)
+{
+       k->p.offset -= k->size;
+       k->p.offset += new_size;
+       k->size = new_size;
+}
 
 #endif /* _BCACHEFS_EXTENTS_H */