]> git.sesse.net Git - bcachefs-tools-debian/blobdiff - libbcachefs/fs.c
Update bcachefs sources to 481b5f343248 bcachefs: Better error messages for missing...
[bcachefs-tools-debian] / libbcachefs / fs.c
index d3fb00396f3b5fdc3159ad9dadaa7309f53d516c..ec419b8e2c43123b42e0d84c837611fc5f6e2314 100644 (file)
 
 #include "bcachefs.h"
 #include "acl.h"
+#include "bkey_buf.h"
 #include "btree_update.h"
 #include "buckets.h"
 #include "chardev.h"
 #include "dirent.h"
+#include "errcode.h"
 #include "extents.h"
 #include "fs.h"
+#include "fs-common.h"
 #include "fs-io.h"
 #include "fs-ioctl.h"
+#include "fs-io-buffered.h"
+#include "fs-io-direct.h"
+#include "fs-io-pagecache.h"
 #include "fsck.h"
 #include "inode.h"
-#include "io.h"
+#include "io_read.h"
 #include "journal.h"
 #include "keylist.h"
 #include "quota.h"
+#include "snapshot.h"
 #include "super.h"
 #include "xattr.h"
 
 #include <linux/aio.h>
 #include <linux/backing-dev.h>
 #include <linux/exportfs.h>
+#include <linux/fiemap.h>
 #include <linux/module.h>
+#include <linux/pagemap.h>
 #include <linux/posix_acl.h>
 #include <linux/random.h>
+#include <linux/seq_file.h>
 #include <linux/statfs.h>
+#include <linux/string.h>
 #include <linux/xattr.h>
 
 static struct kmem_cache *bch2_inode_cache;
 
-static void bch2_vfs_inode_init(struct bch_fs *,
+static void bch2_vfs_inode_init(struct btree_trans *, subvol_inum,
                                struct bch_inode_info *,
-                               struct bch_inode_unpacked *);
+                               struct bch_inode_unpacked *,
+                               struct bch_subvolume *);
 
-static void journal_seq_copy(struct bch_inode_info *dst,
-                            u64 journal_seq)
-{
-       u64 old, v = READ_ONCE(dst->ei_journal_seq);
-
-       do {
-               old = v;
-
-               if (old >= journal_seq)
-                       break;
-       } while ((v = cmpxchg(&dst->ei_journal_seq, old, journal_seq)) != old);
-}
-
-/*
- * I_SIZE_DIRTY requires special handling:
- *
- * To the recovery code, the flag means that there is stale data past i_size
- * that needs to be deleted; it's used for implementing atomic appends and
- * truncates.
- *
- * On append, we set I_SIZE_DIRTY before doing the write, then after the write
- * we clear I_SIZE_DIRTY atomically with updating i_size to the new larger size
- * that exposes the data we just wrote.
- *
- * On truncate, it's the reverse: We set I_SIZE_DIRTY atomically with setting
- * i_size to the new smaller size, then we delete the data that we just made
- * invisible, and then we clear I_SIZE_DIRTY.
- *
- * Because there can be multiple appends in flight at a time, we need a refcount
- * (i_size_dirty_count) instead of manipulating the flag directly. Nonzero
- * refcount means I_SIZE_DIRTY is set, zero means it's cleared.
- *
- * Because write_inode() can be called at any time, i_size_dirty_count means
- * something different to the runtime code - it means to write_inode() "don't
- * update i_size yet".
- *
- * We don't clear I_SIZE_DIRTY directly, we let write_inode() clear it when
- * i_size_dirty_count is zero - but the reverse is not true, I_SIZE_DIRTY must
- * be set explicitly.
- */
-
-void bch2_inode_update_after_write(struct bch_fs *c,
+void bch2_inode_update_after_write(struct btree_trans *trans,
                                   struct bch_inode_info *inode,
                                   struct bch_inode_unpacked *bi,
                                   unsigned fields)
 {
+       struct bch_fs *c = trans->c;
+
+       BUG_ON(bi->bi_inum != inode->v.i_ino);
+
+       bch2_assert_pos_locked(trans, BTREE_ID_inodes,
+                              POS(0, bi->bi_inum),
+                              c->opts.inodes_use_key_cache);
+
        set_nlink(&inode->v, bch2_inode_nlink_get(bi));
        i_uid_write(&inode->v, bi->bi_uid);
        i_gid_write(&inode->v, bi->bi_gid);
        inode->v.i_mode = bi->bi_mode;
 
        if (fields & ATTR_ATIME)
-               inode->v.i_atime = bch2_time_to_timespec(c, bi->bi_atime);
+               inode_set_atime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_atime));
        if (fields & ATTR_MTIME)
-               inode->v.i_mtime = bch2_time_to_timespec(c, bi->bi_mtime);
+               inode_set_mtime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_mtime));
        if (fields & ATTR_CTIME)
-               inode->v.i_ctime = bch2_time_to_timespec(c, bi->bi_ctime);
+               inode_set_ctime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_ctime));
 
        inode->ei_inode         = *bi;
 
        bch2_inode_flags_to_vfs(inode);
 }
 
-int __must_check bch2_write_inode_trans(struct btree_trans *trans,
-                               struct bch_inode_info *inode,
-                               struct bch_inode_unpacked *inode_u,
-                               inode_set_fn set,
-                               void *p)
-{
-       struct btree_iter *iter = NULL;
-       struct bkey_inode_buf *inode_p;
-       int ret;
-
-       lockdep_assert_held(&inode->ei_update_lock);
-
-       iter = bch2_trans_get_iter(trans, BTREE_ID_INODES,
-                                  POS(inode->v.i_ino, 0),
-                                  BTREE_ITER_SLOTS|BTREE_ITER_INTENT);
-       if (IS_ERR(iter))
-               return PTR_ERR(iter);
-
-       /* The btree node lock is our lock on the inode: */
-       ret = bch2_btree_iter_traverse(iter);
-       if (ret)
-               return ret;
-
-       *inode_u = inode->ei_inode;
-
-       if (set) {
-               ret = set(inode, inode_u, p);
-               if (ret)
-                       return ret;
-       }
-
-       inode_p = bch2_trans_kmalloc(trans, sizeof(*inode_p));
-       if (IS_ERR(inode_p))
-               return PTR_ERR(inode_p);
-
-       bch2_inode_pack(inode_p, inode_u);
-       bch2_trans_update(trans, iter, &inode_p->inode.k_i);
-
-       return 0;
-}
-
 int __must_check bch2_write_inode(struct bch_fs *c,
                                  struct bch_inode_info *inode,
                                  inode_set_fn set,
                                  void *p, unsigned fields)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
+       struct btree_iter iter = { NULL };
        struct bch_inode_unpacked inode_u;
        int ret;
-
-       bch2_trans_init(&trans, c, 0, 0);
 retry:
-       bch2_trans_begin(&trans);
-
-       ret = bch2_write_inode_trans(&trans, inode, &inode_u, set, p) ?:
-               bch2_trans_commit(&trans, NULL,
-                                 &inode->ei_journal_seq,
-                                 BTREE_INSERT_ATOMIC|
-                                 BTREE_INSERT_NOUNLOCK|
-                                 BTREE_INSERT_NOFAIL);
-       if (ret == -EINTR)
-               goto retry;
+       bch2_trans_begin(trans);
+
+       ret   = bch2_inode_peek(trans, &iter, &inode_u, inode_inum(inode),
+                               BTREE_ITER_INTENT) ?:
+               (set ? set(trans, inode, &inode_u, p) : 0) ?:
+               bch2_inode_write(trans, &iter, &inode_u) ?:
+               bch2_trans_commit(trans, NULL, NULL, BCH_TRANS_COMMIT_no_enospc);
 
        /*
         * the btree node lock protects inode->ei_inode, not ei_update_lock;
         * this is important for inode updates via bchfs_write_index_update
         */
        if (!ret)
-               bch2_inode_update_after_write(c, inode, &inode_u, fields);
+               bch2_inode_update_after_write(trans, inode, &inode_u, fields);
+
+       bch2_trans_iter_exit(trans, &iter);
 
-       bch2_trans_exit(&trans);
+       if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
+               goto retry;
+
+       bch2_fs_fatal_err_on(bch2_err_matches(ret, ENOENT), c,
+                            "inode %u:%llu not found when updating",
+                            inode_inum(inode).subvol,
+                            inode_inum(inode).inum);
+
+       bch2_trans_put(trans);
        return ret < 0 ? ret : 0;
 }
 
@@ -207,184 +151,150 @@ int bch2_fs_quota_transfer(struct bch_fs *c,
        return ret;
 }
 
-int bch2_reinherit_attrs_fn(struct bch_inode_info *inode,
-                           struct bch_inode_unpacked *bi,
-                           void *p)
+static int bch2_iget5_test(struct inode *vinode, void *p)
 {
-       struct bch_inode_info *dir = p;
-       u64 src, dst;
-       unsigned id;
-       int ret = 1;
-
-       for (id = 0; id < Inode_opt_nr; id++) {
-               if (bi->bi_fields_set & (1 << id))
-                       continue;
+       struct bch_inode_info *inode = to_bch_ei(vinode);
+       subvol_inum *inum = p;
 
-               src = bch2_inode_opt_get(&dir->ei_inode, id);
-               dst = bch2_inode_opt_get(bi, id);
+       return inode->ei_subvol == inum->subvol &&
+               inode->ei_inode.bi_inum == inum->inum;
+}
 
-               if (src == dst)
-                       continue;
+static int bch2_iget5_set(struct inode *vinode, void *p)
+{
+       struct bch_inode_info *inode = to_bch_ei(vinode);
+       subvol_inum *inum = p;
 
-               bch2_inode_opt_set(bi, id, src);
-               ret = 0;
-       }
+       inode->v.i_ino          = inum->inum;
+       inode->ei_subvol        = inum->subvol;
+       inode->ei_inode.bi_inum = inum->inum;
+       return 0;
+}
 
-       return ret;
+static unsigned bch2_inode_hash(subvol_inum inum)
+{
+       return jhash_3words(inum.subvol, inum.inum >> 32, inum.inum, JHASH_INITVAL);
 }
 
-struct inode *bch2_vfs_inode_get(struct bch_fs *c, u64 inum)
+struct inode *bch2_vfs_inode_get(struct bch_fs *c, subvol_inum inum)
 {
        struct bch_inode_unpacked inode_u;
        struct bch_inode_info *inode;
+       struct btree_trans *trans;
+       struct bch_subvolume subvol;
        int ret;
 
-       inode = to_bch_ei(iget_locked(c->vfs_sb, inum));
+       inode = to_bch_ei(iget5_locked(c->vfs_sb,
+                                      bch2_inode_hash(inum),
+                                      bch2_iget5_test,
+                                      bch2_iget5_set,
+                                      &inum));
        if (unlikely(!inode))
                return ERR_PTR(-ENOMEM);
        if (!(inode->v.i_state & I_NEW))
                return &inode->v;
 
-       ret = bch2_inode_find_by_inum(c, inum, &inode_u);
+       trans = bch2_trans_get(c);
+       ret = lockrestart_do(trans,
+               bch2_subvolume_get(trans, inum.subvol, true, 0, &subvol) ?:
+               bch2_inode_find_by_inum_trans(trans, inum, &inode_u));
+
+       if (!ret)
+               bch2_vfs_inode_init(trans, inum, inode, &inode_u, &subvol);
+       bch2_trans_put(trans);
+
        if (ret) {
                iget_failed(&inode->v);
-               return ERR_PTR(ret);
+               return ERR_PTR(bch2_err_class(ret));
        }
 
-       bch2_vfs_inode_init(c, inode, &inode_u);
-
-       inode->ei_journal_seq = bch2_inode_journal_seq(&c->journal, inum);
+       mutex_lock(&c->vfs_inodes_lock);
+       list_add(&inode->ei_vfs_inode_list, &c->vfs_inodes_list);
+       mutex_unlock(&c->vfs_inodes_lock);
 
        unlock_new_inode(&inode->v);
 
        return &inode->v;
 }
 
-static void bch2_inode_init_owner(struct bch_inode_unpacked *inode_u,
-                                 const struct inode *dir, umode_t mode)
-{
-       kuid_t uid = current_fsuid();
-       kgid_t gid;
-
-       if (dir && dir->i_mode & S_ISGID) {
-               gid = dir->i_gid;
-               if (S_ISDIR(mode))
-                       mode |= S_ISGID;
-       } else
-               gid = current_fsgid();
-
-       inode_u->bi_uid         = from_kuid(dir->i_sb->s_user_ns, uid);
-       inode_u->bi_gid         = from_kgid(dir->i_sb->s_user_ns, gid);
-       inode_u->bi_mode        = mode;
-}
-
-static int inode_update_for_create_fn(struct bch_inode_info *inode,
-                                     struct bch_inode_unpacked *bi,
-                                     void *p)
-{
-       struct bch_fs *c = inode->v.i_sb->s_fs_info;
-       struct bch_inode_unpacked *new_inode = p;
-
-       bi->bi_mtime = bi->bi_ctime = bch2_current_time(c);
-
-       if (S_ISDIR(new_inode->bi_mode))
-               bi->bi_nlink++;
-
-       return 0;
-}
-
-static struct bch_inode_info *
-__bch2_create(struct bch_inode_info *dir, struct dentry *dentry,
-             umode_t mode, dev_t rdev, bool tmpfile)
+struct bch_inode_info *
+__bch2_create(struct mnt_idmap *idmap,
+             struct bch_inode_info *dir, struct dentry *dentry,
+             umode_t mode, dev_t rdev, subvol_inum snapshot_src,
+             unsigned flags)
 {
        struct bch_fs *c = dir->v.i_sb->s_fs_info;
-       struct btree_trans trans;
+       struct btree_trans *trans;
        struct bch_inode_unpacked dir_u;
        struct bch_inode_info *inode, *old;
        struct bch_inode_unpacked inode_u;
-       struct bch_hash_info hash_info;
        struct posix_acl *default_acl = NULL, *acl = NULL;
+       subvol_inum inum;
+       struct bch_subvolume subvol;
        u64 journal_seq = 0;
        int ret;
 
-       bch2_inode_init(c, &inode_u, 0, 0, 0, rdev, &dir->ei_inode);
-       bch2_inode_init_owner(&inode_u, &dir->v, mode);
-
-       hash_info = bch2_hash_info_init(c, &inode_u);
-
-       if (tmpfile)
-               inode_u.bi_flags |= BCH_INODE_UNLINKED;
-
-       ret = bch2_quota_acct(c, bch_qid(&inode_u), Q_INO, 1,
-                             KEY_TYPE_QUOTA_PREALLOC);
-       if (ret)
-               return ERR_PTR(ret);
-
+       /*
+        * preallocate acls + vfs inode before btree transaction, so that
+        * nothing can fail after the transaction succeeds:
+        */
 #ifdef CONFIG_BCACHEFS_POSIX_ACL
-       ret = posix_acl_create(&dir->v, &inode_u.bi_mode, &default_acl, &acl);
+       ret = posix_acl_create(&dir->v, &mode, &default_acl, &acl);
        if (ret)
-               goto err;
+               return ERR_PTR(ret);
 #endif
-
-       /*
-        * preallocate vfs inode before btree transaction, so that nothing can
-        * fail after the transaction succeeds:
-        */
        inode = to_bch_ei(new_inode(c->vfs_sb));
        if (unlikely(!inode)) {
-               ret = -ENOMEM;
+               inode = ERR_PTR(-ENOMEM);
                goto err;
        }
 
-       if (!tmpfile)
+       bch2_inode_init_early(c, &inode_u);
+
+       if (!(flags & BCH_CREATE_TMPFILE))
                mutex_lock(&dir->ei_update_lock);
 
-       bch2_trans_init(&trans, c, 8, 1024);
+       trans = bch2_trans_get(c);
 retry:
-       bch2_trans_begin(&trans);
-
-       ret   = __bch2_inode_create(&trans, &inode_u,
-                                   BLOCKDEV_INODE_MAX, 0,
-                                   &c->unused_inode_hint) ?:
-               (default_acl
-                ? bch2_set_acl_trans(&trans, &inode_u, &hash_info,
-                                     default_acl, ACL_TYPE_DEFAULT)
-                : 0) ?:
-               (acl
-                ? bch2_set_acl_trans(&trans, &inode_u, &hash_info,
-                                     acl, ACL_TYPE_ACCESS)
-                : 0) ?:
-               (!tmpfile
-                ? __bch2_dirent_create(&trans, dir->v.i_ino,
-                                       &dir->ei_str_hash,
-                                       mode_to_type(mode),
-                                       &dentry->d_name,
-                                       inode_u.bi_inum,
-                                       BCH_HASH_SET_MUST_CREATE)
-               : 0) ?:
-               (!tmpfile
-                ? bch2_write_inode_trans(&trans, dir, &dir_u,
-                                         inode_update_for_create_fn,
-                                         &inode_u)
-                : 0) ?:
-               bch2_trans_commit(&trans, NULL,
-                                 &journal_seq,
-                                 BTREE_INSERT_ATOMIC|
-                                 BTREE_INSERT_NOUNLOCK);
-       if (ret == -EINTR)
-               goto retry;
+       bch2_trans_begin(trans);
+
+       ret   = bch2_subvol_is_ro_trans(trans, dir->ei_subvol) ?:
+               bch2_create_trans(trans,
+                                 inode_inum(dir), &dir_u, &inode_u,
+                                 !(flags & BCH_CREATE_TMPFILE)
+                                 ? &dentry->d_name : NULL,
+                                 from_kuid(i_user_ns(&dir->v), current_fsuid()),
+                                 from_kgid(i_user_ns(&dir->v), current_fsgid()),
+                                 mode, rdev,
+                                 default_acl, acl, snapshot_src, flags) ?:
+               bch2_quota_acct(c, bch_qid(&inode_u), Q_INO, 1,
+                               KEY_TYPE_QUOTA_PREALLOC);
        if (unlikely(ret))
+               goto err_before_quota;
+
+       inum.subvol = inode_u.bi_subvol ?: dir->ei_subvol;
+       inum.inum = inode_u.bi_inum;
+
+       ret   = bch2_subvolume_get(trans, inum.subvol, true,
+                                  BTREE_ITER_WITH_UPDATES, &subvol) ?:
+               bch2_trans_commit(trans, NULL, &journal_seq, 0);
+       if (unlikely(ret)) {
+               bch2_quota_acct(c, bch_qid(&inode_u), Q_INO, -1,
+                               KEY_TYPE_QUOTA_WARN);
+err_before_quota:
+               if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
+                       goto retry;
                goto err_trans;
+       }
 
-       if (!tmpfile) {
-               bch2_inode_update_after_write(c, dir, &dir_u,
+       if (!(flags & BCH_CREATE_TMPFILE)) {
+               bch2_inode_update_after_write(trans, dir, &dir_u,
                                              ATTR_MTIME|ATTR_CTIME);
-               journal_seq_copy(dir, journal_seq);
                mutex_unlock(&dir->ei_update_lock);
        }
 
-       bch2_vfs_inode_init(c, inode, &inode_u);
-       journal_seq_copy(inode, journal_seq);
+       bch2_iget5_set(&inode->v, &inum);
+       bch2_vfs_inode_init(trans, inum, inode, &inode_u, &subvol);
 
        set_cached_acl(&inode->v, ACL_TYPE_ACCESS, acl);
        set_cached_acl(&inode->v, ACL_TYPE_DEFAULT, default_acl);
@@ -395,18 +305,28 @@ retry:
         * thread pulling the inode in and modifying it:
         */
 
-       old = to_bch_ei(insert_inode_locked2(&inode->v));
-       if (unlikely(old)) {
+       inode->v.i_state |= I_CREATING;
+
+       old = to_bch_ei(inode_insert5(&inode->v,
+                                     bch2_inode_hash(inum),
+                                     bch2_iget5_test,
+                                     bch2_iget5_set,
+                                     &inum));
+       BUG_ON(!old);
+
+       if (unlikely(old != inode)) {
                /*
                 * We raced, another process pulled the new inode into cache
                 * before us:
                 */
-               old->ei_journal_seq = inode->ei_journal_seq;
                make_bad_inode(&inode->v);
                iput(&inode->v);
 
                inode = old;
        } else {
+               mutex_lock(&c->vfs_inodes_lock);
+               list_add(&inode->ei_vfs_inode_list, &c->vfs_inodes_list);
+               mutex_unlock(&c->vfs_inodes_lock);
                /*
                 * we really don't want insert_inode_locked2() to be setting
                 * I_NEW...
@@ -414,22 +334,20 @@ retry:
                unlock_new_inode(&inode->v);
        }
 
-       bch2_trans_exit(&trans);
-out:
+       bch2_trans_put(trans);
+err:
        posix_acl_release(default_acl);
        posix_acl_release(acl);
        return inode;
 err_trans:
-       if (!tmpfile)
+       if (!(flags & BCH_CREATE_TMPFILE))
                mutex_unlock(&dir->ei_update_lock);
 
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
        make_bad_inode(&inode->v);
        iput(&inode->v);
-err:
-       bch2_quota_acct(c, bch_qid(&inode_u), Q_INO, -1, KEY_TYPE_QUOTA_WARN);
        inode = ERR_PTR(ret);
-       goto out;
+       goto err;
 }
 
 /* methods */
@@ -439,41 +357,40 @@ static struct dentry *bch2_lookup(struct inode *vdir, struct dentry *dentry,
 {
        struct bch_fs *c = vdir->i_sb->s_fs_info;
        struct bch_inode_info *dir = to_bch_ei(vdir);
+       struct bch_hash_info hash = bch2_hash_info_init(c, &dir->ei_inode);
        struct inode *vinode = NULL;
-       u64 inum;
+       subvol_inum inum = { .subvol = 1 };
+       int ret;
 
-       inum = bch2_dirent_lookup(c, dir->v.i_ino,
-                                 &dir->ei_str_hash,
-                                 &dentry->d_name);
+       ret = bch2_dirent_lookup(c, inode_inum(dir), &hash,
+                                &dentry->d_name, &inum);
 
-       if (inum)
+       if (!ret)
                vinode = bch2_vfs_inode_get(c, inum);
 
        return d_splice_alias(vinode, dentry);
 }
 
-static int bch2_create(struct inode *vdir, struct dentry *dentry,
-                      umode_t mode, bool excl)
+static int bch2_mknod(struct mnt_idmap *idmap,
+                     struct inode *vdir, struct dentry *dentry,
+                     umode_t mode, dev_t rdev)
 {
        struct bch_inode_info *inode =
-               __bch2_create(to_bch_ei(vdir), dentry, mode|S_IFREG, 0, false);
+               __bch2_create(idmap, to_bch_ei(vdir), dentry, mode, rdev,
+                             (subvol_inum) { 0 }, 0);
 
        if (IS_ERR(inode))
-               return PTR_ERR(inode);
+               return bch2_err_class(PTR_ERR(inode));
 
        d_instantiate(dentry, &inode->v);
        return 0;
 }
 
-static int inode_update_for_link_fn(struct bch_inode_info *inode,
-                                   struct bch_inode_unpacked *bi,
-                                   void *p)
+static int bch2_create(struct mnt_idmap *idmap,
+                      struct inode *vdir, struct dentry *dentry,
+                      umode_t mode, bool excl)
 {
-       struct bch_fs *c = inode->v.i_sb->s_fs_info;
-
-       bi->bi_ctime = bch2_current_time(c);
-       bch2_inode_nlink_inc(bi);
-       return 0;
+       return bch2_mknod(idmap, vdir, dentry, mode|S_IFREG, 0);
 }
 
 static int __bch2_link(struct bch_fs *c,
@@ -481,36 +398,25 @@ static int __bch2_link(struct bch_fs *c,
                       struct bch_inode_info *dir,
                       struct dentry *dentry)
 {
-       struct btree_trans trans;
-       struct bch_inode_unpacked inode_u;
+       struct btree_trans *trans = bch2_trans_get(c);
+       struct bch_inode_unpacked dir_u, inode_u;
        int ret;
 
        mutex_lock(&inode->ei_update_lock);
-       bch2_trans_init(&trans, c, 4, 1024);
-retry:
-       bch2_trans_begin(&trans);
-
-       ret   = __bch2_dirent_create(&trans, dir->v.i_ino,
-                                    &dir->ei_str_hash,
-                                    mode_to_type(inode->v.i_mode),
-                                    &dentry->d_name,
-                                    inode->v.i_ino,
-                                    BCH_HASH_SET_MUST_CREATE) ?:
-               bch2_write_inode_trans(&trans, inode, &inode_u,
-                                      inode_update_for_link_fn,
-                                      NULL) ?:
-               bch2_trans_commit(&trans, NULL,
-                                 &inode->ei_journal_seq,
-                                 BTREE_INSERT_ATOMIC|
-                                 BTREE_INSERT_NOUNLOCK);
-
-       if (ret == -EINTR)
-               goto retry;
 
-       if (likely(!ret))
-               bch2_inode_update_after_write(c, inode, &inode_u, ATTR_CTIME);
+       ret = commit_do(trans, NULL, NULL, 0,
+                       bch2_link_trans(trans,
+                                       inode_inum(dir),   &dir_u,
+                                       inode_inum(inode), &inode_u,
+                                       &dentry->d_name));
 
-       bch2_trans_exit(&trans);
+       if (likely(!ret)) {
+               bch2_inode_update_after_write(trans, dir, &dir_u,
+                                             ATTR_MTIME|ATTR_CTIME);
+               bch2_inode_update_after_write(trans, inode, &inode_u, ATTR_CTIME);
+       }
+
+       bch2_trans_put(trans);
        mutex_unlock(&inode->ei_update_lock);
        return ret;
 }
@@ -525,7 +431,9 @@ static int bch2_link(struct dentry *old_dentry, struct inode *vdir,
 
        lockdep_assert_held(&inode->v.i_rwsem);
 
-       ret = __bch2_link(c, inode, dir, dentry);
+       ret   = bch2_subvol_is_ro(c, dir->ei_subvol) ?:
+               bch2_subvol_is_ro(c, inode->ei_subvol) ?:
+               __bch2_link(c, inode, dir, dentry);
        if (unlikely(ret))
                return ret;
 
@@ -534,88 +442,67 @@ static int bch2_link(struct dentry *old_dentry, struct inode *vdir,
        return 0;
 }
 
-static int inode_update_dir_for_unlink_fn(struct bch_inode_info *inode,
-                                         struct bch_inode_unpacked *bi,
-                                         void *p)
-{
-       struct bch_fs *c = inode->v.i_sb->s_fs_info;
-       struct bch_inode_info *unlink_inode = p;
-
-       bi->bi_mtime = bi->bi_ctime = bch2_current_time(c);
-
-       bi->bi_nlink -= S_ISDIR(unlink_inode->v.i_mode);
-
-       return 0;
-}
-
-static int inode_update_for_unlink_fn(struct bch_inode_info *inode,
-                                     struct bch_inode_unpacked *bi,
-                                     void *p)
-{
-       struct bch_fs *c = inode->v.i_sb->s_fs_info;
-
-       bi->bi_ctime = bch2_current_time(c);
-       bch2_inode_nlink_dec(bi);
-       return 0;
-}
-
-static int bch2_unlink(struct inode *vdir, struct dentry *dentry)
+int __bch2_unlink(struct inode *vdir, struct dentry *dentry,
+                 bool deleting_snapshot)
 {
        struct bch_fs *c = vdir->i_sb->s_fs_info;
        struct bch_inode_info *dir = to_bch_ei(vdir);
        struct bch_inode_info *inode = to_bch_ei(dentry->d_inode);
        struct bch_inode_unpacked dir_u, inode_u;
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        int ret;
 
        bch2_lock_inodes(INODE_UPDATE_LOCK, dir, inode);
-       bch2_trans_init(&trans, c, 4, 1024);
-retry:
-       bch2_trans_begin(&trans);
-
-       ret   = __bch2_dirent_delete(&trans, dir->v.i_ino,
-                                    &dir->ei_str_hash,
-                                    &dentry->d_name) ?:
-               bch2_write_inode_trans(&trans, dir, &dir_u,
-                                      inode_update_dir_for_unlink_fn,
-                                      inode) ?:
-               bch2_write_inode_trans(&trans, inode, &inode_u,
-                                      inode_update_for_unlink_fn,
-                                      NULL) ?:
-               bch2_trans_commit(&trans, NULL,
-                                 &dir->ei_journal_seq,
-                                 BTREE_INSERT_ATOMIC|
-                                 BTREE_INSERT_NOUNLOCK|
-                                 BTREE_INSERT_NOFAIL);
-       if (ret == -EINTR)
-               goto retry;
-       if (ret)
-               goto err;
 
-       if (dir->ei_journal_seq > inode->ei_journal_seq)
-               inode->ei_journal_seq = dir->ei_journal_seq;
+       ret = commit_do(trans, NULL, NULL,
+                       BCH_TRANS_COMMIT_no_enospc,
+               bch2_unlink_trans(trans,
+                                 inode_inum(dir), &dir_u,
+                                 &inode_u, &dentry->d_name,
+                                 deleting_snapshot));
+       if (unlikely(ret))
+               goto err;
 
-       bch2_inode_update_after_write(c, dir, &dir_u,
+       bch2_inode_update_after_write(trans, dir, &dir_u,
                                      ATTR_MTIME|ATTR_CTIME);
-       bch2_inode_update_after_write(c, inode, &inode_u,
+       bch2_inode_update_after_write(trans, inode, &inode_u,
                                      ATTR_MTIME);
+
+       if (inode_u.bi_subvol) {
+               /*
+                * Subvolume deletion is asynchronous, but we still want to tell
+                * the VFS that it's been deleted here:
+                */
+               set_nlink(&inode->v, 0);
+       }
 err:
-       bch2_trans_exit(&trans);
        bch2_unlock_inodes(INODE_UPDATE_LOCK, dir, inode);
+       bch2_trans_put(trans);
 
        return ret;
 }
 
-static int bch2_symlink(struct inode *vdir, struct dentry *dentry,
+static int bch2_unlink(struct inode *vdir, struct dentry *dentry)
+{
+       struct bch_inode_info *dir= to_bch_ei(vdir);
+       struct bch_fs *c = dir->v.i_sb->s_fs_info;
+
+       return bch2_subvol_is_ro(c, dir->ei_subvol) ?:
+               __bch2_unlink(vdir, dentry, false);
+}
+
+static int bch2_symlink(struct mnt_idmap *idmap,
+                       struct inode *vdir, struct dentry *dentry,
                        const char *symname)
 {
        struct bch_fs *c = vdir->i_sb->s_fs_info;
        struct bch_inode_info *dir = to_bch_ei(vdir), *inode;
        int ret;
 
-       inode = __bch2_create(dir, dentry, S_IFLNK|S_IRWXUGO, 0, true);
-       if (unlikely(IS_ERR(inode)))
-               return PTR_ERR(inode);
+       inode = __bch2_create(idmap, dir, dentry, S_IFLNK|S_IRWXUGO, 0,
+                             (subvol_inum) { 0 }, BCH_CREATE_TMPFILE);
+       if (IS_ERR(inode))
+               return bch2_err_class(PTR_ERR(inode));
 
        inode_lock(&inode->v);
        ret = page_symlink(&inode->v, symname, strlen(symname) + 1);
@@ -628,8 +515,6 @@ static int bch2_symlink(struct inode *vdir, struct dentry *dentry,
        if (unlikely(ret))
                goto err;
 
-       journal_seq_copy(dir, inode->ei_journal_seq);
-
        ret = __bch2_link(c, inode, dir, dentry);
        if (unlikely(ret))
                goto err;
@@ -641,260 +526,139 @@ err:
        return ret;
 }
 
-static int bch2_mkdir(struct inode *vdir, struct dentry *dentry, umode_t mode)
+static int bch2_mkdir(struct mnt_idmap *idmap,
+                     struct inode *vdir, struct dentry *dentry, umode_t mode)
 {
-       struct bch_inode_info *inode =
-               __bch2_create(to_bch_ei(vdir), dentry, mode|S_IFDIR, 0, false);
-
-       if (IS_ERR(inode))
-               return PTR_ERR(inode);
-
-       d_instantiate(dentry, &inode->v);
-       return 0;
-}
-
-static int bch2_rmdir(struct inode *vdir, struct dentry *dentry)
-{
-       struct bch_fs *c = vdir->i_sb->s_fs_info;
-
-       if (bch2_empty_dir(c, dentry->d_inode->i_ino))
-               return -ENOTEMPTY;
-
-       return bch2_unlink(vdir, dentry);
-}
-
-static int bch2_mknod(struct inode *vdir, struct dentry *dentry,
-                     umode_t mode, dev_t rdev)
-{
-       struct bch_inode_info *inode =
-               __bch2_create(to_bch_ei(vdir), dentry, mode, rdev, false);
-
-       if (IS_ERR(inode))
-               return PTR_ERR(inode);
-
-       d_instantiate(dentry, &inode->v);
-       return 0;
-}
-
-struct rename_info {
-       u64                     now;
-       struct bch_inode_info   *src_dir;
-       struct bch_inode_info   *dst_dir;
-       struct bch_inode_info   *src_inode;
-       struct bch_inode_info   *dst_inode;
-       enum bch_rename_mode    mode;
-};
-
-static int inode_update_for_rename_fn(struct bch_inode_info *inode,
-                                     struct bch_inode_unpacked *bi,
-                                     void *p)
-{
-       struct rename_info *info = p;
-       int ret;
-
-       if (inode == info->src_dir) {
-               bi->bi_nlink -= S_ISDIR(info->src_inode->v.i_mode);
-               bi->bi_nlink += info->dst_inode &&
-                       S_ISDIR(info->dst_inode->v.i_mode) &&
-                       info->mode == BCH_RENAME_EXCHANGE;
-       }
-
-       if (inode == info->dst_dir) {
-               bi->bi_nlink += S_ISDIR(info->src_inode->v.i_mode);
-               bi->bi_nlink -= info->dst_inode &&
-                       S_ISDIR(info->dst_inode->v.i_mode);
-       }
-
-       if (inode == info->src_inode) {
-               ret = bch2_reinherit_attrs_fn(inode, bi, info->dst_dir);
-
-               BUG_ON(!ret && S_ISDIR(info->src_inode->v.i_mode));
-       }
-
-       if (inode == info->dst_inode &&
-           info->mode == BCH_RENAME_EXCHANGE) {
-               ret = bch2_reinherit_attrs_fn(inode, bi, info->src_dir);
-
-               BUG_ON(!ret && S_ISDIR(info->dst_inode->v.i_mode));
-       }
-
-       if (inode == info->dst_inode &&
-           info->mode == BCH_RENAME_OVERWRITE) {
-               BUG_ON(bi->bi_nlink &&
-                      S_ISDIR(info->dst_inode->v.i_mode));
-
-               bch2_inode_nlink_dec(bi);
-       }
-
-       if (inode == info->src_dir ||
-           inode == info->dst_dir)
-               bi->bi_mtime = info->now;
-       bi->bi_ctime = info->now;
-
-       return 0;
+       return bch2_mknod(idmap, vdir, dentry, mode|S_IFDIR, 0);
 }
 
-static int bch2_rename2(struct inode *src_vdir, struct dentry *src_dentry,
+static int bch2_rename2(struct mnt_idmap *idmap,
+                       struct inode *src_vdir, struct dentry *src_dentry,
                        struct inode *dst_vdir, struct dentry *dst_dentry,
                        unsigned flags)
 {
        struct bch_fs *c = src_vdir->i_sb->s_fs_info;
-       struct rename_info i = {
-               .src_dir        = to_bch_ei(src_vdir),
-               .dst_dir        = to_bch_ei(dst_vdir),
-               .src_inode      = to_bch_ei(src_dentry->d_inode),
-               .dst_inode      = to_bch_ei(dst_dentry->d_inode),
-               .mode           = flags & RENAME_EXCHANGE
-                               ? BCH_RENAME_EXCHANGE
-                       : dst_dentry->d_inode
-                               ? BCH_RENAME_OVERWRITE : BCH_RENAME,
-       };
-       struct btree_trans trans;
+       struct bch_inode_info *src_dir = to_bch_ei(src_vdir);
+       struct bch_inode_info *dst_dir = to_bch_ei(dst_vdir);
+       struct bch_inode_info *src_inode = to_bch_ei(src_dentry->d_inode);
+       struct bch_inode_info *dst_inode = to_bch_ei(dst_dentry->d_inode);
        struct bch_inode_unpacked dst_dir_u, src_dir_u;
        struct bch_inode_unpacked src_inode_u, dst_inode_u;
-       u64 journal_seq = 0;
+       struct btree_trans *trans;
+       enum bch_rename_mode mode = flags & RENAME_EXCHANGE
+               ? BCH_RENAME_EXCHANGE
+               : dst_dentry->d_inode
+               ? BCH_RENAME_OVERWRITE : BCH_RENAME;
        int ret;
 
        if (flags & ~(RENAME_NOREPLACE|RENAME_EXCHANGE))
                return -EINVAL;
 
-       if (i.mode == BCH_RENAME_OVERWRITE) {
-               if (S_ISDIR(i.src_inode->v.i_mode) !=
-                   S_ISDIR(i.dst_inode->v.i_mode))
-                       return -ENOTDIR;
-
-               if (S_ISDIR(i.src_inode->v.i_mode) &&
-                   bch2_empty_dir(c, i.dst_inode->v.i_ino))
-                       return -ENOTEMPTY;
-
-               ret = filemap_write_and_wait_range(i.src_inode->v.i_mapping,
+       if (mode == BCH_RENAME_OVERWRITE) {
+               ret = filemap_write_and_wait_range(src_inode->v.i_mapping,
                                                   0, LLONG_MAX);
                if (ret)
                        return ret;
        }
 
-       bch2_trans_init(&trans, c, 8, 2048);
+       trans = bch2_trans_get(c);
 
        bch2_lock_inodes(INODE_UPDATE_LOCK,
-                        i.src_dir,
-                        i.dst_dir,
-                        i.src_inode,
-                        i.dst_inode);
-
-       if (S_ISDIR(i.src_inode->v.i_mode) &&
-           inode_attrs_changing(i.dst_dir, i.src_inode)) {
-               ret = -EXDEV;
-               goto err;
-       }
+                        src_dir,
+                        dst_dir,
+                        src_inode,
+                        dst_inode);
 
-       if (i.mode == BCH_RENAME_EXCHANGE &&
-           S_ISDIR(i.dst_inode->v.i_mode) &&
-           inode_attrs_changing(i.src_dir, i.dst_inode)) {
-               ret = -EXDEV;
+       ret   = bch2_subvol_is_ro_trans(trans, src_dir->ei_subvol) ?:
+               bch2_subvol_is_ro_trans(trans, dst_dir->ei_subvol);
+       if (ret)
                goto err;
-       }
 
-       if (inode_attr_changing(i.dst_dir, i.src_inode, Inode_opt_project)) {
-               ret = bch2_fs_quota_transfer(c, i.src_inode,
-                                            i.dst_dir->ei_qid,
+       if (inode_attr_changing(dst_dir, src_inode, Inode_opt_project)) {
+               ret = bch2_fs_quota_transfer(c, src_inode,
+                                            dst_dir->ei_qid,
                                             1 << QTYP_PRJ,
                                             KEY_TYPE_QUOTA_PREALLOC);
                if (ret)
                        goto err;
        }
 
-       if (i.mode == BCH_RENAME_EXCHANGE &&
-           inode_attr_changing(i.src_dir, i.dst_inode, Inode_opt_project)) {
-               ret = bch2_fs_quota_transfer(c, i.dst_inode,
-                                            i.src_dir->ei_qid,
+       if (mode == BCH_RENAME_EXCHANGE &&
+           inode_attr_changing(src_dir, dst_inode, Inode_opt_project)) {
+               ret = bch2_fs_quota_transfer(c, dst_inode,
+                                            src_dir->ei_qid,
                                             1 << QTYP_PRJ,
                                             KEY_TYPE_QUOTA_PREALLOC);
                if (ret)
                        goto err;
        }
 
-retry:
-       bch2_trans_begin(&trans);
-       i.now = bch2_current_time(c);
-
-       ret   = bch2_dirent_rename(&trans,
-                                  i.src_dir, &src_dentry->d_name,
-                                  i.dst_dir, &dst_dentry->d_name,
-                                  i.mode) ?:
-               bch2_write_inode_trans(&trans, i.src_dir, &src_dir_u,
-                                      inode_update_for_rename_fn, &i) ?:
-               (i.src_dir != i.dst_dir
-                ? bch2_write_inode_trans(&trans, i.dst_dir, &dst_dir_u,
-                                      inode_update_for_rename_fn, &i)
-                : 0 ) ?:
-               bch2_write_inode_trans(&trans, i.src_inode, &src_inode_u,
-                                      inode_update_for_rename_fn, &i) ?:
-               (i.dst_inode
-                ? bch2_write_inode_trans(&trans, i.dst_inode, &dst_inode_u,
-                                      inode_update_for_rename_fn, &i)
-                : 0 ) ?:
-               bch2_trans_commit(&trans, NULL,
-                                 &journal_seq,
-                                 BTREE_INSERT_ATOMIC|
-                                 BTREE_INSERT_NOUNLOCK);
-       if (ret == -EINTR)
-               goto retry;
+       ret = commit_do(trans, NULL, NULL, 0,
+                       bch2_rename_trans(trans,
+                                         inode_inum(src_dir), &src_dir_u,
+                                         inode_inum(dst_dir), &dst_dir_u,
+                                         &src_inode_u,
+                                         &dst_inode_u,
+                                         &src_dentry->d_name,
+                                         &dst_dentry->d_name,
+                                         mode));
        if (unlikely(ret))
                goto err;
 
-       bch2_inode_update_after_write(c, i.src_dir, &src_dir_u,
+       BUG_ON(src_inode->v.i_ino != src_inode_u.bi_inum);
+       BUG_ON(dst_inode &&
+              dst_inode->v.i_ino != dst_inode_u.bi_inum);
+
+       bch2_inode_update_after_write(trans, src_dir, &src_dir_u,
                                      ATTR_MTIME|ATTR_CTIME);
-       journal_seq_copy(i.src_dir, journal_seq);
 
-       if (i.src_dir != i.dst_dir) {
-               bch2_inode_update_after_write(c, i.dst_dir, &dst_dir_u,
+       if (src_dir != dst_dir)
+               bch2_inode_update_after_write(trans, dst_dir, &dst_dir_u,
                                              ATTR_MTIME|ATTR_CTIME);
-               journal_seq_copy(i.dst_dir, journal_seq);
-       }
 
-       journal_seq_copy(i.src_inode, journal_seq);
-       if (i.dst_inode)
-               journal_seq_copy(i.dst_inode, journal_seq);
-
-       bch2_inode_update_after_write(c, i.src_inode, &src_inode_u,
+       bch2_inode_update_after_write(trans, src_inode, &src_inode_u,
                                      ATTR_CTIME);
-       if (i.dst_inode)
-               bch2_inode_update_after_write(c, i.dst_inode, &dst_inode_u,
+
+       if (dst_inode)
+               bch2_inode_update_after_write(trans, dst_inode, &dst_inode_u,
                                              ATTR_CTIME);
 err:
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
 
-       bch2_fs_quota_transfer(c, i.src_inode,
-                              bch_qid(&i.src_inode->ei_inode),
+       bch2_fs_quota_transfer(c, src_inode,
+                              bch_qid(&src_inode->ei_inode),
                               1 << QTYP_PRJ,
                               KEY_TYPE_QUOTA_NOCHECK);
-       if (i.dst_inode)
-               bch2_fs_quota_transfer(c, i.dst_inode,
-                                      bch_qid(&i.dst_inode->ei_inode),
+       if (dst_inode)
+               bch2_fs_quota_transfer(c, dst_inode,
+                                      bch_qid(&dst_inode->ei_inode),
                                       1 << QTYP_PRJ,
                                       KEY_TYPE_QUOTA_NOCHECK);
 
        bch2_unlock_inodes(INODE_UPDATE_LOCK,
-                          i.src_dir,
-                          i.dst_dir,
-                          i.src_inode,
-                          i.dst_inode);
+                          src_dir,
+                          dst_dir,
+                          src_inode,
+                          dst_inode);
 
        return ret;
 }
 
-static int inode_update_for_setattr_fn(struct bch_inode_info *inode,
-                                      struct bch_inode_unpacked *bi,
-                                      void *p)
+static void bch2_setattr_copy(struct mnt_idmap *idmap,
+                             struct bch_inode_info *inode,
+                             struct bch_inode_unpacked *bi,
+                             struct iattr *attr)
 {
        struct bch_fs *c = inode->v.i_sb->s_fs_info;
-       struct iattr *attr = p;
        unsigned int ia_valid = attr->ia_valid;
 
        if (ia_valid & ATTR_UID)
-               bi->bi_uid = from_kuid(inode->v.i_sb->s_user_ns, attr->ia_uid);
+               bi->bi_uid = from_kuid(i_user_ns(&inode->v), attr->ia_uid);
        if (ia_valid & ATTR_GID)
-               bi->bi_gid = from_kgid(inode->v.i_sb->s_user_ns, attr->ia_gid);
+               bi->bi_gid = from_kgid(i_user_ns(&inode->v), attr->ia_gid);
+
+       if (ia_valid & ATTR_SIZE)
+               bi->bi_size = attr->ia_size;
 
        if (ia_valid & ATTR_ATIME)
                bi->bi_atime = timespec_to_bch2_time(c, attr->ia_atime);
@@ -910,19 +674,20 @@ static int inode_update_for_setattr_fn(struct bch_inode_info *inode,
                        : inode->v.i_gid;
 
                if (!in_group_p(gid) &&
-                   !capable_wrt_inode_uidgid(&inode->v, CAP_FSETID))
+                   !capable_wrt_inode_uidgid(idmap, &inode->v, CAP_FSETID))
                        mode &= ~S_ISGID;
                bi->bi_mode = mode;
        }
-
-       return 0;
 }
 
-static int bch2_setattr_nonsize(struct bch_inode_info *inode, struct iattr *iattr)
+int bch2_setattr_nonsize(struct mnt_idmap *idmap,
+                        struct bch_inode_info *inode,
+                        struct iattr *attr)
 {
        struct bch_fs *c = inode->v.i_sb->s_fs_info;
        struct bch_qid qid;
-       struct btree_trans trans;
+       struct btree_trans *trans;
+       struct btree_iter inode_iter = { NULL };
        struct bch_inode_unpacked inode_u;
        struct posix_acl *acl = NULL;
        int ret;
@@ -931,51 +696,62 @@ static int bch2_setattr_nonsize(struct bch_inode_info *inode, struct iattr *iatt
 
        qid = inode->ei_qid;
 
-       if (iattr->ia_valid & ATTR_UID)
-               qid.q[QTYP_USR] = from_kuid(&init_user_ns, iattr->ia_uid);
+       if (attr->ia_valid & ATTR_UID)
+               qid.q[QTYP_USR] = from_kuid(i_user_ns(&inode->v), attr->ia_uid);
 
-       if (iattr->ia_valid & ATTR_GID)
-               qid.q[QTYP_GRP] = from_kgid(&init_user_ns, iattr->ia_gid);
+       if (attr->ia_valid & ATTR_GID)
+               qid.q[QTYP_GRP] = from_kgid(i_user_ns(&inode->v), attr->ia_gid);
 
        ret = bch2_fs_quota_transfer(c, inode, qid, ~0,
                                     KEY_TYPE_QUOTA_PREALLOC);
        if (ret)
                goto err;
 
-       bch2_trans_init(&trans, c, 0, 0);
+       trans = bch2_trans_get(c);
 retry:
-       bch2_trans_begin(&trans);
+       bch2_trans_begin(trans);
        kfree(acl);
        acl = NULL;
 
-       ret = bch2_write_inode_trans(&trans, inode, &inode_u,
-                               inode_update_for_setattr_fn, iattr) ?:
-               (iattr->ia_valid & ATTR_MODE
-                ? bch2_acl_chmod(&trans, inode, iattr->ia_mode, &acl)
-                : 0) ?:
-               bch2_trans_commit(&trans, NULL,
-                                 &inode->ei_journal_seq,
-                                 BTREE_INSERT_ATOMIC|
-                                 BTREE_INSERT_NOUNLOCK|
-                                 BTREE_INSERT_NOFAIL);
-       if (ret == -EINTR)
+       ret = bch2_inode_peek(trans, &inode_iter, &inode_u, inode_inum(inode),
+                             BTREE_ITER_INTENT);
+       if (ret)
+               goto btree_err;
+
+       bch2_setattr_copy(idmap, inode, &inode_u, attr);
+
+       if (attr->ia_valid & ATTR_MODE) {
+               ret = bch2_acl_chmod(trans, inode_inum(inode), &inode_u,
+                                    inode_u.bi_mode, &acl);
+               if (ret)
+                       goto btree_err;
+       }
+
+       ret =   bch2_inode_write(trans, &inode_iter, &inode_u) ?:
+               bch2_trans_commit(trans, NULL, NULL,
+                                 BCH_TRANS_COMMIT_no_enospc);
+btree_err:
+       bch2_trans_iter_exit(trans, &inode_iter);
+
+       if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
                goto retry;
        if (unlikely(ret))
                goto err_trans;
 
-       bch2_inode_update_after_write(c, inode, &inode_u, iattr->ia_valid);
+       bch2_inode_update_after_write(trans, inode, &inode_u, attr->ia_valid);
 
        if (acl)
                set_cached_acl(&inode->v, ACL_TYPE_ACCESS, acl);
 err_trans:
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
 err:
        mutex_unlock(&inode->ei_update_lock);
 
-       return ret;
+       return bch2_err_class(ret);
 }
 
-static int bch2_getattr(const struct path *path, struct kstat *stat,
+static int bch2_getattr(struct mnt_idmap *idmap,
+                       const struct path *path, struct kstat *stat,
                        u32 request_mask, unsigned query_flags)
 {
        struct bch_inode_info *inode = to_bch_ei(d_inode(path->dentry));
@@ -989,9 +765,9 @@ static int bch2_getattr(const struct path *path, struct kstat *stat,
        stat->gid       = inode->v.i_gid;
        stat->rdev      = inode->v.i_rdev;
        stat->size      = i_size_read(&inode->v);
-       stat->atime     = inode->v.i_atime;
-       stat->mtime     = inode->v.i_mtime;
-       stat->ctime     = inode->v.i_ctime;
+       stat->atime     = inode_get_atime(&inode->v);
+       stat->mtime     = inode_get_mtime(&inode->v);
+       stat->ctime     = inode_get_ctime(&inode->v);
        stat->blksize   = block_bytes(c);
        stat->blocks    = inode->v.i_blocks;
 
@@ -1000,50 +776,61 @@ static int bch2_getattr(const struct path *path, struct kstat *stat,
                stat->btime = bch2_time_to_timespec(c, inode->ei_inode.bi_otime);
        }
 
-       if (inode->ei_inode.bi_flags & BCH_INODE_IMMUTABLE)
+       if (inode->ei_inode.bi_flags & BCH_INODE_immutable)
                stat->attributes |= STATX_ATTR_IMMUTABLE;
-       if (inode->ei_inode.bi_flags & BCH_INODE_APPEND)
+       stat->attributes_mask    |= STATX_ATTR_IMMUTABLE;
+
+       if (inode->ei_inode.bi_flags & BCH_INODE_append)
                stat->attributes |= STATX_ATTR_APPEND;
-       if (inode->ei_inode.bi_flags & BCH_INODE_NODUMP)
+       stat->attributes_mask    |= STATX_ATTR_APPEND;
+
+       if (inode->ei_inode.bi_flags & BCH_INODE_nodump)
                stat->attributes |= STATX_ATTR_NODUMP;
+       stat->attributes_mask    |= STATX_ATTR_NODUMP;
 
        return 0;
 }
 
-static int bch2_setattr(struct dentry *dentry, struct iattr *iattr)
+static int bch2_setattr(struct mnt_idmap *idmap,
+                       struct dentry *dentry, struct iattr *iattr)
 {
        struct bch_inode_info *inode = to_bch_ei(dentry->d_inode);
+       struct bch_fs *c = inode->v.i_sb->s_fs_info;
        int ret;
 
        lockdep_assert_held(&inode->v.i_rwsem);
 
-       ret = setattr_prepare(dentry, iattr);
+       ret   = bch2_subvol_is_ro(c, inode->ei_subvol) ?:
+               setattr_prepare(idmap, dentry, iattr);
        if (ret)
                return ret;
 
        return iattr->ia_valid & ATTR_SIZE
-               ? bch2_truncate(inode, iattr)
-               : bch2_setattr_nonsize(inode, iattr);
+               ? bchfs_truncate(idmap, inode, iattr)
+               : bch2_setattr_nonsize(idmap, inode, iattr);
 }
 
-static int bch2_tmpfile(struct inode *vdir, struct dentry *dentry, umode_t mode)
+static int bch2_tmpfile(struct mnt_idmap *idmap,
+                       struct inode *vdir, struct file *file, umode_t mode)
 {
        struct bch_inode_info *inode =
-               __bch2_create(to_bch_ei(vdir), dentry, mode, 0, true);
+               __bch2_create(idmap, to_bch_ei(vdir),
+                             file->f_path.dentry, mode, 0,
+                             (subvol_inum) { 0 }, BCH_CREATE_TMPFILE);
 
        if (IS_ERR(inode))
-               return PTR_ERR(inode);
+               return bch2_err_class(PTR_ERR(inode));
 
-       d_mark_tmpfile(dentry, &inode->v);
-       d_instantiate(dentry, &inode->v);
-       return 0;
+       d_mark_tmpfile(file, &inode->v);
+       d_instantiate(file->f_path.dentry, &inode->v);
+       return finish_open_simple(file, 0);
 }
 
 static int bch2_fill_extent(struct bch_fs *c,
                            struct fiemap_extent_info *info,
                            struct bkey_s_c k, unsigned flags)
 {
-       if (bkey_extent_is_data(k.k)) {
+       if (bkey_extent_is_direct_data(k.k)) {
                struct bkey_ptrs_c ptrs = bch2_bkey_ptrs_c(k);
                const union bch_extent_entry *entry;
                struct extent_ptr_decoded p;
@@ -1056,13 +843,16 @@ static int bch2_fill_extent(struct bch_fs *c,
                        int flags2 = 0;
                        u64 offset = p.ptr.offset;
 
+                       if (p.ptr.unwritten)
+                               flags2 |= FIEMAP_EXTENT_UNWRITTEN;
+
                        if (p.crc.compression_type)
                                flags2 |= FIEMAP_EXTENT_ENCODED;
                        else
                                offset += p.crc.offset;
 
-                       if ((offset & (c->opts.block_size - 1)) ||
-                           (k.k->size & (c->opts.block_size - 1)))
+                       if ((offset & (block_sectors(c) - 1)) ||
+                           (k.k->size & (block_sectors(c) - 1)))
                                flags2 |= FIEMAP_EXTENT_NOT_ALIGNED;
 
                        ret = fiemap_fill_next_extent(info,
@@ -1074,6 +864,12 @@ static int bch2_fill_extent(struct bch_fs *c,
                }
 
                return 0;
+       } else if (bkey_extent_is_inline_data(k.k)) {
+               return fiemap_fill_next_extent(info,
+                                              bkey_start_offset(k.k) << 9,
+                                              0, k.k->size << 9,
+                                              flags|
+                                              FIEMAP_EXTENT_DATA_INLINE);
        } else if (k.k->type == KEY_TYPE_reservation) {
                return fiemap_fill_next_extent(info,
                                               bkey_start_offset(k.k) << 9,
@@ -1091,84 +887,107 @@ static int bch2_fiemap(struct inode *vinode, struct fiemap_extent_info *info,
 {
        struct bch_fs *c = vinode->i_sb->s_fs_info;
        struct bch_inode_info *ei = to_bch_ei(vinode);
-       struct btree_trans trans;
-       struct btree_iter *iter;
+       struct btree_trans *trans;
+       struct btree_iter iter;
        struct bkey_s_c k;
-       BKEY_PADDED(k) cur, prev;
+       struct bkey_buf cur, prev;
        struct bpos end = POS(ei->v.i_ino, (start + len) >> 9);
        unsigned offset_into_extent, sectors;
        bool have_extent = false;
+       u32 snapshot;
        int ret = 0;
 
+       ret = fiemap_prep(&ei->v, info, start, &len, FIEMAP_FLAG_SYNC);
+       if (ret)
+               return ret;
+
        if (start + len < start)
                return -EINVAL;
 
-       bch2_trans_init(&trans, c, 0, 0);
+       start >>= 9;
 
-       iter = bch2_trans_get_iter(&trans, BTREE_ID_EXTENTS,
-                                  POS(ei->v.i_ino, start >> 9), 0);
+       bch2_bkey_buf_init(&cur);
+       bch2_bkey_buf_init(&prev);
+       trans = bch2_trans_get(c);
 retry:
-       while ((k = bch2_btree_iter_peek(iter)).k &&
-              !(ret = bkey_err(k)) &&
-              bkey_cmp(iter->pos, end) < 0) {
+       bch2_trans_begin(trans);
+
+       ret = bch2_subvolume_get_snapshot(trans, ei->ei_subvol, &snapshot);
+       if (ret)
+               goto err;
+
+       bch2_trans_iter_init(trans, &iter, BTREE_ID_extents,
+                            SPOS(ei->v.i_ino, start, snapshot), 0);
+
+       while (!(ret = btree_trans_too_many_iters(trans)) &&
+              (k = bch2_btree_iter_peek_upto(&iter, end)).k &&
+              !(ret = bkey_err(k))) {
+               enum btree_id data_btree = BTREE_ID_extents;
+
                if (!bkey_extent_is_data(k.k) &&
                    k.k->type != KEY_TYPE_reservation) {
-                       bch2_btree_iter_next(iter);
+                       bch2_btree_iter_advance(&iter);
                        continue;
                }
 
-               bkey_reassemble(&cur.k, k);
-               k = bkey_i_to_s_c(&cur.k);
-
-               offset_into_extent      = iter->pos.offset -
+               offset_into_extent      = iter.pos.offset -
                        bkey_start_offset(k.k);
                sectors                 = k.k->size - offset_into_extent;
 
-               ret = bch2_read_indirect_extent(&trans,
-                                       &offset_into_extent, &cur.k);
+               bch2_bkey_buf_reassemble(&cur, c, k);
+
+               ret = bch2_read_indirect_extent(trans, &data_btree,
+                                       &offset_into_extent, &cur);
                if (ret)
                        break;
 
+               k = bkey_i_to_s_c(cur.k);
+               bch2_bkey_buf_realloc(&prev, c, k.k->u64s);
+
                sectors = min(sectors, k.k->size - offset_into_extent);
 
-               if (offset_into_extent)
-                       bch2_cut_front(POS(k.k->p.inode,
-                                          bkey_start_offset(k.k) +
-                                          offset_into_extent),
-                                      &cur.k);
-               bch2_key_resize(&cur.k.k, sectors);
-               cur.k.k.p = iter->pos;
-               cur.k.k.p.offset += cur.k.k.size;
+               bch2_cut_front(POS(k.k->p.inode,
+                                  bkey_start_offset(k.k) +
+                                  offset_into_extent),
+                              cur.k);
+               bch2_key_resize(&cur.k->k, sectors);
+               cur.k->k.p = iter.pos;
+               cur.k->k.p.offset += cur.k->k.size;
 
                if (have_extent) {
+                       bch2_trans_unlock(trans);
                        ret = bch2_fill_extent(c, info,
-                                       bkey_i_to_s_c(&prev.k), 0);
+                                       bkey_i_to_s_c(prev.k), 0);
                        if (ret)
                                break;
                }
 
-               bkey_copy(&prev.k, &cur.k);
+               bkey_copy(prev.k, cur.k);
                have_extent = true;
 
-               if (k.k->type == KEY_TYPE_reflink_v)
-                       bch2_btree_iter_set_pos(iter, k.k->p);
-               else
-                       bch2_btree_iter_next(iter);
+               bch2_btree_iter_set_pos(&iter,
+                       POS(iter.pos.inode, iter.pos.offset + sectors));
        }
-
-       if (ret == -EINTR)
+       start = iter.pos.offset;
+       bch2_trans_iter_exit(trans, &iter);
+err:
+       if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
                goto retry;
 
-       if (!ret && have_extent)
-               ret = bch2_fill_extent(c, info, bkey_i_to_s_c(&prev.k),
+       if (!ret && have_extent) {
+               bch2_trans_unlock(trans);
+               ret = bch2_fill_extent(c, info, bkey_i_to_s_c(prev.k),
                                       FIEMAP_EXTENT_LAST);
+       }
 
-       ret = bch2_trans_exit(&trans) ?: ret;
+       bch2_trans_put(trans);
+       bch2_bkey_buf_exit(&cur, c);
+       bch2_bkey_buf_exit(&prev, c);
        return ret < 0 ? ret : 0;
 }
 
 static const struct vm_operations_struct bch_vm_ops = {
-       .fault          = filemap_fault,
+       .fault          = bch2_page_fault,
        .map_pages      = filemap_map_pages,
        .page_mkwrite   = bch2_page_mkwrite,
 };
@@ -1191,19 +1010,40 @@ static loff_t bch2_dir_llseek(struct file *file, loff_t offset, int whence)
 
 static int bch2_vfs_readdir(struct file *file, struct dir_context *ctx)
 {
-       struct bch_fs *c = file_inode(file)->i_sb->s_fs_info;
+       struct bch_inode_info *inode = file_bch_inode(file);
+       struct bch_fs *c = inode->v.i_sb->s_fs_info;
+
+       if (!dir_emit_dots(file, ctx))
+               return 0;
 
-       return bch2_readdir(c, file, ctx);
+       int ret = bch2_readdir(c, inode_inum(inode), ctx);
+
+       bch_err_fn(c, ret);
+       return bch2_err_class(ret);
+}
+
+static int bch2_open(struct inode *vinode, struct file *file)
+{
+       if (file->f_flags & (O_WRONLY|O_RDWR)) {
+               struct bch_inode_info *inode = to_bch_ei(vinode);
+               struct bch_fs *c = inode->v.i_sb->s_fs_info;
+
+               int ret = bch2_subvol_is_ro(c, inode->ei_subvol);
+               if (ret)
+                       return ret;
+       }
+
+       return generic_file_open(vinode, file);
 }
 
 static const struct file_operations bch_file_operations = {
+       .open           = bch2_open,
        .llseek         = bch2_llseek,
-       .read_iter      = generic_file_read_iter,
+       .read_iter      = bch2_read_iter,
        .write_iter     = bch2_write_iter,
        .mmap           = bch2_mmap,
-       .open           = generic_file_open,
        .fsync          = bch2_fsync,
-       .splice_read    = generic_file_splice_read,
+       .splice_read    = filemap_splice_read,
        .splice_write   = iter_file_splice_write,
        .fallocate      = bch2_fallocate_dispatch,
        .unlocked_ioctl = bch2_fs_file_ioctl,
@@ -1231,7 +1071,7 @@ static const struct inode_operations bch_dir_inode_operations = {
        .unlink         = bch2_unlink,
        .symlink        = bch2_symlink,
        .mkdir          = bch2_mkdir,
-       .rmdir          = bch2_rmdir,
+       .rmdir          = bch2_unlink,
        .mknod          = bch2_mknod,
        .rename         = bch2_rename2,
        .getattr        = bch2_getattr,
@@ -1247,7 +1087,7 @@ static const struct inode_operations bch_dir_inode_operations = {
 static const struct file_operations bch_dir_file_operations = {
        .llseek         = bch2_dir_llseek,
        .read           = generic_read_dir,
-       .iterate        = bch2_vfs_readdir,
+       .iterate_shared = bch2_vfs_readdir,
        .fsync          = bch2_fsync,
        .unlocked_ioctl = bch2_fs_file_ioctl,
 #ifdef CONFIG_COMPAT
@@ -1277,67 +1117,266 @@ static const struct inode_operations bch_special_inode_operations = {
 };
 
 static const struct address_space_operations bch_address_space_operations = {
-       .writepage      = bch2_writepage,
-       .readpage       = bch2_readpage,
+       .read_folio     = bch2_read_folio,
        .writepages     = bch2_writepages,
-       .readpages      = bch2_readpages,
-       .set_page_dirty = __set_page_dirty_nobuffers,
+       .readahead      = bch2_readahead,
+       .dirty_folio    = filemap_dirty_folio,
        .write_begin    = bch2_write_begin,
        .write_end      = bch2_write_end,
-       .invalidatepage = bch2_invalidatepage,
-       .releasepage    = bch2_releasepage,
-       .direct_IO      = bch2_direct_IO,
+       .invalidate_folio = bch2_invalidate_folio,
+       .release_folio  = bch2_release_folio,
+       .direct_IO      = noop_direct_IO,
 #ifdef CONFIG_MIGRATION
-       .migratepage    = bch2_migrate_page,
+       .migrate_folio  = filemap_migrate_folio,
 #endif
-       .error_remove_page = generic_error_remove_page,
+       .error_remove_folio = generic_error_remove_folio,
 };
 
-static struct inode *bch2_nfs_get_inode(struct super_block *sb,
-               u64 ino, u32 generation)
+struct bcachefs_fid {
+       u64             inum;
+       u32             subvol;
+       u32             gen;
+} __packed;
+
+struct bcachefs_fid_with_parent {
+       struct bcachefs_fid     fid;
+       struct bcachefs_fid     dir;
+} __packed;
+
+static int bcachefs_fid_valid(int fh_len, int fh_type)
 {
-       struct bch_fs *c = sb->s_fs_info;
-       struct inode *vinode;
+       switch (fh_type) {
+       case FILEID_BCACHEFS_WITHOUT_PARENT:
+               return fh_len == sizeof(struct bcachefs_fid) / sizeof(u32);
+       case FILEID_BCACHEFS_WITH_PARENT:
+               return fh_len == sizeof(struct bcachefs_fid_with_parent) / sizeof(u32);
+       default:
+               return false;
+       }
+}
+
+static struct bcachefs_fid bch2_inode_to_fid(struct bch_inode_info *inode)
+{
+       return (struct bcachefs_fid) {
+               .inum   = inode->ei_inode.bi_inum,
+               .subvol = inode->ei_subvol,
+               .gen    = inode->ei_inode.bi_generation,
+       };
+}
+
+static int bch2_encode_fh(struct inode *vinode, u32 *fh, int *len,
+                         struct inode *vdir)
+{
+       struct bch_inode_info *inode    = to_bch_ei(vinode);
+       struct bch_inode_info *dir      = to_bch_ei(vdir);
+       int min_len;
 
-       if (ino < BCACHEFS_ROOT_INO)
-               return ERR_PTR(-ESTALE);
+       if (!S_ISDIR(inode->v.i_mode) && dir) {
+               struct bcachefs_fid_with_parent *fid = (void *) fh;
 
-       vinode = bch2_vfs_inode_get(c, ino);
-       if (IS_ERR(vinode))
-               return ERR_CAST(vinode);
-       if (generation && vinode->i_generation != generation) {
-               /* we didn't find the right inode.. */
+               min_len = sizeof(*fid) / sizeof(u32);
+               if (*len < min_len) {
+                       *len = min_len;
+                       return FILEID_INVALID;
+               }
+
+               fid->fid = bch2_inode_to_fid(inode);
+               fid->dir = bch2_inode_to_fid(dir);
+
+               *len = min_len;
+               return FILEID_BCACHEFS_WITH_PARENT;
+       } else {
+               struct bcachefs_fid *fid = (void *) fh;
+
+               min_len = sizeof(*fid) / sizeof(u32);
+               if (*len < min_len) {
+                       *len = min_len;
+                       return FILEID_INVALID;
+               }
+               *fid = bch2_inode_to_fid(inode);
+
+               *len = min_len;
+               return FILEID_BCACHEFS_WITHOUT_PARENT;
+       }
+}
+
+static struct inode *bch2_nfs_get_inode(struct super_block *sb,
+                                       struct bcachefs_fid fid)
+{
+       struct bch_fs *c = sb->s_fs_info;
+       struct inode *vinode = bch2_vfs_inode_get(c, (subvol_inum) {
+                                   .subvol = fid.subvol,
+                                   .inum = fid.inum,
+       });
+       if (!IS_ERR(vinode) && vinode->i_generation != fid.gen) {
                iput(vinode);
-               return ERR_PTR(-ESTALE);
+               vinode = ERR_PTR(-ESTALE);
        }
        return vinode;
 }
 
-static struct dentry *bch2_fh_to_dentry(struct super_block *sb, struct fid *fid,
+static struct dentry *bch2_fh_to_dentry(struct super_block *sb, struct fid *_fid,
                int fh_len, int fh_type)
 {
-       return generic_fh_to_dentry(sb, fid, fh_len, fh_type,
-                                   bch2_nfs_get_inode);
+       struct bcachefs_fid *fid = (void *) _fid;
+
+       if (!bcachefs_fid_valid(fh_len, fh_type))
+               return NULL;
+
+       return d_obtain_alias(bch2_nfs_get_inode(sb, *fid));
 }
 
-static struct dentry *bch2_fh_to_parent(struct super_block *sb, struct fid *fid,
+static struct dentry *bch2_fh_to_parent(struct super_block *sb, struct fid *_fid,
                int fh_len, int fh_type)
 {
-       return generic_fh_to_parent(sb, fid, fh_len, fh_type,
-                                   bch2_nfs_get_inode);
+       struct bcachefs_fid_with_parent *fid = (void *) _fid;
+
+       if (!bcachefs_fid_valid(fh_len, fh_type) ||
+           fh_type != FILEID_BCACHEFS_WITH_PARENT)
+               return NULL;
+
+       return d_obtain_alias(bch2_nfs_get_inode(sb, fid->dir));
+}
+
+static struct dentry *bch2_get_parent(struct dentry *child)
+{
+       struct bch_inode_info *inode = to_bch_ei(child->d_inode);
+       struct bch_fs *c = inode->v.i_sb->s_fs_info;
+       subvol_inum parent_inum = {
+               .subvol = inode->ei_inode.bi_parent_subvol ?:
+                       inode->ei_subvol,
+               .inum = inode->ei_inode.bi_dir,
+       };
+
+       return d_obtain_alias(bch2_vfs_inode_get(c, parent_inum));
+}
+
+static int bch2_get_name(struct dentry *parent, char *name, struct dentry *child)
+{
+       struct bch_inode_info *inode    = to_bch_ei(child->d_inode);
+       struct bch_inode_info *dir      = to_bch_ei(parent->d_inode);
+       struct bch_fs *c = inode->v.i_sb->s_fs_info;
+       struct btree_trans *trans;
+       struct btree_iter iter1;
+       struct btree_iter iter2;
+       struct bkey_s_c k;
+       struct bkey_s_c_dirent d;
+       struct bch_inode_unpacked inode_u;
+       subvol_inum target;
+       u32 snapshot;
+       struct qstr dirent_name;
+       unsigned name_len = 0;
+       int ret;
+
+       if (!S_ISDIR(dir->v.i_mode))
+               return -EINVAL;
+
+       trans = bch2_trans_get(c);
+
+       bch2_trans_iter_init(trans, &iter1, BTREE_ID_dirents,
+                            POS(dir->ei_inode.bi_inum, 0), 0);
+       bch2_trans_iter_init(trans, &iter2, BTREE_ID_dirents,
+                            POS(dir->ei_inode.bi_inum, 0), 0);
+retry:
+       bch2_trans_begin(trans);
+
+       ret = bch2_subvolume_get_snapshot(trans, dir->ei_subvol, &snapshot);
+       if (ret)
+               goto err;
+
+       bch2_btree_iter_set_snapshot(&iter1, snapshot);
+       bch2_btree_iter_set_snapshot(&iter2, snapshot);
+
+       ret = bch2_inode_find_by_inum_trans(trans, inode_inum(inode), &inode_u);
+       if (ret)
+               goto err;
+
+       if (inode_u.bi_dir == dir->ei_inode.bi_inum) {
+               bch2_btree_iter_set_pos(&iter1, POS(inode_u.bi_dir, inode_u.bi_dir_offset));
+
+               k = bch2_btree_iter_peek_slot(&iter1);
+               ret = bkey_err(k);
+               if (ret)
+                       goto err;
+
+               if (k.k->type != KEY_TYPE_dirent) {
+                       ret = -BCH_ERR_ENOENT_dirent_doesnt_match_inode;
+                       goto err;
+               }
+
+               d = bkey_s_c_to_dirent(k);
+               ret = bch2_dirent_read_target(trans, inode_inum(dir), d, &target);
+               if (ret > 0)
+                       ret = -BCH_ERR_ENOENT_dirent_doesnt_match_inode;
+               if (ret)
+                       goto err;
+
+               if (target.subvol       == inode->ei_subvol &&
+                   target.inum         == inode->ei_inode.bi_inum)
+                       goto found;
+       } else {
+               /*
+                * File with multiple hardlinks and our backref is to the wrong
+                * directory - linear search:
+                */
+               for_each_btree_key_continue_norestart(iter2, 0, k, ret) {
+                       if (k.k->p.inode > dir->ei_inode.bi_inum)
+                               break;
+
+                       if (k.k->type != KEY_TYPE_dirent)
+                               continue;
+
+                       d = bkey_s_c_to_dirent(k);
+                       ret = bch2_dirent_read_target(trans, inode_inum(dir), d, &target);
+                       if (ret < 0)
+                               break;
+                       if (ret)
+                               continue;
+
+                       if (target.subvol       == inode->ei_subvol &&
+                           target.inum         == inode->ei_inode.bi_inum)
+                               goto found;
+               }
+       }
+
+       ret = -ENOENT;
+       goto err;
+found:
+       dirent_name = bch2_dirent_get_name(d);
+
+       name_len = min_t(unsigned, dirent_name.len, NAME_MAX);
+       memcpy(name, dirent_name.name, name_len);
+       name[name_len] = '\0';
+err:
+       if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
+               goto retry;
+
+       bch2_trans_iter_exit(trans, &iter1);
+       bch2_trans_iter_exit(trans, &iter2);
+       bch2_trans_put(trans);
+
+       return ret;
 }
 
 static const struct export_operations bch_export_ops = {
+       .encode_fh      = bch2_encode_fh,
        .fh_to_dentry   = bch2_fh_to_dentry,
        .fh_to_parent   = bch2_fh_to_parent,
-       //.get_parent   = bch2_get_parent,
+       .get_parent     = bch2_get_parent,
+       .get_name       = bch2_get_name,
 };
 
-static void bch2_vfs_inode_init(struct bch_fs *c,
+static void bch2_vfs_inode_init(struct btree_trans *trans, subvol_inum inum,
                                struct bch_inode_info *inode,
-                               struct bch_inode_unpacked *bi)
+                               struct bch_inode_unpacked *bi,
+                               struct bch_subvolume *subvol)
 {
-       bch2_inode_update_after_write(c, inode, bi, ~0);
+       bch2_inode_update_after_write(trans, inode, bi, ~0);
+
+       if (BCH_SUBVOLUME_SNAP(subvol))
+               set_bit(EI_INODE_SNAPSHOT, &inode->ei_flags);
+       else
+               clear_bit(EI_INODE_SNAPSHOT, &inode->ei_flags);
 
        inode->v.i_blocks       = bi->bi_sectors;
        inode->v.i_ino          = bi->bi_inum;
@@ -1345,10 +1384,10 @@ static void bch2_vfs_inode_init(struct bch_fs *c,
        inode->v.i_generation   = bi->bi_generation;
        inode->v.i_size         = bi->bi_size;
 
-       inode->ei_journal_seq   = 0;
+       inode->ei_flags         = 0;
        inode->ei_quota_reserved = 0;
-       inode->ei_str_hash      = bch2_hash_info_init(c, bi);
        inode->ei_qid           = bch_qid(bi);
+       inode->ei_subvol        = inum.subvol;
 
        inode->v.i_mapping->a_ops = &bch_address_space_operations;
 
@@ -1370,6 +1409,8 @@ static void bch2_vfs_inode_init(struct bch_fs *c,
                inode->v.i_op   = &bch_special_inode_operations;
                break;
        }
+
+       mapping_set_large_folios(inode->v.i_mapping);
 }
 
 static struct inode *bch2_alloc_inode(struct super_block *sb)
@@ -1382,8 +1423,9 @@ static struct inode *bch2_alloc_inode(struct super_block *sb)
 
        inode_init_once(&inode->v);
        mutex_init(&inode->ei_update_lock);
+       two_state_lock_init(&inode->ei_pagecache_lock);
+       INIT_LIST_HEAD(&inode->ei_vfs_inode_list);
        mutex_init(&inode->ei_quota_lock);
-       inode->ei_journal_seq = 0;
 
        return &inode->v;
 }
@@ -1401,15 +1443,16 @@ static void bch2_destroy_inode(struct inode *vinode)
        call_rcu(&vinode->i_rcu, bch2_i_callback);
 }
 
-static int inode_update_times_fn(struct bch_inode_info *inode,
+static int inode_update_times_fn(struct btree_trans *trans,
+                                struct bch_inode_info *inode,
                                 struct bch_inode_unpacked *bi,
                                 void *p)
 {
        struct bch_fs *c = inode->v.i_sb->s_fs_info;
 
-       bi->bi_atime    = timespec_to_bch2_time(c, inode->v.i_atime);
-       bi->bi_mtime    = timespec_to_bch2_time(c, inode->v.i_mtime);
-       bi->bi_ctime    = timespec_to_bch2_time(c, inode->v.i_ctime);
+       bi->bi_atime    = timespec_to_bch2_time(c, inode_get_atime(&inode->v));
+       bi->bi_mtime    = timespec_to_bch2_time(c, inode_get_mtime(&inode->v));
+       bi->bi_ctime    = timespec_to_bch2_time(c, inode_get_ctime(&inode->v));
 
        return 0;
 }
@@ -1426,7 +1469,7 @@ static int bch2_vfs_write_inode(struct inode *vinode,
                               ATTR_ATIME|ATTR_MTIME|ATTR_CTIME);
        mutex_unlock(&inode->ei_update_lock);
 
-       return ret;
+       return bch2_err_class(ret);
 }
 
 static void bch2_evict_inode(struct inode *vinode)
@@ -1445,8 +1488,76 @@ static void bch2_evict_inode(struct inode *vinode)
                                KEY_TYPE_QUOTA_WARN);
                bch2_quota_acct(c, inode->ei_qid, Q_INO, -1,
                                KEY_TYPE_QUOTA_WARN);
-               bch2_inode_rm(c, inode->v.i_ino);
+               bch2_inode_rm(c, inode_inum(inode));
+       }
+
+       mutex_lock(&c->vfs_inodes_lock);
+       list_del_init(&inode->ei_vfs_inode_list);
+       mutex_unlock(&c->vfs_inodes_lock);
+}
+
+void bch2_evict_subvolume_inodes(struct bch_fs *c, snapshot_id_list *s)
+{
+       struct bch_inode_info *inode;
+       DARRAY(struct bch_inode_info *) grabbed;
+       bool clean_pass = false, this_pass_clean;
+
+       /*
+        * Initially, we scan for inodes without I_DONTCACHE, then mark them to
+        * be pruned with d_mark_dontcache().
+        *
+        * Once we've had a clean pass where we didn't find any inodes without
+        * I_DONTCACHE, we wait for them to be freed:
+        */
+
+       darray_init(&grabbed);
+       darray_make_room(&grabbed, 1024);
+again:
+       cond_resched();
+       this_pass_clean = true;
+
+       mutex_lock(&c->vfs_inodes_lock);
+       list_for_each_entry(inode, &c->vfs_inodes_list, ei_vfs_inode_list) {
+               if (!snapshot_list_has_id(s, inode->ei_subvol))
+                       continue;
+
+               if (!(inode->v.i_state & I_DONTCACHE) &&
+                   !(inode->v.i_state & I_FREEING) &&
+                   igrab(&inode->v)) {
+                       this_pass_clean = false;
+
+                       if (darray_push_gfp(&grabbed, inode, GFP_ATOMIC|__GFP_NOWARN)) {
+                               iput(&inode->v);
+                               break;
+                       }
+               } else if (clean_pass && this_pass_clean) {
+                       wait_queue_head_t *wq = bit_waitqueue(&inode->v.i_state, __I_NEW);
+                       DEFINE_WAIT_BIT(wait, &inode->v.i_state, __I_NEW);
+
+                       prepare_to_wait(wq, &wait.wq_entry, TASK_UNINTERRUPTIBLE);
+                       mutex_unlock(&c->vfs_inodes_lock);
+
+                       schedule();
+                       finish_wait(wq, &wait.wq_entry);
+                       goto again;
+               }
+       }
+       mutex_unlock(&c->vfs_inodes_lock);
+
+       darray_for_each(grabbed, i) {
+               inode = *i;
+               d_mark_dontcache(&inode->v);
+               d_prune_aliases(&inode->v);
+               iput(&inode->v);
        }
+       grabbed.nr = 0;
+
+       if (!clean_pass || !this_pass_clean) {
+               clean_pass = this_pass_clean;
+               goto again;
+       }
+
+       darray_exit(&grabbed);
 }
 
 static int bch2_statfs(struct dentry *dentry, struct kstatfs *buf)
@@ -1455,15 +1566,21 @@ static int bch2_statfs(struct dentry *dentry, struct kstatfs *buf)
        struct bch_fs *c = sb->s_fs_info;
        struct bch_fs_usage_short usage = bch2_fs_usage_read_short(c);
        unsigned shift = sb->s_blocksize_bits - 9;
+       /*
+        * this assumes inodes take up 64 bytes, which is a decent average
+        * number:
+        */
+       u64 avail_inodes = ((usage.capacity - usage.used) << 3);
        u64 fsid;
 
        buf->f_type     = BCACHEFS_STATFS_MAGIC;
        buf->f_bsize    = sb->s_blocksize;
        buf->f_blocks   = usage.capacity >> shift;
-       buf->f_bfree    = (usage.capacity - usage.used) >> shift;
-       buf->f_bavail   = buf->f_bfree;
-       buf->f_files    = usage.nr_inodes;
-       buf->f_ffree    = U64_MAX;
+       buf->f_bfree    = usage.free >> shift;
+       buf->f_bavail   = avail_factor(usage.free) >> shift;
+
+       buf->f_files    = usage.nr_inodes + avail_inodes;
+       buf->f_ffree    = avail_inodes;
 
        fsid = le64_to_cpup((void *) c->sb.user_uuid.b) ^
               le64_to_cpup((void *) c->sb.user_uuid.b + sizeof(u64));
@@ -1477,6 +1594,7 @@ static int bch2_statfs(struct dentry *dentry, struct kstatfs *buf)
 static int bch2_sync_fs(struct super_block *sb, int wait)
 {
        struct bch_fs *c = sb->s_fs_info;
+       int ret;
 
        if (c->opts.journal_flush_disabled)
                return 0;
@@ -1486,104 +1604,24 @@ static int bch2_sync_fs(struct super_block *sb, int wait)
                return 0;
        }
 
-       return bch2_journal_flush(&c->journal);
+       ret = bch2_journal_flush(&c->journal);
+       return bch2_err_class(ret);
 }
 
-static struct bch_fs *bch2_path_to_fs(const char *dev)
+static struct bch_fs *bch2_path_to_fs(const char *path)
 {
        struct bch_fs *c;
-       struct block_device *bdev = lookup_bdev(dev);
-
-       if (IS_ERR(bdev))
-               return ERR_CAST(bdev);
-
-       c = bch2_bdev_to_fs(bdev);
-       bdput(bdev);
-       return c ?: ERR_PTR(-ENOENT);
-}
-
-static struct bch_fs *__bch2_open_as_blockdevs(const char *dev_name, char * const *devs,
-                                              unsigned nr_devs, struct bch_opts opts)
-{
-       struct bch_fs *c, *c1, *c2;
-       size_t i;
-
-       if (!nr_devs)
-               return ERR_PTR(-EINVAL);
-
-       c = bch2_fs_open(devs, nr_devs, opts);
-
-       if (IS_ERR(c) && PTR_ERR(c) == -EBUSY) {
-               /*
-                * Already open?
-                * Look up each block device, make sure they all belong to a
-                * filesystem and they all belong to the _same_ filesystem
-                */
-
-               c1 = bch2_path_to_fs(devs[0]);
-               if (IS_ERR(c1))
-                       return c;
-
-               for (i = 1; i < nr_devs; i++) {
-                       c2 = bch2_path_to_fs(devs[i]);
-                       if (!IS_ERR(c2))
-                               closure_put(&c2->cl);
-
-                       if (c1 != c2) {
-                               closure_put(&c1->cl);
-                               return c;
-                       }
-               }
-
-               c = c1;
-       }
-
-       if (IS_ERR(c))
-               return c;
+       dev_t dev;
+       int ret;
 
-       mutex_lock(&c->state_lock);
+       ret = lookup_bdev(path, &dev);
+       if (ret)
+               return ERR_PTR(ret);
 
-       if (!test_bit(BCH_FS_STARTED, &c->flags)) {
-               mutex_unlock(&c->state_lock);
+       c = bch2_dev_to_fs(dev);
+       if (c)
                closure_put(&c->cl);
-               pr_err("err mounting %s: incomplete filesystem", dev_name);
-               return ERR_PTR(-EINVAL);
-       }
-
-       mutex_unlock(&c->state_lock);
-
-       set_bit(BCH_FS_BDEV_MOUNTED, &c->flags);
-       return c;
-}
-
-static struct bch_fs *bch2_open_as_blockdevs(const char *_dev_name,
-                                            struct bch_opts opts)
-{
-       char *dev_name = NULL, **devs = NULL, *s;
-       struct bch_fs *c = ERR_PTR(-ENOMEM);
-       size_t i, nr_devs = 0;
-
-       dev_name = kstrdup(_dev_name, GFP_KERNEL);
-       if (!dev_name)
-               goto err;
-
-       for (s = dev_name; s; s = strchr(s + 1, ':'))
-               nr_devs++;
-
-       devs = kcalloc(nr_devs, sizeof(const char *), GFP_KERNEL);
-       if (!devs)
-               goto err;
-
-       for (i = 0, s = dev_name;
-            s;
-            (s = strchr(s, ':')) && (*s++ = '\0'))
-               devs[i++] = s;
-
-       c = __bch2_open_as_blockdevs(_dev_name, devs, nr_devs, opts);
-err:
-       kfree(devs);
-       kfree(dev_name);
-       return c;
+       return c ?: ERR_PTR(-ENOENT);
 }
 
 static int bch2_remount(struct super_block *sb, int *flags, char *data)
@@ -1592,14 +1630,14 @@ static int bch2_remount(struct super_block *sb, int *flags, char *data)
        struct bch_opts opts = bch2_opts_empty();
        int ret;
 
-       opt_set(opts, read_only, (*flags & SB_RDONLY) != 0);
-
-       ret = bch2_parse_mount_opts(&opts, data);
+       ret = bch2_parse_mount_opts(c, &opts, data);
        if (ret)
-               return ret;
+               goto err;
+
+       opt_set(opts, read_only, (*flags & SB_RDONLY) != 0);
 
        if (opts.read_only != c->opts.read_only) {
-               mutex_lock(&c->state_lock);
+               down_write(&c->state_lock);
 
                if (opts.read_only) {
                        bch2_fs_read_only(c);
@@ -1609,8 +1647,9 @@ static int bch2_remount(struct super_block *sb, int *flags, char *data)
                        ret = bch2_fs_read_write(c);
                        if (ret) {
                                bch_err(c, "error going rw: %i", ret);
-                               mutex_unlock(&c->state_lock);
-                               return -EINVAL;
+                               up_write(&c->state_lock);
+                               ret = -EINVAL;
+                               goto err;
                        }
 
                        sb->s_flags &= ~SB_RDONLY;
@@ -1618,39 +1657,97 @@ static int bch2_remount(struct super_block *sb, int *flags, char *data)
 
                c->opts.read_only = opts.read_only;
 
-               mutex_unlock(&c->state_lock);
+               up_write(&c->state_lock);
        }
 
-       if (opts.errors >= 0)
+       if (opt_defined(opts, errors))
                c->opts.errors = opts.errors;
+err:
+       return bch2_err_class(ret);
+}
 
-       return ret;
+static int bch2_show_devname(struct seq_file *seq, struct dentry *root)
+{
+       struct bch_fs *c = root->d_sb->s_fs_info;
+       bool first = true;
+
+       for_each_online_member(c, ca) {
+               if (!first)
+                       seq_putc(seq, ':');
+               first = false;
+               seq_puts(seq, ca->disk_sb.sb_name);
+       }
+
+       return 0;
 }
 
 static int bch2_show_options(struct seq_file *seq, struct dentry *root)
 {
        struct bch_fs *c = root->d_sb->s_fs_info;
        enum bch_opt_id i;
-       char buf[512];
+       struct printbuf buf = PRINTBUF;
+       int ret = 0;
 
        for (i = 0; i < bch2_opts_nr; i++) {
                const struct bch_option *opt = &bch2_opt_table[i];
                u64 v = bch2_opt_get_by_id(&c->opts, i);
 
-               if (!(opt->mode & OPT_MOUNT))
+               if (!(opt->flags & OPT_MOUNT))
                        continue;
 
                if (v == bch2_opt_get_by_id(&bch2_opts_default, i))
                        continue;
 
-               bch2_opt_to_text(&PBUF(buf), c, opt, v,
+               printbuf_reset(&buf);
+               bch2_opt_to_text(&buf, c, c->disk_sb.sb, opt, v,
                                 OPT_SHOW_MOUNT_STYLE);
                seq_putc(seq, ',');
-               seq_puts(seq, buf);
+               seq_puts(seq, buf.buf);
        }
 
+       if (buf.allocation_failure)
+               ret = -ENOMEM;
+       printbuf_exit(&buf);
+       return ret;
+}
+
+static void bch2_put_super(struct super_block *sb)
+{
+       struct bch_fs *c = sb->s_fs_info;
+
+       __bch2_fs_stop(c);
+}
+
+/*
+ * bcachefs doesn't currently integrate intwrite freeze protection but the
+ * internal write references serve the same purpose. Therefore reuse the
+ * read-only transition code to perform the quiesce. The caveat is that we don't
+ * currently have the ability to block tasks that want a write reference while
+ * the superblock is frozen. This is fine for now, but we should either add
+ * blocking support or find a way to integrate sb_start_intwrite() and friends.
+ */
+static int bch2_freeze(struct super_block *sb)
+{
+       struct bch_fs *c = sb->s_fs_info;
+
+       down_write(&c->state_lock);
+       bch2_fs_read_only(c);
+       up_write(&c->state_lock);
        return 0;
+}
+
+static int bch2_unfreeze(struct super_block *sb)
+{
+       struct bch_fs *c = sb->s_fs_info;
+       int ret;
+
+       if (test_bit(BCH_FS_emergency_ro, &c->flags))
+               return 0;
 
+       down_write(&c->state_lock);
+       ret = bch2_fs_read_write(c);
+       up_write(&c->state_lock);
+       return ret;
 }
 
 static const struct super_operations bch_super_operations = {
@@ -1660,58 +1757,109 @@ static const struct super_operations bch_super_operations = {
        .evict_inode    = bch2_evict_inode,
        .sync_fs        = bch2_sync_fs,
        .statfs         = bch2_statfs,
+       .show_devname   = bch2_show_devname,
        .show_options   = bch2_show_options,
        .remount_fs     = bch2_remount,
-#if 0
        .put_super      = bch2_put_super,
        .freeze_fs      = bch2_freeze,
        .unfreeze_fs    = bch2_unfreeze,
-#endif
 };
 
-static int bch2_test_super(struct super_block *s, void *data)
-{
-       return s->s_fs_info == data;
-}
-
 static int bch2_set_super(struct super_block *s, void *data)
 {
        s->s_fs_info = data;
        return 0;
 }
 
+static int bch2_noset_super(struct super_block *s, void *data)
+{
+       return -EBUSY;
+}
+
+typedef DARRAY(struct bch_fs *) darray_fs;
+
+static int bch2_test_super(struct super_block *s, void *data)
+{
+       struct bch_fs *c = s->s_fs_info;
+       darray_fs *d = data;
+
+       if (!c)
+               return false;
+
+       darray_for_each(*d, i)
+               if (c != *i)
+                       return false;
+       return true;
+}
+
 static struct dentry *bch2_mount(struct file_system_type *fs_type,
                                 int flags, const char *dev_name, void *data)
 {
        struct bch_fs *c;
-       struct bch_dev *ca;
        struct super_block *sb;
        struct inode *vinode;
        struct bch_opts opts = bch2_opts_empty();
-       unsigned i;
        int ret;
 
        opt_set(opts, read_only, (flags & SB_RDONLY) != 0);
 
-       ret = bch2_parse_mount_opts(&opts, data);
+       ret = bch2_parse_mount_opts(NULL, &opts, data);
+       if (ret)
+               return ERR_PTR(ret);
+
+       if (!dev_name || strlen(dev_name) == 0)
+               return ERR_PTR(-EINVAL);
+
+       darray_str devs;
+       ret = bch2_split_devs(dev_name, &devs);
        if (ret)
                return ERR_PTR(ret);
 
-       c = bch2_open_as_blockdevs(dev_name, opts);
-       if (IS_ERR(c))
-               return ERR_CAST(c);
+       darray_fs devs_to_fs = {};
+       darray_for_each(devs, i) {
+               ret = darray_push(&devs_to_fs, bch2_path_to_fs(*i));
+               if (ret) {
+                       sb = ERR_PTR(ret);
+                       goto got_sb;
+               }
+       }
+
+       sb = sget(fs_type, bch2_test_super, bch2_noset_super, flags|SB_NOSEC, &devs_to_fs);
+       if (!IS_ERR(sb))
+               goto got_sb;
+
+       c = bch2_fs_open(devs.data, devs.nr, opts);
+       if (IS_ERR(c)) {
+               sb = ERR_CAST(c);
+               goto got_sb;
+       }
+
+       /* Some options can't be parsed until after the fs is started: */
+       ret = bch2_parse_mount_opts(c, &opts, data);
+       if (ret) {
+               bch2_fs_stop(c);
+               sb = ERR_PTR(ret);
+               goto got_sb;
+       }
+
+       bch2_opts_apply(&c->opts, opts);
+
+       sb = sget(fs_type, NULL, bch2_set_super, flags|SB_NOSEC, c);
+       if (IS_ERR(sb))
+               bch2_fs_stop(c);
+got_sb:
+       darray_exit(&devs_to_fs);
+       bch2_darray_str_exit(&devs);
 
-       sb = sget(fs_type, bch2_test_super, bch2_set_super, flags|SB_NOSEC, c);
        if (IS_ERR(sb)) {
-               closure_put(&c->cl);
-               return ERR_CAST(sb);
+               ret = PTR_ERR(sb);
+               ret = bch2_err_class(ret);
+               return ERR_PTR(ret);
        }
 
-       BUG_ON(sb->s_fs_info != c);
+       c = sb->s_fs_info;
 
        if (sb->s_root) {
-               closure_put(&c->cl);
-
                if ((flags ^ sb->s_flags) & SB_RDONLY) {
                        ret = -EBUSY;
                        goto err_put_super;
@@ -1730,19 +1878,19 @@ static struct dentry *bch2_mount(struct file_system_type *fs_type,
 #endif
        sb->s_xattr             = bch2_xattr_handlers;
        sb->s_magic             = BCACHEFS_STATFS_MAGIC;
-       sb->s_time_gran         = c->sb.time_precision;
+       sb->s_time_gran         = c->sb.nsec_per_time_unit;
+       sb->s_time_min          = div_s64(S64_MIN, c->sb.time_units_per_sec) + 1;
+       sb->s_time_max          = div_s64(S64_MAX, c->sb.time_units_per_sec);
        c->vfs_sb               = sb;
-       strlcpy(sb->s_id, c->name, sizeof(sb->s_id));
+       strscpy(sb->s_id, c->name, sizeof(sb->s_id));
 
        ret = super_setup_bdi(sb);
        if (ret)
                goto err_put_super;
 
-       sb->s_bdi->congested_fn         = bch2_congested;
-       sb->s_bdi->congested_data       = c;
        sb->s_bdi->ra_pages             = VM_READAHEAD_PAGES;
 
-       for_each_online_member(ca, c, i) {
+       for_each_online_member(c, ca) {
                struct block_device *bdev = ca->disk_sb.bdev;
 
                /* XXX: create an anonymous device for multi device filesystems */
@@ -1752,18 +1900,20 @@ static struct dentry *bch2_mount(struct file_system_type *fs_type,
                break;
        }
 
+       c->dev = sb->s_dev;
+
 #ifdef CONFIG_BCACHEFS_POSIX_ACL
        if (c->opts.acl)
                sb->s_flags     |= SB_POSIXACL;
 #endif
 
-       vinode = bch2_vfs_inode_get(c, BCACHEFS_ROOT_INO);
-       if (IS_ERR(vinode)) {
-               bch_err(c, "error mounting: error getting root inode %i",
-                       (int) PTR_ERR(vinode));
-               ret = PTR_ERR(vinode);
+       sb->s_shrink->seeks = 0;
+
+       vinode = bch2_vfs_inode_get(c, BCACHEFS_ROOT_SUBVOL_INUM);
+       ret = PTR_ERR_OR_ZERO(vinode);
+       bch_err_msg(c, ret, "mounting: error getting root inode");
+       if (ret)
                goto err_put_super;
-       }
 
        sb->s_root = d_make_root(vinode);
        if (!sb->s_root) {
@@ -1778,7 +1928,7 @@ out:
 
 err_put_super:
        deactivate_locked_super(sb);
-       return ERR_PTR(ret);
+       return ERR_PTR(bch2_err_class(ret));
 }
 
 static void bch2_kill_sb(struct super_block *sb)
@@ -1786,11 +1936,7 @@ static void bch2_kill_sb(struct super_block *sb)
        struct bch_fs *c = sb->s_fs_info;
 
        generic_shutdown_super(sb);
-
-       if (test_bit(BCH_FS_BDEV_MOUNTED, &c->flags))
-               bch2_fs_stop(c);
-       else
-               closure_put(&c->cl);
+       bch2_fs_free(c);
 }
 
 static struct file_system_type bcache_fs_type = {
@@ -1806,15 +1952,14 @@ MODULE_ALIAS_FS("bcachefs");
 void bch2_vfs_exit(void)
 {
        unregister_filesystem(&bcache_fs_type);
-       if (bch2_inode_cache)
-               kmem_cache_destroy(bch2_inode_cache);
+       kmem_cache_destroy(bch2_inode_cache);
 }
 
 int __init bch2_vfs_init(void)
 {
        int ret = -ENOMEM;
 
-       bch2_inode_cache = KMEM_CACHE(bch_inode_info, 0);
+       bch2_inode_cache = KMEM_CACHE(bch_inode_info, SLAB_RECLAIM_ACCOUNT);
        if (!bch2_inode_cache)
                goto err;