]> git.sesse.net Git - bcachefs-tools-debian/blobdiff - libbcachefs/fs.c
New upstream release
[bcachefs-tools-debian] / libbcachefs / fs.c
index 8d2f388b4327db8196e884866a40590371b86a5f..f76d403ccb766d479b280c8faae33cd98f001548 100644 (file)
 #include "fs-common.h"
 #include "fs-io.h"
 #include "fs-ioctl.h"
+#include "fs-io-buffered.h"
+#include "fs-io-direct.h"
+#include "fs-io-pagecache.h"
 #include "fsck.h"
 #include "inode.h"
-#include "io.h"
+#include "io_read.h"
 #include "journal.h"
 #include "keylist.h"
 #include "quota.h"
+#include "snapshot.h"
 #include "super.h"
 #include "xattr.h"
 
@@ -62,11 +66,11 @@ void bch2_inode_update_after_write(struct btree_trans *trans,
        inode->v.i_mode = bi->bi_mode;
 
        if (fields & ATTR_ATIME)
-               inode->v.i_atime = bch2_time_to_timespec(c, bi->bi_atime);
+               inode_set_atime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_atime));
        if (fields & ATTR_MTIME)
-               inode->v.i_mtime = bch2_time_to_timespec(c, bi->bi_mtime);
+               inode_set_mtime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_mtime));
        if (fields & ATTR_CTIME)
-               inode->v.i_ctime = bch2_time_to_timespec(c, bi->bi_ctime);
+               inode_set_ctime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_ctime));
 
        inode->ei_inode         = *bi;
 
@@ -78,29 +82,27 @@ int __must_check bch2_write_inode(struct bch_fs *c,
                                  inode_set_fn set,
                                  void *p, unsigned fields)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        struct btree_iter iter = { NULL };
        struct bch_inode_unpacked inode_u;
        int ret;
-
-       bch2_trans_init(&trans, c, 0, 512);
 retry:
-       bch2_trans_begin(&trans);
+       bch2_trans_begin(trans);
 
-       ret   = bch2_inode_peek(&trans, &iter, &inode_u, inode_inum(inode),
+       ret   = bch2_inode_peek(trans, &iter, &inode_u, inode_inum(inode),
                                BTREE_ITER_INTENT) ?:
-               (set ? set(inode, &inode_u, p) : 0) ?:
-               bch2_inode_write(&trans, &iter, &inode_u) ?:
-               bch2_trans_commit(&trans, NULL, NULL, BTREE_INSERT_NOFAIL);
+               (set ? set(trans, inode, &inode_u, p) : 0) ?:
+               bch2_inode_write(trans, &iter, &inode_u) ?:
+               bch2_trans_commit(trans, NULL, NULL, BCH_TRANS_COMMIT_no_enospc);
 
        /*
         * the btree node lock protects inode->ei_inode, not ei_update_lock;
         * this is important for inode updates via bchfs_write_index_update
         */
        if (!ret)
-               bch2_inode_update_after_write(&trans, inode, &inode_u, fields);
+               bch2_inode_update_after_write(trans, inode, &inode_u, fields);
 
-       bch2_trans_iter_exit(&trans, &iter);
+       bch2_trans_iter_exit(trans, &iter);
 
        if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
                goto retry;
@@ -110,7 +112,7 @@ retry:
                             inode_inum(inode).subvol,
                             inode_inum(inode).inum);
 
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
        return ret < 0 ? ret : 0;
 }
 
@@ -178,7 +180,7 @@ struct inode *bch2_vfs_inode_get(struct bch_fs *c, subvol_inum inum)
 {
        struct bch_inode_unpacked inode_u;
        struct bch_inode_info *inode;
-       struct btree_trans trans;
+       struct btree_trans *trans;
        struct bch_subvolume subvol;
        int ret;
 
@@ -192,18 +194,18 @@ struct inode *bch2_vfs_inode_get(struct bch_fs *c, subvol_inum inum)
        if (!(inode->v.i_state & I_NEW))
                return &inode->v;
 
-       bch2_trans_init(&trans, c, 8, 0);
-       ret = lockrestart_do(&trans,
-               bch2_subvolume_get(&trans, inum.subvol, true, 0, &subvol) ?:
-               bch2_inode_find_by_inum_trans(&trans, inum, &inode_u));
+       trans = bch2_trans_get(c);
+       ret = lockrestart_do(trans,
+               bch2_subvolume_get(trans, inum.subvol, true, 0, &subvol) ?:
+               bch2_inode_find_by_inum_trans(trans, inum, &inode_u));
 
        if (!ret)
-               bch2_vfs_inode_init(&trans, inum, inode, &inode_u, &subvol);
-       bch2_trans_exit(&trans);
+               bch2_vfs_inode_init(trans, inum, inode, &inode_u, &subvol);
+       bch2_trans_put(trans);
 
        if (ret) {
                iget_failed(&inode->v);
-               return ERR_PTR(ret);
+               return ERR_PTR(bch2_err_class(ret));
        }
 
        mutex_lock(&c->vfs_inodes_lock);
@@ -222,7 +224,7 @@ __bch2_create(struct mnt_idmap *idmap,
              unsigned flags)
 {
        struct bch_fs *c = dir->v.i_sb->s_fs_info;
-       struct btree_trans trans;
+       struct btree_trans *trans;
        struct bch_inode_unpacked dir_u;
        struct bch_inode_info *inode, *old;
        struct bch_inode_unpacked inode_u;
@@ -252,13 +254,11 @@ __bch2_create(struct mnt_idmap *idmap,
        if (!(flags & BCH_CREATE_TMPFILE))
                mutex_lock(&dir->ei_update_lock);
 
-       bch2_trans_init(&trans, c, 8,
-                       2048 + (!(flags & BCH_CREATE_TMPFILE)
-                               ? dentry->d_name.len : 0));
+       trans = bch2_trans_get(c);
 retry:
-       bch2_trans_begin(&trans);
+       bch2_trans_begin(trans);
 
-       ret   = bch2_create_trans(&trans,
+       ret   = bch2_create_trans(trans,
                                  inode_inum(dir), &dir_u, &inode_u,
                                  !(flags & BCH_CREATE_TMPFILE)
                                  ? &dentry->d_name : NULL,
@@ -274,9 +274,9 @@ retry:
        inum.subvol = inode_u.bi_subvol ?: dir->ei_subvol;
        inum.inum = inode_u.bi_inum;
 
-       ret   = bch2_subvolume_get(&trans, inum.subvol, true,
+       ret   = bch2_subvolume_get(trans, inum.subvol, true,
                                   BTREE_ITER_WITH_UPDATES, &subvol) ?:
-               bch2_trans_commit(&trans, NULL, &journal_seq, 0);
+               bch2_trans_commit(trans, NULL, &journal_seq, 0);
        if (unlikely(ret)) {
                bch2_quota_acct(c, bch_qid(&inode_u), Q_INO, -1,
                                KEY_TYPE_QUOTA_WARN);
@@ -287,13 +287,13 @@ err_before_quota:
        }
 
        if (!(flags & BCH_CREATE_TMPFILE)) {
-               bch2_inode_update_after_write(&trans, dir, &dir_u,
+               bch2_inode_update_after_write(trans, dir, &dir_u,
                                              ATTR_MTIME|ATTR_CTIME);
                mutex_unlock(&dir->ei_update_lock);
        }
 
        bch2_iget5_set(&inode->v, &inum);
-       bch2_vfs_inode_init(&trans, inum, inode, &inode_u, &subvol);
+       bch2_vfs_inode_init(trans, inum, inode, &inode_u, &subvol);
 
        set_cached_acl(&inode->v, ACL_TYPE_ACCESS, acl);
        set_cached_acl(&inode->v, ACL_TYPE_DEFAULT, default_acl);
@@ -333,7 +333,7 @@ err_before_quota:
                unlock_new_inode(&inode->v);
        }
 
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
 err:
        posix_acl_release(default_acl);
        posix_acl_release(acl);
@@ -342,7 +342,7 @@ err_trans:
        if (!(flags & BCH_CREATE_TMPFILE))
                mutex_unlock(&dir->ei_update_lock);
 
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
        make_bad_inode(&inode->v);
        iput(&inode->v);
        inode = ERR_PTR(ret);
@@ -397,26 +397,25 @@ static int __bch2_link(struct bch_fs *c,
                       struct bch_inode_info *dir,
                       struct dentry *dentry)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        struct bch_inode_unpacked dir_u, inode_u;
        int ret;
 
        mutex_lock(&inode->ei_update_lock);
-       bch2_trans_init(&trans, c, 4, 1024);
 
-       ret = commit_do(&trans, NULL, NULL, 0,
-                       bch2_link_trans(&trans,
+       ret = commit_do(trans, NULL, NULL, 0,
+                       bch2_link_trans(trans,
                                        inode_inum(dir),   &dir_u,
                                        inode_inum(inode), &inode_u,
                                        &dentry->d_name));
 
        if (likely(!ret)) {
-               bch2_inode_update_after_write(&trans, dir, &dir_u,
+               bch2_inode_update_after_write(trans, dir, &dir_u,
                                              ATTR_MTIME|ATTR_CTIME);
-               bch2_inode_update_after_write(&trans, inode, &inode_u, ATTR_CTIME);
+               bch2_inode_update_after_write(trans, inode, &inode_u, ATTR_CTIME);
        }
 
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
        mutex_unlock(&inode->ei_update_lock);
        return ret;
 }
@@ -447,24 +446,23 @@ int __bch2_unlink(struct inode *vdir, struct dentry *dentry,
        struct bch_inode_info *dir = to_bch_ei(vdir);
        struct bch_inode_info *inode = to_bch_ei(dentry->d_inode);
        struct bch_inode_unpacked dir_u, inode_u;
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        int ret;
 
        bch2_lock_inodes(INODE_UPDATE_LOCK, dir, inode);
-       bch2_trans_init(&trans, c, 4, 1024);
 
-       ret = commit_do(&trans, NULL, NULL,
-                       BTREE_INSERT_NOFAIL,
-               bch2_unlink_trans(&trans,
+       ret = commit_do(trans, NULL, NULL,
+                       BCH_TRANS_COMMIT_no_enospc,
+               bch2_unlink_trans(trans,
                                  inode_inum(dir), &dir_u,
                                  &inode_u, &dentry->d_name,
                                  deleting_snapshot));
        if (unlikely(ret))
                goto err;
 
-       bch2_inode_update_after_write(&trans, dir, &dir_u,
+       bch2_inode_update_after_write(trans, dir, &dir_u,
                                      ATTR_MTIME|ATTR_CTIME);
-       bch2_inode_update_after_write(&trans, inode, &inode_u,
+       bch2_inode_update_after_write(trans, inode, &inode_u,
                                      ATTR_MTIME);
 
        if (inode_u.bi_subvol) {
@@ -475,8 +473,8 @@ int __bch2_unlink(struct inode *vdir, struct dentry *dentry,
                set_nlink(&inode->v, 0);
        }
 err:
-       bch2_trans_exit(&trans);
        bch2_unlock_inodes(INODE_UPDATE_LOCK, dir, inode);
+       bch2_trans_put(trans);
 
        return ret;
 }
@@ -539,7 +537,7 @@ static int bch2_rename2(struct mnt_idmap *idmap,
        struct bch_inode_info *dst_inode = to_bch_ei(dst_dentry->d_inode);
        struct bch_inode_unpacked dst_dir_u, src_dir_u;
        struct bch_inode_unpacked src_inode_u, dst_inode_u;
-       struct btree_trans trans;
+       struct btree_trans *trans;
        enum bch_rename_mode mode = flags & RENAME_EXCHANGE
                ? BCH_RENAME_EXCHANGE
                : dst_dentry->d_inode
@@ -556,7 +554,7 @@ static int bch2_rename2(struct mnt_idmap *idmap,
                        return ret;
        }
 
-       bch2_trans_init(&trans, c, 8, 2048);
+       trans = bch2_trans_get(c);
 
        bch2_lock_inodes(INODE_UPDATE_LOCK,
                         src_dir,
@@ -583,8 +581,8 @@ static int bch2_rename2(struct mnt_idmap *idmap,
                        goto err;
        }
 
-       ret = commit_do(&trans, NULL, NULL, 0,
-                       bch2_rename_trans(&trans,
+       ret = commit_do(trans, NULL, NULL, 0,
+                       bch2_rename_trans(trans,
                                          inode_inum(src_dir), &src_dir_u,
                                          inode_inum(dst_dir), &dst_dir_u,
                                          &src_inode_u,
@@ -599,21 +597,21 @@ static int bch2_rename2(struct mnt_idmap *idmap,
        BUG_ON(dst_inode &&
               dst_inode->v.i_ino != dst_inode_u.bi_inum);
 
-       bch2_inode_update_after_write(&trans, src_dir, &src_dir_u,
+       bch2_inode_update_after_write(trans, src_dir, &src_dir_u,
                                      ATTR_MTIME|ATTR_CTIME);
 
        if (src_dir != dst_dir)
-               bch2_inode_update_after_write(&trans, dst_dir, &dst_dir_u,
+               bch2_inode_update_after_write(trans, dst_dir, &dst_dir_u,
                                              ATTR_MTIME|ATTR_CTIME);
 
-       bch2_inode_update_after_write(&trans, src_inode, &src_inode_u,
+       bch2_inode_update_after_write(trans, src_inode, &src_inode_u,
                                      ATTR_CTIME);
 
        if (dst_inode)
-               bch2_inode_update_after_write(&trans, dst_inode, &dst_inode_u,
+               bch2_inode_update_after_write(trans, dst_inode, &dst_inode_u,
                                              ATTR_CTIME);
 err:
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
 
        bch2_fs_quota_transfer(c, src_inode,
                               bch_qid(&src_inode->ei_inode),
@@ -676,7 +674,7 @@ int bch2_setattr_nonsize(struct mnt_idmap *idmap,
 {
        struct bch_fs *c = inode->v.i_sb->s_fs_info;
        struct bch_qid qid;
-       struct btree_trans trans;
+       struct btree_trans *trans;
        struct btree_iter inode_iter = { NULL };
        struct bch_inode_unpacked inode_u;
        struct posix_acl *acl = NULL;
@@ -697,13 +695,13 @@ int bch2_setattr_nonsize(struct mnt_idmap *idmap,
        if (ret)
                goto err;
 
-       bch2_trans_init(&trans, c, 0, 0);
+       trans = bch2_trans_get(c);
 retry:
-       bch2_trans_begin(&trans);
+       bch2_trans_begin(trans);
        kfree(acl);
        acl = NULL;
 
-       ret = bch2_inode_peek(&trans, &inode_iter, &inode_u, inode_inum(inode),
+       ret = bch2_inode_peek(trans, &inode_iter, &inode_u, inode_inum(inode),
                              BTREE_ITER_INTENT);
        if (ret)
                goto btree_err;
@@ -711,29 +709,29 @@ retry:
        bch2_setattr_copy(idmap, inode, &inode_u, attr);
 
        if (attr->ia_valid & ATTR_MODE) {
-               ret = bch2_acl_chmod(&trans, inode_inum(inode), &inode_u,
+               ret = bch2_acl_chmod(trans, inode_inum(inode), &inode_u,
                                     inode_u.bi_mode, &acl);
                if (ret)
                        goto btree_err;
        }
 
-       ret =   bch2_inode_write(&trans, &inode_iter, &inode_u) ?:
-               bch2_trans_commit(&trans, NULL, NULL,
-                                 BTREE_INSERT_NOFAIL);
+       ret =   bch2_inode_write(trans, &inode_iter, &inode_u) ?:
+               bch2_trans_commit(trans, NULL, NULL,
+                                 BCH_TRANS_COMMIT_no_enospc);
 btree_err:
-       bch2_trans_iter_exit(&trans, &inode_iter);
+       bch2_trans_iter_exit(trans, &inode_iter);
 
        if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
                goto retry;
        if (unlikely(ret))
                goto err_trans;
 
-       bch2_inode_update_after_write(&trans, inode, &inode_u, attr->ia_valid);
+       bch2_inode_update_after_write(trans, inode, &inode_u, attr->ia_valid);
 
        if (acl)
                set_cached_acl(&inode->v, ACL_TYPE_ACCESS, acl);
 err_trans:
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
 err:
        mutex_unlock(&inode->ei_update_lock);
 
@@ -755,9 +753,9 @@ static int bch2_getattr(struct mnt_idmap *idmap,
        stat->gid       = inode->v.i_gid;
        stat->rdev      = inode->v.i_rdev;
        stat->size      = i_size_read(&inode->v);
-       stat->atime     = inode->v.i_atime;
-       stat->mtime     = inode->v.i_mtime;
-       stat->ctime     = inode->v.i_ctime;
+       stat->atime     = inode_get_atime(&inode->v);
+       stat->mtime     = inode_get_mtime(&inode->v);
+       stat->ctime     = inode_get_ctime(&inode->v);
        stat->blksize   = block_bytes(c);
        stat->blocks    = inode->v.i_blocks;
 
@@ -766,15 +764,15 @@ static int bch2_getattr(struct mnt_idmap *idmap,
                stat->btime = bch2_time_to_timespec(c, inode->ei_inode.bi_otime);
        }
 
-       if (inode->ei_inode.bi_flags & BCH_INODE_IMMUTABLE)
+       if (inode->ei_inode.bi_flags & BCH_INODE_immutable)
                stat->attributes |= STATX_ATTR_IMMUTABLE;
        stat->attributes_mask    |= STATX_ATTR_IMMUTABLE;
 
-       if (inode->ei_inode.bi_flags & BCH_INODE_APPEND)
+       if (inode->ei_inode.bi_flags & BCH_INODE_append)
                stat->attributes |= STATX_ATTR_APPEND;
        stat->attributes_mask    |= STATX_ATTR_APPEND;
 
-       if (inode->ei_inode.bi_flags & BCH_INODE_NODUMP)
+       if (inode->ei_inode.bi_flags & BCH_INODE_nodump)
                stat->attributes |= STATX_ATTR_NODUMP;
        stat->attributes_mask    |= STATX_ATTR_NODUMP;
 
@@ -794,7 +792,7 @@ static int bch2_setattr(struct mnt_idmap *idmap,
                return ret;
 
        return iattr->ia_valid & ATTR_SIZE
-               ? bch2_truncate(idmap, inode, iattr)
+               ? bchfs_truncate(idmap, inode, iattr)
                : bch2_setattr_nonsize(idmap, inode, iattr);
 }
 
@@ -875,7 +873,7 @@ static int bch2_fiemap(struct inode *vinode, struct fiemap_extent_info *info,
 {
        struct bch_fs *c = vinode->i_sb->s_fs_info;
        struct bch_inode_info *ei = to_bch_ei(vinode);
-       struct btree_trans trans;
+       struct btree_trans *trans;
        struct btree_iter iter;
        struct bkey_s_c k;
        struct bkey_buf cur, prev;
@@ -896,18 +894,18 @@ static int bch2_fiemap(struct inode *vinode, struct fiemap_extent_info *info,
 
        bch2_bkey_buf_init(&cur);
        bch2_bkey_buf_init(&prev);
-       bch2_trans_init(&trans, c, 0, 0);
+       trans = bch2_trans_get(c);
 retry:
-       bch2_trans_begin(&trans);
+       bch2_trans_begin(trans);
 
-       ret = bch2_subvolume_get_snapshot(&trans, ei->ei_subvol, &snapshot);
+       ret = bch2_subvolume_get_snapshot(trans, ei->ei_subvol, &snapshot);
        if (ret)
                goto err;
 
-       bch2_trans_iter_init(&trans, &iter, BTREE_ID_extents,
+       bch2_trans_iter_init(trans, &iter, BTREE_ID_extents,
                             SPOS(ei->v.i_ino, start, snapshot), 0);
 
-       while (!(ret = btree_trans_too_many_iters(&trans)) &&
+       while (!(ret = btree_trans_too_many_iters(trans)) &&
               (k = bch2_btree_iter_peek_upto(&iter, end)).k &&
               !(ret = bkey_err(k))) {
                enum btree_id data_btree = BTREE_ID_extents;
@@ -924,7 +922,7 @@ retry:
 
                bch2_bkey_buf_reassemble(&cur, c, k);
 
-               ret = bch2_read_indirect_extent(&trans, &data_btree,
+               ret = bch2_read_indirect_extent(trans, &data_btree,
                                        &offset_into_extent, &cur);
                if (ret)
                        break;
@@ -943,7 +941,7 @@ retry:
                cur.k->k.p.offset += cur.k->k.size;
 
                if (have_extent) {
-                       bch2_trans_unlock(&trans);
+                       bch2_trans_unlock(trans);
                        ret = bch2_fill_extent(c, info,
                                        bkey_i_to_s_c(prev.k), 0);
                        if (ret)
@@ -957,18 +955,18 @@ retry:
                        POS(iter.pos.inode, iter.pos.offset + sectors));
        }
        start = iter.pos.offset;
-       bch2_trans_iter_exit(&trans, &iter);
+       bch2_trans_iter_exit(trans, &iter);
 err:
        if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
                goto retry;
 
        if (!ret && have_extent) {
-               bch2_trans_unlock(&trans);
+               bch2_trans_unlock(trans);
                ret = bch2_fill_extent(c, info, bkey_i_to_s_c(prev.k),
                                       FIEMAP_EXTENT_LAST);
        }
 
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
        bch2_bkey_buf_exit(&cur, c);
        bch2_bkey_buf_exit(&prev, c);
        return ret < 0 ? ret : 0;
@@ -1000,11 +998,16 @@ static int bch2_vfs_readdir(struct file *file, struct dir_context *ctx)
 {
        struct bch_inode_info *inode = file_bch_inode(file);
        struct bch_fs *c = inode->v.i_sb->s_fs_info;
+       int ret;
 
        if (!dir_emit_dots(file, ctx))
                return 0;
 
-       return bch2_readdir(c, inode_inum(inode), ctx);
+       ret = bch2_readdir(c, inode_inum(inode), ctx);
+       if (ret)
+               bch_err_fn(c, ret);
+
+       return bch2_err_class(ret);
 }
 
 static const struct file_operations bch_file_operations = {
@@ -1210,9 +1213,6 @@ static struct dentry *bch2_get_parent(struct dentry *child)
                .inum = inode->ei_inode.bi_dir,
        };
 
-       if (!parent_inum.inum)
-               return NULL;
-
        return d_obtain_alias(bch2_vfs_inode_get(c, parent_inum));
 }
 
@@ -1221,7 +1221,7 @@ static int bch2_get_name(struct dentry *parent, char *name, struct dentry *child
        struct bch_inode_info *inode    = to_bch_ei(child->d_inode);
        struct bch_inode_info *dir      = to_bch_ei(parent->d_inode);
        struct bch_fs *c = inode->v.i_sb->s_fs_info;
-       struct btree_trans trans;
+       struct btree_trans *trans;
        struct btree_iter iter1;
        struct btree_iter iter2;
        struct bkey_s_c k;
@@ -1229,29 +1229,30 @@ static int bch2_get_name(struct dentry *parent, char *name, struct dentry *child
        struct bch_inode_unpacked inode_u;
        subvol_inum target;
        u32 snapshot;
-       unsigned name_len;
+       struct qstr dirent_name;
+       unsigned name_len = 0;
        int ret;
 
        if (!S_ISDIR(dir->v.i_mode))
                return -EINVAL;
 
-       bch2_trans_init(&trans, c, 0, 0);
+       trans = bch2_trans_get(c);
 
-       bch2_trans_iter_init(&trans, &iter1, BTREE_ID_dirents,
+       bch2_trans_iter_init(trans, &iter1, BTREE_ID_dirents,
                             POS(dir->ei_inode.bi_inum, 0), 0);
-       bch2_trans_iter_init(&trans, &iter2, BTREE_ID_dirents,
+       bch2_trans_iter_init(trans, &iter2, BTREE_ID_dirents,
                             POS(dir->ei_inode.bi_inum, 0), 0);
 retry:
-       bch2_trans_begin(&trans);
+       bch2_trans_begin(trans);
 
-       ret = bch2_subvolume_get_snapshot(&trans, dir->ei_subvol, &snapshot);
+       ret = bch2_subvolume_get_snapshot(trans, dir->ei_subvol, &snapshot);
        if (ret)
                goto err;
 
        bch2_btree_iter_set_snapshot(&iter1, snapshot);
        bch2_btree_iter_set_snapshot(&iter2, snapshot);
 
-       ret = bch2_inode_find_by_inum_trans(&trans, inode_inum(inode), &inode_u);
+       ret = bch2_inode_find_by_inum_trans(trans, inode_inum(inode), &inode_u);
        if (ret)
                goto err;
 
@@ -1269,7 +1270,7 @@ retry:
                }
 
                d = bkey_s_c_to_dirent(k);
-               ret = bch2_dirent_read_target(&trans, inode_inum(dir), d, &target);
+               ret = bch2_dirent_read_target(trans, inode_inum(dir), d, &target);
                if (ret > 0)
                        ret = -BCH_ERR_ENOENT_dirent_doesnt_match_inode;
                if (ret)
@@ -1291,7 +1292,7 @@ retry:
                                continue;
 
                        d = bkey_s_c_to_dirent(k);
-                       ret = bch2_dirent_read_target(&trans, inode_inum(dir), d, &target);
+                       ret = bch2_dirent_read_target(trans, inode_inum(dir), d, &target);
                        if (ret < 0)
                                break;
                        if (ret)
@@ -1306,17 +1307,18 @@ retry:
        ret = -ENOENT;
        goto err;
 found:
-       name_len = min_t(unsigned, bch2_dirent_name_bytes(d), NAME_MAX);
+       dirent_name = bch2_dirent_get_name(d);
 
-       memcpy(name, d.v->d_name, name_len);
+       name_len = min_t(unsigned, dirent_name.len, NAME_MAX);
+       memcpy(name, dirent_name.name, name_len);
        name[name_len] = '\0';
 err:
        if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
                goto retry;
 
-       bch2_trans_iter_exit(&trans, &iter1);
-       bch2_trans_iter_exit(&trans, &iter2);
-       bch2_trans_exit(&trans);
+       bch2_trans_iter_exit(trans, &iter1);
+       bch2_trans_iter_exit(trans, &iter2);
+       bch2_trans_put(trans);
 
        return ret;
 }
@@ -1406,15 +1408,16 @@ static void bch2_destroy_inode(struct inode *vinode)
        call_rcu(&vinode->i_rcu, bch2_i_callback);
 }
 
-static int inode_update_times_fn(struct bch_inode_info *inode,
+static int inode_update_times_fn(struct btree_trans *trans,
+                                struct bch_inode_info *inode,
                                 struct bch_inode_unpacked *bi,
                                 void *p)
 {
        struct bch_fs *c = inode->v.i_sb->s_fs_info;
 
-       bi->bi_atime    = timespec_to_bch2_time(c, inode->v.i_atime);
-       bi->bi_mtime    = timespec_to_bch2_time(c, inode->v.i_mtime);
-       bi->bi_ctime    = timespec_to_bch2_time(c, inode->v.i_ctime);
+       bi->bi_atime    = timespec_to_bch2_time(c, inode_get_atime(&inode->v));
+       bi->bi_mtime    = timespec_to_bch2_time(c, inode_get_mtime(&inode->v));
+       bi->bi_ctime    = timespec_to_bch2_time(c, inode_get_ctime(&inode->v));
 
        return 0;
 }
@@ -1589,7 +1592,7 @@ static struct bch_fs *bch2_path_to_fs(const char *path)
 static char **split_devs(const char *_dev_name, unsigned *nr)
 {
        char *dev_name = NULL, **devs = NULL, *s;
-       size_t i, nr_devs = 0;
+       size_t i = 0, nr_devs = 0;
 
        dev_name = kstrdup(_dev_name, GFP_KERNEL);
        if (!dev_name)
@@ -1604,9 +1607,7 @@ static char **split_devs(const char *_dev_name, unsigned *nr)
                return NULL;
        }
 
-       for (i = 0, s = dev_name;
-            s;
-            (s = strchr(s, ':')) && (*s++ = '\0'))
+       while ((s = strsep(&dev_name, ":")))
                devs[i++] = s;
 
        *nr = nr_devs;
@@ -1649,7 +1650,7 @@ static int bch2_remount(struct super_block *sb, int *flags, char *data)
                up_write(&c->state_lock);
        }
 
-       if (opts.errors >= 0)
+       if (opt_defined(opts, errors))
                c->opts.errors = opts.errors;
 err:
        return bch2_err_class(ret);
@@ -1710,6 +1711,35 @@ static void bch2_put_super(struct super_block *sb)
        __bch2_fs_stop(c);
 }
 
+/*
+ * bcachefs doesn't currently integrate intwrite freeze protection but the
+ * internal write references serve the same purpose. Therefore reuse the
+ * read-only transition code to perform the quiesce. The caveat is that we don't
+ * currently have the ability to block tasks that want a write reference while
+ * the superblock is frozen. This is fine for now, but we should either add
+ * blocking support or find a way to integrate sb_start_intwrite() and friends.
+ */
+static int bch2_freeze(struct super_block *sb)
+{
+       struct bch_fs *c = sb->s_fs_info;
+
+       down_write(&c->state_lock);
+       bch2_fs_read_only(c);
+       up_write(&c->state_lock);
+       return 0;
+}
+
+static int bch2_unfreeze(struct super_block *sb)
+{
+       struct bch_fs *c = sb->s_fs_info;
+       int ret;
+
+       down_write(&c->state_lock);
+       ret = bch2_fs_read_write(c);
+       up_write(&c->state_lock);
+       return ret;
+}
+
 static const struct super_operations bch_super_operations = {
        .alloc_inode    = bch2_alloc_inode,
        .destroy_inode  = bch2_destroy_inode,
@@ -1721,10 +1751,8 @@ static const struct super_operations bch_super_operations = {
        .show_options   = bch2_show_options,
        .remount_fs     = bch2_remount,
        .put_super      = bch2_put_super,
-#if 0
        .freeze_fs      = bch2_freeze,
        .unfreeze_fs    = bch2_unfreeze,
-#endif
 };
 
 static int bch2_set_super(struct super_block *s, void *data)
@@ -1878,7 +1906,7 @@ got_sb:
        vinode = bch2_vfs_inode_get(c, BCACHEFS_ROOT_SUBVOL_INUM);
        ret = PTR_ERR_OR_ZERO(vinode);
        if (ret) {
-               bch_err(c, "error mounting: error getting root inode: %s", bch2_err_str(ret));
+               bch_err_msg(c, ret, "mounting: error getting root inode");
                goto err_put_super;
        }