]> git.sesse.net Git - bcachefs-tools-debian/blobdiff - libbcachefs/opts.h
Update bcachefs sources to 070ec8d07b bcachefs: Snapshot depth, skiplist fields
[bcachefs-tools-debian] / libbcachefs / opts.h
index 126056e605435e65c1d5ad29528a76eae5cca6f2..e105a742fd443b17cecb271b526b25adcb3e3958 100644 (file)
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #ifndef _BCACHEFS_OPTS_H
 #define _BCACHEFS_OPTS_H
 
@@ -8,13 +9,26 @@
 #include "bcachefs_format.h"
 
 extern const char * const bch2_error_actions[];
+extern const char * const bch2_version_upgrade_opts[];
+extern const char * const bch2_sb_features[];
+extern const char * const bch2_sb_compat[];
+extern const char * const bch2_btree_ids[];
 extern const char * const bch2_csum_types[];
+extern const char * const bch2_csum_opts[];
 extern const char * const bch2_compression_types[];
+extern const char * const bch2_compression_opts[];
 extern const char * const bch2_str_hash_types[];
+extern const char * const bch2_str_hash_opts[];
 extern const char * const bch2_data_types[];
-extern const char * const bch2_cache_replacement_policies[];
-extern const char * const bch2_cache_modes[];
-extern const char * const bch2_dev_state[];
+extern const char * const bch2_member_states[];
+extern const char * const bch2_jset_entry_types[];
+extern const char * const bch2_fs_usage_types[];
+extern const char * const bch2_d_types[];
+
+static inline const char *bch2_d_type_str(unsigned d_type)
+{
+       return (d_type < BCH_DT_MAX ? bch2_d_types[d_type] : NULL) ?: "(bad d_type)";
+}
 
 /*
  * Mount options; we also store defaults in the superblock.
@@ -29,23 +43,32 @@ extern const char * const bch2_dev_state[];
  */
 
 /* dummy option, for options that aren't stored in the superblock */
-LE64_BITMASK(NO_SB_OPT,                struct bch_sb, flags[0], 0, 0);
-
-enum opt_mode {
-       OPT_INTERNAL,
-       OPT_FORMAT,
-       OPT_MOUNT,
-       OPT_RUNTIME,
+u64 BCH2_NO_SB_OPT(const struct bch_sb *);
+void SET_BCH2_NO_SB_OPT(struct bch_sb *, u64);
+
+/* When can be set: */
+enum opt_flags {
+       OPT_FS          = (1 << 0),     /* Filesystem option */
+       OPT_DEVICE      = (1 << 1),     /* Device option */
+       OPT_INODE       = (1 << 2),     /* Inode option */
+       OPT_FORMAT      = (1 << 3),     /* May be specified at format time */
+       OPT_MOUNT       = (1 << 4),     /* May be specified at mount time */
+       OPT_RUNTIME     = (1 << 5),     /* May be specified at runtime */
+       OPT_HUMAN_READABLE = (1 << 6),
+       OPT_MUST_BE_POW_2 = (1 << 7),   /* Must be power of 2 */
+       OPT_SB_FIELD_SECTORS = (1 << 8),/* Superblock field is >> 9 of actual value */
+       OPT_SB_FIELD_ILOG2 = (1 << 9),  /* Superblock field is ilog2 of actual value */
 };
 
 enum opt_type {
        BCH_OPT_BOOL,
        BCH_OPT_UINT,
        BCH_OPT_STR,
+       BCH_OPT_FN,
 };
 
 /**
- * BCH_OPT(name, type, in mem type, mode, sb_opt)
+ * x(name, shortopt, type, in mem type, mode, sb_opt)
  *
  * @name       - name of mount option, sysfs attribute, and struct bch_opts
  *               member
@@ -63,115 +86,382 @@ enum opt_type {
  *  - helptext
  */
 
+#ifdef __KERNEL__
+#define RATELIMIT_ERRORS_DEFAULT true
+#else
+#define RATELIMIT_ERRORS_DEFAULT false
+#endif
+
+#ifdef CONFIG_BCACHEFS_DEBUG
+#define BCACHEFS_VERBOSE_DEFAULT       true
+#else
+#define BCACHEFS_VERBOSE_DEFAULT       false
+#endif
+
 #define BCH_OPTS()                                                     \
-       BCH_OPT(block_size,             u16,    OPT_FORMAT,             \
-               OPT_UINT(1, 128),                                       \
-               BCH_SB_BLOCK_SIZE,              8)                      \
-       BCH_OPT(btree_node_size,        u16,    OPT_FORMAT,             \
-               OPT_UINT(1, 128),                                       \
-               BCH_SB_BTREE_NODE_SIZE,         512)                    \
-       BCH_OPT(errors,                 u8,     OPT_RUNTIME,            \
-               OPT_STR(bch2_error_actions),                            \
-               BCH_SB_ERROR_ACTION,            BCH_ON_ERROR_RO)        \
-       BCH_OPT(metadata_replicas,      u8,     OPT_MOUNT,              \
-               OPT_UINT(1, BCH_REPLICAS_MAX),                          \
-               BCH_SB_META_REPLICAS_WANT,      1)                      \
-       BCH_OPT(data_replicas,          u8,     OPT_MOUNT,              \
-               OPT_UINT(1, BCH_REPLICAS_MAX),                          \
-               BCH_SB_DATA_REPLICAS_WANT,      1)                      \
-       BCH_OPT(metadata_replicas_required, u8, OPT_MOUNT,              \
-               OPT_UINT(1, BCH_REPLICAS_MAX),                          \
-               BCH_SB_META_REPLICAS_REQ,       1)                      \
-       BCH_OPT(data_replicas_required, u8,     OPT_MOUNT,              \
-               OPT_UINT(1, BCH_REPLICAS_MAX),                          \
-               BCH_SB_DATA_REPLICAS_REQ,       1)                      \
-       BCH_OPT(metadata_checksum,      u8,     OPT_RUNTIME,            \
-               OPT_STR(bch2_csum_types),                               \
-               BCH_SB_META_CSUM_TYPE,          BCH_CSUM_OPT_CRC32C)    \
-       BCH_OPT(data_checksum,          u8,     OPT_RUNTIME,            \
-               OPT_STR(bch2_csum_types),                               \
-               BCH_SB_DATA_CSUM_TYPE,          BCH_CSUM_OPT_CRC32C)    \
-       BCH_OPT(compression,            u8,     OPT_RUNTIME,            \
-               OPT_STR(bch2_compression_types),                        \
-               BCH_SB_COMPRESSION_TYPE,        BCH_COMPRESSION_OPT_NONE)\
-       BCH_OPT(str_hash,               u8,     OPT_RUNTIME,            \
-               OPT_STR(bch2_str_hash_types),                           \
-               BCH_SB_STR_HASH_TYPE,           BCH_STR_HASH_SIPHASH)   \
-       BCH_OPT(inodes_32bit,           u8,     OPT_RUNTIME,            \
-               OPT_BOOL(),                                             \
-               BCH_SB_INODE_32BIT,             false)                  \
-       BCH_OPT(gc_reserve_percent,     u8,     OPT_MOUNT,              \
-               OPT_UINT(5, 21),                                        \
-               BCH_SB_GC_RESERVE,              8)                      \
-       BCH_OPT(root_reserve_percent,   u8,     OPT_MOUNT,              \
-               OPT_UINT(0, 100),                                       \
-               BCH_SB_ROOT_RESERVE,            0)                      \
-       BCH_OPT(wide_macs,              u8,     OPT_RUNTIME,            \
-               OPT_BOOL(),                                             \
-               BCH_SB_128_BIT_MACS,            false)                  \
-       BCH_OPT(acl,                    u8,     OPT_MOUNT,              \
-               OPT_BOOL(),                                             \
-               BCH_SB_POSIX_ACL,               true)                   \
-       BCH_OPT(degraded,               u8,     OPT_MOUNT,              \
-               OPT_BOOL(),                                             \
-               NO_SB_OPT,                      false)                  \
-       BCH_OPT(verbose_recovery,       u8,     OPT_MOUNT,              \
-               OPT_BOOL(),                                             \
-               NO_SB_OPT,                      false)                  \
-       BCH_OPT(journal_flush_disabled, u8,     OPT_RUNTIME,            \
-               OPT_BOOL(),                                             \
-               NO_SB_OPT,                      false)                  \
-       BCH_OPT(nofsck,                 u8,     OPT_MOUNT,              \
-               OPT_BOOL(),                                             \
-               NO_SB_OPT,                      false)                  \
-       BCH_OPT(fix_errors,             u8,     OPT_MOUNT,              \
-               OPT_BOOL(),                                             \
-               NO_SB_OPT,                      false)                  \
-       BCH_OPT(nochanges,              u8,     OPT_MOUNT,              \
-               OPT_BOOL(),                                             \
-               NO_SB_OPT,                      false)                  \
-       BCH_OPT(noreplay,               u8,     OPT_MOUNT,              \
-               OPT_BOOL(),                                             \
-               NO_SB_OPT,                      false)                  \
-       BCH_OPT(norecovery,             u8,     OPT_MOUNT,              \
-               OPT_BOOL(),                                             \
-               NO_SB_OPT,                      false)                  \
-       BCH_OPT(noexcl,                 u8,     OPT_MOUNT,              \
-               OPT_BOOL(),                                             \
-               NO_SB_OPT,                      false)                  \
-       BCH_OPT(sb,                     u64,    OPT_MOUNT,              \
-               OPT_UINT(0, S64_MAX),                                   \
-               NO_SB_OPT,                      BCH_SB_SECTOR)          \
-       BCH_OPT(read_only,              u8,     OPT_INTERNAL,           \
-               OPT_BOOL(),                                             \
-               NO_SB_OPT,                      false)                  \
-       BCH_OPT(nostart,                u8,     OPT_INTERNAL,           \
-               OPT_BOOL(),                                             \
-               NO_SB_OPT,                      false)
+       x(block_size,                   u16,                            \
+         OPT_FS|OPT_FORMAT|                                            \
+         OPT_HUMAN_READABLE|OPT_MUST_BE_POW_2|OPT_SB_FIELD_SECTORS,    \
+         OPT_UINT(512, 1U << 16),                                      \
+         BCH_SB_BLOCK_SIZE,            8,                              \
+         "size",       NULL)                                           \
+       x(btree_node_size,              u32,                            \
+         OPT_FS|OPT_FORMAT|                                            \
+         OPT_HUMAN_READABLE|OPT_MUST_BE_POW_2|OPT_SB_FIELD_SECTORS,    \
+         OPT_UINT(512, 1U << 20),                                      \
+         BCH_SB_BTREE_NODE_SIZE,       512,                            \
+         "size",       "Btree node size, default 256k")                \
+       x(errors,                       u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,                      \
+         OPT_STR(bch2_error_actions),                                  \
+         BCH_SB_ERROR_ACTION,          BCH_ON_ERROR_ro,                \
+         NULL,         "Action to take on filesystem error")           \
+       x(metadata_replicas,            u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,                      \
+         OPT_UINT(1, BCH_REPLICAS_MAX),                                \
+         BCH_SB_META_REPLICAS_WANT,    1,                              \
+         "#",          "Number of metadata replicas")                  \
+       x(data_replicas,                u8,                             \
+         OPT_FS|OPT_INODE|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,            \
+         OPT_UINT(1, BCH_REPLICAS_MAX),                                \
+         BCH_SB_DATA_REPLICAS_WANT,    1,                              \
+         "#",          "Number of data replicas")                      \
+       x(metadata_replicas_required, u8,                               \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT,                                  \
+         OPT_UINT(1, BCH_REPLICAS_MAX),                                \
+         BCH_SB_META_REPLICAS_REQ,     1,                              \
+         "#",          NULL)                                           \
+       x(data_replicas_required,       u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT,                                  \
+         OPT_UINT(1, BCH_REPLICAS_MAX),                                \
+         BCH_SB_DATA_REPLICAS_REQ,     1,                              \
+         "#",          NULL)                                           \
+       x(encoded_extent_max,           u32,                            \
+         OPT_FS|OPT_FORMAT|                                            \
+         OPT_HUMAN_READABLE|OPT_MUST_BE_POW_2|OPT_SB_FIELD_SECTORS|OPT_SB_FIELD_ILOG2,\
+         OPT_UINT(4096, 2U << 20),                                     \
+         BCH_SB_ENCODED_EXTENT_MAX_BITS, 64 << 10,                     \
+         "size",       "Maximum size of checksummed/compressed extents")\
+       x(metadata_checksum,            u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,                      \
+         OPT_STR(bch2_csum_opts),                                      \
+         BCH_SB_META_CSUM_TYPE,        BCH_CSUM_OPT_crc32c,            \
+         NULL,         NULL)                                           \
+       x(data_checksum,                u8,                             \
+         OPT_FS|OPT_INODE|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,            \
+         OPT_STR(bch2_csum_opts),                                      \
+         BCH_SB_DATA_CSUM_TYPE,        BCH_CSUM_OPT_crc32c,            \
+         NULL,         NULL)                                           \
+       x(compression,                  u8,                             \
+         OPT_FS|OPT_INODE|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,            \
+         OPT_STR(bch2_compression_opts),                               \
+         BCH_SB_COMPRESSION_TYPE,      BCH_COMPRESSION_OPT_none,       \
+         NULL,         NULL)                                           \
+       x(background_compression,       u8,                             \
+         OPT_FS|OPT_INODE|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,            \
+         OPT_STR(bch2_compression_opts),                               \
+         BCH_SB_BACKGROUND_COMPRESSION_TYPE,BCH_COMPRESSION_OPT_none,  \
+         NULL,         NULL)                                           \
+       x(str_hash,                     u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,                      \
+         OPT_STR(bch2_str_hash_opts),                                  \
+         BCH_SB_STR_HASH_TYPE,         BCH_STR_HASH_OPT_siphash,       \
+         NULL,         "Hash function for directory entries and xattrs")\
+       x(metadata_target,              u16,                            \
+         OPT_FS|OPT_INODE|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,            \
+         OPT_FN(bch2_opt_target),                                      \
+         BCH_SB_METADATA_TARGET,       0,                              \
+         "(target)",   "Device or label for metadata writes")          \
+       x(foreground_target,            u16,                            \
+         OPT_FS|OPT_INODE|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,            \
+         OPT_FN(bch2_opt_target),                                      \
+         BCH_SB_FOREGROUND_TARGET,     0,                              \
+         "(target)",   "Device or label for foreground writes")        \
+       x(background_target,            u16,                            \
+         OPT_FS|OPT_INODE|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,            \
+         OPT_FN(bch2_opt_target),                                      \
+         BCH_SB_BACKGROUND_TARGET,     0,                              \
+         "(target)",   "Device or label to move data to in the background")\
+       x(promote_target,               u16,                            \
+         OPT_FS|OPT_INODE|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,            \
+         OPT_FN(bch2_opt_target),                                      \
+         BCH_SB_PROMOTE_TARGET,        0,                              \
+         "(target)",   "Device or label to promote data to on read")   \
+       x(erasure_code,                 u16,                            \
+         OPT_FS|OPT_INODE|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,            \
+         OPT_BOOL(),                                                   \
+         BCH_SB_ERASURE_CODE,          false,                          \
+         NULL,         "Enable erasure coding (DO NOT USE YET)")       \
+       x(inodes_32bit,                 u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,                      \
+         OPT_BOOL(),                                                   \
+         BCH_SB_INODE_32BIT,           true,                           \
+         NULL,         "Constrain inode numbers to 32 bits")           \
+       x(shard_inode_numbers,          u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,                      \
+         OPT_BOOL(),                                                   \
+         BCH_SB_SHARD_INUMS,           true,                           \
+         NULL,         "Shard new inode numbers by CPU id")            \
+       x(inodes_use_key_cache, u8,                                     \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT,                                  \
+         OPT_BOOL(),                                                   \
+         BCH_SB_INODES_USE_KEY_CACHE,  true,                           \
+         NULL,         "Use the btree key cache for the inodes btree") \
+       x(btree_node_mem_ptr_optimization, u8,                          \
+         OPT_FS|OPT_MOUNT|OPT_RUNTIME,                                 \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               true,                           \
+         NULL,         "Stash pointer to in memory btree node in btree ptr")\
+       x(btree_write_buffer_size, u32,                                 \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_UINT(16, (1U << 20) - 1),                                 \
+         BCH2_NO_SB_OPT,               1U << 13,                       \
+         NULL,         "Number of btree write buffer entries")         \
+       x(gc_reserve_percent,           u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,                      \
+         OPT_UINT(5, 21),                                              \
+         BCH_SB_GC_RESERVE,            8,                              \
+         "%",          "Percentage of disk space to reserve for copygc")\
+       x(gc_reserve_bytes,             u64,                            \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME|                      \
+         OPT_HUMAN_READABLE|OPT_SB_FIELD_SECTORS,                      \
+         OPT_UINT(0, U64_MAX),                                         \
+         BCH_SB_GC_RESERVE_BYTES,      0,                              \
+         "%",          "Amount of disk space to reserve for copygc\n"  \
+                       "Takes precedence over gc_reserve_percent if set")\
+       x(root_reserve_percent,         u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT,                                  \
+         OPT_UINT(0, 100),                                             \
+         BCH_SB_ROOT_RESERVE,          0,                              \
+         "%",          "Percentage of disk space to reserve for superuser")\
+       x(wide_macs,                    u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,                      \
+         OPT_BOOL(),                                                   \
+         BCH_SB_128_BIT_MACS,          false,                          \
+         NULL,         "Store full 128 bits of cryptographic MACs, instead of 80")\
+       x(inline_data,                  u8,                             \
+         OPT_FS|OPT_MOUNT|OPT_RUNTIME,                                 \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               true,                           \
+         NULL,         "Enable inline data extents")                   \
+       x(acl,                          u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT,                                  \
+         OPT_BOOL(),                                                   \
+         BCH_SB_POSIX_ACL,             true,                           \
+         NULL,         "Enable POSIX acls")                            \
+       x(usrquota,                     u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT,                                  \
+         OPT_BOOL(),                                                   \
+         BCH_SB_USRQUOTA,              false,                          \
+         NULL,         "Enable user quotas")                           \
+       x(grpquota,                     u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT,                                  \
+         OPT_BOOL(),                                                   \
+         BCH_SB_GRPQUOTA,              false,                          \
+         NULL,         "Enable group quotas")                          \
+       x(prjquota,                     u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT,                                  \
+         OPT_BOOL(),                                                   \
+         BCH_SB_PRJQUOTA,              false,                          \
+         NULL,         "Enable project quotas")                        \
+       x(degraded,                     u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Allow mounting in degraded mode")              \
+       x(very_degraded,                u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Allow mounting in when data will be missing")  \
+       x(discard,                      u8,                             \
+         OPT_FS|OPT_MOUNT|OPT_DEVICE,                                  \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               true,                           \
+         NULL,         "Enable discard/TRIM support")                  \
+       x(verbose,                      u8,                             \
+         OPT_FS|OPT_MOUNT|OPT_RUNTIME,                                 \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               BCACHEFS_VERBOSE_DEFAULT,       \
+         NULL,         "Extra debugging information during mount/recovery")\
+       x(journal_flush_delay,          u32,                            \
+         OPT_FS|OPT_MOUNT|OPT_RUNTIME,                                 \
+         OPT_UINT(1, U32_MAX),                                         \
+         BCH_SB_JOURNAL_FLUSH_DELAY,   1000,                           \
+         NULL,         "Delay in milliseconds before automatic journal commits")\
+       x(journal_flush_disabled,       u8,                             \
+         OPT_FS|OPT_MOUNT|OPT_RUNTIME,                                 \
+         OPT_BOOL(),                                                   \
+         BCH_SB_JOURNAL_FLUSH_DISABLED,false,                          \
+         NULL,         "Disable journal flush on sync/fsync\n"         \
+                       "If enabled, writes can be lost, but only since the\n"\
+                       "last journal write (default 1 second)")        \
+       x(journal_reclaim_delay,        u32,                            \
+         OPT_FS|OPT_MOUNT|OPT_RUNTIME,                                 \
+         OPT_UINT(0, U32_MAX),                                         \
+         BCH_SB_JOURNAL_RECLAIM_DELAY, 100,                            \
+         NULL,         "Delay in milliseconds before automatic journal reclaim")\
+       x(move_bytes_in_flight,         u32,                            \
+         OPT_HUMAN_READABLE|OPT_FS|OPT_MOUNT|OPT_RUNTIME,              \
+         OPT_UINT(1024, U32_MAX),                                      \
+         BCH2_NO_SB_OPT,               1U << 20,                       \
+         NULL,         "Maximum Amount of IO to keep in flight by the move path")\
+       x(move_ios_in_flight,           u32,                            \
+         OPT_FS|OPT_MOUNT|OPT_RUNTIME,                                 \
+         OPT_UINT(1, 1024),                                            \
+         BCH2_NO_SB_OPT,               32,                             \
+         NULL,         "Maximum number of IOs to keep in flight by the move path")\
+       x(fsck,                         u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Run fsck on mount")                            \
+       x(fix_errors,                   u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Fix errors during fsck without asking")        \
+       x(ratelimit_errors,             u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               RATELIMIT_ERRORS_DEFAULT,       \
+         NULL,         "Ratelimit error messages during fsck")         \
+       x(nochanges,                    u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Super read only mode - no writes at all will be issued,\n"\
+                       "even if we have to replay the journal")        \
+       x(norecovery,                   u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Don't replay the journal")                     \
+       x(keep_journal,                 u8,                             \
+         0,                                                            \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Don't free journal entries/keys after startup")\
+       x(read_entire_journal,          u8,                             \
+         0,                                                            \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Read all journal entries, not just dirty ones")\
+       x(read_journal_only,            u8,                             \
+         0,                                                            \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Only read the journal, skip the rest of recovery")\
+       x(journal_transaction_names,    u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME,                      \
+         OPT_BOOL(),                                                   \
+         BCH_SB_JOURNAL_TRANSACTION_NAMES, true,                       \
+         NULL,         "Log transaction function names in journal")    \
+       x(noexcl,                       u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Don't open device in exclusive mode")          \
+       x(direct_io,                    u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,                       true,                   \
+         NULL,         "Use O_DIRECT (userspace only)")                \
+       x(sb,                           u64,                            \
+         OPT_MOUNT,                                                    \
+         OPT_UINT(0, S64_MAX),                                         \
+         BCH2_NO_SB_OPT,               BCH_SB_SECTOR,                  \
+         "offset",     "Sector offset of superblock")                  \
+       x(read_only,                    u8,                             \
+         OPT_FS,                                                       \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         NULL)                                           \
+       x(nostart,                      u8,                             \
+         0,                                                            \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Don\'t start filesystem, only open devices")   \
+       x(reconstruct_alloc,            u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Reconstruct alloc btree")                      \
+       x(version_upgrade,              u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_STR(bch2_version_upgrade_opts),                           \
+         BCH_SB_VERSION_UPGRADE,       BCH_VERSION_UPGRADE_compatible, \
+         NULL,         "Set superblock to latest version,\n"           \
+                       "allowing any new features to be used")         \
+       x(buckets_nouse,                u8,                             \
+         0,                                                            \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Allocate the buckets_nouse bitmap")            \
+       x(project,                      u8,                             \
+         OPT_INODE,                                                    \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         NULL)                                           \
+       x(nocow,                        u8,                             \
+         OPT_FS|OPT_FORMAT|OPT_MOUNT|OPT_RUNTIME|OPT_INODE,            \
+         OPT_BOOL(),                                                   \
+         BCH_SB_NOCOW,                 false,                          \
+         NULL,         "Nocow mode: Writes will be done in place when possible.\n"\
+                       "Snapshots and reflink will still caused writes to be COW\n"\
+                       "Implicitly disables data checksumming, compression and encryption")\
+       x(nocow_enabled,                u8,                             \
+         OPT_FS|OPT_MOUNT,                                             \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,                       true,                   \
+         NULL,         "Enable nocow mode: enables runtime locking in\n"\
+                       "data move path needed if nocow will ever be in use\n")\
+       x(no_data_io,                   u8,                             \
+         OPT_MOUNT,                                                    \
+         OPT_BOOL(),                                                   \
+         BCH2_NO_SB_OPT,               false,                          \
+         NULL,         "Skip submit_bio() for data reads and writes, " \
+                       "for performance testing purposes")             \
+       x(fs_size,                      u64,                            \
+         OPT_DEVICE,                                                   \
+         OPT_UINT(0, S64_MAX),                                         \
+         BCH2_NO_SB_OPT,               0,                              \
+         "size",       "Size of filesystem on device")                 \
+       x(bucket,                       u32,                            \
+         OPT_DEVICE,                                                   \
+         OPT_UINT(0, S64_MAX),                                         \
+         BCH2_NO_SB_OPT,               0,                              \
+         "size",       "Size of filesystem on device")                 \
+       x(durability,                   u8,                             \
+         OPT_DEVICE,                                                   \
+         OPT_UINT(0, BCH_REPLICAS_MAX),                                \
+         BCH2_NO_SB_OPT,               1,                              \
+         "n",          "Data written to this device will be considered\n"\
+                       "to have already been replicated n times")
 
 struct bch_opts {
-#define BCH_OPT(_name, _bits, ...)     unsigned _name##_defined:1;
+#define x(_name, _bits, ...)   unsigned _name##_defined:1;
        BCH_OPTS()
-#undef BCH_OPT
+#undef x
 
-#define BCH_OPT(_name, _bits, ...)     _bits   _name;
+#define x(_name, _bits, ...)   _bits   _name;
        BCH_OPTS()
-#undef BCH_OPT
+#undef x
 };
 
 static const struct bch_opts bch2_opts_default = {
-#define BCH_OPT(_name, _bits, _mode, _type, _sb_opt, _default)         \
+#define x(_name, _bits, _mode, _type, _sb_opt, _default, ...)          \
        ._name##_defined = true,                                        \
        ._name = _default,                                              \
 
        BCH_OPTS()
-#undef BCH_OPT
+#undef x
 };
 
 #define opt_defined(_opts, _name)      ((_opts)._name##_defined)
 
 #define opt_get(_opts, _name)                                          \
-       (opt_defined(_opts, _name) ? _opts._name : bch2_opts_default._name)
+       (opt_defined(_opts, _name) ? (_opts)._name : bch2_opts_default._name)
 
 #define opt_set(_opts, _name, _v)                                      \
 do {                                                                   \
@@ -187,26 +477,29 @@ static inline struct bch_opts bch2_opts_empty(void)
 void bch2_opts_apply(struct bch_opts *, struct bch_opts);
 
 enum bch_opt_id {
-#define BCH_OPT(_name, ...)    Opt_##_name,
+#define x(_name, ...)  Opt_##_name,
        BCH_OPTS()
-#undef BCH_OPT
+#undef x
        bch2_opts_nr
 };
 
+struct bch_fs;
+struct printbuf;
+
 struct bch_option {
        struct attribute        attr;
+       u64                     (*get_sb)(const struct bch_sb *);
        void                    (*set_sb)(struct bch_sb *, u64);
-       enum opt_mode           mode;
        enum opt_type           type;
+       enum opt_flags          flags;
+       u64                     min, max;
 
-       union {
-       struct {
-               u64             min, max;
-       };
-       struct {
-               const char * const *choices;
-       };
-       };
+       const char * const *choices;
+       int (*parse)(struct bch_fs *, const char *, u64 *);
+       void (*to_text)(struct printbuf *, struct bch_fs *, struct bch_sb *, u64);
+
+       const char              *hint;
+       const char              *help;
 
 };
 
@@ -216,31 +509,35 @@ bool bch2_opt_defined_by_id(const struct bch_opts *, enum bch_opt_id);
 u64 bch2_opt_get_by_id(const struct bch_opts *, enum bch_opt_id);
 void bch2_opt_set_by_id(struct bch_opts *, enum bch_opt_id, u64);
 
-struct bch_opts bch2_opts_from_sb(struct bch_sb *);
+u64 bch2_opt_from_sb(struct bch_sb *, enum bch_opt_id);
+int bch2_opts_from_sb(struct bch_opts *, struct bch_sb *);
+void __bch2_opt_set_sb(struct bch_sb *, const struct bch_option *, u64);
+void bch2_opt_set_sb(struct bch_fs *, const struct bch_option *, u64);
 
 int bch2_opt_lookup(const char *);
-int bch2_opt_parse(const struct bch_option *, const char *, u64 *);
-int bch2_parse_mount_opts(struct bch_opts *, char *);
+int bch2_opt_validate(const struct bch_option *, u64, struct printbuf *);
+int bch2_opt_parse(struct bch_fs *, const struct bch_option *,
+                  const char *, u64 *, struct printbuf *);
 
-/* inode opts: */
+#define OPT_SHOW_FULL_LIST     (1 << 0)
+#define OPT_SHOW_MOUNT_STYLE   (1 << 1)
 
-#define BCH_INODE_OPTS()                                       \
-       BCH_INODE_OPT(data_checksum,                    8)      \
-       BCH_INODE_OPT(compression,                      8)
+void bch2_opt_to_text(struct printbuf *, struct bch_fs *, struct bch_sb *,
+                     const struct bch_option *, u64, unsigned);
 
-struct bch_io_opts {
-#define BCH_INODE_OPT(_name, _bits)    unsigned _name##_defined:1;
-       BCH_INODE_OPTS()
-#undef BCH_INODE_OPT
+int bch2_opt_check_may_set(struct bch_fs *, int, u64);
+int bch2_opts_check_may_set(struct bch_fs *);
+int bch2_parse_mount_opts(struct bch_fs *, struct bch_opts *, char *);
 
-#define BCH_INODE_OPT(_name, _bits)    u##_bits _name;
+/* inode opts: */
+
+struct bch_io_opts {
+#define x(_name, _bits)        u##_bits _name;
        BCH_INODE_OPTS()
-#undef BCH_INODE_OPT
+#undef x
 };
 
 struct bch_io_opts bch2_opts_to_inode_opts(struct bch_opts);
-struct bch_opts bch2_inode_opts_to_opts(struct bch_io_opts);
-void bch2_io_opts_apply(struct bch_io_opts *, struct bch_io_opts);
 bool bch2_opt_is_inode_opt(enum bch_opt_id);
 
 #endif /* _BCACHEFS_OPTS_H */