]> git.sesse.net Git - bcachefs-tools-debian/blobdiff - libbcachefs/reflink.c
Update bcachefs sources to ac3ab6a511 bcachefs: Fix an uninitialized var
[bcachefs-tools-debian] / libbcachefs / reflink.c
index d78a3d5f72465d32da21df13b21dab6af04b766c..c624fabe1e1cd74380baeeb7aef4f0e41886c041 100644 (file)
@@ -1,7 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0
 #include "bcachefs.h"
-#include "bkey_on_stack.h"
+#include "bkey_buf.h"
 #include "btree_update.h"
+#include "buckets.h"
 #include "extents.h"
 #include "inode.h"
 #include "io.h"
@@ -9,6 +10,18 @@
 
 #include <linux/sched/signal.h>
 
+static inline unsigned bkey_type_to_indirect(const struct bkey *k)
+{
+       switch (k->type) {
+       case KEY_TYPE_extent:
+               return KEY_TYPE_reflink_v;
+       case KEY_TYPE_inline_data:
+               return KEY_TYPE_indirect_inline_data;
+       default:
+               return 0;
+       }
+}
+
 /* reflink pointers */
 
 const char *bch2_reflink_p_invalid(const struct bch_fs *c, struct bkey_s_c k)
@@ -71,18 +84,43 @@ void bch2_reflink_v_to_text(struct printbuf *out, struct bch_fs *c,
        bch2_bkey_ptrs_to_text(out, c, k);
 }
 
+/* indirect inline data */
+
+const char *bch2_indirect_inline_data_invalid(const struct bch_fs *c,
+                                             struct bkey_s_c k)
+{
+       if (bkey_val_bytes(k.k) < sizeof(struct bch_indirect_inline_data))
+               return "incorrect value size";
+       return NULL;
+}
+
+void bch2_indirect_inline_data_to_text(struct printbuf *out,
+                                       struct bch_fs *c, struct bkey_s_c k)
+{
+       struct bkey_s_c_indirect_inline_data d = bkey_s_c_to_indirect_inline_data(k);
+       unsigned datalen = bkey_inline_data_bytes(k.k);
+
+       pr_buf(out, "refcount %llu datalen %u: %*phN",
+              le64_to_cpu(d.v->refcount), datalen,
+              min(datalen, 32U), d.v->data);
+}
+
 static int bch2_make_extent_indirect(struct btree_trans *trans,
                                     struct btree_iter *extent_iter,
-                                    struct bkey_i_extent *e)
+                                    struct bkey_i *orig)
 {
        struct bch_fs *c = trans->c;
        struct btree_iter *reflink_iter;
        struct bkey_s_c k;
-       struct bkey_i_reflink_v *r_v;
+       struct bkey_i *r_v;
        struct bkey_i_reflink_p *r_p;
+       __le64 *refcount;
        int ret;
 
-       for_each_btree_key(trans, reflink_iter, BTREE_ID_REFLINK,
+       if (orig->k.type == KEY_TYPE_inline_data)
+               bch2_check_set_feature(c, BCH_FEATURE_reflink_inline_data);
+
+       for_each_btree_key(trans, reflink_iter, BTREE_ID_reflink,
                           POS(0, c->reflink_hint),
                           BTREE_ITER_INTENT|BTREE_ITER_SLOTS, k, ret) {
                if (reflink_iter->pos.inode) {
@@ -90,7 +128,7 @@ static int bch2_make_extent_indirect(struct btree_trans *trans,
                        continue;
                }
 
-               if (bkey_deleted(k.k) && e->k.size <= k.k->size)
+               if (bkey_deleted(k.k) && orig->k.size <= k.k->size)
                        break;
        }
 
@@ -100,33 +138,39 @@ static int bch2_make_extent_indirect(struct btree_trans *trans,
        /* rewind iter to start of hole, if necessary: */
        bch2_btree_iter_set_pos(reflink_iter, bkey_start_pos(k.k));
 
-       r_v = bch2_trans_kmalloc(trans, sizeof(*r_v) + bkey_val_bytes(&e->k));
+       r_v = bch2_trans_kmalloc(trans, sizeof(__le64) + bkey_val_bytes(&orig->k));
        ret = PTR_ERR_OR_ZERO(r_v);
        if (ret)
                goto err;
 
-       bkey_reflink_v_init(&r_v->k_i);
+       bkey_init(&r_v->k);
+       r_v->k.type     = bkey_type_to_indirect(&orig->k);
        r_v->k.p        = reflink_iter->pos;
-       bch2_key_resize(&r_v->k, e->k.size);
-       r_v->k.version  = e->k.version;
+       bch2_key_resize(&r_v->k, orig->k.size);
+       r_v->k.version  = orig->k.version;
+
+       set_bkey_val_bytes(&r_v->k, sizeof(__le64) + bkey_val_bytes(&orig->k));
 
-       set_bkey_val_u64s(&r_v->k, bkey_val_u64s(&r_v->k) +
-                         bkey_val_u64s(&e->k));
-       r_v->v.refcount = 0;
-       memcpy(r_v->v.start, e->v.start, bkey_val_bytes(&e->k));
+       refcount        = (void *) &r_v->v;
+       *refcount       = 0;
+       memcpy(refcount + 1, &orig->v, bkey_val_bytes(&orig->k));
 
-       bch2_trans_update(trans, reflink_iter, &r_v->k_i, 0);
+       ret = bch2_trans_update(trans, reflink_iter, r_v, 0);
+       if (ret)
+               goto err;
 
        r_p = bch2_trans_kmalloc(trans, sizeof(*r_p));
-       if (IS_ERR(r_p))
-               return PTR_ERR(r_p);
+       if (IS_ERR(r_p)) {
+               ret = PTR_ERR(r_p);
+               goto err;
+       }
 
-       e->k.type = KEY_TYPE_reflink_p;
-       r_p = bkey_i_to_reflink_p(&e->k_i);
+       orig->k.type = KEY_TYPE_reflink_p;
+       r_p = bkey_i_to_reflink_p(orig);
        set_bkey_val_bytes(&r_p->k, sizeof(r_p->v));
        r_p->v.idx = cpu_to_le64(bkey_start_offset(&r_v->k));
 
-       bch2_trans_update(trans, extent_iter, &r_p->k_i, 0);
+       ret = bch2_trans_update(trans, extent_iter, &r_p->k_i, 0);
 err:
        if (!IS_ERR(reflink_iter))
                c->reflink_hint = reflink_iter->pos.offset;
@@ -144,8 +188,7 @@ static struct bkey_s_c get_next_src(struct btree_iter *iter, struct bpos end)
                if (bkey_cmp(iter->pos, end) >= 0)
                        return bkey_s_c_null;
 
-               if (k.k->type == KEY_TYPE_extent ||
-                   k.k->type == KEY_TYPE_reflink_p)
+               if (bkey_extent_is_data(k.k))
                        break;
        }
 
@@ -160,8 +203,7 @@ s64 bch2_remap_range(struct bch_fs *c,
        struct btree_trans trans;
        struct btree_iter *dst_iter, *src_iter;
        struct bkey_s_c src_k;
-       BKEY_PADDED(k) new_dst;
-       struct bkey_on_stack new_src;
+       struct bkey_buf new_dst, new_src;
        struct bpos dst_end = dst_start, src_end = src_start;
        struct bpos dst_want, src_want;
        u64 src_done, dst_done;
@@ -175,28 +217,29 @@ s64 bch2_remap_range(struct bch_fs *c,
        dst_end.offset += remap_sectors;
        src_end.offset += remap_sectors;
 
-       bkey_on_stack_init(&new_src);
+       bch2_bkey_buf_init(&new_dst);
+       bch2_bkey_buf_init(&new_src);
        bch2_trans_init(&trans, c, BTREE_ITER_MAX, 4096);
 
-       src_iter = bch2_trans_get_iter(&trans, BTREE_ID_EXTENTS, src_start,
+       src_iter = bch2_trans_get_iter(&trans, BTREE_ID_extents, src_start,
                                       BTREE_ITER_INTENT);
-       dst_iter = bch2_trans_get_iter(&trans, BTREE_ID_EXTENTS, dst_start,
+       dst_iter = bch2_trans_get_iter(&trans, BTREE_ID_extents, dst_start,
                                       BTREE_ITER_INTENT);
 
-       while (1) {
-               bch2_trans_reset(&trans, TRANS_RESET_MEM);
+       while (ret == 0 || ret == -EINTR) {
+               struct disk_reservation disk_res = { 0 };
 
-               trans.mem_top = 0;
+               bch2_trans_begin(&trans);
 
                if (fatal_signal_pending(current)) {
                        ret = -EINTR;
-                       goto err;
+                       break;
                }
 
                src_k = get_next_src(src_iter, src_end);
                ret = bkey_err(src_k);
                if (ret)
-                       goto btree_err;
+                       continue;
 
                src_done = bpos_min(src_iter->pos, src_end).offset -
                        src_start.offset;
@@ -205,8 +248,6 @@ s64 bch2_remap_range(struct bch_fs *c,
                if (bkey_cmp(dst_iter->pos, dst_want) < 0) {
                        ret = bch2_fpunch_at(&trans, dst_iter, dst_want,
                                             journal_seq, i_sectors_delta);
-                       if (ret)
-                               goto btree_err;
                        continue;
                }
 
@@ -215,17 +256,17 @@ s64 bch2_remap_range(struct bch_fs *c,
                if (!bkey_cmp(dst_iter->pos, dst_end))
                        break;
 
-               if (src_k.k->type == KEY_TYPE_extent) {
-                       bkey_on_stack_reassemble(&new_src, c, src_k);
+               if (src_k.k->type != KEY_TYPE_reflink_p) {
+                       bch2_bkey_buf_reassemble(&new_src, c, src_k);
                        src_k = bkey_i_to_s_c(new_src.k);
 
                        bch2_cut_front(src_iter->pos,   new_src.k);
                        bch2_cut_back(src_end,          new_src.k);
 
                        ret = bch2_make_extent_indirect(&trans, src_iter,
-                                               bkey_i_to_extent(new_src.k));
+                                               new_src.k);
                        if (ret)
-                               goto btree_err;
+                               continue;
 
                        BUG_ON(src_k.k->type != KEY_TYPE_reflink_p);
                }
@@ -234,7 +275,7 @@ s64 bch2_remap_range(struct bch_fs *c,
                        struct bkey_s_c_reflink_p src_p =
                                bkey_s_c_to_reflink_p(src_k);
                        struct bkey_i_reflink_p *dst_p =
-                               bkey_reflink_p_init(&new_dst.k);
+                               bkey_reflink_p_init(new_dst.k);
 
                        u64 offset = le64_to_cpu(src_p.v->idx) +
                                (src_iter->pos.offset -
@@ -245,29 +286,27 @@ s64 bch2_remap_range(struct bch_fs *c,
                        BUG();
                }
 
-               new_dst.k.k.p = dst_iter->pos;
-               bch2_key_resize(&new_dst.k.k,
+               new_dst.k->k.p = dst_iter->pos;
+               bch2_key_resize(&new_dst.k->k,
                                min(src_k.k->p.offset - src_iter->pos.offset,
                                    dst_end.offset - dst_iter->pos.offset));
 
-               ret = bch2_extent_update(&trans, dst_iter, &new_dst.k,
-                                        NULL, journal_seq,
-                                        new_i_size, i_sectors_delta);
+               ret = bch2_extent_update(&trans, dst_iter, new_dst.k,
+                                        &disk_res, journal_seq,
+                                        new_i_size, i_sectors_delta,
+                                        true);
+               bch2_disk_reservation_put(c, &disk_res);
                if (ret)
-                       goto btree_err;
+                       continue;
 
                dst_done = dst_iter->pos.offset - dst_start.offset;
                src_want = POS(src_start.inode, src_start.offset + dst_done);
                bch2_btree_iter_set_pos(src_iter, src_want);
-btree_err:
-               if (ret == -EINTR)
-                       ret = 0;
-               if (ret)
-                       goto err;
        }
+       bch2_trans_iter_put(&trans, dst_iter);
+       bch2_trans_iter_put(&trans, src_iter);
 
-       BUG_ON(bkey_cmp(dst_iter->pos, dst_end));
-err:
+       BUG_ON(!ret && bkey_cmp(dst_iter->pos, dst_end));
        BUG_ON(bkey_cmp(dst_iter->pos, dst_end) > 0);
 
        dst_done = dst_iter->pos.offset - dst_start.offset;
@@ -289,10 +328,13 @@ err:
                        ret2  = bch2_inode_write(&trans, inode_iter, &inode_u) ?:
                                bch2_trans_commit(&trans, NULL, journal_seq, 0);
                }
+
+               bch2_trans_iter_put(&trans, inode_iter);
        } while (ret2 == -EINTR);
 
        ret = bch2_trans_exit(&trans) ?: ret;
-       bkey_on_stack_exit(&new_src, c);
+       bch2_bkey_buf_exit(&new_src, c);
+       bch2_bkey_buf_exit(&new_dst, c);
 
        percpu_ref_put(&c->writes);