]> git.sesse.net Git - bcachefs-tools-debian/blobdiff - libbcachefs/sysfs.c
Update bcachefs sources to e99d29e402 bcachefs: zstd support, compression refactoring
[bcachefs-tools-debian] / libbcachefs / sysfs.c
index 9e9ef4cdf7d6fa75b9596940131aa029d9a0fdfd..2e958a8ef3817075eda22b8be1cdaccc8b9f005d 100644 (file)
@@ -5,13 +5,17 @@
  * Copyright 2012 Google, Inc.
  */
 
+#ifndef NO_BCACHEFS_SYSFS
+
 #include "bcachefs.h"
 #include "alloc.h"
 #include "compress.h"
 #include "sysfs.h"
 #include "btree_cache.h"
+#include "btree_io.h"
 #include "btree_iter.h"
 #include "btree_update.h"
+#include "btree_update_interior.h"
 #include "btree_gc.h"
 #include "buckets.h"
 #include "inode.h"
@@ -53,7 +57,7 @@ static ssize_t fn ## _store(struct kobject *kobj, struct attribute *attr,\
 #define sysfs_printf(file, fmt, ...)                                   \
 do {                                                                   \
        if (attr == &sysfs_ ## file)                                    \
-               return snprintf(buf, PAGE_SIZE, fmt "\n", __VA_ARGS__); \
+               return scnprintf(buf, PAGE_SIZE, fmt "\n", __VA_ARGS__);\
 } while (0)
 
 #define sysfs_print(file, var)                                         \
@@ -134,6 +138,7 @@ read_attribute(block_size);
 read_attribute(btree_node_size);
 read_attribute(first_bucket);
 read_attribute(nbuckets);
+read_attribute(iostats);
 read_attribute(read_priority_stats);
 read_attribute(write_priority_stats);
 read_attribute(fragmentation_stats);
@@ -141,37 +146,29 @@ read_attribute(oldest_gen_stats);
 read_attribute(reserve_stats);
 read_attribute(btree_cache_size);
 read_attribute(compression_stats);
-read_attribute(written);
-read_attribute(btree_written);
-read_attribute(metadata_written);
 read_attribute(journal_debug);
 read_attribute(journal_pins);
+read_attribute(btree_updates);
+read_attribute(dirty_btree_nodes);
 
 read_attribute(internal_uuid);
 
-read_attribute(available_buckets);
-read_attribute(free_buckets);
-read_attribute(dirty_data);
-read_attribute(dirty_bytes);
-read_attribute(dirty_buckets);
-read_attribute(cached_data);
-read_attribute(cached_bytes);
-read_attribute(cached_buckets);
-read_attribute(meta_buckets);
-read_attribute(alloc_buckets);
 read_attribute(has_data);
-read_attribute(has_metadata);
 read_attribute(alloc_debug);
+write_attribute(wake_allocator);
 
 read_attribute(read_realloc_races);
+read_attribute(extent_migrate_done);
+read_attribute(extent_migrate_raced);
 
 rw_attribute(journal_write_delay_ms);
 rw_attribute(journal_reclaim_delay_ms);
 
+rw_attribute(writeback_pages_max);
+
 rw_attribute(discard);
 rw_attribute(cache_replacement_policy);
 
-rw_attribute(foreground_write_ratelimit_enabled);
 rw_attribute(copy_gc_enabled);
 sysfs_pd_controller_attribute(copy_gc);
 
@@ -180,12 +177,9 @@ rw_attribute(tiering_enabled);
 rw_attribute(tiering_percent);
 sysfs_pd_controller_attribute(tiering);
 
-sysfs_pd_controller_attribute(foreground_write);
 
 rw_attribute(pd_controllers_update_seconds);
 
-rw_attribute(foreground_target_percent);
-
 read_attribute(meta_replicas_have);
 read_attribute(data_replicas_have);
 
@@ -195,14 +189,6 @@ read_attribute(data_replicas_have);
        BCH_DEBUG_PARAMS()
 #undef BCH_DEBUG_PARAM
 
-#define BCH_OPT(_name, _mode, ...)                                     \
-       static struct attribute sysfs_opt_##_name = {                   \
-               .name = #_name, .mode = _mode,                          \
-       };
-
-       BCH_VISIBLE_OPTS()
-#undef BCH_OPT
-
 #define BCH_TIME_STAT(name, frequency_units, duration_units)           \
        sysfs_time_stats_attribute(name, frequency_units, duration_units);
        BCH_TIME_STATS()
@@ -218,11 +204,11 @@ static size_t bch2_btree_cache_size(struct bch_fs *c)
        size_t ret = 0;
        struct btree *b;
 
-       mutex_lock(&c->btree_cache_lock);
-       list_for_each_entry(b, &c->btree_cache, list)
+       mutex_lock(&c->btree_cache.lock);
+       list_for_each_entry(b, &c->btree_cache.live, list)
                ret += btree_bytes(c);
 
-       mutex_unlock(&c->btree_cache_lock);
+       mutex_unlock(&c->btree_cache.lock);
        return ret;
 }
 
@@ -281,18 +267,18 @@ static ssize_t bch2_compression_stats(struct bch_fs *c, char *buf)
                if (k.k->type == BCH_EXTENT) {
                        struct bkey_s_c_extent e = bkey_s_c_to_extent(k);
                        const struct bch_extent_ptr *ptr;
-                       const union bch_extent_crc *crc;
+                       struct bch_extent_crc_unpacked crc;
 
                        extent_for_each_ptr_crc(e, ptr, crc) {
-                               if (crc_compression_type(crc) == BCH_COMPRESSION_NONE) {
+                               if (crc.compression_type == BCH_COMPRESSION_NONE) {
                                        nr_uncompressed_extents++;
                                        uncompressed_sectors += e.k->size;
                                } else {
                                        nr_compressed_extents++;
                                        compressed_sectors_compressed +=
-                                               crc_compressed_size(e.k, crc);
+                                               crc.compressed_size;
                                        compressed_sectors_uncompressed +=
-                                               crc_uncompressed_size(e.k, crc);
+                                               crc.uncompressed_size;
                                }
 
                                /* only looking at the first ptr */
@@ -301,7 +287,7 @@ static ssize_t bch2_compression_stats(struct bch_fs *c, char *buf)
                }
        bch2_btree_iter_unlock(&iter);
 
-       return snprintf(buf, PAGE_SIZE,
+       return scnprintf(buf, PAGE_SIZE,
                        "uncompressed data:\n"
                        "       nr extents:                     %llu\n"
                        "       size (bytes):                   %llu\n"
@@ -326,23 +312,25 @@ SHOW(bch2_fs)
        sysfs_print(journal_write_delay_ms,     c->journal.write_delay_ms);
        sysfs_print(journal_reclaim_delay_ms,   c->journal.reclaim_delay_ms);
 
+       sysfs_print(writeback_pages_max,        c->writeback_pages_max);
+
        sysfs_print(block_size,                 block_bytes(c));
        sysfs_print(btree_node_size,            btree_bytes(c));
        sysfs_hprint(btree_cache_size,          bch2_btree_cache_size(c));
 
        sysfs_print(read_realloc_races,
                    atomic_long_read(&c->read_realloc_races));
+       sysfs_print(extent_migrate_done,
+                   atomic_long_read(&c->extent_migrate_done));
+       sysfs_print(extent_migrate_raced,
+                   atomic_long_read(&c->extent_migrate_raced));
 
        sysfs_printf(btree_gc_periodic, "%u",   (int) c->btree_gc_periodic);
 
-       sysfs_printf(foreground_write_ratelimit_enabled, "%i",
-                    c->foreground_write_ratelimit_enabled);
        sysfs_printf(copy_gc_enabled, "%i", c->copy_gc_enabled);
-       sysfs_pd_controller_show(foreground_write, &c->foreground_write_pd);
 
        sysfs_print(pd_controllers_update_seconds,
                    c->pd_controllers_update_seconds);
-       sysfs_print(foreground_target_percent, c->foreground_target_percent);
 
        sysfs_printf(tiering_enabled,           "%i", c->tiering_enabled);
        sysfs_print(tiering_percent,            c->tiering_percent);
@@ -363,6 +351,12 @@ SHOW(bch2_fs)
        if (attr == &sysfs_journal_pins)
                return bch2_journal_print_pins(&c->journal, buf);
 
+       if (attr == &sysfs_btree_updates)
+               return bch2_btree_updates_print(c, buf);
+
+       if (attr == &sysfs_dirty_btree_nodes)
+               return bch2_dirty_btree_nodes_print(c, buf);
+
        if (attr == &sysfs_compression_stats)
                return bch2_compression_stats(c, buf);
 
@@ -380,8 +374,8 @@ STORE(__bch2_fs)
        sysfs_strtoul(journal_write_delay_ms, c->journal.write_delay_ms);
        sysfs_strtoul(journal_reclaim_delay_ms, c->journal.reclaim_delay_ms);
 
-       sysfs_strtoul(foreground_write_ratelimit_enabled,
-                     c->foreground_write_ratelimit_enabled);
+       if (attr == &sysfs_writeback_pages_max)
+               c->writeback_pages_max = strtoul_restrict_or_return(buf, 1, UINT_MAX);
 
        if (attr == &sysfs_btree_gc_periodic) {
                ssize_t ret = strtoul_safe(buf, c->btree_gc_periodic)
@@ -398,8 +392,8 @@ STORE(__bch2_fs)
                        ?: (ssize_t) size;
 
                for_each_member_device(ca, c, i)
-                       if (ca->moving_gc_read)
-                               wake_up_process(ca->moving_gc_read);
+                       if (ca->copygc_thread)
+                               wake_up_process(ca->copygc_thread);
                return ret;
        }
 
@@ -411,11 +405,8 @@ STORE(__bch2_fs)
                return ret;
        }
 
-       sysfs_pd_controller_store(foreground_write, &c->foreground_write_pd);
-
        sysfs_strtoul(pd_controllers_update_seconds,
                      c->pd_controllers_update_seconds);
-       sysfs_strtoul(foreground_target_percent, c->foreground_target_percent);
 
        sysfs_strtoul(tiering_percent,          c->tiering_percent);
        sysfs_pd_controller_store(tiering,      &c->tiers[1].pd); /* XXX */
@@ -445,7 +436,7 @@ STORE(__bch2_fs)
 
                sc.gfp_mask = GFP_KERNEL;
                sc.nr_to_scan = strtoul_or_return(buf);
-               c->btree_cache_shrink.scan_objects(&c->btree_cache_shrink, &sc);
+               c->btree_cache.shrink.scan_objects(&c->btree_cache.shrink, &sc);
        }
 
        return size;
@@ -475,7 +466,8 @@ struct attribute *bch2_fs_files[] = {
        &sysfs_journal_write_delay_ms,
        &sysfs_journal_reclaim_delay_ms,
 
-       &sysfs_foreground_target_percent,
+       &sysfs_writeback_pages_max,
+
        &sysfs_tiering_percent,
 
        &sysfs_compression_stats,
@@ -501,19 +493,21 @@ struct attribute *bch2_fs_internal_files[] = {
        &sysfs_alloc_debug,
        &sysfs_journal_debug,
        &sysfs_journal_pins,
+       &sysfs_btree_updates,
+       &sysfs_dirty_btree_nodes,
 
        &sysfs_read_realloc_races,
+       &sysfs_extent_migrate_done,
+       &sysfs_extent_migrate_raced,
 
        &sysfs_trigger_journal_flush,
        &sysfs_trigger_btree_coalesce,
        &sysfs_trigger_gc,
        &sysfs_prune_cache,
 
-       &sysfs_foreground_write_ratelimit_enabled,
        &sysfs_copy_gc_enabled,
        &sysfs_tiering_enabled,
        sysfs_pd_controller_files(tiering),
-       sysfs_pd_controller_files(foreground_write),
        &sysfs_internal_uuid,
 
 #define BCH_DEBUG_PARAM(name, description) &sysfs_##name,
@@ -527,23 +521,30 @@ struct attribute *bch2_fs_internal_files[] = {
 
 SHOW(bch2_fs_opts_dir)
 {
+       char *out = buf, *end = buf + PAGE_SIZE;
        struct bch_fs *c = container_of(kobj, struct bch_fs, opts_dir);
+       const struct bch_option *opt = container_of(attr, struct bch_option, attr);
+       int id = opt - bch2_opt_table;
+       u64 v = bch2_opt_get_by_id(&c->opts, id);
 
-       return bch2_opt_show(&c->opts, attr->name, buf, PAGE_SIZE);
+       out += opt->type == BCH_OPT_STR
+               ? bch2_scnprint_string_list(out, end - out, opt->choices, v)
+               : scnprintf(out, end - out, "%lli", v);
+       out += scnprintf(out, end - out, "\n");
+
+       return out - buf;
 }
 
 STORE(bch2_fs_opts_dir)
 {
        struct bch_fs *c = container_of(kobj, struct bch_fs, opts_dir);
-       const struct bch_option *opt;
-       int id;
+       const struct bch_option *opt = container_of(attr, struct bch_option, attr);
+       int ret, id = opt - bch2_opt_table;
        u64 v;
 
-       id = bch2_parse_sysfs_opt(attr->name, buf, &v);
-       if (id < 0)
-               return id;
-
-       opt = &bch2_opt_table[id];
+       ret = bch2_opt_parse(opt, buf, &v);
+       if (ret < 0)
+               return ret;
 
        mutex_lock(&c->sb_lock);
 
@@ -560,7 +561,7 @@ STORE(bch2_fs_opts_dir)
                bch2_write_super(c);
        }
 
-       bch2_opt_set(&c->opts, id, v);
+       bch2_opt_set_by_id(&c->opts, id, v);
 
        mutex_unlock(&c->sb_lock);
 
@@ -568,15 +569,26 @@ STORE(bch2_fs_opts_dir)
 }
 SYSFS_OPS(bch2_fs_opts_dir);
 
-struct attribute *bch2_fs_opts_dir_files[] = {
-#define BCH_OPT(_name, ...)                                            \
-       &sysfs_opt_##_name,
+struct attribute *bch2_fs_opts_dir_files[] = { NULL };
 
-       BCH_VISIBLE_OPTS()
-#undef BCH_OPT
+int bch2_opts_create_sysfs_files(struct kobject *kobj)
+{
+       const struct bch_option *i;
+       int ret;
 
-       NULL
-};
+       for (i = bch2_opt_table;
+            i < bch2_opt_table + bch2_opts_nr;
+            i++) {
+               if (i->mode == OPT_INTERNAL)
+                       continue;
+
+               ret = sysfs_create_file(kobj, &i->attr);
+               if (ret)
+                       return ret;
+       }
+
+       return 0;
+}
 
 /* time stats */
 
@@ -615,26 +627,28 @@ struct attribute *bch2_fs_time_stats_files[] = {
        NULL
 };
 
-typedef unsigned (bucket_map_fn)(struct bch_dev *, struct bucket *, void *);
+typedef unsigned (bucket_map_fn)(struct bch_dev *, size_t, void *);
 
-static unsigned bucket_priority_fn(struct bch_dev *ca, struct bucket *g,
+static unsigned bucket_priority_fn(struct bch_dev *ca, size_t b,
                                   void *private)
 {
+       struct bucket *g = bucket(ca, b);
        int rw = (private ? 1 : 0);
 
        return ca->fs->prio_clock[rw].hand - g->prio[rw];
 }
 
-static unsigned bucket_sectors_used_fn(struct bch_dev *ca, struct bucket *g,
+static unsigned bucket_sectors_used_fn(struct bch_dev *ca, size_t b,
                                       void *private)
 {
+       struct bucket *g = bucket(ca, b);
        return bucket_sectors_used(g->mark);
 }
 
-static unsigned bucket_oldest_gen_fn(struct bch_dev *ca, struct bucket *g,
+static unsigned bucket_oldest_gen_fn(struct bch_dev *ca, size_t b,
                                     void *private)
 {
-       return bucket_gc_gen(ca, g);
+       return bucket_gc_gen(ca, b);
 }
 
 static ssize_t show_quantiles(struct bch_dev *ca, char *buf,
@@ -643,19 +657,25 @@ static ssize_t show_quantiles(struct bch_dev *ca, char *buf,
        int cmp(const void *l, const void *r)
        {       return *((unsigned *) r) - *((unsigned *) l); }
 
-       size_t n = ca->mi.nbuckets, i;
+       size_t i, n;
        /* Compute 31 quantiles */
        unsigned q[31], *p;
        ssize_t ret = 0;
 
-       p = vzalloc(ca->mi.nbuckets * sizeof(unsigned));
-       if (!p)
+       down_read(&ca->bucket_lock);
+       n = ca->mi.nbuckets;
+
+       p = vzalloc(n * sizeof(unsigned));
+       if (!p) {
+               up_read(&ca->bucket_lock);
                return -ENOMEM;
+       }
 
        for (i = ca->mi.first_bucket; i < n; i++)
-               p[i] = fn(ca, &ca->buckets[i], private);
+               p[i] = fn(ca, i, private);
 
        sort(p, n, sizeof(unsigned), cmp, NULL);
+       up_read(&ca->bucket_lock);
 
        while (n &&
               !p[n - 1])
@@ -672,7 +692,6 @@ static ssize_t show_quantiles(struct bch_dev *ca, char *buf,
        buf[ret - 1] = '\n';
 
        return ret;
-
 }
 
 static ssize_t show_reserve_stats(struct bch_dev *ca, char *buf)
@@ -701,17 +720,28 @@ static ssize_t show_reserve_stats(struct bch_dev *ca, char *buf)
 static ssize_t show_dev_alloc_debug(struct bch_dev *ca, char *buf)
 {
        struct bch_fs *c = ca->fs;
-       struct bch_dev_usage stats = bch2_dev_usage_read(ca);
+       struct bch_dev_usage stats = bch2_dev_usage_read(c, ca);
 
        return scnprintf(buf, PAGE_SIZE,
                "free_inc:               %zu/%zu\n"
                "free[RESERVE_BTREE]:    %zu/%zu\n"
                "free[RESERVE_MOVINGGC]: %zu/%zu\n"
                "free[RESERVE_NONE]:     %zu/%zu\n"
-               "alloc:                  %llu/%llu\n"
-               "meta:                   %llu/%llu\n"
-               "dirty:                  %llu/%llu\n"
-               "available:              %llu/%llu\n"
+               "buckets:\n"
+               "    capacity:           %llu\n"
+               "    alloc:              %llu\n"
+               "    sb:                 %llu\n"
+               "    journal:            %llu\n"
+               "    meta:               %llu\n"
+               "    user:               %llu\n"
+               "    cached:             %llu\n"
+               "    available:          %llu\n"
+               "sectors:\n"
+               "    sb:                 %llu\n"
+               "    journal:            %llu\n"
+               "    meta:               %llu\n"
+               "    user:               %llu\n"
+               "    cached:             %llu\n"
                "freelist_wait:          %s\n"
                "open buckets:           %u/%u (reserved %u)\n"
                "open_buckets_wait:      %s\n",
@@ -719,31 +749,57 @@ static ssize_t show_dev_alloc_debug(struct bch_dev *ca, char *buf)
                fifo_used(&ca->free[RESERVE_BTREE]),    ca->free[RESERVE_BTREE].size,
                fifo_used(&ca->free[RESERVE_MOVINGGC]), ca->free[RESERVE_MOVINGGC].size,
                fifo_used(&ca->free[RESERVE_NONE]),     ca->free[RESERVE_NONE].size,
-               stats.buckets_alloc,                    ca->mi.nbuckets - ca->mi.first_bucket,
-               stats.buckets[S_META],                  ca->mi.nbuckets - ca->mi.first_bucket,
-               stats.buckets[S_DIRTY],                 ca->mi.nbuckets - ca->mi.first_bucket,
-               __dev_buckets_available(ca, stats),     ca->mi.nbuckets - ca->mi.first_bucket,
+               ca->mi.nbuckets - ca->mi.first_bucket,
+               stats.buckets_alloc,
+               stats.buckets[BCH_DATA_SB],
+               stats.buckets[BCH_DATA_JOURNAL],
+               stats.buckets[BCH_DATA_BTREE],
+               stats.buckets[BCH_DATA_USER],
+               stats.buckets[BCH_DATA_CACHED],
+               __dev_buckets_available(ca, stats),
+               stats.sectors[BCH_DATA_SB],
+               stats.sectors[BCH_DATA_JOURNAL],
+               stats.sectors[BCH_DATA_BTREE],
+               stats.sectors[BCH_DATA_USER],
+               stats.sectors[BCH_DATA_CACHED],
                c->freelist_wait.list.first             ? "waiting" : "empty",
                c->open_buckets_nr_free, OPEN_BUCKETS_COUNT, BTREE_NODE_RESERVE,
                c->open_buckets_wait.list.first         ? "waiting" : "empty");
 }
 
-static u64 sectors_written(struct bch_dev *ca)
+static const char * const bch2_rw[] = {
+       "read",
+       "write",
+       NULL
+};
+
+static ssize_t show_dev_iostats(struct bch_dev *ca, char *buf)
 {
-       u64 ret = 0;
-       int cpu;
+       char *out = buf, *end = buf + PAGE_SIZE;
+       int rw, i, cpu;
 
-       for_each_possible_cpu(cpu)
-               ret += *per_cpu_ptr(ca->sectors_written, cpu);
+       for (rw = 0; rw < 2; rw++) {
+               out += scnprintf(out, end - out, "%s:\n", bch2_rw[rw]);
 
-       return ret;
+               for (i = 1; i < BCH_DATA_NR; i++) {
+                       u64 n = 0;
+
+                       for_each_possible_cpu(cpu)
+                               n += per_cpu_ptr(ca->io_done, cpu)->sectors[rw][i];
+
+                       out += scnprintf(out, end - out, "%-12s:%12llu\n",
+                                        bch2_data_types[i], n << 9);
+               }
+       }
+
+       return out - buf;
 }
 
 SHOW(bch2_dev)
 {
        struct bch_dev *ca = container_of(kobj, struct bch_dev, kobj);
        struct bch_fs *c = ca->fs;
-       struct bch_dev_usage stats = bch2_dev_usage_read(ca);
+       char *out = buf, *end = buf + PAGE_SIZE;
 
        sysfs_printf(uuid,              "%pU\n", ca->uuid.b);
 
@@ -752,43 +808,37 @@ SHOW(bch2_dev)
        sysfs_print(first_bucket,       ca->mi.first_bucket);
        sysfs_print(nbuckets,           ca->mi.nbuckets);
        sysfs_print(discard,            ca->mi.discard);
-       sysfs_hprint(written, sectors_written(ca) << 9);
-       sysfs_hprint(btree_written,
-                    atomic64_read(&ca->btree_sectors_written) << 9);
-       sysfs_hprint(metadata_written,
-                    (atomic64_read(&ca->meta_sectors_written) +
-                     atomic64_read(&ca->btree_sectors_written)) << 9);
-
-       sysfs_hprint(dirty_data,        stats.sectors[S_DIRTY] << 9);
-       sysfs_print(dirty_bytes,        stats.sectors[S_DIRTY] << 9);
-       sysfs_print(dirty_buckets,      stats.buckets[S_DIRTY]);
-       sysfs_hprint(cached_data,       stats.sectors_cached << 9);
-       sysfs_print(cached_bytes,       stats.sectors_cached << 9);
-       sysfs_print(cached_buckets,     stats.buckets_cached);
-       sysfs_print(meta_buckets,       stats.buckets[S_META]);
-       sysfs_print(alloc_buckets,      stats.buckets_alloc);
-       sysfs_print(available_buckets,  dev_buckets_available(ca));
-       sysfs_print(free_buckets,       dev_buckets_free(ca));
-       sysfs_print(has_data,           bch2_dev_has_data(c, ca) &
-                   (1 << BCH_DATA_USER));
-       sysfs_print(has_metadata,       bch2_dev_has_data(c, ca) &
-                   ((1 << BCH_DATA_JOURNAL)|
-                    (1 << BCH_DATA_BTREE)));
-
-       sysfs_pd_controller_show(copy_gc, &ca->moving_gc_pd);
-
-       if (attr == &sysfs_cache_replacement_policy)
-               return bch2_snprint_string_list(buf, PAGE_SIZE,
-                                               bch2_cache_replacement_policies,
-                                               ca->mi.replacement);
+
+       if (attr == &sysfs_has_data) {
+               out += bch2_scnprint_flag_list(out, end - out,
+                                              bch2_data_types,
+                                              bch2_dev_has_data(c, ca));
+               out += scnprintf(out, end - out, "\n");
+               return out - buf;
+       }
+
+       sysfs_pd_controller_show(copy_gc, &ca->copygc_pd);
+
+       if (attr == &sysfs_cache_replacement_policy) {
+               out += bch2_scnprint_string_list(out, end - out,
+                                                bch2_cache_replacement_policies,
+                                                ca->mi.replacement);
+               out += scnprintf(out, end - out, "\n");
+               return out - buf;
+       }
 
        sysfs_print(tier,               ca->mi.tier);
 
-       if (attr == &sysfs_state_rw)
-               return bch2_snprint_string_list(buf, PAGE_SIZE,
-                                               bch2_dev_state,
-                                               ca->mi.state);
+       if (attr == &sysfs_state_rw) {
+               out += bch2_scnprint_string_list(out, end - out,
+                                                bch2_dev_state,
+                                                ca->mi.state);
+               out += scnprintf(out, end - out, "\n");
+               return out - buf;
+       }
 
+       if (attr == &sysfs_iostats)
+               return show_dev_iostats(ca, buf);
        if (attr == &sysfs_read_priority_stats)
                return show_quantiles(ca, buf, bucket_priority_fn, (void *) 0);
        if (attr == &sysfs_write_priority_stats)
@@ -811,7 +861,7 @@ STORE(bch2_dev)
        struct bch_fs *c = ca->fs;
        struct bch_member *mi;
 
-       sysfs_pd_controller_store(copy_gc, &ca->moving_gc_pd);
+       sysfs_pd_controller_store(copy_gc, &ca->copygc_pd);
 
        if (attr == &sysfs_discard) {
                bool v = strtoul_or_return(buf);
@@ -859,14 +909,17 @@ STORE(bch2_dev)
                SET_BCH_MEMBER_TIER(mi, v);
                bch2_write_super(c);
 
-               bch2_dev_group_remove(&c->tiers[prev_tier].devs, ca);
-               bch2_dev_group_add(&c->tiers[ca->mi.tier].devs, ca);
+               clear_bit(ca->dev_idx, c->tiers[prev_tier].devs.d);
+               set_bit(ca->dev_idx, c->tiers[ca->mi.tier].devs.d);
                mutex_unlock(&c->sb_lock);
 
                bch2_recalc_capacity(c);
                bch2_tiering_start(c);
        }
 
+       if (attr == &sysfs_wake_allocator)
+               bch2_wake_allocator(ca);
+
        return size;
 }
 SYSFS_OPS(bch2_dev);
@@ -885,26 +938,7 @@ struct attribute *bch2_dev_files[] = {
        &sysfs_state_rw,
 
        &sysfs_has_data,
-       &sysfs_has_metadata,
-
-       /* io stats: */
-       &sysfs_written,
-       &sysfs_btree_written,
-       &sysfs_metadata_written,
-
-       /* alloc info - data: */
-       &sysfs_dirty_data,
-       &sysfs_dirty_bytes,
-       &sysfs_cached_data,
-       &sysfs_cached_bytes,
-
-       /* alloc info - buckets: */
-       &sysfs_available_buckets,
-       &sysfs_free_buckets,
-       &sysfs_dirty_buckets,
-       &sysfs_cached_buckets,
-       &sysfs_meta_buckets,
-       &sysfs_alloc_buckets,
+       &sysfs_iostats,
 
        /* alloc info - other stats: */
        &sysfs_read_priority_stats,
@@ -915,7 +949,10 @@ struct attribute *bch2_dev_files[] = {
 
        /* debug: */
        &sysfs_alloc_debug,
+       &sysfs_wake_allocator,
 
        sysfs_pd_controller_files(copy_gc),
        NULL
 };
+
+#endif  /* _BCACHEFS_SYSFS_H_ */