]> git.sesse.net Git - bcachefs-tools-debian/blobdiff - libbcachefs/tests.c
Update bcachefs sources to 1a739db0b256 bcachefs; guard against overflow in btree...
[bcachefs-tools-debian] / libbcachefs / tests.c
index 43f974eb9b7e1fdd43b01066c85ee5da30075cbc..b3fe9fc577470ff14659df531959c9e7aa6c324b 100644 (file)
@@ -4,7 +4,7 @@
 #include "bcachefs.h"
 #include "btree_update.h"
 #include "journal_reclaim.h"
-#include "subvolume.h"
+#include "snapshot.h"
 #include "tests.h"
 
 #include "linux/kthread.h"
@@ -15,13 +15,14 @@ static void delete_test_keys(struct bch_fs *c)
        int ret;
 
        ret = bch2_btree_delete_range(c, BTREE_ID_extents,
-                                     SPOS(0, 0, U32_MAX), SPOS_MAX,
-                                     0,
-                                     NULL);
+                                     SPOS(0, 0, U32_MAX),
+                                     POS(0, U64_MAX),
+                                     0, NULL);
        BUG_ON(ret);
 
        ret = bch2_btree_delete_range(c, BTREE_ID_xattrs,
-                                     SPOS(0, 0, U32_MAX), SPOS_MAX,
+                                     SPOS(0, 0, U32_MAX),
+                                     POS(0, U64_MAX),
                                      0, NULL);
        BUG_ON(ret);
 }
@@ -30,7 +31,7 @@ static void delete_test_keys(struct bch_fs *c)
 
 static int test_delete(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        struct btree_iter iter;
        struct bkey_i_cookie k;
        int ret;
@@ -38,44 +39,40 @@ static int test_delete(struct bch_fs *c, u64 nr)
        bkey_cookie_init(&k.k_i);
        k.k.p.snapshot = U32_MAX;
 
-       bch2_trans_init(&trans, c, 0, 0);
-       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs, k.k.p,
+       bch2_trans_iter_init(trans, &iter, BTREE_ID_xattrs, k.k.p,
                             BTREE_ITER_INTENT);
 
-       ret = commit_do(&trans, NULL, NULL, 0,
+       ret = commit_do(trans, NULL, NULL, 0,
                bch2_btree_iter_traverse(&iter) ?:
-               bch2_trans_update(&trans, &iter, &k.k_i, 0));
-       if (ret) {
-               bch_err(c, "%s(): update error in: %s", __func__, bch2_err_str(ret));
+               bch2_trans_update(trans, &iter, &k.k_i, 0));
+       bch_err_msg(c, ret, "update error");
+       if (ret)
                goto err;
-       }
 
        pr_info("deleting once");
-       ret = commit_do(&trans, NULL, NULL, 0,
+       ret = commit_do(trans, NULL, NULL, 0,
                bch2_btree_iter_traverse(&iter) ?:
-               bch2_btree_delete_at(&trans, &iter, 0));
-       if (ret) {
-               bch_err(c, "%s(): delete error (first): %s", __func__, bch2_err_str(ret));
+               bch2_btree_delete_at(trans, &iter, 0));
+       bch_err_msg(c, ret, "delete error (first)");
+       if (ret)
                goto err;
-       }
 
        pr_info("deleting twice");
-       ret = commit_do(&trans, NULL, NULL, 0,
+       ret = commit_do(trans, NULL, NULL, 0,
                bch2_btree_iter_traverse(&iter) ?:
-               bch2_btree_delete_at(&trans, &iter, 0));
-       if (ret) {
-               bch_err(c, "%s(): delete error (second): %s", __func__, bch2_err_str(ret));
+               bch2_btree_delete_at(trans, &iter, 0));
+       bch_err_msg(c, ret, "delete error (second)");
+       if (ret)
                goto err;
-       }
 err:
-       bch2_trans_iter_exit(&trans, &iter);
-       bch2_trans_exit(&trans);
+       bch2_trans_iter_exit(trans, &iter);
+       bch2_trans_put(trans);
        return ret;
 }
 
 static int test_delete_written(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        struct btree_iter iter;
        struct bkey_i_cookie k;
        int ret;
@@ -83,312 +80,260 @@ static int test_delete_written(struct bch_fs *c, u64 nr)
        bkey_cookie_init(&k.k_i);
        k.k.p.snapshot = U32_MAX;
 
-       bch2_trans_init(&trans, c, 0, 0);
-
-       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs, k.k.p,
+       bch2_trans_iter_init(trans, &iter, BTREE_ID_xattrs, k.k.p,
                             BTREE_ITER_INTENT);
 
-       ret = commit_do(&trans, NULL, NULL, 0,
+       ret = commit_do(trans, NULL, NULL, 0,
                bch2_btree_iter_traverse(&iter) ?:
-               bch2_trans_update(&trans, &iter, &k.k_i, 0));
-       if (ret) {
-               bch_err(c, "%s(): update error: %s", __func__, bch2_err_str(ret));
+               bch2_trans_update(trans, &iter, &k.k_i, 0));
+       bch_err_msg(c, ret, "update error");
+       if (ret)
                goto err;
-       }
 
-       bch2_trans_unlock(&trans);
+       bch2_trans_unlock(trans);
        bch2_journal_flush_all_pins(&c->journal);
 
-       ret = commit_do(&trans, NULL, NULL, 0,
+       ret = commit_do(trans, NULL, NULL, 0,
                bch2_btree_iter_traverse(&iter) ?:
-               bch2_btree_delete_at(&trans, &iter, 0));
-       if (ret) {
-               bch_err(c, "%s(): delete error: %s", __func__, bch2_err_str(ret));
+               bch2_btree_delete_at(trans, &iter, 0));
+       bch_err_msg(c, ret, "delete error");
+       if (ret)
                goto err;
-       }
 err:
-       bch2_trans_iter_exit(&trans, &iter);
-       bch2_trans_exit(&trans);
+       bch2_trans_iter_exit(trans, &iter);
+       bch2_trans_put(trans);
        return ret;
 }
 
 static int test_iterate(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
-       struct btree_iter iter = { NULL };
-       struct bkey_s_c k;
        u64 i;
        int ret = 0;
 
-       bch2_trans_init(&trans, c, 0, 0);
-
        delete_test_keys(c);
 
        pr_info("inserting test keys");
 
        for (i = 0; i < nr; i++) {
-               struct bkey_i_cookie k;
+               struct bkey_i_cookie ck;
 
-               bkey_cookie_init(&k.k_i);
-               k.k.p.offset = i;
-               k.k.p.snapshot = U32_MAX;
+               bkey_cookie_init(&ck.k_i);
+               ck.k.p.offset = i;
+               ck.k.p.snapshot = U32_MAX;
 
-               ret = bch2_btree_insert(c, BTREE_ID_xattrs, &k.k_i,
-                                       NULL, NULL, 0);
-               if (ret) {
-                       bch_err(c, "%s(): insert error: %s", __func__, bch2_err_str(ret));
-                       goto err;
-               }
+               ret = bch2_btree_insert(c, BTREE_ID_xattrs, &ck.k_i, NULL, 0);
+               bch_err_msg(c, ret, "insert error");
+               if (ret)
+                       return ret;
        }
 
        pr_info("iterating forwards");
-
        i = 0;
 
-       ret = for_each_btree_key2(&trans, iter, BTREE_ID_xattrs,
-                                 SPOS(0, 0, U32_MAX), 0, k, ({
-               BUG_ON(k.k->p.offset != i++);
-               0;
-       }));
-       if (ret) {
-               bch_err(c, "%s(): error iterating forwards: %s", __func__, bch2_err_str(ret));
-               goto err;
-       }
+       ret = bch2_trans_run(c,
+               for_each_btree_key_upto(trans, iter, BTREE_ID_xattrs,
+                                       SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                       0, k, ({
+                       BUG_ON(k.k->p.offset != i++);
+                       0;
+               })));
+       bch_err_msg(c, ret, "error iterating forwards");
+       if (ret)
+               return ret;
 
        BUG_ON(i != nr);
 
        pr_info("iterating backwards");
 
-       ret = for_each_btree_key_reverse(&trans, iter, BTREE_ID_xattrs,
-                                        SPOS(0, U64_MAX, U32_MAX), 0, k,
-               ({
+       ret = bch2_trans_run(c,
+               for_each_btree_key_reverse(trans, iter, BTREE_ID_xattrs,
+                               SPOS(0, U64_MAX, U32_MAX), 0, k, ({
                        BUG_ON(k.k->p.offset != --i);
                        0;
-               }));
-       if (ret) {
-               bch_err(c, "%s(): error iterating backwards: %s", __func__, bch2_err_str(ret));
-               goto err;
-       }
+               })));
+       bch_err_msg(c, ret, "error iterating backwards");
+       if (ret)
+               return ret;
 
        BUG_ON(i);
-err:
-       bch2_trans_iter_exit(&trans, &iter);
-       bch2_trans_exit(&trans);
-       return ret;
+       return 0;
 }
 
 static int test_iterate_extents(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
-       struct btree_iter iter = { NULL };
-       struct bkey_s_c k;
        u64 i;
        int ret = 0;
 
-       bch2_trans_init(&trans, c, 0, 0);
-
        delete_test_keys(c);
 
        pr_info("inserting test extents");
 
        for (i = 0; i < nr; i += 8) {
-               struct bkey_i_cookie k;
+               struct bkey_i_cookie ck;
 
-               bkey_cookie_init(&k.k_i);
-               k.k.p.offset = i + 8;
-               k.k.p.snapshot = U32_MAX;
-               k.k.size = 8;
+               bkey_cookie_init(&ck.k_i);
+               ck.k.p.offset = i + 8;
+               ck.k.p.snapshot = U32_MAX;
+               ck.k.size = 8;
 
-               ret = bch2_btree_insert(c, BTREE_ID_extents, &k.k_i,
-                                       NULL, NULL, 0);
-               if (ret) {
-                       bch_err(c, "%s(): insert error: %s", __func__, bch2_err_str(ret));
-                       goto err;
-               }
+               ret = bch2_btree_insert(c, BTREE_ID_extents, &ck.k_i, NULL, 0);
+               bch_err_msg(c, ret, "insert error");
+               if (ret)
+                       return ret;
        }
 
        pr_info("iterating forwards");
-
        i = 0;
 
-       ret = for_each_btree_key2(&trans, iter, BTREE_ID_extents,
-                                 SPOS(0, 0, U32_MAX), 0, k, ({
-               BUG_ON(bkey_start_offset(k.k) != i);
-               i = k.k->p.offset;
-               0;
-       }));
-       if (ret) {
-               bch_err(c, "%s(): error iterating forwards: %s", __func__, bch2_err_str(ret));
-               goto err;
-       }
+       ret = bch2_trans_run(c,
+               for_each_btree_key_upto(trans, iter, BTREE_ID_extents,
+                                       SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                       0, k, ({
+                       BUG_ON(bkey_start_offset(k.k) != i);
+                       i = k.k->p.offset;
+                       0;
+               })));
+       bch_err_msg(c, ret, "error iterating forwards");
+       if (ret)
+               return ret;
 
        BUG_ON(i != nr);
 
        pr_info("iterating backwards");
 
-       ret = for_each_btree_key_reverse(&trans, iter, BTREE_ID_extents,
-                                        SPOS(0, U64_MAX, U32_MAX), 0, k,
-               ({
+       ret = bch2_trans_run(c,
+               for_each_btree_key_reverse(trans, iter, BTREE_ID_extents,
+                               SPOS(0, U64_MAX, U32_MAX), 0, k, ({
                        BUG_ON(k.k->p.offset != i);
                        i = bkey_start_offset(k.k);
                        0;
-               }));
-       if (ret) {
-               bch_err(c, "%s(): error iterating backwards: %s", __func__, bch2_err_str(ret));
-               goto err;
-       }
+               })));
+       bch_err_msg(c, ret, "error iterating backwards");
+       if (ret)
+               return ret;
 
        BUG_ON(i);
-err:
-       bch2_trans_iter_exit(&trans, &iter);
-       bch2_trans_exit(&trans);
-       return ret;
+       return 0;
 }
 
 static int test_iterate_slots(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
-       struct btree_iter iter = { NULL };
-       struct bkey_s_c k;
        u64 i;
        int ret = 0;
 
-       bch2_trans_init(&trans, c, 0, 0);
-
        delete_test_keys(c);
 
        pr_info("inserting test keys");
 
        for (i = 0; i < nr; i++) {
-               struct bkey_i_cookie k;
+               struct bkey_i_cookie ck;
 
-               bkey_cookie_init(&k.k_i);
-               k.k.p.offset = i * 2;
-               k.k.p.snapshot = U32_MAX;
+               bkey_cookie_init(&ck.k_i);
+               ck.k.p.offset = i * 2;
+               ck.k.p.snapshot = U32_MAX;
 
-               ret = bch2_btree_insert(c, BTREE_ID_xattrs, &k.k_i,
-                                       NULL, NULL, 0);
-               if (ret) {
-                       bch_err(c, "%s(): insert error: %s", __func__, bch2_err_str(ret));
-                       goto err;
-               }
+               ret = bch2_btree_insert(c, BTREE_ID_xattrs, &ck.k_i, NULL, 0);
+               bch_err_msg(c, ret, "insert error");
+               if (ret)
+                       return ret;
        }
 
        pr_info("iterating forwards");
-
        i = 0;
 
-       ret = for_each_btree_key2(&trans, iter, BTREE_ID_xattrs,
-                                 SPOS(0, 0, U32_MAX), 0, k, ({
-               BUG_ON(k.k->p.offset != i);
-               i += 2;
-               0;
-       }));
-       if (ret) {
-               bch_err(c, "%s(): error iterating forwards: %s", __func__, bch2_err_str(ret));
-               goto err;
-       }
+       ret = bch2_trans_run(c,
+               for_each_btree_key_upto(trans, iter, BTREE_ID_xattrs,
+                                         SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                         0, k, ({
+                       BUG_ON(k.k->p.offset != i);
+                       i += 2;
+                       0;
+               })));
+       bch_err_msg(c, ret, "error iterating forwards");
+       if (ret)
+               return ret;
 
        BUG_ON(i != nr * 2);
 
        pr_info("iterating forwards by slots");
-
        i = 0;
 
-       ret = for_each_btree_key2(&trans, iter, BTREE_ID_xattrs,
-                                 SPOS(0, 0, U32_MAX),
-                                 BTREE_ITER_SLOTS, k, ({
-               if (i >= nr * 2)
-                       break;
+       ret = bch2_trans_run(c,
+               for_each_btree_key_upto(trans, iter, BTREE_ID_xattrs,
+                                       SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                       BTREE_ITER_SLOTS, k, ({
+                       if (i >= nr * 2)
+                               break;
 
-               BUG_ON(k.k->p.offset != i);
-               BUG_ON(bkey_deleted(k.k) != (i & 1));
+                       BUG_ON(k.k->p.offset != i);
+                       BUG_ON(bkey_deleted(k.k) != (i & 1));
 
-               i++;
-               0;
-       }));
-       if (ret < 0) {
-               bch_err(c, "%s(): error iterating forwards by slots: %s", __func__, bch2_err_str(ret));
-               goto err;
-       }
-       ret = 0;
-err:
-       bch2_trans_exit(&trans);
+                       i++;
+                       0;
+               })));
+       bch_err_msg(c, ret, "error iterating forwards by slots");
        return ret;
 }
 
 static int test_iterate_slots_extents(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
-       struct btree_iter iter = { NULL };
-       struct bkey_s_c k;
        u64 i;
        int ret = 0;
 
-       bch2_trans_init(&trans, c, 0, 0);
-
        delete_test_keys(c);
 
        pr_info("inserting test keys");
 
        for (i = 0; i < nr; i += 16) {
-               struct bkey_i_cookie k;
+               struct bkey_i_cookie ck;
 
-               bkey_cookie_init(&k.k_i);
-               k.k.p.offset = i + 16;
-               k.k.p.snapshot = U32_MAX;
-               k.k.size = 8;
+               bkey_cookie_init(&ck.k_i);
+               ck.k.p.offset = i + 16;
+               ck.k.p.snapshot = U32_MAX;
+               ck.k.size = 8;
 
-               ret = bch2_btree_insert(c, BTREE_ID_extents, &k.k_i,
-                                       NULL, NULL, 0);
-               if (ret) {
-                       bch_err(c, "%s(): insert error: %s", __func__, bch2_err_str(ret));
-                       goto err;
-               }
+               ret = bch2_btree_insert(c, BTREE_ID_extents, &ck.k_i, NULL, 0);
+               bch_err_msg(c, ret, "insert error");
+               if (ret)
+                       return ret;
        }
 
        pr_info("iterating forwards");
-
        i = 0;
 
-       ret = for_each_btree_key2(&trans, iter, BTREE_ID_extents,
-                                 SPOS(0, 0, U32_MAX), 0, k, ({
-               BUG_ON(bkey_start_offset(k.k) != i + 8);
-               BUG_ON(k.k->size != 8);
-               i += 16;
-               0;
-       }));
-       if (ret) {
-               bch_err(c, "%s(): error iterating forwards: %s", __func__, bch2_err_str(ret));
-               goto err;
-       }
+       ret = bch2_trans_run(c,
+               for_each_btree_key_upto(trans, iter, BTREE_ID_extents,
+                                       SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                       0, k, ({
+                       BUG_ON(bkey_start_offset(k.k) != i + 8);
+                       BUG_ON(k.k->size != 8);
+                       i += 16;
+                       0;
+               })));
+       bch_err_msg(c, ret, "error iterating forwards");
+       if (ret)
+               return ret;
 
        BUG_ON(i != nr);
 
        pr_info("iterating forwards by slots");
-
        i = 0;
 
-       ret = for_each_btree_key2(&trans, iter, BTREE_ID_extents,
-                                SPOS(0, 0, U32_MAX),
-                                BTREE_ITER_SLOTS, k, ({
-               if (i == nr)
-                       break;
-               BUG_ON(bkey_deleted(k.k) != !(i % 16));
+       ret = bch2_trans_run(c,
+               for_each_btree_key_upto(trans, iter, BTREE_ID_extents,
+                                       SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                       BTREE_ITER_SLOTS, k, ({
+                       if (i == nr)
+                               break;
+                       BUG_ON(bkey_deleted(k.k) != !(i % 16));
 
-               BUG_ON(bkey_start_offset(k.k) != i);
-               BUG_ON(k.k->size != 8);
-               i = k.k->p.offset;
-               0;
-       }));
-       if (ret) {
-               bch_err(c, "%s(): error iterating forwards by slots: %s", __func__, bch2_err_str(ret));
-               goto err;
-       }
-       ret = 0;
-err:
-       bch2_trans_exit(&trans);
-       return 0;
+                       BUG_ON(bkey_start_offset(k.k) != i);
+                       BUG_ON(k.k->size != 8);
+                       i = k.k->p.offset;
+                       0;
+               })));
+       bch_err_msg(c, ret, "error iterating forwards by slots");
+       return ret;
 }
 
 /*
@@ -397,49 +342,47 @@ err:
  */
 static int test_peek_end(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        struct btree_iter iter;
        struct bkey_s_c k;
 
-       bch2_trans_init(&trans, c, 0, 0);
-       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs,
+       bch2_trans_iter_init(trans, &iter, BTREE_ID_xattrs,
                             SPOS(0, 0, U32_MAX), 0);
 
-       lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek(&iter)));
+       lockrestart_do(trans, bkey_err(k = bch2_btree_iter_peek_upto(&iter, POS(0, U64_MAX))));
        BUG_ON(k.k);
 
-       lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek(&iter)));
+       lockrestart_do(trans, bkey_err(k = bch2_btree_iter_peek_upto(&iter, POS(0, U64_MAX))));
        BUG_ON(k.k);
 
-       bch2_trans_iter_exit(&trans, &iter);
-       bch2_trans_exit(&trans);
+       bch2_trans_iter_exit(trans, &iter);
+       bch2_trans_put(trans);
        return 0;
 }
 
 static int test_peek_end_extents(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        struct btree_iter iter;
        struct bkey_s_c k;
 
-       bch2_trans_init(&trans, c, 0, 0);
-       bch2_trans_iter_init(&trans, &iter, BTREE_ID_extents,
+       bch2_trans_iter_init(trans, &iter, BTREE_ID_extents,
                             SPOS(0, 0, U32_MAX), 0);
 
-       lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek(&iter)));
+       lockrestart_do(trans, bkey_err(k = bch2_btree_iter_peek_upto(&iter, POS(0, U64_MAX))));
        BUG_ON(k.k);
 
-       lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek(&iter)));
+       lockrestart_do(trans, bkey_err(k = bch2_btree_iter_peek_upto(&iter, POS(0, U64_MAX))));
        BUG_ON(k.k);
 
-       bch2_trans_iter_exit(&trans, &iter);
-       bch2_trans_exit(&trans);
+       bch2_trans_iter_exit(trans, &iter);
+       bch2_trans_put(trans);
        return 0;
 }
 
 /* extent unit tests */
 
-u64 test_version;
+static u64 test_version;
 
 static int insert_test_extent(struct bch_fs *c,
                              u64 start, u64 end)
@@ -453,10 +396,8 @@ static int insert_test_extent(struct bch_fs *c,
        k.k_i.k.size = end - start;
        k.k_i.k.version.lo = test_version++;
 
-       ret = bch2_btree_insert(c, BTREE_ID_extents, &k.k_i,
-                               NULL, NULL, 0);
-       if (ret)
-               bch_err(c, "%s(): insert error: %s", __func__, bch2_err_str(ret));
+       ret = bch2_btree_insert(c, BTREE_ID_extents, &k.k_i, NULL, 0);
+       bch_err_fn(c, ret);
        return ret;
 }
 
@@ -498,12 +439,41 @@ static int test_extent_overwrite_all(struct bch_fs *c, u64 nr)
                __test_extent_overwrite(c, 32, 64, 32, 128);
 }
 
+static int insert_test_overlapping_extent(struct bch_fs *c, u64 inum, u64 start, u32 len, u32 snapid)
+{
+       struct bkey_i_cookie k;
+       int ret;
+
+       bkey_cookie_init(&k.k_i);
+       k.k_i.k.p.inode = inum;
+       k.k_i.k.p.offset = start + len;
+       k.k_i.k.p.snapshot = snapid;
+       k.k_i.k.size = len;
+
+       ret = bch2_trans_do(c, NULL, NULL, 0,
+               bch2_btree_insert_nonextent(trans, BTREE_ID_extents, &k.k_i,
+                                           BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE));
+       bch_err_fn(c, ret);
+       return ret;
+}
+
+static int test_extent_create_overlapping(struct bch_fs *c, u64 inum)
+{
+       return  insert_test_overlapping_extent(c, inum,  0, 16, U32_MAX - 2) ?: /* overwrite entire */
+               insert_test_overlapping_extent(c, inum,  2,  8, U32_MAX - 2) ?:
+               insert_test_overlapping_extent(c, inum,  4,  4, U32_MAX) ?:
+               insert_test_overlapping_extent(c, inum, 32,  8, U32_MAX - 2) ?: /* overwrite front/back */
+               insert_test_overlapping_extent(c, inum, 36,  8, U32_MAX) ?:
+               insert_test_overlapping_extent(c, inum, 60,  8, U32_MAX - 2) ?:
+               insert_test_overlapping_extent(c, inum, 64,  8, U32_MAX);
+}
+
 /* snapshot unit tests */
 
 /* Test skipping over keys in unrelated snapshots: */
 static int test_snapshot_filter(struct bch_fs *c, u32 snapid_lo, u32 snapid_hi)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans;
        struct btree_iter iter;
        struct bkey_s_c k;
        struct bkey_i_cookie cookie;
@@ -511,20 +481,19 @@ static int test_snapshot_filter(struct bch_fs *c, u32 snapid_lo, u32 snapid_hi)
 
        bkey_cookie_init(&cookie.k_i);
        cookie.k.p.snapshot = snapid_hi;
-       ret = bch2_btree_insert(c, BTREE_ID_xattrs, &cookie.k_i,
-                               NULL, NULL, 0);
+       ret = bch2_btree_insert(c, BTREE_ID_xattrs, &cookie.k_i, NULL, 0);
        if (ret)
                return ret;
 
-       bch2_trans_init(&trans, c, 0, 0);
-       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs,
+       trans = bch2_trans_get(c);
+       bch2_trans_iter_init(trans, &iter, BTREE_ID_xattrs,
                             SPOS(0, 0, snapid_lo), 0);
-       lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek(&iter)));
+       lockrestart_do(trans, bkey_err(k = bch2_btree_iter_peek_upto(&iter, POS(0, U64_MAX))));
 
        BUG_ON(k.k->p.snapshot != U32_MAX);
 
-       bch2_trans_iter_exit(&trans, &iter);
-       bch2_trans_exit(&trans);
+       bch2_trans_iter_exit(trans, &iter);
+       bch2_trans_put(trans);
        return ret;
 }
 
@@ -537,13 +506,12 @@ static int test_snapshots(struct bch_fs *c, u64 nr)
 
        bkey_cookie_init(&cookie.k_i);
        cookie.k.p.snapshot = U32_MAX;
-       ret = bch2_btree_insert(c, BTREE_ID_xattrs, &cookie.k_i,
-                               NULL, NULL, 0);
+       ret = bch2_btree_insert(c, BTREE_ID_xattrs, &cookie.k_i, NULL, 0);
        if (ret)
                return ret;
 
        ret = bch2_trans_do(c, NULL, NULL, 0,
-                     bch2_snapshot_node_create(&trans, U32_MAX,
+                     bch2_snapshot_node_create(trans, U32_MAX,
                                                snapids,
                                                snapid_subvols,
                                                2));
@@ -554,12 +522,8 @@ static int test_snapshots(struct bch_fs *c, u64 nr)
                swap(snapids[0], snapids[1]);
 
        ret = test_snapshot_filter(c, snapids[0], snapids[1]);
-       if (ret) {
-               bch_err(c, "%s(): err from test_snapshot_filter: %s", __func__, bch2_err_str(ret));
-               return ret;
-       }
-
-       return 0;
+       bch_err_msg(c, ret, "from test_snapshot_filter");
+       return ret;
 }
 
 /* perf tests */
@@ -568,46 +532,40 @@ static u64 test_rand(void)
 {
        u64 v;
 
-       prandom_bytes(&v, sizeof(v));
+       get_random_bytes(&v, sizeof(v));
        return v;
 }
 
 static int rand_insert(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        struct bkey_i_cookie k;
        int ret = 0;
        u64 i;
 
-       bch2_trans_init(&trans, c, 0, 0);
-
        for (i = 0; i < nr; i++) {
                bkey_cookie_init(&k.k_i);
                k.k.p.offset = test_rand();
                k.k.p.snapshot = U32_MAX;
 
-               ret = commit_do(&trans, NULL, NULL, 0,
-                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k.k_i));
-               if (ret) {
-                       bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
+               ret = commit_do(trans, NULL, NULL, 0,
+                       bch2_btree_insert_trans(trans, BTREE_ID_xattrs, &k.k_i, 0));
+               if (ret)
                        break;
-               }
        }
 
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
        return ret;
 }
 
 static int rand_insert_multi(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        struct bkey_i_cookie k[8];
        int ret = 0;
        unsigned j;
        u64 i;
 
-       bch2_trans_init(&trans, c, 0, 0);
-
        for (i = 0; i < nr; i += ARRAY_SIZE(k)) {
                for (j = 0; j < ARRAY_SIZE(k); j++) {
                        bkey_cookie_init(&k[j].k_i);
@@ -615,50 +573,45 @@ static int rand_insert_multi(struct bch_fs *c, u64 nr)
                        k[j].k.p.snapshot = U32_MAX;
                }
 
-               ret = commit_do(&trans, NULL, NULL, 0,
-                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[0].k_i) ?:
-                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[1].k_i) ?:
-                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[2].k_i) ?:
-                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[3].k_i) ?:
-                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[4].k_i) ?:
-                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[5].k_i) ?:
-                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[6].k_i) ?:
-                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[7].k_i));
-               if (ret) {
-                       bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
+               ret = commit_do(trans, NULL, NULL, 0,
+                       bch2_btree_insert_trans(trans, BTREE_ID_xattrs, &k[0].k_i, 0) ?:
+                       bch2_btree_insert_trans(trans, BTREE_ID_xattrs, &k[1].k_i, 0) ?:
+                       bch2_btree_insert_trans(trans, BTREE_ID_xattrs, &k[2].k_i, 0) ?:
+                       bch2_btree_insert_trans(trans, BTREE_ID_xattrs, &k[3].k_i, 0) ?:
+                       bch2_btree_insert_trans(trans, BTREE_ID_xattrs, &k[4].k_i, 0) ?:
+                       bch2_btree_insert_trans(trans, BTREE_ID_xattrs, &k[5].k_i, 0) ?:
+                       bch2_btree_insert_trans(trans, BTREE_ID_xattrs, &k[6].k_i, 0) ?:
+                       bch2_btree_insert_trans(trans, BTREE_ID_xattrs, &k[7].k_i, 0));
+               if (ret)
                        break;
-               }
        }
 
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
        return ret;
 }
 
 static int rand_lookup(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        struct btree_iter iter;
        struct bkey_s_c k;
        int ret = 0;
        u64 i;
 
-       bch2_trans_init(&trans, c, 0, 0);
-       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs,
+       bch2_trans_iter_init(trans, &iter, BTREE_ID_xattrs,
                             SPOS(0, 0, U32_MAX), 0);
 
        for (i = 0; i < nr; i++) {
                bch2_btree_iter_set_pos(&iter, SPOS(0, test_rand(), U32_MAX));
 
-               lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek(&iter)));
+               lockrestart_do(trans, bkey_err(k = bch2_btree_iter_peek(&iter)));
                ret = bkey_err(k);
-               if (ret) {
-                       bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
+               if (ret)
                        break;
-               }
        }
 
-       bch2_trans_iter_exit(&trans, &iter);
-       bch2_trans_exit(&trans);
+       bch2_trans_iter_exit(trans, &iter);
+       bch2_trans_put(trans);
        return ret;
 }
 
@@ -674,8 +627,7 @@ static int rand_mixed_trans(struct btree_trans *trans,
 
        k = bch2_btree_iter_peek(iter);
        ret = bkey_err(k);
-       if (ret && !bch2_err_matches(ret, BCH_ERR_transaction_restart))
-               bch_err(trans->c, "%s(): lookup error: %s", __func__, bch2_err_str(ret));
+       bch_err_msg(trans->c, ret, "lookup error");
        if (ret)
                return ret;
 
@@ -690,28 +642,25 @@ static int rand_mixed_trans(struct btree_trans *trans,
 
 static int rand_mixed(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        struct btree_iter iter;
        struct bkey_i_cookie cookie;
        int ret = 0;
        u64 i, rand;
 
-       bch2_trans_init(&trans, c, 0, 0);
-       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs,
+       bch2_trans_iter_init(trans, &iter, BTREE_ID_xattrs,
                             SPOS(0, 0, U32_MAX), 0);
 
        for (i = 0; i < nr; i++) {
                rand = test_rand();
-               ret = commit_do(&trans, NULL, NULL, 0,
-                       rand_mixed_trans(&trans, &iter, &cookie, i, rand));
-               if (ret) {
-                       bch_err(c, "%s(): update error: %s", __func__, bch2_err_str(ret));
+               ret = commit_do(trans, NULL, NULL, 0,
+                       rand_mixed_trans(trans, &iter, &cookie, i, rand));
+               if (ret)
                        break;
-               }
        }
 
-       bch2_trans_iter_exit(&trans, &iter);
-       bch2_trans_exit(&trans);
+       bch2_trans_iter_exit(trans, &iter);
+       bch2_trans_put(trans);
        return ret;
 }
 
@@ -723,7 +672,7 @@ static int __do_delete(struct btree_trans *trans, struct bpos pos)
 
        bch2_trans_iter_init(trans, &iter, BTREE_ID_xattrs, pos,
                             BTREE_ITER_INTENT);
-       lockrestart_do(trans, bkey_err(k = bch2_btree_iter_peek(&iter)));
+       k = bch2_btree_iter_peek(&iter);
        ret = bkey_err(k);
        if (ret)
                goto err;
@@ -739,111 +688,70 @@ err:
 
 static int rand_delete(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
+       struct btree_trans *trans = bch2_trans_get(c);
        int ret = 0;
        u64 i;
 
-       bch2_trans_init(&trans, c, 0, 0);
-
        for (i = 0; i < nr; i++) {
                struct bpos pos = SPOS(0, test_rand(), U32_MAX);
 
-               ret = commit_do(&trans, NULL, NULL, 0,
-                       __do_delete(&trans, pos));
-               if (ret) {
-                       bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
+               ret = commit_do(trans, NULL, NULL, 0,
+                       __do_delete(trans, pos));
+               if (ret)
                        break;
-               }
        }
 
-       bch2_trans_exit(&trans);
+       bch2_trans_put(trans);
        return ret;
 }
 
 static int seq_insert(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
-       struct btree_iter iter;
-       struct bkey_s_c k;
        struct bkey_i_cookie insert;
-       int ret = 0;
 
        bkey_cookie_init(&insert.k_i);
 
-       bch2_trans_init(&trans, c, 0, 0);
-
-       ret = for_each_btree_key_commit(&trans, iter, BTREE_ID_xattrs,
+       return bch2_trans_run(c,
+               for_each_btree_key_commit(trans, iter, BTREE_ID_xattrs,
                                        SPOS(0, 0, U32_MAX),
                                        BTREE_ITER_SLOTS|BTREE_ITER_INTENT, k,
-                                       NULL, NULL, 0,
-               ({
+                                       NULL, NULL, 0, ({
                        if (iter.pos.offset >= nr)
                                break;
                        insert.k.p = iter.pos;
-                       bch2_trans_update(&trans, &iter, &insert.k_i, 0);
-               }));
-       if (ret)
-               bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
-
-       bch2_trans_exit(&trans);
-       return ret;
+                       bch2_trans_update(trans, &iter, &insert.k_i, 0);
+               })));
 }
 
 static int seq_lookup(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
-       struct btree_iter iter;
-       struct bkey_s_c k;
-       int ret = 0;
-
-       bch2_trans_init(&trans, c, 0, 0);
-
-       ret = for_each_btree_key2(&trans, iter, BTREE_ID_xattrs,
-                                 SPOS(0, 0, U32_MAX), 0, k,
-               0);
-       if (ret)
-               bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
-
-       bch2_trans_exit(&trans);
-       return ret;
+       return bch2_trans_run(c,
+               for_each_btree_key_upto(trans, iter, BTREE_ID_xattrs,
+                                 SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                 0, k,
+               0));
 }
 
 static int seq_overwrite(struct bch_fs *c, u64 nr)
 {
-       struct btree_trans trans;
-       struct btree_iter iter;
-       struct bkey_s_c k;
-       int ret = 0;
-
-       bch2_trans_init(&trans, c, 0, 0);
-
-       ret = for_each_btree_key_commit(&trans, iter, BTREE_ID_xattrs,
+       return bch2_trans_run(c,
+               for_each_btree_key_commit(trans, iter, BTREE_ID_xattrs,
                                        SPOS(0, 0, U32_MAX),
                                        BTREE_ITER_INTENT, k,
-                                       NULL, NULL, 0,
-               ({
+                                       NULL, NULL, 0, ({
                        struct bkey_i_cookie u;
 
                        bkey_reassemble(&u.k_i, k);
-                       bch2_trans_update(&trans, &iter, &u.k_i, 0);
-               }));
-       if (ret)
-               bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
-
-       bch2_trans_exit(&trans);
-       return ret;
+                       bch2_trans_update(trans, &iter, &u.k_i, 0);
+               })));
 }
 
 static int seq_delete(struct bch_fs *c, u64 nr)
 {
-       int ret;
-
-       ret = bch2_btree_delete_range(c, BTREE_ID_xattrs,
-                                     SPOS(0, 0, U32_MAX), SPOS_MAX,
+       return bch2_btree_delete_range(c, BTREE_ID_xattrs,
+                                     SPOS(0, 0, U32_MAX),
+                                     POS(0, U64_MAX),
                                      0, NULL);
-       if (ret)
-               bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
-       return ret;
 }
 
 typedef int (*perf_test_fn)(struct bch_fs *, u64);
@@ -935,6 +843,7 @@ int bch2_btree_perf_test(struct bch_fs *c, const char *testname,
        perf_test(test_extent_overwrite_back);
        perf_test(test_extent_overwrite_middle);
        perf_test(test_extent_overwrite_all);
+       perf_test(test_extent_create_overlapping);
 
        perf_test(test_snapshots);