]> git.sesse.net Git - bcachefs-tools-debian/blobdiff - libbcachefs/tests.c
Update bcachefs sources to 3856459b1b bcachefs: bch2_btree_iter_peek_node_and_restart()
[bcachefs-tools-debian] / libbcachefs / tests.c
index c9362af5651184c14deebb9134aa54540d4c9b8f..d352821d5614005aee064052fe841a6c87a64189 100644 (file)
@@ -1,8 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0
 #ifdef CONFIG_BCACHEFS_TESTS
 
 #include "bcachefs.h"
 #include "btree_update.h"
 #include "journal_reclaim.h"
+#include "subvolume.h"
 #include "tests.h"
 
 #include "linux/kthread.h"
@@ -12,86 +14,114 @@ static void delete_test_keys(struct bch_fs *c)
 {
        int ret;
 
-       ret = bch2_btree_delete_range(c, BTREE_ID_EXTENTS,
-                                     POS(0, 0), POS(0, U64_MAX),
-                                     NULL);
+       ret = bch2_btree_delete_range(c, BTREE_ID_extents,
+                                     SPOS(0, 0, U32_MAX),
+                                     POS(0, U64_MAX),
+                                     0, NULL);
        BUG_ON(ret);
 
-       ret = bch2_btree_delete_range(c, BTREE_ID_DIRENTS,
-                                     POS(0, 0), POS(0, U64_MAX),
-                                     NULL);
+       ret = bch2_btree_delete_range(c, BTREE_ID_xattrs,
+                                     SPOS(0, 0, U32_MAX),
+                                     POS(0, U64_MAX),
+                                     0, NULL);
        BUG_ON(ret);
 }
 
 /* unit tests */
 
-static void test_delete(struct bch_fs *c, u64 nr)
+static int test_delete(struct bch_fs *c, u64 nr)
 {
        struct btree_trans trans;
-       struct btree_iter *iter;
+       struct btree_iter iter;
        struct bkey_i_cookie k;
        int ret;
 
        bkey_cookie_init(&k.k_i);
-
-       bch2_trans_init(&trans, c);
-
-       iter = bch2_trans_get_iter(&trans, BTREE_ID_DIRENTS, k.k.p,
-                                  BTREE_ITER_INTENT);
-
-       ret = bch2_btree_iter_traverse(iter);
-       BUG_ON(ret);
-
-       bch2_trans_update(&trans, BTREE_INSERT_ENTRY(iter, &k.k_i));
-       ret = bch2_trans_commit(&trans, NULL, NULL, 0);
-       BUG_ON(ret);
+       k.k.p.snapshot = U32_MAX;
+
+       bch2_trans_init(&trans, c, 0, 0);
+       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs, k.k.p,
+                            BTREE_ITER_INTENT);
+
+       ret = commit_do(&trans, NULL, NULL, 0,
+               bch2_btree_iter_traverse(&iter) ?:
+               bch2_trans_update(&trans, &iter, &k.k_i, 0));
+       if (ret) {
+               bch_err(c, "%s(): update error in: %s", __func__, bch2_err_str(ret));
+               goto err;
+       }
 
        pr_info("deleting once");
-       ret = bch2_btree_delete_at(&trans, iter, 0);
-       BUG_ON(ret);
+       ret = commit_do(&trans, NULL, NULL, 0,
+               bch2_btree_iter_traverse(&iter) ?:
+               bch2_btree_delete_at(&trans, &iter, 0));
+       if (ret) {
+               bch_err(c, "%s(): delete error (first): %s", __func__, bch2_err_str(ret));
+               goto err;
+       }
 
        pr_info("deleting twice");
-       ret = bch2_btree_delete_at(&trans, iter, 0);
-       BUG_ON(ret);
-
+       ret = commit_do(&trans, NULL, NULL, 0,
+               bch2_btree_iter_traverse(&iter) ?:
+               bch2_btree_delete_at(&trans, &iter, 0));
+       if (ret) {
+               bch_err(c, "%s(): delete error (second): %s", __func__, bch2_err_str(ret));
+               goto err;
+       }
+err:
+       bch2_trans_iter_exit(&trans, &iter);
        bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void test_delete_written(struct bch_fs *c, u64 nr)
+static int test_delete_written(struct bch_fs *c, u64 nr)
 {
        struct btree_trans trans;
-       struct btree_iter *iter;
+       struct btree_iter iter;
        struct bkey_i_cookie k;
        int ret;
 
        bkey_cookie_init(&k.k_i);
+       k.k.p.snapshot = U32_MAX;
 
-       bch2_trans_init(&trans, c);
+       bch2_trans_init(&trans, c, 0, 0);
 
-       iter = bch2_trans_get_iter(&trans, BTREE_ID_DIRENTS, k.k.p,
-                                  BTREE_ITER_INTENT);
-
-       ret = bch2_btree_iter_traverse(iter);
-       BUG_ON(ret);
+       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs, k.k.p,
+                            BTREE_ITER_INTENT);
 
-       bch2_trans_update(&trans, BTREE_INSERT_ENTRY(iter, &k.k_i));
-       ret = bch2_trans_commit(&trans, NULL, NULL, 0);
-       BUG_ON(ret);
+       ret = commit_do(&trans, NULL, NULL, 0,
+               bch2_btree_iter_traverse(&iter) ?:
+               bch2_trans_update(&trans, &iter, &k.k_i, 0));
+       if (ret) {
+               bch_err(c, "%s(): update error: %s", __func__, bch2_err_str(ret));
+               goto err;
+       }
 
+       bch2_trans_unlock(&trans);
        bch2_journal_flush_all_pins(&c->journal);
 
-       ret = bch2_btree_delete_at(&trans, iter, 0);
-       BUG_ON(ret);
-
+       ret = commit_do(&trans, NULL, NULL, 0,
+               bch2_btree_iter_traverse(&iter) ?:
+               bch2_btree_delete_at(&trans, &iter, 0));
+       if (ret) {
+               bch_err(c, "%s(): delete error: %s", __func__, bch2_err_str(ret));
+               goto err;
+       }
+err:
+       bch2_trans_iter_exit(&trans, &iter);
        bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void test_iterate(struct bch_fs *c, u64 nr)
+static int test_iterate(struct bch_fs *c, u64 nr)
 {
-       struct btree_iter iter;
+       struct btree_trans trans;
+       struct btree_iter iter = { NULL };
        struct bkey_s_c k;
        u64 i;
-       int ret;
+       int ret = 0;
+
+       bch2_trans_init(&trans, c, 0, 0);
 
        delete_test_keys(c);
 
@@ -102,37 +132,62 @@ static void test_iterate(struct bch_fs *c, u64 nr)
 
                bkey_cookie_init(&k.k_i);
                k.k.p.offset = i;
+               k.k.p.snapshot = U32_MAX;
 
-               ret = bch2_btree_insert(c, BTREE_ID_DIRENTS, &k.k_i,
+               ret = bch2_btree_insert(c, BTREE_ID_xattrs, &k.k_i,
                                        NULL, NULL, 0);
-               BUG_ON(ret);
+               if (ret) {
+                       bch_err(c, "%s(): insert error: %s", __func__, bch2_err_str(ret));
+                       goto err;
+               }
        }
 
        pr_info("iterating forwards");
 
        i = 0;
 
-       for_each_btree_key(&iter, c, BTREE_ID_DIRENTS, POS(0, 0), 0, k)
+       ret = for_each_btree_key2_upto(&trans, iter, BTREE_ID_xattrs,
+                                 SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                 0, k, ({
                BUG_ON(k.k->p.offset != i++);
-       bch2_btree_iter_unlock(&iter);
+               0;
+       }));
+       if (ret) {
+               bch_err(c, "%s(): error iterating forwards: %s", __func__, bch2_err_str(ret));
+               goto err;
+       }
 
        BUG_ON(i != nr);
 
        pr_info("iterating backwards");
 
-       while (!IS_ERR_OR_NULL((k = bch2_btree_iter_prev(&iter)).k))
-               BUG_ON(k.k->p.offset != --i);
-       bch2_btree_iter_unlock(&iter);
+       ret = for_each_btree_key_reverse(&trans, iter, BTREE_ID_xattrs,
+                                        SPOS(0, U64_MAX, U32_MAX), 0, k,
+               ({
+                       BUG_ON(k.k->p.offset != --i);
+                       0;
+               }));
+       if (ret) {
+               bch_err(c, "%s(): error iterating backwards: %s", __func__, bch2_err_str(ret));
+               goto err;
+       }
 
        BUG_ON(i);
+err:
+       bch2_trans_iter_exit(&trans, &iter);
+       bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void test_iterate_extents(struct bch_fs *c, u64 nr)
+static int test_iterate_extents(struct bch_fs *c, u64 nr)
 {
-       struct btree_iter iter;
+       struct btree_trans trans;
+       struct btree_iter iter = { NULL };
        struct bkey_s_c k;
        u64 i;
-       int ret;
+       int ret = 0;
+
+       bch2_trans_init(&trans, c, 0, 0);
 
        delete_test_keys(c);
 
@@ -143,42 +198,65 @@ static void test_iterate_extents(struct bch_fs *c, u64 nr)
 
                bkey_cookie_init(&k.k_i);
                k.k.p.offset = i + 8;
+               k.k.p.snapshot = U32_MAX;
                k.k.size = 8;
 
-               ret = bch2_btree_insert(c, BTREE_ID_EXTENTS, &k.k_i,
+               ret = bch2_btree_insert(c, BTREE_ID_extents, &k.k_i,
                                        NULL, NULL, 0);
-               BUG_ON(ret);
+               if (ret) {
+                       bch_err(c, "%s(): insert error: %s", __func__, bch2_err_str(ret));
+                       goto err;
+               }
        }
 
        pr_info("iterating forwards");
 
        i = 0;
 
-       for_each_btree_key(&iter, c, BTREE_ID_EXTENTS, POS(0, 0), 0, k) {
+       ret = for_each_btree_key2_upto(&trans, iter, BTREE_ID_extents,
+                                 SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                 0, k, ({
                BUG_ON(bkey_start_offset(k.k) != i);
                i = k.k->p.offset;
+               0;
+       }));
+       if (ret) {
+               bch_err(c, "%s(): error iterating forwards: %s", __func__, bch2_err_str(ret));
+               goto err;
        }
-       bch2_btree_iter_unlock(&iter);
 
        BUG_ON(i != nr);
 
        pr_info("iterating backwards");
 
-       while (!IS_ERR_OR_NULL((k = bch2_btree_iter_prev(&iter)).k)) {
-               BUG_ON(k.k->p.offset != i);
-               i = bkey_start_offset(k.k);
+       ret = for_each_btree_key_reverse(&trans, iter, BTREE_ID_extents,
+                                        SPOS(0, U64_MAX, U32_MAX), 0, k,
+               ({
+                       BUG_ON(k.k->p.offset != i);
+                       i = bkey_start_offset(k.k);
+                       0;
+               }));
+       if (ret) {
+               bch_err(c, "%s(): error iterating backwards: %s", __func__, bch2_err_str(ret));
+               goto err;
        }
-       bch2_btree_iter_unlock(&iter);
 
        BUG_ON(i);
+err:
+       bch2_trans_iter_exit(&trans, &iter);
+       bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void test_iterate_slots(struct bch_fs *c, u64 nr)
+static int test_iterate_slots(struct bch_fs *c, u64 nr)
 {
-       struct btree_iter iter;
+       struct btree_trans trans;
+       struct btree_iter iter = { NULL };
        struct bkey_s_c k;
        u64 i;
-       int ret;
+       int ret = 0;
+
+       bch2_trans_init(&trans, c, 0, 0);
 
        delete_test_keys(c);
 
@@ -189,21 +267,31 @@ static void test_iterate_slots(struct bch_fs *c, u64 nr)
 
                bkey_cookie_init(&k.k_i);
                k.k.p.offset = i * 2;
+               k.k.p.snapshot = U32_MAX;
 
-               ret = bch2_btree_insert(c, BTREE_ID_DIRENTS, &k.k_i,
+               ret = bch2_btree_insert(c, BTREE_ID_xattrs, &k.k_i,
                                        NULL, NULL, 0);
-               BUG_ON(ret);
+               if (ret) {
+                       bch_err(c, "%s(): insert error: %s", __func__, bch2_err_str(ret));
+                       goto err;
+               }
        }
 
        pr_info("iterating forwards");
 
        i = 0;
 
-       for_each_btree_key(&iter, c, BTREE_ID_DIRENTS, POS(0, 0), 0, k) {
+       ret = for_each_btree_key2_upto(&trans, iter, BTREE_ID_xattrs,
+                                 SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                 0, k, ({
                BUG_ON(k.k->p.offset != i);
                i += 2;
+               0;
+       }));
+       if (ret) {
+               bch_err(c, "%s(): error iterating forwards: %s", __func__, bch2_err_str(ret));
+               goto err;
        }
-       bch2_btree_iter_unlock(&iter);
 
        BUG_ON(i != nr * 2);
 
@@ -211,23 +299,37 @@ static void test_iterate_slots(struct bch_fs *c, u64 nr)
 
        i = 0;
 
-       for_each_btree_key(&iter, c, BTREE_ID_DIRENTS, POS(0, 0),
-                          BTREE_ITER_SLOTS, k) {
+       ret = for_each_btree_key2_upto(&trans, iter, BTREE_ID_xattrs,
+                                 SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                 BTREE_ITER_SLOTS, k, ({
+               if (i >= nr * 2)
+                       break;
+
+               BUG_ON(k.k->p.offset != i);
                BUG_ON(bkey_deleted(k.k) != (i & 1));
-               BUG_ON(k.k->p.offset != i++);
 
-               if (i == nr * 2)
-                       break;
+               i++;
+               0;
+       }));
+       if (ret < 0) {
+               bch_err(c, "%s(): error iterating forwards by slots: %s", __func__, bch2_err_str(ret));
+               goto err;
        }
-       bch2_btree_iter_unlock(&iter);
+       ret = 0;
+err:
+       bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void test_iterate_slots_extents(struct bch_fs *c, u64 nr)
+static int test_iterate_slots_extents(struct bch_fs *c, u64 nr)
 {
-       struct btree_iter iter;
+       struct btree_trans trans;
+       struct btree_iter iter = { NULL };
        struct bkey_s_c k;
        u64 i;
-       int ret;
+       int ret = 0;
+
+       bch2_trans_init(&trans, c, 0, 0);
 
        delete_test_keys(c);
 
@@ -238,23 +340,33 @@ static void test_iterate_slots_extents(struct bch_fs *c, u64 nr)
 
                bkey_cookie_init(&k.k_i);
                k.k.p.offset = i + 16;
+               k.k.p.snapshot = U32_MAX;
                k.k.size = 8;
 
-               ret = bch2_btree_insert(c, BTREE_ID_EXTENTS, &k.k_i,
+               ret = bch2_btree_insert(c, BTREE_ID_extents, &k.k_i,
                                        NULL, NULL, 0);
-               BUG_ON(ret);
+               if (ret) {
+                       bch_err(c, "%s(): insert error: %s", __func__, bch2_err_str(ret));
+                       goto err;
+               }
        }
 
        pr_info("iterating forwards");
 
        i = 0;
 
-       for_each_btree_key(&iter, c, BTREE_ID_EXTENTS, POS(0, 0), 0, k) {
+       ret = for_each_btree_key2_upto(&trans, iter, BTREE_ID_extents,
+                                 SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                 0, k, ({
                BUG_ON(bkey_start_offset(k.k) != i + 8);
                BUG_ON(k.k->size != 8);
                i += 16;
+               0;
+       }));
+       if (ret) {
+               bch_err(c, "%s(): error iterating forwards: %s", __func__, bch2_err_str(ret));
+               goto err;
        }
-       bch2_btree_iter_unlock(&iter);
 
        BUG_ON(i != nr);
 
@@ -262,111 +374,197 @@ static void test_iterate_slots_extents(struct bch_fs *c, u64 nr)
 
        i = 0;
 
-       for_each_btree_key(&iter, c, BTREE_ID_EXTENTS, POS(0, 0),
-                          BTREE_ITER_SLOTS, k) {
+       ret = for_each_btree_key2_upto(&trans, iter, BTREE_ID_extents,
+                                SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                BTREE_ITER_SLOTS, k, ({
+               if (i == nr)
+                       break;
                BUG_ON(bkey_deleted(k.k) != !(i % 16));
 
                BUG_ON(bkey_start_offset(k.k) != i);
                BUG_ON(k.k->size != 8);
                i = k.k->p.offset;
-
-               if (i == nr)
-                       break;
+               0;
+       }));
+       if (ret) {
+               bch_err(c, "%s(): error iterating forwards by slots: %s", __func__, bch2_err_str(ret));
+               goto err;
        }
-       bch2_btree_iter_unlock(&iter);
+       ret = 0;
+err:
+       bch2_trans_exit(&trans);
+       return 0;
 }
 
 /*
  * XXX: we really want to make sure we've got a btree with depth > 0 for these
  * tests
  */
-static void test_peek_end(struct bch_fs *c, u64 nr)
+static int test_peek_end(struct bch_fs *c, u64 nr)
 {
+       struct btree_trans trans;
        struct btree_iter iter;
        struct bkey_s_c k;
 
-       bch2_btree_iter_init(&iter, c, BTREE_ID_DIRENTS, POS_MIN, 0);
+       bch2_trans_init(&trans, c, 0, 0);
+       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs,
+                            SPOS(0, 0, U32_MAX), 0);
 
-       k = bch2_btree_iter_peek(&iter);
+       lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek_upto(&iter, POS(0, U64_MAX))));
        BUG_ON(k.k);
 
-       k = bch2_btree_iter_peek(&iter);
+       lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek_upto(&iter, POS(0, U64_MAX))));
        BUG_ON(k.k);
 
-       bch2_btree_iter_unlock(&iter);
+       bch2_trans_iter_exit(&trans, &iter);
+       bch2_trans_exit(&trans);
+       return 0;
 }
 
-static void test_peek_end_extents(struct bch_fs *c, u64 nr)
+static int test_peek_end_extents(struct bch_fs *c, u64 nr)
 {
+       struct btree_trans trans;
        struct btree_iter iter;
        struct bkey_s_c k;
 
-       bch2_btree_iter_init(&iter, c, BTREE_ID_EXTENTS, POS_MIN, 0);
+       bch2_trans_init(&trans, c, 0, 0);
+       bch2_trans_iter_init(&trans, &iter, BTREE_ID_extents,
+                            SPOS(0, 0, U32_MAX), 0);
 
-       k = bch2_btree_iter_peek(&iter);
+       lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek_upto(&iter, POS(0, U64_MAX))));
        BUG_ON(k.k);
 
-       k = bch2_btree_iter_peek(&iter);
+       lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek_upto(&iter, POS(0, U64_MAX))));
        BUG_ON(k.k);
 
-       bch2_btree_iter_unlock(&iter);
+       bch2_trans_iter_exit(&trans, &iter);
+       bch2_trans_exit(&trans);
+       return 0;
 }
 
 /* extent unit tests */
 
 u64 test_version;
 
-static void insert_test_extent(struct bch_fs *c,
-                              u64 start, u64 end)
+static int insert_test_extent(struct bch_fs *c,
+                             u64 start, u64 end)
 {
        struct bkey_i_cookie k;
        int ret;
 
-       //pr_info("inserting %llu-%llu v %llu", start, end, test_version);
-
        bkey_cookie_init(&k.k_i);
        k.k_i.k.p.offset = end;
+       k.k_i.k.p.snapshot = U32_MAX;
        k.k_i.k.size = end - start;
        k.k_i.k.version.lo = test_version++;
 
-       ret = bch2_btree_insert(c, BTREE_ID_EXTENTS, &k.k_i,
+       ret = bch2_btree_insert(c, BTREE_ID_extents, &k.k_i,
                                NULL, NULL, 0);
-       BUG_ON(ret);
+       if (ret)
+               bch_err(c, "%s(): insert error: %s", __func__, bch2_err_str(ret));
+       return ret;
 }
 
-static void __test_extent_overwrite(struct bch_fs *c,
+static int __test_extent_overwrite(struct bch_fs *c,
                                    u64 e1_start, u64 e1_end,
                                    u64 e2_start, u64 e2_end)
 {
-       insert_test_extent(c, e1_start, e1_end);
-       insert_test_extent(c, e2_start, e2_end);
+       int ret;
+
+       ret   = insert_test_extent(c, e1_start, e1_end) ?:
+               insert_test_extent(c, e2_start, e2_end);
 
        delete_test_keys(c);
+       return ret;
 }
 
-static void test_extent_overwrite_front(struct bch_fs *c, u64 nr)
+static int test_extent_overwrite_front(struct bch_fs *c, u64 nr)
 {
-       __test_extent_overwrite(c, 0, 64, 0, 32);
-       __test_extent_overwrite(c, 8, 64, 0, 32);
+       return  __test_extent_overwrite(c, 0, 64, 0, 32) ?:
+               __test_extent_overwrite(c, 8, 64, 0, 32);
 }
 
-static void test_extent_overwrite_back(struct bch_fs *c, u64 nr)
+static int test_extent_overwrite_back(struct bch_fs *c, u64 nr)
 {
-       __test_extent_overwrite(c, 0, 64, 32, 64);
-       __test_extent_overwrite(c, 0, 64, 32, 72);
+       return  __test_extent_overwrite(c, 0, 64, 32, 64) ?:
+               __test_extent_overwrite(c, 0, 64, 32, 72);
 }
 
-static void test_extent_overwrite_middle(struct bch_fs *c, u64 nr)
+static int test_extent_overwrite_middle(struct bch_fs *c, u64 nr)
 {
-       __test_extent_overwrite(c, 0, 64, 32, 40);
+       return __test_extent_overwrite(c, 0, 64, 32, 40);
+}
+
+static int test_extent_overwrite_all(struct bch_fs *c, u64 nr)
+{
+       return  __test_extent_overwrite(c, 32, 64,  0,  64) ?:
+               __test_extent_overwrite(c, 32, 64,  0, 128) ?:
+               __test_extent_overwrite(c, 32, 64, 32,  64) ?:
+               __test_extent_overwrite(c, 32, 64, 32, 128);
+}
+
+/* snapshot unit tests */
+
+/* Test skipping over keys in unrelated snapshots: */
+static int test_snapshot_filter(struct bch_fs *c, u32 snapid_lo, u32 snapid_hi)
+{
+       struct btree_trans trans;
+       struct btree_iter iter;
+       struct bkey_s_c k;
+       struct bkey_i_cookie cookie;
+       int ret;
+
+       bkey_cookie_init(&cookie.k_i);
+       cookie.k.p.snapshot = snapid_hi;
+       ret = bch2_btree_insert(c, BTREE_ID_xattrs, &cookie.k_i,
+                               NULL, NULL, 0);
+       if (ret)
+               return ret;
+
+       bch2_trans_init(&trans, c, 0, 0);
+       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs,
+                            SPOS(0, 0, snapid_lo), 0);
+       lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek_upto(&iter, POS(0, U64_MAX))));
+
+       BUG_ON(k.k->p.snapshot != U32_MAX);
+
+       bch2_trans_iter_exit(&trans, &iter);
+       bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void test_extent_overwrite_all(struct bch_fs *c, u64 nr)
+static int test_snapshots(struct bch_fs *c, u64 nr)
 {
-       __test_extent_overwrite(c, 32, 64,  0,  64);
-       __test_extent_overwrite(c, 32, 64,  0, 128);
-       __test_extent_overwrite(c, 32, 64, 32,  64);
-       __test_extent_overwrite(c, 32, 64, 32, 128);
+       struct bkey_i_cookie cookie;
+       u32 snapids[2];
+       u32 snapid_subvols[2] = { 1, 1 };
+       int ret;
+
+       bkey_cookie_init(&cookie.k_i);
+       cookie.k.p.snapshot = U32_MAX;
+       ret = bch2_btree_insert(c, BTREE_ID_xattrs, &cookie.k_i,
+                               NULL, NULL, 0);
+       if (ret)
+               return ret;
+
+       ret = bch2_trans_do(c, NULL, NULL, 0,
+                     bch2_snapshot_node_create(&trans, U32_MAX,
+                                               snapids,
+                                               snapid_subvols,
+                                               2));
+       if (ret)
+               return ret;
+
+       if (snapids[0] > snapids[1])
+               swap(snapids[0], snapids[1]);
+
+       ret = test_snapshot_filter(c, snapids[0], snapids[1]);
+       if (ret) {
+               bch_err(c, "%s(): err from test_snapshot_filter: %s", __func__, bch2_err_str(ret));
+               return ret;
+       }
+
+       return 0;
 }
 
 /* perf tests */
@@ -374,169 +572,288 @@ static void test_extent_overwrite_all(struct bch_fs *c, u64 nr)
 static u64 test_rand(void)
 {
        u64 v;
-#if 0
-       v = prandom_u32();
-#else
-       prandom_bytes(&v, sizeof(v));
-#endif
+
+       get_random_bytes(&v, sizeof(v));
        return v;
 }
 
-static void rand_insert(struct bch_fs *c, u64 nr)
+static int rand_insert(struct bch_fs *c, u64 nr)
 {
+       struct btree_trans trans;
        struct bkey_i_cookie k;
-       int ret;
+       int ret = 0;
        u64 i;
 
+       bch2_trans_init(&trans, c, 0, 0);
+
        for (i = 0; i < nr; i++) {
                bkey_cookie_init(&k.k_i);
                k.k.p.offset = test_rand();
+               k.k.p.snapshot = U32_MAX;
 
-               ret = bch2_btree_insert(c, BTREE_ID_DIRENTS, &k.k_i,
-                                       NULL, NULL, 0);
-               BUG_ON(ret);
+               ret = commit_do(&trans, NULL, NULL, 0,
+                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k.k_i, 0));
+               if (ret) {
+                       bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
+                       break;
+               }
        }
+
+       bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void rand_lookup(struct bch_fs *c, u64 nr)
+static int rand_insert_multi(struct bch_fs *c, u64 nr)
 {
+       struct btree_trans trans;
+       struct bkey_i_cookie k[8];
+       int ret = 0;
+       unsigned j;
        u64 i;
 
-       for (i = 0; i < nr; i++) {
-               struct btree_iter iter;
-               struct bkey_s_c k;
+       bch2_trans_init(&trans, c, 0, 0);
 
-               bch2_btree_iter_init(&iter, c, BTREE_ID_DIRENTS,
-                                    POS(0, test_rand()), 0);
+       for (i = 0; i < nr; i += ARRAY_SIZE(k)) {
+               for (j = 0; j < ARRAY_SIZE(k); j++) {
+                       bkey_cookie_init(&k[j].k_i);
+                       k[j].k.p.offset = test_rand();
+                       k[j].k.p.snapshot = U32_MAX;
+               }
 
-               k = bch2_btree_iter_peek(&iter);
-               bch2_btree_iter_unlock(&iter);
+               ret = commit_do(&trans, NULL, NULL, 0,
+                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[0].k_i, 0) ?:
+                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[1].k_i, 0) ?:
+                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[2].k_i, 0) ?:
+                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[3].k_i, 0) ?:
+                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[4].k_i, 0) ?:
+                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[5].k_i, 0) ?:
+                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[6].k_i, 0) ?:
+                       __bch2_btree_insert(&trans, BTREE_ID_xattrs, &k[7].k_i, 0));
+               if (ret) {
+                       bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
+                       break;
+               }
        }
+
+       bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void rand_mixed(struct bch_fs *c, u64 nr)
+static int rand_lookup(struct bch_fs *c, u64 nr)
 {
-       int ret;
+       struct btree_trans trans;
+       struct btree_iter iter;
+       struct bkey_s_c k;
+       int ret = 0;
        u64 i;
 
+       bch2_trans_init(&trans, c, 0, 0);
+       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs,
+                            SPOS(0, 0, U32_MAX), 0);
+
        for (i = 0; i < nr; i++) {
-               struct btree_trans trans;
-               struct btree_iter *iter;
-               struct bkey_s_c k;
+               bch2_btree_iter_set_pos(&iter, SPOS(0, test_rand(), U32_MAX));
 
-               bch2_trans_init(&trans, c);
+               lockrestart_do(&trans, bkey_err(k = bch2_btree_iter_peek(&iter)));
+               ret = bkey_err(k);
+               if (ret) {
+                       bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
+                       break;
+               }
+       }
 
-               iter = bch2_trans_get_iter(&trans, BTREE_ID_DIRENTS,
-                                          POS(0, test_rand()), 0);
+       bch2_trans_iter_exit(&trans, &iter);
+       bch2_trans_exit(&trans);
+       return ret;
+}
+
+static int rand_mixed_trans(struct btree_trans *trans,
+                           struct btree_iter *iter,
+                           struct bkey_i_cookie *cookie,
+                           u64 i, u64 pos)
+{
+       struct bkey_s_c k;
+       int ret;
 
-               k = bch2_btree_iter_peek(iter);
+       bch2_btree_iter_set_pos(iter, SPOS(0, pos, U32_MAX));
 
-               if (!(i & 3) && k.k) {
-                       struct bkey_i_cookie k;
+       k = bch2_btree_iter_peek(iter);
+       ret = bkey_err(k);
+       if (ret && !bch2_err_matches(ret, BCH_ERR_transaction_restart))
+               bch_err(trans->c, "%s(): lookup error: %s", __func__, bch2_err_str(ret));
+       if (ret)
+               return ret;
 
-                       bkey_cookie_init(&k.k_i);
-                       k.k.p = iter->pos;
+       if (!(i & 3) && k.k) {
+               bkey_cookie_init(&cookie->k_i);
+               cookie->k.p = iter->pos;
+               ret = bch2_trans_update(trans, iter, &cookie->k_i, 0);
+       }
 
-                       bch2_trans_update(&trans, BTREE_INSERT_ENTRY(iter, &k.k_i));
-                       ret = bch2_trans_commit(&trans, NULL, NULL, 0);
-                       BUG_ON(ret);
-               }
+       return ret;
+}
+
+static int rand_mixed(struct bch_fs *c, u64 nr)
+{
+       struct btree_trans trans;
+       struct btree_iter iter;
+       struct bkey_i_cookie cookie;
+       int ret = 0;
+       u64 i, rand;
 
-               bch2_trans_exit(&trans);
+       bch2_trans_init(&trans, c, 0, 0);
+       bch2_trans_iter_init(&trans, &iter, BTREE_ID_xattrs,
+                            SPOS(0, 0, U32_MAX), 0);
+
+       for (i = 0; i < nr; i++) {
+               rand = test_rand();
+               ret = commit_do(&trans, NULL, NULL, 0,
+                       rand_mixed_trans(&trans, &iter, &cookie, i, rand));
+               if (ret) {
+                       bch_err(c, "%s(): update error: %s", __func__, bch2_err_str(ret));
+                       break;
+               }
        }
 
+       bch2_trans_iter_exit(&trans, &iter);
+       bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void rand_delete(struct bch_fs *c, u64 nr)
+static int __do_delete(struct btree_trans *trans, struct bpos pos)
 {
-       struct bkey_i k;
-       int ret;
+       struct btree_iter iter;
+       struct bkey_s_c k;
+       int ret = 0;
+
+       bch2_trans_iter_init(trans, &iter, BTREE_ID_xattrs, pos,
+                            BTREE_ITER_INTENT);
+       lockrestart_do(trans, bkey_err(k = bch2_btree_iter_peek(&iter)));
+       ret = bkey_err(k);
+       if (ret)
+               goto err;
+
+       if (!k.k)
+               goto err;
+
+       ret = bch2_btree_delete_at(trans, &iter, 0);
+err:
+       bch2_trans_iter_exit(trans, &iter);
+       return ret;
+}
+
+static int rand_delete(struct bch_fs *c, u64 nr)
+{
+       struct btree_trans trans;
+       int ret = 0;
        u64 i;
 
+       bch2_trans_init(&trans, c, 0, 0);
+
        for (i = 0; i < nr; i++) {
-               bkey_init(&k.k);
-               k.k.p.offset = test_rand();
+               struct bpos pos = SPOS(0, test_rand(), U32_MAX);
 
-               ret = bch2_btree_insert(c, BTREE_ID_DIRENTS, &k,
-                                       NULL, NULL, 0);
-               BUG_ON(ret);
+               ret = commit_do(&trans, NULL, NULL, 0,
+                       __do_delete(&trans, pos));
+               if (ret) {
+                       bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
+                       break;
+               }
        }
+
+       bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void seq_insert(struct bch_fs *c, u64 nr)
+static int seq_insert(struct bch_fs *c, u64 nr)
 {
        struct btree_trans trans;
-       struct btree_iter *iter;
+       struct btree_iter iter;
        struct bkey_s_c k;
        struct bkey_i_cookie insert;
-       int ret;
-       u64 i = 0;
+       int ret = 0;
 
        bkey_cookie_init(&insert.k_i);
 
-       bch2_trans_init(&trans, c);
-
-       iter = bch2_trans_get_iter(&trans, BTREE_ID_DIRENTS, POS_MIN,
-                                  BTREE_ITER_SLOTS|BTREE_ITER_INTENT);
-
-       for_each_btree_key_continue(iter, BTREE_ITER_SLOTS, k) {
-               insert.k.p = iter->pos;
-
-               bch2_trans_update(&trans, BTREE_INSERT_ENTRY(iter, &insert.k_i));
-               ret = bch2_trans_commit(&trans, NULL, NULL, 0);
-               BUG_ON(ret);
+       bch2_trans_init(&trans, c, 0, 0);
+
+       ret = for_each_btree_key_commit(&trans, iter, BTREE_ID_xattrs,
+                                       SPOS(0, 0, U32_MAX),
+                                       BTREE_ITER_SLOTS|BTREE_ITER_INTENT, k,
+                                       NULL, NULL, 0,
+               ({
+                       if (iter.pos.offset >= nr)
+                               break;
+                       insert.k.p = iter.pos;
+                       bch2_trans_update(&trans, &iter, &insert.k_i, 0);
+               }));
+       if (ret)
+               bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
 
-               if (++i == nr)
-                       break;
-       }
        bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void seq_lookup(struct bch_fs *c, u64 nr)
+static int seq_lookup(struct bch_fs *c, u64 nr)
 {
+       struct btree_trans trans;
        struct btree_iter iter;
        struct bkey_s_c k;
+       int ret = 0;
 
-       for_each_btree_key(&iter, c, BTREE_ID_DIRENTS, POS_MIN, 0, k)
-               ;
-       bch2_btree_iter_unlock(&iter);
+       bch2_trans_init(&trans, c, 0, 0);
+
+       ret = for_each_btree_key2_upto(&trans, iter, BTREE_ID_xattrs,
+                                 SPOS(0, 0, U32_MAX), POS(0, U64_MAX),
+                                 0, k,
+               0);
+       if (ret)
+               bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
+
+       bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void seq_overwrite(struct bch_fs *c, u64 nr)
+static int seq_overwrite(struct bch_fs *c, u64 nr)
 {
        struct btree_trans trans;
-       struct btree_iter *iter;
+       struct btree_iter iter;
        struct bkey_s_c k;
-       int ret;
-
-       bch2_trans_init(&trans, c);
+       int ret = 0;
 
-       iter = bch2_trans_get_iter(&trans, BTREE_ID_DIRENTS, POS_MIN,
-                                  BTREE_ITER_INTENT);
+       bch2_trans_init(&trans, c, 0, 0);
 
-       for_each_btree_key_continue(iter, 0, k) {
-               struct bkey_i_cookie u;
+       ret = for_each_btree_key_commit(&trans, iter, BTREE_ID_xattrs,
+                                       SPOS(0, 0, U32_MAX),
+                                       BTREE_ITER_INTENT, k,
+                                       NULL, NULL, 0,
+               ({
+                       struct bkey_i_cookie u;
 
-               bkey_reassemble(&u.k_i, k);
+                       bkey_reassemble(&u.k_i, k);
+                       bch2_trans_update(&trans, &iter, &u.k_i, 0);
+               }));
+       if (ret)
+               bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
 
-               bch2_trans_update(&trans, BTREE_INSERT_ENTRY(iter, &u.k_i));
-               ret = bch2_trans_commit(&trans, NULL, NULL, 0);
-               BUG_ON(ret);
-       }
        bch2_trans_exit(&trans);
+       return ret;
 }
 
-static void seq_delete(struct bch_fs *c, u64 nr)
+static int seq_delete(struct bch_fs *c, u64 nr)
 {
        int ret;
 
-       ret = bch2_btree_delete_range(c, BTREE_ID_DIRENTS,
-                                     POS(0, 0), POS(0, U64_MAX),
-                                     NULL);
-       BUG_ON(ret);
+       ret = bch2_btree_delete_range(c, BTREE_ID_xattrs,
+                                     SPOS(0, 0, U32_MAX),
+                                     POS(0, U64_MAX),
+                                     0, NULL);
+       if (ret)
+               bch_err(c, "%s(): error %s", __func__, bch2_err_str(ret));
+       return ret;
 }
 
-typedef void (*perf_test_fn)(struct bch_fs *, u64);
+typedef int (*perf_test_fn)(struct bch_fs *, u64);
 
 struct test_job {
        struct bch_fs                   *c;
@@ -552,11 +869,13 @@ struct test_job {
 
        u64                             start;
        u64                             finish;
+       int                             ret;
 };
 
 static int btree_perf_test_thread(void *data)
 {
        struct test_job *j = data;
+       int ret;
 
        if (atomic_dec_and_test(&j->ready)) {
                wake_up(&j->ready_wait);
@@ -565,7 +884,11 @@ static int btree_perf_test_thread(void *data)
                wait_event(j->ready_wait, !atomic_read(&j->ready));
        }
 
-       j->fn(j->c, j->nr / j->nr_threads);
+       ret = j->fn(j->c, div64_u64(j->nr, j->nr_threads));
+       if (ret) {
+               bch_err(j->c, "%ps: error %s", j->fn, bch2_err_str(ret));
+               j->ret = ret;
+       }
 
        if (atomic_dec_and_test(&j->done)) {
                j->finish = sched_clock();
@@ -575,11 +898,13 @@ static int btree_perf_test_thread(void *data)
        return 0;
 }
 
-void bch2_btree_perf_test(struct bch_fs *c, const char *testname,
-                         u64 nr, unsigned nr_threads)
+int bch2_btree_perf_test(struct bch_fs *c, const char *testname,
+                        u64 nr, unsigned nr_threads)
 {
        struct test_job j = { .c = c, .nr = nr, .nr_threads = nr_threads };
-       char name_buf[20], nr_buf[20], per_sec_buf[20];
+       char name_buf[20];
+       struct printbuf nr_buf = PRINTBUF;
+       struct printbuf per_sec_buf = PRINTBUF;
        unsigned i;
        u64 time;
 
@@ -593,6 +918,7 @@ void bch2_btree_perf_test(struct bch_fs *c, const char *testname,
        if (!strcmp(testname, #_test)) j.fn = _test
 
        perf_test(rand_insert);
+       perf_test(rand_insert_multi);
        perf_test(rand_lookup);
        perf_test(rand_mixed);
        perf_test(rand_delete);
@@ -617,9 +943,11 @@ void bch2_btree_perf_test(struct bch_fs *c, const char *testname,
        perf_test(test_extent_overwrite_middle);
        perf_test(test_extent_overwrite_all);
 
+       perf_test(test_snapshots);
+
        if (!j.fn) {
                pr_err("unknown test %s", testname);
-               return;
+               return -EINVAL;
        }
 
        //pr_info("running test %s:", testname);
@@ -637,13 +965,16 @@ void bch2_btree_perf_test(struct bch_fs *c, const char *testname,
        time = j.finish - j.start;
 
        scnprintf(name_buf, sizeof(name_buf), "%s:", testname);
-       bch2_hprint(&PBUF(nr_buf), nr);
-       bch2_hprint(&PBUF(per_sec_buf), nr * NSEC_PER_SEC / time);
+       prt_human_readable_u64(&nr_buf, nr);
+       prt_human_readable_u64(&per_sec_buf, div64_u64(nr * NSEC_PER_SEC, time));
        printk(KERN_INFO "%-12s %s with %u threads in %5llu sec, %5llu nsec per iter, %5s per sec\n",
-               name_buf, nr_buf, nr_threads,
-               time / NSEC_PER_SEC,
-               time * nr_threads / nr,
-               per_sec_buf);
+               name_buf, nr_buf.buf, nr_threads,
+               div_u64(time, NSEC_PER_SEC),
+               div_u64(time * nr_threads, nr),
+               per_sec_buf.buf);
+       printbuf_exit(&per_sec_buf);
+       printbuf_exit(&nr_buf);
+       return j.ret;
 }
 
 #endif /* CONFIG_BCACHEFS_TESTS */