- Fix TOCTOU problem (utf8_stat -> fstat)

[vlc] / modules / access / mms / mmstu.c

diff --git a/modules/access/mms/mmstu.c b/modules/access/mms/mmstu.c
index 034b15233402d8c9e153f0a3e9982ab2a8f054ff..778e614edf9d657aca0ab06c141e0a00a8916bdc 100644 (file)
--- a/modules/access/mms/mmstu.c
+++ b/modules/access/mms/mmstu.c
@@ -18,7 +18,7 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 
 
@@ -48,6 +48,7 @@
 #endif
 
 #include "network.h"
+#include "vlc_url.h"
 #include "asf.h"
 #include "buffer.h"
 
@@ -97,13 +98,13 @@ static int  mms_ReceivePacket( access_t * );
  * Merci :))
  */
 /*
- * Vous pourriez signer vos commentaires (même si on voit bien qui peut
- * écrire ce genre de trucs :p), et écrire en anglais, bordel de
+ * Vous pourriez signer vos commentaires (m�e si on voit bien qui peut
+ * �rire ce genre de trucs :p), et �rire en anglais, bordel de
  * merde :p.
  */
 /*
- * Alors la ouai ç'est fou les gens qui écrivent des commentaires sans les
- * signer. Ca mériterait un coup de pied dans le cul ça :)
+ * Alors la ouai �est fou les gens qui �rivent des commentaires sans les
+ * signer. Ca m�iterait un coup de pied dans le cul � :)
  */
 
 int  E_(MMSTUOpen)( access_t *p_access )
@@ -458,7 +459,7 @@ static int MMSOpen( access_t  *p_access, vlc_url_t *p_url, int  i_proto )
 
     /* *** Open a TCP connection with server *** */
     msg_Dbg( p_access, "waiting for connection..." );
-    p_sys->i_handle_tcp = net_OpenTCP( p_access, p_url->psz_host, p_url->i_port );
+    p_sys->i_handle_tcp = net_ConnectTCP( p_access, p_url->psz_host, p_url->i_port );
     if( p_sys->i_handle_tcp < 0 )
     {
         msg_Err( p_access, "failed to open a connection (tcp)" );
@@ -649,10 +650,10 @@ static int MMSOpen( access_t  *p_access, vlc_url_t *p_url, int  i_proto )
     switch( GetDWLE( p_sys->p_cmd + MMS_CMD_HEADERSIZE ) )
     {
         case 0x0001:
-            msg_Dbg( p_access, "Media file name/path accepted" );
+            msg_Dbg( p_access, "media file name/path accepted" );
             break;
         case 0x0002:
-            msg_Dbg( p_access, "Authentication accepted" );
+            msg_Dbg( p_access, "authentication accepted" );
             break;
         case -1:
         default:
@@ -677,7 +678,7 @@ static int MMSOpen( access_t  *p_access, vlc_url_t *p_url, int  i_proto )
         GetDWLE( p_sys->p_cmd + MMS_CMD_HEADERSIZE + 60 );
 
     msg_Dbg( p_access,
-             "answer 0x06 flags:0x%8.8x media_length:%ds packet_length:%d packet_count:%d max_bit_rate:%d header_size:%d",
+             "answer 0x06 flags:0x%8.8x media_length:%us packet_length:%ul packet_count:%u max_bit_rate:%d header_size:%d",
              p_sys->i_flags_broadcast,
              p_sys->i_media_length,
              p_sys->i_packet_length,
@@ -867,7 +868,7 @@ static int MMSStart( access_t  *p_access, uint32_t i_packet )
     {
         /* get a packet */
         mms_HeaderMediaRead( p_access, MMS_PACKET_MEDIA );
-        msg_Dbg( p_access, "Streaming started" );
+        msg_Dbg( p_access, "streaming started" );
         return( 0 );
     }
 }
@@ -911,14 +912,14 @@ static void MMSClose( access_t  *p_access )
         net_Close( p_sys->i_handle_udp );
     }
 
-    FREE( p_sys->p_cmd );
-    FREE( p_sys->p_media );
-    FREE( p_sys->p_header );
+    FREENULL( p_sys->p_cmd );
+    FREENULL( p_sys->p_media );
+    FREENULL( p_sys->p_header );
 
-    FREE( p_sys->psz_server_version );
-    FREE( p_sys->psz_tool_version );
-    FREE( p_sys->psz_update_player_url );
-    FREE( p_sys->psz_encryption_type );
+    FREENULL( p_sys->psz_server_version );
+    FREENULL( p_sys->psz_tool_version );
+    FREENULL( p_sys->psz_update_player_url );
+    FREENULL( p_sys->psz_encryption_type );
 }
 
 /****************************************************************************
@@ -926,15 +927,13 @@ static void MMSClose( access_t  *p_access )
  * MMS specific functions
  *
  ****************************************************************************/
-static int mms_CommandSend( access_t *p_access,
-                             int i_command,
-                             uint32_t i_prefix1, uint32_t i_prefix2,
-                             uint8_t *p_data, int i_data_old )
+static int mms_CommandSend( access_t *p_access, int i_command,
+                            uint32_t i_prefix1, uint32_t i_prefix2,
+                            uint8_t *p_data, int i_data_old )
 {
     var_buffer_t buffer;
-
-    access_sys_t        *p_sys = p_access->p_sys;
-    int i_data_by8;
+    access_sys_t *p_sys = p_access->p_sys;
+    int i_data_by8, i_ret;
     int i_data = i_data_old;
 
     while( i_data & 0x7 ) i_data++;
@@ -966,10 +965,9 @@ static int mms_CommandSend( access_t *p_access,
     var_buffer_add64( &buffer, 0 );
 
     /* send it */
-    if( send( p_sys->i_handle_tcp,
-              buffer.p_data,
-              buffer.i_data - ( 8 - ( i_data - i_data_old ) ),
-              0 ) == -1 )
+    i_ret = net_Write( p_access, p_sys->i_handle_tcp, NULL, buffer.p_data,
+                       buffer.i_data - ( 8 - ( i_data - i_data_old ) ) );
+    if( i_ret != buffer.i_data - ( 8 - ( i_data - i_data_old ) ) )
     {
         msg_Err( p_access, "failed to send command" );
         return VLC_EGENERIC;
@@ -1016,7 +1014,7 @@ static int NetFillBuffer( access_t *p_access )
 
     if( i_handle_max == 0 )
     {
-        msg_Warn( p_access, "nothing to read %d:%d", i_tcp, i_udp );
+        msg_Warn( p_access, "nothing to read %d:%d", (int)i_tcp, (int)i_udp );
         return 0;
     }
     else
@@ -1273,7 +1271,7 @@ static int  mms_ParsePacket( access_t *p_access,
     }
     else
     {
-        FREE( p_sys->p_media );
+        FREENULL( p_sys->p_media );
         p_sys->p_media = p_packet;
         p_sys->i_media = i_packet_length - 8;
         p_sys->i_media_used = 0;
@@ -1301,7 +1299,7 @@ static int mms_ReceivePacket( access_t *p_access )
             if( GetDWLE( p_sys->buffer_tcp + 4 ) == 0xb00bface  )
             {
                 if( GetDWLE( p_sys->buffer_tcp + 8 ) + 16 <=
-                    p_sys->i_buffer_tcp )
+                    (uint32_t)p_sys->i_buffer_tcp )
                 {
                     b_refill = VLC_FALSE;
                 }