# include "config.h"
#endif
-#include <vlc/vlc.h>
+#include <vlc_common.h>
+#include <vlc_plugin.h>
#include <vlc_access.h>
#include <sys/types.h>
#define CHAN_LONGTEXT N_( "Channel of the card to use (Usually, 0 = tuner, " \
"1 = composite, 2 = svideo)" )
-static int i_norm_list[] =
+static const int i_norm_list[] =
{ V4L2_STD_UNKNOWN, V4L2_STD_SECAM, V4L2_STD_PAL, V4L2_STD_NTSC };
-static const char *psz_norm_list_text[] =
+static const char *const psz_norm_list_text[] =
{ N_("Automatic"), N_("SECAM"), N_("PAL"), N_("NTSC") };
-static int i_bitrates[] = { 0, 1 };
-static const char *psz_bitrates_list_text[] = { N_("vbr"), N_("cbr") };
+static const int i_bitrates[] = { 0, 1 };
+static const char *const psz_bitrates_list_text[] = { N_("vbr"), N_("cbr") };
-static int pi_radio_range[2] = { 65000, 108000 };
+static const int pi_radio_range[2] = { 65000, 108000 };
-vlc_module_begin();
- set_shortname( _("PVR") );
- set_description( _("IVTV MPEG Encoding cards input") );
- set_category( CAT_INPUT );
- set_subcategory( SUBCAT_INPUT_ACCESS );
- set_capability( "access2", 0 );
- add_shortcut( "pvr" );
+vlc_module_begin ()
+ set_shortname( N_("PVR") )
+ set_description( N_("IVTV MPEG Encoding cards input") )
+ set_category( CAT_INPUT )
+ set_subcategory( SUBCAT_INPUT_ACCESS )
+ set_capability( "access", 0 )
+ add_shortcut( "pvr" )
add_integer( "pvr-caching", DEFAULT_PTS_DELAY / 1000, NULL, CACHING_TEXT,
- CACHING_LONGTEXT, VLC_TRUE );
+ CACHING_LONGTEXT, true )
add_string( "pvr-device", "/dev/video0", NULL, DEVICE_TEXT,
- DEVICE_LONGTEXT, VLC_FALSE );
+ DEVICE_LONGTEXT, false )
add_string( "pvr-radio-device", "/dev/radio0", NULL, RADIO_DEVICE_TEXT,
- RADIO_DEVICE_LONGTEXT, VLC_FALSE );
+ RADIO_DEVICE_LONGTEXT, false )
add_integer( "pvr-norm", V4L2_STD_UNKNOWN , NULL, NORM_TEXT,
- NORM_LONGTEXT, VLC_FALSE );
- change_integer_list( i_norm_list, psz_norm_list_text, 0 );
- add_integer( "pvr-width", -1, NULL, WIDTH_TEXT, WIDTH_LONGTEXT, VLC_TRUE );
+ NORM_LONGTEXT, false )
+ change_integer_list( i_norm_list, psz_norm_list_text, NULL )
+ add_integer( "pvr-width", -1, NULL, WIDTH_TEXT, WIDTH_LONGTEXT, true )
add_integer( "pvr-height", -1, NULL, HEIGHT_TEXT, HEIGHT_LONGTEXT,
- VLC_TRUE );
+ true )
add_integer( "pvr-frequency", -1, NULL, FREQUENCY_TEXT, FREQUENCY_LONGTEXT,
- VLC_FALSE );
+ false )
add_integer( "pvr-framerate", -1, NULL, FRAMERATE_TEXT, FRAMERATE_LONGTEXT,
- VLC_TRUE );
+ true )
add_integer( "pvr-keyint", -1, NULL, KEYINT_TEXT, KEYINT_LONGTEXT,
- VLC_TRUE );
+ true )
add_integer( "pvr-bframes", -1, NULL, FRAMERATE_TEXT, FRAMERATE_LONGTEXT,
- VLC_TRUE );
+ true )
add_integer( "pvr-bitrate", -1, NULL, BITRATE_TEXT, BITRATE_LONGTEXT,
- VLC_FALSE );
+ false )
add_integer( "pvr-bitrate-peak", -1, NULL, BITRATE_PEAK_TEXT,
- BITRATE_PEAK_LONGTEXT, VLC_TRUE );
+ BITRATE_PEAK_LONGTEXT, true )
add_integer( "pvr-bitrate-mode", -1, NULL, BITRATE_MODE_TEXT,
- BITRATE_MODE_LONGTEXT, VLC_TRUE );
- change_integer_list( i_bitrates, psz_bitrates_list_text, 0 );
+ BITRATE_MODE_LONGTEXT, true )
+ change_integer_list( i_bitrates, psz_bitrates_list_text, NULL )
add_integer( "pvr-audio-bitmask", -1, NULL, BITMASK_TEXT,
- BITMASK_LONGTEXT, VLC_TRUE );
+ BITMASK_LONGTEXT, true )
add_integer( "pvr-audio-volume", -1, NULL, VOLUME_TEXT,
- VOLUME_LONGTEXT, VLC_TRUE );
- add_integer( "pvr-channel", -1, NULL, CHAN_TEXT, CHAN_LONGTEXT, VLC_TRUE );
+ VOLUME_LONGTEXT, true )
+ add_integer( "pvr-channel", -1, NULL, CHAN_TEXT, CHAN_LONGTEXT, true )
- set_callbacks( Open, Close );
-vlc_module_end();
+ set_callbacks( Open, Close )
+vlc_module_end ()
/*****************************************************************************
* Prototypes
int i_volume;
/* driver version */
- vlc_bool_t b_v4l2_api;
+ bool b_v4l2_api;
};
/*****************************************************************************
controls.reserved[0] = 0;
controls.reserved[1] = 0;
controls.count = 0;
- controls.controls = calloc( sizeof( struct v4l2_ext_control ),
- MAX_V4L2_CTRLS );
+ controls.controls = calloc( MAX_V4L2_CTRLS,
+ sizeof( struct v4l2_ext_control ) );
if( controls.controls == NULL )
return VLC_ENOMEM;
access_sys_t * p_sys;
char * psz_tofree;
char * psz_parser;
- char * psz_device = NULL;
vlc_value_t val;
struct v4l2_capability device_capability;
int result;
memset( &device_capability, 0, sizeof(struct v4l2_capability) );
- p_access->pf_read = Read;
- p_access->pf_block = NULL;
- p_access->pf_seek = NULL;
- p_access->pf_control = Control;
- p_access->info.i_update = 0;
- p_access->info.i_size = 0;
- p_access->info.i_pos = 0;
- p_access->info.b_eof = VLC_FALSE;
- p_access->info.i_title = 0;
- p_access->info.i_seekpoint = 0;
-
- /* create private access data */
- p_sys = calloc( sizeof( access_sys_t ), 1 );
- if( !p_sys )
- return VLC_ENOMEM;
-
- p_access->p_sys = p_sys;
+ access_InitFields( p_access );
+ ACCESS_SET_CALLBACKS( Read, NULL, Control, NULL );
+ p_sys = p_access->p_sys = calloc( 1, sizeof( access_sys_t ));
+ if( !p_sys ) return VLC_ENOMEM;
/* defaults values */
var_Create( p_access, "pvr-caching", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
/* parse command line options */
psz_tofree = strdup( p_access->psz_path );
if( !psz_tofree )
- return VLC_ENOMEM;
+ return VLC_ENOMEM; /* <-- FIXME MEMORY LEAK */
psz_parser = psz_tofree;
- if( *psz_parser )
+ while( *psz_parser )
{
- for( ;; )
+ /* Leading slash -> device path */
+ if( *psz_parser == '/' )
{
- if ( !strncmp( psz_parser, "norm=", strlen( "norm=" ) ) )
- {
- char *psz_parser_init;
- psz_parser += strlen( "norm=" );
- psz_parser_init = psz_parser;
- while ( (*psz_parser != ':')
- && (*psz_parser != ',')
- && (*psz_parser != '\0') )
- {
- psz_parser++;
- }
-
- if ( !strncmp( psz_parser_init, "secam" ,
- psz_parser - psz_parser_init ) )
- {
- p_sys->i_standard = V4L2_STD_SECAM;
- }
- else if ( !strncmp( psz_parser_init, "pal" ,
- psz_parser - psz_parser_init ) )
- {
- p_sys->i_standard = V4L2_STD_PAL;
- }
- else if ( !strncmp( psz_parser_init, "ntsc" ,
- psz_parser - psz_parser_init ) )
- {
- p_sys->i_standard = V4L2_STD_NTSC;
- }
- else
- {
- p_sys->i_standard = strtol( psz_parser_init ,
- &psz_parser, 0 );
- }
- }
- else if( !strncmp( psz_parser, "channel=",
- strlen( "channel=" ) ) )
- {
- p_sys->i_input =
- strtol( psz_parser + strlen( "channel=" ),
- &psz_parser, 0 );
- }
- else if( !strncmp( psz_parser, "device=", strlen( "device=" ) ) )
- {
- int i_len = strlen( "/dev/videox" );
- psz_device = calloc( i_len + 1, 1 );
- if( !psz_device )
- return VLC_ENOMEM;
-
- snprintf( psz_device, i_len, "/dev/video%ld",
- strtol( psz_parser + strlen( "device=" ),
- &psz_parser, 0 ) );
- }
- else if( !strncmp( psz_parser, "frequency=",
- strlen( "frequency=" ) ) )
- {
- p_sys->i_frequency =
- strtol( psz_parser + strlen( "frequency=" ),
- &psz_parser, 0 );
- }
- else if( !strncmp( psz_parser, "framerate=",
- strlen( "framerate=" ) ) )
- {
- p_sys->i_framerate =
- strtol( psz_parser + strlen( "framerate=" ),
- &psz_parser, 0 );
- }
- else if( !strncmp( psz_parser, "keyint=",
- strlen( "keyint=" ) ) )
- {
- p_sys->i_keyint =
- strtol( psz_parser + strlen( "keyint=" ),
- &psz_parser, 0 );
- }
- else if( !strncmp( psz_parser, "bframes=",
- strlen( "bframes=" ) ) )
- {
- p_sys->i_bframes =
- strtol( psz_parser + strlen( "bframes=" ),
- &psz_parser, 0 );
- }
+ free( p_sys->psz_videodev );
+ p_sys->psz_videodev = strdup( psz_parser );
+ break;
+ }
- else if( !strncmp( psz_parser, "width=",
- strlen( "width=" ) ) )
- {
- p_sys->i_width =
- strtol( psz_parser + strlen( "width=" ),
- &psz_parser, 0 );
- }
- else if( !strncmp( psz_parser, "height=",
- strlen( "height=" ) ) )
- {
- p_sys->i_height =
- strtol( psz_parser + strlen( "height=" ),
- &psz_parser, 0 );
- }
- else if( !strncmp( psz_parser, "audio=",
- strlen( "audio=" ) ) )
- {
- p_sys->i_audio_bitmask =
- strtol( psz_parser + strlen( "audio=" ),
- &psz_parser, 0 );
- }
- else if( !strncmp( psz_parser, "bitrate=",
- strlen( "bitrate=" ) ) )
- {
- p_sys->i_bitrate =
- strtol( psz_parser + strlen( "bitrate=" ),
- &psz_parser, 0 );
- }
- else if( !strncmp( psz_parser, "maxbitrate=",
- strlen( "maxbitrate=" ) ) )
- {
- p_sys->i_bitrate_peak =
- strtol( psz_parser + strlen( "maxbitrate=" ),
- &psz_parser, 0 );
- }
- else if( !strncmp( psz_parser, "bitratemode=",
- strlen( "bitratemode=" ) ) )
- {
- char *psz_parser_init;
- psz_parser += strlen( "bitratemode=" );
- psz_parser_init = psz_parser;
- while ( (*psz_parser != ':')
- && (*psz_parser != ',')
- && (*psz_parser != '\0') )
- {
- psz_parser++;
- }
+ /* Extract option name */
+ const char *optname = psz_parser;
+ psz_parser = strchr( psz_parser, '=' );
+ if( psz_parser == NULL )
+ break;
+ *psz_parser++ = '\0';
- if ( !strncmp( psz_parser_init, "vbr" ,
- psz_parser - psz_parser_init ) )
- {
- p_sys->i_bitrate_mode = 0;
- }
- else if ( !strncmp( psz_parser_init, "cbr" ,
- psz_parser - psz_parser_init ) )
- {
- p_sys->i_bitrate_mode = 1;
- }
- }
- else if( !strncmp( psz_parser, "size=",
- strlen( "size=" ) ) )
- {
- p_sys->i_width =
- strtol( psz_parser + strlen( "size=" ),
- &psz_parser, 0 );
- p_sys->i_height =
- strtol( psz_parser + 1 ,
- &psz_parser, 0 );
- }
- else
- {
- char *psz_parser_init;
- psz_parser_init = psz_parser;
- while ( (*psz_parser != ':') &&
- (*psz_parser != ',') &&
- (*psz_parser != '\0') )
- {
- psz_parser++;
- }
- psz_device = calloc( psz_parser - psz_parser_init + 1, 1 );
- if( !psz_device )
- return VLC_ENOMEM;
+ /* Extract option value */
+ char *optval = psz_parser;
+ while( memchr( ":,", *psz_parser, 3 /* includes \0 */ ) == NULL )
+ psz_parser++;
+ if( *psz_parser ) /* more options to come */
+ *psz_parser++ = '\0'; /* skip , or : */
- strncpy( psz_device, psz_parser_init,
- psz_parser - psz_parser_init );
- }
- if( *psz_parser )
- psz_parser++;
+ if ( !strcmp( optname, "norm" ) )
+ {
+ if ( !strcmp( optval, "secam" ) )
+ p_sys->i_standard = V4L2_STD_SECAM;
+ else if ( !strcmp( optval, "pal" ) )
+ p_sys->i_standard = V4L2_STD_PAL;
+ else if ( !strcmp( optval, "ntsc" ) )
+ p_sys->i_standard = V4L2_STD_NTSC;
else
- break;
+ p_sys->i_standard = atoi( optval );
}
- }
- free( psz_tofree );
-
- if( psz_device )
- {
- if( p_sys->psz_videodev )
+ else if( !strcmp( optname, "channel" ) )
+ p_sys->i_input = atoi( optval );
+ else if( !strcmp( optname, "device" ) )
+ {
free( p_sys->psz_videodev );
- p_sys->psz_videodev = psz_device;
+ if( asprintf( &p_sys->psz_videodev, "/dev/video%s", optval ) == -1)
+ p_sys->psz_videodev = NULL;
+ }
+ else if( !strcmp( optname, "frequency" ) )
+ p_sys->i_frequency = atoi( optval );
+ else if( !strcmp( optname, "framerate" ) )
+ p_sys->i_framerate = atoi( optval );
+ else if( !strcmp( optname, "keyint" ) )
+ p_sys->i_keyint = atoi( optval );
+ else if( !strcmp( optname, "bframes" ) )
+ p_sys->i_bframes = atoi( optval );
+ else if( !strcmp( optname, "width" ) )
+ p_sys->i_width = atoi( optval );
+ else if( !strcmp( optname, "height" ) )
+ p_sys->i_height = atoi( optval );
+ else if( !strcmp( optname, "audio" ) )
+ p_sys->i_audio_bitmask = atoi( optval );
+ else if( !strcmp( optname, "bitrate" ) )
+ p_sys->i_bitrate = atoi( optval );
+ else if( !strcmp( optname, "maxbitrate" ) )
+ p_sys->i_bitrate_peak = atoi( optval );
+ else if( !strcmp( optname, "bitratemode" ) )
+ {
+ if( !strcmp( optval, "vbr" ) )
+ p_sys->i_bitrate_mode = 0;
+ else if( !strcmp( optval, "cbr" ) )
+ p_sys->i_bitrate_mode = 1;
+ }
+ else if( !strcmp( optname, "size" ) )
+ {
+ p_sys->i_width = strtol( optval, &optval, 0 );
+ p_sys->i_height = atoi( optval );
+ }
}
+ free( psz_tofree );
/* open the device */
p_sys->i_fd = open( p_sys->psz_videodev, O_RDWR );
if( p_sys->i_fd < 0 )
{
- msg_Err( p_access, "Cannot open device (%m)." );
+ msg_Err( p_access, "Cannot open device %s (%m).",
+ p_sys->psz_videodev );
Close( VLC_OBJECT(p_access) );
return VLC_EGENERIC;
}
{
/* Drivers > 0.8.0 use v4l2 API instead of IVTV ioctls */
msg_Dbg( p_access, "this driver uses the v4l2 API" );
- p_sys->b_v4l2_api = VLC_TRUE;
+ p_sys->b_v4l2_api = true;
}
else
{
- p_sys->b_v4l2_api = VLC_FALSE;
+ p_sys->b_v4l2_api = false;
}
/* set the input */
close( p_sys->i_fd );
if ( p_sys->i_radio_fd != -1 )
close( p_sys->i_radio_fd );
- if ( p_sys->psz_videodev )
- free( p_sys->psz_videodev );
- if ( p_sys->psz_radiodev )
- free( p_sys->psz_radiodev );
+ free( p_sys->psz_videodev );
+ free( p_sys->psz_radiodev );
free( p_sys );
}
do
{
- if( p_access->b_die )
+ if( !vlc_object_alive (p_access) )
return 0;
ufd.revents = 0;
i_ret = read( p_sys->i_fd, p_buffer, i_len );
if( i_ret == 0 )
{
- p_access->info.b_eof = VLC_TRUE;
+ p_access->info.b_eof = true;
}
else if( i_ret > 0 )
{
*****************************************************************************/
static int Control( access_t *p_access, int i_query, va_list args )
{
- vlc_bool_t *pb_bool;
+ bool *pb_bool;
int *pi_int;
int64_t *pi_64;
/* */
case ACCESS_CAN_SEEK:
case ACCESS_CAN_FASTSEEK:
- pb_bool = (vlc_bool_t*)va_arg( args, vlc_bool_t* );
- *pb_bool = VLC_FALSE;
+ pb_bool = (bool*)va_arg( args, bool* );
+ *pb_bool = false;
break;
case ACCESS_CAN_PAUSE:
- pb_bool = (vlc_bool_t*)va_arg( args, vlc_bool_t* );
- *pb_bool = VLC_FALSE;
+ pb_bool = (bool*)va_arg( args, bool* );
+ *pb_bool = false;
break;
case ACCESS_CAN_CONTROL_PACE:
- pb_bool = (vlc_bool_t*)va_arg( args, vlc_bool_t* );
- *pb_bool = VLC_FALSE;
+ pb_bool = (bool*)va_arg( args, bool* );
+ *pb_bool = false;
break;
/* */
- case ACCESS_GET_MTU:
- pi_int = (int*)va_arg( args, int * );
- *pi_int = 0;
- break;
-
case ACCESS_GET_PTS_DELAY:
pi_64 = (int64_t*)va_arg( args, int64_t * );
*pi_64 = (int64_t)var_GetInteger( p_access, "pvr-caching" ) * 1000;
projects / vlc / blobdiff