]> git.sesse.net Git - vlc/blobdiff - modules/audio_mixer/trivial.c
* Audio volume management now works properly. See src/audio_output/intf.c
[vlc] / modules / audio_mixer / trivial.c
index e53479359758a0f6bd0d8d1a3bd0f04d8758334b..73d86b5134f37d2398d831a587fda39c17fec4af 100644 (file)
@@ -2,7 +2,7 @@
  * trivial.c : trivial mixer plug-in (1 input, no downmixing)
  *****************************************************************************
  * Copyright (C) 2002 VideoLAN
- * $Id: trivial.c,v 1.4 2002/08/12 22:12:50 massiot Exp $
+ * $Id: trivial.c,v 1.6 2002/08/21 22:41:59 massiot Exp $
  *
  * Authors: Christophe Massiot <massiot@via.ecp.fr>
  *
@@ -43,9 +43,8 @@ static void DoWork    ( aout_instance_t *, aout_buffer_t * );
  * Module descriptor
  *****************************************************************************/
 vlc_module_begin();
-    set_description( _("trivial aout mixer module") );
+    set_description( _("trivial audio mixer module") );
     set_capability( "audio mixer", 1 );
-    add_shortcut( "trivial" );
     set_callbacks( Create, NULL );
 vlc_module_end();
 
@@ -56,8 +55,8 @@ static int Create( vlc_object_t *p_this )
 {
     aout_instance_t * p_aout = (aout_instance_t *)p_this;
 
-    if ( p_aout->mixer.output.i_format != AOUT_FMT_FLOAT32
-          && p_aout->mixer.output.i_format != AOUT_FMT_FIXED32 )
+    if ( p_aout->mixer.mixer.i_format != AOUT_FMT_FLOAT32
+          && p_aout->mixer.mixer.i_format != AOUT_FMT_FIXED32 )
     {
         return -1;
     }
@@ -67,136 +66,50 @@ static int Create( vlc_object_t *p_this )
     return 0;
 }
 
-/*****************************************************************************
- * SparseCopy: trivially downmix or upmix a buffer
- *****************************************************************************/
-static void SparseCopy( u32 * p_dest, const u32 * p_src, size_t i_len,
-                        int i_output_stride, int i_input_stride )
-{
-    int i;
-    for ( i = 0; i < i_len; i++ )
-    {
-        int j;
-        for ( j = 0; j < i_output_stride; j++ )
-        {
-            p_dest[j] = p_src[j];
-        }
-        p_src += i_input_stride;
-        p_dest += i_output_stride;
-    }
-}
-
 /*****************************************************************************
  * DoWork: mix a new output buffer
  *****************************************************************************/
 static void DoWork( aout_instance_t * p_aout, aout_buffer_t * p_buffer )
 {
     aout_input_t * p_input = p_aout->pp_inputs[0];
+    int i_nb_bytes = p_buffer->i_nb_samples * sizeof(s32)
+                      * p_aout->mixer.mixer.i_channels;
+    byte_t * p_in = p_input->p_first_byte_to_mix;
+    byte_t * p_out = p_buffer->p_buffer;
 
-    if ( p_input->input.i_channels == p_aout->mixer.output.i_channels )
+    for ( ; ; )
     {
-        int i_nb_bytes = p_buffer->i_nb_samples * sizeof(u32)
-                          * p_input->input.i_channels;
-        byte_t * p_in = (p_input->p_first_byte_to_mix == NULL) ?
-                        p_input->fifo.p_first->p_buffer :
-                        p_input->p_first_byte_to_mix;
-        byte_t * p_out = p_buffer->p_buffer;
+        ptrdiff_t i_available_bytes = (p_input->fifo.p_first->p_buffer
+                                        - p_in)
+                                        + p_input->fifo.p_first->i_nb_samples
+                                           * sizeof(s32)
+                                           * p_aout->mixer.mixer.i_channels;
 
-        for ( ; ; )
+        if ( i_available_bytes < i_nb_bytes )
         {
-            ptrdiff_t i_available_bytes = (p_input->fifo.p_first->p_buffer
-                                           - p_in)
-                                           + p_input->fifo.p_first->i_nb_samples
-                                              * sizeof(u32)
-                                              * p_input->input.i_channels;
-
-            if ( i_available_bytes < i_nb_bytes )
-            {
-                aout_buffer_t * p_old_buffer;
+            aout_buffer_t * p_old_buffer;
 
-                if ( i_available_bytes > 0 )
-                    p_aout->p_vlc->pf_memcpy( p_out, p_in, i_available_bytes );
-                i_nb_bytes -= i_available_bytes;
-                p_out += i_available_bytes;
+            if ( i_available_bytes > 0 )
+                p_aout->p_vlc->pf_memcpy( p_out, p_in, i_available_bytes );
+            i_nb_bytes -= i_available_bytes;
+            p_out += i_available_bytes;
 
-                /* Next buffer */
-                p_old_buffer = aout_FifoPop( p_aout, &p_input->fifo );
-                aout_BufferFree( p_old_buffer );
-                if ( p_input->fifo.p_first == NULL )
-                {
-                    msg_Err( p_aout, "internal amix error" );
-                    return;
-                }
-                p_in = p_input->fifo.p_first->p_buffer;
-            }
-            else
+            /* Next buffer */
+            p_old_buffer = aout_FifoPop( p_aout, &p_input->fifo );
+            aout_BufferFree( p_old_buffer );
+            if ( p_input->fifo.p_first == NULL )
             {
-                p_aout->p_vlc->pf_memcpy( p_out, p_in, i_nb_bytes );
-                p_input->p_first_byte_to_mix = p_in + i_nb_bytes;
-                break;
+                msg_Err( p_aout, "internal amix error" );
+                return;
             }
+            p_in = p_input->fifo.p_first->p_buffer;
         }
-    }
-    else
-    {
-        /* Downmixing or upmixing. */
-        int i_nb_samples = p_buffer->i_nb_samples;
-        u32 * p_in = (p_input->p_first_byte_to_mix == NULL) ?
-                     (u32 *)p_input->fifo.p_first->p_buffer :
-                     (u32 *)p_input->p_first_byte_to_mix;
-        u32 * p_out = (u32 *)p_buffer->p_buffer;
-
-        if ( p_input->input.i_channels < p_aout->mixer.output.i_channels )
+        else
         {
-            /* Zero out the destination buffer, to avoid static on unavailable
-             * channels. */
-            memset( p_buffer->p_buffer, 0,
-                    p_buffer->i_nb_samples * sizeof(u32)
-                     * p_aout->mixer.output.i_channels );
-        }
-
-        for ( ; ; )
-        {
-            ptrdiff_t i_available_bytes = (p_input->fifo.p_first->p_buffer
-                                           - (byte_t *)p_in)
-                                           + p_input->fifo.p_first->i_nb_samples
-                                              * sizeof(u32)
-                                              * p_input->input.i_channels;
-            int i_available_samples = i_available_bytes
-                                       / p_input->input.i_channels
-                                       / sizeof(u32);
-
-            if ( i_available_samples < i_nb_samples )
-            {
-                aout_buffer_t * p_old_buffer;
-
-                if ( i_available_samples > 0 )
-                    SparseCopy( p_out, p_in, i_available_samples,
-                                p_aout->mixer.output.i_channels,
-                                p_input->input.i_channels );
-                i_nb_samples -= i_available_samples;
-                p_out += i_available_samples * p_aout->mixer.output.i_channels;
-
-                /* Next buffer */
-                p_old_buffer = aout_FifoPop( p_aout, &p_input->fifo );
-                aout_BufferFree( p_old_buffer );
-                if ( p_input->fifo.p_first == NULL )
-                {
-                    msg_Err( p_aout, "internal amix error" );
-                    return;
-                }
-                p_in = (u32 *)p_input->fifo.p_first->p_buffer;
-            }
-            else
-            {
-                SparseCopy( p_out, p_in, i_nb_samples,
-                            p_aout->mixer.output.i_channels,
-                            p_input->input.i_channels );
-                p_input->p_first_byte_to_mix = (byte_t *)p_in
-                               + i_nb_samples * p_input->input.i_channels
-                                  * sizeof(u32);
-                break;
-            }
+            if ( i_nb_bytes > 0 )
+                p_aout->p_vlc->pf_memcpy( p_out, p_in, i_nb_bytes );
+            p_input->p_first_byte_to_mix = p_in + i_nb_bytes;
+            break;
         }
     }
 }