]> git.sesse.net Git - vlc/blobdiff - modules/audio_output/directx.c
Improvements to preferences
[vlc] / modules / audio_output / directx.c
index 23a0be19c9c6c4b2ea70136daaf0fb24db072d71..5bed710d0c99b984f841e02a7e7b820d26aa86ad 100644 (file)
@@ -2,9 +2,9 @@
  * directx.c: Windows DirectX audio output method
  *****************************************************************************
  * Copyright (C) 2001 VideoLAN
- * $Id: directx.c,v 1.7 2002/11/01 15:43:55 gbazin Exp $
+ * $Id$
  *
- * Authors: Gildas Bazin <gbazin@netcourrier.com>
+ * Authors: Gildas Bazin <gbazin@videolan.org>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -39,7 +39,7 @@
 #include <dsound.h>
 
 #define FRAME_SIZE 2048              /* The size is in samples, not in bytes */
-#define FRAMES_NUM 4
+#define FRAMES_NUM 8
 
 /* frame buffer status */
 #define FRAME_QUEUED 0
@@ -60,6 +60,73 @@ DEFINE_GUID(IID_IDirectSoundNotify, 0xb0210783, 0x89cd, 0x11d0, 0xaf, 0x8, 0x0,
 #   define WAVE_FORMAT_IEEE_FLOAT 0x0003
 #endif
 
+#ifndef WAVE_FORMAT_DOLBY_AC3_SPDIF
+#   define WAVE_FORMAT_DOLBY_AC3_SPDIF 0x0092
+#endif
+
+#ifndef WAVE_FORMAT_EXTENSIBLE
+#define  WAVE_FORMAT_EXTENSIBLE   0xFFFE
+#endif
+
+#ifndef SPEAKER_FRONT_LEFT
+#   define SPEAKER_FRONT_LEFT             0x1
+#   define SPEAKER_FRONT_RIGHT            0x2
+#   define SPEAKER_FRONT_CENTER           0x4
+#   define SPEAKER_LOW_FREQUENCY          0x8
+#   define SPEAKER_BACK_LEFT              0x10
+#   define SPEAKER_BACK_RIGHT             0x20
+#   define SPEAKER_FRONT_LEFT_OF_CENTER   0x40
+#   define SPEAKER_FRONT_RIGHT_OF_CENTER  0x80
+#   define SPEAKER_BACK_CENTER            0x100
+#   define SPEAKER_SIDE_LEFT              0x200
+#   define SPEAKER_SIDE_RIGHT             0x400
+#   define SPEAKER_TOP_CENTER             0x800
+#   define SPEAKER_TOP_FRONT_LEFT         0x1000
+#   define SPEAKER_TOP_FRONT_CENTER       0x2000
+#   define SPEAKER_TOP_FRONT_RIGHT        0x4000
+#   define SPEAKER_TOP_BACK_LEFT          0x8000
+#   define SPEAKER_TOP_BACK_CENTER        0x10000
+#   define SPEAKER_TOP_BACK_RIGHT         0x20000
+#   define SPEAKER_RESERVED               0x80000000
+#endif
+
+#ifndef DSSPEAKER_HEADPHONE
+#   define DSSPEAKER_HEADPHONE         0x00000001
+#endif
+#ifndef DSSPEAKER_MONO
+#   define DSSPEAKER_MONO              0x00000002
+#endif
+#ifndef DSSPEAKER_QUAD
+#   define DSSPEAKER_QUAD              0x00000003
+#endif
+#ifndef DSSPEAKER_STEREO
+#   define DSSPEAKER_STEREO            0x00000004
+#endif
+#ifndef DSSPEAKER_SURROUND
+#   define DSSPEAKER_SURROUND          0x00000005
+#endif
+#ifndef DSSPEAKER_5POINT1
+#   define DSSPEAKER_5POINT1           0x00000006
+#endif
+
+#ifndef _WAVEFORMATEXTENSIBLE_
+typedef struct {
+    WAVEFORMATEX    Format;
+    union {
+        WORD wValidBitsPerSample;       /* bits of precision  */
+        WORD wSamplesPerBlock;          /* valid if wBitsPerSample==0 */
+        WORD wReserved;                 /* If neither applies, set to zero. */
+    } Samples;
+    DWORD           dwChannelMask;      /* which channels are */
+                                        /* present in stream  */
+    GUID            SubFormat;
+} WAVEFORMATEXTENSIBLE, *PWAVEFORMATEXTENSIBLE;
+#endif
+
+DEFINE_GUID( _KSDATAFORMAT_SUBTYPE_IEEE_FLOAT, WAVE_FORMAT_IEEE_FLOAT, 0x0000, 0x0010, 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71 );
+DEFINE_GUID( _KSDATAFORMAT_SUBTYPE_PCM, WAVE_FORMAT_PCM, 0x0000, 0x0010, 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71 );
+DEFINE_GUID( _KSDATAFORMAT_SUBTYPE_DOLBY_AC3_SPDIF, WAVE_FORMAT_DOLBY_AC3_SPDIF, 0x0000, 0x0010, 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71 );
+
 /*****************************************************************************
  * notification_thread_t: DirectX event thread
  *****************************************************************************/
@@ -84,46 +151,66 @@ typedef struct notification_thread_t
  *****************************************************************************/
 struct aout_sys_t
 {
+    HINSTANCE           hdsound_dll;      /* handle of the opened dsound dll */
     LPDIRECTSOUND       p_dsobject;              /* main Direct Sound object */
-
-    LPDIRECTSOUNDBUFFER p_dsbuffer_primary;     /* the actual sound card buffer
-                                                   (not used directly) */
-
     LPDIRECTSOUNDBUFFER p_dsbuffer;   /* the sound buffer we use (direct sound
                                        * takes care of mixing all the
                                        * secondary buffers into the primary) */
 
     LPDIRECTSOUNDNOTIFY p_dsnotify;         /* the position notify interface */
+    notification_thread_t *p_notif;                  /* DirectSoundThread id */
 
-    HINSTANCE           hdsound_dll;      /* handle of the opened dsound dll */
+    int b_playing;                                         /* playing status */
 
-    notification_thread_t * p_notif;                 /* DirectSoundThread id */
+    int i_frame_size;                         /* Size in bytes of one frame */
 
-    int b_playing;                                         /* playing status */
+    vlc_bool_t b_chan_reorder;              /* do we need channel reordering */
+    int pi_chan_table[AOUT_CHAN_MAX];
+    uint32_t i_channel_mask;
+    uint32_t i_bits_per_sample;
+    uint32_t i_channels;
 };
 
+static const uint32_t pi_channels_src[] =
+    { AOUT_CHAN_LEFT, AOUT_CHAN_RIGHT,
+      AOUT_CHAN_MIDDLELEFT, AOUT_CHAN_MIDDLERIGHT,
+      AOUT_CHAN_REARLEFT, AOUT_CHAN_REARRIGHT,
+      AOUT_CHAN_CENTER, AOUT_CHAN_LFE, 0 };
+static const uint32_t pi_channels_in[] =
+    { SPEAKER_FRONT_LEFT, SPEAKER_FRONT_RIGHT,
+      SPEAKER_SIDE_LEFT, SPEAKER_SIDE_RIGHT,
+      SPEAKER_BACK_LEFT, SPEAKER_BACK_RIGHT,
+      SPEAKER_FRONT_CENTER, SPEAKER_LOW_FREQUENCY, 0 };
+static const uint32_t pi_channels_out[] =
+    { SPEAKER_FRONT_LEFT, SPEAKER_FRONT_RIGHT,
+      SPEAKER_FRONT_CENTER, SPEAKER_LOW_FREQUENCY,
+      SPEAKER_BACK_LEFT, SPEAKER_BACK_RIGHT,
+      SPEAKER_SIDE_LEFT, SPEAKER_SIDE_RIGHT, 0 };
+
 /*****************************************************************************
  * Local prototypes.
  *****************************************************************************/
 static int  OpenAudio  ( vlc_object_t * );
 static void CloseAudio ( vlc_object_t * );
-
 static void Play       ( aout_instance_t * );
 
 /* local functions */
-static int  DirectxCreateSecondaryBuffer ( aout_instance_t * );
-static void DirectxDestroySecondaryBuffer( aout_instance_t * );
-static int  DirectxInitDSound            ( aout_instance_t * );
-static void DirectSoundThread            ( notification_thread_t * );
-static int  DirectxFillBuffer            ( aout_instance_t *, int,
-                                           aout_buffer_t * );
+static void Probe             ( aout_instance_t * );
+static int  InitDirectSound   ( aout_instance_t * );
+static int  CreateDSBuffer    ( aout_instance_t *, int, int, int, int, int, vlc_bool_t );
+static int  CreateDSBufferPCM ( aout_instance_t *, int*, int, int, int, vlc_bool_t );
+static void DestroyDSBuffer   ( aout_instance_t * );
+static void DirectSoundThread ( notification_thread_t * );
+static int  FillBuffer        ( aout_instance_t *, int, aout_buffer_t * );
 
 /*****************************************************************************
  * Module descriptor
  *****************************************************************************/
 vlc_module_begin();
-    set_description( _("DirectX audio module") );
+    set_description( _("DirectX audio output") );
     set_capability( "audio output", 100 );
+    set_category( CAT_AUDIO );
+    set_subcategory( SUBCAT_AUDIO_AOUT );
     add_shortcut( "directx" );
     set_callbacks( OpenAudio, CloseAudio );
 vlc_module_end();
@@ -136,11 +223,10 @@ vlc_module_end();
 static int OpenAudio( vlc_object_t *p_this )
 {
     aout_instance_t * p_aout = (aout_instance_t *)p_this;
-    HRESULT dsresult;
-    DSBUFFERDESC dsbuffer_desc;
+    vlc_value_t val;
     int i;
 
-    msg_Dbg( p_aout, "Open" );
+    msg_Dbg( p_aout, "OpenAudio" );
 
    /* Allocate structure */
     p_aout->output.p_sys = malloc( sizeof( aout_sys_t ) );
@@ -152,7 +238,6 @@ static int OpenAudio( vlc_object_t *p_this )
 
     /* Initialize some variables */
     p_aout->output.p_sys->p_dsobject = NULL;
-    p_aout->output.p_sys->p_dsbuffer_primary = NULL;
     p_aout->output.p_sys->p_dsbuffer = NULL;
     p_aout->output.p_sys->p_dsnotify = NULL;
     p_aout->output.p_sys->p_notif = NULL;
@@ -162,49 +247,108 @@ static int OpenAudio( vlc_object_t *p_this )
     aout_VolumeSoftInit( p_aout );
 
     /* Initialise DirectSound */
-    if( DirectxInitDSound( p_aout ) )
+    if( InitDirectSound( p_aout ) )
     {
         msg_Err( p_aout, "cannot initialize DirectSound" );
         goto error;
     }
 
-    /* Obtain (not create) Direct Sound primary buffer */
-    memset( &dsbuffer_desc, 0, sizeof(DSBUFFERDESC) );
-    dsbuffer_desc.dwSize = sizeof(DSBUFFERDESC);
-    dsbuffer_desc.dwFlags = DSBCAPS_PRIMARYBUFFER;
-    msg_Warn( p_aout, "create direct sound primary buffer" );
-    dsresult = IDirectSound_CreateSoundBuffer(p_aout->output.p_sys->p_dsobject,
-                                     &dsbuffer_desc,
-                                     &p_aout->output.p_sys->p_dsbuffer_primary,
-                                     NULL);
-    if( dsresult != DS_OK )
+    if( var_Type( p_aout, "audio-device" ) == 0 )
     {
-        msg_Err( p_aout, "cannot create direct sound primary buffer" );
+        Probe( p_aout );
+    }
+
+    if( var_Get( p_aout, "audio-device", &val ) < 0 )
+    {
+        /* Probe() has failed. */
         goto error;
     }
 
-    /* Now we need to setup DirectSound play notification */
+    /* Now we need to setup our DirectSound play notification structure */
     p_aout->output.p_sys->p_notif =
         vlc_object_create( p_aout, sizeof(notification_thread_t) );
     p_aout->output.p_sys->p_notif->p_aout = p_aout;
 
-    /* first we need to create the notification events */
+    /* Then create the notification events */
     for( i = 0; i < FRAMES_NUM; i++ )
         p_aout->output.p_sys->p_notif->p_events[i].hEventNotify =
             CreateEvent( NULL, FALSE, FALSE, NULL );
 
-    /* then create a new secondary buffer */
-    p_aout->output.output.i_format = VLC_FOURCC('f','l','3','2');
-    if( DirectxCreateSecondaryBuffer( p_aout ) )
+    /* Open the device */
+    if( val.i_int == AOUT_VAR_SPDIF )
     {
-        msg_Err( p_aout, "cannot create WAVE_FORMAT_IEEE_FLOAT buffer" );
+        p_aout->output.output.i_format = VLC_FOURCC('s','p','d','i');
+
+        /* Calculate the frame size in bytes */
+        p_aout->output.i_nb_samples = A52_FRAME_NB;
+        p_aout->output.output.i_bytes_per_frame = AOUT_SPDIF_SIZE;
+        p_aout->output.output.i_frame_length = A52_FRAME_NB;
+        p_aout->output.p_sys->i_frame_size =
+            p_aout->output.output.i_bytes_per_frame;
+
+        if( CreateDSBuffer( p_aout, VLC_FOURCC('s','p','d','i'),
+                            p_aout->output.output.i_physical_channels,
+                            aout_FormatNbChannels( &p_aout->output.output ),
+                            p_aout->output.output.i_rate,
+                            p_aout->output.p_sys->i_frame_size, VLC_FALSE )
+            != VLC_SUCCESS )
+        {
+            msg_Err( p_aout, "cannot open directx audio device" );
+            free( p_aout->output.p_sys );
+            return VLC_EGENERIC;
+        }
 
-        p_aout->output.output.i_format = VLC_FOURCC('s','1','6','l');
-        if( DirectxCreateSecondaryBuffer( p_aout ) )
+        aout_VolumeNoneInit( p_aout );
+    }
+    else
+    {
+        if( val.i_int == AOUT_VAR_5_1 )
+        {
+            p_aout->output.output.i_physical_channels
+                = AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER
+                   | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT
+                   | AOUT_CHAN_LFE;
+        }
+        else if( val.i_int == AOUT_VAR_3F2R )
+        {
+            p_aout->output.output.i_physical_channels
+                = AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER
+                   | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT;
+        }
+        else if( val.i_int == AOUT_VAR_2F2R )
+        {
+            p_aout->output.output.i_physical_channels
+                = AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT
+                   | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT;
+        }
+        else if( val.i_int == AOUT_VAR_MONO )
         {
-            msg_Err( p_aout, "cannot create WAVE_FORMAT_PCM buffer" );
-            return 1;
+            p_aout->output.output.i_physical_channels = AOUT_CHAN_CENTER;
         }
+        else
+        {
+            p_aout->output.output.i_physical_channels
+                = AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT;
+        }
+
+        if( CreateDSBufferPCM( p_aout, &p_aout->output.output.i_format,
+                               p_aout->output.output.i_physical_channels,
+                               aout_FormatNbChannels( &p_aout->output.output ),
+                               p_aout->output.output.i_rate, VLC_FALSE )
+            != VLC_SUCCESS )
+        {
+            msg_Err( p_aout, "cannot open directx audio device" );
+            free( p_aout->output.p_sys );
+            return VLC_EGENERIC;
+        }
+
+        /* Calculate the frame size in bytes */
+        p_aout->output.i_nb_samples = FRAME_SIZE;
+        aout_FormatPrepare( &p_aout->output.output );
+        p_aout->output.p_sys->i_frame_size =
+            FRAME_SIZE * p_aout->output.output.i_bytes_per_frame;
+
+        aout_VolumeSoftInit( p_aout );
     }
 
     /* then launch the notification thread */
@@ -212,7 +356,7 @@ static int OpenAudio( vlc_object_t *p_this )
     if( vlc_thread_create( p_aout->output.p_sys->p_notif,
                            "DirectSound Notification Thread",
                            DirectSoundThread,
-                           THREAD_PRIORITY_TIME_CRITICAL, 1 ) )
+                           VLC_THREAD_PRIORITY_HIGHEST, VLC_FALSE ) )
     {
         msg_Err( p_aout, "cannot create DirectSoundThread" );
         goto error;
@@ -220,13 +364,169 @@ static int OpenAudio( vlc_object_t *p_this )
 
     vlc_object_attach( p_aout->output.p_sys->p_notif, p_aout );
 
-    return 0;
+    return VLC_SUCCESS;
 
  error:
     CloseAudio( VLC_OBJECT(p_aout) );
     return VLC_EGENERIC;
 }
 
+/*****************************************************************************
+ * Probe: probe the audio device for available formats and channels
+ *****************************************************************************/
+static void Probe( aout_instance_t * p_aout )
+{
+    vlc_value_t val, text;
+    int i_format;
+    unsigned int i_physical_channels;
+    DWORD ui_speaker_config;
+
+    var_Create( p_aout, "audio-device", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE );
+    text.psz_string = _("Audio Device");
+    var_Change( p_aout, "audio-device", VLC_VAR_SETTEXT, &text, NULL );
+
+    /* Test for 5.1 support */
+    i_physical_channels = AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT |
+                          AOUT_CHAN_CENTER | AOUT_CHAN_REARLEFT |
+                          AOUT_CHAN_REARRIGHT | AOUT_CHAN_LFE;
+    if( p_aout->output.output.i_physical_channels == i_physical_channels )
+    {
+        if( CreateDSBufferPCM( p_aout, &i_format, i_physical_channels, 6,
+                               p_aout->output.output.i_rate, VLC_TRUE )
+            == VLC_SUCCESS )
+        {
+            val.i_int = AOUT_VAR_5_1;
+            text.psz_string = N_("5.1");
+            var_Change( p_aout, "audio-device",
+                        VLC_VAR_ADDCHOICE, &val, &text );
+            msg_Dbg( p_aout, "device supports 5.1 channels" );
+        }
+    }
+
+    /* Test for 3 Front 2 Rear support */
+    i_physical_channels = AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT |
+                          AOUT_CHAN_CENTER | AOUT_CHAN_REARLEFT |
+                          AOUT_CHAN_REARRIGHT;
+    if( p_aout->output.output.i_physical_channels == i_physical_channels )
+    {
+        if( CreateDSBufferPCM( p_aout, &i_format, i_physical_channels, 5,
+                               p_aout->output.output.i_rate, VLC_TRUE )
+            == VLC_SUCCESS )
+        {
+            val.i_int = AOUT_VAR_3F2R;
+            text.psz_string = N_("3 Front 2 Rear");
+            var_Change( p_aout, "audio-device",
+                        VLC_VAR_ADDCHOICE, &val, &text );
+            msg_Dbg( p_aout, "device supports 5 channels" );
+        }
+    }
+
+    /* Test for 2 Front 2 Rear support */
+    i_physical_channels = AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT |
+                          AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT;
+    if( ( p_aout->output.output.i_physical_channels & i_physical_channels )
+        == i_physical_channels )
+    {
+        if( CreateDSBufferPCM( p_aout, &i_format, i_physical_channels, 4,
+                               p_aout->output.output.i_rate, VLC_TRUE )
+            == VLC_SUCCESS )
+        {
+            val.i_int = AOUT_VAR_2F2R;
+            text.psz_string = N_("2 Front 2 Rear");
+            var_Change( p_aout, "audio-device",
+                        VLC_VAR_ADDCHOICE, &val, &text );
+            msg_Dbg( p_aout, "device supports 4 channels" );
+        }
+    }
+
+    /* Test for stereo support */
+    i_physical_channels = AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT;
+    if( CreateDSBufferPCM( p_aout, &i_format, i_physical_channels, 2,
+                           p_aout->output.output.i_rate, VLC_TRUE )
+        == VLC_SUCCESS )
+    {
+        val.i_int = AOUT_VAR_STEREO;
+        text.psz_string = N_("Stereo");
+        var_Change( p_aout, "audio-device", VLC_VAR_ADDCHOICE, &val, &text );
+        var_Change( p_aout, "audio-device", VLC_VAR_SETDEFAULT, &val, NULL );
+        msg_Dbg( p_aout, "device supports 2 channels" );
+    }
+
+    /* Test for mono support */
+    i_physical_channels = AOUT_CHAN_CENTER;
+    if( CreateDSBufferPCM( p_aout, &i_format, i_physical_channels, 1,
+                           p_aout->output.output.i_rate, VLC_TRUE )
+        == VLC_SUCCESS )
+    {
+        val.i_int = AOUT_VAR_MONO;
+        text.psz_string = N_("Mono");
+        var_Change( p_aout, "audio-device", VLC_VAR_ADDCHOICE, &val, &text );
+        msg_Dbg( p_aout, "device supports 1 channel" );
+    }
+
+    /* Check the speaker configuration to determine which channel config should
+     * be the default */
+    if FAILED( IDirectSound_GetSpeakerConfig( p_aout->output.p_sys->p_dsobject,
+                                              &ui_speaker_config ) )
+    {
+        ui_speaker_config = DSSPEAKER_STEREO;
+    }
+    switch( DSSPEAKER_CONFIG(ui_speaker_config) )
+    {
+    case DSSPEAKER_5POINT1:
+        val.i_int = AOUT_VAR_5_1;
+        break;
+    case DSSPEAKER_QUAD:
+        val.i_int = AOUT_VAR_2F2R;
+        break;
+#if 0 /* Lots of people just get their settings wrong and complain that
+       * this is a problem with VLC so just don't ever set mono by default. */
+    case DSSPEAKER_MONO:
+        val.i_int = AOUT_VAR_MONO;
+        break;
+#endif
+    case DSSPEAKER_SURROUND:
+    case DSSPEAKER_STEREO:
+    default:
+        val.i_int = AOUT_VAR_STEREO;
+        break;
+    }
+    var_Set( p_aout, "audio-device", val );
+
+    /* Test for SPDIF support */
+    if ( AOUT_FMT_NON_LINEAR( &p_aout->output.output ) )
+    {
+        if( CreateDSBuffer( p_aout, VLC_FOURCC('s','p','d','i'),
+                            p_aout->output.output.i_physical_channels,
+                            aout_FormatNbChannels( &p_aout->output.output ),
+                            p_aout->output.output.i_rate,
+                            AOUT_SPDIF_SIZE, VLC_TRUE )
+            == VLC_SUCCESS )
+        {
+            msg_Dbg( p_aout, "device supports A/52 over S/PDIF" );
+            val.i_int = AOUT_VAR_SPDIF;
+            text.psz_string = N_("A/52 over S/PDIF");
+            var_Change( p_aout, "audio-device",
+                        VLC_VAR_ADDCHOICE, &val, &text );
+            if( config_GetInt( p_aout, "spdif" ) )
+                var_Set( p_aout, "audio-device", val );
+        }
+    }
+
+    var_Change( p_aout, "audio-device", VLC_VAR_CHOICESCOUNT, &val, NULL );
+    if( val.i_int <= 0 )
+    {
+        /* Probe() has failed. */
+        var_Destroy( p_aout, "audio-device" );
+        return;
+    }
+
+    var_AddCallback( p_aout, "audio-device", aout_ChannelsRestart, NULL );
+
+    val.b_bool = VLC_TRUE;
+    var_Set( p_aout, "intf-change", val );
+}
+
 /*****************************************************************************
  * Play: we'll start playing the directsound buffer here because at least here
  *       we know the first buffer has been put in the aout fifo and we also
@@ -246,7 +546,7 @@ static void Play( aout_instance_t *p_aout )
 
         /* fill in the first samples */
         p_buffer = aout_FifoPop( p_aout, &p_aout->output.fifo );
-        DirectxFillBuffer( p_aout, 0, p_buffer );
+        FillBuffer( p_aout, 0, p_buffer );
 
         /* wake up the audio output thread */
         SetEvent( p_aout->output.p_sys->p_notif->p_events[0].hEventNotify );
@@ -259,49 +559,43 @@ static void Play( aout_instance_t *p_aout )
 static void CloseAudio( vlc_object_t *p_this )
 {
     aout_instance_t * p_aout = (aout_instance_t *)p_this;
+    aout_sys_t *p_sys = p_aout->output.p_sys;
 
-    msg_Dbg( p_aout, "Close" );
+    msg_Dbg( p_aout, "CloseAudio" );
 
     /* kill the position notification thread, if any */
-    if( p_aout->output.p_sys->p_notif )
+    if( p_sys->p_notif )
     {
-        vlc_object_detach( p_aout->output.p_sys->p_notif );
-        if( p_aout->output.p_sys->p_notif->b_thread )
+        vlc_object_detach( p_sys->p_notif );
+        if( p_sys->p_notif->b_thread )
         {
-            p_aout->output.p_sys->p_notif->b_die = 1;
+            p_sys->p_notif->b_die = 1;
 
-            if( !p_aout->output.p_sys->b_playing )
+            if( !p_sys->b_playing )
                 /* wake up the audio thread */
-                SetEvent(
-                    p_aout->output.p_sys->p_notif->p_events[0].hEventNotify );
+                SetEvent( p_sys->p_notif->p_events[0].hEventNotify );
 
-            vlc_thread_join( p_aout->output.p_sys->p_notif );
+            vlc_thread_join( p_sys->p_notif );
         }
-        vlc_object_destroy( p_aout->output.p_sys->p_notif );
+        vlc_object_destroy( p_sys->p_notif );
     }
 
     /* release the secondary buffer */
-    DirectxDestroySecondaryBuffer( p_aout );
-
-    /* then release the primary buffer */
-    if( p_aout->output.p_sys->p_dsbuffer_primary )
-        IDirectSoundBuffer_Release( p_aout->output.p_sys->p_dsbuffer_primary );
+    DestroyDSBuffer( p_aout );
 
     /* finally release the DirectSound object */
-    if( p_aout->output.p_sys->p_dsobject )
-        IDirectSound_Release( p_aout->output.p_sys->p_dsobject );
+    if( p_sys->p_dsobject ) IDirectSound_Release( p_sys->p_dsobject );
     
     /* free DSOUND.DLL */
-    if( p_aout->output.p_sys->hdsound_dll )
-       FreeLibrary( p_aout->output.p_sys->hdsound_dll );
+    if( p_sys->hdsound_dll ) FreeLibrary( p_sys->hdsound_dll );
 
-    free( p_aout->output.p_sys );
+    free( p_sys );
 }
 
 /*****************************************************************************
- * DirectxInitDSound: handle all the gory details of DirectSound initialisation
+ * InitDirectSound: handle all the gory details of DirectSound initialisation
  *****************************************************************************/
-static int DirectxInitDSound( aout_instance_t *p_aout )
+static int InitDirectSound( aout_instance_t *p_aout )
 {
     HRESULT (WINAPI *OurDirectSoundCreate)(LPGUID, LPDIRECTSOUND *, LPUNKNOWN);
 
@@ -322,8 +616,8 @@ static int DirectxInitDSound( aout_instance_t *p_aout )
     }
 
     /* Create the direct sound object */
-    if( OurDirectSoundCreate( NULL, &p_aout->output.p_sys->p_dsobject, NULL )
-        != DS_OK )
+    if FAILED( OurDirectSoundCreate( NULL, &p_aout->output.p_sys->p_dsobject,
+                                     NULL ) )
     {
         msg_Warn( p_aout, "cannot create a direct sound device" );
         goto error;
@@ -346,7 +640,7 @@ static int DirectxInitDSound( aout_instance_t *p_aout )
         msg_Warn( p_aout, "cannot set direct sound cooperative level" );
     }
 
-    return 0;
+    return VLC_SUCCESS;
 
  error:
     p_aout->output.p_sys->p_dsobject = NULL;
@@ -355,12 +649,12 @@ static int DirectxInitDSound( aout_instance_t *p_aout )
         FreeLibrary( p_aout->output.p_sys->hdsound_dll );
         p_aout->output.p_sys->hdsound_dll = NULL;
     }
-    return 1;
+    return VLC_EGENERIC;
 
 }
 
 /*****************************************************************************
- * DirectxCreateSecondaryBuffer
+ * CreateDSBuffer: Creates a direct sound buffer of the required format.
  *****************************************************************************
  * This function creates the buffer we'll use to play audio.
  * In DirectSound there are two kinds of buffers:
@@ -369,73 +663,122 @@ static int DirectxInitDSound( aout_instance_t *p_aout )
  *    applications and DirectSound takes care of mixing them into the primary.
  *
  * Once you create a secondary buffer, you cannot change its format anymore so
- * you have to release the current and create another one.
+ * you have to release the current one and create another.
  *****************************************************************************/
-static int DirectxCreateSecondaryBuffer( aout_instance_t *p_aout )
+static int CreateDSBuffer( aout_instance_t *p_aout, int i_format,
+                           int i_channels, int i_nb_channels, int i_rate,
+                           int i_bytes_per_frame, vlc_bool_t b_probe )
 {
-    WAVEFORMATEX         waveformat;
+    WAVEFORMATEXTENSIBLE waveformat;
     DSBUFFERDESC         dsbdesc;
-    DSBCAPS              dsbcaps;
-    int                  i_nb_channels, i;
+    unsigned int         i;
 
-    i_nb_channels = aout_FormatNbChannels( &p_aout->output.output );
-    if ( i_nb_channels > 2 )
+    /* First set the sound buffer format */
+    waveformat.dwChannelMask = 0;
+    for( i = 0; i < sizeof(pi_channels_src)/sizeof(uint32_t); i++ )
     {
-        i_nb_channels = 2;
-        p_aout->output.output.i_channels = AOUT_CHAN_STEREO;
+        if( i_channels & pi_channels_src[i] )
+            waveformat.dwChannelMask |= pi_channels_in[i];
     }
 
-    /* First set the buffer format */
-    memset( &waveformat, 0, sizeof(WAVEFORMATEX) );
-    switch( p_aout->output.output.i_format )
+    switch( i_format )
     {
-    case VLC_FOURCC('s','1','6','l'):
-        waveformat.wFormatTag     = WAVE_FORMAT_PCM;
-        waveformat.wBitsPerSample = 16;
+    case VLC_FOURCC('s','p','d','i'):
+        i_nb_channels = 2;
+        /* To prevent channel re-ordering */
+        waveformat.dwChannelMask = SPEAKER_FRONT_LEFT | SPEAKER_FRONT_RIGHT;
+        waveformat.Format.wBitsPerSample = 16;
+        waveformat.Samples.wValidBitsPerSample =
+            waveformat.Format.wBitsPerSample;
+        waveformat.Format.wFormatTag = WAVE_FORMAT_DOLBY_AC3_SPDIF;
+        waveformat.SubFormat = _KSDATAFORMAT_SUBTYPE_DOLBY_AC3_SPDIF;
         break;
+
     case VLC_FOURCC('f','l','3','2'):
-        waveformat.wFormatTag     = WAVE_FORMAT_IEEE_FLOAT;
-        waveformat.wBitsPerSample = sizeof(float) * 8;
+        waveformat.Format.wBitsPerSample = sizeof(float) * 8;
+        waveformat.Samples.wValidBitsPerSample =
+            waveformat.Format.wBitsPerSample;
+        waveformat.Format.wFormatTag = WAVE_FORMAT_IEEE_FLOAT;
+        waveformat.SubFormat = _KSDATAFORMAT_SUBTYPE_IEEE_FLOAT;
+        break;
+
+    case VLC_FOURCC('s','1','6','l'):
+        waveformat.Format.wBitsPerSample = 16;
+        waveformat.Samples.wValidBitsPerSample =
+            waveformat.Format.wBitsPerSample;
+        waveformat.Format.wFormatTag = WAVE_FORMAT_PCM;
+        waveformat.SubFormat = _KSDATAFORMAT_SUBTYPE_PCM;
         break;
     }
-    waveformat.nChannels       = i_nb_channels;
-    waveformat.nSamplesPerSec  = p_aout->output.output.i_rate;
-    waveformat.nBlockAlign     = waveformat.wBitsPerSample / 8 *
-                                 waveformat.nChannels;
-    waveformat.nAvgBytesPerSec = waveformat.nSamplesPerSec *
-                                     waveformat.nBlockAlign;
 
-    aout_FormatPrepare( &p_aout->output.output );
+    waveformat.Format.nChannels = i_nb_channels;
+    waveformat.Format.nSamplesPerSec = i_rate;
+    waveformat.Format.nBlockAlign =
+        waveformat.Format.wBitsPerSample / 8 * i_nb_channels;
+    waveformat.Format.nAvgBytesPerSec =
+        waveformat.Format.nSamplesPerSec * waveformat.Format.nBlockAlign;
+
+    p_aout->output.p_sys->i_bits_per_sample = waveformat.Format.wBitsPerSample;
+    p_aout->output.p_sys->i_channels = i_nb_channels;
 
-    /* Then fill in the descriptor */
+    /* Then fill in the direct sound descriptor */
     memset(&dsbdesc, 0, sizeof(DSBUFFERDESC));
     dsbdesc.dwSize = sizeof(DSBUFFERDESC);
     dsbdesc.dwFlags = DSBCAPS_GETCURRENTPOSITION2/* Better position accuracy */
                     | DSBCAPS_CTRLPOSITIONNOTIFY     /* We need notification */
                     | DSBCAPS_GLOBALFOCUS;      /* Allows background playing */
-    dsbdesc.dwBufferBytes = FRAME_SIZE * FRAMES_NUM           /* buffer size */
-                            * p_aout->output.output.i_bytes_per_frame;
-    dsbdesc.lpwfxFormat = &waveformat;
-    if( IDirectSound_CreateSoundBuffer( p_aout->output.p_sys->p_dsobject,
-                                        &dsbdesc,
-                                        &p_aout->output.p_sys->p_dsbuffer,
-                                        NULL) != DS_OK )
-    {
-        msg_Warn( p_aout, "cannot create direct sound secondary buffer" );
-        goto error;
+
+    /* Only use the new WAVE_FORMAT_EXTENSIBLE format for multichannel audio */
+    if( i_nb_channels <= 2 )
+    {
+        waveformat.Format.cbSize = 0;
     }
+    else
+    {
+        waveformat.Format.wFormatTag = WAVE_FORMAT_EXTENSIBLE;
+        waveformat.Format.cbSize =
+            sizeof(WAVEFORMATEXTENSIBLE) - sizeof(WAVEFORMATEX);
 
-    /* backup the size of a frame */
-    p_aout->output.p_sys->p_notif->i_frame_size = FRAME_SIZE *
-        p_aout->output.output.i_bytes_per_frame;
+        /* Needed for 5.1 on emu101k */
+        dsbdesc.dwFlags |= DSBCAPS_LOCHARDWARE;
+    }
 
-    memset(&dsbcaps, 0, sizeof(DSBCAPS));
-    dsbcaps.dwSize = sizeof(DSBCAPS);
-    IDirectSoundBuffer_GetCaps( p_aout->output.p_sys->p_dsbuffer, &dsbcaps  );
-    msg_Dbg( p_aout, "requested %li bytes buffer and got %li bytes.",
-             FRAMES_NUM * p_aout->output.p_sys->p_notif->i_frame_size,
-             dsbcaps.dwBufferBytes );
+    dsbdesc.dwBufferBytes = FRAMES_NUM * i_bytes_per_frame;   /* buffer size */
+    dsbdesc.lpwfxFormat = (WAVEFORMATEX *)&waveformat;
+
+    if FAILED( IDirectSound_CreateSoundBuffer(
+                   p_aout->output.p_sys->p_dsobject, &dsbdesc,
+                   &p_aout->output.p_sys->p_dsbuffer, NULL) )
+    {
+        if( dsbdesc.dwFlags & DSBCAPS_LOCHARDWARE )
+        {
+            /* Try without DSBCAPS_LOCHARDWARE */
+            dsbdesc.dwFlags &= ~DSBCAPS_LOCHARDWARE;
+            if FAILED( IDirectSound_CreateSoundBuffer(
+                   p_aout->output.p_sys->p_dsobject, &dsbdesc,
+                   &p_aout->output.p_sys->p_dsbuffer, NULL) )
+            {
+                return VLC_EGENERIC;
+            }
+            if( !b_probe )
+                msg_Dbg( p_aout, "couldn't use hardware sound buffer" );
+        }
+        else
+        {
+            return VLC_EGENERIC;
+        }
+    }
+
+    /* Stop here if we were just probing */
+    if( b_probe )
+    {
+        IDirectSoundBuffer_Release( p_aout->output.p_sys->p_dsbuffer );
+        p_aout->output.p_sys->p_dsbuffer = NULL;
+        return VLC_SUCCESS;
+    }
+
+    /* Backup the size of a frame */
+    p_aout->output.p_sys->p_notif->i_frame_size = i_bytes_per_frame;
 
     /* Now the secondary buffer is created, we need to setup its position
      * notification */
@@ -453,48 +796,83 @@ static int DirectxCreateSecondaryBuffer( aout_instance_t *p_aout )
                                 &IID_IDirectSoundNotify,
                                 (LPVOID *)&p_aout->output.p_sys->p_dsnotify ) )
     {
-        msg_Err( p_aout, "cannot get Notify interface" );
+        msg_Err( p_aout, "cannot get IDirectSoundNotify interface" );
         goto error;
     }
-        
+
     if FAILED( IDirectSoundNotify_SetNotificationPositions(
                                     p_aout->output.p_sys->p_dsnotify,
                                     FRAMES_NUM,
                                     p_aout->output.p_sys->p_notif->p_events ) )
     {
-        msg_Err( p_aout, "cannot set position Notification" );
+        msg_Err( p_aout, "cannot set position notification" );
         goto error;
     }
 
-    p_aout->output.i_nb_samples = FRAME_SIZE;
+    p_aout->output.p_sys->i_channel_mask = waveformat.dwChannelMask;
+
+    p_aout->output.p_sys->b_chan_reorder =
+        aout_CheckChannelReorder( pi_channels_in, pi_channels_out,
+                                  waveformat.dwChannelMask, i_nb_channels,
+                                  p_aout->output.p_sys->pi_chan_table );
 
-    return 0;
+    if( p_aout->output.p_sys->b_chan_reorder )
+    {
+        msg_Dbg( p_aout, "channel reordering needed" );
+    }
+
+    return VLC_SUCCESS;
 
  error:
-    if( p_aout->output.p_sys->p_dsbuffer )
+    DestroyDSBuffer( p_aout );
+    return VLC_EGENERIC;
+}
+
+/*****************************************************************************
+ * CreateDSBufferPCM: creates a PCM direct sound buffer.
+ *****************************************************************************
+ * We first try to create a WAVE_FORMAT_IEEE_FLOAT buffer if supported by
+ * the hardware, otherwise we create a WAVE_FORMAT_PCM buffer.
+ ****************************************************************************/
+static int CreateDSBufferPCM( aout_instance_t *p_aout, int *i_format,
+                              int i_channels, int i_nb_channels, int i_rate,
+                              vlc_bool_t b_probe )
+{
+    /* Float32 audio samples are not supported for 5.1 output on the emu101k */
+
+    if( i_nb_channels > 2 ||
+        CreateDSBuffer( p_aout, VLC_FOURCC('f','l','3','2'),
+                        i_channels, i_nb_channels, i_rate,
+                        FRAME_SIZE * 4 * i_nb_channels, b_probe )
+        != VLC_SUCCESS )
     {
-        IDirectSoundBuffer_Release( p_aout->output.p_sys->p_dsbuffer );
-        p_aout->output.p_sys->p_dsbuffer = NULL;
+        if ( CreateDSBuffer( p_aout, VLC_FOURCC('s','1','6','l'),
+                             i_channels, i_nb_channels, i_rate,
+                             FRAME_SIZE * 2 * i_nb_channels, b_probe )
+             != VLC_SUCCESS )
+        {
+            return VLC_EGENERIC;
+        }
+        else
+        {
+            *i_format = VLC_FOURCC('s','1','6','l');
+            return VLC_SUCCESS;
+        }
     }
-    if( p_aout->output.p_sys->p_dsnotify )
+    else
     {
-        IDirectSoundBuffer_Release( p_aout->output.p_sys->p_dsbuffer );
-        p_aout->output.p_sys->p_dsnotify = NULL;
+        *i_format = VLC_FOURCC('f','l','3','2');
+        return VLC_SUCCESS;
     }
-    return VLC_EGENERIC;
 }
 
 /*****************************************************************************
- * DirectxCreateSecondaryBuffer
+ * DestroyDSBuffer
  *****************************************************************************
  * This function destroys the secondary buffer.
  *****************************************************************************/
-static void DirectxDestroySecondaryBuffer( aout_instance_t *p_aout )
+static void DestroyDSBuffer( aout_instance_t *p_aout )
 {
-    /* make sure the buffer isn't playing */
-    if( p_aout->output.p_sys->p_dsbuffer )
-        IDirectSoundBuffer_Stop( p_aout->output.p_sys->p_dsbuffer );
-
     if( p_aout->output.p_sys->p_dsnotify )
     {
         IDirectSoundNotify_Release( p_aout->output.p_sys->p_dsnotify );
@@ -509,21 +887,22 @@ static void DirectxDestroySecondaryBuffer( aout_instance_t *p_aout )
 }
 
 /*****************************************************************************
- * DirectxFillBuffer: Fill in one of the direct sound frame buffers.
+ * FillBuffer: Fill in one of the direct sound frame buffers.
  *****************************************************************************
  * Returns VLC_SUCCESS on success.
  *****************************************************************************/
-static int DirectxFillBuffer( aout_instance_t *p_aout, int i_frame,
-                              aout_buffer_t *p_buffer )
+static int FillBuffer( aout_instance_t *p_aout, int i_frame,
+                       aout_buffer_t *p_buffer )
 {
     notification_thread_t *p_notif = p_aout->output.p_sys->p_notif;
+    aout_sys_t *p_sys = p_aout->output.p_sys;
     void *p_write_position, *p_wrap_around;
     long l_bytes1, l_bytes2;
     HRESULT dsresult;
 
     /* Before copying anything, we have to lock the buffer */
     dsresult = IDirectSoundBuffer_Lock(
-                p_aout->output.p_sys->p_dsbuffer,               /* DS buffer */
+                p_sys->p_dsbuffer,                              /* DS buffer */
                 i_frame * p_notif->i_frame_size,             /* Start offset */
                 p_notif->i_frame_size,                    /* Number of bytes */
                 &p_write_position,                  /* Address of lock start */
@@ -533,9 +912,9 @@ static int DirectxFillBuffer( aout_instance_t *p_aout, int i_frame,
                 0 );                                                /* Flags */
     if( dsresult == DSERR_BUFFERLOST )
     {
-        IDirectSoundBuffer_Restore( p_aout->output.p_sys->p_dsbuffer );
+        IDirectSoundBuffer_Restore( p_sys->p_dsbuffer );
         dsresult = IDirectSoundBuffer_Lock(
-                               p_aout->output.p_sys->p_dsbuffer,
+                               p_sys->p_dsbuffer,
                                i_frame * p_notif->i_frame_size,
                                p_notif->i_frame_size,
                                &p_write_position,
@@ -551,18 +930,27 @@ static int DirectxFillBuffer( aout_instance_t *p_aout, int i_frame,
         return VLC_EGENERIC;
     }
 
-    if ( p_buffer != NULL )
+    if( p_buffer == NULL )
     {
+        memset( p_write_position, 0, l_bytes1 );
+    }
+    else
+    {
+        if( p_sys->b_chan_reorder )
+        {
+            /* Do the channel reordering here */
+            aout_ChannelReorder( p_buffer->p_buffer, p_buffer->i_nb_bytes,
+                                 p_sys->i_channels, p_sys->pi_chan_table,
+                                 p_sys->i_bits_per_sample );
+        }
+
         p_aout->p_vlc->pf_memcpy( p_write_position, p_buffer->p_buffer,
                                   l_bytes1 );
         aout_BufferFree( p_buffer );
     }
-    else
-        memset( p_write_position, 0, l_bytes1 );
 
     /* Now the data has been copied, unlock the buffer */
-    IDirectSoundBuffer_Unlock( p_aout->output.p_sys->p_dsbuffer,
-                               p_write_position, l_bytes1,
+    IDirectSoundBuffer_Unlock( p_sys->p_dsbuffer, p_write_position, l_bytes1,
                                p_wrap_around, l_bytes2 );
 
     return VLC_SUCCESS;
@@ -581,10 +969,14 @@ static void DirectSoundThread( notification_thread_t *p_notif )
     aout_instance_t *p_aout = p_notif->p_aout;
     int i, i_which_frame, i_last_frame, i_next_frame;
     mtime_t mtime;
+    vlc_bool_t b_sleek;
 
     for( i = 0; i < FRAMES_NUM; i++ )
         notification_events[i] = p_notif->p_events[i].hEventNotify;
 
+    /* We don't want any resampling when using S/PDIF output */
+    b_sleek = p_aout->output.output.i_format == VLC_FOURCC('s','p','d','i');
+
     /* Tell the main thread that we are ready */
     vlc_thread_ready( p_notif );
 
@@ -633,9 +1025,9 @@ static void DirectSoundThread( notification_thread_t *p_notif )
         mtime = mdate();
 
         /* We take into account the current latency */
-        if( IDirectSoundBuffer_GetCurrentPosition(
-                p_aout->output.p_sys->p_dsbuffer,
-                &l_latency, NULL ) == DS_OK )
+        if SUCCEEDED( IDirectSoundBuffer_GetCurrentPosition(
+                        p_aout->output.p_sys->p_dsbuffer,
+                        &l_latency, NULL ) )
         {
             if( l_latency > (i_which_frame * FRAME_SIZE)
                   && l_latency < ((i_which_frame+1) * FRAME_SIZE) )
@@ -671,7 +1063,7 @@ static void DirectSoundThread( notification_thread_t *p_notif )
 
             p_buffer = aout_OutputNextBuffer( p_aout,
                 mtime + 1000000 / p_aout->output.output.i_rate *
-                ((i - i_next_frame + 1) * FRAME_SIZE + l_latency), VLC_FALSE );
+                ((i - i_next_frame + 1) * FRAME_SIZE + l_latency), b_sleek );
 
             /* If there is no audio data available and we have some buffered
              * already, then just wait for the next time */
@@ -682,7 +1074,7 @@ static void DirectSoundThread( notification_thread_t *p_notif )
                 break;
             }
 
-            if( DirectxFillBuffer( p_aout, (i%FRAMES_NUM), p_buffer )
+            if( FillBuffer( p_aout, (i%FRAMES_NUM), p_buffer )
                 != VLC_SUCCESS )
                 break;
 
@@ -692,6 +1084,9 @@ static void DirectSoundThread( notification_thread_t *p_notif )
 
     }
 
+    /* make sure the buffer isn't playing */
+    IDirectSoundBuffer_Stop( p_aout->output.p_sys->p_dsbuffer );
+
     /* free the events */
     for( i = 0; i < FRAMES_NUM; i++ )
         CloseHandle( notification_events[i] );