]> git.sesse.net Git - vlc/blobdiff - modules/codec/subsusf.c
MKV: remove unused parameter
[vlc] / modules / codec / subsusf.c
index 2662ccf4a148aa97112b7ebf546060d530d2d4e2..80db2bd50e97dfc79453a38a54d10ebc0c410c56 100644 (file)
 #ifdef HAVE_CONFIG_H
 # include "config.h"
 #endif
+#include <assert.h>
 
-#include "subsdec.h"
+#include <vlc_common.h>
 #include <vlc_plugin.h>
 #include <vlc_modules.h>
-#include <assert.h>
+#include <vlc_codec.h>
+#include <vlc_input.h>
+#include <vlc_charset.h>
+#include <vlc_image.h>
+#include <vlc_xml.h>
+#include <vlc_stream.h>
 
 /*****************************************************************************
- * Local prototypes
+ * Module descriptor.
  *****************************************************************************/
 static int  OpenDecoder   ( vlc_object_t * );
 static void CloseDecoder  ( vlc_object_t * );
 
-static subpicture_t *DecodeBlock   ( decoder_t *, block_t ** );
-static char         *CreatePlainText( char * );
-static int           ParseImageAttachments( decoder_t *p_dec );
-
-static subpicture_t        *ParseText     ( decoder_t *, block_t * );
-static void                 ParseUSFHeader( decoder_t * );
-static subpicture_region_t *ParseUSFString( decoder_t *, char * );
-static subpicture_region_t *LoadEmbeddedImage( decoder_t *p_dec, const char *psz_filename, int i_transparent_color );
-
-/*****************************************************************************
- * Module descriptor.
- *****************************************************************************/
-
 vlc_module_begin ()
     set_capability( "decoder", 40 )
     set_shortname( N_("USFSubs"))
@@ -58,6 +51,58 @@ vlc_module_begin ()
     /* We inherit subsdec-align and subsdec-formatted from subsdec.c */
 vlc_module_end ()
 
+
+/*****************************************************************************
+ * Local prototypes
+ *****************************************************************************/
+enum
+{
+    ATTRIBUTE_ALIGNMENT = (1 << 0),
+    ATTRIBUTE_X         = (1 << 1),
+    ATTRIBUTE_X_PERCENT = (1 << 2),
+    ATTRIBUTE_Y         = (1 << 3),
+    ATTRIBUTE_Y_PERCENT = (1 << 4),
+};
+
+typedef struct
+{
+    char       *psz_filename;
+    picture_t  *p_pic;
+} image_attach_t;
+
+typedef struct
+{
+    char *          psz_stylename; /* The name of the style, no comma's allowed */
+    text_style_t    font_style;
+    int             i_align;
+    int             i_margin_h;
+    int             i_margin_v;
+    int             i_margin_percent_h;
+    int             i_margin_percent_v;
+}  ssa_style_t;
+
+struct decoder_sys_t
+{
+    int                 i_original_height;
+    int                 i_original_width;
+    int                 i_align;          /* Subtitles alignment on the vout */
+
+    ssa_style_t         **pp_ssa_styles;
+    int                 i_ssa_styles;
+
+    image_attach_t      **pp_images;
+    int                 i_images;
+};
+
+static subpicture_t *DecodeBlock   ( decoder_t *, block_t ** );
+static char         *CreatePlainText( char * );
+static int           ParseImageAttachments( decoder_t *p_dec );
+
+static subpicture_t        *ParseText     ( decoder_t *, block_t * );
+static void                 ParseUSFHeader( decoder_t * );
+static subpicture_region_t *ParseUSFString( decoder_t *, char * );
+static subpicture_region_t *LoadEmbeddedImage( decoder_t *p_dec, const char *psz_filename, int i_transparent_color );
+
 /*****************************************************************************
  * OpenDecoder: probe the decoder and return score
  *****************************************************************************
@@ -80,11 +125,6 @@ static int OpenDecoder( vlc_object_t *p_this )
     p_dec->fmt_out.i_cat = SPU_ES;
     p_dec->fmt_out.i_codec = 0;
 
-    /* Unused fields of p_sys - not needed for USF decoding */
-    p_sys->b_ass = false;
-    p_sys->iconv_handle = (vlc_iconv_t)-1;
-    p_sys->b_autodetect_utf8 = false;
-
     /* init of p_sys */
     p_sys->i_align = 0;
     p_sys->i_original_height = 0;
@@ -528,37 +568,29 @@ static int ParseImageAttachments( decoder_t *p_dec )
 static void ParseUSFHeaderTags( decoder_t *p_dec, xml_reader_t *p_xml_reader )
 {
     decoder_sys_t *p_sys = p_dec->p_sys;
-    char *psz_node;
+    const char *node;
     ssa_style_t *p_ssa_style = NULL;
     int i_style_level = 0;
     int i_metadata_level = 0;
     int type;
 
-    while( (type = xml_ReaderNextNode( p_xml_reader )) > 0 )
+    while( (type = xml_ReaderNextNode( p_xml_reader, &node )) > 0 )
     {
         switch( type )
         {
             case XML_READER_ENDELEM:
-                psz_node = xml_ReaderName( p_xml_reader );
-
-                if( !psz_node )
-                    break;
                 switch (i_style_level)
                 {
                     case 0:
-                        if( !strcasecmp( "metadata", psz_node ) && (i_metadata_level == 1) )
-                        {
+                        if( !strcasecmp( "metadata", node ) && (i_metadata_level == 1) )
                             i_metadata_level--;
-                        }
                         break;
                     case 1:
-                        if( !strcasecmp( "styles", psz_node ) )
-                        {
+                        if( !strcasecmp( "styles", node ) )
                             i_style_level--;
-                        }
                         break;
                     case 2:
-                        if( !strcasecmp( "style", psz_node ) )
+                        if( !strcasecmp( "style", node ) )
                         {
                             TAB_APPEND( p_sys->i_ssa_styles, p_sys->pp_ssa_styles, p_ssa_style );
 
@@ -567,57 +599,40 @@ static void ParseUSFHeaderTags( decoder_t *p_dec, xml_reader_t *p_xml_reader )
                         }
                         break;
                 }
-
-                free( psz_node );
                 break;
-            case XML_READER_STARTELEM:
-                psz_node = xml_ReaderName( p_xml_reader );
 
-                if( !psz_node )
-                    break;
-
-                if( !strcasecmp( "metadata", psz_node ) && (i_style_level == 0) )
-                {
+            case XML_READER_STARTELEM:
+                if( !strcasecmp( "metadata", node ) && (i_style_level == 0) )
                     i_metadata_level++;
-                }
-                else if( !strcasecmp( "resolution", psz_node ) &&
+                else if( !strcasecmp( "resolution", node ) &&
                          ( i_metadata_level == 1) )
                 {
-                    const char *attr;
-                    while( (attr = xml_ReaderNextAttr( p_xml_reader )) )
+                    const char *attr, *val;
+                    while( (attr = xml_ReaderNextAttr( p_xml_reader, &val )) )
                     {
-                        char *psz_value = xml_ReaderValue ( p_xml_reader );
-                        if( !psz_value )
-                            continue;
-
                         if( !strcasecmp( "x", attr ) )
-                            p_sys->i_original_width = atoi( psz_value );
+                            p_sys->i_original_width = atoi( val );
                         else if( !strcasecmp( "y", attr ) )
-                            p_sys->i_original_height = atoi( psz_value );
-                        free( psz_value );
+                            p_sys->i_original_height = atoi( val );
                     }
                 }
-                else if( !strcasecmp( "styles", psz_node ) && (i_style_level == 0) )
+                else if( !strcasecmp( "styles", node ) && (i_style_level == 0) )
                 {
                     i_style_level++;
                 }
-                else if( !strcasecmp( "style", psz_node ) && (i_style_level == 1) )
+                else if( !strcasecmp( "style", node ) && (i_style_level == 1) )
                 {
                     i_style_level++;
 
                     p_ssa_style = calloc( 1, sizeof(ssa_style_t) );
-                    if( !p_ssa_style )
-                    {
-                        free( psz_node );
+                    if( unlikely(!p_ssa_style) )
                         return;
-                    }
                     /* All styles are supposed to default to Default, and then
                      * one or more settings are over-ridden.
                      * At the moment this only effects styles defined AFTER
                      * Default in the XML
                      */
-                    int i;
-                    for( i = 0; i < p_sys->i_ssa_styles; i++ )
+                    for( int i = 0; i < p_sys->i_ssa_styles; i++ )
                     {
                         if( !strcasecmp( p_sys->pp_ssa_styles[i]->psz_stylename, "Default" ) )
                         {
@@ -631,40 +646,31 @@ static void ParseUSFHeaderTags( decoder_t *p_dec, xml_reader_t *p_xml_reader )
                         }
                     }
 
-                    const char *attr;
-                    while( (attr = xml_ReaderNextAttr( p_xml_reader )) )
+                    const char *attr, *val;
+                    while( (attr = xml_ReaderNextAttr( p_xml_reader, &val )) )
                     {
-                        char *psz_value = xml_ReaderValue ( p_xml_reader );
-                        if( !psz_value )
-                            continue;
-
                         if( !strcasecmp( "name", attr ) )
                         {
                             free( p_ssa_style->psz_stylename );
-                            p_ssa_style->psz_stylename = strdup( psz_value );
+                            p_ssa_style->psz_stylename = strdup( val );
                         }
-                        free( psz_value );
                     }
                 }
-                else if( !strcasecmp( "fontstyle", psz_node ) && (i_style_level == 2) )
+                else if( !strcasecmp( "fontstyle", node ) && (i_style_level == 2) )
                 {
-                    const char *attr;
-                    while( (attr = xml_ReaderNextAttr( p_xml_reader )) )
+                    const char *attr, *val;
+                    while( (attr = xml_ReaderNextAttr( p_xml_reader, &val )) )
                     {
-                        char *psz_value = xml_ReaderValue ( p_xml_reader );
-                        if( !psz_value )
-                            continue;
-
                         if( !strcasecmp( "face", attr ) )
                         {
                             free( p_ssa_style->font_style.psz_fontname );
-                            p_ssa_style->font_style.psz_fontname = strdup( psz_value );
+                            p_ssa_style->font_style.psz_fontname = strdup( val );
                         }
                         else if( !strcasecmp( "size", attr ) )
                         {
-                            if( ( *psz_value == '+' ) || ( *psz_value == '-' ) )
+                            if( ( *val == '+' ) || ( *val == '-' ) )
                             {
-                                int i_value = atoi( psz_value );
+                                int i_value = atoi( val );
 
                                 if( ( i_value >= -5 ) && ( i_value <= 5 ) )
                                     p_ssa_style->font_style.i_font_size  +=
@@ -675,141 +681,133 @@ static void ParseUSFHeaderTags( decoder_t *p_dec, xml_reader_t *p_xml_reader )
                                     p_ssa_style->font_style.i_font_size  = i_value;
                             }
                             else
-                                p_ssa_style->font_style.i_font_size  = atoi( psz_value );
+                                p_ssa_style->font_style.i_font_size  = atoi( val );
                         }
                         else if( !strcasecmp( "italic", attr ) )
                         {
-                            if( !strcasecmp( "yes", psz_value ))
+                            if( !strcasecmp( "yes", val ))
                                 p_ssa_style->font_style.i_style_flags |= STYLE_ITALIC;
                             else
                                 p_ssa_style->font_style.i_style_flags &= ~STYLE_ITALIC;
                         }
                         else if( !strcasecmp( "weight", attr ) )
                         {
-                            if( !strcasecmp( "bold", psz_value ))
+                            if( !strcasecmp( "bold", val ))
                                 p_ssa_style->font_style.i_style_flags |= STYLE_BOLD;
                             else
                                 p_ssa_style->font_style.i_style_flags &= ~STYLE_BOLD;
                         }
                         else if( !strcasecmp( "underline", attr ) )
                         {
-                            if( !strcasecmp( "yes", psz_value ))
+                            if( !strcasecmp( "yes", val ))
                                 p_ssa_style->font_style.i_style_flags |= STYLE_UNDERLINE;
                             else
                                 p_ssa_style->font_style.i_style_flags &= ~STYLE_UNDERLINE;
                         }
                         else if( !strcasecmp( "color", attr ) )
                         {
-                            if( *psz_value == '#' )
+                            if( *val == '#' )
                             {
-                                unsigned long col = strtol(psz_value+1, NULL, 16);
+                                unsigned long col = strtol(val+1, NULL, 16);
                                  p_ssa_style->font_style.i_font_color = (col & 0x00ffffff);
                                  p_ssa_style->font_style.i_font_alpha = (col >> 24) & 0xff;
                             }
                         }
                         else if( !strcasecmp( "outline-color", attr ) )
                         {
-                            if( *psz_value == '#' )
+                            if( *val == '#' )
                             {
-                                unsigned long col = strtol(psz_value+1, NULL, 16);
+                                unsigned long col = strtol(val+1, NULL, 16);
                                 p_ssa_style->font_style.i_outline_color = (col & 0x00ffffff);
                                 p_ssa_style->font_style.i_outline_alpha = (col >> 24) & 0xff;
                             }
                         }
                         else if( !strcasecmp( "outline-level", attr ) )
                         {
-                            p_ssa_style->font_style.i_outline_width = atoi( psz_value );
+                            p_ssa_style->font_style.i_outline_width = atoi( val );
                         }
                         else if( !strcasecmp( "shadow-color", attr ) )
                         {
-                            if( *psz_value == '#' )
+                            if( *val == '#' )
                             {
-                                unsigned long col = strtol(psz_value+1, NULL, 16);
+                                unsigned long col = strtol(val+1, NULL, 16);
                                 p_ssa_style->font_style.i_shadow_color = (col & 0x00ffffff);
                                 p_ssa_style->font_style.i_shadow_alpha = (col >> 24) & 0xff;
                             }
                         }
                         else if( !strcasecmp( "shadow-level", attr ) )
                         {
-                            p_ssa_style->font_style.i_shadow_width = atoi( psz_value );
+                            p_ssa_style->font_style.i_shadow_width = atoi( val );
                         }
                         else if( !strcasecmp( "back-color", attr ) )
                         {
-                            if( *psz_value == '#' )
+                            if( *val == '#' )
                             {
-                                unsigned long col = strtol(psz_value+1, NULL, 16);
+                                unsigned long col = strtol(val+1, NULL, 16);
                                 p_ssa_style->font_style.i_karaoke_background_color = (col & 0x00ffffff);
                                 p_ssa_style->font_style.i_karaoke_background_alpha = (col >> 24) & 0xff;
                             }
                         }
                         else if( !strcasecmp( "spacing", attr ) )
                         {
-                            p_ssa_style->font_style.i_spacing = atoi( psz_value );
+                            p_ssa_style->font_style.i_spacing = atoi( val );
                         }
-                        free( psz_value );
                     }
                 }
-                else if( !strcasecmp( "position", psz_node ) && (i_style_level == 2) )
+                else if( !strcasecmp( "position", node ) && (i_style_level == 2) )
                 {
-                    const char *attr;
-                    while( (attr = xml_ReaderNextAttr( p_xml_reader )) )
+                    const char *attr, *val;
+                    while( (attr = xml_ReaderNextAttr( p_xml_reader, &val )) )
                     {
-                        char *psz_value = xml_ReaderValue ( p_xml_reader );
-                        if( !psz_value )
-                            continue;
-
                         if( !strcasecmp( "alignment", attr ) )
                         {
-                            if( !strcasecmp( "TopLeft", psz_value ) )
+                            if( !strcasecmp( "TopLeft", val ) )
                                 p_ssa_style->i_align = SUBPICTURE_ALIGN_TOP | SUBPICTURE_ALIGN_LEFT;
-                            else if( !strcasecmp( "TopCenter", psz_value ) )
+                            else if( !strcasecmp( "TopCenter", val ) )
                                 p_ssa_style->i_align = SUBPICTURE_ALIGN_TOP;
-                            else if( !strcasecmp( "TopRight", psz_value ) )
+                            else if( !strcasecmp( "TopRight", val ) )
                                 p_ssa_style->i_align = SUBPICTURE_ALIGN_TOP | SUBPICTURE_ALIGN_RIGHT;
-                            else if( !strcasecmp( "MiddleLeft", psz_value ) )
+                            else if( !strcasecmp( "MiddleLeft", val ) )
                                 p_ssa_style->i_align = SUBPICTURE_ALIGN_LEFT;
-                            else if( !strcasecmp( "MiddleCenter", psz_value ) )
+                            else if( !strcasecmp( "MiddleCenter", val ) )
                                 p_ssa_style->i_align = 0;
-                            else if( !strcasecmp( "MiddleRight", psz_value ) )
+                            else if( !strcasecmp( "MiddleRight", val ) )
                                 p_ssa_style->i_align = SUBPICTURE_ALIGN_RIGHT;
-                            else if( !strcasecmp( "BottomLeft", psz_value ) )
+                            else if( !strcasecmp( "BottomLeft", val ) )
                                 p_ssa_style->i_align = SUBPICTURE_ALIGN_BOTTOM | SUBPICTURE_ALIGN_LEFT;
-                            else if( !strcasecmp( "BottomCenter", psz_value ) )
+                            else if( !strcasecmp( "BottomCenter", val ) )
                                 p_ssa_style->i_align = SUBPICTURE_ALIGN_BOTTOM;
-                            else if( !strcasecmp( "BottomRight", psz_value ) )
+                            else if( !strcasecmp( "BottomRight", val ) )
                                 p_ssa_style->i_align = SUBPICTURE_ALIGN_BOTTOM | SUBPICTURE_ALIGN_RIGHT;
                         }
                         else if( !strcasecmp( "horizontal-margin", attr ) )
                         {
-                            if( strchr( psz_value, '%' ) )
+                            if( strchr( val, '%' ) )
                             {
                                 p_ssa_style->i_margin_h = 0;
-                                p_ssa_style->i_margin_percent_h = atoi( psz_value );
+                                p_ssa_style->i_margin_percent_h = atoi( val );
                             }
                             else
                             {
-                                p_ssa_style->i_margin_h = atoi( psz_value );
+                                p_ssa_style->i_margin_h = atoi( val );
                                 p_ssa_style->i_margin_percent_h = 0;
                             }
                         }
                         else if( !strcasecmp( "vertical-margin", attr ) )
                         {
-                            if( strchr( psz_value, '%' ) )
+                            if( strchr( val, '%' ) )
                             {
                                 p_ssa_style->i_margin_v = 0;
-                                p_ssa_style->i_margin_percent_v = atoi( psz_value );
+                                p_ssa_style->i_margin_percent_v = atoi( val );
                             }
                             else
                             {
-                                p_ssa_style->i_margin_v = atoi( psz_value );
+                                p_ssa_style->i_margin_v = atoi( val );
                                 p_ssa_style->i_margin_percent_v = 0;
                             }
                         }
-                        free( psz_value );
                     }
                 }
-
-                free( psz_node );
                 break;
         }
     }
@@ -991,16 +989,13 @@ static void ParseUSFHeader( decoder_t *p_dec )
     p_xml_reader = xml_ReaderCreate( p_dec, p_sub );
     if( likely(p_xml_reader) )
     {
-        /* Look for Root Node */
-        if( xml_ReaderNextNode( p_xml_reader ) == XML_READER_STARTELEM )
-        {
-            char *psz_node = xml_ReaderName( p_xml_reader );
+        const char *node;
 
-            if( !strcasecmp( "usfsubtitles", psz_node ) )
-                ParseUSFHeaderTags( p_dec, p_xml_reader );
+        /* Look for Root Node */
+        if( xml_ReaderNextNode( p_xml_reader, &node ) == XML_READER_STARTELEM
+         && !strcasecmp( "usfsubtitles", node ) )
+            ParseUSFHeaderTags( p_dec, p_xml_reader );
 
-            free( psz_node );
-        }
         xml_ReaderDelete( p_xml_reader );
     }
     stream_Delete( p_sub );