/*****************************************************************************
* theora.c: theora decoder module making use of libtheora.
*****************************************************************************
- * Copyright (C) 1999-2001 VideoLAN
+ * Copyright (C) 1999-2001 the VideoLAN team
* $Id$
*
* Authors: Gildas Bazin <gbazin@videolan.org>
theora_comment tc; /* theora comment header */
theora_state td; /* theora bitstream user comments */
+ /*
+ * Decoding properties
+ */
+ vlc_bool_t b_decoded_first_keyframe;
+
/*
* Common properties
*/
vlc_module_begin();
set_category( CAT_INPUT );
set_subcategory( SUBCAT_INPUT_VCODEC );
+ set_shortname( "Theora" );
set_description( _("Theora video decoder") );
set_capability( "decoder", 100 );
set_callbacks( OpenDecoder, CloseDecoder );
add_submodule();
set_description( _("Theora video encoder") );
- set_capability( "encoder", 100 );
+ set_capability( "encoder", 150 );
set_callbacks( OpenEncoder, CloseEncoder );
add_shortcut( "theora" );
p_dec->p_sys->b_packetizer = VLC_FALSE;
p_sys->i_pts = 0;
+ p_sys->b_decoded_first_keyframe = VLC_FALSE;
/* Set output properties */
p_dec->fmt_out.i_cat = VIDEO_ES;
p_sys->ti.frame_width, p_sys->ti.frame_height,
p_sys->ti.offset_x, p_sys->ti.offset_y );
+ /* Sanity check that seems necessary for some corrupted files */
+ if( p_sys->ti.width < p_sys->ti.frame_width ||
+ p_sys->ti.height < p_sys->ti.frame_height )
+ {
+ msg_Warn( p_dec, "trying to correct invalid theora header "
+ "(frame size (%dx%d) is smaller than frame content (%d,%d))",
+ p_sys->ti.width, p_sys->ti.height,
+ p_sys->ti.frame_width, p_sys->ti.frame_height );
+
+ if( p_sys->ti.width < p_sys->ti.frame_width )
+ p_sys->ti.width = p_sys->ti.frame_width;
+ if( p_sys->ti.height < p_sys->ti.frame_height )
+ p_sys->ti.height = p_sys->ti.frame_height;
+ }
+
/* The next packet in order is the comments header */
oggpacket.b_o_s = 0;
oggpacket.bytes = *(p_extra++) << 8;
block_t *p_block = *pp_block;
void *p_buf;
+ if( ( p_block->i_flags&(BLOCK_FLAG_DISCONTINUITY|BLOCK_FLAG_CORRUPTED) ) != 0 )
+ {
+ /* Don't send the the first packet after a discontinuity to
+ * theora_decode, otherwise we get purple/green display artifacts
+ * appearing in the video output */
+ return NULL;
+ }
+
/* Date management */
if( p_block->i_pts > 0 && p_block->i_pts != p_sys->i_pts )
{
theora_decode_packetin( &p_sys->td, p_oggpacket );
- /* Decode */
- theora_decode_YUVout( &p_sys->td, &yuv );
+ /* Check for keyframe */
+ if( !(p_oggpacket->packet[0] & 0x80) /* data packet */ &&
+ !(p_oggpacket->packet[0] & 0x40) /* intra frame */ )
+ p_sys->b_decoded_first_keyframe = VLC_TRUE;
+
+ /* If we haven't seen a single keyframe yet, don't let Theora decode
+ * anything, otherwise we'll get display artifacts. (This is impossible
+ * in the general case, but can happen if e.g. we play a network stream
+ * using a timed URL, such that the server doesn't start the video with a
+ * keyframe). */
+ if( p_sys->b_decoded_first_keyframe )
+ theora_decode_YUVout( &p_sys->td, &yuv );
+ else
+ return NULL;
/* Get a new picture */
p_pic = p_dec->pf_vout_buffer_new( p_dec );
for( i_line = 0; i_line < p_pic->p[i_plane].i_visible_lines; i_line++ )
{
- p_dec->p_vlc->pf_memcpy( p_dst, p_src, i_width );
+ p_dec->p_vlc->pf_memcpy( p_dst, p_src + i_src_xoffset,
+ i_plane ? yuv->uv_width : yuv->y_width );
p_src += i_src_stride;
p_dst += i_dst_stride;
}
if( p_enc->fmt_in.video.i_aspect )
{
- int64_t i_num, i_den;
- int i_dst_num, i_dst_den;
+ uint64_t i_num, i_den;
+ unsigned i_dst_num, i_dst_den;
i_num = p_enc->fmt_in.video.i_aspect * (int64_t)p_sys->ti.height;
i_den = VOUT_ASPECT_FACTOR * p_sys->ti.width;
- vlc_reduce( &i_dst_num, &i_dst_den, i_num, i_den, 0 );
+ vlc_ureduce( &i_dst_num, &i_dst_den, i_num, i_den, 0 );
p_sys->ti.aspect_numerator = i_dst_num;
p_sys->ti.aspect_denominator = i_dst_den;
}