]> git.sesse.net Git - vlc/blobdiff - modules/codec/vorbis.c
meta-data handling cleanup
[vlc] / modules / codec / vorbis.c
index 69954cf07bd52f4ec8819843950ba91eaba6e542..dc580f1f9a14ff18175d7185ddf09130a7cbb4bc 100644 (file)
@@ -1,7 +1,10 @@
 /*****************************************************************************
- * vorbis.c: vorbis decoder/encoder/packetizer module making use of libvorbis.
+ * vorbis.c: vorbis decoder/encoder/packetizer module using of libvorbis.
  *****************************************************************************
  * Copyright (C) 2001-2003 the VideoLAN team
+ * Copyright (C) 2007 Société des arts technologiques
+ * Copyright (C) 2007 Savoir-faire Linux
+ *
  * $Id$
  *
  * Authors: Gildas Bazin <gbazin@videolan.org>
 /*****************************************************************************
  * Preamble
  *****************************************************************************/
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
 #include <vlc/vlc.h>
 #include <vlc_codec.h>
 #include <vlc_aout.h>
 #include <vlc_input.h>
+#include <vlc_playlist.h>
 #include <vlc_sout.h>
 
 #include <ogg/ogg.h>
@@ -54,7 +62,7 @@
 struct decoder_sys_t
 {
     /* Module mode */
-    vlc_bool_t b_packetizer;
+    bool b_packetizer;
 
     /*
      * Input properties
@@ -86,7 +94,7 @@ struct decoder_sys_t
     int pi_chan_table[AOUT_CHAN_MAX];
 };
 
-static int pi_channels_maps[7] =
+static int pi_channels_maps[9] =
 {
     0,
     AOUT_CHAN_CENTER,
@@ -97,7 +105,13 @@ static int pi_channels_maps[7] =
     AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER
      | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT,
     AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER
-     | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT | AOUT_CHAN_LFE
+     | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT | AOUT_CHAN_LFE,
+    AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER
+     | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT | AOUT_CHAN_MIDDLELEFT
+     | AOUT_CHAN_MIDDLERIGHT,
+    AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER | AOUT_CHAN_REARLEFT
+     | AOUT_CHAN_REARRIGHT | AOUT_CHAN_MIDDLELEFT | AOUT_CHAN_MIDDLERIGHT
+     | AOUT_CHAN_LFE
 };
 
 /*
@@ -136,11 +150,9 @@ static void *ProcessPacket ( decoder_t *, ogg_packet *, block_t ** );
 static aout_buffer_t *DecodePacket  ( decoder_t *, ogg_packet * );
 static block_t *SendPacket( decoder_t *, ogg_packet *, block_t * );
 
-#ifndef HAVE_TAGLIB
 static void ParseVorbisComments( decoder_t * );
-#endif
 
-static void ConfigureChannelOrder(int *, int, uint32_t, vlc_bool_t );
+static void ConfigureChannelOrder(int *, int, uint32_t, bool );
 
 #ifdef MODULE_NAME_IS_tremor
 static void Interleave   ( int32_t *, const int32_t **, int, int, int * );
@@ -198,13 +210,13 @@ vlc_module_begin();
 #endif
 
     add_integer( ENC_CFG_PREFIX "quality", 0, NULL, ENC_QUALITY_TEXT,
-                 ENC_QUALITY_LONGTEXT, VLC_FALSE );
+                 ENC_QUALITY_LONGTEXT, false );
     add_integer( ENC_CFG_PREFIX "max-bitrate", 0, NULL, ENC_MAXBR_TEXT,
-                 ENC_MAXBR_LONGTEXT, VLC_FALSE );
+                 ENC_MAXBR_LONGTEXT, false );
     add_integer( ENC_CFG_PREFIX "min-bitrate", 0, NULL, ENC_MINBR_TEXT,
-                 ENC_MINBR_LONGTEXT, VLC_FALSE );
+                 ENC_MINBR_LONGTEXT, false );
     add_bool( ENC_CFG_PREFIX "cbr", 0, NULL, ENC_CBR_TEXT,
-                 ENC_CBR_LONGTEXT, VLC_FALSE );
+                 ENC_CBR_LONGTEXT, false );
 #endif
 
 vlc_module_end();
@@ -239,7 +251,7 @@ static int OpenDecoder( vlc_object_t *p_this )
     /* Misc init */
     aout_DateSet( &p_sys->end_date, 0 );
     p_sys->i_last_block_size = 0;
-    p_sys->b_packetizer = VLC_FALSE;
+    p_sys->b_packetizer = false;
     p_sys->i_headers = 0;
     p_sys->i_input_rate = INPUT_RATE_DEFAULT;
 
@@ -272,7 +284,7 @@ static int OpenPacketizer( vlc_object_t *p_this )
 
     if( i_ret == VLC_SUCCESS )
     {
-        p_dec->p_sys->b_packetizer = VLC_TRUE;
+        p_dec->p_sys->b_packetizer = true;
         p_dec->fmt_out.i_codec = VLC_FOURCC('v','o','r','b');
     }
 
@@ -397,10 +409,9 @@ static int ProcessHeaders( decoder_t *p_dec )
     p_dec->fmt_out.audio.i_rate     = p_sys->vi.rate;
     p_dec->fmt_out.audio.i_channels = p_sys->vi.channels;
 
-    if( p_dec->fmt_out.audio.i_channels < 0 ||
-        p_dec->fmt_out.audio.i_channels > 6 )
+    if( p_dec->fmt_out.audio.i_channels > 9 )
     {
-        msg_Err( p_dec, "invalid number of channels (not between 1 and 6): %i",
+        msg_Err( p_dec, "invalid number of channels (not between 1 and 9): %i",
                  p_dec->fmt_out.audio.i_channels );
         return VLC_EGENERIC;
     }
@@ -411,7 +422,6 @@ static int ProcessHeaders( decoder_t *p_dec )
     p_dec->fmt_out.i_bitrate = p_sys->vi.bitrate_nominal;
 
     aout_DateInit( &p_sys->end_date, p_sys->vi.rate );
-    aout_DateSet( &p_sys->end_date, 0 );
 
     msg_Dbg( p_dec, "channels:%d samplerate:%ld bitrate:%ld",
              p_sys->vi.channels, p_sys->vi.rate, p_sys->vi.bitrate_nominal );
@@ -434,9 +444,7 @@ static int ProcessHeaders( decoder_t *p_dec )
         msg_Err( p_dec, "2nd Vorbis header is corrupted" );
         return VLC_EGENERIC;
     }
-#ifndef HAVE_TAGLIB
     ParseVorbisComments( p_dec );
-#endif
 
     /* The next packet in order is the codebooks header
      * We need to watch out that this packet is not missing as a
@@ -473,7 +481,7 @@ static int ProcessHeaders( decoder_t *p_dec )
     }
 
     ConfigureChannelOrder(p_sys->pi_chan_table, p_sys->vi.channels,
-            p_dec->fmt_out.audio.i_physical_channels, VLC_TRUE);
+            p_dec->fmt_out.audio.i_physical_channels, true);
 
     return VLC_SUCCESS;
 }
@@ -609,7 +617,6 @@ static block_t *SendPacket( decoder_t *p_dec, ogg_packet *p_oggpacket,
     return p_block;
 }
 
-#ifndef HAVE_TAGLIB
 /*****************************************************************************
  * ParseVorbisComments
  *****************************************************************************/
@@ -640,15 +647,12 @@ static void ParseVorbisComments( decoder_t *p_dec )
             psz_value++;
             input_Control( p_input, INPUT_ADD_INFO, _("Vorbis comment"),
                            psz_name, "%s", psz_value );
+#ifndef HAVE_TAGLIB
             if( !strcasecmp( psz_name, "artist" ) )
             {
                 if( psz_value && ( *psz_value != '\0' ) )
                 {
                     input_item_SetArtist( p_item, psz_value );
-                    input_ItemAddInfo( p_item,
-                                        _(VLC_META_INFO_CAT),
-                                        _(VLC_META_ARTIST),
-                                        "%s", psz_value );
                 }
             }
             else if( !strcasecmp( psz_name, "title" ) )
@@ -673,12 +677,29 @@ static void ParseVorbisComments( decoder_t *p_dec )
                     input_item_SetTrackID( p_item, psz_value );
                 }
             }
-            else if( !strcasecmp( psz_name, "REPLAYGAIN_TRACK_GAIN" ) ||
+#if 0 //not used
+            else if( !strcasecmp( psz_name, "musicbrainz_artistid" ) )
+            {
+                if( psz_value && ( *psz_value != '\0' ) )
+                {
+                    vlc_meta_SetArtistID( p_item, psz_value );
+                }
+            }
+            else if( !strcasecmp( psz_name, "musicbrainz_albumid" ) )
+            {
+                if( psz_value && ( *psz_value != '\0' ) )
+                {
+                    input_item_SetAlbumID( p_item, psz_value );
+                }
+            }
+#endif
+#endif
+            if( !strcasecmp( psz_name, "REPLAYGAIN_TRACK_GAIN" ) ||
                      !strcasecmp( psz_name, "RG_RADIO" ) )
             {
                 audio_replay_gain_t *r = &p_dec->fmt_out.audio_replay_gain;
 
-                r->pb_gain[AUDIO_REPLAY_GAIN_TRACK] = VLC_TRUE;
+                r->pb_gain[AUDIO_REPLAY_GAIN_TRACK] = true;
                 r->pf_gain[AUDIO_REPLAY_GAIN_TRACK] = atof( psz_value );
             }
             else if( !strcasecmp( psz_name, "REPLAYGAIN_TRACK_PEAK" ) ||
@@ -686,7 +707,7 @@ static void ParseVorbisComments( decoder_t *p_dec )
             {
                 audio_replay_gain_t *r = &p_dec->fmt_out.audio_replay_gain;
 
-                r->pb_peak[AUDIO_REPLAY_GAIN_TRACK] = VLC_TRUE;
+                r->pb_peak[AUDIO_REPLAY_GAIN_TRACK] = true;
                 r->pf_peak[AUDIO_REPLAY_GAIN_TRACK] = atof( psz_value );
             }
             else if( !strcasecmp( psz_name, "REPLAYGAIN_ALBUM_GAIN" ) ||
@@ -694,45 +715,27 @@ static void ParseVorbisComments( decoder_t *p_dec )
             {
                 audio_replay_gain_t *r = &p_dec->fmt_out.audio_replay_gain;
 
-                r->pb_gain[AUDIO_REPLAY_GAIN_ALBUM] = VLC_TRUE;
+                r->pb_gain[AUDIO_REPLAY_GAIN_ALBUM] = true;
                 r->pf_gain[AUDIO_REPLAY_GAIN_ALBUM] = atof( psz_value );
             }
             else if( !strcasecmp( psz_name, "REPLAYGAIN_ALBUM_PEAK" ) )
             {
                 audio_replay_gain_t *r = &p_dec->fmt_out.audio_replay_gain;
 
-                r->pb_peak[AUDIO_REPLAY_GAIN_ALBUM] = VLC_TRUE;
+                r->pb_peak[AUDIO_REPLAY_GAIN_ALBUM] = true;
                 r->pf_peak[AUDIO_REPLAY_GAIN_ALBUM] = atof( psz_value );
             }
-#if 0 //not used
-            else if( !strcasecmp( psz_name, "musicbrainz_artistid" ) )
-            {
-                if( psz_value && ( *psz_value != '\0' ) )
-                {
-                    vlc_meta_SetArtistID( p_item, psz_value );
-                }
-            }
-            else if( !strcasecmp( psz_name, "musicbrainz_albumid" ) )
-            {
-                if( psz_value && ( *psz_value != '\0' ) )
-                {
-                    input_item_SetAlbumID( p_item, psz_value );
-                }
-            }
-#endif
         }
-        /* FIXME */
-        var_SetInteger( p_input, "item-change", p_item->i_id );
+        var_SetInteger( pl_Get( p_input ), "item-change", p_item->i_id );
         free( psz_comment );
         i++;
     }
 }
-#endif
 
 /*****************************************************************************
  * Interleave: helper function to interleave channels
  *****************************************************************************/
-static void ConfigureChannelOrder(int *pi_chan_table, int i_channels, uint32_t i_channel_mask, vlc_bool_t b_decode)
+static void ConfigureChannelOrder(int *pi_chan_table, int i_channels, uint32_t i_channel_mask, bool b_decode)
 {
     const uint32_t *pi_channels_in;
     switch( i_channels )
@@ -972,7 +975,7 @@ static int OpenEncoder( vlc_object_t *p_this )
     p_sys->i_pts = 0;
 
     ConfigureChannelOrder(p_sys->pi_chan_table, p_sys->vi.channels,
-            p_enc->fmt_in.audio.i_physical_channels, VLC_TRUE);
+            p_enc->fmt_in.audio.i_physical_channels, true);
 
     return VLC_SUCCESS;
 }