]> git.sesse.net Git - vlc/blobdiff - modules/control/gestures.c
Use var_Inherit* instead of var_CreateGet*.
[vlc] / modules / control / gestures.c
index e7003c9abd601b0a7c5622fd05544118045cdaab..9305cce64e12aec49895a70a16fdde4d7a65ac65 100644 (file)
@@ -1,7 +1,7 @@
 /*****************************************************************************
  * gestures.c: control vlc with mouse gestures
  *****************************************************************************
- * Copyright (C) 2004 the VideoLAN team
+ * Copyright (C) 2004-2009 the VideoLAN team
  * $Id$
  *
  * Authors: Sigmund Augdal Helberg <dnumgis@videolan.org>
  *****************************************************************************/
 struct intf_sys_t
 {
-    vlc_object_t *      p_vout;
-    bool          b_got_gesture;
-    bool          b_button_pressed;
+    vlc_mutex_t         lock;
+    vout_thread_t      *p_vout;
+    bool                b_got_gesture;
+    bool                b_button_pressed;
     int                 i_mouse_x, i_mouse_y;
     int                 i_last_x, i_last_y;
     unsigned int        i_pattern;
@@ -68,8 +69,6 @@ struct intf_sys_t
 
 int  Open   ( vlc_object_t * );
 void Close  ( vlc_object_t * );
-static int  InitThread     ( intf_thread_t *p_intf );
-static void EndThread      ( intf_thread_t *p_intf );
 static int  MouseEvent     ( vlc_object_t *, char const *,
                              vlc_value_t, vlc_value_t, void * );
 
@@ -87,24 +86,30 @@ static void RunIntf        ( intf_thread_t *p_intf );
 #define BUTTON_LONGTEXT N_( \
     "Trigger button for mouse gestures." )
 
+#if defined (HAVE_MAEMO)
+# define BUTTON_DEFAULT "left"
+#else
+# define BUTTON_DEFAULT "right"
+#endif
+
 static const char *const button_list[] = { "left", "middle", "right" };
 static const char *const button_list_text[] =
                                    { N_("Left"), N_("Middle"), N_("Right") };
 
-vlc_module_begin();
-    set_shortname( N_("Gestures"));
-    set_category( CAT_INTERFACE );
-    set_subcategory( SUBCAT_INTERFACE_CONTROL );
+vlc_module_begin ()
+    set_shortname( N_("Gestures"))
+    set_category( CAT_INTERFACE )
+    set_subcategory( SUBCAT_INTERFACE_CONTROL )
     add_integer( "gestures-threshold", 30, NULL,
-                 THRESHOLD_TEXT, THRESHOLD_LONGTEXT, true );
-    add_string( "gestures-button", "right", NULL,
-                BUTTON_TEXT, BUTTON_LONGTEXT, false );
-        change_string_list( button_list, button_list_text, 0 );
-    set_description( N_("Mouse gestures control interface") );
+                 THRESHOLD_TEXT, THRESHOLD_LONGTEXT, true )
+    add_string( "gestures-button", BUTTON_DEFAULT, NULL,
+                BUTTON_TEXT, BUTTON_LONGTEXT, false )
+        change_string_list( button_list, button_list_text, 0 )
+    set_description( N_("Mouse gestures control interface") )
 
-    set_capability( "interface", 0 );
-    set_callbacks( Open, Close );
-vlc_module_end();
+    set_capability( "interface", 0 )
+    set_callbacks( Open, Close )
+vlc_module_end ()
 
 /*****************************************************************************
  * OpenIntf: initialize interface
@@ -114,15 +119,33 @@ int Open ( vlc_object_t *p_this )
     intf_thread_t *p_intf = (intf_thread_t *)p_this;
 
     /* Allocate instance and initialize some members */
-    p_intf->p_sys = malloc( sizeof( intf_sys_t ) );
+    intf_sys_t *p_sys = p_intf->p_sys = malloc( sizeof( intf_sys_t ) );
     if( p_intf->p_sys == NULL )
-    {
-        return( 1 );
-    };
+        return VLC_ENOMEM;
 
+    // Configure the module
     p_intf->pf_run = RunIntf;
 
-    return( 0 );
+    vlc_mutex_init( &p_sys->lock );
+    p_sys->p_vout = NULL;
+    p_sys->b_got_gesture = false;
+    p_sys->b_button_pressed = false;
+    p_sys->i_threshold = var_InheritInteger( p_intf, "gestures-threshold" );
+
+    // Choose the tight button to use
+    char *psz_button = var_InheritString( p_intf, "gestures-button" );
+    if( psz_button && !strcmp( psz_button, "left" ) )
+        p_sys->i_button_mask = 1;
+    else if( psz_button && !strcmp( psz_button, "middle" ) )
+        p_sys->i_button_mask = 2;
+    else // psz_button == "right"
+        p_sys->i_button_mask = 4;
+    free( psz_button );
+
+    p_sys->i_pattern = 0;
+    p_sys->i_num_gestures = 0;
+
+    return VLC_SUCCESS;
 }
 
 /*****************************************************************************
@@ -133,23 +156,6 @@ static int gesture( int i_pattern, int i_num )
     return ( i_pattern >> ( i_num * 4 ) ) & 0xF;
 }
 
-/*****************************************************************************
- * input_from_playlist: don't forget to release the return value
- *  Also this function should really be available from core.
- *****************************************************************************/
-static input_thread_t * input_from_playlist ( playlist_t *p_playlist )
-{
-    input_thread_t * p_input;
-
-    PL_LOCK;
-    p_input = p_playlist->p_input;
-    if( p_input )
-        vlc_object_yield( p_input );
-    PL_UNLOCK;
-
-    return p_input;
-}
-
 /*****************************************************************************
  * CloseIntf: destroy dummy interface
  *****************************************************************************/
@@ -157,7 +163,18 @@ void Close ( vlc_object_t *p_this )
 {
     intf_thread_t *p_intf = (intf_thread_t *)p_this;
 
+    // Destroy the callbacks
+    if( p_intf->p_sys->p_vout )
+    {
+        var_DelCallback( p_intf->p_sys->p_vout, "mouse-moved",
+                         MouseEvent, p_intf );
+        var_DelCallback( p_intf->p_sys->p_vout, "mouse-button-down",
+                         MouseEvent, p_intf );
+        vlc_object_release( p_intf->p_sys->p_vout );
+    }
+
     /* Destroy structure */
+    vlc_mutex_destroy( &p_intf->p_sys->lock );
     free( p_intf->p_sys );
 }
 
@@ -167,195 +184,166 @@ void Close ( vlc_object_t *p_this )
  *****************************************************************************/
 static void RunIntf( intf_thread_t *p_intf )
 {
-    playlist_t * p_playlist = NULL;
-
-    vlc_mutex_lock( &p_intf->change_lock );
-    p_intf->p_sys->p_vout = NULL;
-    vlc_mutex_unlock( &p_intf->change_lock );
-
-    if( InitThread( p_intf ) < 0 )
-    {
-        msg_Err( p_intf, "can't initialize interface thread" );
-        return;
-    }
-    msg_Dbg( p_intf, "interface thread initialized" );
+    intf_sys_t *p_sys = p_intf->p_sys;
+    int canc = vlc_savecancel();
+    input_thread_t *p_input;
 
     /* Main loop */
-    while( !intf_ShouldDie( p_intf ) )
+    while( vlc_object_alive( p_intf ) )
     {
-        vlc_mutex_lock( &p_intf->change_lock );
+        vlc_mutex_lock( &p_sys->lock );
 
         /*
          * mouse cursor
          */
-        if( p_intf->p_sys->b_got_gesture )
+        if( p_sys->b_got_gesture )
         {
-            vlc_value_t val;
             int i_interval = 0;
             /* Do something */
             /* If you modify this, please try to follow this convention:
                Start with LEFT, RIGHT for playback related commands
                and UP, DOWN, for other commands */
-            switch( p_intf->p_sys->i_pattern )
+            playlist_t * p_playlist = pl_Get( p_intf );
+            switch( p_sys->i_pattern )
             {
             case LEFT:
-                i_interval = config_GetInt( p_intf , "short-jump-size" );
-                if ( i_interval > 0 ) {
-                    val.i_time = ( (mtime_t)( -i_interval ) * 1000000L);
-                    var_Set( p_intf, "time-offset", val );
+                msg_Dbg( p_intf, "Go backward in the movie!" );
+                p_input = playlist_CurrentInput( p_playlist );
+                if( p_input )
+                {
+                    i_interval = var_InheritInteger( p_intf , "short-jump-size" );
+                    if ( i_interval > 0 )
+                    {
+                        mtime_t i_time = ( (mtime_t)( -i_interval ) * 1000000L);
+                        var_SetTime( p_input, "time-offset", i_time );
+                    }
+                    vlc_object_release( p_input );
                 }
-                msg_Dbg(p_intf, "Go backward in the movie!");
                 break;
+
             case RIGHT:
-                i_interval = config_GetInt( p_intf , "short-jump-size" );
-                if ( i_interval > 0 ) {
-                    val.i_time = ( (mtime_t)( i_interval ) * 1000000L);
-                    var_Set( p_intf, "time-offset", val );
+                msg_Dbg( p_intf, "Go forward in the movie!" );
+                p_input = playlist_CurrentInput( p_playlist );
+                if( p_input )
+                {
+                    i_interval = var_InheritInteger( p_intf , "short-jump-size" );
+                    if ( i_interval > 0 )
+                    {
+                        mtime_t i_time = ( (mtime_t)( i_interval ) * 1000000L);
+                        var_SetTime( p_input, "time-offset", i_time );
+                    }
+                    vlc_object_release( p_input );
                 }
-                msg_Dbg(p_intf, "Go forward in the movie!");
                 break;
+
             case GESTURE(LEFT,UP,NONE,NONE):
-                /*FIXME BF*/
-                msg_Dbg(p_intf, "Going slower.");
+                msg_Dbg( p_intf, "Going slower." );
+                p_input = playlist_CurrentInput( p_playlist );
+                if( p_input )
+                {
+                    var_TriggerCallback( p_input, "rate-slower" );
+                    vlc_object_release( p_input );
+                }
                 break;
+
             case GESTURE(RIGHT,UP,NONE,NONE):
-                /*FIXME FF*/
-                msg_Dbg(p_intf, "Going faster.");
+                msg_Dbg( p_intf, "Going faster." );
+                p_input = playlist_CurrentInput( p_playlist );
+                if( p_input )
+                {
+                    var_TriggerCallback( p_input, "rate-faster" );
+                    vlc_object_release( p_input );
+                }
                 break;
+
             case GESTURE(LEFT,RIGHT,NONE,NONE):
             case GESTURE(RIGHT,LEFT,NONE,NONE):
-                {
-                    input_thread_t * p_input;
-                    p_playlist = pl_Yield( p_intf );
-
-                    p_input = input_from_playlist( p_playlist );
-                    vlc_object_release( p_playlist );
+                msg_Dbg( p_intf, "Play/Pause" );
+                p_input = playlist_CurrentInput( p_playlist );
  
-                    if( !p_input )
-                        break;
-                    val.i_int = PLAYING_S;
-                    if( p_input )
-                    {
-                        var_Get( p_input, "state", &val);
-                        if( val.i_int == PAUSE_S )
-                        {
-                            val.i_int = PLAYING_S;
-                        }
-                        else
-                        {
-                            val.i_int = PAUSE_S;
-                        }
-                        var_Set( p_input, "state", val);
-                    }
-                    msg_Dbg(p_intf, "Play/Pause");
+                if( p_input )
+                {
+                    int i_state = var_GetInteger( p_input, "state" );
+                    var_SetInteger( p_input, "state", ( i_state != PLAYING_S )
+                                                      ? PLAYING_S : PAUSE_S );
                     vlc_object_release( p_input );
                 }
                 break;
-            case GESTURE(LEFT,DOWN,NONE,NONE):
-                p_playlist = pl_Yield( p_intf );
 
+            case GESTURE(LEFT,DOWN,NONE,NONE):
                 playlist_Prev( p_playlist );
-                vlc_object_release( p_playlist );
                 break;
-            case GESTURE(RIGHT,DOWN,NONE,NONE):
-                p_playlist = pl_Yield( p_intf );
 
+            case GESTURE(RIGHT,DOWN,NONE,NONE):
                 playlist_Next( p_playlist );
-                vlc_object_release( p_playlist );
                 break;
+
             case UP:
-                {
-                    audio_volume_t i_newvol;
-                    aout_VolumeUp( p_intf, 1, &i_newvol );
-                    msg_Dbg(p_intf, "Louder");
-                }
+                msg_Dbg(p_intf, "Louder");
+                aout_VolumeUp( p_playlist, 1, NULL );
                 break;
+
             case DOWN:
-                {
-                    audio_volume_t i_newvol;
-                    aout_VolumeDown( p_intf, 1, &i_newvol );
-                    msg_Dbg(p_intf, "Quieter");
-                }
+                msg_Dbg(p_intf, "Quieter");
+                aout_VolumeDown( p_playlist, 1, NULL );
                 break;
+
             case GESTURE(UP,DOWN,NONE,NONE):
             case GESTURE(DOWN,UP,NONE,NONE):
-                {
-                    audio_volume_t i_newvol = -1;
-                    aout_VolumeMute( p_intf, &i_newvol );
-                    msg_Dbg(p_intf, "Mute sound");
-                }
+                msg_Dbg( p_intf, "Mute sound" );
+                aout_ToggleMute( p_playlist, NULL );
                 break;
+
             case GESTURE(UP,RIGHT,NONE,NONE):
                 {
-                   input_thread_t * p_input;
-                   vlc_value_t val, list, list2;
-                   int i_count, i;
-
-                    p_playlist = pl_Yield( p_intf );
-
-                    p_input = input_from_playlist( p_playlist );
-
-                    vlc_object_release( p_playlist );
+                    vlc_value_t list, list2;
+                    int i_count, i, i_audio_es;
 
+                    p_input = playlist_CurrentInput( p_playlist );
                     if( !p_input )
                         break;
 
-                   var_Get( p_input, "audio-es", &val );
-                   var_Change( p_input, "audio-es", VLC_VAR_GETCHOICES,
-                               &list, &list2 );
-                   i_count = list.p_list->i_count;
-                   if( i_count <= 1 )
-                   {
-                       vlc_object_release( p_input );
-                       break;
-                   }
-                   for( i = 0; i < i_count; i++ )
-                   {
-                       if( val.i_int == list.p_list->p_values[i].i_int )
-                       {
-                           break;
-                       }
-                   }
-                   /* value of audio-es was not in choices list */
-                   if( i == i_count )
-                   {
-                       msg_Warn( p_input,
-                               "invalid current audio track, selecting 0" );
-                       var_Set( p_input, "audio-es",
-                               list.p_list->p_values[0] );
-                       i = 0;
-                   }
-                   else if( i == i_count - 1 )
-                   {
-                       var_Set( p_input, "audio-es",
-                               list.p_list->p_values[1] );
-                       i = 1;
-                   }
-                   else
-                   {
-                       var_Set( p_input, "audio-es",
-                               list.p_list->p_values[i+1] );
-                       i++;
-                   }
-                   vlc_object_release( p_input );
+                    i_audio_es = var_GetInteger( p_input, "audio-es" );
+                    var_Change( p_input, "audio-es", VLC_VAR_GETCHOICES,
+                                &list, &list2 );
+                    i_count = list.p_list->i_count;
+                    if( i_count <= 1 )
+                    {
+                        var_FreeList( &list, &list2 );
+                        vlc_object_release( p_input );
+                        break;
+                    }
+                    for( i = 0; i < i_count; i++ )
+                    {
+                        if( i_audio_es == list.p_list->p_values[i].i_int )
+                            break;
+                    }
+                    /* value of audio-es was not in choices list */
+                    if( i == i_count )
+                    {
+                        msg_Warn( p_input,
+                                  "invalid current audio track, selecting 0" );
+                        i = 0;
+                    }
+                    else if( i == i_count - 1 )
+                        i = 1;
+                    else
+                        i++;
+                    var_SetInteger( p_input, "audio-es", list.p_list->p_values[i].i_int );
+                    var_FreeList( &list, &list2 );
+                    vlc_object_release( p_input );
                 }
                 break;
             case GESTURE(DOWN,RIGHT,NONE,NONE):
                 {
-                    input_thread_t * p_input;
-                    vlc_value_t val, list, list2;
-                    int i_count, i;
-
-                    p_playlist = pl_Yield( p_intf );
-
-                    p_input = input_from_playlist( p_playlist );
-                    vlc_object_release( p_playlist );
+                    vlc_value_t list, list2;
+                    int i_count, i, i_spu_es;
 
+                    p_input = playlist_CurrentInput( p_playlist );
                     if( !p_input )
                         break;
 
-                    var_Get( p_input, "spu-es", &val );
+                    i_spu_es = var_GetInteger( p_input, "spu-es" );
 
                     var_Change( p_input, "spu-es", VLC_VAR_GETCHOICES,
                             &list, &list2 );
@@ -363,11 +351,12 @@ static void RunIntf( intf_thread_t *p_intf )
                     if( i_count <= 1 )
                     {
                         vlc_object_release( p_input );
+                        var_FreeList( &list, &list2 );
                         break;
                     }
                     for( i = 0; i < i_count; i++ )
                     {
-                        if( val.i_int == list.p_list->p_values[i].i_int )
+                        if( i_spu_es == list.p_list->p_values[i].i_int )
                         {
                             break;
                         }
@@ -377,144 +366,79 @@ static void RunIntf( intf_thread_t *p_intf )
                     {
                         msg_Warn( p_input,
                                 "invalid current subtitle track, selecting 0" );
-                        var_Set( p_input, "spu-es", list.p_list->p_values[0] );
                         i = 0;
                     }
                     else if( i == i_count - 1 )
-                    {
-                        var_Set( p_input, "spu-es", list.p_list->p_values[0] );
                         i = 0;
-                    }
                     else
-                    {
-                        var_Set( p_input, "spu-es",
-                                list.p_list->p_values[i+1] );
-                        i = i + 1;
-                    }
+                        i++;
+                    var_SetInteger( p_input, "spu-es", list.p_list->p_values[i].i_int);
+                    var_FreeList( &list, &list2 );
                     vlc_object_release( p_input );
                 }
                 break;
+
             case GESTURE(UP,LEFT,NONE,NONE):
-                if (p_intf->p_sys->p_vout )
-                {
-                    ((vout_thread_t *)p_intf->p_sys->p_vout)->i_changes |=
-                        VOUT_FULLSCREEN_CHANGE;
-                }
+            {
+                bool val = var_ToggleBool( pl_Get( p_intf ), "fullscreen" );
+                if( p_sys->p_vout )
+                    var_SetBool( p_sys->p_vout, "fullscreen", val );
                 break;
+           }
+
             case GESTURE(DOWN,LEFT,NONE,NONE):
                 /* FIXME: Should close the vout!"*/
-                vlc_object_kill( p_intf->p_libvlc );
+                libvlc_Quit( p_intf->p_libvlc );
                 break;
             case GESTURE(DOWN,LEFT,UP,RIGHT):
             case GESTURE(UP,RIGHT,DOWN,LEFT):
-                msg_Dbg(p_intf, "a square was drawn!" );
+                msg_Dbg( p_intf, "a square was drawn!" );
                 break;
             default:
                 break;
             }
-            p_intf->p_sys->i_num_gestures = 0;
-            p_intf->p_sys->i_pattern = 0;
-            p_intf->p_sys->b_got_gesture = false;
+            p_sys->i_num_gestures = 0;
+            p_sys->i_pattern = 0;
+            p_sys->b_got_gesture = false;
         }
 
         /*
          * video output
          */
-        if( p_intf->p_sys->p_vout && !vlc_object_alive (p_intf->p_sys->p_vout) )
+        if( p_sys->p_vout && !vlc_object_alive( p_sys->p_vout ) )
         {
-            var_DelCallback( p_intf->p_sys->p_vout, "mouse-moved",
+            var_DelCallback( p_sys->p_vout, "mouse-moved",
                              MouseEvent, p_intf );
-            var_DelCallback( p_intf->p_sys->p_vout, "mouse-button-down",
+            var_DelCallback( p_sys->p_vout, "mouse-button-down",
                              MouseEvent, p_intf );
-            vlc_object_release( p_intf->p_sys->p_vout );
-            p_intf->p_sys->p_vout = NULL;
+            vlc_object_release( p_sys->p_vout );
+            p_sys->p_vout = NULL;
         }
 
-        if( p_intf->p_sys->p_vout == NULL )
+        if( p_sys->p_vout == NULL )
         {
-            p_intf->p_sys->p_vout = vlc_object_find( p_intf,
-                                      VLC_OBJECT_VOUT, FIND_ANYWHERE );
-            if( p_intf->p_sys->p_vout )
+            p_input = playlist_CurrentInput( pl_Get( p_intf ) );
+            if( p_input )
+            {
+                p_sys->p_vout = input_GetVout( p_input );
+                vlc_object_release( p_input );
+            }
+            if( p_sys->p_vout )
             {
-                var_AddCallback( p_intf->p_sys->p_vout, "mouse-moved",
+                var_AddCallback( p_sys->p_vout, "mouse-moved",
                                  MouseEvent, p_intf );
-                var_AddCallback( p_intf->p_sys->p_vout, "mouse-button-down",
+                var_AddCallback( p_sys->p_vout, "mouse-button-down",
                                  MouseEvent, p_intf );
             }
         }
 
-        vlc_mutex_unlock( &p_intf->change_lock );
+        vlc_mutex_unlock( &p_sys->lock );
 
         /* Wait a bit */
         msleep( INTF_IDLE_SLEEP );
     }
 
-    EndThread( p_intf );
-}
-
-/*****************************************************************************
- * InitThread:
- *****************************************************************************/
-static int InitThread( intf_thread_t * p_intf )
-{
-    char *psz_button;
-    /* we might need some locking here */
-    if( !intf_ShouldDie( p_intf ) )
-    {
-        /* p_intf->change_lock locking strategy:
-         * - Every access to p_intf->p_sys are locked threw p_intf->change_lock
-         * - make sure there won't be  cross increment/decrement ref count
-         *   of p_intf->p_sys members p_intf->change_lock should be locked
-         *   during those operations */
-        vlc_mutex_lock( &p_intf->change_lock );
-
-        p_intf->p_sys->b_got_gesture = false;
-        p_intf->p_sys->b_button_pressed = false;
-        p_intf->p_sys->i_threshold =
-                     config_GetInt( p_intf, "gestures-threshold" );
-        psz_button = config_GetPsz( p_intf, "gestures-button" );
-        if ( !strcmp( psz_button, "left" ) )
-        {
-            p_intf->p_sys->i_button_mask = 1;
-        }
-        else if ( !strcmp( psz_button, "middle" ) )
-        {
-            p_intf->p_sys->i_button_mask = 2;
-        }
-        else if ( !strcmp( psz_button, "right" ) )
-        {
-            p_intf->p_sys->i_button_mask = 4;
-        }
-
-        p_intf->p_sys->i_pattern = 0;
-        p_intf->p_sys->i_num_gestures = 0;
-        vlc_mutex_unlock( &p_intf->change_lock );
-
-        return 0;
-    }
-    else
-    {
-        return -1;
-    }
-}
-
-/*****************************************************************************
- * EndThread:
- *****************************************************************************/
-static void EndThread( intf_thread_t * p_intf )
-{
-    vlc_mutex_lock( &p_intf->change_lock );
-
-    if( p_intf->p_sys->p_vout )
-    {
-        var_DelCallback( p_intf->p_sys->p_vout, "mouse-moved",
-                         MouseEvent, p_intf );
-        var_DelCallback( p_intf->p_sys->p_vout, "mouse-button-down",
-                         MouseEvent, p_intf );
-        vlc_object_release( p_intf->p_sys->p_vout );
-    }
-
-    vlc_mutex_unlock( &p_intf->change_lock );
+    vlc_restorecancel( canc );
 }
 
 /*****************************************************************************
@@ -524,33 +448,29 @@ static int MouseEvent( vlc_object_t *p_this, char const *psz_var,
                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
 {
     VLC_UNUSED(p_this); VLC_UNUSED(oldval);
-    vlc_value_t val;
     int pattern = 0;
 
     signed int i_horizontal, i_vertical;
     intf_thread_t *p_intf = (intf_thread_t *)p_data;
+    intf_sys_t    *p_sys = p_intf->p_sys;
 
-    vlc_mutex_lock( &p_intf->change_lock );
+    vlc_mutex_lock( &p_sys->lock );
 
     /* don't process new gestures before the last events are processed */
-    if( p_intf->p_sys->b_got_gesture )
+    if( p_sys->b_got_gesture )
     {
-        vlc_mutex_unlock( &p_intf->change_lock );
+        vlc_mutex_unlock( &p_sys->lock );
         return VLC_SUCCESS;
     }
 
-    if( !strcmp(psz_var, "mouse-moved" ) && p_intf->p_sys->b_button_pressed )
+    if( !strcmp( psz_var, "mouse-moved" ) && p_sys->b_button_pressed )
     {
-        var_Get( p_intf->p_sys->p_vout, "mouse-x", &val );
-        p_intf->p_sys->i_mouse_x = val.i_int;
-        var_Get( p_intf->p_sys->p_vout, "mouse-y", &val );
-        p_intf->p_sys->i_mouse_y = val.i_int;
-        i_horizontal = p_intf->p_sys->i_mouse_x -
-            p_intf->p_sys->i_last_x;
-        i_horizontal = i_horizontal / p_intf->p_sys->i_threshold;
-        i_vertical = p_intf->p_sys->i_mouse_y
-            - p_intf->p_sys->i_last_y;
-        i_vertical = i_vertical / p_intf->p_sys->i_threshold;
+        p_sys->i_mouse_x = newval.coords.x;
+        p_sys->i_mouse_y = newval.coords.y;
+        i_horizontal = p_sys->i_mouse_x - p_sys->i_last_x;
+        i_horizontal = i_horizontal / p_sys->i_threshold;
+        i_vertical = p_sys->i_mouse_y - p_sys->i_last_y;
+        i_vertical = i_vertical / p_sys->i_threshold;
 
         if( i_horizontal < 0 )
         {
@@ -574,37 +494,33 @@ static int MouseEvent( vlc_object_t *p_this, char const *psz_var,
         }
         if( pattern )
         {
-            p_intf->p_sys->i_last_y = p_intf->p_sys->i_mouse_y;
-            p_intf->p_sys->i_last_x = p_intf->p_sys->i_mouse_x;
-            if( gesture( p_intf->p_sys->i_pattern,
-                         p_intf->p_sys->i_num_gestures - 1 ) != pattern )
+            p_sys->i_last_y = p_sys->i_mouse_y;
+            p_sys->i_last_x = p_sys->i_mouse_x;
+            if( gesture( p_sys->i_pattern, p_sys->i_num_gestures - 1 )
+                    != pattern )
             {
-                p_intf->p_sys->i_pattern |=
-                    pattern << ( p_intf->p_sys->i_num_gestures * 4 );
-                p_intf->p_sys->i_num_gestures++;
+                p_sys->i_pattern |= pattern << ( p_sys->i_num_gestures * 4 );
+                p_sys->i_num_gestures++;
             }
         }
 
     }
-    if( !strcmp( psz_var, "mouse-button-down" )
-        && newval.i_int & p_intf->p_sys->i_button_mask
-        && !p_intf->p_sys->b_button_pressed )
-    {
-        p_intf->p_sys->b_button_pressed = true;
-        var_Get( p_intf->p_sys->p_vout, "mouse-x", &val );
-        p_intf->p_sys->i_last_x = val.i_int;
-        var_Get( p_intf->p_sys->p_vout, "mouse-y", &val );
-        p_intf->p_sys->i_last_y = val.i_int;
-    }
-    if( !strcmp( psz_var, "mouse-button-down" )
-        && !( newval.i_int & p_intf->p_sys->i_button_mask )
-        && p_intf->p_sys->b_button_pressed )
+    else if( !strcmp( psz_var, "mouse-button-down" ) )
     {
-        p_intf->p_sys->b_button_pressed = false;
-        p_intf->p_sys->b_got_gesture = true;
+        if( (newval.i_int & p_sys->i_button_mask) && !p_sys->b_button_pressed )
+        {
+            p_sys->b_button_pressed = true;
+            var_GetCoords( p_sys->p_vout, "mouse-moved",
+                           &p_sys->i_last_x, &p_sys->i_last_y );
+        }
+        else if( !( newval.i_int & p_sys->i_button_mask ) && p_sys->b_button_pressed )
+        {
+            p_sys->b_button_pressed = false;
+            p_sys->b_got_gesture = true;
+        }
     }
 
-    vlc_mutex_unlock( &p_intf->change_lock );
+    vlc_mutex_unlock( &p_sys->lock );
 
     return VLC_SUCCESS;
 }