/*****************************************************************************
* Preamble
*****************************************************************************/
-#include <stdlib.h> /* malloc(), free() */
#include <vlc/vlc.h>
#include <vlc_interface.h>
TELNETHOST_LONGTEXT, VLC_TRUE );
add_integer( "telnet-port", TELNETPORT_DEFAULT, NULL, TELNETPORT_TEXT,
TELNETPORT_LONGTEXT, VLC_TRUE );
- add_string( "telnet-password", TELNETPWD_DEFAULT, NULL, TELNETPWD_TEXT,
+ add_password( "telnet-password", TELNETPWD_DEFAULT, NULL, TELNETPWD_TEXT,
TELNETPWD_LONGTEXT, VLC_TRUE );
set_description( _("VLM remote control interface") );
add_category_hint( "VLM", NULL, VLC_FALSE );
} telnet_client_t;
static char *MessageToString( vlm_message_t *, int );
-static void Write_message( telnet_client_t *, vlm_message_t *, char *, int );
+static void Write_message( telnet_client_t *, vlm_message_t *, const char *, int );
struct intf_sys_t
{
for( i = 0; i < p_sys->i_clients; i++ )
{
telnet_client_t *cl = p_sys->clients[i];
-
net_Close( cl->fd );
free( cl );
+ p_sys->clients[i] = NULL;
}
if( p_sys->clients != NULL ) free( p_sys->clients );
/* if a new client wants to communicate */
fd = net_Accept( p_intf, p_sys->pi_fd, p_sys->i_clients > 0 ? 0 : -1 );
- if( fd > 0 )
+ if( fd != -1 )
{
- telnet_client_t *cl;
-
- /* to be non blocking */
-#if defined( WIN32 ) || defined( UNDER_CE )
+ telnet_client_t *cl = malloc( sizeof( telnet_client_t ));
+ if( cl )
{
- unsigned long i_dummy = 1;
- ioctlsocket( fd, FIONBIO, &i_dummy );
+ memset( cl, 0, sizeof(telnet_client_t) );
+ cl->i_tel_cmd = 0;
+ cl->fd = fd;
+ cl->buffer_write = NULL;
+ cl->p_buffer_write = cl->buffer_write;
+ Write_message( cl, NULL,
+ "Password: \xff\xfb\x01" , WRITE_MODE_PWD );
+
+ TAB_APPEND( p_sys->i_clients, p_sys->clients, cl );
+ }
+ else
+ {
+ net_Close( fd );
+ continue;
}
-#else
- fcntl( fd, F_SETFL, O_NONBLOCK );
-#endif
- cl = malloc( sizeof( telnet_client_t ));
- cl->i_tel_cmd = 0;
- cl->fd = fd;
- cl->buffer_write = NULL;
- cl->p_buffer_write = cl->buffer_write;
- Write_message( cl, NULL,
- _( "Password: \xff\xfb\x01" ), WRITE_MODE_PWD );
-
- TAB_APPEND( p_sys->i_clients, p_sys->clients, cl );
}
/* to do a proper select */
{
telnet_client_t *cl = p_sys->clients[i];
- if( cl->i_mode == WRITE_MODE_PWD || cl->i_mode == WRITE_MODE_CMD )
+ if( (cl->i_mode == WRITE_MODE_PWD) || (cl->i_mode == WRITE_MODE_CMD) )
{
FD_SET( cl->fd , &fds_write );
}
timeout.tv_usec = 500*1000;
i_ret = select( i_handle_max + 1, &fds_read, &fds_write, 0, &timeout );
- if( i_ret == -1 && errno != EINTR )
+ if( (i_ret == -1) && (errno != EINTR) )
{
msg_Warn( p_intf, "cannot select sockets" );
msleep( 1000 );
{
telnet_client_t *cl = p_sys->clients[i];
- if( FD_ISSET(cl->fd , &fds_write) && cl->i_buffer_write > 0 )
+ if( FD_ISSET(cl->fd , &fds_write) && (cl->i_buffer_write > 0) )
{
- i_len = send( cl->fd , cl->p_buffer_write ,
- cl->i_buffer_write , 0 );
+ i_len = send( cl->fd, cl->p_buffer_write ,
+ cl->i_buffer_write, 0 );
if( i_len > 0 )
{
cl->p_buffer_write += i_len;
int i_end = 0;
int i_recv;
- while( (i_recv=recv( cl->fd, cl->p_buffer_read, 1, 0 )) > 0 &&
- cl->p_buffer_read - cl->buffer_read < 999 )
+ while( ((i_recv=recv( cl->fd, cl->p_buffer_read, 1, 0 )) > 0) &&
+ ((cl->p_buffer_read - cl->buffer_read) < 999) )
{
switch( cl->i_tel_cmd )
{
if( i_end != 0 ) break;
}
- if( cl->p_buffer_read - cl->buffer_read == 999 )
+ if( (cl->p_buffer_read - cl->buffer_read) == 999 )
{
- Write_message( cl, NULL, _( "Line too long\r\n" ),
+ Write_message( cl, NULL, "Line too long\r\n",
cl->i_mode + 2 );
}
- if (i_recv == 0)
+ if( i_recv == 0 || ( i_recv == -1 && errno != EAGAIN && errno != 0 ) )
{
net_Close( cl->fd );
TAB_REMOVE( p_intf->p_sys->i_clients ,
*cl->p_buffer_read == '\n' )
{
*cl->p_buffer_read = '\0';
- if( strcmp( psz_password, cl->buffer_read ) == 0 )
+ if( !psz_password || !strcmp( psz_password, cl->buffer_read ) )
{
- Write_message( cl, NULL, _( "\xff\xfc\x01\r\nWelcome, "
- "Master\r\n> " ), WRITE_MODE_CMD );
+ Write_message( cl, NULL, "\xff\xfc\x01\r\nWelcome, "
+ "Master\r\n> ", WRITE_MODE_CMD );
}
else
{
/* wrong password */
Write_message( cl, NULL,
- _( "\r\nWrong password.\r\nPassword: " ),
+ "\r\nWrong password.\r\nPassword: ",
WRITE_MODE_PWD );
}
}
else if( !strncmp( cl->buffer_read, "shutdown", 8 ) )
{
msg_Err( p_intf, "shutdown requested" );
- p_intf->p_libvlc->b_die = VLC_TRUE;
+ vlc_object_kill( p_intf->p_libvlc );
+ }
+ else if( *cl->buffer_read == '@'
+ && strchr( cl->buffer_read, ' ' ) )
+ {
+ /* Module specific commands (use same syntax as in the
+ * rc interface) */
+ char *psz_name = cl->buffer_read + 1;
+ char *psz_cmd, *psz_arg, *psz_msg;
+ int i_ret;
+
+ psz_cmd = strchr( cl->buffer_read, ' ' );
+ *psz_cmd = '\0'; psz_cmd++;
+ if( ( psz_arg = strchr( psz_cmd, '\n' ) ) ) *psz_arg = '\0';
+ if( ( psz_arg = strchr( psz_cmd, '\r' ) ) ) *psz_arg = '\0';
+ if( ( psz_arg = strchr( psz_cmd, ' ' ) )
+ && *psz_arg )
+ {
+ *psz_arg = '\0';
+ psz_arg++;
+ }
+
+ i_ret = var_Command( p_intf, psz_name, psz_cmd, psz_arg,
+ &psz_msg );
+
+ if( psz_msg )
+ {
+ vlm_message_t *message;
+ message = vlm_MessageNew( "Module command", psz_msg );
+ Write_message( cl, message, NULL, WRITE_MODE_CMD );
+ vlm_MessageDelete( message );
+ free( psz_msg );
+ }
}
else
{
vlm_MessageNew( "logout, quit, exit" , NULL ) );
vlm_MessageAdd( p_my_help,
vlm_MessageNew( "shutdown" , NULL ) );
+ vlm_MessageAdd( p_my_help,
+ vlm_MessageNew( "@moduleinstance command argument",
+ NULL) );
vlm_MessageAdd( message, p_my_help );
}
Write_message( cl, message, NULL, WRITE_MODE_CMD );
}
}
}
+ if( psz_password )
+ free( psz_password );
}
static void Write_message( telnet_client_t *client, vlm_message_t *message,
- char *string_message, int i_mode )
+ const char *string_message, int i_mode )
{
char *psz_message;
projects / vlc / blobdiff