]> git.sesse.net Git - vlc/blobdiff - modules/demux/asf/libasf.c
Remove useless test before a free (again).
[vlc] / modules / demux / asf / libasf.c
index 091e2cf08d6e8e28f0c63b9e2766d237baba9b2e..0ac06b7dab5462374b0ecf67dabe5a85183f7d8a 100644 (file)
@@ -1,7 +1,7 @@
 /*****************************************************************************
  * libasf.c : asf stream demux module for vlc
  *****************************************************************************
- * Copyright (C) 2001-2003 VideoLAN
+ * Copyright (C) 2001-2003 the VideoLAN team
  * $Id$
  *
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 
-#include <stdlib.h>                                      /* malloc(), free() */
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
 
 #include <vlc/vlc.h>
-#include <vlc/input.h>
 
-#include "codecs.h"                        /* BITMAPINFOHEADER, WAVEFORMATEX */
+
+#include <vlc_demux.h>
+
+#include <vlc_codecs.h>                   /* BITMAPINFOHEADER, WAVEFORMATEX */
 #include "libasf.h"
 
 #define ASF_DEBUG 1
 
-#define FREE( p ) \
-    if( p ) {free( p ); p = NULL; }
-
 #define GUID_FMT "0x%x-0x%x-0x%x-0x%2.2x%2.2x%2.2x%2.2x%2.2x%2.2x%2.2x%2.2x"
 #define GUID_PRINT( guid )  \
     (guid).v1,              \
@@ -51,7 +52,7 @@ static int ASF_ReadObject( stream_t *, asf_object_t *,  asf_object_t * );
 /****************************************************************************
  * GUID functions
  ****************************************************************************/
-void ASF_GetGUID( guid_t *p_guid, uint8_t *p_data )
+void ASF_GetGUID( guid_t *p_guid, const uint8_t *p_data )
 {
     p_guid->v1 = GetDWLE( p_data );
     p_guid->v2 = GetWLE( p_data + 4);
@@ -77,7 +78,7 @@ int ASF_CmpGUID( const guid_t *p_guid1, const guid_t *p_guid2 )
 static int ASF_ReadObjectCommon( stream_t *s, asf_object_t *p_obj )
 {
     asf_object_common_t *p_common = (asf_object_common_t*)p_obj;
-    uint8_t             *p_peek;
+    const uint8_t *p_peek;
 
     if( stream_Peek( s, &p_peek, 24 ) < 24 )
     {
@@ -133,6 +134,7 @@ static int ASF_NextObject( stream_t *s, asf_object_t *p_obj )
 
 static void ASF_FreeObject_Null( asf_object_t *pp_obj )
 {
+    VLC_UNUSED(pp_obj);
     return;
 }
 
@@ -141,7 +143,7 @@ static int  ASF_ReadObject_Header( stream_t *s, asf_object_t *p_obj )
     asf_object_header_t *p_hdr = (asf_object_header_t*)p_obj;
     asf_object_t        *p_subobj;
     int                 i_peek;
-    uint8_t             *p_peek;
+    const uint8_t       *p_peek;
 
     if( ( i_peek = stream_Peek( s, &p_peek, 30 ) ) < 30 )
     {
@@ -187,7 +189,7 @@ static int ASF_ReadObject_Data( stream_t *s, asf_object_t *p_obj )
 {
     asf_object_data_t *p_data = (asf_object_data_t*)p_obj;
     int               i_peek;
-    uint8_t           *p_peek;
+    const uint8_t     *p_peek;
 
     if( ( i_peek = stream_Peek( s, &p_peek, 50 ) ) < 50 )
     {
@@ -212,18 +214,21 @@ static int ASF_ReadObject_Data( stream_t *s, asf_object_t *p_obj )
 static int ASF_ReadObject_Index( stream_t *s, asf_object_t *p_obj )
 {
     asf_object_index_t *p_index = (asf_object_index_t*)p_obj;
-    int                i_peek;
-    uint8_t            *p_peek;
+    const uint8_t      *p_peek;
+    int                 i;
 
-    if( ( i_peek = stream_Peek( s, &p_peek, 56 ) ) < 56 )
+    if( stream_Peek( s, &p_peek, p_index->i_object_size ) <
+        (int)p_index->i_object_size )
     {
-       return VLC_EGENERIC;
+        /* Just ignore */
+        return VLC_SUCCESS;
     }
+
     ASF_GetGUID( &p_index->i_file_id, p_peek + 24 );
     p_index->i_index_entry_time_interval = GetQWLE( p_peek + 40 );
     p_index->i_max_packet_count = GetDWLE( p_peek + 48 );
     p_index->i_index_entry_count = GetDWLE( p_peek + 52 );
-    p_index->index_entry = NULL; /* FIXME */
+    p_index->index_entry = NULL;
 
 #ifdef ASF_DEBUG
     msg_Dbg( s,
@@ -236,6 +241,20 @@ static int ASF_ReadObject_Index( stream_t *s, asf_object_t *p_obj )
             (long int)p_index->i_index_entry_count );
 #endif
 
+    /* Sanity checking */
+    if( p_index->i_index_entry_count > (p_index->i_object_size - 56) / 6 )
+        p_index->i_index_entry_count = (p_index->i_object_size - 56) / 6;
+
+    p_index->index_entry = malloc( sizeof(asf_index_entry_t) *
+                                   p_index->i_index_entry_count );
+
+    for( i = 0, p_peek += 56; i < (int)p_index->i_index_entry_count;
+         i++, p_peek += 6 )
+    {
+        p_index->index_entry[i].i_packet_number = GetDWLE( p_peek );
+        p_index->index_entry[i].i_packet_count = GetDWLE( p_peek + 4 );
+    }
+
     return VLC_SUCCESS;
 }
 
@@ -243,16 +262,16 @@ static void ASF_FreeObject_Index( asf_object_t *p_obj )
 {
     asf_object_index_t *p_index = (asf_object_index_t*)p_obj;
 
-    FREE( p_index->index_entry );
+    FREENULL( p_index->index_entry );
 }
 
 static int ASF_ReadObject_file_properties( stream_t *s, asf_object_t *p_obj )
 {
     asf_object_file_properties_t *p_fp = (asf_object_file_properties_t*)p_obj;
-    int      i_peek;
-    uint8_t  *p_peek;
+    int           i_peek;
+    const uint8_t *p_peek;
 
-    if( ( i_peek = stream_Peek( s, &p_peek,  92) ) < 92 )
+    if( ( i_peek = stream_Peek( s, &p_peek,  104 ) ) < 104 )
     {
        return VLC_EGENERIC;
     }
@@ -260,9 +279,10 @@ static int ASF_ReadObject_file_properties( stream_t *s, asf_object_t *p_obj )
     p_fp->i_file_size = GetQWLE( p_peek + 40 );
     p_fp->i_creation_date = GetQWLE( p_peek + 48 );
     p_fp->i_data_packets_count = GetQWLE( p_peek + 56 );
-    p_fp->i_play_duration = GetQWLE( p_peek + 64 );
-    p_fp->i_send_duration = GetQWLE( p_peek + 72 );
-    p_fp->i_preroll = GetQWLE( p_peek + 80 );
+    p_fp->i_send_duration = GetQWLE( p_peek + 64 );
+    p_fp->i_play_duration = GetQWLE( p_peek + 72 );
+    p_fp->i_preroll = GetDWLE( p_peek + 80 );
+    p_fp->i_unknown = GetDWLE( p_peek + 84 );
     p_fp->i_flags = GetDWLE( p_peek + 88 );
     p_fp->i_min_data_packet_size = GetDWLE( p_peek + 92 );
     p_fp->i_max_data_packet_size = GetDWLE( p_peek + 96 );
@@ -272,13 +292,13 @@ static int ASF_ReadObject_file_properties( stream_t *s, asf_object_t *p_obj )
     msg_Dbg( s,
             "read \"file properties object\" file_id:" GUID_FMT
             " file_size:"I64Fd" creation_date:"I64Fd" data_packets_count:"
-            I64Fd" play_duration:"I64Fd" send_duration:"I64Fd" preroll:"
-            I64Fd" flags:%d min_data_packet_size:%d max_data_packet_size:%d "
-            "max_bitrate:%d",
+            I64Fd" send_duration:"I64Fd" play_duration:"I64Fd" preroll:%d"
+            "unknown:%d flags:%d min_data_packet_size:%d "
+            "max_data_packet_size:%d max_bitrate:%d",
             GUID_PRINT( p_fp->i_file_id ), p_fp->i_file_size,
             p_fp->i_creation_date, p_fp->i_data_packets_count,
-            p_fp->i_play_duration, p_fp->i_send_duration,
-            p_fp->i_preroll, p_fp->i_flags,
+            p_fp->i_send_duration, p_fp->i_play_duration,
+            p_fp->i_preroll, p_fp->i_unknown, p_fp->i_flags,
             p_fp->i_min_data_packet_size, p_fp->i_max_data_packet_size,
             p_fp->i_max_bitrate );
 #endif
@@ -294,10 +314,10 @@ static void ASF_FreeObject_metadata( asf_object_t *p_obj )
 
     for( i = 0; i < p_meta->i_record_entries_count; i++ )
     {
-        if( p_meta->record[i].psz_name ) free( p_meta->record[i].psz_name );
-        if( p_meta->record[i].p_data ) free( p_meta->record[i].p_data );
+        free( p_meta->record[i].psz_name );
+        free( p_meta->record[i].p_data );
     }
-    if( p_meta->record ) free( p_meta->record );
+    free( p_meta->record );
 }
 
 static int ASF_ReadObject_metadata( stream_t *s, asf_object_t *p_obj )
@@ -306,7 +326,10 @@ static int ASF_ReadObject_metadata( stream_t *s, asf_object_t *p_obj )
         (asf_object_metadata_t *)p_obj;
 
     int i_peek, i_entries, i;
-    uint8_t *p_peek;
+    const uint8_t *p_peek;
+#ifdef ASF_DEBUG
+    unsigned int j;
+#endif
 
     p_meta->i_record_entries_count = 0;
     p_meta->record = 0;
@@ -401,10 +424,10 @@ static int ASF_ReadObject_metadata( stream_t *s, asf_object_t *p_obj )
     msg_Dbg( s,
             "read \"metadata object\" %d entries",
             p_meta->i_record_entries_count );
-    for( i = 0; i < p_meta->i_record_entries_count; i++ )
+    for( j = 0; j < p_meta->i_record_entries_count; j++ )
     {
-        asf_metadata_record_t *p_rec = &p_meta->record[i];
-        
+        asf_metadata_record_t *p_rec = &p_meta->record[j];
+
         if( p_rec->i_type == ASF_METADATA_TYPE_STRING )
             msg_Dbg( s, "  - %s=%s",
                      p_rec->psz_name, p_rec->p_data );
@@ -425,7 +448,7 @@ static int ASF_ReadObject_header_extension( stream_t *s, asf_object_t *p_obj )
     asf_object_header_extension_t *p_he =
         (asf_object_header_extension_t *)p_obj;
     int     i_peek;
-    uint8_t *p_peek;
+    const uint8_t *p_peek;
 
     if( ( i_peek = stream_Peek( s, &p_peek, p_he->i_object_size ) ) <  46)
     {
@@ -482,20 +505,21 @@ static void ASF_FreeObject_header_extension( asf_object_t *p_obj )
     asf_object_header_extension_t *p_he =
         (asf_object_header_extension_t *)p_obj;
 
-    FREE( p_he->p_header_extension_data );
+    FREENULL( p_he->p_header_extension_data );
 }
 
 static int ASF_ReadObject_stream_properties( stream_t *s, asf_object_t *p_obj )
 {
     asf_object_stream_properties_t *p_sp =
                     (asf_object_stream_properties_t*)p_obj;
-    int     i_peek;
-    uint8_t *p_peek;
+    size_t        i_peek;
+    const uint8_t *p_peek;
 
-    if( ( i_peek = stream_Peek( s, &p_peek,  p_sp->i_object_size ) ) < 74 )
+    if( ( i_peek = stream_Peek( s, &p_peek,  p_sp->i_object_size ) ) < 78 )
     {
        return VLC_EGENERIC;
     }
+
     ASF_GetGUID( &p_sp->i_stream_type, p_peek + 24 );
     ASF_GetGUID( &p_sp->i_error_correction_type, p_peek + 40 );
     p_sp->i_time_offset = GetQWLE( p_peek + 56 );
@@ -504,21 +528,42 @@ static int ASF_ReadObject_stream_properties( stream_t *s, asf_object_t *p_obj )
     p_sp->i_flags = GetWLE( p_peek + 72 );
         p_sp->i_stream_number = p_sp->i_flags&0x07f;
     p_sp->i_reserved = GetDWLE( p_peek + 74 );
+    i_peek -= 78;
+
     if( p_sp->i_type_specific_data_length )
     {
+        if( i_peek < p_sp->i_type_specific_data_length )
+            return VLC_EGENERIC;
+
         p_sp->p_type_specific_data =
             malloc( p_sp->i_type_specific_data_length );
+        if( p_sp->p_type_specific_data == NULL )
+            return VLC_ENOMEM;
+
         memcpy( p_sp->p_type_specific_data, p_peek + 78,
                 p_sp->i_type_specific_data_length );
+        i_peek -= p_sp->i_type_specific_data_length;
     }
     else
     {
         p_sp->p_type_specific_data = NULL;
     }
+
     if( p_sp->i_error_correction_data_length )
     {
+        if( i_peek < p_sp->i_error_correction_data_length )
+        {
+            free( p_sp->p_type_specific_data );
+            return VLC_EGENERIC;
+        }
+
         p_sp->p_error_correction_data =
             malloc( p_sp->i_error_correction_data_length );
+        if( p_sp->p_error_correction_data == NULL )
+        {
+            free( p_sp->p_type_specific_data );
+            return VLC_ENOMEM;
+        }
         memcpy( p_sp->p_error_correction_data,
                 p_peek + 78 + p_sp->i_type_specific_data_length,
                 p_sp->i_error_correction_data_length );
@@ -551,8 +596,8 @@ static void ASF_FreeObject_stream_properties( asf_object_t *p_obj )
     asf_object_stream_properties_t *p_sp =
                 (asf_object_stream_properties_t*)p_obj;
 
-    FREE( p_sp->p_type_specific_data );
-    FREE( p_sp->p_error_correction_data );
+    FREENULL( p_sp->p_type_specific_data );
+    FREENULL( p_sp->p_error_correction_data );
 }
 
 
@@ -560,7 +605,7 @@ static int ASF_ReadObject_codec_list( stream_t *s, asf_object_t *p_obj )
 {
     asf_object_codec_list_t *p_cl = (asf_object_codec_list_t*)p_obj;
     int     i_peek;
-    uint8_t *p_peek, *p_data;
+    const uint8_t *p_peek, *p_data;
 
     unsigned int i_codec;
 
@@ -655,12 +700,12 @@ static void ASF_FreeObject_codec_list( asf_object_t *p_obj )
     for( i_codec = 0; i_codec < p_cl->i_codec_entries_count; i_codec++ )
     {
 #define codec p_cl->codec[i_codec]
-        FREE( codec.psz_name );
-        FREE( codec.psz_description );
-        FREE( codec.p_information );
+        FREENULL( codec.psz_name );
+        FREENULL( codec.psz_description );
+        FREENULL( codec.p_information );
 #undef  codec
     }
-    FREE( p_cl->codec );
+    FREENULL( p_cl->codec );
 }
 
 /* Microsoft should go to hell. This time the length give number of bytes
@@ -669,18 +714,28 @@ static int ASF_ReadObject_content_description(stream_t *s, asf_object_t *p_obj)
 {
     asf_object_content_description_t *p_cd =
         (asf_object_content_description_t *)p_obj;
-    uint8_t *p_peek, *p_data;
-    int i_peek;
-    int i_len, i_title, i_author, i_copyright, i_description, i_rating;
+    const uint8_t *p_peek, *p_data;
+    int i_peek, i_title, i_artist, i_copyright, i_description, i_rating;
+    vlc_iconv_t cd = (vlc_iconv_t)-1;
+    const char *ib = NULL;
+    char *ob = NULL;
+    size_t i_ibl, i_obl, i_len;
+
+    cd = vlc_iconv_open("UTF-8", "UTF-16LE");
+    if ( cd == (vlc_iconv_t)-1 ) {
+        msg_Err( s, "vlc_iconv_open failed" );
+        return VLC_EGENERIC;
+    }
 
+/* FIXME i_size*3 is the worst case. */
 #define GETSTRINGW( psz_str, i_size ) \
-   psz_str = calloc( i_size/2 + 1, sizeof( char ) ); \
-   for( i_len = 0; i_len < i_size/2; i_len++ ) \
-   { \
-       psz_str[i_len] = GetWLE( p_data + 2*i_len ); \
-   } \
-   psz_str[i_size/2] = '\0'; \
-   p_data += i_size;
+    psz_str = (char *)calloc( i_size*3+1, sizeof( char ) ); \
+    ib = (const char *)p_data; \
+    ob = psz_str; \
+    i_ibl = i_size; \
+    i_obl = i_size*3; \
+    i_len = vlc_iconv(cd, &ib, &i_ibl, &ob, &i_obl); \
+    p_data += i_size;
 
     if( ( i_peek = stream_Peek( s, &p_peek, p_cd->i_object_size ) ) < 34 )
     {
@@ -689,13 +744,13 @@ static int ASF_ReadObject_content_description(stream_t *s, asf_object_t *p_obj)
     p_data = p_peek + 24;
 
     i_title = GetWLE( p_data ); p_data += 2;
-    i_author= GetWLE( p_data ); p_data += 2;
+    i_artist= GetWLE( p_data ); p_data += 2;
     i_copyright     = GetWLE( p_data ); p_data += 2;
     i_description   = GetWLE( p_data ); p_data += 2;
     i_rating        = GetWLE( p_data ); p_data += 2;
 
     GETSTRINGW( p_cd->psz_title, i_title );
-    GETSTRINGW( p_cd->psz_author, i_author );
+    GETSTRINGW( p_cd->psz_artist, i_artist );
     GETSTRINGW( p_cd->psz_copyright, i_copyright );
     GETSTRINGW( p_cd->psz_description, i_description );
     GETSTRINGW( p_cd->psz_rating, i_rating );
@@ -704,13 +759,15 @@ static int ASF_ReadObject_content_description(stream_t *s, asf_object_t *p_obj)
 
 #ifdef ASF_DEBUG
     msg_Dbg( s,
-             "Read \"content description object\" title:\"%s\" author:\"%s\" copyright:\"%s\" description:\"%s\" rating:\"%s\"",
+             "read \"content description object\" title:\"%s\" artist:\"%s\" copyright:\"%s\" description:\"%s\" rating:\"%s\"",
              p_cd->psz_title,
-             p_cd->psz_author,
+             p_cd->psz_artist,
              p_cd->psz_copyright,
              p_cd->psz_description,
              p_cd->psz_rating );
 #endif
+
+    vlc_iconv_close(cd);
     return VLC_SUCCESS;
 }
 
@@ -719,11 +776,11 @@ static void ASF_FreeObject_content_description( asf_object_t *p_obj)
     asf_object_content_description_t *p_cd =
         (asf_object_content_description_t *)p_obj;
 
-    FREE( p_cd->psz_title );
-    FREE( p_cd->psz_author );
-    FREE( p_cd->psz_copyright );
-    FREE( p_cd->psz_description );
-    FREE( p_cd->psz_rating );
+    FREENULL( p_cd->psz_title );
+    FREENULL( p_cd->psz_artist );
+    FREENULL( p_cd->psz_copyright );
+    FREENULL( p_cd->psz_description );
+    FREENULL( p_cd->psz_rating );
 }
 
 /* Language list: */
@@ -731,7 +788,7 @@ static int ASF_ReadObject_language_list(stream_t *s, asf_object_t *p_obj)
 {
     asf_object_language_list_t *p_ll =
         (asf_object_language_list_t*)p_obj;
-    uint8_t *p_peek, *p_data;
+    const uint8_t *p_peek, *p_data;
     int i_peek;
     int i;
 
@@ -764,10 +821,10 @@ static int ASF_ReadObject_language_list(stream_t *s, asf_object_t *p_obj)
     }
 
 #ifdef ASF_DEBUG
-    msg_Dbg( s, "Read \"language list object\" %d entries", 
+    msg_Dbg( s, "read \"language list object\" %d entries",
              p_ll->i_language );
     for( i = 0; i < p_ll->i_language; i++ )
-        msg_Dbg( s, "  - '%s'", 
+        msg_Dbg( s, "  - '%s'",
                  p_ll->ppsz_language[i] );
 #endif
     return VLC_SUCCESS;
@@ -780,8 +837,8 @@ static void ASF_FreeObject_language_list( asf_object_t *p_obj)
     int i;
 
     for( i = 0; i < p_ll->i_language; i++ )
-        FREE( p_ll->ppsz_language[i] );
-    FREE( p_ll->ppsz_language );
+        FREENULL( p_ll->ppsz_language[i] );
+    FREENULL( p_ll->ppsz_language );
 }
 
 /* Stream bitrate properties */
@@ -790,7 +847,7 @@ static int ASF_ReadObject_stream_bitrate_properties( stream_t *s,
 {
     asf_object_stream_bitrate_properties_t *p_sb =
         (asf_object_stream_bitrate_properties_t *)p_obj;
-    uint8_t *p_peek, *p_data;
+    const uint8_t *p_peek, *p_data;
     int i_peek;
     int i;
 
@@ -805,17 +862,17 @@ static int ASF_ReadObject_stream_bitrate_properties( stream_t *s,
     {
         p_sb->bitrate[i].i_stream_number = GetWLE( &p_data[0] )& 0x7f;
         p_sb->bitrate[i].i_avg_bitrate = GetDWLE( &p_data[2] );
-       
+
         p_data += 2+4;
     }
 
 #ifdef ASF_DEBUG
-    msg_Dbg( s,"Read \"stream bitrate properties object\"" );
+    msg_Dbg( s,"read \"stream bitrate properties object\"" );
     for( i = 0; i < p_sb->i_bitrate; i++ )
     {
         msg_Dbg( s,"  - stream=%d bitrate=%d",
                  p_sb->bitrate[i].i_stream_number,
-                 p_sb->bitrate[i].i_avg_bitrate ); 
+                 p_sb->bitrate[i].i_avg_bitrate );
     }
 #endif
     return VLC_SUCCESS;
@@ -829,7 +886,7 @@ static int ASF_ReadObject_extended_stream_properties( stream_t *s,
 {
     asf_object_extended_stream_properties_t *p_esp =
         (asf_object_extended_stream_properties_t*)p_obj;
-    uint8_t *p_peek, *p_data;
+    const uint8_t *p_peek, *p_data;
     int i_peek, i;
 
     if( ( i_peek = stream_Peek( s, &p_peek, p_esp->i_object_size ) ) < 88 )
@@ -851,7 +908,7 @@ static int ASF_ReadObject_extended_stream_properties( stream_t *s,
     p_esp->i_language_index = GetWLE( &p_data[50] );
     p_esp->i_average_time_per_frame= GetQWLE( &p_data[52] );
     p_esp->i_stream_name_count = GetWLE( &p_data[60] );
-    p_esp->i_payload_extention_system_count = GetWLE( &p_data[62] );
+    p_esp->i_payload_extension_system_count = GetWLE( &p_data[62] );
 
     p_data += 64;
 
@@ -868,7 +925,7 @@ static int ASF_ReadObject_extended_stream_properties( stream_t *s,
         p_esp->pi_stream_name_language[i] = GetWLE( &p_data[0] );
         i_size = GetWLE( &p_data[2] );
         p_data += 2;
-        
         psz = calloc( i_size/2 + 1, sizeof( char ) );
         for( i_len = 0; i_len < i_size/2; i_len++ )
         {
@@ -880,7 +937,7 @@ static int ASF_ReadObject_extended_stream_properties( stream_t *s,
         p_esp->ppsz_stream_name[i] = psz;
     }
 
-    for( i = 0; i < p_esp->i_payload_extention_system_count; i++ )
+    for( i = 0; i < p_esp->i_payload_extension_system_count; i++ )
     {
         /* Skip them */
         int i_size = GetDWLE( &p_data[16 + 2] );
@@ -894,7 +951,7 @@ static int ASF_ReadObject_extended_stream_properties( stream_t *s,
         asf_object_t *p_sp;
         /* Cannot fail as peek succeed */
         stream_Read( s, NULL, p_data - p_peek );
-        
         p_sp = malloc( sizeof( asf_object_t ) );
 
         if( ASF_ReadObject( s, p_sp, NULL ) )
@@ -904,12 +961,12 @@ static int ASF_ReadObject_extended_stream_properties( stream_t *s,
         else
         {
             /* This p_sp will be inserted by ReadRoot later */
-            p_esp->p_sp = p_sp;
+            p_esp->p_sp = (asf_object_stream_properties_t*)p_sp;
         }
     }
 
 #ifdef ASF_DEBUG
-    msg_Dbg( s, "Read \"extended stream properties object\":" );
+    msg_Dbg( s, "read \"extended stream properties object\":" );
     msg_Dbg( s, "  - start="I64Fd" end="I64Fd,
              p_esp->i_start_time, p_esp->i_end_time );
     msg_Dbg( s, "  - data bitrate=%d buffer=%d initial fullness=%d",
@@ -931,8 +988,8 @@ static int ASF_ReadObject_extended_stream_properties( stream_t *s,
         msg_Dbg( s, "     - lang id=%d name=%s",
                  p_esp->pi_stream_name_language[i],
                  p_esp->ppsz_stream_name[i] );
-    msg_Dbg( s, "  - payload extention system count=%d",
-             p_esp->i_payload_extention_system_count );
+    msg_Dbg( s, "  - payload extension system count=%d",
+             p_esp->i_payload_extension_system_count );
 #endif
     return VLC_SUCCESS;
 }
@@ -943,9 +1000,9 @@ static void ASF_FreeObject_extended_stream_properties( asf_object_t *p_obj)
     int i;
 
     for( i = 0; i < p_esp->i_stream_name_count; i++ )
-        FREE( p_esp->ppsz_stream_name[i] );
-    FREE( p_esp->pi_stream_name_language );
-    FREE( p_esp->ppsz_stream_name );
+        FREENULL( p_esp->ppsz_stream_name[i] );
+    FREENULL( p_esp->pi_stream_name_language );
+    FREENULL( p_esp->ppsz_stream_name );
 }
 
 
@@ -954,7 +1011,7 @@ static int ASF_ReadObject_advanced_mutual_exclusion( stream_t *s,
 {
     asf_object_advanced_mutual_exclusion_t *p_ae =
         (asf_object_advanced_mutual_exclusion_t *)p_obj;
-    uint8_t *p_peek, *p_data;
+    const uint8_t *p_peek, *p_data;
     int i_peek;
     int i;
 
@@ -974,9 +1031,9 @@ static int ASF_ReadObject_advanced_mutual_exclusion( stream_t *s,
         p_ae->pi_stream_number[i] = GetWLE( p_data );
         p_data += 2;
     }
-        
 #ifdef ASF_DEBUG
-    msg_Dbg( s, "Read \"advanced mutual exclusion object\"" );
+    msg_Dbg( s, "read \"advanced mutual exclusion object\"" );
     for( i = 0; i < p_ae->i_stream_number_count; i++ )
         msg_Dbg( s, "  - stream=%d", p_ae->pi_stream_number[i] );
 #endif
@@ -987,7 +1044,7 @@ static void ASF_FreeObject_advanced_mutual_exclusion( asf_object_t *p_obj)
     asf_object_advanced_mutual_exclusion_t *p_ae =
         (asf_object_advanced_mutual_exclusion_t *)p_obj;
 
-    FREE( p_ae->pi_stream_number );
+    FREENULL( p_ae->pi_stream_number );
 }
 
 
@@ -996,7 +1053,7 @@ static int ASF_ReadObject_stream_prioritization( stream_t *s,
 {
     asf_object_stream_prioritization_t *p_sp =
         (asf_object_stream_prioritization_t *)p_obj;
-    uint8_t *p_peek, *p_data;
+    const uint8_t *p_peek, *p_data;
     int i_peek;
     int i;
 
@@ -1018,7 +1075,7 @@ static int ASF_ReadObject_stream_prioritization( stream_t *s,
         p_sp->pi_priority_flag[i] = GetWLE( p_data ); p_data += 2;
     }
 #ifdef ASF_DEBUG
-    msg_Dbg( s, "Read \"stream prioritization object\"" );
+    msg_Dbg( s, "read \"stream prioritization object\"" );
     for( i = 0; i < p_sp->i_priority_count; i++ )
         msg_Dbg( s, "  - Stream:%d flags=0x%x",
                  p_sp->pi_priority_stream_number[i],
@@ -1031,8 +1088,8 @@ static void ASF_FreeObject_stream_prioritization( asf_object_t *p_obj)
     asf_object_stream_prioritization_t *p_sp =
         (asf_object_stream_prioritization_t *)p_obj;
 
-    FREE( p_sp->pi_priority_stream_number );
-    FREE( p_sp->pi_priority_flag );
+    FREENULL( p_sp->pi_priority_stream_number );
+    FREENULL( p_sp->pi_priority_flag );
 }
 
 
@@ -1041,7 +1098,7 @@ static int ASF_ReadObject_extended_content_description( stream_t *s,
 {
     asf_object_extended_content_description_t *p_ec =
         (asf_object_extended_content_description_t *)p_obj;
-    uint8_t *p_peek, *p_data;
+    const uint8_t *p_peek, *p_data;
     int i_peek;
     int i;
 
@@ -1114,7 +1171,7 @@ static int ASF_ReadObject_extended_content_description( stream_t *s,
             p_ec->ppsz_value[i] = NULL;
 
         p_data += i_size;
-        
 
 
 #undef GETSTRINGW
@@ -1122,7 +1179,7 @@ static int ASF_ReadObject_extended_content_description( stream_t *s,
     }
 
 #ifdef ASF_DEBUG
-    msg_Dbg( s, "Read \"extended content description object\"" );
+    msg_Dbg( s, "read \"extended content description object\"" );
     for( i = 0; i < p_ec->i_count; i++ )
         msg_Dbg( s, "  - '%s' = '%s'",
                  p_ec->ppsz_name[i],
@@ -1138,9 +1195,11 @@ static void ASF_FreeObject_extended_content_description( asf_object_t *p_obj)
 
     for( i = 0; i < p_ec->i_count; i++ )
     {
-        FREE( p_ec->ppsz_name[i] );
-        FREE( p_ec->ppsz_value[i] );
+        FREENULL( p_ec->ppsz_name[i] );
+        FREENULL( p_ec->ppsz_value[i] );
     }
+    FREENULL( p_ec->ppsz_name );
+    FREENULL( p_ec->ppsz_value );
 }
 
 
@@ -1149,7 +1208,8 @@ static int ASF_ReadObject_XXX(stream_t *s, asf_object_t *p_obj)
 {
     asf_object_XXX_t *p_XX =
         (asf_object_XXX_t *)p_obj;
-    uint8_t *p_peek, *p_data;
+    const uint8_t *p_peek;
+    uint8_t *p_data;
     int i_peek;
 
     if( ( i_peek = stream_Peek( s, &p_peek, p_XX->i_object_size ) ) < XXX )
@@ -1276,7 +1336,7 @@ static int ASF_ReadObject( stream_t *s, asf_object_t *p_obj,
     }
 
     /* link this object with father */
-    if( p_father )
+    if( p_father && ! i_result )
     {
         if( p_father->common.p_first )
         {
@@ -1347,7 +1407,7 @@ static void ASF_FreeObject( stream_t *s, asf_object_t *p_obj )
 static const struct
 {
     const guid_t *p_id;
-    char *psz_name;
+    const char *psz_name;
 } ASF_ObjectDumpDebugInfo[] =
 {
     { &asf_object_header_guid, "Header" },
@@ -1356,7 +1416,7 @@ static const struct
     { &asf_object_file_properties_guid, "File Properties" },
     { &asf_object_stream_properties_guid, "Stream Properties" },
     { &asf_object_content_description_guid, "Content Description" },
-    { &asf_object_header_extension_guid, "Header Extention" },
+    { &asf_object_header_extension_guid, "Header Extension" },
     { &asf_object_metadata_guid, "Metadata" },
     { &asf_object_codec_list_guid, "Codec List" },
     { &asf_object_marker_guid, "Marker" },
@@ -1381,7 +1441,7 @@ static void ASF_ObjectDumpDebug( vlc_object_t *p_obj,
     char str[1024];
     int i;
     union asf_object_u *p_child;
-    char *psz_name;
+    const char *psz_name;
 
     /* Find the name */
     for( i = 0; ASF_ObjectDumpDebugInfo[i].p_id != NULL; i++ )