{
asf_object_metadata_t *p_meta = &p_obj->metadata;
- for( unsigned int i = 0; i < p_meta->i_record_entries_count; i++ )
+ for( uint32_t i = 0; i < p_meta->i_record_entries_count; i++ )
{
free( p_meta->record[i].psz_name );
free( p_meta->record[i].p_data );
asf_object_metadata_t *p_meta = &p_obj->metadata;
int i_peek;
- unsigned int i;
+ uint32_t i;
const uint8_t *p_peek, *p_data;
if( ( i_peek = stream_Peek( s, &p_peek, p_meta->i_object_size ) ) <
for( i = 0; i < p_meta->i_record_entries_count; i++ )
{
asf_metadata_record_t *p_record = &p_meta->record[i];
- int i_name;
- int i_data;
+ uint16_t i_name;
+ uint32_t i_data;
if( !ASF_HAVE( 2+2+2+2+4 ) )
break;
#ifdef ASF_DEBUG
msg_Dbg( s,
- "read \"metadata object\" %d entries",
+ "read \"metadata object\" %"PRIu32" entries",
p_meta->i_record_entries_count );
- for( unsigned int j = 0; j < p_meta->i_record_entries_count; j++ )
+ for( uint32_t j = 0; j < p_meta->i_record_entries_count; j++ )
{
asf_metadata_record_t *p_rec = &p_meta->record[j];
msg_Dbg( s, " - %s=%s",
p_rec->psz_name, p_rec->p_data );
else if( p_rec->i_type == ASF_METADATA_TYPE_BYTE )
- msg_Dbg( s, " - %s (%i bytes)",
+ msg_Dbg( s, " - %s (%u bytes)",
p_rec->psz_name, p_rec->i_data );
else
- msg_Dbg( s, " - %s=%"PRId64,
+ msg_Dbg( s, " - %s=%"PRIu64,
p_rec->psz_name, p_rec->i_val );
}
#endif
#ifdef ASF_DEBUG
msg_Dbg( s,
"read \"header extension object\" reserved1:" GUID_FMT
- " reserved2:%d header_extension_size:%d",
+ " reserved2:%u header_extension_size:%"PRIu32,
GUID_PRINT( p_he->i_reserved1 ), p_he->i_reserved2,
p_he->i_header_extension_size );
#endif
p_sp->i_type_specific_data_length = GetDWLE( p_peek + 64 );
p_sp->i_error_correction_data_length = GetDWLE( p_peek + 68 );
p_sp->i_flags = GetWLE( p_peek + 72 );
- p_sp->i_stream_number = p_sp->i_flags&0x07f;
+ p_sp->i_stream_number = p_sp->i_flags&0x07f;
+ if ( p_sp->i_stream_number > ASF_MAX_STREAMNUMBER )
+ return VLC_EGENERIC;
p_sp->i_reserved = GetDWLE( p_peek + 74 );
i_peek -= 78;
#ifdef ASF_DEBUG
msg_Dbg( s,
"read \"stream Properties object\" stream_type:" GUID_FMT
- " error_correction_type:" GUID_FMT " time_offset:%"PRId64
- " type_specific_data_length:%d error_correction_data_length:%d"
+ " error_correction_type:" GUID_FMT " time_offset:%"PRIu64
+ " type_specific_data_length:%"PRIu32" error_correction_data_length:%"PRIu32
" flags:0x%x stream_number:%d",
GUID_PRINT( p_sp->i_stream_type ),
GUID_PRINT( p_sp->i_error_correction_type ),
int i_peek;
const uint8_t *p_peek, *p_data;
- unsigned int i_codec;
+ uint32_t i_codec;
if( ( i_peek = stream_Peek( s, &p_peek, p_cl->i_object_size ) ) < 44 )
return VLC_EGENERIC;
{
const asf_codec_entry_t *p_codec = &p_cl->codec[i_codec];
- msg_Dbg( s, " - codec[%d] %s name:\"%s\" "
- "description:\"%s\" information_length:%d",
+ msg_Dbg( s, " - codec[%"PRIu32"] %s name:\"%s\" "
+ "description:\"%s\" information_length:%u",
i_codec, ( p_codec->i_type == ASF_CODEC_TYPE_VIDEO ) ?
"video" : ( ( p_codec->i_type == ASF_CODEC_TYPE_AUDIO ) ?
"audio" : "unknown" ),
{
asf_object_codec_list_t *p_cl = &p_obj->codec_list;
- for( unsigned int i_codec = 0; i_codec < p_cl->i_codec_entries_count; i_codec++ )
+ for( uint32_t i_codec = 0; i_codec < p_cl->i_codec_entries_count; i_codec++ )
{
asf_codec_entry_t *p_codec = &p_cl->codec[i_codec];
{
asf_object_content_description_t *p_cd = &p_obj->content_description;
const uint8_t *p_peek, *p_data;
- int i_peek, i_title, i_artist, i_copyright, i_description, i_rating;
+ int i_peek;
+ uint16_t i_title, i_artist, i_copyright, i_description, i_rating;
if( ( i_peek = stream_Peek( s, &p_peek, p_cd->i_object_size ) ) < 34 )
return VLC_EGENERIC;
asf_object_language_list_t *p_ll = &p_obj->language_list;
const uint8_t *p_peek, *p_data;
int i_peek;
- int i;
+ uint16_t i;
if( ( i_peek = stream_Peek( s, &p_peek, p_ll->i_object_size ) ) < 26 )
return VLC_EGENERIC;
}
#ifdef ASF_DEBUG
- msg_Dbg( s, "read \"language list object\" %d entries",
+ msg_Dbg( s, "read \"language list object\" %u entries",
p_ll->i_language );
for( i = 0; i < p_ll->i_language; i++ )
msg_Dbg( s, " - '%s'",
static void ASF_FreeObject_language_list( asf_object_t *p_obj)
{
asf_object_language_list_t *p_ll = &p_obj->language_list;
- int i;
+ uint16_t i;
for( i = 0; i < p_ll->i_language; i++ )
FREENULL( p_ll->ppsz_language[i] );
asf_object_stream_bitrate_properties_t *p_sb = &p_obj->stream_bitrate;
const uint8_t *p_peek, *p_data;
int i_peek;
- int i;
+ uint16_t i;
if( ( i_peek = stream_Peek( s, &p_peek, p_sb->i_object_size ) ) < 26 )
return VLC_EGENERIC;
p_data = &p_peek[24];
p_sb->i_bitrate = ASF_READ2();
- if( p_sb->i_bitrate > 127 )
- p_sb->i_bitrate = 127; /* Buggy ? */
+ if( p_sb->i_bitrate > ASF_MAX_STREAMNUMBER )
+ p_sb->i_bitrate = ASF_MAX_STREAMNUMBER; /* Buggy ? */
for( i = 0; i < p_sb->i_bitrate; i++ )
{
if( !ASF_HAVE(2 + 4) )
break;
- p_sb->bitrate[i].i_stream_number = ASF_READ2()& 0x7f;
+ p_sb->bitrate[i].i_stream_number = (uint8_t) ASF_READ2()& 0x7f;
+ if ( p_sb->bitrate[i].i_stream_number > ASF_MAX_STREAMNUMBER )
+ return VLC_EGENERIC;
p_sb->bitrate[i].i_avg_bitrate = ASF_READ4();
}
p_sb->i_bitrate = i;
msg_Dbg( s,"read \"stream bitrate properties object\"" );
for( i = 0; i < p_sb->i_bitrate; i++ )
{
- msg_Dbg( s," - stream=%d bitrate=%d",
+ msg_Dbg( s," - stream=%u bitrate=%"PRIu32,
p_sb->bitrate[i].i_stream_number,
p_sb->bitrate[i].i_avg_bitrate );
}
{
asf_object_extended_stream_properties_t *p_esp = &p_obj->ext_stream;
const uint8_t *p_peek, *p_data;
- int i_peek, i;
+ int i_peek;
+ uint16_t i;
if( ( i_peek = stream_Peek( s, &p_peek, p_esp->i_object_size ) ) < 88 )
return VLC_EGENERIC;
p_esp->i_maximum_object_size = GetDWLE( &p_data[40] );
p_esp->i_flags = GetDWLE( &p_data[44] );
p_esp->i_stream_number = GetWLE( &p_data[48] );
+ if ( p_esp->i_stream_number > ASF_MAX_STREAMNUMBER )
+ return VLC_EGENERIC;
p_esp->i_language_index = GetWLE( &p_data[50] );
p_esp->i_average_time_per_frame= GetQWLE( &p_data[52] );
p_esp->i_stream_name_count = GetWLE( &p_data[60] );
p_data += 64;
p_esp->pi_stream_name_language = calloc( p_esp->i_stream_name_count,
- sizeof(int) );
+ sizeof(uint16_t) );
p_esp->ppsz_stream_name = calloc( p_esp->i_stream_name_count,
sizeof(char*) );
if( !p_esp->pi_stream_name_language ||
#ifdef ASF_DEBUG
msg_Dbg( s, "read \"extended stream properties object\":" );
- msg_Dbg( s, " - start=%"PRId64" end=%"PRId64,
+ msg_Dbg( s, " - start=%"PRIu64" end=%"PRIu64,
p_esp->i_start_time, p_esp->i_end_time );
- msg_Dbg( s, " - data bitrate=%d buffer=%d initial fullness=%d",
+ msg_Dbg( s, " - data bitrate=%"PRId32" buffer=%"PRId32" initial fullness=%"PRId32,
p_esp->i_data_bitrate,
p_esp->i_buffer_size,
p_esp->i_initial_buffer_fullness );
- msg_Dbg( s, " - alternate data bitrate=%d buffer=%d initial fullness=%d",
+ msg_Dbg( s, " - alternate data bitrate=%"PRId32" buffer=%"PRId32" initial fullness=%"PRId32,
p_esp->i_alternate_data_bitrate,
p_esp->i_alternate_buffer_size,
p_esp->i_alternate_initial_buffer_fullness );
- msg_Dbg( s, " - maximum object size=%d", p_esp->i_maximum_object_size );
+ msg_Dbg( s, " - maximum object size=%"PRId32, p_esp->i_maximum_object_size );
msg_Dbg( s, " - flags=0x%x", p_esp->i_flags );
- msg_Dbg( s, " - stream number=%d language=%d",
+ msg_Dbg( s, " - stream number=%u language=%u",
p_esp->i_stream_number, p_esp->i_language_index );
- msg_Dbg( s, " - average time per frame=%"PRId64,
+ msg_Dbg( s, " - average time per frame=%"PRIu64,
p_esp->i_average_time_per_frame );
- msg_Dbg( s, " - stream name count=%d", p_esp->i_stream_name_count );
+ msg_Dbg( s, " - stream name count=%u", p_esp->i_stream_name_count );
for( i = 0; i < p_esp->i_stream_name_count; i++ )
- msg_Dbg( s, " - lang id=%d name=%s",
+ msg_Dbg( s, " - lang id=%u name=%s",
p_esp->pi_stream_name_language[i],
p_esp->ppsz_stream_name[i] );
- msg_Dbg( s, " - payload extension system count=%d",
+ msg_Dbg( s, " - payload extension system count=%u",
p_esp->i_payload_extension_system_count );
for( i = 0; i < p_esp->i_payload_extension_system_count; i++ )
- msg_Dbg( s, " - %d - payload extension: " GUID_FMT, i,
+ msg_Dbg( s, " - %u - payload extension: " GUID_FMT, i,
GUID_PRINT( p_esp->p_ext[i].i_extension_id ) );
#endif
return VLC_SUCCESS;
if ( p_esp->p_ext )
{
- for( int i = 0; i < p_esp->i_payload_extension_system_count; i++ )
+ for( uint16_t i = 0; i < p_esp->i_payload_extension_system_count; i++ )
free( p_esp->p_ext[i].pi_info );
FREENULL( p_esp->p_ext );
}
- for( int i = 0; i < p_esp->i_stream_name_count; i++ )
+ for( uint16_t i = 0; i < p_esp->i_stream_name_count; i++ )
FREENULL( p_esp->ppsz_stream_name[i] );
FREENULL( p_esp->pi_stream_name_language );
FREENULL( p_esp->ppsz_stream_name );
p_ae->i_stream_number_count = ASF_READ2();
p_ae->pi_stream_number = calloc( p_ae->i_stream_number_count, sizeof(uint16_t) );
+ if ( !p_ae->pi_stream_number )
+ return VLC_ENOMEM;
for( i = 0; i < p_ae->i_stream_number_count; i++ )
{
if( !ASF_HAVE(2) )
break;
p_ae->pi_stream_number[i] = ASF_READ2();
+ if ( p_ae->pi_stream_number[i] > ASF_MAX_STREAMNUMBER )
+ {
+ free( p_ae->pi_stream_number );
+ return VLC_EGENERIC;
+ }
}
p_ae->i_stream_number_count = i;
if( !ASF_HAVE(2) )
break;
p_ex->pi_stream_numbers[i] = ASF_READ2();
+ if ( p_ex->pi_stream_numbers[i] > ASF_MAX_STREAMNUMBER )
+ {
+ free( p_ex->pi_stream_numbers );
+ return VLC_EGENERIC;
+ }
}
#ifdef ASF_DEBUG
}
for( i = 0; i < p_ec->i_count; i++ )
{
- int i_size;
- int i_type;
+ uint16_t i_size;
+ uint16_t i_type;
if( !ASF_HAVE(2 + 2+2) )
break;
if( !p_mk->marker )
return VLC_ENOMEM;
- for( unsigned i = 0; i < p_mk->i_count; i++ )
+ for( uint32_t i = 0; i < p_mk->i_count; i++ )
{
asf_marker_t *p_marker = &p_mk->marker[i];
}
#ifdef ASF_DEBUG
- msg_Dbg( s, "Read \"marker object\": %i chapters: %s", p_mk->i_count, p_mk->name );
+ msg_Dbg( s, "Read \"marker object\": %"PRIu32" chapters: %s", p_mk->i_count, p_mk->name );
for( unsigned i = 0; i < p_mk->i_count; i++ )
msg_Dbg( s, "New chapter named: %s", p_mk->marker[i].p_marker_description );
{
asf_object_marker_t *p_mk = (asf_object_marker_t *)p_obj;
- for( unsigned i = 0; i < p_mk->i_count; i++ )
+ for( uint32_t i = 0; i < p_mk->i_count; i++ )
{
FREENULL( p_mk->marker[i].p_marker_description );
}
projects / vlc / blobdiff