]> git.sesse.net Git - vlc/blobdiff - modules/demux/live555.cpp
Patch by Glen Gray: RTSP keep alive fix. If the server doesn't handle RTCP-RR packets...
[vlc] / modules / demux / live555.cpp
index a603f12b96441dd413b5fea67d429346ef67af62..3fed8f0d72e00309a0ea6265c836bcb6666bdf18 100644 (file)
@@ -32,6 +32,7 @@
 #include <vlc_demux.h>
 #include <vlc_interface.h>
 #include <vlc_network.h>
+#include <vlc_url.h>
 
 #include <iostream>
 
@@ -39,6 +40,7 @@
 #   include <winsock2.h>
 #endif
 
+#include "UsageEnvironment.hh"
 #include "BasicUsageEnvironment.hh"
 #include "GroupsockHelper.hh"
 #include "liveMedia.hh"
@@ -144,6 +146,7 @@ struct timeout_thread_t
     VLC_COMMON_MEMBERS
 
     int64_t      i_remain;
+    vlc_bool_t   b_handle_keep_alive;
     demux_sys_t  *p_sys;
 };
 
@@ -151,6 +154,7 @@ struct demux_sys_t
 {
     char            *p_sdp;    /* XXX mallocated */
     char            *psz_path; /* URL-encoded path */
+    vlc_url_t       url;
 
     MediaSession     *ms;
     TaskScheduler    *scheduler;
@@ -261,6 +265,9 @@ static int  Open ( vlc_object_t *p_this )
     p_sys->b_real = VLC_FALSE;
     p_sys->psz_path = strdup( p_demux->psz_path );
 
+    /* parse URL for rtsp://[user:[passwd]@]serverip:port/options */
+    vlc_UrlParse( &p_sys->url, p_sys->psz_path, 0 );
+
     if( ( p_sys->scheduler = BasicTaskScheduler::createNew() ) == NULL )
     {
         msg_Err( p_demux, "BasicTaskScheduler::createNew failed" );
@@ -310,7 +317,8 @@ static int  Open ( vlc_object_t *p_this )
         }
         p_sys->p_sdp = (char*)p_sdp;
     }
-    else if( p_demux->s == NULL && !strcasecmp( p_demux->psz_access, "sdp" ) )
+    else if( ( p_demux->s == NULL ) &&
+             !strcasecmp( p_demux->psz_access, "sdp" ) )
     {
         /* sdp:// link from SAP */
         p_sys->p_sdp = strdup( p_sys->psz_path );
@@ -377,6 +385,8 @@ error:
     if( p_sys->p_sdp ) free( p_sys->p_sdp );
     if( p_sys->psz_path ) free( p_sys->psz_path );
 
+    vlc_UrlClean( &p_sys->url );
+
     free( p_sys );
     return VLC_EGENERIC;
 }
@@ -416,6 +426,8 @@ static void Close( vlc_object_t *p_this )
     if( p_sys->p_sdp ) free( p_sys->p_sdp );
     if( p_sys->psz_path ) free( p_sys->psz_path );
 
+    vlc_UrlClean( &p_sys->url );
+
     free( p_sys );
 }
 
@@ -439,7 +451,7 @@ createnew:
     if( var_CreateGetBool( p_demux, "rtsp-http" ) )
         i_http_port = var_CreateGetInteger( p_demux, "rtsp-http-port" );
 
-    if( ( p_sys->rtsp = RTSPClient::createNew(*p_sys->env,
+    if( ( p_sys->rtsp = RTSPClient::createNew( *p_sys->env,
           p_demux->p_libvlc->i_verbose > 1,
           "VLC media player", i_http_port ) ) == NULL )
     {
@@ -447,17 +459,35 @@ createnew:
                  p_sys->env->getResultMsg() );
         return VLC_EGENERIC;
     }
+
     psz_url = (char*)malloc( strlen( p_sys->psz_path ) + 8 );
-    sprintf( psz_url, "rtsp://%s", p_sys->psz_path );
+    if( !psz_url ) return VLC_ENOMEM;
 
-    psz_options = p_sys->rtsp->sendOptionsCmd( psz_url );
-    if( psz_options ) delete [] psz_options;
+    if( p_sys->url.psz_username || p_sys->url.psz_password )
+    {
+        sprintf( psz_url, "rtsp://%s%s", p_sys->url.psz_host,
+                 p_sys->url.psz_path );
+
+        psz_user = strdup( p_sys->url.psz_username );
+        psz_pwd  = strdup( p_sys->url.psz_password );
+    }
+    else
+    {
+        sprintf( psz_url, "rtsp://%s", p_sys->psz_path );
 
-    psz_user = var_CreateGetString( p_demux, "rtsp-user" );
-    psz_pwd  = var_CreateGetString( p_demux, "rtsp-pwd" );
+        psz_user = var_CreateGetString( p_demux, "rtsp-user" );
+        psz_pwd  = var_CreateGetString( p_demux, "rtsp-pwd" );
+    }
 
 describe:
-    authenticator.setUsernameAndPassword( (const char*)psz_user, (const char*)psz_pwd );
+msg_Info( p_demux, "[%s] user=%s pwd=%s", psz_url, psz_user, psz_pwd );
+    authenticator.setUsernameAndPassword( (const char*)psz_user,
+                                          (const char*)psz_pwd );
+
+    psz_options = p_sys->rtsp->sendOptionsCmd( psz_url, psz_user, psz_pwd,
+                                               &authenticator );
+    if( psz_options ) delete [] psz_options;
+
     p_sdp = p_sys->rtsp->describeURL( psz_url,
                 &authenticator, var_CreateGetBool( p_demux, "rtsp-kasenna" ) );
 
@@ -471,7 +501,9 @@ describe:
         const char *psz_error = p_sys->env->getResultMsg();
 
         msg_Dbg( p_demux, "DESCRIBE failed with %d: %s", i_code, psz_error );
-        sscanf( psz_error, "%*sRTSP/%*s%3u", &i_code );
+        if( var_CreateGetBool( p_demux, "rtsp-http" ) )
+            sscanf( psz_error, "%*s %*s HTTP GET %*s HTTP/%*u.%*u %3u %*s", &i_code );
+        else sscanf( psz_error, "%*sRTSP/%*s%3u", &i_code );
 
         if( i_code == 401 )
         {
@@ -483,16 +515,17 @@ describe:
                                                    &psz_login, &psz_password );
             if( i_ret == DIALOG_OK_YES )
             {
-               msg_Dbg( p_demux, "retrying with user=%s, pwd=%s",
-                           psz_login, psz_password );
-               if( psz_login ) psz_user = psz_login;
-               if( psz_password ) psz_pwd = psz_password;
-               goto describe;
+                msg_Dbg( p_demux, "retrying with user=%s, pwd=%s",
+                            psz_login, psz_password );
+                if( psz_login ) psz_user = psz_login;
+                if( psz_password ) psz_pwd = psz_password;
+                i_ret = VLC_SUCCESS;
+                goto describe;
             }
             if( psz_login ) free( psz_login );
             if( psz_password ) free( psz_password );
         }
-        else if( !var_CreateGetBool( p_demux, "rtsp-http" ) )
+        else if( !var_GetBool( p_demux, "rtsp-http" ) )
         {
             /* Perhaps a firewall is being annoying. Try HTTP tunneling mode */
             vlc_value_t val;
@@ -509,6 +542,7 @@ describe:
 
     /* malloc-ated copy */
     if( p_sys->p_sdp ) free( p_sys->p_sdp );
+    p_sys->p_sdp = NULL;
     if( p_sdp ) p_sys->p_sdp = strdup( (char*)p_sdp );
     delete[] p_sdp;
 
@@ -516,7 +550,7 @@ describe:
 }
 
 /*****************************************************************************
- * Connect: prepares the subsessions and does the SETUP
+ * SessionsSetup: prepares the subsessions and does the SETUP
  *****************************************************************************/
 static int SessionsSetup( demux_t *p_demux )
 {
@@ -530,7 +564,8 @@ static int SessionsSetup( demux_t *p_demux )
     unsigned int   i_buffer = 0;
     unsigned const thresh = 200000; /* RTP reorder threshold .2 second (default .1) */
 
-    b_rtsp_tcp    = var_CreateGetBool( p_demux, "rtsp-tcp" );
+    b_rtsp_tcp    = var_CreateGetBool( p_demux, "rtsp-tcp" ) ||
+                    var_GetBool( p_demux, "rtsp-http" );
     i_client_port = var_CreateGetInteger( p_demux, "rtp-client-port" );
 
     /* Create the session from the SDP */
@@ -743,7 +778,14 @@ static int SessionsSetup( demux_t *p_demux )
                 }
                 else if( !strcmp( sub->codecName(), "SPEEX" ) )
                 {
-                    tk->fmt.i_codec = VLC_FOURCC( 's', 'p', 'x', ' ' );
+                    tk->fmt.i_codec = VLC_FOURCC( 's', 'p', 'x', 'r' );
+                    if ( sub->rtpTimestampFrequency() )
+                        tk->fmt.audio.i_rate = sub->rtpTimestampFrequency();
+                    else
+                    {
+                        msg_Warn( p_demux,"Using 8kHz as default sample rate." );
+                        tk->fmt.audio.i_rate = 8000;
+                    }
                 }
             }
             else if( !strcmp( sub->mediumName(), "video" ) )
@@ -917,13 +959,13 @@ static int Play( demux_t *p_demux )
     }
     p_sys->i_pcr = 0;
 
-#if 0
+#if (LIVEMEDIA_LIBRARY_VERSION_INT >= 1195257600)
     /* TODO */
     for( i = 0; i < p_sys->i_track; i++ )
     {
-        //p_sys->track[i]->i_pts = 0;
+        p_sys->track[i]->i_pts = (int64_t) ( p_sys->track[i]->sub->rtpInfo.timestamp * (double)1000000.0 );
         p_sys->track[i]->i_start_seq = (int)p_sys->track[i]->sub->rtpInfo.seqNum;
-        msg_Dbg( p_demux, "set startseq: %u", p_sys->track[i]->i_start_seq );
+        msg_Info( p_demux, "set startseq: %u", p_sys->track[i]->i_start_seq );
     }
 #endif
 
@@ -970,8 +1012,7 @@ static int Demux( demux_t *p_demux )
     /* Check if we need to send the server a Keep-A-Live signal */
     if( p_sys->b_timeout_call && p_sys->rtsp && p_sys->ms )
     {
-        char *psz_bye = NULL;
-        p_sys->rtsp->getMediaSessionParameter( *p_sys->ms, NULL, psz_bye );
+        p_sys->rtsp->setMediaSessionParameter( *p_sys->ms, "vlc" , "1" );
         p_sys->b_timeout_call = VLC_FALSE;
     }
 
@@ -1033,25 +1074,26 @@ static int Demux( demux_t *p_demux )
 
             es_out_Control( p_demux->out, ES_OUT_RESET_PCR );
             tk->b_rtcp_sync = VLC_TRUE;
-#if 0
             /* reset PCR */
             tk->i_pts = 0;
             p_sys->i_pcr = 0;
             i_pcr = 0;
-#endif
         }
     }
 
-    if( p_sys->b_multicast && p_sys->b_no_data && p_sys->i_no_data_ti > 120 )
+    if( p_sys->b_multicast && p_sys->b_no_data &&
+        ( p_sys->i_no_data_ti > 120 ) )
     {
         /* FIXME Make this configurable
         msg_Err( p_demux, "no multicast data received in 36s, aborting" );
         return 0;
         */
     }
-    else if( !p_sys->b_multicast && p_sys->b_no_data && p_sys->i_no_data_ti > 34 )
+    else if( !p_sys->b_multicast && p_sys->b_no_data &&
+             ( p_sys->i_no_data_ti > 34 ) )
     {
-        vlc_bool_t b_rtsp_tcp = var_GetBool( p_demux, "rtsp-tcp" );
+        vlc_bool_t b_rtsp_tcp = var_GetBool( p_demux, "rtsp-tcp" ) ||
+                                var_GetBool( p_demux, "rtsp-http" );
 
         if( !b_rtsp_tcp && p_sys->rtsp && p_sys->ms )
         {
@@ -1133,13 +1175,13 @@ static int Control( demux_t *p_demux, int i_query, va_list args )
                 }
                 es_out_Control( p_demux->out, ES_OUT_RESET_PCR );
                 p_sys->i_pcr = 0;
-#if 0
+#if (LIVEMEDIA_LIBRARY_VERSION_INT >= 1195257600)
                 /* Retrieve RTP-Info values */
                 for( i = 0; i < p_sys->i_track; i++ )
                 {
-                    //p_sys->track[i]->i_pts = 0;
+                    p_sys->track[i]->i_pts = (int64_t) ( p_sys->track[i]->sub->rtpInfo.timestamp * (double)1000000.0 );
                     p_sys->track[i]->i_start_seq = p_sys->track[i]->sub->rtpInfo.seqNum;
-                    msg_Dbg( p_demux, "set pos startseq: %u", p_sys->track[i]->i_start_seq );
+                    msg_Info( p_demux, "set pos startseq: %u", p_sys->track[i]->i_start_seq );
                 }
 #endif
 #if (LIVEMEDIA_LIBRARY_VERSION_INT >= 9999999999)
@@ -1208,14 +1250,28 @@ static int Control( demux_t *p_demux, int i_query, va_list args )
                     msg_Err( p_demux, "PLAY or PAUSE failed %s", p_sys->env->getResultMsg() );
                     return VLC_EGENERIC;
             }
+
+            /* When we Pause, we'll need the TimeoutPrevention thread to
+             * handle sending the "Keep Alive" message to the server. 
+             * Unfortunately Live555 isn't thread safe and so can't 
+             * do this normally while the main Demux thread is handling
+             * a live stream. We end up with the Timeout thread blocking
+             * waiting for a response from the server. So when we PAUSE
+             * we set a flag that the TimeoutPrevention function will check
+             * and if it's set, it will trigger the GET_PARAMETER message */
+            if( b_bool && p_sys->p_timeout != NULL )
+                p_sys->p_timeout->b_handle_keep_alive = VLC_TRUE;
+            else if( !b_bool && p_sys->p_timeout != NULL ) 
+                p_sys->p_timeout->b_handle_keep_alive = VLC_FALSE;
+
             es_out_Control( p_demux->out, ES_OUT_RESET_PCR );
             p_sys->i_pcr = 0;
-#if 0
+#if (LIVEMEDIA_LIBRARY_VERSION_INT >= 1195257600)
             for( i = 0; i < p_sys->i_track; i++ )
             {
-                //p_sys->track[i]->i_pts = 0;
+                p_sys->track[i]->i_pts = (int64_t) ( p_sys->track[i]->sub->rtpInfo.timestamp * (double)1000000.0 );
                 p_sys->track[i]->i_start_seq = p_sys->track[i]->sub->rtpInfo.seqNum;
-                msg_Dbg( p_demux, "set pause startseq: %u", p_sys->track[i]->i_start_seq );
+                msg_Info( p_demux, "set pause startseq: %u", p_sys->track[i]->i_start_seq );
             }
 #endif
 #if (LIVEMEDIA_LIBRARY_VERSION_INT >= 9999999999)
@@ -1293,9 +1349,11 @@ static int RollOverTcp( demux_t *p_demux )
     p_sys->i_track = 0;
 
     /* Reopen rtsp client */
-    if( p_demux->s != NULL && ( i_return = Connect( p_demux ) ) != VLC_SUCCESS )
+    if( ( p_demux->s != NULL ) &&
+        ( i_return = Connect( p_demux ) ) != VLC_SUCCESS )
     {
-        msg_Err( p_demux, "Failed to connect with rtsp://%s", p_sys->psz_path );
+        msg_Err( p_demux, "Failed to connect with rtsp://%s",
+                 p_sys->psz_path );
         goto error;
     }
 
@@ -1573,10 +1631,21 @@ static void TimeoutPrevention( timeout_thread_t *p_timeout )
     {
         if( p_timeout->i_remain <= 0 )
         {
+            char *psz_bye = NULL;
             p_timeout->i_remain = (int64_t)p_timeout->p_sys->i_timeout -2;
             p_timeout->i_remain *= 1000000;
-            p_timeout->p_sys->b_timeout_call = VLC_TRUE;
             msg_Dbg( p_timeout, "reset the timeout timer" );
+            if( p_timeout->b_handle_keep_alive == VLC_TRUE )
+            {
+#if LIVEMEDIA_LIBRARY_VERSION_INT >= 1138089600
+                p_timeout->p_sys->rtsp->getMediaSessionParameter( *p_timeout->p_sys->ms, NULL, psz_bye );
+#endif
+                p_timeout->p_sys->b_timeout_call = VLC_FALSE;
+            }
+            else
+            {
+                p_timeout->p_sys->b_timeout_call = VLC_TRUE;
+            }
         }
         p_timeout->i_remain -= 200000;
         msleep( 200000 ); /* 200 ms */