]> git.sesse.net Git - vlc/blobdiff - modules/demux/mkv.cpp
* forwardport [18346]: LocaleFree() a utf8_readdir entry instead of using free()
[vlc] / modules / demux / mkv.cpp
index 8d2ede2dfc554b2cd58b6fb3241218688b0651e0..c3feaf606afcf66e82f20fb7df622ce9e3deb336 100644 (file)
 #   include <time.h>                                               /* time() */
 #endif
 
-#include <vlc/input.h>
 
-#include <codecs.h>                        /* BITMAPINFOHEADER, WAVEFORMATEX */
+#include <vlc_codecs.h>               /* BITMAPINFOHEADER, WAVEFORMATEX */
 #include "iso_lang.h"
 #include "vlc_meta.h"
+#include <vlc_charset.h>
+#include <vlc_input.h>
+#include <vlc_demux.h>
 
 #include <iostream>
 #include <cassert>
@@ -109,7 +111,7 @@ extern "C" {
 
 ////////////////////////////////////////////////////////////////////////////////////////////////////////////////
 #undef ATTRIBUTE_PACKED
-#undef PRAGMA_PACK_BEGIN 
+#undef PRAGMA_PACK_BEGIN
 #undef PRAGMA_PACK_END
 
 #if defined(__GNUC__)
@@ -218,7 +220,7 @@ typedef struct {
 #define COMMAND_DATA_SIZE 8
 
 /**
- * PCI General Information 
+ * PCI General Information
  */
 typedef struct {
   uint32_t nv_pck_lbn;      /**< sector address of this nav pack */
@@ -239,8 +241,8 @@ typedef struct {
   uint32_t nsml_agl_dsta[9];  /**< address of destination vobu in AGL_C#n */
 } ATTRIBUTE_PACKED nsml_agli_t;
 
-/** 
- * Highlight General Information 
+/**
+ * Highlight General Information
  *
  * For btngrX_dsp_ty the bits have the following meaning:
  * 000b: normal 4/3 only buttons
@@ -273,7 +275,7 @@ typedef struct {
   unsigned char zero3 : 1;
 #endif
   uint8_t btn_ofn;     /**< button offset number range 0-255 */
-  uint8_t btn_ns;      /**< number of valid buttons  <= 36/18/12 (low 6 bits) */  
+  uint8_t btn_ns;      /**< number of valid buttons  <= 36/18/12 (low 6 bits) */
   uint8_t nsl_btn_ns;  /**< number of buttons selectable by U_BTNNi (low 6 bits)   nsl_btn_ns <= btn_ns */
   uint8_t zero5;       /**< reserved */
   uint8_t fosl_btnn;   /**< forcedly selected button  (low 6 bits) */
@@ -346,7 +348,7 @@ typedef struct {
 } ATTRIBUTE_PACKED btni_t;
 
 /**
- * Highlight Information 
+ * Highlight Information
  */
 typedef struct {
   hl_gi_t     hl_gi;
@@ -477,7 +479,7 @@ block_t *block_zlib_decompress( vlc_object_t *p_this, block_t *p_in_block ) {
 /**
  * Helper function to print the mkv parse tree
  */
-static void MkvTree( demux_t & demuxer, int i_level, char *psz_format, ... )
+static void MkvTree( demux_t & demuxer, int i_level, const char *psz_format, ... )
 {
     va_list args;
     if( i_level > 9 )
@@ -486,7 +488,7 @@ static void MkvTree( demux_t & demuxer, int i_level, char *psz_format, ... )
         return;
     }
     va_start( args, psz_format );
-    static char *psz_foo = "|   |   |   |   |   |   |   |   |   |";
+    static const char psz_foo[] = "|   |   |   |   |   |   |   |   |   |";
     char *psz_foo2 = (char*)malloc( ( i_level * 4 + 3 + strlen( psz_format ) ) * sizeof(char) );
     strncpy( psz_foo2, psz_foo, 4 * i_level );
     psz_foo2[ 4 * i_level ] = '+';
@@ -496,7 +498,7 @@ static void MkvTree( demux_t & demuxer, int i_level, char *psz_format, ... )
     free( psz_foo2 );
     va_end( args );
 }
-    
+
 /*****************************************************************************
  * Stream managment
  *****************************************************************************/
@@ -602,11 +604,11 @@ typedef struct
     vlc_bool_t      b_silent;
 
     /* informative */
-    char         *psz_codec_name;
-    char         *psz_codec_settings;
-    char         *psz_codec_info_url;
-    char         *psz_codec_download_url;
-    
+    const char   *psz_codec_name;
+    const char   *psz_codec_settings;
+    const char   *psz_codec_info_url;
+    const char   *psz_codec_download_url;
+
     /* encryption/compression */
     int                    i_compression_type;
     KaxContentCompSettings *p_compression_data;
@@ -643,7 +645,7 @@ public:
     ,sys( demuxer )
     {}
         
-    virtual ~chapter_codec_cmds_c() 
+    virtual ~chapter_codec_cmds_c()
     {
         delete p_private_data;
         std::vector<KaxChapterProcessData*>::iterator indexe = enter_cmds.begin();
@@ -896,7 +898,7 @@ public:
     bool Leave();
 
 protected:
-    matroska_script_interpretor_c interpretor; 
+    matroska_script_interpretor_c interpretor;
 };
 
 class chapter_translation_c
@@ -952,9 +954,9 @@ public:
     virtual chapter_item_c * FindTimecode( mtime_t i_timecode, const chapter_item_c * p_current, bool & b_found );
     void Append( const chapter_item_c & edition );
     chapter_item_c * FindChapter( int64_t i_find_uid );
-    virtual chapter_item_c *BrowseCodecPrivate( unsigned int codec_id, 
-                                    bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ), 
-                                    const void *p_cookie, 
+    virtual chapter_item_c *BrowseCodecPrivate( unsigned int codec_id,
+                                    bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ),
+                                    const void *p_cookie,
                                     size_t i_cookie_size );
     std::string                 GetCodecName( bool f_for_title = false ) const;
     bool                        ParentOf( const chapter_item_c & item ) const;
@@ -1240,9 +1242,9 @@ public:
     bool UpdateCurrentToChapter( demux_t & demux );
     void PrepareChapters( );
 
-    chapter_item_c *BrowseCodecPrivate( unsigned int codec_id, 
-                                        bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ), 
-                                        const void *p_cookie, 
+    chapter_item_c *BrowseCodecPrivate( unsigned int codec_id,
+                                        bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ),
+                                        const void *p_cookie,
                                         size_t i_cookie_size );
     chapter_item_c *FindChapter( int64_t i_find_uid );
 
@@ -1358,10 +1360,10 @@ public:
     float                   f_duration;
 
     matroska_segment_c *FindSegment( const EbmlBinary & uid ) const;
-    chapter_item_c *BrowseCodecPrivate( unsigned int codec_id, 
-                                        bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ), 
-                                        const void *p_cookie, 
-                                        size_t i_cookie_size, 
+    chapter_item_c *BrowseCodecPrivate( unsigned int codec_id,
+                                        bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ),
+                                        const void *p_cookie,
+                                        size_t i_cookie_size,
                                         virtual_segment_c * & p_segment_found );
     chapter_item_c *FindChapter( int64_t i_find_uid, virtual_segment_c * & p_segment_found );
 
@@ -1485,22 +1487,22 @@ static int Open( vlc_object_t * p_this )
             }
             else
             {
-                if (s_path.find_last_of(DIRECTORY_SEPARATOR) > 0) 
+                if (s_path.find_last_of(DIRECTORY_SEPARATOR) > 0)
                 {
                     s_path = s_path.substr(0,s_path.find_last_of(DIRECTORY_SEPARATOR));
                 }
             }
 
-            struct dirent *p_file_item;
-            DIR *p_src_dir = opendir(s_path.c_str());
+            DIR *p_src_dir = utf8_opendir(s_path.c_str());
 
             if (p_src_dir != NULL)
             {
-                while ((p_file_item = (dirent *) readdir(p_src_dir)))
+                const char *psz_file;
+                while ((psz_file = utf8_readdir(p_src_dir)) != NULL)
                 {
-                    if (strlen(p_file_item->d_name) > 4)
+                    if (strlen(psz_file) > 4)
                     {
-                        s_filename = s_path + DIRECTORY_SEPARATOR + p_file_item->d_name;
+                        s_filename = s_path + DIRECTORY_SEPARATOR + psz_file;
 
 #ifdef WIN32
                         if (!strcasecmp(s_filename.c_str(), p_demux->psz_path))
@@ -1510,10 +1512,10 @@ static int Open( vlc_object_t * p_this )
                             continue; // don't reuse the original opened file
 
 #if defined(__GNUC__) && (__GNUC__ < 3)
-                        if (!s_filename.compare("mkv", s_filename.length() - 3, 3) || 
+                        if (!s_filename.compare("mkv", s_filename.length() - 3, 3) ||
                             !s_filename.compare("mka", s_filename.length() - 3, 3))
 #else
-                        if (!s_filename.compare(s_filename.length() - 3, 3, "mkv") || 
+                        if (!s_filename.compare(s_filename.length() - 3, 3, "mkv") ||
                             !s_filename.compare(s_filename.length() - 3, 3, "mka"))
 #endif
                         {
@@ -1545,6 +1547,7 @@ static int Open( vlc_object_t * p_this )
                             }
                         }
                     }
+                    LocaleFree (psz_file);
                 }
                 closedir( p_src_dir );
             }
@@ -1854,7 +1857,7 @@ static block_t *MemToBlock( demux_t *p_demux, uint8_t *p_mem, int i_mem, size_t
 }
 
 #if LIBMATROSKA_VERSION >= 0x000800
-static void BlockDecode( demux_t *p_demux, KaxBlock *block, KaxSimpleBlock *simpleblock, 
+static void BlockDecode( demux_t *p_demux, KaxBlock *block, KaxSimpleBlock *simpleblock,
                          mtime_t i_pts, mtime_t i_duration, bool f_mandatory )
 #else
 static void BlockDecode( demux_t *p_demux, KaxBlock *block, mtime_t i_pts,
@@ -1922,7 +1925,7 @@ static void BlockDecode( demux_t *p_demux, KaxBlock *block, mtime_t i_pts,
 
 
 #if LIBMATROSKA_VERSION >= 0x000800
-    for( i = 0; 
+    for( i = 0;
         (block != NULL && i < block->NumberFrames()) || (simpleblock != NULL && i < simpleblock->NumberFrames());
         i++ )
 #else
@@ -2200,17 +2203,17 @@ bool matroska_segment_c::Select( mtime_t i_start_time )
             {
                 tracks[i_track]->fmt.i_codec = VLC_FOURCC( 'D', 'I', 'V', '3' );
             }
-            else if( !strcmp( tracks[i_track]->psz_codec, "V_MPEG4/ISO/AVC" ) )
+            else if( !strncmp( tracks[i_track]->psz_codec, "V_MPEG4/ISO", 11 ) )
             {
-                tracks[i_track]->fmt.i_codec = VLC_FOURCC( 'a', 'v', 'c', '1' );
+                /* A MPEG 4 codec, SP, ASP, AP or AVC */
+                if( !strcmp( tracks[i_track]->psz_codec, "V_MPEG4/ISO/AVC" ) )
+                    tracks[i_track]->fmt.i_codec = VLC_FOURCC( 'a', 'v', 'c', '1' );
+                else
+                    tracks[i_track]->fmt.i_codec = VLC_FOURCC( 'm', 'p', '4', 'v' );
                 tracks[i_track]->fmt.i_extra = tracks[i_track]->i_extra_data;
                 tracks[i_track]->fmt.p_extra = malloc( tracks[i_track]->i_extra_data );
                 memcpy( tracks[i_track]->fmt.p_extra,tracks[i_track]->p_extra_data, tracks[i_track]->i_extra_data );
             }
-            else
-            {
-                tracks[i_track]->fmt.i_codec = VLC_FOURCC( 'm', 'p', '4', 'v' );
-            }
         }
         else if( !strcmp( tracks[i_track]->psz_codec, "V_QUICKTIME" ) )
         {
@@ -2383,6 +2386,20 @@ bool matroska_segment_c::Select( mtime_t i_start_time )
             tracks[i_track]->fmt.p_extra = malloc( tracks[i_track]->i_extra_data );
             memcpy( tracks[i_track]->fmt.p_extra, tracks[i_track]->p_extra_data, tracks[i_track]->i_extra_data );
         }
+        else if( !strcmp( tracks[i_track]->psz_codec, "A_WAVPACK4" ) )
+        {
+            tracks[i_track]->fmt.i_codec = VLC_FOURCC( 'W', 'V', 'P', 'K' );
+            tracks[i_track]->fmt.i_extra = tracks[i_track]->i_extra_data;
+            tracks[i_track]->fmt.p_extra = malloc( tracks[i_track]->i_extra_data );
+            memcpy( tracks[i_track]->fmt.p_extra, tracks[i_track]->p_extra_data, tracks[i_track]->i_extra_data );
+        }
+        else if( !strcmp( tracks[i_track]->psz_codec, "A_TTA1" ) )
+        {
+            tracks[i_track]->fmt.i_codec = VLC_FOURCC( 'T', 'T', 'A', '1' );
+            tracks[i_track]->fmt.i_extra = tracks[i_track]->i_extra_data;
+            tracks[i_track]->fmt.p_extra = malloc( tracks[i_track]->i_extra_data );
+            memcpy( tracks[i_track]->fmt.p_extra, tracks[i_track]->p_extra_data, tracks[i_track]->i_extra_data );
+        }
         else if( !strcmp( tracks[i_track]->psz_codec, "A_PCM/INT/BIG" ) ||
                  !strcmp( tracks[i_track]->psz_codec, "A_PCM/INT/LIT" ) ||
                  !strcmp( tracks[i_track]->psz_codec, "A_PCM/FLOAT/IEEE" ) )
@@ -2397,18 +2414,6 @@ bool matroska_segment_c::Select( mtime_t i_start_time )
             }
             tracks[i_track]->fmt.audio.i_blockalign = ( tracks[i_track]->fmt.audio.i_bitspersample + 7 ) / 8 * tracks[i_track]->fmt.audio.i_channels;
         }
-        else if( !strcmp( tracks[i_track]->psz_codec, "A_TTA1" ) )
-        {
-            /* FIXME: support this codec */
-            msg_Err( &sys.demuxer, "TTA not supported yet[%d, n=%d]", (int)i_track, tracks[i_track]->i_number );
-            tracks[i_track]->fmt.i_codec = VLC_FOURCC( 'u', 'n', 'd', 'f' );
-        }
-        else if( !strcmp( tracks[i_track]->psz_codec, "A_WAVPACK4" ) )
-        {
-            /* FIXME: support this codec */
-            msg_Err( &sys.demuxer, "Wavpack not supported yet[%d, n=%d]", (int)i_track, tracks[i_track]->i_number );
-            tracks[i_track]->fmt.i_codec = VLC_FOURCC( 'u', 'n', 'd', 'f' );
-        }
         else if( !strcmp( tracks[i_track]->psz_codec, "S_TEXT/UTF8" ) )
         {
             tracks[i_track]->fmt.i_codec = VLC_FOURCC( 's', 'u', 'b', 't' );
@@ -2421,7 +2426,7 @@ bool matroska_segment_c::Select( mtime_t i_start_time )
         {
             tracks[i_track]->fmt.i_codec = VLC_FOURCC( 's', 's', 'a', ' ' );
             tracks[i_track]->fmt.subs.psz_encoding = strdup( "UTF-8" );
-            if( tracks[i_track]->i_extra_data ) 
+            if( tracks[i_track]->i_extra_data )
             {
                 tracks[i_track]->fmt.i_extra = tracks[i_track]->i_extra_data;
                 tracks[i_track]->fmt.p_extra = malloc( tracks[i_track]->i_extra_data );
@@ -2576,7 +2581,7 @@ int demux_sys_t::EventThread( vlc_object_t *p_this )
     p_ev->b_key     = VLC_FALSE;
 
     /* catch all key event */
-    var_AddCallback( p_ev->p_vlc, "key-pressed", EventKey, p_ev );
+    var_AddCallback( p_ev->p_libvlc, "key-pressed", EventKey, p_ev );
 
     /* main loop */
     while( !p_ev->b_die )
@@ -2594,7 +2599,7 @@ int demux_sys_t::EventThread( vlc_object_t *p_this )
         if( p_ev->b_key )
         {
             vlc_value_t valk;
-            struct vlc_t::hotkey *p_hotkeys = p_ev->p_vlc->p_hotkeys;
+            struct libvlc_int_t::hotkey *p_hotkeys = p_ev->p_libvlc->p_hotkeys;
             int i, i_action = -1;
 
             msg_Dbg( p_ev->p_demux, "Handle Key Event");
@@ -2603,7 +2608,7 @@ int demux_sys_t::EventThread( vlc_object_t *p_this )
 
             pci_t *pci = (pci_t *) &p_sys->pci_packet;
 
-            var_Get( p_ev->p_vlc, "key-pressed", &valk );
+            var_Get( p_ev->p_libvlc, "key-pressed", &valk );
             for( i = 0; p_hotkeys[i].psz_action != NULL; i++ )
             {
                 if( p_hotkeys[i].i_key == valk.i_int )
@@ -2754,14 +2759,14 @@ int demux_sys_t::EventThread( vlc_object_t *p_this )
                 // get current button
                 best = 0;
                 dist = 0x08000000; /* >> than  (720*720)+(567*567); */
-                for(button = 1; button <= pci->hli.hl_gi.btn_ns; button++) 
+                for(button = 1; button <= pci->hli.hl_gi.btn_ns; button++)
                 {
                     btni_t *button_ptr = &(pci->hli.btnit[button-1]);
 
                     if(((unsigned)valx.i_int >= button_ptr->x_start)
                      && ((unsigned)valx.i_int <= button_ptr->x_end)
                      && ((unsigned)valy.i_int >= button_ptr->y_start)
-                     && ((unsigned)valy.i_int <= button_ptr->y_end)) 
+                     && ((unsigned)valy.i_int <= button_ptr->y_end))
                     {
                         mx = (button_ptr->x_start + button_ptr->x_end)/2;
                         my = (button_ptr->y_start + button_ptr->y_end)/2;
@@ -2878,7 +2883,7 @@ int demux_sys_t::EventThread( vlc_object_t *p_this )
         var_DelCallback( p_vout, "mouse-clicked", EventMouse, p_ev );
         vlc_object_release( p_vout );
     }
-    var_DelCallback( p_ev->p_vlc, "key-pressed", EventKey, p_ev );
+    var_DelCallback( p_ev->p_libvlc, "key-pressed", EventKey, p_ev );
 
     vlc_mutex_destroy( &p_ev->lock );
 
@@ -3025,9 +3030,9 @@ bool virtual_segment_c::UpdateCurrentToChapter( demux_t & demux )
     return false;
 }
 
-chapter_item_c *virtual_segment_c::BrowseCodecPrivate( unsigned int codec_id, 
-                                    bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ), 
-                                    const void *p_cookie, 
+chapter_item_c *virtual_segment_c::BrowseCodecPrivate( unsigned int codec_id,
+                                    bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ),
+                                    const void *p_cookie,
                                     size_t i_cookie_size )
 {
     // FIXME don't assume it is the first edition
@@ -3054,9 +3059,9 @@ chapter_item_c *virtual_segment_c::FindChapter( int64_t i_find_uid )
     return NULL;
 }
 
-chapter_item_c *chapter_item_c::BrowseCodecPrivate( unsigned int codec_id, 
-                                    bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ), 
-                                    const void *p_cookie, 
+chapter_item_c *chapter_item_c::BrowseCodecPrivate( unsigned int codec_id,
+                                    bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ),
+                                    const void *p_cookie,
                                     size_t i_cookie_size )
 {
     // this chapter
@@ -4075,7 +4080,7 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
         }
         else  if( MKV_IS_ID( l, KaxTrackType ) )
         {
-            char *psz_type;
+            const char *psz_type;
             KaxTrackType &ttype = *(KaxTrackType*)l;
 
             switch( uint8(ttype) )
@@ -4240,7 +4245,7 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
                                     KaxContentCompAlgo &compalg = *(KaxContentCompAlgo*)l4;
                                     MkvTree( sys.demuxer, 6, "Compression Algorithm: %i", uint32(compalg) );
                                     tk->i_compression_type = uint32( compalg );
-                                    if ( ( tk->i_compression_type != MATROSKA_COMPRESSION_ZLIB ) && 
+                                    if ( ( tk->i_compression_type != MATROSKA_COMPRESSION_ZLIB ) &&
                                          ( tk->i_compression_type != MATROSKA_COMPRESSION_HEADER ) )
                                     {
                                         msg_Err( &sys.demuxer, "Track Compression method %d not supported", tk->i_compression_type );
@@ -4257,20 +4262,17 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
                                 }
                             }
                         }
-
                         else
                         {
                             MkvTree( sys.demuxer, 5, "Unknown (%s)", typeid(*l3).name() );
                         }
                     }
-                    
                 }
                 else
                 {
                     MkvTree( sys.demuxer, 4, "Unknown (%s)", typeid(*l2).name() );
                 }
             }
-                
         }
 //        else if( EbmlId( *l ) == KaxCodecSettings::ClassInfos.GlobalId )
 //        {
@@ -4309,6 +4311,8 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
         {
             EbmlMaster *tkv = static_cast<EbmlMaster*>(l);
             unsigned int j;
+            unsigned int i_crop_right = 0, i_crop_left = 0, i_crop_top = 0, i_crop_bottom = 0;
+            unsigned int i_display_unit = 0, i_display_width = 0, i_display_height = 0;
 
             msg_Dbg( &sys.demuxer, "|   |   |   + Track Video" );
             tk->f_fps = 0.0;
@@ -4350,44 +4354,42 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
                 {
                     KaxVideoDisplayWidth &vwidth = *(KaxVideoDisplayWidth*)l;
 
-                    tk->fmt.video.i_visible_width = uint16( vwidth );
+                    i_display_width = uint16( vwidth );
                     msg_Dbg( &sys.demuxer, "|   |   |   |   + display width=%d", uint16( vwidth ) );
                 }
                 else if( MKV_IS_ID( l, KaxVideoDisplayHeight ) )
                 {
                     KaxVideoDisplayWidth &vheight = *(KaxVideoDisplayWidth*)l;
 
-                    tk->fmt.video.i_visible_height = uint16( vheight );
+                    i_display_height = uint16( vheight );
                     msg_Dbg( &sys.demuxer, "|   |   |   |   + display height=%d", uint16( vheight ) );
                 }
                 else if( MKV_IS_ID( l, KaxVideoPixelCropBottom ) )
                 {
                     KaxVideoPixelCropBottom &cropval = *(KaxVideoPixelCropBottom*)l;
 
-                    tk->fmt.video.i_height -= uint16( cropval );
+                    i_crop_bottom = uint16( cropval );
                     msg_Dbg( &sys.demuxer, "|   |   |   |   + crop pixel bottom=%d", uint16( cropval ) );
                 }
                 else if( MKV_IS_ID( l, KaxVideoPixelCropTop ) )
                 {
                     KaxVideoPixelCropTop &cropval = *(KaxVideoPixelCropTop*)l;
 
-                    tk->fmt.video.i_height -= uint16( cropval );
-                    tk->fmt.video.i_y_offset += uint16( cropval );
+                    i_crop_top = uint16( cropval );
                     msg_Dbg( &sys.demuxer, "|   |   |   |   + crop pixel top=%d", uint16( cropval ) );
                 }
                 else if( MKV_IS_ID( l, KaxVideoPixelCropRight ) )
                 {
                     KaxVideoPixelCropRight &cropval = *(KaxVideoPixelCropRight*)l;
 
-                    tk->fmt.video.i_width -= uint16( cropval );
+                    i_crop_right = uint16( cropval );
                     msg_Dbg( &sys.demuxer, "|   |   |   |   + crop pixel right=%d", uint16( cropval ) );
                 }
                 else if( MKV_IS_ID( l, KaxVideoPixelCropLeft ) )
                 {
                     KaxVideoPixelCropLeft &cropval = *(KaxVideoPixelCropLeft*)l;
 
-                    tk->fmt.video.i_width -= uint16( cropval );
-                    tk->fmt.video.i_x_offset += uint16( cropval );
+                    i_crop_left = uint16( cropval );
                     msg_Dbg( &sys.demuxer, "|   |   |   |   + crop pixel left=%d", uint16( cropval ) );
                 }
                 else if( MKV_IS_ID( l, KaxVideoFrameRate ) )
@@ -4397,13 +4399,14 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
                     tk->f_fps = float( vfps );
                     msg_Dbg( &sys.demuxer, "   |   |   |   + fps=%f", float( vfps ) );
                 }
-//                else if( EbmlId( *l ) == KaxVideoDisplayUnit::ClassInfos.GlobalId )
-//                {
-//                     KaxVideoDisplayUnit &vdmode = *(KaxVideoDisplayUnit*)l;
+                else if( EbmlId( *l ) == KaxVideoDisplayUnit::ClassInfos.GlobalId )
+                {
+                    KaxVideoDisplayUnit &vdmode = *(KaxVideoDisplayUnit*)l;
 
-//                    msg_Dbg( &sys.demuxer, "|   |   |   |   + Track Video Display Unit=%s",
-//                             uint8( vdmode ) == 0 ? "pixels" : ( uint8( vdmode ) == 1 ? "centimeters": "inches" ) );
-//                }
+                    i_display_unit = uint8( vdmode );
+                    msg_Dbg( &sys.demuxer, "|   |   |   |   + Track Video Display Unit=%s",
+                             uint8( vdmode ) == 0 ? "pixels" : ( uint8( vdmode ) == 1 ? "centimeters": "inches" ) );
+                }
 //                else if( EbmlId( *l ) == KaxVideoAspectRatio::ClassInfos.GlobalId )
 //                {
 //                    KaxVideoAspectRatio &ratio = *(KaxVideoAspectRatio*)l;
@@ -4414,15 +4417,26 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
 //                {
 //                    KaxVideoGamma &gamma = *(KaxVideoGamma*)l;
 
-//                    msg_Dbg( &sys.demuxer, "   |   |   |   + fps=%f", float( gamma ) );
+//                    msg_Dbg( &sys.demuxer, "   |   |   |   + gamma=%f", float( gamma ) );
 //                }
                 else
                 {
                     msg_Dbg( &sys.demuxer, "|   |   |   |   + Unknown (%s)", typeid(*l).name() );
                 }
             }
-            if ( tk->fmt.video.i_visible_height && tk->fmt.video.i_visible_width )
-                tk->fmt.video.i_aspect = VOUT_ASPECT_FACTOR * tk->fmt.video.i_visible_width / tk->fmt.video.i_visible_height;
+            if( i_display_height && i_display_width )
+                tk->fmt.video.i_aspect = VOUT_ASPECT_FACTOR * i_display_width / i_display_height;
+            if( i_crop_left || i_crop_right || i_crop_top || i_crop_bottom )
+            {
+                tk->fmt.video.i_visible_width = tk->fmt.video.i_width;
+                tk->fmt.video.i_visible_height = tk->fmt.video.i_height;
+                tk->fmt.video.i_x_offset = i_crop_left;
+                tk->fmt.video.i_y_offset = i_crop_top;
+                tk->fmt.video.i_visible_width -= i_crop_left + i_crop_right;
+                tk->fmt.video.i_visible_height -= i_crop_top + i_crop_bottom;
+            }
+            /* FIXME: i_display_* allows you to not only set DAR, but also a zoom factor.
+               we do not support this atm */
         }
         else  if( MKV_IS_ID( l, KaxTrackAudio ) )
         {
@@ -5061,8 +5075,8 @@ chapter_item_c *chapter_item_c::FindTimecode( mtime_t i_user_timecode, const cha
     if ( p_current == this )
         b_found = true;
 
-    if ( i_user_timecode >= i_user_start_time && 
-        ( i_user_timecode < i_user_end_time || 
+    if ( i_user_timecode >= i_user_start_time &&
+        ( i_user_timecode < i_user_end_time ||
           ( i_user_start_time == i_user_end_time && i_user_timecode == i_user_end_time )))
     {
         std::vector<chapter_item_c*>::iterator index = sub_chapters.begin();
@@ -5365,10 +5379,10 @@ matroska_segment_c *demux_sys_t::FindSegment( const EbmlBinary & uid ) const
     return NULL;
 }
 
-chapter_item_c *demux_sys_t::BrowseCodecPrivate( unsigned int codec_id, 
-                                        bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ), 
-                                        const void *p_cookie, 
-                                        size_t i_cookie_size, 
+chapter_item_c *demux_sys_t::BrowseCodecPrivate( unsigned int codec_id,
+                                        bool (*match)(const chapter_codec_cmds_c &data, const void *p_cookie, size_t i_cookie_size ),
+                                        const void *p_cookie,
+                                        size_t i_cookie_size,
                                         virtual_segment_c * &p_segment_found )
 {
     chapter_item_c *p_result = NULL;
@@ -5417,7 +5431,7 @@ size_t virtual_segment_c::AddSegment( matroska_segment_c *p_segment )
     // check if it's not already in here
     for ( i=0; i<linked_segments.size(); i++ )
     {
-        if ( linked_segments[i]->p_segment_uid != NULL 
+        if ( linked_segments[i]->p_segment_uid != NULL
             && p_segment->p_segment_uid != NULL
             && *p_segment->p_segment_uid == *linked_segments[i]->p_segment_uid )
             return 0;
@@ -5594,7 +5608,7 @@ void matroska_segment_c::Seek( mtime_t i_date, mtime_t i_time_offset )
                     BlockDecode( &sys.demuxer, block, sys.i_pts, 0, i_block_ref1 >= 0 || i_block_ref2 > 0 );
 #endif
                 }
-            } 
+            }
         }
 
         delete block;
@@ -6387,7 +6401,7 @@ bool matroska_script_codec_c::Leave()
     return f_result;
 }
 
-// see http://www.matroska.org/technical/specs/chapters/index.html#mscript 
+// see http://www.matroska.org/technical/specs/chapters/index.html#mscript
 //  for a description of existing commands
 bool matroska_script_interpretor_c::Interpret( const binary * p_command, size_t i_size )
 {