/*****************************************************************************
* Preamble
*****************************************************************************/
-#include <vlc/vlc.h>
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
+#include <vlc_common.h>
#include <vlc_demux.h>
#include "playlist.h"
-#include "vlc_xml.h"
+#include <vlc_xml.h>
struct demux_sys_t
{
char *psz_prefix;
- playlist_t *p_playlist;
xml_t *p_xml;
xml_reader_t *p_xml_reader;
};
/*****************************************************************************
* Import_podcast: main import function
*****************************************************************************/
-int E_(Import_podcast)( vlc_object_t *p_this )
+int Import_podcast( vlc_object_t *p_this )
{
demux_t *p_demux = (demux_t *)p_this;
- if( !demux2_IsForced( p_demux, "podcast" ) )
+ if( !demux_IsForced( p_demux, "podcast" ) )
return VLC_EGENERIC;
STANDARD_DEMUX_INIT_MSG( "using podcast reader" );
- p_demux->p_sys->psz_prefix = E_(FindPrefix)( p_demux );
- p_demux->p_sys->p_playlist = NULL;
+ p_demux->p_sys->psz_prefix = FindPrefix( p_demux );
p_demux->p_sys->p_xml = NULL;
p_demux->p_sys->p_xml_reader = NULL;
/*****************************************************************************
* Deactivate: frees unused data
*****************************************************************************/
-void E_(Close_podcast)( vlc_object_t *p_this )
+void Close_podcast( vlc_object_t *p_this )
{
demux_t *p_demux = (demux_t *)p_this;
demux_sys_t *p_sys = p_demux->p_sys;
- if( p_sys->psz_prefix ) free( p_sys->psz_prefix );
- if( p_sys->p_playlist ) vlc_object_release( p_sys->p_playlist );
+ free( p_sys->psz_prefix );
if( p_sys->p_xml_reader ) xml_ReaderDelete( p_sys->p_xml, p_sys->p_xml_reader );
if( p_sys->p_xml ) xml_Delete( p_sys->p_xml );
free( p_sys );
{
demux_sys_t *p_sys = p_demux->p_sys;
- vlc_bool_t b_item = VLC_FALSE;
- vlc_bool_t b_image = VLC_FALSE;
+ bool b_item = false;
+ bool b_image = false;
int i_ret;
xml_t *p_xml;
msg_Err( p_demux, "invalid file (no root node)" );
return -1;
}
+
+ while( xml_ReaderNodeType( p_xml_reader ) == XML_READER_NONE )
+ if( xml_ReaderRead( p_xml_reader ) != 1 )
+ {
+ msg_Err( p_demux, "invalid file (no root node)" );
+ return -1;
+ }
+
if( xml_ReaderNodeType( p_xml_reader ) != XML_READER_STARTELEM ||
( psz_elname = xml_ReaderName( p_xml_reader ) ) == NULL ||
strcmp( psz_elname, "rss" ) )
{
msg_Err( p_demux, "invalid root node %i, %s",
xml_ReaderNodeType( p_xml_reader ), psz_elname );
- if( psz_elname ) free( psz_elname );
+ free( psz_elname );
return -1;
}
free( psz_elname ); psz_elname = NULL;
case XML_READER_STARTELEM:
{
// Read the element name
- if( psz_elname ) free( psz_elname );
+ free( psz_elname );
psz_elname = xml_ReaderName( p_xml_reader );
if( !psz_elname ) return -1;
if( !strcmp( psz_elname, "item" ) )
{
- b_item = VLC_TRUE;
+ b_item = true;
}
else if( !strcmp( psz_elname, "image" ) )
{
- b_item = VLC_TRUE;
+ b_item = true;
}
// Read the attributes
{
char *psz_name = xml_ReaderName( p_xml_reader );
char *psz_value = xml_ReaderValue( p_xml_reader );
- if( !psz_name || !psz_value ) return -1;
+ if( !psz_name || !psz_value )
+ {
+ free( psz_name );
+ free( psz_value );
+ free( psz_elname );
+ return -1;
+ }
if( !strcmp( psz_elname, "enclosure" ) &&
!strcmp( psz_name, "url" ) )
{
+ free( psz_item_mrl );
psz_item_mrl = strdup( psz_value );
}
else if( !strcmp( psz_elname, "enclosure" ) &&
!strcmp( psz_name, "length" ) )
{
+ free( psz_item_size );
psz_item_size = strdup( psz_value );
}
else if( !strcmp( psz_elname, "enclosure" ) &&
!strcmp( psz_name, "type" ) )
{
+ free( psz_item_type );
psz_item_type = strdup( psz_value );
}
else
}
case XML_READER_TEXT:
{
-#define SET_DATA( field, name ) else if( b_item == VLC_TRUE \
+#define SET_DATA( field, name ) else if( b_item == true \
&& !strcmp( psz_elname, name ) ) \
{ \
field = strdup( psz_text ); \
}
char *psz_text = xml_ReaderValue( p_xml_reader );
/* item specific meta data */
- if( b_item == VLC_TRUE && !strcmp( psz_elname, "title" ) )
+ if( b_item == true && !strcmp( psz_elname, "title" ) )
{
psz_item_name = strdup( psz_text );
}
- else if( b_item == VLC_TRUE
+ else if( b_item == true
&& ( !strcmp( psz_elname, "itunes:author" )
||!strcmp( psz_elname, "author" ) ) )
{ /* <author> isn't standard iTunes podcast stuff */
psz_item_author = strdup( psz_text );
}
- else if( b_item == VLC_TRUE
+ else if( b_item == true
&& ( !strcmp( psz_elname, "itunes:summary" )
||!strcmp( psz_elname, "description" ) ) )
{ /* <description> isn't standard iTunes podcast stuff */
SET_DATA( psz_item_duration, "itunes:duration" )
SET_DATA( psz_item_keywords, "itunes:keywords" )
SET_DATA( psz_item_subtitle, "itunes:subtitle" )
+#undef SET_DATA
/* toplevel meta data */
- else if( b_item == VLC_FALSE && b_image == VLC_FALSE
+ else if( b_item == false && b_image == false
&& !strcmp( psz_elname, "title" ) )
{
input_item_SetName( p_current_input, psz_text );
#define ADD_GINFO( info, name ) \
else if( !b_item && !b_image && !strcmp( psz_elname, name ) ) \
{ \
- input_ItemAddInfo( p_current_input, _("Podcast Info"), \
+ input_item_AddInfo( p_current_input, _("Podcast Info"), \
_( info ), "%s", psz_text ); \
}
ADD_GINFO( "Podcast Link", "link" )
ADD_GINFO( "Podcast Keywords", "itunes:keywords" )
ADD_GINFO( "Podcast Subtitle", "itunes:subtitle" )
#undef ADD_GINFO
- else if( b_item == VLC_FALSE && b_image == VLC_FALSE
+ else if( b_item == false && b_image == false
&& ( !strcmp( psz_elname, "itunes:summary" )
||!strcmp( psz_elname, "description" ) ) )
{ /* <description> isn't standard iTunes podcast stuff */
- input_ItemAddInfo( p_current_input,
+ input_item_AddInfo( p_current_input,
_( "Podcast Info" ), _( "Podcast Summary" ),
"%s", psz_text );
}
if( !psz_elname ) return -1;
if( !strcmp( psz_elname, "item" ) )
{
- p_input = input_ItemNewExt( p_playlist, psz_item_mrl,
- psz_item_name, 0, NULL, -1 );
+ if( psz_item_mrl == NULL )
+ {
+ msg_Err( p_demux, "invalid XML (no enclosure markup)" );
+ free( psz_elname );
+ return -1;
+ }
+ p_input = input_item_New( p_demux, psz_item_mrl, psz_item_name );
if( p_input == NULL ) break;
#define ADD_INFO( info, field ) \
- if( field ) { input_ItemAddInfo( p_input, \
+ if( field ) { input_item_AddInfo( p_input, \
_( "Podcast Info" ), _( info ), "%s", field ); }
ADD_INFO( "Podcast Publication Date", psz_item_date );
ADD_INFO( "Podcast Author", psz_item_author );
ADD_INFO( "Podcast Subtitle", psz_item_subtitle );
ADD_INFO( "Podcast Summary", psz_item_summary );
ADD_INFO( "Podcast Type", psz_item_type );
+#undef ADD_INFO
if( psz_item_size )
{
- input_ItemAddInfo( p_input,
+ input_item_AddInfo( p_input,
_( "Podcast Info" ),
_( "Podcast Size" ),
"%s bytes",
psz_item_size );
}
- input_ItemAddSubItem( p_current_input, p_input );
+ input_item_AddSubItem( p_current_input, p_input );
+ vlc_gc_decref( p_input );
FREENULL( psz_item_name );
FREENULL( psz_item_mrl );
FREENULL( psz_item_size );
FREENULL( psz_item_keywords );
FREENULL( psz_item_subtitle );
FREENULL( psz_item_summary );
- b_item = VLC_FALSE;
+ b_item = false;
}
else if( !strcmp( psz_elname, "image" ) )
{
- b_image = VLC_FALSE;
+ b_image = false;
}
free( psz_elname );
- psz_elname = strdup("");
+ psz_elname = strdup( "" );
break;
}
msg_Warn( p_demux, "error while parsing data" );
}
+ free( psz_elname );
+
HANDLE_PLAY_AND_RELEASE;
- return -1; /* Needed for correct operation of go back */
+ return 0; /* Needed for correct operation of go back */
}
static int Control( demux_t *p_demux, int i_query, va_list args )
{
+ VLC_UNUSED(p_demux); VLC_UNUSED(i_query); VLC_UNUSED(args);
return VLC_EGENERIC;
}