xml_ReaderDelete: remove useless parameter

[vlc] / modules / demux / playlist / shoutcast.c

diff --git a/modules/demux/playlist/shoutcast.c b/modules/demux/playlist/shoutcast.c
index c007e9d1d0a0527dc0e45302208bdeb1f2f5f381..2534c7c2daf30b246c89c2a7f7ca3b1823ca99b0 100644 (file)
--- a/modules/demux/playlist/shoutcast.c
+++ b/modules/demux/playlist/shoutcast.c
@@ -84,6 +84,7 @@ static int Demux( demux_t *p_demux )
     char *psz_eltname = NULL;
     int i_ret = -1;
     input_item_t *p_current_input = GetCurrentItem(p_demux);
+    input_item_node_t *p_input_node = NULL;
 
     p_xml = xml_Create( p_demux );
     if( !p_xml )
@@ -110,7 +111,7 @@ static int Demux( demux_t *p_demux )
         goto error;
     }
 
-    input_item_node_t *p_input_node = input_item_node_Create( p_current_input );
+    p_input_node = input_item_node_Create( p_current_input );
 
     if( !strcmp( psz_eltname, "genrelist" ) )
     {
@@ -122,21 +123,22 @@ static int Demux( demux_t *p_demux )
     {
         /* we're reading a station list */
         if( DemuxStation( p_demux, p_xml_reader, p_input_node,
-                var_CreateGetBool( p_demux, "shoutcast-show-adult" ) ) )
+                var_InheritBool( p_demux, "shoutcast-show-adult" ) ) )
             goto error;
     }
 
-    input_item_AddSubItemTree( p_input_node );
+    input_item_node_PostAndDelete( p_input_node );
+    p_input_node = NULL;
 
     i_ret = 0; /* Needed for correct operation of go back */
 
 error:
     if( p_xml_reader )
-        xml_ReaderDelete( p_xml, p_xml_reader );
+        xml_ReaderDelete( p_xml_reader );
     if( p_xml )
         xml_Delete( p_xml );
     free( psz_eltname );
-    input_item_node_Delete( p_input_node );
+    if( p_input_node ) input_item_node_Delete( p_input_node );
     vlc_gc_decref(p_current_input);
     return i_ret;
 }
@@ -194,7 +196,7 @@ static int DemuxGenre( demux_t *p_demux, xml_reader_t *p_xml_reader,
                         else
                         {
                             msg_Warn( p_demux,
-                                      "unexpected attribure %s in element %s",
+                                      "unexpected attribute %s in element %s",
                                       psz_attrname, psz_eltname );
                             free( psz_attrvalue );
                         }
@@ -226,7 +228,6 @@ static int DemuxGenre( demux_t *p_demux, xml_reader_t *p_xml_reader,
                         p_input = input_item_New( p_demux, psz_mrl, psz_name );
                         input_item_CopyOptions( p_input_node->p_item, p_input );
                         free( psz_mrl );
-                        input_item_AddSubItem( p_input_node->p_item, p_input );
                         input_item_node_AppendItem( p_input_node, p_input );
                         vlc_gc_decref( p_input );
                     }
@@ -326,7 +327,7 @@ static int DemuxStation( demux_t *p_demux, xml_reader_t *p_xml_reader,
                         else
                         {
                             msg_Warn( p_demux,
-                                      "unexpected attribure %s in element %s",
+                                      "unexpected attribute %s in element %s",
                                       psz_attrname, psz_eltname );
                             free( psz_attrvalue );
                         }
@@ -418,7 +419,6 @@ static int DemuxStation( demux_t *p_demux, xml_reader_t *p_xml_reader,
                         input_item_SetNowPlaying( p_input, psz_ct );
                     if( psz_rt )
                         input_item_SetRating( p_input, psz_rt );
-                    input_item_AddSubItem( p_input_node->p_item, p_input );
                     input_item_node_AppendItem( p_input_node, p_input );
                     vlc_gc_decref( p_input );
                     FREENULL( psz_base );