]> git.sesse.net Git - vlc/blobdiff - modules/demux/playlist/shoutcast.c
Fix deletion of items when changing them to nodes
[vlc] / modules / demux / playlist / shoutcast.c
index ac56600fcb01a573308f24541e2d4b4327ebe716..ca7caebbf7bf82393bf7beba7be87f441247bb34 100644 (file)
@@ -25,7 +25,6 @@
 /*****************************************************************************
  * Preamble
  *****************************************************************************/
-#include <stdlib.h>                                      /* malloc(), free() */
 #include <ctype.h>                                              /* isspace() */
 
 #include <vlc/vlc.h>
@@ -40,9 +39,13 @@ struct demux_sys_t
 {
     playlist_t *p_playlist;
     playlist_item_t *p_current;
+    playlist_item_t *p_item_in_category;
+    int i_parent_id;
 
     xml_t *p_xml;
     xml_reader_t *p_xml_reader;
+
+    vlc_bool_t b_adult;
 };
 
 /* duplicate from modules/services_discovery/shout.c */
@@ -55,11 +58,6 @@ struct demux_sys_t
  *****************************************************************************/
 static int Demux( demux_t *p_demux);
 static int Control( demux_t *p_demux, int i_query, va_list args );
-#if 0
-static void ShoutcastAdd( playlist_t *p_playlist, playlist_item_t* p_genre,
-                          playlist_item_t *p_bitrate, playlist_item_t *p_item,
-                          char *psz_genre, char *psz_bitrate );
-#endif
 
 static int DemuxGenre( demux_t *p_demux );
 static int DemuxStation( demux_t *p_demux );
@@ -70,30 +68,19 @@ static int DemuxStation( demux_t *p_demux );
 int E_(Import_Shoutcast)( vlc_object_t *p_this )
 {
     demux_t *p_demux = (demux_t *)p_this;
-    demux_sys_t *p_sys;
-
-    char    *psz_ext;
 
-    psz_ext = strrchr ( p_demux->psz_path, '.' );
-
-    if( !p_demux->psz_demux || strcmp(p_demux->psz_demux, "shout-winamp") )
-    {
+    if( !isDemux( p_demux, "shout-winamp" ) )
         return VLC_EGENERIC;
-    }
-    msg_Dbg( p_demux, "using shoutcast playlist import");
 
-    p_demux->pf_control = Control;
-    p_demux->pf_demux = Demux;
-    p_demux->p_sys = p_sys = malloc( sizeof(demux_sys_t) );
-    if( p_sys == NULL )
-    {
-        msg_Err( p_demux, "out of memory" );
-        return VLC_ENOMEM;
-    }
+    STANDARD_DEMUX_INIT_MSG( "using shoutcast playlist reader" );
+    p_demux->p_sys->p_playlist = NULL;
+    p_demux->p_sys->p_xml = NULL;
+    p_demux->p_sys->p_xml_reader = NULL;
 
-    p_sys->p_playlist = NULL;
-    p_sys->p_xml = NULL;
-    p_sys->p_xml_reader = NULL;
+    /* Do we want to list adult content ? */
+    var_Create( p_demux, "shoutcast-show-adult",
+                VLC_VAR_BOOL | VLC_VAR_DOINHERIT );
+    p_demux->p_sys->b_adult = var_GetBool( p_demux, "shoutcast-show-adult" );
 
     return VLC_SUCCESS;
 }
@@ -118,43 +105,22 @@ void E_(Close_Shoutcast)( vlc_object_t *p_this )
 static int Demux( demux_t *p_demux )
 {
     demux_sys_t *p_sys = p_demux->p_sys;
-    playlist_t *p_playlist;
-
-    vlc_bool_t b_play;
-
     xml_t *p_xml;
     xml_reader_t *p_xml_reader;
-
     char *psz_eltname = NULL;
-
-
-    p_playlist = (playlist_t *) vlc_object_find( p_demux, VLC_OBJECT_PLAYLIST,
-                                                 FIND_ANYWHERE );
-    if( !p_playlist )
-    {
-        msg_Err( p_demux, "can't find playlist" );
-        return -1;
-    }
+    INIT_PLAYLIST_STUFF;
     p_sys->p_playlist = p_playlist;
-
-    b_play = E_(FindItem)( p_demux, p_playlist, &p_sys->p_current );
-
-    msg_Warn( p_demux, "item: %s", p_sys->p_current->input.psz_name );
-    playlist_ItemToNode( p_playlist, p_sys->p_current );
-    p_sys->p_current->input.i_type = ITEM_TYPE_PLAYLIST;
+    p_sys->p_current = p_current;
+    p_sys->i_parent_id = i_parent_id;
+    p_sys->p_item_in_category = p_item_in_category;
 
     p_xml = p_sys->p_xml = xml_Create( p_demux );
     if( !p_xml ) return -1;
 
-/*    psz_eltname = stream_ReadLine( p_demux->s );
-    if( psz_eltname ) free( psz_eltname );
-    psz_eltname = 0;*/
-
     p_xml_reader = xml_ReaderCreate( p_xml, p_demux->s );
     if( !p_xml_reader ) return -1;
     p_sys->p_xml_reader = p_xml_reader;
 
-    /* xml */
     /* check root node */
     if( xml_ReaderRead( p_xml_reader ) != 1 )
     {
@@ -176,26 +142,17 @@ static int Demux( demux_t *p_demux )
     if( !strcmp( psz_eltname, "genrelist" ) )
     {
         /* we're reading a genre list */
+        free( psz_eltname );
         if( DemuxGenre( p_demux ) ) return -1;
     }
     else
     {
         /* we're reading a station list */
+        free( psz_eltname );
         if( DemuxStation( p_demux ) ) return -1;
     }
-    free( psz_eltname );
 
-    /* Go back and play the playlist */
-    if( b_play && p_playlist->status.p_item &&
-        p_playlist->status.p_item->i_children > 0 )
-    {
-        playlist_Control( p_playlist, PLAYLIST_VIEWPLAY,
-                          p_playlist->status.i_view,
-                          p_playlist->status.p_item,
-                          p_playlist->status.p_item->pp_children[0] );
-    }
-
-    vlc_object_release( p_playlist );
+    HANDLE_PLAY_AND_RELEASE;
     p_sys->p_playlist = NULL;
     return VLC_SUCCESS;
 }
@@ -215,6 +172,7 @@ static int DemuxGenre( demux_t *p_demux )
     demux_sys_t *p_sys = p_demux->p_sys;
     char *psz_name = NULL; /* genre name */
     char *psz_eltname = NULL; /* tag name */
+    input_item_t *p_input;
 
     while( xml_ReaderRead( p_sys->p_xml_reader ) == 1 )
     {
@@ -231,11 +189,9 @@ static int DemuxGenre( demux_t *p_demux )
 
             case XML_READER_STARTELEM:
                 // Read the element name
-                if( psz_eltname ) free( psz_eltname );
                 psz_eltname = xml_ReaderName( p_sys->p_xml_reader );
                 if( !psz_eltname ) return -1;
 
-
                 if( !strcmp( psz_eltname, "genre" ) )
                 {
                     // Read the attributes
@@ -244,20 +200,27 @@ static int DemuxGenre( demux_t *p_demux )
                         char *psz_attrname = xml_ReaderName( p_sys->p_xml_reader );
                         char *psz_attrvalue =
                             xml_ReaderValue( p_sys->p_xml_reader );
-                        if( !psz_attrname || !psz_attrvalue ) return -1;
+                        if( !psz_attrname || !psz_attrvalue )
+                        {
+                            FREENULL(psz_attrname);
+                            FREENULL(psz_attrvalue);
+                            free(psz_eltname);
+                            /*FIXME: isn't return a bit too much. what about break*/
+                            return -1;
+                        }
 
                         GET_VALUE( name )
                         else
                         {
                             msg_Warn( p_demux,
                                       "unexpected attribure %s in element %s",
-                                      psz_attrname,
-                                      psz_eltname );
+                                      psz_attrname,psz_eltname );
                         }
                         free( psz_attrname );
                         free( psz_attrvalue );
                     }
                 }
+                free( psz_eltname ); psz_eltname = NULL;
                 break;
 
             case XML_READER_TEXT:
@@ -266,38 +229,26 @@ static int DemuxGenre( demux_t *p_demux )
             // End element
             case XML_READER_ENDELEM:
                 // Read the element name
-                free( psz_eltname );
                 psz_eltname = xml_ReaderName( p_sys->p_xml_reader );
                 if( !psz_eltname ) return -1;
                 if( !strcmp( psz_eltname, "genre" ) )
                 {
-                    playlist_item_t *p_item;
                     char *psz_mrl = malloc( strlen( SHOUTCAST_BASE_URL )
                             + strlen( "?genre=" ) + strlen( psz_name ) + 1 );
                     sprintf( psz_mrl, SHOUTCAST_BASE_URL "?genre=%s",
                              psz_name );
-                    p_item = playlist_ItemNew( p_sys->p_playlist, psz_mrl,
-                                               psz_name );
+                    p_input = input_ItemNewExt( p_sys->p_playlist, psz_mrl,
+                                                psz_name, 0, NULL, -1 );
+                    vlc_input_item_CopyOptions( p_sys->p_current->p_input,
+                                                p_input );
                     free( psz_mrl );
-                    playlist_NodeAddItem( p_sys->p_playlist, p_item,
-                                          p_sys->p_current->pp_parents[0]->i_view,
-                                          p_sys->p_current, PLAYLIST_APPEND,
-                                          PLAYLIST_END );
-
-                    /* We need to declare the parents of the node as the
-                     *                  * same of the parent's ones */
-                    playlist_CopyParents( p_sys->p_current, p_item );
-
-                    vlc_input_item_CopyOptions( &p_sys->p_current->input,
-                                                &p_item->input );
-
-#define FREE(a) if( a ) free( a ); a = NULL;
-                    FREE( psz_name );
-#undef FREE
+                    playlist_AddWhereverNeeded( p_sys->p_playlist, p_input,
+                             p_sys->p_current, p_sys->p_item_in_category,
+                             (p_sys->i_parent_id > 0 ) ? VLC_TRUE: VLC_FALSE,
+                             PLAYLIST_APPEND );
+                    FREENULL( psz_name );
                 }
-                free( psz_eltname );
-                psz_eltname = strdup("");
-
+                FREENULL( psz_eltname );
                 break;
         }
     }
@@ -332,6 +283,7 @@ static int DemuxGenre( demux_t *p_demux )
 static int DemuxStation( demux_t *p_demux )
 {
     demux_sys_t *p_sys = p_demux->p_sys;
+    input_item_t *p_input;
 
     char *psz_base = NULL; /* */
 
@@ -364,7 +316,6 @@ static int DemuxStation( demux_t *p_demux )
 
             case XML_READER_STARTELEM:
                 // Read the element name
-                if( psz_eltname ) free( psz_eltname );
                 psz_eltname = xml_ReaderName( p_sys->p_xml_reader );
                 if( !psz_eltname ) return -1;
 
@@ -376,15 +327,20 @@ static int DemuxStation( demux_t *p_demux )
                         char *psz_attrname = xml_ReaderName( p_sys->p_xml_reader );
                         char *psz_attrvalue =
                             xml_ReaderValue( p_sys->p_xml_reader );
-                        if( !psz_attrname || !psz_attrvalue ) return -1;
+                        if( !psz_attrname || !psz_attrvalue )
+                        {
+                            free(psz_eltname);
+                            FREENULL(psz_attrname);
+                            FREENULL(psz_attrvalue);
+                            return -1;
+                        }
 
                         GET_VALUE( base )
                         else
                         {
                             msg_Warn( p_demux,
                                       "unexpected attribure %s in element %s",
-                                      psz_attrname,
-                                      psz_eltname );
+                                      psz_attrname, psz_eltname );
                         }
                         free( psz_attrname );
                         free( psz_attrvalue );
@@ -397,7 +353,13 @@ static int DemuxStation( demux_t *p_demux )
                         char *psz_attrname = xml_ReaderName( p_sys->p_xml_reader );
                         char *psz_attrvalue =
                             xml_ReaderValue( p_sys->p_xml_reader );
-                        if( !psz_attrname || !psz_attrvalue ) return -1;
+                        if( !psz_attrname || !psz_attrvalue )
+                        {
+                            free(psz_eltname);
+                            FREENULL(psz_attrname);
+                            FREENULL(psz_attrvalue);
+                            return -1;
+                        }
 
                         GET_VALUE( name )
                         else GET_VALUE( mt )
@@ -411,14 +373,14 @@ static int DemuxStation( demux_t *p_demux )
                         else
                         {
                             msg_Warn( p_demux,
-                                      "unexpected attribure %s in element %s",
-                                      psz_attrname,
-                                      psz_eltname );
+                                      "unexpected attribute %s in element %s",
+                                      psz_attrname, psz_eltname );
                         }
                         free( psz_attrname );
                         free( psz_attrvalue );
                     }
                 }
+                free(psz_eltname);
                 break;
 
             case XML_READER_TEXT:
@@ -427,13 +389,12 @@ static int DemuxStation( demux_t *p_demux )
             // End element
             case XML_READER_ENDELEM:
                 // Read the element name
-                free( psz_eltname );
                 psz_eltname = xml_ReaderName( p_sys->p_xml_reader );
                 if( !psz_eltname ) return -1;
                 if( !strcmp( psz_eltname, "station" ) &&
-                    ( psz_base || ( psz_rt && psz_load ) ) )
+                    ( psz_base || ( psz_rt && psz_load &&
+                    ( p_sys->b_adult || strcmp( psz_rt, "NC17" ) ) ) ) )
                 {
-                    playlist_item_t *p_item;
                     char *psz_mrl = NULL;
                     if( psz_rt || psz_load )
                     {
@@ -452,94 +413,42 @@ static int DemuxStation( demux_t *p_demux )
                         sprintf( psz_mrl, SHOUTCAST_TUNEIN_BASE_URL "%s?id=%s",
                              psz_base, psz_id );
                     }
-                    msg_Warn( p_demux, "%s", psz_mrl );
-                    p_item = playlist_ItemNew( p_sys->p_playlist, psz_mrl,
-                                               psz_name );
+                    p_input = input_ItemNewExt( p_sys->p_playlist, psz_mrl,
+                                                psz_name , 0, NULL, -1 );
                     free( psz_mrl );
 
-                    if( psz_mt )
-                    {
-                        vlc_input_item_AddInfo( &p_item->input,
-                                                _( "Shoutcast" ),
-                                                _( "Mime type" ),
-                                                "%s",
-                                                psz_mt );
-                    }
-                    else if( psz_br )
-                    {
-                        vlc_input_item_AddInfo( &p_item->input,
-                                                _( "Shoutcast" ),
-                                                _( "Bitrate" ),
-                                                "%s",
-                                                psz_br );
-                    }
-                    else if( psz_genre )
-                    {
-                        vlc_input_item_AddInfo( &p_item->input,
-                                                _(VLC_META_INFO_CAT),
-                                                _(VLC_META_GENRE),
-                                                "%s",
-                                                psz_genre );
-                    }
-                    else if( psz_ct )
-                    {
-                        vlc_input_item_AddInfo( &p_item->input,
-                                                _(VLC_META_INFO_CAT),
-                                                _(VLC_META_NOW_PLAYING),
-                                                "%s",
-                                                psz_ct );
-                    }
-                    else if( psz_lc )
-                    {
-                        vlc_input_item_AddInfo( &p_item->input,
-                                                _( "Shoutcast" ),
-                                                _( "Listeners" ),
-                                                "%s",
-                                                psz_lc );
-                    }
-                    else if( psz_rt )
-                    {
-                        vlc_input_item_AddInfo( &p_item->input,
-                                                _( "Shoutcast" ),
-                                                _( "Rating" ),
-                                                "%s",
-                                                psz_rt );
-                    }
-                    else if( psz_load )
-                    {
-                        vlc_input_item_AddInfo( &p_item->input,
-                                                _( "Shoutcast" ),
-                                                _( "Load" ),
-                                                "%s",
-                                                psz_load );
-                    }
-
-                    playlist_NodeAddItem( p_sys->p_playlist, p_item,
-                                          p_sys->p_current->pp_parents[0]->i_view,
-                                          p_sys->p_current, PLAYLIST_APPEND,
-                                          PLAYLIST_END );
-
-                    /* We need to declare the parents of the node as the
-                     *                  * same of the parent's ones */
-                    playlist_CopyParents( p_sys->p_current, p_item );
-
-                    vlc_input_item_CopyOptions( &p_sys->p_current->input,
-                                                &p_item->input );
-
-#define FREE(a) if( a ) free( a ); a = NULL;
-                    FREE( psz_name );
-                    FREE( psz_mt )
-                    FREE( psz_id )
-                    FREE( psz_br )
-                    FREE( psz_genre )
-                    FREE( psz_ct )
-                    FREE( psz_lc )
-                    FREE( psz_rt )
-#undef FREE
+                    vlc_input_item_CopyOptions( p_sys->p_current->p_input,
+                                                p_input );
+
+#define SADD_INFO( type, field ) if( field ) { vlc_input_item_AddInfo( \
+                    p_input, _("Shoutcast"), _(type), "%s", field ) ; }
+                    SADD_INFO( "Mime type", psz_mt );
+                    SADD_INFO( "Bitrate", psz_br );
+                    SADD_INFO( "Listeners", psz_lc );
+                    SADD_INFO( "Load", psz_load );
+                    p_input->p_meta = vlc_meta_New();
+                    if( psz_genre )
+                        vlc_meta_SetGenre( p_input->p_meta, psz_genre );
+                    if( psz_ct )
+                        vlc_meta_SetNowPlaying( p_input->p_meta, psz_ct );
+                    if( psz_rt )
+                        vlc_meta_SetRating( p_input->p_meta, psz_rt );
+
+                    playlist_AddWhereverNeeded( p_sys->p_playlist, p_input,
+                             p_sys->p_current, p_sys->p_item_in_category,
+                             (p_sys->i_parent_id > 0 ) ? VLC_TRUE: VLC_FALSE,
+                             PLAYLIST_APPEND );
+
+                    FREENULL( psz_name );
+                    FREENULL( psz_mt )
+                    FREENULL( psz_id )
+                    FREENULL( psz_br )
+                    FREENULL( psz_genre )
+                    FREENULL( psz_ct )
+                    FREENULL( psz_lc )
+                    FREENULL( psz_rt )
                 }
                 free( psz_eltname );
-                psz_eltname = strdup("");
-
                 break;
         }
     }