]> git.sesse.net Git - vlc/blobdiff - modules/demux/ts.c
demux: ts: reject unknown probed streams
[vlc] / modules / demux / ts.c
index 14736b1ced90de08fb0b6cfba05ad7f85c8ce199..a467b56561c5c2cc39ce074eb6aae1c73694c977 100644 (file)
@@ -62,6 +62,9 @@
 # include <dvbpsi/tot.h>
 
 #include "../mux/mpeg/dvbpsi_compat.h"
+#include "../mux/mpeg/streams.h"
+#include "../mux/mpeg/tsutil.h"
+#include "../mux/mpeg/tables.h"
 
 #include "../codec/opus_header.h"
 
@@ -303,8 +306,22 @@ typedef struct
     ts_es_t     **extra_es;
     int         i_extra_es;
 
+    struct
+    {
+        vlc_fourcc_t i_fourcc;
+        int i_type;
+        bool b_haspcr;
+    } probed;
 } ts_pid_t;
 
+typedef struct
+{
+    int i_service;
+} vdr_info_t;
+
+#define MIN_ES_PID 4    /* Should be 32.. broken muxers */
+#define MAX_ES_PID 8190
+
 struct demux_sys_t
 {
     stream_t   *stream;
@@ -347,6 +364,7 @@ struct demux_sys_t
     int         i_pmt;
     ts_pid_t    **pmt;
     int         i_pmt_es;
+    bool        b_delay_es_creation;
 
     /* */
     bool        b_es_id_pid;
@@ -355,6 +373,7 @@ struct demux_sys_t
     bool        b_split_es;
 
     bool        b_trust_pcr;
+    bool        b_disable_pcr;
 
     /* */
     bool        b_access_control;
@@ -370,6 +389,22 @@ struct demux_sys_t
     int         i_current_program;
     vlc_list_t  programs_list;
 
+    struct
+    {
+        /* broken PCR handling */
+        bool        b_program_pcr_seen;
+        mtime_t     i_first_dts;
+    } pcrfix;
+
+    struct
+    {
+        mtime_t i_first_dts;     /* first dts encountered for the stream */
+        int     i_timesourcepid; /* which pid we saved the dts from */
+        bool    b_pat_deadline;  /* set if we haven't seen PAT within 140ms */
+    } patfix;
+
+    vdr_info_t  vdr;
+
     /* */
     bool        b_start_record;
 };
@@ -399,6 +434,7 @@ static inline int PIDGet( block_t *p )
 }
 
 static bool GatherData( demux_t *p_demux, ts_pid_t *pid, block_t *p_bk );
+static void AddAndCreateES( demux_t *p_demux, ts_pid_t *pid );
 
 static block_t* ReadTSPacket( demux_t *p_demux );
 static int Seek( demux_t *p_demux, double f_percent );
@@ -406,6 +442,8 @@ static void GetFirstPCR( demux_t *p_demux );
 static void GetLastPCR( demux_t *p_demux );
 static void CheckPCR( demux_t *p_demux );
 static void PCRHandle( demux_t *p_demux, ts_pid_t *, block_t * );
+static void PCRFixHandle( demux_t *, block_t * );
+static mtime_t AdjustPTSWrapAround( demux_t *, mtime_t );
 
 static void              IODFree( iod_descriptor_t * );
 
@@ -420,105 +458,35 @@ static void SetPrgFilter( demux_t *, int i_prg, bool b_selected );
 #define TS_PACKET_SIZE_204 204
 #define TS_PACKET_SIZE_MAX 204
 
-static int DetectPacketSize( demux_t *p_demux, int *pi_header_size )
+static int DetectPacketSize( demux_t *p_demux, int *pi_header_size, int i_offset )
 {
     const uint8_t *p_peek;
+
     if( stream_Peek( p_demux->s,
-                     &p_peek, TS_PACKET_SIZE_MAX ) < TS_PACKET_SIZE_MAX )
+                     &p_peek, i_offset + TS_PACKET_SIZE_MAX ) < i_offset + TS_PACKET_SIZE_MAX )
         return -1;
 
-    *pi_header_size = 0;
-
-    if( memcmp( p_peek, "TFrc", 4 ) == 0 )
-    {
-#if 0
-        /* I used the TF5000PVR 2004 Firmware .doc header documentation,
-         * http://www.i-topfield.com/data/product/firmware/Structure%20of%20Recorded%20File%20in%20TF5000PVR%20(Feb%2021%202004).doc
-         * but after the filename the offsets seem to be incorrect.  - DJ */
-        int i_duration, i_name;
-        char *psz_name = xmalloc(25);
-        char *psz_event_name;
-        char *psz_event_text = xmalloc(130);
-        char *psz_ext_text = xmalloc(1025);
-
-        // 2 bytes version Uimsbf (4,5)
-        // 2 bytes reserved (6,7)
-        // 2 bytes duration in minutes Uimsbf (8,9(
-        i_duration = (int) (p_peek[8] << 8) | p_peek[9];
-        msg_Dbg( p_demux, "Topfield recording length: +/- %d minutes", i_duration);
-        // 2 bytes service number in channel list (10, 11)
-        // 2 bytes service type Bslbf 0=TV 1=Radio Bslb (12, 13)
-        // 4 bytes of reserved + tuner info (14,15,16,17)
-        // 2 bytes of Service ID  Bslbf (18,19)
-        // 2 bytes of PMT PID  Uimsbf (20,21)
-        // 2 bytes of PCR PID  Uimsbf (22,23)
-        // 2 bytes of Video PID  Uimsbf (24,25)
-        // 2 bytes of Audio PID  Uimsbf (26,27)
-        // 24 bytes filename Bslbf
-        memcpy( psz_name, &p_peek[28], 24 );
-        psz_name[24] = '\0';
-        msg_Dbg( p_demux, "recordingname=%s", psz_name );
-        // 1 byte of sat index Uimsbf  (52)
-        // 3 bytes (1 bit of polarity Bslbf +23 bits reserved)
-        // 4 bytes of freq. Uimsbf (56,57,58,59)
-        // 2 bytes of symbol rate Uimsbf (60,61)
-        // 2 bytes of TS stream ID Uimsbf (62,63)
-        // 4 bytes reserved
-        // 2 bytes reserved
-        // 2 bytes duration Uimsbf (70,71)
-        //i_duration = (int) (p_peek[70] << 8) | p_peek[71];
-        //msg_Dbg( p_demux, "Topfield 2nd duration field: +/- %d minutes", i_duration);
-        // 4 bytes EventID Uimsbf (72-75)
-        // 8 bytes of Start and End time info (76-83)
-        // 1 byte reserved (84)
-        // 1 byte event name length Uimsbf (89)
-        i_name = (int)(p_peek[89]&~0x81);
-        msg_Dbg( p_demux, "event name length = %d", i_name);
-        psz_event_name = xmalloc( i_name+1 );
-        // 1 byte parental rating (90)
-        // 129 bytes of event text
-        memcpy( psz_event_name, &p_peek[91], i_name );
-        psz_event_name[i_name] = '\0';
-        memcpy( psz_event_text, &p_peek[91+i_name], 129-i_name );
-        psz_event_text[129-i_name] = '\0';
-        msg_Dbg( p_demux, "event name=%s", psz_event_name );
-        msg_Dbg( p_demux, "event text=%s", psz_event_text );
-        // 12 bytes reserved (220)
-        // 6 bytes reserved
-        // 2 bytes Event Text Length Uimsbf
-        // 4 bytes EventID Uimsbf
-        // FIXME We just have 613 bytes. not enough for this entire text
-        // 1024 bytes Extended Event Text Bslbf
-        memcpy( psz_ext_text, p_peek+372, 1024 );
-        psz_ext_text[1024] = '\0';
-        msg_Dbg( p_demux, "extended event text=%s", psz_ext_text );
-        // 52 bytes reserved Bslbf
-#endif
-        msg_Dbg( p_demux, "this is a topfield file" );
-        return TS_PACKET_SIZE_188;
-    }
-
     for( int i_sync = 0; i_sync < TS_PACKET_SIZE_MAX; i_sync++ )
     {
-        if( p_peek[i_sync] != 0x47 )
+        if( p_peek[i_offset + i_sync] != 0x47 )
             continue;
 
         /* Check next 3 sync bytes */
-        int i_peek = TS_PACKET_SIZE_MAX * 3 + i_sync + 1;
+        int i_peek = i_offset + TS_PACKET_SIZE_MAX * 3 + i_sync + 1;
         if( ( stream_Peek( p_demux->s, &p_peek, i_peek ) ) < i_peek )
         {
             msg_Err( p_demux, "cannot peek" );
             return -1;
         }
-        if( p_peek[i_sync + 1 * TS_PACKET_SIZE_188] == 0x47 &&
-            p_peek[i_sync + 2 * TS_PACKET_SIZE_188] == 0x47 &&
-            p_peek[i_sync + 3 * TS_PACKET_SIZE_188] == 0x47 )
+        if( p_peek[i_offset + i_sync + 1 * TS_PACKET_SIZE_188] == 0x47 &&
+            p_peek[i_offset + i_sync + 2 * TS_PACKET_SIZE_188] == 0x47 &&
+            p_peek[i_offset + i_sync + 3 * TS_PACKET_SIZE_188] == 0x47 )
         {
             return TS_PACKET_SIZE_188;
         }
-        else if( p_peek[i_sync + 1 * TS_PACKET_SIZE_192] == 0x47 &&
-                 p_peek[i_sync + 2 * TS_PACKET_SIZE_192] == 0x47 &&
-                 p_peek[i_sync + 3 * TS_PACKET_SIZE_192] == 0x47 )
+        else if( p_peek[i_offset + i_sync + 1 * TS_PACKET_SIZE_192] == 0x47 &&
+                 p_peek[i_offset + i_sync + 2 * TS_PACKET_SIZE_192] == 0x47 &&
+                 p_peek[i_offset + i_sync + 3 * TS_PACKET_SIZE_192] == 0x47 )
         {
             if( i_sync == 4 )
             {
@@ -526,9 +494,9 @@ static int DetectPacketSize( demux_t *p_demux, int *pi_header_size )
             }
             return TS_PACKET_SIZE_192;
         }
-        else if( p_peek[i_sync + 1 * TS_PACKET_SIZE_204] == 0x47 &&
-                 p_peek[i_sync + 2 * TS_PACKET_SIZE_204] == 0x47 &&
-                 p_peek[i_sync + 3 * TS_PACKET_SIZE_204] == 0x47 )
+        else if( p_peek[i_offset + i_sync + 1 * TS_PACKET_SIZE_204] == 0x47 &&
+                 p_peek[i_offset + i_sync + 2 * TS_PACKET_SIZE_204] == 0x47 &&
+                 p_peek[i_offset + i_sync + 3 * TS_PACKET_SIZE_204] == 0x47 )
         {
             return TS_PACKET_SIZE_204;
         }
@@ -543,6 +511,100 @@ static int DetectPacketSize( demux_t *p_demux, int *pi_header_size )
     return -1;
 }
 
+#define TOPFIELD_HEADER_SIZE 3712
+
+static int DetectPVRHeadersAndHeaderSize( demux_t *p_demux, int *pi_header_size, vdr_info_t *p_vdr )
+{
+    const uint8_t *p_peek;
+    *pi_header_size = 0;
+    int i_packet_size = -1;
+
+    if( stream_Peek( p_demux->s,
+                     &p_peek, TS_PACKET_SIZE_MAX ) < TS_PACKET_SIZE_MAX )
+        return -1;
+
+    if( memcmp( p_peek, "TFrc", 4 ) == 0 &&
+        p_peek[6] == 0 && memcmp( &p_peek[53], "\x80\x00\x00", 4 ) == 0 &&
+        stream_Peek( p_demux->s, &p_peek, TOPFIELD_HEADER_SIZE + TS_PACKET_SIZE_MAX )
+            == TOPFIELD_HEADER_SIZE + TS_PACKET_SIZE_MAX )
+    {
+        i_packet_size = DetectPacketSize( p_demux, pi_header_size, TOPFIELD_HEADER_SIZE );
+        if( i_packet_size != -1 )
+        {
+            msg_Dbg( p_demux, "this is a topfield file" );
+#if 0
+            /* I used the TF5000PVR 2004 Firmware .doc header documentation,
+             * http://www.i-topfield.com/data/product/firmware/Structure%20of%20Recorded%20File%20in%20TF5000PVR%20(Feb%2021%202004).doc
+             * but after the filename the offsets seem to be incorrect.  - DJ */
+            int i_duration, i_name;
+            char *psz_name = xmalloc(25);
+            char *psz_event_name;
+            char *psz_event_text = xmalloc(130);
+            char *psz_ext_text = xmalloc(1025);
+
+            // 2 bytes version Uimsbf (4,5)
+            // 2 bytes reserved (6,7)
+            // 2 bytes duration in minutes Uimsbf (8,9(
+            i_duration = (int) (p_peek[8] << 8) | p_peek[9];
+            msg_Dbg( p_demux, "Topfield recording length: +/- %d minutes", i_duration);
+            // 2 bytes service number in channel list (10, 11)
+            // 2 bytes service type Bslbf 0=TV 1=Radio Bslb (12, 13)
+            // 4 bytes of reserved + tuner info (14,15,16,17)
+            // 2 bytes of Service ID  Bslbf (18,19)
+            // 2 bytes of PMT PID  Uimsbf (20,21)
+            // 2 bytes of PCR PID  Uimsbf (22,23)
+            // 2 bytes of Video PID  Uimsbf (24,25)
+            // 2 bytes of Audio PID  Uimsbf (26,27)
+            // 24 bytes filename Bslbf
+            memcpy( psz_name, &p_peek[28], 24 );
+            psz_name[24] = '\0';
+            msg_Dbg( p_demux, "recordingname=%s", psz_name );
+            // 1 byte of sat index Uimsbf  (52)
+            // 3 bytes (1 bit of polarity Bslbf +23 bits reserved)
+            // 4 bytes of freq. Uimsbf (56,57,58,59)
+            // 2 bytes of symbol rate Uimsbf (60,61)
+            // 2 bytes of TS stream ID Uimsbf (62,63)
+            // 4 bytes reserved
+            // 2 bytes reserved
+            // 2 bytes duration Uimsbf (70,71)
+            //i_duration = (int) (p_peek[70] << 8) | p_peek[71];
+            //msg_Dbg( p_demux, "Topfield 2nd duration field: +/- %d minutes", i_duration);
+            // 4 bytes EventID Uimsbf (72-75)
+            // 8 bytes of Start and End time info (76-83)
+            // 1 byte reserved (84)
+            // 1 byte event name length Uimsbf (89)
+            i_name = (int)(p_peek[89]&~0x81);
+            msg_Dbg( p_demux, "event name length = %d", i_name);
+            psz_event_name = xmalloc( i_name+1 );
+            // 1 byte parental rating (90)
+            // 129 bytes of event text
+            memcpy( psz_event_name, &p_peek[91], i_name );
+            psz_event_name[i_name] = '\0';
+            memcpy( psz_event_text, &p_peek[91+i_name], 129-i_name );
+            psz_event_text[129-i_name] = '\0';
+            msg_Dbg( p_demux, "event name=%s", psz_event_name );
+            msg_Dbg( p_demux, "event text=%s", psz_event_text );
+            // 12 bytes reserved (220)
+            // 6 bytes reserved
+            // 2 bytes Event Text Length Uimsbf
+            // 4 bytes EventID Uimsbf
+            // FIXME We just have 613 bytes. not enough for this entire text
+            // 1024 bytes Extended Event Text Bslbf
+            memcpy( psz_ext_text, p_peek+372, 1024 );
+            psz_ext_text[1024] = '\0';
+            msg_Dbg( p_demux, "extended event text=%s", psz_ext_text );
+            // 52 bytes reserved Bslbf
+#endif
+            p_vdr->i_service = GetWBE(&p_peek[18]);
+
+            return i_packet_size;
+            //return TS_PACKET_SIZE_188;
+        }
+    }
+
+    return DetectPacketSize( p_demux, pi_header_size, 0 );
+}
+
 #if (DVBPSI_VERSION_INT >= DVBPSI_VERSION_WANTED(1,0,0))
 static void vlc_dvbpsi_reset( demux_t *p_demux )
 {
@@ -587,6 +649,288 @@ static void vlc_dvbpsi_reset( demux_t *p_demux )
 }
 #endif
 
+static inline mtime_t ExtractPESTimestamp( const uint8_t *p_data )
+{
+    return ((mtime_t)(p_data[ 0]&0x0e ) << 29)|
+             (mtime_t)(p_data[1] << 22)|
+            ((mtime_t)(p_data[2]&0xfe) << 14)|
+             (mtime_t)(p_data[3] << 7)|
+             (mtime_t)(p_data[4] >> 1);
+}
+
+static void ProbePES( demux_t *p_demux, ts_pid_t *pid, const uint8_t *p_pesstart, bool b_adaptfield )
+{
+    demux_sys_t *p_sys = p_demux->p_sys;
+    const uint8_t *p_pes = p_pesstart;
+    pid->probed.i_type = -1;
+
+    if( b_adaptfield )
+    {
+        uint8_t len = *p_pes;
+        p_pes++;
+
+        if(len == 0)
+        {
+            p_pes++; /* stuffing */
+        }
+        else
+        {
+            pid->probed.b_haspcr = ( *p_pes >= 7 && (p_pes[1] & 0x10) );
+            p_pes += len;
+        }
+    }
+
+    if( p_pes - p_pesstart >= TS_PACKET_SIZE_188 - 9)
+        return;
+
+    if( p_pes[0] != 0 || p_pes[1] != 0 || p_pes[2] != 1 )
+        return;
+
+    size_t i_pesextoffset = 8;
+    mtime_t i_dts = -1;
+    if( p_pes[7] & 0x80 ) // PTS
+    {
+        i_pesextoffset += 5;
+        i_dts = ExtractPESTimestamp( &p_pes[9] );
+    }
+    if( p_pes[7] & 0x40 ) // DTS
+    {
+        i_pesextoffset += 5;
+        i_dts = ExtractPESTimestamp( &p_pes[14] );
+    }
+    if( p_pes[7] & 0x20 ) // ESCR
+        i_pesextoffset += 6;
+    if( p_pes[7] & 0x10 ) // ESrate
+        i_pesextoffset += 3;
+    if( p_pes[7] & 0x08 ) // DSM
+        i_pesextoffset += 1;
+    if( p_pes[7] & 0x04 ) // CopyInfo
+        i_pesextoffset += 1;
+    if( p_pes[7] & 0x02 ) // PESCRC
+        i_pesextoffset += 2;
+
+     /* HeaderdataLength */
+    const size_t i_payloadoffset = 8 + 1 + p_pes[8];
+    i_pesextoffset += 1;
+
+    if( p_pes[7] & 0x01 ) // PESExt
+    {
+        size_t i_extension2_offset = 1;
+        if ( p_pes[i_pesextoffset] & 0x80 ) // private data
+            i_extension2_offset += 16;
+        if ( p_pes[i_pesextoffset] & 0x40 ) // pack
+            i_extension2_offset += 1;
+        if ( p_pes[i_pesextoffset] & 0x20 ) // seq
+            i_extension2_offset += 2;
+        if ( p_pes[i_pesextoffset] & 0x10 ) // P-STD
+            i_extension2_offset += 2;
+        if ( p_pes[i_pesextoffset] & 0x01 ) // Extension 2
+        {
+            uint8_t i_len = p_pes[i_pesextoffset + i_extension2_offset] & 0x7F;
+            i_extension2_offset += i_len;
+        }
+    }
+    /* (i_payloadoffset - i_pesextoffset) 0xFF stuffing */
+
+    if( &p_pes[i_payloadoffset] - p_pesstart >= TS_PACKET_SIZE_188 - 4)
+        return;
+
+    const uint8_t *p_data = &p_pes[i_payloadoffset];
+    /* AUDIO STREAM */
+    if(p_pes[3] >= 0xC0 && p_pes[3] <= 0xDF)
+    {
+        if( !memcmp( p_data, "\x7F\xFE\x80\x01", 4 ) )
+        {
+            pid->probed.i_type = 0x06;
+            pid->probed.i_fourcc = VLC_CODEC_DTS;
+        }
+        else if( !memcmp( p_data, "\x0B\x77", 2 ) )
+        {
+            pid->probed.i_type = 0x06;
+            pid->probed.i_fourcc = VLC_CODEC_EAC3;
+        }
+        else if( p_data[0] == 0xFF && (p_data[1] & 0xE0) == 0xE0 )
+        {
+            switch(p_data[1] & 18)
+            {
+            /* 10 - MPEG Version 2 (ISO/IEC 13818-3)
+               11 - MPEG Version 1 (ISO/IEC 11172-3) */
+                case 0x10:
+                    pid->probed.i_type = 0x04;
+                    break;
+                case 0x18:
+                    pid->probed.i_type = 0x03;
+                default:
+                    break;
+            }
+
+            switch(p_data[1] & 6)
+            {
+            /* 01 - Layer III
+               10 - Layer II
+               11 - Layer I */
+                case 0x06:
+                    pid->probed.i_type = 0x04;
+                    pid->probed.i_fourcc = VLC_CODEC_MPGA;
+                    break;
+                case 0x04:
+                    pid->probed.i_type = 0x04;
+                    pid->probed.i_fourcc = VLC_CODEC_MP2;
+                    break;
+                case 0x02:
+                    pid->probed.i_type = 0x04;
+                    pid->probed.i_fourcc = VLC_CODEC_MP3;
+                default:
+                    break;
+            }
+        }
+    }
+    /* VIDEO STREAM */
+    else if( p_pes[3] >= 0xE0 && p_pes[3] <= 0xEF )
+    {
+        if( !memcmp( p_data, "\x00\x00\x00", 4 ) )
+        {
+            pid->probed.i_type = 0x1b;
+            pid->probed.i_fourcc = VLC_CODEC_H264;
+        }
+        else if( !memcmp( p_data, "\x00\x00\x01", 4 ) )
+        {
+            pid->probed.i_type = 0x02;
+            pid->probed.i_fourcc = VLC_CODEC_MPGV;
+        }
+    }
+
+    /* Track timestamps and flag missing PAT */
+    if( !p_sys->patfix.i_timesourcepid && i_dts > -1 )
+    {
+        p_sys->patfix.i_first_dts = i_dts;
+        p_sys->patfix.i_timesourcepid = pid->i_pid;
+    }
+    else if( p_sys->patfix.i_timesourcepid == pid->i_pid && i_dts > -1 &&
+             !p_sys->patfix.b_pat_deadline )
+    {
+        if( i_dts - p_sys->patfix.i_first_dts > 9 * 140000 / 100 )
+            p_sys->patfix.b_pat_deadline = true;
+    }
+
+}
+
+static void BuildPATCallback( void *p_opaque, block_t *p_block )
+{
+    ts_pid_t *pat_pid = (ts_pid_t *) p_opaque;
+    dvbpsi_PushPacket( pat_pid->psi->handle, p_block->p_buffer );
+}
+
+static void BuildPMTCallback( void *p_opaque, block_t *p_block )
+{
+    ts_pid_t *program_pid = (ts_pid_t *) p_opaque;
+    while( p_block )
+    {
+        for( int i_prg = 0; i_prg < program_pid->psi->i_prg; i_prg++ )
+        {
+            dvbpsi_PushPacket( program_pid->psi->prg[i_prg]->handle,
+                               p_block->p_buffer );
+        }
+        p_block = p_block->p_next;
+    }
+}
+
+static void MissingPATPMTFixup( demux_t *p_demux )
+{
+    demux_sys_t *p_sys = p_demux->p_sys;
+    int i_program_number = 1234;
+    int i_program_pid = 1337;
+    int i_pcr_pid = 0x1FFF;
+    int i_num_pes = 0;
+
+    if( p_sys->pid[i_program_pid].b_seen )
+    {
+        /* Find a free one */
+        for( i_program_pid = MIN_ES_PID;
+             i_program_pid < MAX_ES_PID && p_sys->pid[i_program_pid].b_seen;
+             i_program_pid++ );
+    }
+
+    for( int i = MIN_ES_PID; i < MAX_ES_PID; i++ )
+    {
+        if( !p_sys->pid[i].b_seen ||
+            p_sys->pid[i].probed.i_type == -1 )
+            continue;
+
+        if( i_pcr_pid == 0x1FFF && ( p_sys->pid[i].probed.i_type == 0x03 ||
+                                     p_sys->pid[i].probed.b_haspcr ) )
+            i_pcr_pid = p_sys->pid[i].i_pid;
+
+        i_num_pes++;
+    }
+
+    if( i_num_pes == 0 )
+        return;
+
+    ts_stream_t patstream =
+    {
+        .i_pid = 0,
+        .i_continuity_counter = 0x10,
+        .b_discontinuity = false
+    };
+
+    ts_stream_t pmtprogramstream =
+    {
+        .i_pid = i_program_pid,
+        .i_continuity_counter = 0x0,
+        .b_discontinuity = false
+    };
+
+    BuildPAT( DVBPSI_HANDLE_PARAM(p_sys->pid[0].psi->handle)
+            &p_sys->pid[0], BuildPATCallback,
+            0, 1,
+            &patstream,
+            1, &pmtprogramstream, &i_program_number );
+
+    if( !p_sys->pid[i_program_pid].psi )
+    {
+        msg_Err( p_demux, "PAT creation failed" );
+        return;
+    }
+
+    struct esstreams_t
+    {
+        pes_stream_t pes;
+        ts_stream_t ts;
+    };
+    es_format_t esfmt = {0};
+    struct esstreams_t *esstreams = calloc( i_num_pes, sizeof(struct esstreams_t) );
+    pes_mapped_stream_t *mapped = calloc( i_num_pes, sizeof(pes_mapped_stream_t) );
+    if( esstreams && mapped )
+    {
+        int j=0;
+        for( int i = MIN_ES_PID; i < MAX_ES_PID; i++ )
+        {
+            if( !p_sys->pid[i].b_seen ||
+                p_sys->pid[i].probed.i_type == -1 )
+                continue;
+
+            esstreams[j].pes.i_stream_type = p_sys->pid[i].probed.i_type;
+            esstreams[j].pes.i_stream_type = p_sys->pid[i].probed.i_type;
+            esstreams[j].ts.i_pid = p_sys->pid[i].i_pid;
+            mapped[j].pes = &esstreams[j].pes;
+            mapped[j].ts = &esstreams[j].ts;
+            mapped[j].fmt = &esfmt;
+            j++;
+        }
+
+        BuildPMT( DVBPSI_HANDLE_PARAM(p_sys->pid[0].psi->handle) VLC_OBJECT(p_demux),
+                &p_sys->pid[i_program_pid], BuildPMTCallback,
+                0, 1,
+                i_pcr_pid,
+                NULL,
+                1, &pmtprogramstream, &i_program_number,
+                i_num_pes, mapped );
+    }
+    free(esstreams);
+    free(mapped);
+}
+
 /*****************************************************************************
  * Open
  *****************************************************************************/
@@ -598,9 +942,10 @@ static int Open( vlc_object_t *p_this )
     int          i_packet_size, i_packet_header_size = 0;
 
     ts_pid_t    *pat;
+    vdr_info_t   vdr = {0};
 
     /* Search first sync byte */
-    i_packet_size = DetectPacketSize( p_demux, &i_packet_header_size );
+    i_packet_size = DetectPVRHeadersAndHeaderSize( p_demux, &i_packet_header_size, &vdr );
     if( i_packet_size < 0 )
         return VLC_EGENERIC;
 
@@ -623,6 +968,8 @@ static int Open( vlc_object_t *p_this )
     p_sys->i_dvb_start = 0;
     p_sys->i_dvb_length = 0;
 
+    p_sys->vdr = vdr;
+
     p_sys->arib.b25stream = NULL;
     p_sys->stream = p_demux->s;
 
@@ -634,6 +981,8 @@ static int Open( vlc_object_t *p_this )
         pid->i_pid      = i;
         pid->b_seen     = false;
         pid->b_valid    = false;
+        pid->probed.i_fourcc = 0;
+        pid->probed.i_type = 0;
     }
     /* PID 8191 is padding */
     p_sys->pid[8191].b_seen = true;
@@ -733,6 +1082,7 @@ static int Open( vlc_object_t *p_this )
     /* Init PMT array */
     TAB_INIT( p_sys->i_pmt, p_sys->pmt );
     p_sys->i_pmt_es = 0;
+    p_sys->b_delay_es_creation = true;
 
     /* Read config */
     p_sys->b_es_id_pid = var_CreateGetBool( p_demux, "ts-es-id-pid" );
@@ -832,11 +1182,17 @@ static int Open( vlc_object_t *p_this )
         }
     }
 
-    while( p_sys->i_pmt_es <= 0 && vlc_object_alive( p_demux ) )
+    while( p_sys->i_pmt_es <= 0
+           && (!p_sys->pid[0].b_seen && !p_sys->patfix.b_pat_deadline) )
     {
         if( Demux( p_demux ) != 1 )
             break;
     }
+
+    /* If we had no PAT within 140ms, create PAT/PMT from probed streams */
+    if( p_sys->i_pmt_es == 0 && !p_sys->pid[0].b_seen )
+        MissingPATPMTFixup( p_demux );
+
     return VLC_SUCCESS;
 }
 
@@ -985,6 +1341,15 @@ static int Demux( demux_t *p_demux )
         /* Parse the TS packet */
         ts_pid_t *p_pid = &p_sys->pid[PIDGet( p_pkt )];
 
+        /* Probe streams to build PAT/PMT after 140ms in case we don't see any PAT */
+        if( !p_sys->pid[0].b_seen &&
+            (p_pid->probed.i_type == 0 || p_pid->i_pid == p_sys->patfix.i_timesourcepid) &&
+            (p_pkt->p_buffer[1] & 0xC0) == 0x40 && /* Payload start but not corrupt */
+            (p_pkt->p_buffer[3] & 0xD0) == 0x10 )  /* Has payload but is not encrypted */
+        {
+            ProbePES( p_demux, p_pid, p_pkt->p_buffer + 4, p_pkt->p_buffer[3] & 0x20 /* Adaptation field */);
+        }
+
         if( p_pid->b_valid )
         {
             if( p_pid->psi )
@@ -1005,6 +1370,8 @@ static int Demux( demux_t *p_demux )
             }
             else
             {
+                if(p_sys->b_delay_es_creation) /* No longer delay ES since that pid's program sends data */
+                    AddAndCreateES( p_demux, NULL );
                 b_frame = GatherData( p_demux, p_pid, p_pkt );
             }
         }
@@ -1402,6 +1769,8 @@ static void SetPrgFilter( demux_t *p_demux, int i_prg_id, bool b_selected )
     ts_prg_psi_t *p_prg = NULL;
     int i_pmt_pid = -1;
 
+    p_sys->b_disable_pcr = !p_sys->b_trust_pcr;
+
     /* Search pmt to be unselected */
     for( int i = 0; i < p_sys->i_pmt; i++ )
     {
@@ -1724,19 +2093,13 @@ static void ParsePES( demux_t *p_demux, ts_pid_t *pid, block_t *p_pes )
 
             if( header[7]&0x80 )    /* has pts */
             {
-                i_pts = ((mtime_t)(header[ 9]&0x0e ) << 29)|
-                         (mtime_t)(header[10] << 22)|
-                        ((mtime_t)(header[11]&0xfe) << 14)|
-                         (mtime_t)(header[12] << 7)|
-                         (mtime_t)(header[13] >> 1);
+                i_pts = ExtractPESTimestamp( &header[9] );
+                i_pts = AdjustPTSWrapAround( p_demux, i_pts );
 
                 if( header[7]&0x40 )    /* has dts */
                 {
-                     i_dts = ((mtime_t)(header[14]&0x0e ) << 29)|
-                             (mtime_t)(header[15] << 22)|
-                            ((mtime_t)(header[16]&0xfe) << 14)|
-                             (mtime_t)(header[17] << 7)|
-                             (mtime_t)(header[18] >> 1);
+                    i_dts = ExtractPESTimestamp( &header[14] );
+                    i_dts = AdjustPTSWrapAround( p_demux, i_dts );
                 }
             }
         }
@@ -1760,20 +2123,12 @@ static void ParsePES( demux_t *p_demux, ts_pid_t *pid, block_t *p_pes )
 
             if(  header[i_skip]&0x20 )
             {
-                 i_pts = ((mtime_t)(header[i_skip]&0x0e ) << 29)|
-                          (mtime_t)(header[i_skip+1] << 22)|
-                         ((mtime_t)(header[i_skip+2]&0xfe) << 14)|
-                          (mtime_t)(header[i_skip+3] << 7)|
-                          (mtime_t)(header[i_skip+4] >> 1);
+                i_pts = ExtractPESTimestamp( &header[i_skip] );
 
                 if( header[i_skip]&0x10 )    /* has dts */
                 {
-                     i_dts = ((mtime_t)(header[i_skip+5]&0x0e ) << 29)|
-                              (mtime_t)(header[i_skip+6] << 22)|
-                             ((mtime_t)(header[i_skip+7]&0xfe) << 14)|
-                              (mtime_t)(header[i_skip+8] << 7)|
-                              (mtime_t)(header[i_skip+9] >> 1);
-                     i_skip += 10;
+                    i_dts = ExtractPESTimestamp( &header[i_skip+5] );
+                    i_skip += 10;
                 }
                 else
                 {
@@ -1916,10 +2271,17 @@ static void ParsePES( demux_t *p_demux, ts_pid_t *pid, block_t *p_pes )
                         block_Duplicate( p_block ) );
             }
 
-            if (!p_sys->b_trust_pcr && p_block->i_dts > VLC_TS_INVALID )
+            PCRFixHandle( p_demux, p_block );
+
+            if ( p_sys->b_disable_pcr && p_block->i_dts > VLC_TS_INVALID )
                 es_out_Control( p_demux->out, ES_OUT_SET_GROUP_PCR,
                         pid->i_owner_number, p_block->i_dts);
 
+            if( !p_sys->b_disable_pcr && p_block->i_dts > VLC_TS_INVALID &&
+                 p_block->i_dts < (VLC_TS_0 + p_sys->i_current_pcr * 100 / 9) )
+                msg_Warn( p_demux, "Broken stream: pid %d sends packets with dts %"PRId64"us later than pcr",
+                          pid->i_pid, (p_sys->i_current_pcr * 100 / 9) - p_block->i_dts + VLC_TS_0  );
+
             es_out_Send( p_demux->out, pid->es->id, p_block );
 
             p_block = p_next;
@@ -1978,6 +2340,8 @@ static void ParseTableSection( demux_t *p_demux, ts_pid_t *pid, block_t *p_data
         p_content->i_pts = VLC_TS_0 + i_date * 100 / 9;
     }
     es_out_Send( p_demux->out, pid->es->id, p_content );
+
+    PCRFixHandle( p_demux, p_content );
 }
 static void ParseData( demux_t *p_demux, ts_pid_t *pid )
 {
@@ -2028,7 +2392,7 @@ static block_t* ReadTSPacket( demux_t *p_demux )
     {
         msg_Warn( p_demux, "lost synchro" );
         block_Release( p_pkt );
-        while( vlc_object_alive (p_demux) )
+        for( ;; )
         {
             const uint8_t *p_peek;
             int i_peek, i_skip = 0;
@@ -2088,6 +2452,32 @@ static mtime_t AdjustPCRWrapAround( demux_t *p_demux, mtime_t i_pcr )
     return i_pcr + i_adjust;
 }
 
+static mtime_t AdjustPTSWrapAround( demux_t *p_demux, mtime_t i_pts )
+{
+    demux_sys_t *p_sys = p_demux->p_sys;
+    mtime_t i_pcr = p_sys->i_current_pcr;
+
+    mtime_t i_adjustremain = i_pcr % 0x1FFFFFFFF;
+    mtime_t i_adjustbase = i_pcr - i_adjustremain;
+
+    mtime_t i_pts_adjust = i_adjustbase;
+
+    /* PTS has rolled first */
+    if( i_adjustremain >= 0xFFFFFFFF && i_pts < 0xFFFFFFFF )
+    {
+        i_pts_adjust += 0x1FFFFFFFF;
+    }
+    /* PCR has rolled first (PTS is late!) */
+    else if( i_adjustremain < 0xFFFFFFFF && i_pts >= 0xFFFFFFFF )
+    {
+        if( i_adjustbase >= 0x1FFFFFFFF ) /* we need to remove current roll */
+            i_pts_adjust -= 0x1FFFFFFFF;
+    }
+
+    i_pts += i_pts_adjust;
+    return i_pts;
+}
+
 static mtime_t GetPCR( block_t *p_pkt )
 {
     const uint8_t *p = p_pkt->p_buffer;
@@ -2125,7 +2515,7 @@ static int SeekToPCR( demux_t *p_demux, int64_t i_pos )
     if( stream_Seek( p_sys->stream, i_pos ) )
         return VLC_EGENERIC;
 
-    while( vlc_object_alive( p_demux ) )
+    for( ;; )
     {
         block_t *p_pkt;
 
@@ -2221,6 +2611,7 @@ static int Seek( demux_t *p_demux, double f_percent )
     else
     {
         msg_Dbg( p_demux, "Seek():can find a time position. i_cnt:%d", i_cnt );
+        p_demux->p_sys->pcrfix.i_first_dts = 0;
         return VLC_SUCCESS;
     }
 }
@@ -2234,7 +2625,7 @@ static void GetFirstPCR( demux_t *p_demux )
     if( stream_Seek( p_sys->stream, 0 ) )
         return;
 
-    while( vlc_object_alive (p_demux) )
+    for( ;; )
     {
         block_t     *p_pkt;
 
@@ -2275,7 +2666,7 @@ static void GetLastPCR( demux_t *p_demux )
     if( i_pos < 0 && i_pos >= i_stream_size )
         return;
 
-    while( vlc_object_alive( p_demux ) )
+    for( ;; )
     {
         if( SeekToPCR( p_demux, i_pos ) )
             break;
@@ -2283,20 +2674,7 @@ static void GetLastPCR( demux_t *p_demux )
         if( ( i_pos = stream_Tell( p_sys->stream ) ) >= i_last_pos )
             break;
     }
-    if( p_sys->i_last_pcr >= 0 )
-    {
-        int64_t i_size = stream_Size( p_sys->stream );
-        mtime_t i_duration_msec = ( p_sys->i_last_pcr - p_sys->i_first_pcr ) * 100 / 9 / 1000;
-        int64_t i_rate = ( i_size < 0 || i_duration_msec <= 0 ) ? 0 : i_size * 1000 * 8 / i_duration_msec;
-        const int64_t TS_SUPPOSED_MAXRATE = 55 * 1000 * 1000; //FIXME I think it's enough.
-        const int64_t TS_SUPPOSED_MINRATE = 0.5 * 1000 * 1000; //FIXME
-        if( i_rate < TS_SUPPOSED_MINRATE || i_rate > TS_SUPPOSED_MAXRATE )
-        {
-            msg_Dbg( p_demux, "calculated bitrate (%"PRId64"bit/s) is too low or too high. min bitrate (%"PRId64"bit/s) max bitrate (%"PRId64"bit/s)",
-                     i_rate, TS_SUPPOSED_MINRATE, TS_SUPPOSED_MAXRATE );
-            p_sys->i_last_pcr = -1;
-        }
-    }
+
     stream_Seek( p_sys->stream, i_initial_pos );
     assert( i_initial_pos == stream_Tell( p_sys->stream ) );
     p_sys->i_current_pcr = i_initial_pcr;
@@ -2315,7 +2693,7 @@ static void CheckPCR( demux_t *p_demux )
     p_sys->p_pcrs[0] = p_sys->i_first_pcr;
     p_sys->p_pos[0] = i_initial_pos;
 
-    for( i = 1; i < p_sys->i_pcrs_num && vlc_object_alive( p_demux ); ++i )
+    for( i = 1; i < p_sys->i_pcrs_num; ++i )
     {
         /* Round i_pos to a multiple of p_sys->i_packet_size */
         int64_t i_pos = i_size / p_sys->i_pcrs_num * i;
@@ -2352,37 +2730,72 @@ static void PCRHandle( demux_t *p_demux, ts_pid_t *pid, block_t *p_bk )
     if( i_pcr < 0 )
         return;
 
+    i_pcr = AdjustPCRWrapAround( p_demux, i_pcr );
+
     if( p_sys->i_pid_ref_pcr == pid->i_pid )
-        p_sys->i_current_pcr = AdjustPCRWrapAround( p_demux, i_pcr );
+        p_sys->i_current_pcr = i_pcr;
 
     /* Search program and set the PCR */
-    int i_group = -1;
-    for( int i = 0; i < p_sys->i_pmt && i_group < 0 ; i++ )
+    for( int i = 0; i < p_sys->i_pmt; i++ )
     {
-        bool b_pmt_has_es = false;
-
+        int i_group = -1;
         for( int i_prg = 0; i_prg < p_sys->pmt[i]->psi->i_prg; i_prg++ )
         {
-            if( pid->i_pid == p_sys->pmt[i]->psi->prg[i_prg]->i_pid_pcr )
+            ts_prg_psi_t *p_prg = p_sys->pmt[i]->psi->prg[i_prg];
+
+            if( p_prg->i_pid_pcr == 0x1FFF ) /* That program has no dedicated PCR pid ISO/IEC 13818-1 2.4.4.9 */
             {
-                /* We've found our target group */
-                p_sys->pmt[i]->psi->prg[i_prg]->i_pcr_value = i_pcr;
-                i_group = p_sys->pmt[i]->psi->prg[i_prg]->i_number;
-                for( int j = 0; j < 8192; j++ )
+                if( pid->p_owner ) /* PCR shall be on pid itself */
                 {
-                    const ts_pid_t *pid = &p_sys->pid[j];
-                    if( pid->b_valid && pid->p_owner == p_sys->pmt[i]->psi && pid->es )
-                    {
-                        b_pmt_has_es = true;
-                        break;
-                    }
+                    p_prg->i_pcr_value = i_pcr; /* ? update PCR for the whole group program */
+                    i_group = p_prg->i_number;
+                    p_sys->pcrfix.b_program_pcr_seen = true;
+                    p_sys->pcrfix.i_first_dts = 0;
+                    p_sys->b_disable_pcr = !p_sys->b_trust_pcr;
+                }
+                else
+                {
+                    msg_Warn(p_demux, "discarding PCR update from pid %d which has no owner", pid->i_pid);
+                }
+                break;
+            }
+            else /* set PCR provided by current pid to program(s) referencing it */
+            {
+                /* Can be dedicated PCR pid (no owned then) or another pid (owner == pmt) */
+                if( p_prg->i_pid_pcr == pid->i_pid ) /* If that program references current pid as PCR */
+                {
+                    p_prg->i_pcr_value = i_pcr;
+                    i_group = p_prg->i_number; /* We've found a target group for update */
+                    p_sys->pcrfix.b_program_pcr_seen = true;
+                    p_sys->pcrfix.i_first_dts = 0;
+                    p_sys->b_disable_pcr = !p_sys->b_trust_pcr;
                 }
             }
         }
-
-        if ( p_sys->b_trust_pcr && i_group > 0 && b_pmt_has_es )
+        if ( !p_sys->b_disable_pcr && i_group > 0 && p_sys->i_pmt_es )
+        {
             es_out_Control( p_demux->out, ES_OUT_SET_GROUP_PCR,
               i_group, VLC_TS_0 + i_pcr * 100 / 9 );
+        }
+    }
+}
+
+static void PCRFixHandle( demux_t *p_demux, block_t *p_block )
+{
+    demux_sys_t *p_sys = p_demux->p_sys;
+    /* Record the first data packet timestamp in case there wont be any PCR */
+    if( !p_sys->pcrfix.b_program_pcr_seen && !p_sys->b_disable_pcr )
+    {
+        if( !p_sys->pcrfix.i_first_dts )
+        {
+            p_sys->pcrfix.i_first_dts = p_block->i_dts;
+        }
+        else if( p_block->i_dts - p_sys->pcrfix.i_first_dts > CLOCK_FREQ / 10 ) /* "shall not exceed 100ms" */
+        {
+            p_sys->b_disable_pcr = true;
+            msg_Warn( p_demux, "No PCR received for program %d, set up workaround",
+                      p_sys->i_current_program );
+        }
     }
 }
 
@@ -3003,9 +3416,9 @@ static void SDTCallBack( demux_t *p_demux, dvbpsi_sdt_t *p_sdt )
 
     msg_Dbg( p_demux, "SDTCallBack called" );
 
-    if( sdt->psi->i_sdt_version != -1 &&
-        ( !p_sdt->b_current_next ||
-          p_sdt->i_version == sdt->psi->i_sdt_version ) )
+    if( p_sys->b_delay_es_creation ||
+       !p_sdt->b_current_next ||
+        p_sdt->i_version == sdt->psi->i_sdt_version )
     {
         dvbpsi_DeleteSDT( p_sdt );
         return;
@@ -3037,6 +3450,13 @@ static void SDTCallBack( demux_t *p_demux, dvbpsi_sdt_t *p_sdt )
                  p_srv->b_eit_present, p_srv->i_running_status,
                  p_srv->b_free_ca );
 
+        if( p_sys->vdr.i_service && p_srv->i_service_id != p_sys->vdr.i_service )
+        {
+            msg_Dbg( p_demux, "  * service id=%d skipped (not declared in vdr header)",
+                     p_sys->vdr.i_service );
+            continue;
+        }
+
         p_meta = vlc_meta_New();
         for( p_dr = p_srv->p_first_descriptor; p_dr; p_dr = p_dr->p_next )
         {
@@ -4269,6 +4689,10 @@ static bool PMTSetupEsHDMV( demux_t *p_demux, ts_pid_t *pid,
         p_fmt->i_cat = AUDIO_ES;
         p_fmt->i_codec = VLC_CODEC_BD_LPCM;
         break;
+    case 0x81:
+        p_fmt->i_cat = AUDIO_ES;
+        p_fmt->i_codec = VLC_CODEC_A52;
+        break;
     case 0x82:
     case 0x85: /* DTS-HD High resolution audio */
     case 0x86: /* DTS-HD Master audio */
@@ -4294,6 +4718,10 @@ static bool PMTSetupEsHDMV( demux_t *p_demux, ts_pid_t *pid,
     case 0x91: /* Interactive graphics */
     case 0x92: /* Subtitle */
         return false;
+    case 0xEA:
+        p_fmt->i_cat = VIDEO_ES;
+        p_fmt->i_codec = VLC_CODEC_VC1;
+        break;
     default:
         msg_Info( p_demux, "HDMV registration not implemented for pid 0x%x type 0x%x",
                   p_es->i_pid, p_es->i_type );
@@ -4413,6 +4841,54 @@ static void PMTParseEsIso639( demux_t *p_demux, ts_pid_t *pid,
 #endif
 }
 
+static void AddAndCreateES( demux_t *p_demux, ts_pid_t *pid )
+{
+    demux_sys_t  *p_sys = p_demux->p_sys;
+    bool b_create_delayed = false;
+
+    if( pid )
+    {
+        if( pid->b_seen && p_sys->b_delay_es_creation )
+        {
+            p_sys->b_delay_es_creation = false;
+            b_create_delayed = true;
+        }
+
+        if( !p_sys->b_delay_es_creation )
+        {
+            pid->es->id = es_out_Add( p_demux->out, &pid->es->fmt );
+            for( int i = 0; i < pid->i_extra_es; i++ )
+            {
+                pid->extra_es[i]->id =
+                    es_out_Add( p_demux->out, &pid->extra_es[i]->fmt );
+            }
+            p_sys->i_pmt_es += 1 + pid->i_extra_es;
+        }
+    }
+    else if( p_sys->b_delay_es_creation )
+    {
+        p_sys->b_delay_es_creation = false;
+        b_create_delayed = true;
+    }
+
+    if( b_create_delayed )
+    {
+        for(int i=MIN_ES_PID; i<MAX_ES_PID; i++)
+        {
+            pid = &p_sys->pid[i];
+            if(!pid->es || pid->es->id)
+                continue;
+            pid->es->id = es_out_Add( p_demux->out, &pid->es->fmt );
+            for( int j = 0; j < pid->i_extra_es; j++ )
+            {
+                pid->extra_es[j]->id =
+                    es_out_Add( p_demux->out, &pid->extra_es[j]->fmt );
+            }
+            p_sys->i_pmt_es += 1 + pid->i_extra_es;
+        }
+    }
+}
+
 static void PMTCallBack( void *data, dvbpsi_pmt_t *p_pmt )
 {
     demux_t      *p_demux = data;
@@ -4559,7 +5035,7 @@ static void PMTCallBack( void *data, dvbpsi_pmt_t *p_pmt )
     dvbpsi_pmt_es_t      *p_es;
     for( p_es = p_pmt->p_first_es; p_es != NULL; p_es = p_es->p_next )
     {
-        ts_pid_t tmp_pid, *old_pid = 0, *pid = &tmp_pid;
+        ts_pid_t tmp_pid = {0}, *old_pid = {0}, *pid = &tmp_pid;
 
         /* Find out if the PID was already declared */
         for( int i = 0; i < i_clean; i++ )
@@ -4760,13 +5236,7 @@ static void PMTCallBack( void *data, dvbpsi_pmt_t *p_pmt )
             }
             else
             {
-                pid->es->id = es_out_Add( p_demux->out, &pid->es->fmt );
-                for( int i = 0; i < pid->i_extra_es; i++ )
-                {
-                    pid->extra_es[i]->id =
-                        es_out_Add( p_demux->out, &pid->extra_es[i]->fmt );
-                }
-                p_sys->i_pmt_es += 1 + pid->i_extra_es;
+                AddAndCreateES( p_demux, pid );
             }
         }