]> git.sesse.net Git - vlc/blobdiff - modules/demux/ts.c
* treeble -> treble
[vlc] / modules / demux / ts.c
index 25b1de522ddab896b45165d3e555537504a566c0..f7e0a009f21161ecc8ccda63ef814d4fdcf7c041 100644 (file)
 static int  Open  ( vlc_object_t * );
 static void Close ( vlc_object_t * );
 
+#define PMT_TEXT N_("Extra PMT")
+#define PMT_LONGTEXT N_( \
+  "Allows a user to specify an extra pmt (pmt_pid=pid:stream_type[,...])" )
+
+#define PID_TEXT N_("Set id of ES to PID")
+#define PID_LONGTEXT N_("set id of es to pid")
+
+#define TSOUT_TEXT N_("Fast udp streaming")
+#define TSOUT_LONGTEXT N_( \
+  "Sends TS to specific ip:port by udp (you must know what you are doing)")
+
+#define MTUOUT_TEXT N_("MTU for out mode")
+#define MTUOUT_LONGTEXT N_("MTU for out mode")
+
+#define CSA_TEXT N_("CSA ck")
+#define CSA_LONGTEXT N_("CSA ck")
+
+#define SILENT_TEXT N_("Silent mode")
+#define SILENT_LONGTEXT N_("do not complain on encrypted PES")
+
 vlc_module_begin();
     set_description( _("ISO 13818-1 MPEG Transport Stream input - new" ) );
-    add_string( "ts-extra-pmt", NULL, NULL, "extra PMT", "allow user to specify an extra pmt (pmt_pid=pid:stream_type[,...])", VLC_TRUE );
-    add_bool( "ts-es-id-pid", 0, NULL, "set id of es to pid", "set id of es to pid", VLC_TRUE );
-    add_string( "ts-out", NULL, NULL, "fast udp streaming", "send TS to specific ip:port by udp (you must know what you are doing)", VLC_TRUE );
-    add_integer( "ts-out-mtu", 1500, NULL, "MTU for out mode", "MTU for out mode", VLC_TRUE );
-    add_string( "ts-csa-ck", NULL, NULL, "CSA ck", "CSA ck", VLC_TRUE );
-    add_bool( "ts-silent", 0, NULL, "Silent mode", "do not complain on encrypted PES", VLC_TRUE );
+
+    add_string( "ts-extra-pmt", NULL, NULL, PMT_TEXT, PMT_LONGTEXT, VLC_TRUE );
+    add_bool( "ts-es-id-pid", 0, NULL, PID_TEXT, PID_LONGTEXT, VLC_TRUE );
+    add_string( "ts-out", NULL, NULL, TSOUT_TEXT, TSOUT_LONGTEXT, VLC_TRUE );
+    add_integer( "ts-out-mtu", 1500, NULL, MTUOUT_TEXT,
+                 MTUOUT_LONGTEXT, VLC_TRUE );
+    add_string( "ts-csa-ck", NULL, NULL, CSA_TEXT, CSA_LONGTEXT, VLC_TRUE );
+    add_bool( "ts-silent", 0, NULL, SILENT_TEXT, SILENT_LONGTEXT, VLC_TRUE );
+
     set_capability( "demux2", 10 );
     set_callbacks( Open, Close );
-    add_shortcut( "ts2" );
+    add_shortcut( "ts" );
 vlc_module_end();
 
 /*****************************************************************************
@@ -139,6 +162,7 @@ typedef struct
 
     decoder_config_descriptor_t    dec_descr;
     sl_config_descriptor_t         sl_descr;
+
 } es_mpeg4_descriptor_t;
 
 typedef struct
@@ -161,33 +185,40 @@ typedef struct
 
 typedef struct
 {
+    dvbpsi_handle   handle;
+
     int             i_version;
     int             i_number;
     int             i_pid_pcr;
     /* IOD stuff (mpeg4) */
     iod_descriptor_t *iod;
+
 } ts_prg_psi_t;
 
 typedef struct
 {
-    /* Common PSI handle */
-    dvbpsi_handle   handle;
-
     /* for special PAT case */
+    dvbpsi_handle   handle;
     int             i_pat_version;
 
     /* For PMT */
     int             i_prg;
     ts_prg_psi_t    **prg;
+
 } ts_psi_t;
 
 typedef struct
 {
     es_format_t  fmt;
     es_out_id_t *id;
+    int         i_pes_size;
+    int         i_pes_gathered;
     block_t     *p_pes;
+    block_t     **pp_last;
 
     es_mpeg4_descriptor_t *p_mpeg4desc;
+    int         b_gather;
+
 } ts_es_t;
 
 typedef struct
@@ -214,6 +245,9 @@ typedef struct
 
 struct demux_sys_t
 {
+    /* TS packet size (188, 192, 204) */
+    int         i_packet_size;
+
     /* how many TS packet we read at once */
     int         i_ts_read;
 
@@ -257,6 +291,10 @@ static void PCRHandle( demux_t *p_demux, ts_pid_t *, block_t * );
 static iod_descriptor_t *IODNew( int , uint8_t * );
 static void              IODFree( iod_descriptor_t * );
 
+#define TS_PACKET_SIZE_188 188
+#define TS_PACKET_SIZE_192 192
+#define TS_PACKET_SIZE_204 204
+#define TS_PACKET_SIZE_MAX 204
 
 /*****************************************************************************
  * Open
@@ -267,49 +305,68 @@ static int Open( vlc_object_t *p_this )
     demux_sys_t *p_sys;
 
     uint8_t     *p_peek;
-    int          i_peek;
-    int          i_sync;
-    int          i;
+    int          i_sync, i_peek, i;
+    int          i_packet_size;
 
     ts_pid_t     *pat;
 
     vlc_value_t  val;
 
-    if( ( i_peek = stream_Peek( p_demux->s, &p_peek, 189 ) ) < 1 )
+    if( stream_Peek( p_demux->s, &p_peek, TS_PACKET_SIZE_MAX ) <
+        TS_PACKET_SIZE_MAX )
     {
         msg_Err( p_demux, "cannot peek" );
         return VLC_EGENERIC;
     }
 
-    /* Search first synch */
-    for( i_sync = 0; i_sync < i_peek; i_sync++ )
+    /* Search first sync byte */
+    for( i_sync = 0; i_sync < TS_PACKET_SIZE_MAX; i_sync++ )
     {
         if( p_peek[i_sync] == 0x47 ) break;
     }
-    if( i_sync >= i_peek )
+    if( i_sync >= TS_PACKET_SIZE_MAX )
     {
-        if( strcmp( p_demux->psz_demux, "ts2" ) )
+        if( strcmp( p_demux->psz_demux, "ts" ) )
         {
             msg_Warn( p_demux, "TS module discarded" );
             return VLC_EGENERIC;
         }
         msg_Warn( p_demux, "this does not look like a TS stream, continuing" );
     }
-    if( strcmp( p_demux->psz_demux, "ts2" ) )
+
+    /* Check next 3 sync bytes */
+    i_peek = TS_PACKET_SIZE_MAX * 3 + i_sync + 1;
+    if( ( stream_Peek( p_demux->s, &p_peek, i_peek ) ) < i_peek )
     {
-        /* Check next 3 sync points */
-        i_peek = 188*3 + 1 + i_sync;
-        if( ( stream_Peek( p_demux->s, &p_peek, i_peek ) ) < i_peek )
-        {
-            msg_Err( p_demux, "cannot peek" );
-            return VLC_EGENERIC;
-        }
-        if( p_peek[i_sync+  188] != 0x47 || p_peek[i_sync+2*188] != 0x47 ||
-            p_peek[i_sync+3*188] != 0x47 )
-        {
-            msg_Warn( p_demux, "TS module discarded (lost sync)" );
-            return VLC_EGENERIC;
-        }
+        msg_Err( p_demux, "cannot peek" );
+        return VLC_EGENERIC;
+    }
+    if( p_peek[i_sync + TS_PACKET_SIZE_188] == 0x47 &&
+        p_peek[i_sync + 2 * TS_PACKET_SIZE_188] == 0x47 &&
+        p_peek[i_sync + 3 * TS_PACKET_SIZE_188] == 0x47 )
+    {
+        i_packet_size = TS_PACKET_SIZE_188;
+    }
+    else if( p_peek[i_sync + TS_PACKET_SIZE_192] == 0x47 &&
+             p_peek[i_sync + 2 * TS_PACKET_SIZE_192] == 0x47 &&
+             p_peek[i_sync + 3 * TS_PACKET_SIZE_192] == 0x47 )
+    {
+        i_packet_size = TS_PACKET_SIZE_192;
+    }
+    else if( p_peek[i_sync + TS_PACKET_SIZE_204] == 0x47 &&
+             p_peek[i_sync + 2 * TS_PACKET_SIZE_204] == 0x47 &&
+             p_peek[i_sync + 3 * TS_PACKET_SIZE_204] == 0x47 )
+    {
+        i_packet_size = TS_PACKET_SIZE_204;
+    }
+    else if( !strcmp( p_demux->psz_demux, "ts" ) )
+    {
+        i_packet_size = TS_PACKET_SIZE_188;
+    }
+    else
+    {
+        msg_Warn( p_demux, "TS module discarded (lost sync)" );
+        return VLC_EGENERIC;
     }
 
     /* Fill p_demux field */
@@ -327,6 +384,7 @@ static int Open( vlc_object_t *p_this )
         pid->b_seen     = VLC_FALSE;
         pid->b_valid    = VLC_FALSE;
     }
+    p_sys->i_packet_size = i_packet_size;
     p_sys->b_udp_out = VLC_FALSE;
     p_sys->i_ts_read = 50;
     p_sys->csa = NULL;
@@ -375,12 +433,12 @@ static int Open( vlc_object_t *p_this )
             var_Create( p_demux, "ts-out-mtu",
                         VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
             var_Get( p_demux, "ts-out-mtu", &mtu );
-            p_sys->i_ts_read = mtu.i_int / 188;
+            p_sys->i_ts_read = mtu.i_int / p_sys->i_packet_size;
             if( p_sys->i_ts_read <= 0 )
             {
-                p_sys->i_ts_read = 1500 / 188;
+                p_sys->i_ts_read = 1500 / p_sys->i_packet_size;
             }
-            p_sys->buffer = malloc( 188 * p_sys->i_ts_read );
+            p_sys->buffer = malloc( p_sys->i_packet_size * p_sys->i_ts_read );
         }
     }
     if( val.psz_string )
@@ -404,7 +462,7 @@ static int Open( vlc_object_t *p_this )
             msg_Dbg( p_demux, "extra pmt specified (pid=0x%x)", i_pid );
             PIDInit( pmt, VLC_TRUE, NULL );
             /* FIXME we should also ask for a number */
-            pmt->psi->handle =
+            pmt->psi->prg[0]->handle =
                 dvbpsi_AttachPMT( 1, (dvbpsi_pmt_callback)PMTCallBack,
                                   p_demux );
             pmt->psi->prg[0]->i_number = 0; /* special one */
@@ -573,47 +631,51 @@ static int Demux( demux_t *p_demux )
         ts_pid_t    *p_pid;
 
         /* Get a new TS packet */
-        if( ( p_pkt = stream_Block( p_demux->s, 188 ) ) == NULL )
+        if( !( p_pkt = stream_Block( p_demux->s, p_sys->i_packet_size ) ) )
         {
             msg_Dbg( p_demux, "eof ?" );
             return 0;
         }
+
+        /* Check sync byte and re-sync if needed */
         if( p_pkt->p_buffer[0] != 0x47 )
         {
             msg_Warn( p_demux, "lost synchro" );
             block_Release( p_pkt );
 
-            /* Resynch */
             while( !p_demux->b_die )
             {
-                uint8_t    *p_peek;
-                int         i_peek = stream_Peek( p_demux->s, &p_peek, 1880 );
-                int         i_skip = 0;
-                vlc_bool_t  b_ok = VLC_FALSE;
+                uint8_t *p_peek;
+                int i_peek, i_skip = 0;
 
-                if( i_peek < 189 )
+                i_peek = stream_Peek( p_demux->s, &p_peek,
+                                      p_sys->i_packet_size * 10 );
+                if( i_peek < p_sys->i_packet_size + 1 )
                 {
                     msg_Dbg( p_demux, "eof ?" );
                     return 0;
                 }
 
-                while( i_skip < i_peek - 188 )
+                while( i_skip < i_peek - p_sys->i_packet_size )
                 {
-                    if( p_peek[i_skip] == 0x47 && p_peek[i_skip+188] == 0x47 )
+                    if( p_peek[i_skip] == 0x47 &&
+                        p_peek[i_skip + p_sys->i_packet_size] == 0x47 )
                     {
-                        b_ok = VLC_TRUE;
                         break;
                     }
                     i_skip++;
                 }
+
+                msg_Dbg( p_demux, "skipping %d bytes of garbage", i_skip );
                 stream_Read( p_demux->s, NULL, i_skip );
-                msg_Dbg( p_demux, "%d bytes of garbage", i_skip );
-                if( b_ok )
+
+                if( i_skip < i_peek - p_sys->i_packet_size )
                 {
                     break;
                 }
             }
-            if( ( p_pkt = stream_Block( p_demux->s, 188 ) ) == NULL )
+
+            if( !( p_pkt = stream_Block( p_demux->s, p_sys->i_packet_size ) ) )
             {
                 msg_Dbg( p_demux, "eof ?" );
                 return 0;
@@ -622,7 +684,8 @@ static int Demux( demux_t *p_demux )
 
         if( p_sys->b_udp_out )
         {
-            memcpy( &p_sys->buffer[i_pkt*188], p_pkt->p_buffer, 188 );
+            memcpy( &p_sys->buffer[i_pkt * p_sys->i_packet_size],
+                    p_pkt->p_buffer, p_sys->i_packet_size );
         }
 
         /* Parse the TS packet */
@@ -632,7 +695,19 @@ static int Demux( demux_t *p_demux )
         {
             if( p_pid->psi )
             {
-                dvbpsi_PushPacket( p_pid->psi->handle, p_pkt->p_buffer );
+                if( p_pid->i_pid == 0 )
+                {
+                    dvbpsi_PushPacket( p_pid->psi->handle, p_pkt->p_buffer );
+                }
+                else
+                {
+                    int i_prg;
+                    for( i_prg = 0; i_prg < p_pid->psi->i_prg; i_prg++ )
+                    {
+                        dvbpsi_PushPacket( p_pid->psi->prg[i_prg]->handle,
+                                           p_pkt->p_buffer );
+                    }
+                }
                 block_Release( p_pkt );
             }
             else if( !p_sys->b_udp_out )
@@ -665,7 +740,8 @@ static int Demux( demux_t *p_demux )
     if( p_sys->b_udp_out )
     {
         /* Send the complete block */
-        net_Write( p_demux, p_sys->fd, p_sys->buffer, p_sys->i_ts_read * 188 );
+        net_Write( p_demux, p_sys->fd, p_sys->buffer,
+                   p_sys->i_ts_read * p_sys->i_packet_size );
     }
 
     return 1;
@@ -755,7 +831,7 @@ static void PIDInit( ts_pid_t *pid, vlc_bool_t b_psi, ts_psi_t *p_owner )
             pid->psi = malloc( sizeof( ts_psi_t ) );
             pid->psi->i_prg = 0;
             pid->psi->prg   = NULL;
-            pid->psi->handle         = NULL;
+            pid->psi->handle= NULL;
         }
         pid->psi->i_pat_version  = -1;
         if( p_owner )
@@ -766,6 +842,7 @@ static void PIDInit( ts_pid_t *pid, vlc_bool_t b_psi, ts_psi_t *p_owner )
             prg->i_number   = -1;
             prg->i_pid_pcr  = -1;
             prg->iod        = NULL;
+            prg->handle     = NULL;
 
             TAB_APPEND( pid->psi->i_prg, pid->psi->prg, prg );
         }
@@ -778,7 +855,11 @@ static void PIDInit( ts_pid_t *pid, vlc_bool_t b_psi, ts_psi_t *p_owner )
         es_format_Init( &pid->es->fmt, UNKNOWN_ES, 0 );
         pid->es->id      = NULL;
         pid->es->p_pes   = NULL;
+        pid->es->i_pes_size= 0;
+        pid->es->i_pes_gathered= 0;
+        pid->es->pp_last = &pid->es->p_pes;
         pid->es->p_mpeg4desc = NULL;
+        pid->es->b_gather = VLC_FALSE;
     }
 }
 
@@ -791,7 +872,10 @@ static void PIDClean( es_out_t *out, ts_pid_t *pid )
         if( pid->psi->handle ) dvbpsi_DetachPMT( pid->psi->handle );
         for( i = 0; i < pid->psi->i_prg; i++ )
         {
-            if( pid->psi->prg[i]->iod ) IODFree( pid->psi->prg[i]->iod );
+            if( pid->psi->prg[i]->iod )
+                IODFree( pid->psi->prg[i]->iod );
+            if( pid->psi->prg[i]->handle )
+                dvbpsi_DetachPMT( pid->psi->prg[i]->handle );
             free( pid->psi->prg[i] );
         }
         if( pid->psi->prg ) free( pid->psi->prg );
@@ -832,35 +916,37 @@ static void PIDClean( es_out_t *out, ts_pid_t *pid )
 /****************************************************************************
  * gathering stuff
  ****************************************************************************/
-static void ParsePES ( demux_t *p_demux, ts_pid_t *pid )
+static void ParsePES( demux_t *p_demux, ts_pid_t *pid )
 {
     block_t *p_pes = pid->es->p_pes;
     uint8_t header[30];
-    int     i_pes_size;
+    int     i_pes_size = 0;
     int     i_skip = 0;
     mtime_t i_dts = -1;
     mtime_t i_pts = -1;
+    mtime_t i_length = 0;
     int i_max;
 
     /* remove the pes from pid */
     pid->es->p_pes = NULL;
+    pid->es->i_pes_size= 0;
+    pid->es->i_pes_gathered= 0;
+    pid->es->pp_last = &pid->es->p_pes;
 
     /* FIXME find real max size */
     i_max = block_ChainExtract( p_pes, header, 30 );
 
+
     if( header[0] != 0 || header[1] != 0 || header[2] != 1 )
     {
-        if ( !p_demux->p_sys->b_silent )
-            msg_Warn( p_demux, "invalid header [0x%x:%x:%x:%x]", header[0],
-                      header[1],header[2],header[3] );
+        if( !p_demux->p_sys->b_silent )
+            msg_Warn( p_demux, "invalid header [0x%x:%x:%x:%x] (pid: 0x%x)",
+                      header[0], header[1],header[2],header[3], pid->i_pid );
         block_ChainRelease( p_pes );
         return;
     }
 
-    i_pes_size = (header[4] << 8)|header[5];
-
     /* TODO check size */
-
     switch( header[3] )
     {
         case 0xBC:  /* Program stream map */
@@ -885,7 +971,7 @@ static void ParsePES ( demux_t *p_demux, ts_pid_t *pid )
                              (mtime_t)(header[10] << 22)|
                             ((mtime_t)(header[11]&0xfe) << 14)|
                              (mtime_t)(header[12] << 7)|
-                             (mtime_t)(header[12] >> 1);
+                             (mtime_t)(header[13] >> 1);
 
                     if( header[7]&0x40 )    /* has dts */
                     {
@@ -917,19 +1003,19 @@ static void ParsePES ( demux_t *p_demux, ts_pid_t *pid )
 
                 if(  header[i_skip]&0x20 )
                 {
-                     p_pes->i_pts = ((mtime_t)(header[i_skip]&0x0e ) << 29)|
-                                     (mtime_t)(header[i_skip+1] << 22)|
-                                    ((mtime_t)(header[i_skip+2]&0xfe) << 14)|
-                                     (mtime_t)(header[i_skip+3] << 7)|
-                                     (mtime_t)(header[i_skip+4] >> 1);
+                     i_pts = ((mtime_t)(header[i_skip]&0x0e ) << 29)|
+                              (mtime_t)(header[i_skip+1] << 22)|
+                             ((mtime_t)(header[i_skip+2]&0xfe) << 14)|
+                              (mtime_t)(header[i_skip+3] << 7)|
+                              (mtime_t)(header[i_skip+4] >> 1);
 
                     if( header[i_skip]&0x10 )    /* has dts */
                     {
-                         p_pes->i_dts = ((mtime_t)(header[i_skip+5]&0x0e ) << 29)|
-                                         (mtime_t)(header[i_skip+6] << 22)|
-                                        ((mtime_t)(header[i_skip+7]&0xfe) << 14)|
-                                         (mtime_t)(header[i_skip+8] << 7)|
-                                         (mtime_t)(header[i_skip+9] >> 1);
+                         i_dts = ((mtime_t)(header[i_skip+5]&0x0e ) << 29)|
+                                  (mtime_t)(header[i_skip+6] << 22)|
+                                 ((mtime_t)(header[i_skip+7]&0xfe) << 14)|
+                                  (mtime_t)(header[i_skip+8] << 7)|
+                                  (mtime_t)(header[i_skip+9] >> 1);
                          i_skip += 10;
                     }
                     else
@@ -956,6 +1042,30 @@ static void ParsePES ( demux_t *p_demux, ts_pid_t *pid )
     {
         i_skip += 1;
     }
+    else if( pid->es->fmt.i_codec == VLC_FOURCC( 's', 'u', 'b', 't' ) &&
+             pid->es->p_mpeg4desc )
+    {
+        decoder_config_descriptor_t *dcd = &pid->es->p_mpeg4desc->dec_descr;
+
+        if( dcd->i_decoder_specific_info_len > 2 &&
+            dcd->p_decoder_specific_info[0] == 0x10 &&
+            ( dcd->p_decoder_specific_info[1]&0x10 ) )
+        {
+            /* display length */
+            if( p_pes->i_buffer + 2 <= i_skip )
+            {
+                i_length = GetWBE( &p_pes->p_buffer[i_skip] );
+            }
+
+            i_skip += 2;
+        }
+        if( p_pes->i_buffer + 2 <= i_skip )
+        {
+            i_pes_size = GetWBE( &p_pes->p_buffer[i_skip] );
+        }
+        /* */
+        i_skip += 2;
+    }
 
     /* skip header */
     while( p_pes && i_skip > 0 )
@@ -989,10 +1099,19 @@ static void ParsePES ( demux_t *p_demux, ts_pid_t *pid )
         {
             p_pes->i_pts = i_pts * 100 / 9;
         }
+        p_pes->i_length = i_length * 100 / 9;
 
-        /* For mpeg4/mscodec we first gather the packet.
-         * This will make ffmpeg a lot happier */
         p_block = block_ChainGather( p_pes );
+        if( pid->es->fmt.i_codec == VLC_FOURCC( 's', 'u', 'b', 't' ) )
+        {
+            if( i_pes_size > 0 && p_block->i_buffer > i_pes_size )
+            {
+                p_block->i_buffer = i_pes_size;
+            }
+            /* Append a \0 */
+            p_block = block_Realloc( p_block, 0, p_block->i_buffer + 1 );
+            p_block->p_buffer[p_block->i_buffer -1] = '\0';
+        }
 
         for( i = 0; i < pid->i_extra_es; i++ )
         {
@@ -1046,20 +1165,31 @@ static void PCRHandle( demux_t *p_demux, ts_pid_t *pid, block_t *p_bk )
 static vlc_bool_t GatherPES( demux_t *p_demux, ts_pid_t *pid, block_t *p_bk )
 {
     const uint8_t    *p = p_bk->p_buffer;
-    const vlc_bool_t  b_adaptation= p[3]&0x20;
-    const vlc_bool_t  b_payload   = p[3]&0x10;
-    const int         i_cc        = p[3]&0x0f;   /* continuity counter */
+    const vlc_bool_t b_unit_start = p[1]&0x40;
+    const vlc_bool_t b_adaptation = p[3]&0x20;
+    const vlc_bool_t b_payload    = p[3]&0x10;
+    const int        i_cc         = p[3]&0x0f;   /* continuity counter */
+
     /* transport_scrambling_control is ignored */
 
     int         i_skip = 0;
-    vlc_bool_t  i_ret   = VLC_FALSE;
-
+    vlc_bool_t  i_ret  = VLC_FALSE;
     int         i_diff;
 
-    //msg_Dbg( p_demux, "pid=0x%x unit_start=%d adaptation=%d payload=%d cc=0x%x", i_pid, b_unit_start, b_adaptation, b_payload, i_continuity_counter);
+#if 0
+    msg_Dbg( p_demux, "pid=0x%x unit_start=%d adaptation=%d payload=%d "
+             "cc=0x%x", pid->i_pid, b_unit_start, b_adaptation,
+             b_payload, i_cc );
+#endif
+
+    /* For now, ignore additional error correction
+     * TODO: handle Reed-Solomon 204,188 error correction */
+    p_bk->i_buffer = TS_PACKET_SIZE_188;
+
     if( p[1]&0x80 )
     {
-        msg_Dbg( p_demux, "transport_error_indicator set (pid=0x%x)", pid->i_pid );
+        msg_Dbg( p_demux, "transport_error_indicator set (pid=0x%x)",
+                 pid->i_pid );
     }
 
     if( p_demux->p_sys->csa )
@@ -1069,11 +1199,13 @@ static vlc_bool_t GatherPES( demux_t *p_demux, ts_pid_t *pid, block_t *p_bk )
 
     if( !b_adaptation )
     {
+        /* We don't have any adaptation_field, so payload starts
+         * immediately after the 4 byte TS header */
         i_skip = 4;
     }
     else
     {
-        /* p[4] is adaptation length */
+        /* p[4] is adaptation_field_length minus one */
         i_skip = 5 + p[4];
         if( p[4] > 0 )
         {
@@ -1084,11 +1216,13 @@ static vlc_bool_t GatherPES( demux_t *p_demux, ts_pid_t *pid, block_t *p_bk )
             }
         }
     }
-    /* test continuity counter */
+
+    /* Test continuity counter */
     /* continuous when (one of this):
         * diff == 1
         * diff == 0 and payload == 0
-        * diff == 0 and duplicate packet (playload != 0) <- do we should test the content ?
+        * diff == 0 and duplicate packet (playload != 0) <- should we
+        *   test the content ?
      */
 
     i_diff = ( i_cc - pid->i_cc )&0x0f;
@@ -1124,37 +1258,54 @@ static vlc_bool_t GatherPES( demux_t *p_demux, ts_pid_t *pid, block_t *p_bk )
     if( i_skip >= 188 || pid->es->id == NULL || p_demux->p_sys->b_udp_out )
     {
         block_Release( p_bk );
+        return i_ret;
     }
-    else
-    {
-        const vlc_bool_t b_unit_start= p[1]&0x40;
 
-        /* we have to gather it */
-        p_bk->p_buffer += i_skip;
-        p_bk->i_buffer -= i_skip;
+    /* We have to gather it */
+    p_bk->p_buffer += i_skip;
+    p_bk->i_buffer -= i_skip;
 
-        if( b_unit_start )
+    if( b_unit_start )
+    {
+        if( pid->es->p_pes )
         {
-            if( pid->es->p_pes )
+            ParsePES( p_demux, pid );
+            i_ret = VLC_TRUE;
+        }
+
+        block_ChainLastAppend( &pid->es->pp_last, p_bk );
+        if( p_bk->i_buffer > 6 )
+        {
+            pid->es->i_pes_size = GetWBE( &p_bk->p_buffer[4] );
+            if( pid->es->i_pes_size > 0 )
             {
-                ParsePES( p_demux, pid );
-                i_ret = VLC_TRUE;
+                pid->es->i_pes_size += 6;
             }
-
-            pid->es->p_pes = p_bk;
+        }
+        pid->es->i_pes_gathered += p_bk->i_buffer;
+        if( pid->es->i_pes_size > 0 &&
+            pid->es->i_pes_gathered >= pid->es->i_pes_size )
+        {
+            ParsePES( p_demux, pid );
+            i_ret = VLC_TRUE;
+        }
+    }
+    else
+    {
+        if( pid->es->p_pes == NULL )
+        {
+            /* msg_Dbg( p_demux, "broken packet" ); */
+            block_Release( p_bk );
         }
         else
         {
-            if( pid->es->p_pes == NULL )
+            block_ChainLastAppend( &pid->es->pp_last, p_bk );
+            pid->es->i_pes_gathered += p_bk->i_buffer;
+            if( pid->es->i_pes_size > 0 &&
+                pid->es->i_pes_gathered >= pid->es->i_pes_size )
             {
-                /* msg_Dbg( p_demux, "broken packet" ); */
-                block_Release( p_bk );
-            }
-            else
-            {
-                /* TODO check if when have gathered enough packets to form a
-                 * PES (ie read PES size)*/
-                block_ChainAppend( &pid->es->p_pes, p_bk );
+                ParsePES( p_demux, pid );
+                i_ret = VLC_TRUE;
             }
         }
     }
@@ -1183,6 +1334,7 @@ static int PIDFillFormat( ts_pid_t *pid, int i_stream_type )
             break;
         case 0x10:  /* MPEG4 (video) */
             es_format_Init( fmt, VIDEO_ES, VLC_FOURCC( 'm', 'p', '4', 'v' ) );
+            pid->es->b_gather = VLC_TRUE;
             break;
         case 0x1B:  /* H264 <- check transport syntax/needed descriptor */
             es_format_Init( fmt, VIDEO_ES, VLC_FOURCC( 'h', '2', '6', '4' ) );
@@ -1217,8 +1369,13 @@ static int PIDFillFormat( ts_pid_t *pid, int i_stream_type )
             es_format_Init( fmt, AUDIO_ES, VLC_FOURCC( 's', 'd', 'd', 'b' ) );
             break;
 
-        case 0x06:  /* PES_PRIVATE  (fixed later) */
         case 0xa0:  /* MSCODEC vlc (video) (fixed later) */
+            es_format_Init( fmt, UNKNOWN_ES, 0 );
+            pid->es->b_gather = VLC_TRUE;
+            break;
+
+        case 0x06:  /* PES_PRIVATE  (fixed later) */
+        case 0x12:  /* MPEG-4 generic (sub/scene/...) (fixed later) */
         default:
             es_format_Init( fmt, UNKNOWN_ES, 0 );
             break;
@@ -1607,7 +1764,8 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
         int i_prg;
         for( i_prg = 0; i_prg < p_sys->pmt[i]->psi->i_prg; i_prg++ )
         {
-            if( p_sys->pmt[i]->psi->prg[i_prg]->i_number == p_pmt->i_program_number )
+            if( p_sys->pmt[i]->psi->prg[i_prg]->i_number ==
+                p_pmt->i_program_number )
             {
                 pmt = p_sys->pmt[i];
                 prg = p_sys->pmt[i]->psi->prg[i_prg];
@@ -1637,7 +1795,8 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
     {
         ts_pid_t *pid = &p_sys->pid[i];
 
-        if( pid->b_valid && pid->p_owner == pmt->psi && pid->i_owner_number == prg->i_number && pid->psi == NULL )
+        if( pid->b_valid && pid->p_owner == pmt->psi &&
+            pid->i_owner_number == prg->i_number && pid->psi == NULL )
         {
             PIDClean( p_demux->out, pid );
         }
@@ -1684,7 +1843,8 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
         PIDFillFormat( pid, p_es->i_type );
         pid->i_owner_number = prg->i_number;
 
-        if( p_es->i_type == 0x10 || p_es->i_type == 0x11 )
+        if( p_es->i_type == 0x10 || p_es->i_type == 0x11 ||
+            p_es->i_type == 0x12 )
         {
             /* MPEG-4 stream: search SL_DESCRIPTOR */
             dvbpsi_descriptor_t *p_dr = p_es->p_first_descriptor;;
@@ -1723,6 +1883,11 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
                     pid->es->fmt.i_cat = VIDEO_ES;
                     switch( dcd->i_objectTypeIndication )
                     {
+                    case 0x0B: /* mpeg4 sub */
+                        pid->es->fmt.i_cat = SPU_ES;
+                        pid->es->fmt.i_codec = VLC_FOURCC('s','u','b','t');
+                        break;
+
                     case 0x20: /* mpeg4 */
                         pid->es->fmt.i_codec = VLC_FOURCC('m','p','4','v');
                         break;
@@ -1802,6 +1967,26 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
                     pid->es->fmt.i_cat = AUDIO_ES;
                     pid->es->fmt.i_codec = VLC_FOURCC( 'a', '5', '2', ' ' );
                 }
+                else if( p_dr->i_tag == 0x05 )
+                {
+
+                    /* DTS registration descriptor (ETSI TS 101 154 Annex F) */
+                    pid->es->fmt.i_cat = AUDIO_ES;
+                    pid->es->fmt.i_codec = VLC_FOURCC( 'd', 't', 's', ' ' );
+                }
+                else if( p_dr->i_tag == 0x73 )
+                {
+                    /* DTS audio descriptor (ETSI TS 101 154 Annex F) */
+                    msg_Dbg( p_demux, "  * DTS audio descriptor not decoded" );
+                    pid->es->fmt.i_cat = AUDIO_ES;
+                    pid->es->fmt.i_codec = VLC_FOURCC( 'd', 't', 's', ' ' );
+                }
+                else if( p_dr->i_tag == 0x56 )
+                {
+                    msg_Dbg( p_demux, "  * Teletext descriptor" );
+                    pid->es->fmt.i_cat = SPU_ES;
+                    pid->es->fmt.i_codec = VLC_FOURCC( 't', 'e', 'l', 'x' );
+                }
 #ifdef _DVBPSI_DR_59_H_
                 else if( p_dr->i_tag == 0x59 )
                 {
@@ -1827,6 +2012,9 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
 
                         pid->es->fmt.subs.dvb.i_id =
                             sub->p_subtitle[0].i_composition_page_id;
+                        /* Hack, FIXME */
+                        pid->es->fmt.subs.dvb.i_id |=
+                          ((int)sub->p_subtitle[0].i_ancillary_page_id << 16);
                     }
                     else pid->es->fmt.i_cat = UNKNOWN_ES;
 
@@ -1836,6 +2024,9 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
                         p_es->fmt = pid->es->fmt;
                         p_es->id = NULL;
                         p_es->p_pes = NULL;
+                        p_es->i_pes_size = 0;
+                        p_es->i_pes_gathered = 0;
+                        p_es->pp_last = &p_es->p_pes;
                         p_es->p_mpeg4desc = NULL;
 
                         p_es->fmt.psz_language = malloc( 4 );
@@ -1845,6 +2036,9 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
 
                         p_es->fmt.subs.dvb.i_id =
                             sub->p_subtitle[n].i_composition_page_id;
+                        /* Hack, FIXME */
+                        pid->es->fmt.subs.dvb.i_id |=
+                          ((int)sub->p_subtitle[n].i_ancillary_page_id << 16);
 
                         TAB_APPEND( pid->i_extra_es, pid->extra_es, p_es );
                     }
@@ -1952,7 +2146,8 @@ static void PATCallBack( demux_t *p_demux, dvbpsi_pat_t *p_pat )
     msg_Dbg( p_demux, "PATCallBack called" );
 
     if( pat->psi->i_pat_version != -1 &&
-        ( !p_pat->b_current_next || p_pat->i_version == pat->psi->i_pat_version ) )
+        ( !p_pat->b_current_next ||
+          p_pat->i_version == pat->psi->i_pat_version ) )
     {
         dvbpsi_DeletePAT( p_pat );
         return;
@@ -1981,7 +2176,8 @@ static void PATCallBack( demux_t *p_demux, dvbpsi_pat_t *p_pat )
                     int i_prg;
                     for( i_prg = 0; i_prg < pmt->psi->i_prg; i_prg++ )
                     {
-                        if( p_program->i_number == pmt->psi->prg[i_prg]->i_number )
+                        if( p_program->i_number ==
+                            pmt->psi->prg[i_prg]->i_number )
                         {
                             b_keep = VLC_TRUE;
                             break;
@@ -2009,8 +2205,8 @@ static void PATCallBack( demux_t *p_demux, dvbpsi_pat_t *p_pat )
                 int i_prg;
                 for( i_prg = 0; i_prg < pid->p_owner->i_prg; i_prg++ )
                 {
-                    if( pid->p_owner->prg[i_prg]->i_pid_pcr == pmt_rm[j]->i_pid &&
-                        pid->es->id )
+                    if( pid->p_owner->prg[i_prg]->i_pid_pcr ==
+                        pmt_rm[j]->i_pid && pid->es->id )
                     {
                         /* We only remove es that aren't defined by extra pmt */
                         PIDClean( p_demux->out, pid );
@@ -2043,20 +2239,10 @@ static void PATCallBack( demux_t *p_demux, dvbpsi_pat_t *p_pat )
         if( p_program->i_number != 0 )
         {
             ts_pid_t *pmt = &p_sys->pid[p_program->i_pid];
+            vlc_bool_t b_add = VLC_TRUE;
 
-            if( !pmt->b_valid )
+            if( pmt->b_valid )
             {
-                PIDInit( pmt, VLC_TRUE, pat->psi );
-                pmt->psi->handle =
-                    dvbpsi_AttachPMT( p_program->i_number,
-                                      (dvbpsi_pmt_callback)PMTCallBack, p_demux );
-                pmt->psi->prg[0]->i_number = p_program->i_number;
-
-                TAB_APPEND( p_sys->i_pmt, p_sys->pmt, pmt );
-            }
-            else
-            {
-                vlc_bool_t b_add = VLC_TRUE;
                 int i_prg;
                 for( i_prg = 0; i_prg < pmt->psi->i_prg; i_prg++ )
                 {
@@ -2066,11 +2252,21 @@ static void PATCallBack( demux_t *p_demux, dvbpsi_pat_t *p_pat )
                         break;
                     }
                 }
-                if( b_add )
-                {
-                    PIDInit( pmt, VLC_TRUE, pat->psi );
-                    pmt->psi->prg[pmt->psi->i_prg-1]->i_number = p_program->i_number;
-                }
+            }
+            else
+            {
+                TAB_APPEND( p_sys->i_pmt, p_sys->pmt, pmt );
+            }
+
+            if( b_add )
+            {
+                PIDInit( pmt, VLC_TRUE, pat->psi );
+                pmt->psi->prg[pmt->psi->i_prg-1]->handle =
+                    dvbpsi_AttachPMT( p_program->i_number,
+                                      (dvbpsi_pmt_callback)PMTCallBack,
+                                      p_demux );
+                pmt->psi->prg[pmt->psi->i_prg-1]->i_number =
+                    p_program->i_number;
             }
         }
     }
@@ -2078,4 +2274,3 @@ static void PATCallBack( demux_t *p_demux, dvbpsi_pat_t *p_pat )
 
     dvbpsi_DeletePAT( p_pat );
 }
-