]> git.sesse.net Git - vlc/blobdiff - modules/demux/ts.c
MKV: debug extra metadata too
[vlc] / modules / demux / ts.c
index 0f1b86d797920eee096edefc8c72b29829a6742b..f9c2f4dedaf7eec870db7a7e61fd38885405b8b0 100644 (file)
@@ -62,7 +62,7 @@
 # include <dvbpsi/tot.h>
 
 #undef TS_DEBUG
-static void ts_debug(const char *format, ...)
+VLC_FORMAT(1, 2) static void ts_debug(const char *format, ...)
 {
 #ifdef TS_DEBUG
     va_list ap;
@@ -337,8 +337,8 @@ static void PIDInit ( ts_pid_t *pid, bool b_psi, ts_psi_t *p_owner );
 static void PIDClean( demux_t *, ts_pid_t *pid );
 static void PIDFillFormat( ts_es_t *es, int i_stream_type );
 
-static void PATCallBack( demux_t *, dvbpsi_pat_t * );
-static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt );
+static void PATCallBack( void*, dvbpsi_pat_t * );
+static void PMTCallBack( void *data, dvbpsi_pmt_t *p_pmt );
 static void PSINewTableCallBack( demux_t *, dvbpsi_handle,
                                  uint8_t  i_table_id, uint16_t i_extension );
 static int ChangeKeyCallback( vlc_object_t *, char const *, vlc_value_t, vlc_value_t, void * );
@@ -550,8 +550,7 @@ static int Open( vlc_object_t *p_this )
     /* Init PAT handler */
     pat = &p_sys->pid[0];
     PIDInit( pat, true, NULL );
-    pat->psi->handle = dvbpsi_AttachPAT( (dvbpsi_pat_callback)PATCallBack,
-                                         p_demux );
+    pat->psi->handle = dvbpsi_AttachPAT( PATCallBack, p_demux );
     if( p_sys->b_dvb_meta )
     {
         ts_pid_t *sdt = &p_sys->pid[0x11];
@@ -1129,7 +1128,9 @@ static int UserPmt( demux_t *p_demux, const char *psz_fmt )
     prg->i_pid_pmt  = -1;
     prg->i_version  = -1;
     prg->i_number   = i_number != 0 ? i_number : TS_USER_PMT_NUMBER;
-    prg->handle     = dvbpsi_AttachPMT( i_number != TS_USER_PMT_NUMBER ? i_number : 1, (dvbpsi_pmt_callback)PMTCallBack, p_demux );
+    prg->handle     = dvbpsi_AttachPMT(
+        i_number != TS_USER_PMT_NUMBER ? i_number : 1,
+        PMTCallBack, p_demux );
     TAB_APPEND( pmt->psi->i_prg, pmt->psi->prg, prg );
 
     psz = strchr( psz, '=' );
@@ -1305,36 +1306,29 @@ static void PIDInit( ts_pid_t *pid, bool b_psi, ts_psi_t *p_owner )
         if( p_owner )
         {
             ts_prg_psi_t *prg = malloc( sizeof( ts_prg_psi_t ) );
-            if( prg )
-            {
-                /* PMT */
-                prg->i_version  = -1;
-                prg->i_number   = -1;
-                prg->i_pid_pcr  = -1;
-                prg->i_pid_pmt  = -1;
-                prg->i_pcr_value= -1;
-                prg->iod        = NULL;
-                prg->handle     = NULL;
-
-                TAB_APPEND( pid->psi->i_prg, pid->psi->prg, prg );
-            }
+            if( !prg )
+                return;
+            /* PMT */
+            prg->i_version  = -1;
+            prg->i_number   = -1;
+            prg->i_pid_pcr  = -1;
+            prg->i_pid_pmt  = -1;
+            prg->i_pcr_value= -1;
+            prg->iod        = NULL;
+            prg->handle     = NULL;
+
+            TAB_APPEND( pid->psi->i_prg, pid->psi->prg, prg );
         }
     }
     else
     {
         pid->psi = NULL;
-        pid->es  = malloc( sizeof( ts_es_t ) );
-        if( pid->es )
-        {
-            es_format_Init( &pid->es->fmt, UNKNOWN_ES, 0 );
-            pid->es->id      = NULL;
-            pid->es->p_pes   = NULL;
-            pid->es->i_pes_size= 0;
-            pid->es->i_pes_gathered= 0;
-            pid->es->pp_last = &pid->es->p_pes;
-            pid->es->p_mpeg4desc = NULL;
-            pid->es->b_gather = false;
-        }
+        pid->es  = calloc( 1, sizeof( ts_es_t ) );
+        if( !pid->es )
+            return;
+
+        es_format_Init( &pid->es->fmt, UNKNOWN_ES, 0 );
+        pid->es->pp_last = &pid->es->p_pes;
     }
 }
 
@@ -1950,28 +1944,22 @@ static void PCRHandle( demux_t *p_demux, ts_pid_t *pid, block_t *p_bk )
         return;
 
     mtime_t i_pcr = GetPCR( p_bk );
-    if( i_pcr >= 0 )
-    {
-        if( p_sys->i_pid_ref_pcr == pid->i_pid )
-        {
-            p_sys->i_current_pcr = AdjustPCRWrapAround( p_demux, i_pcr );
-        }
+    if( i_pcr < 0 )
+        return;
 
-        /* Search program and set the PCR */
-        for( int i = 0; i < p_sys->i_pmt; i++ )
-        {
-            for( int i_prg = 0; i_prg < p_sys->pmt[i]->psi->i_prg; i_prg++ )
+    if( p_sys->i_pid_ref_pcr == pid->i_pid )
+        p_sys->i_current_pcr = AdjustPCRWrapAround( p_demux, i_pcr );
+
+    /* Search program and set the PCR */
+    for( int i = 0; i < p_sys->i_pmt; i++ )
+        for( int i_prg = 0; i_prg < p_sys->pmt[i]->psi->i_prg; i_prg++ )
+            if( pid->i_pid == p_sys->pmt[i]->psi->prg[i_prg]->i_pid_pcr )
             {
-                if( pid->i_pid == p_sys->pmt[i]->psi->prg[i_prg]->i_pid_pcr )
-                {
-                    p_sys->pmt[i]->psi->prg[i_prg]->i_pcr_value = i_pcr;
-                    es_out_Control( p_demux->out, ES_OUT_SET_GROUP_PCR,
-                                    (int)p_sys->pmt[i]->psi->prg[i_prg]->i_number,
-                                    (int64_t)(VLC_TS_0 + i_pcr * 100 / 9) );
-                }
+                p_sys->pmt[i]->psi->prg[i_prg]->i_pcr_value = i_pcr;
+                es_out_Control( p_demux->out, ES_OUT_SET_GROUP_PCR,
+                                (int)p_sys->pmt[i]->psi->prg[i_prg]->i_number,
+                                (int64_t)(VLC_TS_0 + i_pcr * 100 / 9) );
             }
-        }
-    }
 }
 
 static bool GatherPES( demux_t *p_demux, ts_pid_t *pid, block_t *p_bk )
@@ -3101,7 +3089,6 @@ static void PMTSetupEsTeletext( demux_t *p_demux, ts_pid_t *pid,
     }
 #endif
 
-#ifdef _DVBPSI_DR_59_H_
     dvbpsi_descriptor_t *p_dr = PMTEsFindDescriptor( p_es, 0x59 );
     if( p_dr )
     {
@@ -3133,7 +3120,6 @@ static void PMTSetupEsTeletext( demux_t *p_demux, ts_pid_t *pid,
             memcpy( p_dst->p_iso639, p_src->i_iso6392_language_code, 3 );
         }
     }
-#endif
 
     /* */
     es_format_Init( p_fmt, SPU_ES, VLC_CODEC_TELETEXT );
@@ -3219,7 +3205,6 @@ static void PMTSetupEsDvbSubtitle( demux_t *p_demux, ts_pid_t *pid,
 
     dvbpsi_descriptor_t *p_dr = PMTEsFindDescriptor( p_es, 0x59 );
     int i_page = 0;
-#ifdef _DVBPSI_DR_59_H_
     dvbpsi_subtitling_dr_t *p_sub = dvbpsi_DecodeSubtitlingDr( p_dr );
     for( int i = 0; p_sub && i < p_sub->i_subtitles_number; i++ )
     {
@@ -3228,7 +3213,6 @@ static void PMTSetupEsDvbSubtitle( demux_t *p_demux, ts_pid_t *pid,
             ( i_type >= 0x20 && i_type <= 0x24 ) )
             i_page++;
     }
-#endif
 
     if( !p_demux->p_sys->b_split_es  || i_page <= 0 )
     {
@@ -3248,7 +3232,6 @@ static void PMTSetupEsDvbSubtitle( demux_t *p_demux, ts_pid_t *pid,
     }
     else
     {
-#ifdef _DVBPSI_DR_59_H_
         for( int i = 0; i < p_sub->i_subtitles_number; i++ )
         {
             ts_es_t *p_es;
@@ -3308,7 +3291,6 @@ static void PMTSetupEsDvbSubtitle( demux_t *p_demux, ts_pid_t *pid,
             p_es->fmt.subs.dvb.i_id = ( p->i_composition_page_id <<  0 ) |
                                       ( p->i_ancillary_page_id   << 16 );
         }
-#endif
     }
 }
 static void PMTSetupEs0x06( demux_t *p_demux, ts_pid_t *pid,
@@ -3349,7 +3331,6 @@ static void PMTSetupEs0x06( demux_t *p_demux, ts_pid_t *pid,
         /* Subtitle/Teletext/VBI fallbacks */
         dvbpsi_descriptor_t *p_dr = PMTEsFindDescriptor( p_es, 0x59 );
 
-#ifdef _DVBPSI_DR_59_H_
         dvbpsi_subtitling_dr_t *p_sub;
         if( p_dr && ( p_sub = dvbpsi_DecodeSubtitlingDr( p_dr ) ) )
         {
@@ -3384,10 +3365,7 @@ static void PMTSetupEs0x06( demux_t *p_demux, ts_pid_t *pid,
                 }
             }
         }
-#else
-        if( p_fmt->i_cat == UNKNOWN_ES && p_dr )
-            PMTSetupEsDvbSubtitle( p_demux, pid, p_es );
-#endif
+
         if( p_fmt->i_cat == UNKNOWN_ES &&
             ( PMTEsFindDescriptor( p_es, 0x45 ) ||  /* VBI Data descriptor */
               PMTEsFindDescriptor( p_es, 0x46 ) ||  /* VBI Teletext descriptor */
@@ -3398,7 +3376,6 @@ static void PMTSetupEs0x06( demux_t *p_demux, ts_pid_t *pid,
         }
     }
 
-#ifdef _DVBPSI_DR_52_H_
     /* FIXME is it useful ? */
     if( PMTEsFindDescriptor( p_es, 0x52 ) )
     {
@@ -3407,7 +3384,6 @@ static void PMTSetupEs0x06( demux_t *p_demux, ts_pid_t *pid,
 
         msg_Dbg( p_demux, "    * Stream Component Identifier: %d", p_si->i_component_tag );
     }
-#endif
 }
 
 static void PMTSetupEs0xEA( demux_t *p_demux, ts_pid_t *pid,
@@ -3485,10 +3461,8 @@ static void PMTSetupEs0xA0( demux_t *p_demux, ts_pid_t *pid,
     p_fmt->b_packetized = true;
 }
 
-static void PMTSetupEsHDMV( demux_t *p_demux, ts_pid_t *pid,
-                           const dvbpsi_pmt_es_t *p_es )
+static void PMTSetupEsHDMV( ts_pid_t *pid, const dvbpsi_pmt_es_t *p_es )
 {
-    VLC_UNUSED(p_demux);
     es_format_t *p_fmt = &pid->es->fmt;
 
     /* Blu-Ray mapping */
@@ -3553,11 +3527,27 @@ static void PMTSetupEsRegistration( demux_t *p_demux, ts_pid_t *pid,
         {
             p_fmt->i_cat   = p_regs[i].i_cat;
             p_fmt->i_codec = p_regs[i].i_codec;
-            break;
+            return;
         }
     }
 }
 
+static char *GetAudioTypeDesc(demux_t *p_demux, int type)
+{
+    static const char *audio_type[] = {
+        NULL,
+        N_("clean effects"),
+        N_("hearing impaired"),
+        N_("visual impaired commentary"),
+    };
+
+    if (type < 0 || type > 3)
+        msg_Dbg( p_demux, "unknown audio type: %d", type);
+    else if (type > 0)
+        return strdup(audio_type[type - 1]);
+
+    return NULL;
+}
 static void PMTParseEsIso639( demux_t *p_demux, ts_pid_t *pid,
                               const dvbpsi_pmt_es_t *p_es )
 {
@@ -3578,35 +3568,15 @@ static void PMTParseEsIso639( demux_t *p_demux, ts_pid_t *pid,
     pid->es->fmt.psz_language = malloc( 4 );
     if( pid->es->fmt.psz_language )
     {
-        memcpy( pid->es->fmt.psz_language,
-                p_decoded->code[0].iso_639_code, 3 );
+        memcpy( pid->es->fmt.psz_language, p_decoded->code[0].iso_639_code, 3 );
         pid->es->fmt.psz_language[3] = 0;
         msg_Dbg( p_demux, "found language: %s", pid->es->fmt.psz_language);
     }
-    switch( p_decoded->code[0].i_audio_type )
-    {
-    case 0:
+    int type = p_decoded->code[0].i_audio_type;
+    pid->es->fmt.psz_description = GetAudioTypeDesc(p_demux, type);
+    if (type == 0)
         pid->es->fmt.i_priority = 1; // prioritize normal audio tracks
-        pid->es->fmt.psz_description = NULL;
-        break;
-    case 1:
-        pid->es->fmt.psz_description =
-            strdup(_("clean effects"));
-        break;
-    case 2:
-        pid->es->fmt.psz_description =
-            strdup(_("hearing impaired"));
-        break;
-    case 3:
-        pid->es->fmt.psz_description =
-            strdup(_("visual impaired commentary"));
-        break;
-    default:
-        msg_Dbg( p_demux, "unknown audio type: %d",
-                 p_decoded->code[0].i_audio_type);
-        pid->es->fmt.psz_description = NULL;
-        break;
-    }
+
     pid->es->fmt.i_extra_languages = p_decoded->i_code_count-1;
     if( pid->es->fmt.i_extra_languages > 0 )
         pid->es->fmt.p_extra_languages =
@@ -3616,40 +3586,15 @@ static void PMTParseEsIso639( demux_t *p_demux, ts_pid_t *pid,
     {
         for( int i = 0; i < pid->es->fmt.i_extra_languages; i++ )
         {
-            msg_Dbg( p_demux, "bang" );
-            pid->es->fmt.p_extra_languages[i].psz_language =
-                malloc(4);
+            pid->es->fmt.p_extra_languages[i].psz_language = malloc(4);
             if( pid->es->fmt.p_extra_languages[i].psz_language )
             {
                 memcpy( pid->es->fmt.p_extra_languages[i].psz_language,
                     p_decoded->code[i+1].iso_639_code, 3 );
                 pid->es->fmt.p_extra_languages[i].psz_language[3] = '\0';
             }
-            switch( p_decoded->code[i].i_audio_type )
-            {
-            case 0:
-                pid->es->fmt.p_extra_languages[i].psz_description =
-                    NULL;
-                break;
-            case 1:
-                pid->es->fmt.p_extra_languages[i].psz_description =
-                    strdup(_("clean effects"));
-                break;
-            case 2:
-                pid->es->fmt.p_extra_languages[i].psz_description =
-                    strdup(_("hearing impaired"));
-                break;
-            case 3:
-                pid->es->fmt.p_extra_languages[i].psz_description =
-                    strdup(_("visual impaired commentary"));
-                break;
-            default:
-                msg_Dbg( p_demux, "unknown audio type: %d",
-                        p_decoded->code[i].i_audio_type);
-                pid->es->fmt.psz_description = NULL;
-                break;
-            }
-
+            int type = p_decoded->code[i].i_audio_type;
+            pid->es->fmt.psz_description = GetAudioTypeDesc(p_demux, type);
         }
     }
 #else
@@ -3663,37 +3608,28 @@ static void PMTParseEsIso639( demux_t *p_demux, ts_pid_t *pid,
 #endif
 }
 
-static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
+static void PMTCallBack( void *data, dvbpsi_pmt_t *p_pmt )
 {
-    demux_sys_t          *p_sys = p_demux->p_sys;
-    dvbpsi_descriptor_t  *p_dr;
-    dvbpsi_pmt_es_t      *p_es;
+    demux_t      *p_demux = data;
+    demux_sys_t  *p_sys = p_demux->p_sys;
 
-    ts_pid_t             *pmt = NULL;
-    ts_prg_psi_t         *prg = NULL;
-
-    ts_pid_t             **pp_clean = NULL;
-    int                  i_clean = 0;
-    bool                 b_hdmv = false;
+    ts_pid_t     *pmt = NULL;
+    ts_prg_psi_t *prg;
 
     msg_Dbg( p_demux, "PMTCallBack called" );
 
     /* First find this PMT declared in PAT */
-    for( int i = 0; i < p_sys->i_pmt; i++ )
-    {
-        for( int i_prg = 0; i_prg < p_sys->pmt[i]->psi->i_prg; i_prg++ )
+    for( int i = 0; !pmt && i < p_sys->i_pmt; i++ )
+        for( int i_prg = 0; !pmt && i_prg < p_sys->pmt[i]->psi->i_prg; i_prg++ )
         {
             const int i_pmt_number = p_sys->pmt[i]->psi->prg[i_prg]->i_number;
-            if( i_pmt_number != TS_USER_PMT_NUMBER && i_pmt_number == p_pmt->i_program_number )
+            if( i_pmt_number != TS_USER_PMT_NUMBER &&
+                i_pmt_number == p_pmt->i_program_number )
             {
                 pmt = p_sys->pmt[i];
                 prg = p_sys->pmt[i]->psi->prg[i_prg];
-                break;
             }
         }
-        if( pmt )
-            break;
-    }
 
     if( pmt == NULL )
     {
@@ -3702,6 +3638,7 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
         return;
     }
 
+
     if( prg->i_version != -1 &&
         ( !p_pmt->b_current_next || prg->i_version == p_pmt->i_version ) )
     {
@@ -3709,6 +3646,8 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
         return;
     }
 
+    ts_pid_t **pp_clean = NULL;
+    int      i_clean = 0;
     /* Clean this program (remove all es) */
     for( int i = 0; i < 8192; i++ )
     {
@@ -3733,30 +3672,25 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
 
     ValidateDVBMeta( p_demux, prg->i_pid_pcr );
     if( ProgramIsSelected( p_demux, prg->i_number ) )
-    {
-        /* Set demux filter */
-        SetPIDFilter( p_demux, prg->i_pid_pcr, true );
-    }
+        SetPIDFilter( p_demux, prg->i_pid_pcr, true ); /* Set demux filter */
 
     /* Parse descriptor */
+    bool b_hdmv = false;
+    dvbpsi_descriptor_t  *p_dr;
     for( p_dr = p_pmt->p_first_descriptor; p_dr != NULL; p_dr = p_dr->p_next )
-    {
-        if( p_dr->i_tag == 0x1d )
+        switch(p_dr->i_tag)
         {
-            /* We have found an IOD descriptor */
+        case 0x1d: /* We have found an IOD descriptor */
             msg_Dbg( p_demux, " * descriptor : IOD (0x1d)" );
-
             prg->iod = IODNew( p_dr->i_length, p_dr->p_data );
-        }
-        else if( p_dr->i_tag == 0x9 )
-        {
-            uint16_t i_sysid = ((uint16_t)p_dr->p_data[0] << 8)
-                                | p_dr->p_data[1];
-            msg_Dbg( p_demux, " * descriptor : CA (0x9) SysID 0x%x", i_sysid );
-        }
-        else if( p_dr->i_tag == 0x05 )
-        {
-            /* Registration Descriptor */
+            break;
+
+        case 0x9:
+            msg_Dbg( p_demux, " * descriptor : CA (0x9) SysID 0x%x",
+                    (p_dr->p_data[0] << 8) | p_dr->p_data[1] );
+            break;
+
+        case 0x5: /* Registration Descriptor */
             if( p_dr->i_length != 4 )
             {
                 msg_Warn( p_demux, "invalid Registration Descriptor" );
@@ -3765,18 +3699,15 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
             {
                 msg_Dbg( p_demux, " * descriptor : registration %4.4s", p_dr->p_data );
                 if( !memcmp( p_dr->p_data, "HDMV", 4 ) )
-                {
-                    /* Blu-Ray */
-                    b_hdmv = true;
-                }
+                    b_hdmv = true; /* Blu-Ray */
             }
-        }
-        else
-        {
+            break;
+
+        default:
             msg_Dbg( p_demux, " * descriptor : unknown (0x%x)", p_dr->i_tag );
         }
-    }
 
+    dvbpsi_pmt_es_t      *p_es;
     for( p_es = p_pmt->p_first_es; p_es != NULL; p_es = p_es->p_next )
     {
         ts_pid_t tmp_pid, *old_pid = 0, *pid = &tmp_pid;
@@ -3835,7 +3766,7 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
         }
         else if( b_hdmv )
         {
-            PMTSetupEsHDMV( p_demux, pid, p_es );
+            PMTSetupEsHDMV( pid, p_es );
         }
         else if( p_es->i_type >= 0x80 )
         {
@@ -3917,17 +3848,13 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
         p_dr = PMTEsFindDescriptor( p_es, 0x09 );
         if( p_dr && p_dr->i_length >= 2 )
         {
-            uint16_t i_sysid = (p_dr->p_data[0] << 8) | p_dr->p_data[1];
             msg_Dbg( p_demux, "   * descriptor : CA (0x9) SysID 0x%x",
-                     i_sysid );
+                     (p_dr->p_data[0] << 8) | p_dr->p_data[1] );
         }
 
         if( ProgramIsSelected( p_demux, prg->i_number ) &&
             ( pid->es->id != NULL || p_sys->b_udp_out ) )
-        {
-            /* Set demux filter */
-            SetPIDFilter( p_demux, p_es->i_pid, true );
-        }
+            SetPIDFilter( p_demux, p_es->i_pid, true ); /* Set demux filter */
     }
 
     /* Set CAM descrambling */
@@ -3939,9 +3866,7 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
     for( int i = 0; i < i_clean; i++ )
     {
         if( ProgramIsSelected( p_demux, prg->i_number ) )
-        {
             SetPIDFilter( p_demux, pp_clean[i]->i_pid, false );
-        }
 
         PIDClean( p_demux, pp_clean[i] );
     }
@@ -3949,8 +3874,9 @@ static void PMTCallBack( demux_t *p_demux, dvbpsi_pmt_t *p_pmt )
         free( pp_clean );
 }
 
-static void PATCallBack( demux_t *p_demux, dvbpsi_pat_t *p_pat )
+static void PATCallBack( void *data, dvbpsi_pat_t *p_pat )
 {
+    demux_t              *p_demux = data;
     demux_sys_t          *p_sys = p_demux->p_sys;
     dvbpsi_pat_program_t *p_program;
     ts_pid_t             *pat = &p_sys->pid[0];
@@ -3981,29 +3907,21 @@ static void PATCallBack( demux_t *p_demux, dvbpsi_pat_t *p_pat )
             ts_pid_t *pmt = p_sys->pmt[i];
             bool b_keep = false;
 
-            for( p_program = p_pat->p_first_program; p_program != NULL;
+            for( p_program = p_pat->p_first_program; !b_keep && p_program;
                  p_program = p_program->p_next )
             {
-                if( p_program->i_pid == pmt->i_pid )
-                {
-                    for( int i_prg = 0; i_prg < pmt->psi->i_prg; i_prg++ )
-                    {
-                        if( p_program->i_number ==
-                            pmt->psi->prg[i_prg]->i_number )
-                        {
-                            b_keep = true;
-                            break;
-                        }
-                    }
-                    if( b_keep )
-                        break;
-                }
-            }
+                if( p_program->i_pid != pmt->i_pid )
+                    continue;
 
-            if( !b_keep )
-            {
-                TAB_APPEND( i_pmt_rm, pmt_rm, pmt );
+                for( int i_prg = 0; !b_keep && i_prg < pmt->psi->i_prg; i_prg++ )
+                    if( p_program->i_number == pmt->psi->prg[i_prg]->i_number )
+                        b_keep = true;
             }
+
+            if( b_keep )
+                continue;
+
+            TAB_APPEND( i_pmt_rm, pmt_rm, pmt );
         }
 
         /* Delete all ES attached to thoses PMT */
@@ -4055,51 +3973,42 @@ static void PATCallBack( demux_t *p_demux, dvbpsi_pat_t *p_pat )
     {
         msg_Dbg( p_demux, "  * number=%d pid=%d", p_program->i_number,
                  p_program->i_pid );
-        if( p_program->i_number != 0 )
+        if( p_program->i_number == 0 )
+            continue;
+
+        ts_pid_t *pmt = &p_sys->pid[p_program->i_pid];
+
+        ValidateDVBMeta( p_demux, p_program->i_pid );
+
+        if( pmt->b_valid )
         {
-            ts_pid_t *pmt = &p_sys->pid[p_program->i_pid];
             bool b_add = true;
+            for( int i_prg = 0; b_add && i_prg < pmt->psi->i_prg; i_prg++ )
+                if( pmt->psi->prg[i_prg]->i_number == p_program->i_number )
+                    b_add = false;
 
-            ValidateDVBMeta( p_demux, p_program->i_pid );
+            if( !b_add )
+                continue;
+        }
+        else
+        {
+            TAB_APPEND( p_sys->i_pmt, p_sys->pmt, pmt );
+        }
 
-            if( pmt->b_valid )
-            {
-                for( int i_prg = 0; i_prg < pmt->psi->i_prg; i_prg++ )
-                {
-                    if( pmt->psi->prg[i_prg]->i_number == p_program->i_number )
-                    {
-                        b_add = false;
-                        break;
-                    }
-                }
-            }
-            else
-            {
-                TAB_APPEND( p_sys->i_pmt, p_sys->pmt, pmt );
-            }
+        PIDInit( pmt, true, pat->psi );
+        ts_prg_psi_t *prg = pmt->psi->prg[pmt->psi->i_prg-1];
+        prg->handle = dvbpsi_AttachPMT(p_program->i_number, PMTCallBack, p_demux);
+        prg->i_number = p_program->i_number;
+        prg->i_pid_pmt = p_program->i_pid;
 
-            if( b_add )
-            {
-                PIDInit( pmt, true, pat->psi );
-                pmt->psi->prg[pmt->psi->i_prg-1]->handle =
-                    dvbpsi_AttachPMT( p_program->i_number,
-                                      (dvbpsi_pmt_callback)PMTCallBack,
-                                      p_demux );
-                pmt->psi->prg[pmt->psi->i_prg-1]->i_number =
-                    p_program->i_number;
-                pmt->psi->prg[pmt->psi->i_prg-1]->i_pid_pmt =
-                    p_program->i_pid;
-
-                /* Now select PID at access level */
-                if( ProgramIsSelected( p_demux, p_program->i_number ) )
-                {
-                    if( p_sys->i_current_program == 0 )
-                        p_sys->i_current_program = p_program->i_number;
+        /* Now select PID at access level */
+        if( ProgramIsSelected( p_demux, p_program->i_number ) )
+        {
+            if( p_sys->i_current_program == 0 )
+                p_sys->i_current_program = p_program->i_number;
 
-                    if( SetPIDFilter( p_demux, p_program->i_pid, true ) )
-                        p_sys->b_access_control = false;
-                }
-            }
+            if( SetPIDFilter( p_demux, p_program->i_pid, true ) )
+                p_sys->b_access_control = false;
         }
     }
     pat->psi->i_pat_version = p_pat->i_version;