]> git.sesse.net Git - casparcg/blobdiff - modules/ffmpeg/consumer/ffmpeg_consumer.cpp
git-svn-id: https://casparcg.svn.sourceforge.net/svnroot/casparcg/server/branches...
[casparcg] / modules / ffmpeg / consumer / ffmpeg_consumer.cpp
index 510b318fd40fa5f79fbb6f7941ceaa822220909a..6f8505a55a895663001a58bb737d368f5f34acb3 100644 (file)
  \r
 #include "../StdAfx.h"\r
 \r
+#include "../ffmpeg_error.h"\r
+#include "../producer/tbb_avcodec.h"\r
+\r
 #include "ffmpeg_consumer.h"\r
 \r
 #include <core/mixer/read_frame.h>\r
+#include <core/mixer/audio/audio_util.h>\r
+#include <core/consumer/frame_consumer.h>\r
+#include <core/video_format.h>\r
 \r
 #include <common/concurrency/executor.h>\r
 #include <common/utility/string.h>\r
 #include <common/env.h>\r
 \r
 #include <boost/thread/once.hpp>\r
+#include <boost/algorithm/string.hpp>\r
 \r
 #include <tbb/cache_aligned_allocator.h>\r
 #include <tbb/parallel_invoke.h>\r
@@ -50,202 +57,188 @@ extern "C"
 #pragma warning (pop)\r
 #endif\r
 \r
-namespace caspar { \r
+namespace caspar { namespace ffmpeg {\r
        \r
 struct ffmpeg_consumer : boost::noncopyable\r
 {              \r
-       std::string filename_;\r
+       const std::string                                               filename_;\r
+               \r
+       const std::shared_ptr<AVFormatContext>  oc_;\r
+       const core::video_format_desc                   format_desc_;\r
+       \r
+       executor                                                                executor_;\r
 \r
        // Audio\r
-       AVStream* audio_st_;\r
-       std::vector<unsigned char, tbb::cache_aligned_allocator<unsigned char>> audio_outbuf_;\r
+       std::shared_ptr<AVStream>                               audio_st_;\r
+       std::vector<uint8_t>                                    audio_outbuf_;\r
+\r
+       std::vector<int16_t>                                    audio_input_buffer_;\r
 \r
        // Video\r
-       AVStream* video_st_;\r
-       std::vector<uint8_t, tbb::cache_aligned_allocator<unsigned char>> picture_buf_;\r
+       std::shared_ptr<AVStream>                               video_st_;\r
+       std::vector<uint8_t>                                    video_outbuf_;\r
 \r
-       std::vector<unsigned char, tbb::cache_aligned_allocator<unsigned char>> video_outbuf_;\r
-       SwsContext* img_convert_ctx_;\r
+       std::vector<uint8_t>                                    picture_buf_;\r
+       std::shared_ptr<SwsContext>                             img_convert_ctx_;\r
        \r
-       AVOutputFormat* fmt_;\r
-       std::shared_ptr<AVFormatContext> oc_;\r
-       core::video_format_desc format_desc_;\r
-\r
-       std::vector<short, tbb::cache_aligned_allocator<short>> audio_input_buffer_;\r
-\r
-       boost::unique_future<void> active_;\r
-\r
-       executor executor_;\r
 public:\r
-       ffmpeg_consumer(const std::string& filename, const core::video_format_desc& format_desc)\r
-               : filename_(filename)\r
-               , audio_st_(nullptr)\r
-               , video_st_(nullptr)\r
-               , fmt_(nullptr)\r
-               , img_convert_ctx_(nullptr)\r
-               , video_outbuf_(1920*1080*4)\r
+       ffmpeg_consumer(const std::string& filename, const core::video_format_desc& format_desc, const std::string& codec, int bitrate)\r
+               : filename_(filename + ".mov")\r
+               , video_outbuf_(1920*1080*8)\r
                , audio_outbuf_(48000)\r
+               , oc_(avformat_alloc_context(), av_free)\r
                , format_desc_(format_desc)\r
-               , executor_(L"ffmpeg_consumer", true)\r
+               , executor_(print())\r
        {\r
-               active_ = executor_.begin_invoke([]{});\r
-\r
-               fmt_ = av_guess_format(nullptr, filename_.c_str(), nullptr);\r
-               if (!fmt_) \r
-               {\r
-                       CASPAR_LOG(info) << "Could not deduce output format from ffmpeg extension: using MPEG.";\r
-                       fmt_ = av_guess_format("mpeg", nullptr, nullptr);\r
-                       filename_ = filename_ + ".avi"; \r
-               }\r
-               if (!fmt_)\r
-                       BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("Could not find suitable output format"));\r
-               \r
-               oc_.reset(avformat_alloc_context(), av_free);\r
-               if (!oc_)\r
-                       BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("Memory error"));\r
-               std::copy_n(filename_.c_str(), filename_.size(), oc_->filename);\r
-\r
-               oc_->oformat = fmt_;\r
-               // To avoid mpeg buffer underflow (http://www.mail-archive.com/libav-user@mplayerhq.hu/msg00194.html)\r
-               oc_->preload = static_cast<int>(0.5*AV_TIME_BASE);\r
-               oc_->max_delay = static_cast<int>(0.7*AV_TIME_BASE);\r
-                       \r
-               //  Add the audio and video streams using the default format codecs     and initialize the codecs .\r
-               if (fmt_->video_codec != CODEC_ID_NONE)         \r
-                       video_st_ = add_video_stream(fmt_->video_codec);\r
+               executor_.set_capacity(25);\r
                \r
-               if (fmt_->audio_codec != CODEC_ID_NONE) \r
-                       audio_st_ = add_audio_stream(fmt_->audio_codec);        \r
-\r
-               // Set the output parameters (must be done even if no parameters).              \r
-               int errn = 0;\r
-               if ((errn = -av_set_parameters(oc_.get(), nullptr)) > 0)\r
-                       BOOST_THROW_EXCEPTION(\r
-                               file_read_error() << \r
-                               msg_info("Invalid output format parameters") <<\r
-                               boost::errinfo_api_function("avcodec_open") <<\r
-                               boost::errinfo_errno(errn) <<\r
-                               boost::errinfo_file_name(filename_));\r
+               oc_->oformat = av_guess_format(nullptr, filename_.c_str(), nullptr);\r
+               if (!oc_->oformat)\r
+                       BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("Could not find suitable output format."));\r
                \r
-               dump_format(oc_.get(), 0, filename_.c_str(), 1);\r
+               THROW_ON_ERROR2(av_set_parameters(oc_.get(), nullptr), "[ffmpeg_consumer]");\r
 \r
-               // Now that all the parameters are set, we can open the audio and\r
-               // video codecs and allocate the necessary encode buffers.\r
-               if (video_st_)\r
-                       open_video(video_st_);\r
+               strcpy_s(oc_->filename, filename_.c_str());\r
                \r
-               try\r
-               {\r
-                       if (audio_st_)\r
-                               open_audio(audio_st_);\r
-               }\r
-               catch(...)\r
-               {\r
-                       CASPAR_LOG_CURRENT_EXCEPTION();\r
-                       audio_st_ = nullptr;\r
-               }\r
\r
+               auto video_codec = avcodec_find_encoder_by_name(codec.c_str());\r
+               if(video_codec == nullptr)\r
+                       BOOST_THROW_EXCEPTION(invalid_argument() << arg_name_info(codec));\r
+\r
+               //  Add the audio and video streams using the default format codecs     and initialize the codecs .\r
+               video_st_ = add_video_stream(video_codec->id, bitrate);\r
+               audio_st_ = add_audio_stream();\r
+                               \r
+               dump_format(oc_.get(), 0, filename_.c_str(), 1);\r
+                \r
                // Open the output ffmpeg, if needed.\r
-               if (!(fmt_->flags & AVFMT_NOFILE)) \r
-               {\r
-                       int errn = 0;\r
-                       if ((errn = -url_fopen(&oc_->pb, filename_.c_str(), URL_WRONLY)) > 0) \r
-                               BOOST_THROW_EXCEPTION(\r
-                                       file_not_found() << \r
-                                       msg_info("Could not open file") <<\r
-                                       boost::errinfo_api_function("url_fopen") <<\r
-                                       boost::errinfo_errno(errn) <<\r
-                                       boost::errinfo_file_name(filename_));\r
-               }\r
-               \r
-               av_write_header(oc_.get()); // write the stream header, if any \r
+               if (!(oc_->oformat->flags & AVFMT_NOFILE)) \r
+                       THROW_ON_ERROR2(avio_open(&oc_->pb, filename_.c_str(), URL_WRONLY), "[ffmpeg_consumer]");\r
+                               \r
+               THROW_ON_ERROR2(av_write_header(oc_.get()), "[ffmpeg_consumer]");\r
 \r
-               CASPAR_LOG(info) << print() << L" Successfully initialized.";   \r
+               CASPAR_LOG(info) << print() << L" Successfully Initialized.";   \r
        }\r
 \r
        ~ffmpeg_consumer()\r
        {    \r
-               executor_.invoke([]{});\r
                executor_.stop();\r
-\r
-               av_write_trailer(oc_.get());\r
-\r
-               // Close each codec.\r
-               if (video_st_)          \r
-                       avcodec_close(video_st_->codec);\r
+               executor_.join();\r
                \r
-               if (audio_st_)\r
-                       avcodec_close(audio_st_->codec);\r
-                               \r
-               // Free the streams.\r
-               for(size_t i = 0; i < oc_->nb_streams; ++i) \r
+               try\r
                {\r
-                       av_freep(&oc_->streams[i]->codec);\r
-                       av_freep(&oc_->streams[i]);\r
+                       THROW_ON_ERROR2(av_write_trailer(oc_.get()), "[ffmpeg_consumer]");\r
+               \r
+                       audio_st_.reset();\r
+                       video_st_.reset();\r
+                         \r
+                       for(size_t i = 0; i < oc_->nb_streams; i++) \r
+                       {\r
+                               av_freep(&oc_->streams[i]->codec);\r
+                               av_freep(&oc_->streams[i]);\r
+                       }\r
+\r
+                       if (!(oc_->oformat->flags & AVFMT_NOFILE)) \r
+                               THROW_ON_ERROR2(avio_close(oc_->pb), "[ffmpeg_consumer]"); // Close the output ffmpeg.\r
+\r
+                       CASPAR_LOG(info) << print() << L" Successfully Uninitialized."; \r
+               }\r
+               catch(...)\r
+               {\r
+                       CASPAR_LOG_CURRENT_EXCEPTION();\r
                }\r
 \r
-               if (!(fmt_->flags & AVFMT_NOFILE)) \r
-                       url_fclose(oc_->pb); // Close the output ffmpeg.\r
        }\r
-               \r
+                       \r
        std::wstring print() const\r
        {\r
                return L"ffmpeg[" + widen(filename_) + L"]";\r
        }\r
 \r
-       AVStream* add_video_stream(enum CodecID codec_id)\r
+       std::shared_ptr<AVStream> add_video_stream(enum CodecID codec_id, int bitrate)\r
        { \r
                auto st = av_new_stream(oc_.get(), 0);\r
                if (!st) \r
-                       BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("Could not alloc stream"));\r
\r
-               auto c = st->codec;\r
-               c->codec_id = codec_id;\r
-               c->codec_type = AVMEDIA_TYPE_VIDEO;\r
\r
-               // Put sample parameters.\r
-               c->bit_rate = static_cast<int>(static_cast<double>(format_desc_.size)*format_desc_.fps*0.1326);\r
-               c->width = format_desc_.width;\r
-               c->height = format_desc_.height;\r
-               c->time_base.den = static_cast<int>(format_desc_.fps);\r
-               c->time_base.num = 1;\r
-               c->pix_fmt = c->pix_fmt == -1 ? PIX_FMT_YUV420P : c->pix_fmt;\r
-\r
-               // Some formats want stream headers to be separate.\r
+               {\r
+                       BOOST_THROW_EXCEPTION(caspar_exception() \r
+                               << msg_info("Could not alloc video-stream")                             \r
+                               << boost::errinfo_api_function("av_new_stream"));\r
+               }\r
+               \r
+               st->codec->codec_id                     = codec_id;\r
+               st->codec->codec_type           = AVMEDIA_TYPE_VIDEO;\r
+               st->codec->width                        = format_desc_.width;\r
+               st->codec->height                       = format_desc_.height;\r
+               st->codec->time_base.den        = format_desc_.time_scale;\r
+               st->codec->time_base.num        = format_desc_.duration;\r
+\r
+               if(st->codec->codec_id == CODEC_ID_PRORES)\r
+               {                       \r
+                       st->codec->bit_rate     = bitrate > 0 ? bitrate : format_desc_.width < 1280 ? 42*1000000 : 147*1000000;\r
+                       st->codec->pix_fmt      = PIX_FMT_YUV422P10;\r
+               }\r
+               else if(st->codec->codec_id == CODEC_ID_DNXHD)\r
+               {\r
+                       st->codec->bit_rate     = bitrate > 0 ? bitrate : 145*1000000;\r
+                       st->codec->width        = std::min<size_t>(1280, format_desc_.width);\r
+                       st->codec->height       = std::min<size_t>(720, format_desc_.height);\r
+                       st->codec->pix_fmt      = PIX_FMT_YUV422P;\r
+               }\r
+               else\r
+                       BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("unsupported codec"));\r
+               \r
                if(oc_->oformat->flags & AVFMT_GLOBALHEADER)\r
-                       c->flags |= CODEC_FLAG_GLOBAL_HEADER;\r
\r
-               return st;\r
-       }\r
-        \r
-       void open_video(AVStream* st)\r
-       { \r
-               auto c = st->codec;\r
\r
-               auto codec = avcodec_find_encoder(c->codec_id);\r
+                       st->codec->flags |= CODEC_FLAG_GLOBAL_HEADER;\r
+\r
+               auto codec = avcodec_find_encoder(st->codec->codec_id);\r
                if (!codec)\r
                        BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("codec not found"));\r
+\r
+               THROW_ON_ERROR2(tbb_avcodec_open(st->codec, codec), "[ffmpeg_consumer]");\r
+\r
+               return std::shared_ptr<AVStream>(st, [](AVStream* st)\r
+               {\r
+                       tbb_avcodec_close(st->codec);\r
+               });\r
+       }\r
+       \r
+       std::shared_ptr<AVStream> add_audio_stream()\r
+       {\r
+               auto st = av_new_stream(oc_.get(), 1);\r
+               if (!st) \r
+               {\r
+                       BOOST_THROW_EXCEPTION(caspar_exception() \r
+                               << msg_info("Could not alloc audio-stream")                             \r
+                               << boost::errinfo_api_function("av_new_stream"));\r
+               }\r
+\r
+               st->codec->codec_id             = CODEC_ID_PCM_S16LE;\r
+               st->codec->codec_type   = AVMEDIA_TYPE_AUDIO;\r
+               st->codec->sample_rate  = 48000;\r
+               st->codec->channels             = 2;\r
+               st->codec->sample_fmt   = SAMPLE_FMT_S16;\r
+               \r
+               if(oc_->oformat->flags & AVFMT_GLOBALHEADER)\r
+                       st->codec->flags |= CODEC_FLAG_GLOBAL_HEADER;\r
                \r
-               int errn = 0;\r
-               if ((errn = -avcodec_open(c, codec)) > 0)\r
-                       BOOST_THROW_EXCEPTION(\r
-                               file_read_error() << \r
-                               msg_info("Could not open video codec.") <<\r
-                               boost::errinfo_api_function("avcodec_open") <<\r
-                               boost::errinfo_errno(errn) <<\r
-                               boost::errinfo_file_name(filename_));            \r
+               auto codec = avcodec_find_encoder(st->codec->codec_id);\r
+               if (!codec)\r
+                       BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("codec not found"));\r
+\r
+               THROW_ON_ERROR2(avcodec_open(st->codec, codec), "[ffmpeg_consumer]");\r
+\r
+               return std::shared_ptr<AVStream>(st, [](AVStream* st)\r
+               {\r
+                       avcodec_close(st->codec);\r
+               });\r
        }\r
   \r
-       void encode_video_frame(const safe_ptr<const core::read_frame>& frame)\r
+       void encode_video_frame(const safe_ptr<core::read_frame>& frame)\r
        { \r
-               if(!video_st_)\r
-                       return;\r
-\r
-               AVCodecContext* c = video_st_->codec;\r
+               auto c = video_st_->codec;\r
  \r
-               if (img_convert_ctx_ == nullptr\r
+               if(!img_convert_ctx_\r
                {\r
-                       img_convert_ctx_ = sws_getContext(format_desc_.width, format_desc_.height, PIX_FMT_BGRA, c->width, c->height, c->pix_fmt, SWS_BICUBIC, nullptr, nullptr, nullptr);\r
+                       img_convert_ctx_.reset(sws_getContext(format_desc_.width, format_desc_.height, PIX_FMT_BGRA, c->width, c->height, c->pix_fmt, SWS_BICUBIC, nullptr, nullptr, nullptr), sws_freeContext);\r
                        if (img_convert_ctx_ == nullptr) \r
                                BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("Cannot initialize the conversion context"));\r
                }\r
@@ -254,180 +247,108 @@ public:
                avpicture_fill(reinterpret_cast<AVPicture*>(av_frame.get()), const_cast<uint8_t*>(frame->image_data().begin()), PIX_FMT_BGRA, format_desc_.width, format_desc_.height);\r
                                \r
                std::shared_ptr<AVFrame> local_av_frame(avcodec_alloc_frame(), av_free);\r
+               local_av_frame->interlaced_frame = format_desc_.field_mode != core::field_mode::progressive;\r
+               local_av_frame->top_field_first  = format_desc_.field_mode == core::field_mode::upper;\r
+\r
                picture_buf_.resize(avpicture_get_size(c->pix_fmt, format_desc_.width, format_desc_.height));\r
                avpicture_fill(reinterpret_cast<AVPicture*>(local_av_frame.get()), picture_buf_.data(), c->pix_fmt, format_desc_.width, format_desc_.height);\r
 \r
-               sws_scale(img_convert_ctx_, av_frame->data, av_frame->linesize, 0, c->height, local_av_frame->data, local_av_frame->linesize);\r
-                               \r
-               int ret = avcodec_encode_video(c, video_outbuf_.data(), video_outbuf_.size(), local_av_frame.get());\r
+               sws_scale(img_convert_ctx_.get(), av_frame->data, av_frame->linesize, 0, c->height, local_av_frame->data, local_av_frame->linesize);\r
                                \r
-               int errn = -ret;\r
-               if (errn > 0) \r
-                       BOOST_THROW_EXCEPTION(\r
-                               invalid_operation() << \r
-                               msg_info("Could not encode video frame.") <<\r
-                               boost::errinfo_api_function("avcodec_encode_video") <<\r
-                               boost::errinfo_errno(errn) <<\r
-                               boost::errinfo_file_name(filename_));\r
-\r
-               auto out_size = ret;\r
-               AVPacket pkt;\r
-               av_init_packet(&pkt);\r
-               pkt.size = out_size;\r
-\r
-               // If zero size, it means the image was buffered.\r
-               if (out_size > 0) \r
-               { \r
+               int out_size = THROW_ON_ERROR2(avcodec_encode_video(c, video_outbuf_.data(), video_outbuf_.size(), local_av_frame.get()), "[ffmpeg_consumer]");\r
+               if(out_size > 0)\r
+               {\r
+                       AVPacket pkt;\r
+                       av_init_packet(&pkt);\r
\r
                        if (c->coded_frame->pts != AV_NOPTS_VALUE)\r
-                               pkt.pts = av_rescale_q(c->coded_frame->pts, c->time_base, video_st_->time_base);\r
+                               pkt.pts= av_rescale_q(c->coded_frame->pts, c->time_base, video_st_->time_base);\r
+\r
                        if(c->coded_frame->key_frame)\r
                                pkt.flags |= AV_PKT_FLAG_KEY;\r
 \r
-                       pkt.stream_index = video_st_->index;\r
-                       pkt.data = video_outbuf_.data();\r
-\r
-                       if (av_interleaved_write_frame(oc_.get(), &pkt) != 0)\r
-                               BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("Error while writing video frame"));\r
-               }               \r
-       }\r
-\r
-       AVStream* add_audio_stream(enum CodecID codec_id)\r
-       {\r
-               audio_st_ = av_new_stream(oc_.get(), 1);\r
-               if (!audio_st_)\r
-                       BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("Could not alloc stream"));\r
-\r
-               auto c = audio_st_->codec;\r
-               c->codec_id = codec_id;\r
-               c->codec_type = AVMEDIA_TYPE_AUDIO;\r
-\r
-               // Put sample parameters.\r
-               c->bit_rate = 192000;\r
-               c->sample_rate = 48000;\r
-               c->channels = 2;\r
-\r
-               // Some formats want stream headers to be separate.\r
-               if(oc_->oformat->flags & AVFMT_GLOBALHEADER)\r
-                       c->flags |= CODEC_FLAG_GLOBAL_HEADER;\r
-\r
-               return audio_st_;\r
+                       pkt.stream_index        = video_st_->index;\r
+                       pkt.data                        = video_outbuf_.data();\r
+                       pkt.size                        = out_size;\r
\r
+                       THROW_ON_ERROR2(av_interleaved_write_frame(oc_.get(), &pkt), L"[ffmpeg_consumer]");\r
+               }       \r
        }\r
-\r
-       void open_audio(AVStream* st)\r
-       {\r
-               auto c = st->codec;\r
-\r
-               // Find the audio encoder.\r
-               auto codec = avcodec_find_encoder(c->codec_id);\r
-               if (!codec) \r
-                       BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("codec not found"));\r
                \r
-               // Open it.\r
-               int errn = 0;\r
-               if ((errn = -avcodec_open(c, codec)) > 0)\r
-                       BOOST_THROW_EXCEPTION(\r
-                               file_read_error() << \r
-                               msg_info("Could not open audio codec") <<\r
-                               boost::errinfo_api_function("avcodec_open") <<\r
-                               boost::errinfo_errno(errn) <<\r
-                               boost::errinfo_file_name(filename_));\r
-       }\r
-       \r
-       void encode_audio_frame(const safe_ptr<const core::read_frame>& frame)\r
-       {       \r
-               if(!frame->audio_data().empty())\r
-                       audio_input_buffer_.insert(audio_input_buffer_.end(), frame->audio_data().begin(), frame->audio_data().end());\r
-               else\r
-                       audio_input_buffer_.insert(audio_input_buffer_.end(), 3840, 0);\r
-\r
-               while(encode_audio_packet()){}\r
-       }\r
-\r
-       bool encode_audio_packet()\r
-       {               \r
-               if(!audio_st_)\r
-                       return false;\r
-\r
+       void encode_audio_frame(const safe_ptr<core::read_frame>& frame)\r
+       {                       \r
                auto c = audio_st_->codec;\r
 \r
-               auto frame_bytes = c->frame_size * 2 * 2; // samples per frame * 2 channels * 2 bytes per sample\r
-               if(static_cast<int>(audio_input_buffer_.size()) < frame_bytes/2)\r
-                       return false;\r
+               auto audio_data = core::audio_32_to_16(frame->audio_data());\r
 \r
                AVPacket pkt;\r
                av_init_packet(&pkt);\r
                \r
-               int ret = avcodec_encode_audio(c, audio_outbuf_.data(), audio_outbuf_.size(), audio_input_buffer_.data());\r
-               \r
-               int errn = -ret;\r
-               if (errn > 0) \r
-                       BOOST_THROW_EXCEPTION(\r
-                               invalid_operation() << \r
-                               msg_info("Could not encode audio samples.") <<\r
-                               boost::errinfo_api_function("avcodec_encode_audio") <<\r
-                               boost::errinfo_errno(errn) <<\r
-                               boost::errinfo_file_name(filename_));\r
-\r
-               pkt.size = ret;\r
-               audio_input_buffer_ = std::vector<short, tbb::cache_aligned_allocator<short>>(audio_input_buffer_.begin() + frame_bytes/2, audio_input_buffer_.end());\r
-\r
                if (c->coded_frame && c->coded_frame->pts != AV_NOPTS_VALUE)\r
                        pkt.pts = av_rescale_q(c->coded_frame->pts, c->time_base, audio_st_->time_base);\r
-               pkt.flags |= AV_PKT_FLAG_KEY;\r
+\r
+               pkt.flags                |= AV_PKT_FLAG_KEY;\r
                pkt.stream_index = audio_st_->index;\r
-               pkt.data = audio_outbuf_.data();\r
+               pkt.size                 = audio_data.size()*2;\r
+               pkt.data                 = reinterpret_cast<uint8_t*>(audio_data.data());\r
                \r
-               if (av_interleaved_write_frame(oc_.get(), &pkt) != 0)\r
-                       BOOST_THROW_EXCEPTION(caspar_exception() << msg_info("Error while writing audio frame"));\r
-\r
-               return true;\r
+               THROW_ON_ERROR2(av_interleaved_write_frame(oc_.get(), &pkt), L"[ffmpeg_consumer]");\r
        }\r
-        \r
-       void send(const safe_ptr<const core::read_frame>& frame)\r
+                \r
+       void send(const safe_ptr<core::read_frame>& frame)\r
        {\r
-               active_.get();\r
-               active_ = executor_.begin_invoke([=]\r
+               executor_.begin_invoke([=]\r
                {                               \r
-                       auto my_frame = frame;\r
-                       encode_video_frame(my_frame);\r
-                       encode_audio_frame(my_frame);\r
+                       encode_video_frame(frame);\r
+                       encode_audio_frame(frame);\r
                });\r
        }\r
-\r
-       size_t buffer_depth() const { return 1; }\r
 };\r
 \r
 struct ffmpeg_consumer_proxy : public core::frame_consumer\r
 {\r
-       const std::wstring filename_;\r
-       const bool key_only_;\r
+       const std::wstring      filename_;\r
+       const bool                      key_only_;\r
+       const std::string       codec_;\r
+       const int                       bitrate_;\r
 \r
        std::unique_ptr<ffmpeg_consumer> consumer_;\r
 \r
 public:\r
 \r
-       ffmpeg_consumer_proxy(const std::wstring& filename, bool key_only)\r
+       ffmpeg_consumer_proxy(const std::wstring& filename, bool key_only, const std::string codec, int bitrate)\r
                : filename_(filename)\r
-               , key_only_(key_only){}\r
+               , key_only_(key_only)\r
+               , codec_(boost::to_lower_copy(codec))\r
+               , bitrate_(bitrate)\r
+       {\r
+       }\r
        \r
-       virtual void initialize(const core::video_format_desc& format_desc)\r
+       virtual void initialize(const core::video_format_desc& format_desc, int, int)\r
        {\r
-               consumer_.reset(new ffmpeg_consumer(narrow(filename_), format_desc));\r
+               consumer_.reset();\r
+               consumer_.reset(new ffmpeg_consumer(narrow(filename_), format_desc, codec_, bitrate_));\r
        }\r
        \r
-       virtual void send(const safe_ptr<const core::read_frame>& frame)\r
+       virtual bool send(const safe_ptr<core::read_frame>& frame) override\r
        {\r
                consumer_->send(frame);\r
+               return true;\r
        }\r
        \r
-       virtual std::wstring print() const\r
+       virtual std::wstring print() const override\r
+       {\r
+               return consumer_ ? consumer_->print() : L"[ffmpeg_consumer]";\r
+       }\r
+               \r
+       virtual bool has_synchronization_clock() const override\r
        {\r
-               return consumer_->print();\r
+               return false;\r
        }\r
 \r
-       virtual bool key_only() const\r
+       virtual size_t buffer_depth() const override\r
        {\r
-               return key_only_;\r
+               return 1;\r
        }\r
 };     \r
 \r
@@ -440,15 +361,27 @@ safe_ptr<core::frame_consumer> create_ffmpeg_consumer(const std::vector<std::wst
        boost::filesystem::remove(boost::filesystem::wpath(env::media_folder() + params[1])); // Delete the file if it exists\r
        bool key_only = std::find(params.begin(), params.end(), L"KEY_ONLY") != params.end();\r
 \r
-       return make_safe<ffmpeg_consumer_proxy>(env::media_folder() + params[1], key_only);\r
+       std::string codec = "dnxhd";\r
+       auto codec_it = std::find(params.begin(), params.end(), L"CODEC");\r
+       if(codec_it++ != params.end())\r
+               codec = narrow(*codec_it);\r
+\r
+       int bitrate = 0;        \r
+       auto bitrate_it = std::find(params.begin(), params.end(), L"BITRATE");\r
+       if(bitrate_it++ != params.end())\r
+               bitrate = boost::lexical_cast<int>(*codec_it);\r
+\r
+       return make_safe<ffmpeg_consumer_proxy>(env::media_folder() + params[1], key_only, codec, bitrate);\r
 }\r
 \r
 safe_ptr<core::frame_consumer> create_ffmpeg_consumer(const boost::property_tree::ptree& ptree)\r
 {\r
-       std::string filename = ptree.get<std::string>("filename");\r
-       bool key_only            = ptree.get("key-only", false);\r
+       std::string filename = ptree.get<std::string>("path");\r
+       auto key_only            = ptree.get("key-only", false);\r
+       auto codec                       = ptree.get("codec", "dnxhd");\r
+       auto bitrate             = ptree.get("bitrate", 0);\r
        \r
-       return make_safe<ffmpeg_consumer_proxy>(env::media_folder() + widen(filename), key_only);\r
+       return make_safe<ffmpeg_consumer_proxy>(env::media_folder() + widen(filename), key_only, codec, bitrate);\r
 }\r
 \r
-}\r
+}}\r