]> git.sesse.net Git - vlc/blobdiff - modules/gui/macosx/intf.m
modules/macosx/playlist.m: Remove code that shouldn't be here, to re-enable services...
[vlc] / modules / gui / macosx / intf.m
index 4a60444472dafb48a8693d647ddc0cd08cfeb7d8..1e17a48b36ecabf0277da6bb779525cb325cf8d0 100644 (file)
@@ -7,13 +7,13 @@
  * Authors: Jon Lech Johansen <jon-vl@nanocrew.net>
  *          Christophe Massiot <massiot@via.ecp.fr>
  *          Derk-Jan Hartman <hartman at videolan.org>
- *          Felix K\9fhne <fkuehne at videolan dot org>
+ *          Felix Paul Kühne <fkuehne at videolan dot org>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  *****************************************************************************/
 static void Run ( intf_thread_t *p_intf );
 
+/* Quick hack */
+/*****************************************************************************
+ * VLCApplication implementation (this hack is really disgusting now,
+ *                                feel free to fix.)
+ *****************************************************************************/
+@interface VLCApplication : NSApplication
+{
+   libvlc_int_t *o_libvlc;
+}
+- (void)setVLC: (libvlc_int_t *)p_libvlc;
+@end
+
+
+@implementation VLCApplication
+- (void)setVLC: (libvlc_int_t *) p_libvlc
+{
+    o_libvlc = p_libvlc;
+}
+- (void)terminate: (id)sender
+{
+    vlc_object_kill( o_libvlc );
+    [super terminate: sender];
+}
+@end
+
 /*****************************************************************************
  * OpenIntf: initialize interface
  *****************************************************************************/
@@ -74,16 +99,11 @@ int E_(OpenIntf) ( vlc_object_t *p_this )
 
     p_intf->p_sys->o_pool = [[NSAutoreleasePool alloc] init];
 
-    /* Put Cocoa into multithread mode as soon as possible.
-     * http://developer.apple.com/techpubs/macosx/Cocoa/
-     * TasksAndConcepts/ProgrammingTopics/Multithreading/index.html
-     * This thread does absolutely nothing at all. */
-    //[NSThread detachNewThreadSelector:@selector(self) toTarget:[NSString string] withObject:nil];
-
     p_intf->p_sys->o_sendport = [[NSPort port] retain];
     p_intf->p_sys->p_sub = msg_Subscribe( p_intf, MSG_QUEUE_NORMAL );
     p_intf->b_play = VLC_TRUE;
     p_intf->pf_run = Run;
+    p_intf->b_should_run_on_first_thread = VLC_TRUE;
 
     return( 0 );
 }
@@ -125,6 +145,14 @@ static void Run( intf_thread_t *p_intf )
     sigaddset( &set, SIGTERM );
     pthread_sigmask( SIG_UNBLOCK, &set, NULL );
 
+    NSAutoreleasePool * o_pool = [[NSAutoreleasePool alloc] init];
+
+    /* Install a jmpbuffer to where we can go back before the NSApp exit
+     * see applicationWillTerminate: */
+    /* We need that code to run on main thread */
+    [VLCApplication sharedApplication];
+    [NSApp setVLC: p_intf->p_libvlc];
+
     [[VLCMain sharedInstance] setIntf: p_intf];
     [NSBundle loadNibNamed: @"MainMenu" owner: NSApp];
 
@@ -132,6 +160,8 @@ static void Run( intf_thread_t *p_intf )
      * see applicationWillTerminate: */
     if(setjmp(jmpbuffer) == 0)
         [NSApp run];
+
+    [o_pool release];
 }
 
 int ExecuteOnMainThread( id target, SEL sel, void * p_arg )
@@ -249,10 +279,10 @@ static int InteractCallback( vlc_object_t *p_this, const char *psz_variable,
     VLCMain *interface = (VLCMain *)param;
     interaction_dialog_t *p_dialog = (interaction_dialog_t *)(new_val.p_address);
     NSValue *o_value = [NSValue valueWithPointer:p_dialog];
-    
     [[NSNotificationCenter defaultCenter] postNotificationName: @"VLCNewInteractionEventNotification" object:[interface getInteractionList]
      userInfo:[NSDictionary dictionaryWithObject:o_value forKey:@"VLCDialogPointer"]];
-    
     [o_pool release];
     return VLC_SUCCESS;
 }
@@ -363,12 +393,14 @@ static VLCMain *_o_sharedMainInstance = nil;
     o_embedded_list = [[VLCEmbeddedList alloc] init];
     o_interaction_list = [[VLCInteractionList alloc] init];
     o_sfilters = nil;
-    o_update = [[VLCUpdate alloc] init];
+#ifdef UPDATE_CHECK
+    //FIXME o_update = [[VLCUpdate alloc] init];
+#endif
 
     i_lastShownVolume = -1;
 
     o_remote = [[AppleRemote alloc] init];
-       [o_remote setClickCountEnabledButtons: kRemoteButtonPlay];
+    [o_remote setClickCountEnabledButtons: kRemoteButtonPlay];
     [o_remote setDelegate: _o_sharedMainInstance];
 
     o_eyetv = [[VLCEyeTVController alloc] init];
@@ -464,7 +496,8 @@ static VLCMain *_o_sharedMainInstance = nil;
     [self setSubmenusEnabled: FALSE];
     [self manageVolumeSlider];
     [o_window setDelegate: self];
-    
+    b_restore_size = false;
     if( [o_window frame].size.height <= 200 )
     {
         b_small_window = YES;
@@ -499,7 +532,7 @@ static VLCMain *_o_sharedMainInstance = nil;
     var_AddCallback( p_playlist, "intf-show", ShowController, self);
 
     vlc_object_release( p_playlist );
-    
     var_Create( p_intf, "interaction", VLC_VAR_ADDRESS );
     var_AddCallback( p_intf, "interaction", InteractCallback, self );
     p_intf->b_interaction = VLC_TRUE;
@@ -511,7 +544,7 @@ static VLCMain *_o_sharedMainInstance = nil;
                                              selector: @selector(refreshVoutDeviceMenu:)
                                                  name: NSApplicationDidChangeScreenParametersNotification
                                                object: nil];
-    
     nib_main_loaded = TRUE;
 }
 
@@ -534,7 +567,7 @@ static VLCMain *_o_sharedMainInstance = nil;
 
     /* messages panel */
     [o_msgs_panel setTitle: _NS("Messages")];
-    [o_msgs_btn_crashlog setTitle: _NS("Open CrashLog")];
+    [o_msgs_btn_crashlog setTitle: _NS("Open CrashLog...")];
 
     /* main menu */
     [o_mi_about setTitle: [_NS("About VLC media player") \
@@ -624,25 +657,25 @@ static VLCMain *_o_sharedMainInstance = nil;
     [o_mu_window setTitle: _NS("Window")];
     [o_mi_minimize setTitle: _NS("Minimize Window")];
     [o_mi_close_window setTitle: _NS("Close Window")];
-    [o_mi_controller setTitle: _NS("Controller")];
-    [o_mi_equalizer setTitle: _NS("Equalizer")];
-    [o_mi_extended setTitle: _NS("Extended Controls")];
-    [o_mi_bookmarks setTitle: _NS("Bookmarks")];
-    [o_mi_playlist setTitle: _NS("Playlist")];
-    [o_mi_info setTitle: _NS("Information")];
-    [o_mi_messages setTitle: _NS("Messages")];
-    [o_mi_errorsAndWarnings setTitle: _NS("Errors and Warnings")];
+    [o_mi_controller setTitle: _NS("Controller...")];
+    [o_mi_equalizer setTitle: _NS("Equalizer...")];
+    [o_mi_extended setTitle: _NS("Extended Controls...")];
+    [o_mi_bookmarks setTitle: _NS("Bookmarks...")];
+    [o_mi_playlist setTitle: _NS("Playlist...")];
+    [o_mi_info setTitle: _NS("Media Information...")];
+    [o_mi_messages setTitle: _NS("Messages...")];
+    [o_mi_errorsAndWarnings setTitle: _NS("Errors and Warnings...")];
 
     [o_mi_bring_atf setTitle: _NS("Bring All to Front")];
 
     [o_mu_help setTitle: _NS("Help")];
-    [o_mi_readme setTitle: _NS("ReadMe...")];
-    [o_mi_documentation setTitle: _NS("Online Documentation")];
-    [o_mi_reportabug setTitle: _NS("Report a Bug")];
-    [o_mi_website setTitle: _NS("VideoLAN Website")];
+    [o_mi_help setTitle: _NS("VLC media player Help...")];
+    [o_mi_readme setTitle: _NS("ReadMe / FAQ...")];
     [o_mi_license setTitle: _NS("License")];
-    [o_mi_donation setTitle: _NS("Make a donation")];
-    [o_mi_forum setTitle: _NS("Online Forum")];
+    [o_mi_documentation setTitle: _NS("Online Documentation...")];
+    [o_mi_website setTitle: _NS("VideoLAN Website...")];
+    [o_mi_donation setTitle: _NS("Make a donation...")];
+    [o_mi_forum setTitle: _NS("Online Forum...")];
 
     /* dock menu */
     [o_dmi_play setTitle: _NS("Play")];
@@ -650,7 +683,7 @@ static VLCMain *_o_sharedMainInstance = nil;
     [o_dmi_next setTitle: _NS("Next")];
     [o_dmi_previous setTitle: _NS("Previous")];
     [o_dmi_mute setTitle: _NS("Mute")];
-    
     /* vout menu */
     [o_vmi_play setTitle: _NS("Play")];
     [o_vmi_stop setTitle: _NS("Stop")];
@@ -662,7 +695,7 @@ static VLCMain *_o_sharedMainInstance = nil;
     [o_vmi_fullscreen setTitle: _NS("Fullscreen")];
     [o_vmi_snapshot setTitle: _NS("Snapshot")];
 
-    [o_info_window setTitle: _NS("Information")];
+    [o_info_window setTitle: _NS("Media Information")];
 }
 
 - (void)applicationWillFinishLaunching:(NSNotification *)o_notification
@@ -690,6 +723,21 @@ static VLCMain *_o_sharedMainInstance = nil;
     [o_controls setupVarMenuItem: o_mi_add_intf target: (vlc_object_t *)p_intf
         var: "intf-add" selector: @selector(toggleVar:)];
 
+    /* check whether the user runs a valid version of OSX; alert is auto-released */
+    if( MACOS_VERSION < 10.4f )
+    {
+        NSAlert *ourAlert;
+        int i_returnValue;
+        ourAlert = [NSAlert alertWithMessageText: _NS("Your version of Mac OS X is not supported")
+                        defaultButton: _NS("Quit")
+                      alternateButton: NULL
+                          otherButton: NULL
+            informativeTextWithFormat: _NS("VLC media player requires Mac OS X 10.4 or higher.")];
+        [ourAlert setAlertStyle: NSCriticalAlertStyle];
+        i_returnValue = [ourAlert runModal];
+        [NSApp terminate: self];
+    }
+
     vlc_thread_set_priority( p_intf, VLC_THREAD_PRIORITY_LOW );
 }
 
@@ -705,7 +753,7 @@ static VLCMain *_o_sharedMainInstance = nil;
     return( TRUE );
 }
 
-- (NSString *)localizedString:(char *)psz
+- (NSString *)localizedString:(const char *)psz
 {
     NSString * o_str = nil;
 
@@ -730,7 +778,7 @@ static VLCMain *_o_sharedMainInstance = nil;
 
 /* When user click in the Dock icon our double click in the finder */
 - (BOOL)applicationShouldHandleReopen:(NSApplication *)theApplication hasVisibleWindows:(BOOL)hasVisibleWindows
-{      
+{    
     if (!hasVisibleWindows)
         [o_window makeKeyAndOrderFront:self];
 
@@ -739,10 +787,19 @@ static VLCMain *_o_sharedMainInstance = nil;
 
 - (void)applicationDidFinishLaunching:(NSNotification *)aNotification
 {
+#ifdef UPDATE_CHECK
     /* Check for update silently on startup */
     if ( !nib_update_loaded )
         nib_update_loaded = [NSBundle loadNibNamed:@"Update" owner:self];
-    [NSThread detachNewThreadSelector:@selector(checkForUpdate) toTarget:o_update withObject:NULL];
+
+    // FIXME
+    //if([o_update shouldCheckForUpdate])
+    //    [NSThread detachNewThreadSelector:@selector(checkForUpdate) toTarget:o_update withObject:NULL];
+#endif
+
+    /* Handle sleep notification */
+    [[[NSWorkspace sharedWorkspace] notificationCenter] addObserver:self selector:@selector(computerWillSleep:)
+           name:NSWorkspaceWillSleepNotification object:nil];
 }
 
 /* Listen to the remote in exclusive mode, only when VLC is the active
@@ -756,15 +813,27 @@ static VLCMain *_o_sharedMainInstance = nil;
     [o_remote stopListening: self];
 }
 
+/* Triggered when the computer goes to sleep */
+- (void)computerWillSleep: (NSNotification *)notification
+{
+    /* Pause */
+    if ( p_intf->p_sys->i_play_status == PLAYING_S )
+    {
+        vlc_value_t val;
+        val.i_int = config_GetInt( p_intf, "key-play-pause" );
+        var_Set( p_intf->p_libvlc, "key-pressed", val );
+    }
+}
+
 /* Helper method for the remote control interface in order to trigger forward/backward and volume
    increase/decrease as long as the user holds the left/right, plus/minus button */
-- (void) executeHoldActionForRemoteButton: (NSNumber*) buttonIdentifierNumber 
+- (void) executeHoldActionForRemoteButton: (NSNumber*) buttonIdentifierNumber
 {
-    if (b_remote_button_hold) 
+    if (b_remote_button_hold)
     {
-        switch([buttonIdentifierNumber intValue]) 
+        switch([buttonIdentifierNumber intValue])
         {
-            case kRemoteButtonRight_Hold:       
+            case kRemoteButtonRight_Hold:
                   [o_controls forward: self];
             break;
             case kRemoteButtonLeft_Hold:
@@ -775,22 +844,22 @@ static VLCMain *_o_sharedMainInstance = nil;
             break;
             case kRemoteButtonVolume_Minus_Hold:
                 [o_controls volumeDown: self];
-            break;              
+            break;
         }
-        if (b_remote_button_hold) 
+        if (b_remote_button_hold)
         {
             /* trigger event */
-            [self performSelector:@selector(executeHoldActionForRemoteButton:) 
+            [self performSelector:@selector(executeHoldActionForRemoteButton:)
                          withObject:buttonIdentifierNumber
-                         afterDelay:0.25];         
+                         afterDelay:0.25];
         }
     }
 }
 
 /* Apple Remote callback */
-- (void) appleRemoteButton: (AppleRemoteEventIdentifier)buttonIdentifier 
-               pressedDown: (BOOL) pressedDown 
-                clickCount: (unsigned int) count 
+- (void) appleRemoteButton: (AppleRemoteEventIdentifier)buttonIdentifier
+               pressedDown: (BOOL) pressedDown
+                clickCount: (unsigned int) count
 {
     switch( buttonIdentifier )
     {
@@ -799,7 +868,7 @@ static VLCMain *_o_sharedMainInstance = nil;
                 [o_controls toogleFullscreen:self];
             } else {
                 [o_controls play: self];
-            }            
+            }
             break;
         case kRemoteButtonVolume_Plus:
             [o_controls volumeUp: self];
@@ -820,9 +889,9 @@ static VLCMain *_o_sharedMainInstance = nil;
             /* simulate an event as long as the user holds the button */
             b_remote_button_hold = pressedDown;
             if( pressedDown )
-            {                
-                NSNumber* buttonIdentifierNumber = [NSNumber numberWithInt: buttonIdentifier];  
-                [self performSelector:@selector(executeHoldActionForRemoteButton:) 
+            {
+                NSNumber* buttonIdentifierNumber = [NSNumber numberWithInt: buttonIdentifier];
+                [self performSelector:@selector(executeHoldActionForRemoteButton:)
                            withObject:buttonIdentifierNumber];
             }
             break;
@@ -1133,7 +1202,7 @@ static VLCMain *_o_sharedMainInstance = nil;
         vlc_bool_t b_chapters = VLC_FALSE;
 
         playlist_t * p_playlist = pl_Yield( p_intf );
-       /** \todo fix i_size use */
+    /** \todo fix i_size use */
         b_plmul = p_playlist->items.i_size > 1;
         p_input = p_playlist->p_input;
 
@@ -1145,7 +1214,7 @@ static VLCMain *_o_sharedMainInstance = nil;
 
             /* check wether slow/fast motion is possible*/
             b_control = p_input->b_can_pace_control;
-    
 
             /* chapters & titles */
             //b_chapters = p_input->stream.i_area_nb > 1;
@@ -1161,8 +1230,8 @@ static VLCMain *_o_sharedMainInstance = nil;
 
         [o_timeslider setFloatValue: 0.0];
         [o_timeslider setEnabled: b_seekable];
-        [o_timefield setStringValue: @"0:00:00"];
-        [[[self getControls] getFSPanel] setStreamPos: 0 andTime: @"0:00:00"];
+        [o_timefield setStringValue: @"00:00"];
+        [[[self getControls] getFSPanel] setStreamPos: 0 andTime: @"00:00"];
         [[[self getControls] getFSPanel] setSeekable: b_seekable];
 
         [o_embedded_window setSeekable: b_seekable];
@@ -1220,7 +1289,7 @@ static VLCMain *_o_sharedMainInstance = nil;
             [[[self getControls] getFSPanel] setStreamTitle: o_temp];
 
             [[o_controls getVoutView] updateTitle];
-            
             [o_playlist updateRowSelection];
             p_intf->p_sys->b_current_title_update = FALSE;
         }
@@ -1230,8 +1299,8 @@ static VLCMain *_o_sharedMainInstance = nil;
             /* Update the slider */
             vlc_value_t time;
             NSString * o_time;
-            mtime_t i_seconds;
             vlc_value_t pos;
+            char psz_time[MSTRTIME_MAX_SIZE];
             float f_updated;
 
             var_Get( p_input, "position", &pos );
@@ -1239,12 +1308,9 @@ static VLCMain *_o_sharedMainInstance = nil;
             [o_timeslider setFloatValue: f_updated];
 
             var_Get( p_input, "time", &time );
-            i_seconds = time.i_time / 1000000;
 
-            o_time = [NSString stringWithFormat: @"%d:%02d:%02d",
-                            (int) (i_seconds / (60 * 60)),
-                            (int) (i_seconds / 60 % 60),
-                            (int) (i_seconds % 60)];
+            o_time = [NSString stringWithUTF8String: secstotimestr( psz_time, (time.i_time / 1000000) )];
+
             [o_timefield setStringValue: o_time];
             [[[self getControls] getFSPanel] setStreamPos: f_updated andTime: o_time];
             [o_embedded_window setTime: o_time position: f_updated];
@@ -1378,10 +1444,10 @@ static VLCMain *_o_sharedMainInstance = nil;
     int x,y = 0;
     vout_thread_t * p_vout = vlc_object_find( p_intf, VLC_OBJECT_VOUT,
                                               FIND_ANYWHERE );
-    
     if(! p_vout )
         return;
-    
     /* clean the menu before adding new entries */
     if( [o_mi_screen hasSubmenu] )
     {
@@ -1574,8 +1640,8 @@ static VLCMain *_o_sharedMainInstance = nil;
     {
         vlc_value_t time;
         vlc_value_t pos;
-        mtime_t i_seconds;
         NSString * o_time;
+        char psz_time[MSTRTIME_MAX_SIZE];
         vlc_object_yield( p_input );
 
         pos.f_float = f_updated / 10000.;
@@ -1583,12 +1649,8 @@ static VLCMain *_o_sharedMainInstance = nil;
         [o_timeslider setFloatValue: f_updated];
 
         var_Get( p_input, "time", &time );
-        i_seconds = time.i_time / 1000000;
 
-        o_time = [NSString stringWithFormat: @"%d:%02d:%02d",
-                        (int) (i_seconds / (60 * 60)),
-                        (int) (i_seconds / 60 % 60),
-                        (int) (i_seconds % 60)];
+        o_time = [NSString stringWithUTF8String: secstotimestr( psz_time, (time.i_time / 1000000) )];
         [o_timefield setStringValue: o_time];
         [[[self getControls] getFSPanel] setStreamPos: f_updated andTime: o_time];
         [o_embedded_window setTime: o_time position: f_updated];
@@ -1602,7 +1664,7 @@ static VLCMain *_o_sharedMainInstance = nil;
     playlist_t * p_playlist;
     vout_thread_t * p_vout;
     int returnedValue = 0;
-    
     /* Stop playback */
     p_playlist = pl_Yield( p_intf );
     playlist_Stop( p_playlist );
@@ -1612,7 +1674,7 @@ static VLCMain *_o_sharedMainInstance = nil;
     config_PutInt( p_intf->p_libvlc, "volume", i_lastShownVolume );
     returnedValue = config_SaveConfigFile( p_intf->p_libvlc, "main" );
     if( returnedValue != 0 )
-        msg_Err( p_intf, 
+        msg_Err( p_intf,
                  "error while saving volume in osx's terminate method (%i)",
                  returnedValue );
 
@@ -1621,7 +1683,7 @@ static VLCMain *_o_sharedMainInstance = nil;
     {
         [o_extended savePrefs];
     }
-    
     p_intf->b_interaction = VLC_FALSE;
     var_DelCallback( p_intf, "interaction", InteractCallback, self );
 
@@ -1634,22 +1696,22 @@ static VLCMain *_o_sharedMainInstance = nil;
      * will be called later on -- FK (10/6/05) */
     if( nib_about_loaded && o_about )
         [o_about release];
-    
     if( nib_open_loaded && o_open )
         [o_open release];
-    
     if( nib_extended_loaded && o_extended )
     {
         [o_extended collapsAll];
         [o_extended release];
     }
-    
     if( nib_bookmarks_loaded && o_bookmarks )
         [o_bookmarks release];
 
     if( nib_wizard_loaded && o_wizard )
         [o_wizard release];
-        
     if( o_embedded_list != nil )
         [o_embedded_list release];
 
@@ -1699,7 +1761,7 @@ static VLCMain *_o_sharedMainInstance = nil;
     /* write cached user defaults to disk */
     [[NSUserDefaults standardUserDefaults] synchronize];
 
-    p_intf->b_die = VLC_TRUE;
+    vlc_object_kill( p_intf );
 
     /* Go back to Run() and make libvlc exit properly */
     longjmp( jmpbuffer, 1 );
@@ -1820,27 +1882,29 @@ static VLCMain *_o_sharedMainInstance = nil;
         nib_wizard_loaded = [NSBundle loadNibNamed:@"Wizard" owner:self];
         [o_wizard initStrings];
     }
-    
     if ( !nib_bookmarks_loaded )
-    {
         nib_bookmarks_loaded = [NSBundle loadNibNamed:@"Bookmarks" owner:self];
-        [o_bookmarks showBookmarks];
-    } else {
-        [o_bookmarks showBookmarks];
-    }
+
+    [o_bookmarks showBookmarks];
 }
 
 - (IBAction)viewAbout:(id)sender
 {
-    if ( !nib_about_loaded )
-    {
+    if( !nib_about_loaded )
         nib_about_loaded = [NSBundle loadNibNamed:@"About" owner:self];
-        [o_about showPanel];
-    } else {
-        [o_about showPanel];
-    }
+
+    [o_about showAbout];
 }
 
+- (IBAction)showLicense:(id)sender
+{
+    if( !nib_about_loaded )
+        nib_about_loaded = [NSBundle loadNibNamed:@"About" owner:self];
+
+    [o_about showGPL: sender];
+}
+    
 - (IBAction)viewPreferences:(id)sender
 {
 /* GRUIIIIIIIK */
@@ -1849,12 +1913,25 @@ static VLCMain *_o_sharedMainInstance = nil;
     [o_prefs showPrefs];
 }
 
+#ifdef UPDATE_CHECK
 - (IBAction)checkForUpdate:(id)sender
-{
-    if ( !nib_update_loaded )
+{/* FIXME
+    if( !nib_update_loaded )
         nib_update_loaded = [NSBundle loadNibNamed:@"Update" owner:self];
 
     [o_update showUpdateWindow];
+*/}
+#endif
+
+- (IBAction)viewHelp:(id)sender
+{
+    if( !nib_about_loaded )
+    {
+        nib_about_loaded = [NSBundle loadNibNamed:@"About" owner:self];
+        [o_about showHelp];
+    }
+    else
+        [o_about showHelp];
 }
 
 - (IBAction)openReadMe:(id)sender
@@ -1874,14 +1951,6 @@ static VLCMain *_o_sharedMainInstance = nil;
     [[NSWorkspace sharedWorkspace] openURL: o_url];
 }
 
-- (IBAction)reportABug:(id)sender
-{
-    NSURL * o_url = [NSURL URLWithString:
-        @"http://www.videolan.org/support/bug-reporting.html"];
-
-    [[NSWorkspace sharedWorkspace] openURL: o_url];
-}
-
 - (IBAction)openWebsite:(id)sender
 {
     NSURL * o_url = [NSURL URLWithString: @"http://www.videolan.org/"];
@@ -1889,15 +1958,6 @@ static VLCMain *_o_sharedMainInstance = nil;
     [[NSWorkspace sharedWorkspace] openURL: o_url];
 }
 
-- (IBAction)openLicense:(id)sender
-{
-    NSString * o_path = [[NSBundle mainBundle]
-        pathForResource: @"COPYING" ofType: nil];
-
-    [[NSWorkspace sharedWorkspace] openFile: o_path
-                                   withApplication: @"TextEdit"];
-}
-
 - (IBAction)openForum:(id)sender
 {
     NSURL * o_url = [NSURL URLWithString: @"http://forum.videolan.org/"];
@@ -1968,6 +2028,8 @@ static VLCMain *_o_sharedMainInstance = nil;
     /*First, check if the playlist is visible*/
     if( o_rect.size.height <= 200 )
     {
+        o_restore_rect = o_rect;
+        b_restore_size = true;
         b_small_window = YES; /* we know we are small, make sure this is actually set (see case below) */
         /* make large */
         if ( o_size_with_playlist.height > 200 )
@@ -1976,23 +2038,33 @@ static VLCMain *_o_sharedMainInstance = nil;
         } else {
             o_rect.size.height = 500;
         }
-        
         if ( o_size_with_playlist.width > [o_window minSize].width )
         {
             o_rect.size.width = o_size_with_playlist.width;
         } else {
             o_rect.size.width = 500;
         }
-        
         o_rect.size.height = (o_size_with_playlist.height > 200) ?
             o_size_with_playlist.height : 500;
         o_rect.origin.x = [o_window frame].origin.x;
         o_rect.origin.y = [o_window frame].origin.y - o_rect.size.height +
                                                 [o_window minSize].height;
+
+        NSRect screenRect = [[o_window screen] visibleFrame];
+        if ( !NSContainsRect( screenRect, o_rect ) ) {
+            if ( NSMaxX(o_rect) > NSMaxX(screenRect) )
+                o_rect.origin.x = ( NSMaxX(screenRect) - o_rect.size.width );
+            if ( NSMinY(o_rect) < NSMinY(screenRect) )
+                o_rect.origin.y = ( NSMinY(screenRect) );
+        }
+
         [o_btn_playlist setState: YES];
     }
     else
     {
+        NSSize curSize = o_rect.size;
         /* make small */
         o_rect.size.height = [o_window minSize].height;
         o_rect.size.width = [o_window minSize].width;
@@ -2001,6 +2073,9 @@ static VLCMain *_o_sharedMainInstance = nil;
         o_rect.origin.y = [o_window frame].origin.y +
             [o_window frame].size.height - [o_window minSize].height;
 
+        if ( b_restore_size )
+            o_rect = o_restore_rect;
+
         [o_playlist_view setAutoresizesSubviews: NO];
         [o_playlist_view removeFromSuperview];
         [o_btn_playlist setState: NO];
@@ -2044,6 +2119,11 @@ static VLCMain *_o_sharedMainInstance = nil;
     return proposedFrameSize;
 }
 
+- (void)windowDidMove:(NSNotification *)notif
+{
+    b_restore_size = false;
+}
+
 - (void)windowDidResize:(NSNotification *)notif
 {
     if( [o_window frame].size.height > 200 && b_small_window )