#import "MainMenu.h"
#include <vlc_keys.h>
-#import <vlc_osd.h>
#import <vlc_interface.h>
#include <vlc_url.h>
- (NSMenu *)menuForEvent:(NSEvent *)o_event
{
- return( [(VLCPlaylist *)[self delegate] menuForEvent: o_event] );
+ return([(VLCPlaylist *)[self delegate] menuForEvent: o_event]);
}
- (void)keyDown:(NSEvent *)o_event
{
unichar key = 0;
- if( [[o_event characters] length] )
- {
+ if ([[o_event characters] length])
key = [[o_event characters] characterAtIndex: 0];
- }
- switch( key )
- {
+ switch(key) {
case NSDeleteCharacter:
case NSDeleteFunctionKey:
case NSDeleteCharFunctionKey:
- (id)init
{
- playlist_t * p_playlist = pl_Get( VLCIntf );
+ playlist_t * p_playlist = pl_Get(VLCIntf);
p_current_root_item = p_playlist->p_local_category;
self = [super init];
- if ( self != nil )
- {
+ if (self != nil)
o_outline_dict = [[NSMutableDictionary alloc] init];
- }
+
return self;
}
- (void)awakeFromNib
{
- playlist_t * p_playlist = pl_Get( VLCIntf );
+ playlist_t * p_playlist = pl_Get(VLCIntf);
[o_outline_view setTarget: self];
[o_outline_view setDelegate: self];
[o_outline_view setDataSource: self];
{
int i_return = 0;
playlist_item_t *p_item = NULL;
- playlist_t * p_playlist = pl_Get( VLCIntf );
- //assert( outlineView == o_outline_view );
+ playlist_t * p_playlist = pl_Get(VLCIntf);
+ //assert(outlineView == o_outline_view);
PL_LOCK;
- if( !item )
- {
+ if (!item)
p_item = p_current_root_item;
- }
else
p_item = (playlist_item_t *)[item pointerValue];
- if( p_item )
+ if (p_item)
i_return = p_item->i_children;
PL_UNLOCK;
{
playlist_item_t *p_return = NULL, *p_item = NULL;
NSValue *o_value;
- playlist_t * p_playlist = pl_Get( VLCIntf );
+ playlist_t * p_playlist = pl_Get(VLCIntf);
PL_LOCK;
- if( item == nil )
- {
- /* root object */
- p_item = p_current_root_item;
- }
+ if (item == nil)
+ p_item = p_current_root_item; /* root object */
else
- {
p_item = (playlist_item_t *)[item pointerValue];
- }
- if( p_item && index < p_item->i_children && index >= 0 )
+
+ if (p_item && index < p_item->i_children && index >= 0)
p_return = p_item->pp_children[index];
PL_UNLOCK;
o_value = [o_outline_dict objectForKey:[NSString stringWithFormat: @"%p", p_return]];
- if( o_value == nil )
- {
+ if (o_value == nil) {
/* FIXME: Why is there a warning if that happens all the time and seems
* to be normal? Add an assert and fix it.
- * msg_Warn( VLCIntf, "playlist item misses pointer value, adding one" ); */
+ * msg_Warn(VLCIntf, "playlist item misses pointer value, adding one"); */
o_value = [[NSValue valueWithPointer: p_return] retain];
}
return o_value;
- (BOOL)outlineView:(NSOutlineView *)outlineView isItemExpandable:(id)item
{
int i_return = 0;
- playlist_t *p_playlist = pl_Get( VLCIntf );
+ playlist_t *p_playlist = pl_Get(VLCIntf);
PL_LOCK;
- if( item == nil )
- {
+ if (item == nil) {
/* root object */
- if( p_current_root_item )
- {
+ if (p_current_root_item) {
i_return = p_current_root_item->i_children;
}
- }
- else
- {
+ } else {
playlist_item_t *p_item = (playlist_item_t *)[item pointerValue];
- if( p_item )
+ if (p_item)
i_return = p_item->i_children;
}
PL_UNLOCK;
/* For error handling */
static BOOL attempted_reload = NO;
- if( item == nil || ![item isKindOfClass: [NSValue class]] )
- {
+ if (item == nil || ![item isKindOfClass: [NSValue class]]) {
/* Attempt to fix the error by asking for a data redisplay
* This might cause infinite loop, so add a small check */
- if( !attempted_reload )
- {
+ if (!attempted_reload) {
attempted_reload = YES;
[outlineView reloadData];
}
}
p_item = (playlist_item_t *)[item pointerValue];
- if( !p_item || !p_item->p_input )
- {
+ if (!p_item || !p_item->p_input) {
/* Attempt to fix the error by asking for a data redisplay
* This might cause infinite loop, so add a small check */
- if( !attempted_reload )
- {
+ if (!attempted_reload) {
attempted_reload = YES;
[outlineView reloadData];
}
attempted_reload = NO;
NSString * o_identifier = [o_tc identifier];
- if( [o_identifier isEqualToString:TRACKNUM_COLUMN] )
- {
- psz_value = input_item_GetTrackNumber( p_item->p_input ); \
- if (psz_value) { \
- o_value = [NSString stringWithUTF8String: psz_value]; \
- free( psz_value ); \
+ if ([o_identifier isEqualToString:TRACKNUM_COLUMN]) {
+ psz_value = input_item_GetTrackNumber(p_item->p_input);
+ if (psz_value) {
+ o_value = [NSString stringWithUTF8String: psz_value];
+ free(psz_value);
}
- }
- else if( [o_identifier isEqualToString:TITLE_COLUMN] )
- {
+ } else if ([o_identifier isEqualToString:TITLE_COLUMN]) {
/* sanity check to prevent the NSString class from crashing */
- char *psz_title = input_item_GetTitleFbName( p_item->p_input );
- if( psz_title )
- {
+ char *psz_title = input_item_GetTitleFbName(p_item->p_input);
+ if (psz_title) {
o_value = [NSString stringWithUTF8String: psz_title];
- free( psz_title );
+ free(psz_title);
}
- }
- else if( [o_identifier isEqualToString:ARTIST_COLUMN] )
- {
- psz_value = input_item_GetArtist( p_item->p_input ); \
- if (psz_value) { \
- o_value = [NSString stringWithUTF8String: psz_value]; \
- free( psz_value ); \
+ } else if ([o_identifier isEqualToString:ARTIST_COLUMN]) {
+ psz_value = input_item_GetArtist(p_item->p_input);
+ if (psz_value) {
+ o_value = [NSString stringWithUTF8String: psz_value];
+ free(psz_value);
}
- }
- else if( [o_identifier isEqualToString:@"duration"] )
- {
+ } else if ([o_identifier isEqualToString:@"duration"]) {
char psz_duration[MSTRTIME_MAX_SIZE];
- mtime_t dur = input_item_GetDuration( p_item->p_input );
- if( dur != -1 )
- {
- secstotimestr( psz_duration, dur/1000000 );
+ mtime_t dur = input_item_GetDuration(p_item->p_input);
+ if (dur != -1) {
+ secstotimestr(psz_duration, dur/1000000);
o_value = [NSString stringWithUTF8String: psz_duration];
}
else
o_value = @"--:--";
- }
- else if( [o_identifier isEqualToString:GENRE_COLUMN] )
- {
- psz_value = input_item_GetGenre( p_item->p_input ); \
- if (psz_value) { \
- o_value = [NSString stringWithUTF8String: psz_value]; \
- free( psz_value ); \
+ } else if ([o_identifier isEqualToString:GENRE_COLUMN]) {
+ psz_value = input_item_GetGenre(p_item->p_input);
+ if (psz_value) {
+ o_value = [NSString stringWithUTF8String: psz_value];
+ free(psz_value);
}
- }
- else if( [o_identifier isEqualToString:ALBUM_COLUMN] )
- {
- psz_value = input_item_GetAlbum( p_item->p_input ); \
- if (psz_value) { \
- o_value = [NSString stringWithUTF8String: psz_value]; \
- free( psz_value ); \
+ } else if ([o_identifier isEqualToString:ALBUM_COLUMN]) {
+ psz_value = input_item_GetAlbum(p_item->p_input);
+ if (psz_value) {
+ o_value = [NSString stringWithUTF8String: psz_value];
+ free(psz_value);
}
- }
- else if( [o_identifier isEqualToString:DESCRIPTION_COLUMN] )
- {
- psz_value = input_item_GetDescription( p_item->p_input ); \
- if (psz_value) { \
- o_value = [NSString stringWithUTF8String: psz_value]; \
- free( psz_value ); \
+ } else if ([o_identifier isEqualToString:DESCRIPTION_COLUMN]) {
+ psz_value = input_item_GetDescription(p_item->p_input);
+ if (psz_value) {
+ o_value = [NSString stringWithUTF8String: psz_value];
+ free(psz_value);
}
- }
- else if( [o_identifier isEqualToString:DATE_COLUMN] )
- {
- psz_value = input_item_GetDate( p_item->p_input ); \
- if (psz_value) { \
- o_value = [NSString stringWithUTF8String: psz_value]; \
- free( psz_value ); \
+ } else if ([o_identifier isEqualToString:DATE_COLUMN]) {
+ psz_value = input_item_GetDate(p_item->p_input);
+ if (psz_value) {
+ o_value = [NSString stringWithUTF8String: psz_value];
+ free(psz_value);
}
- }
- else if( [o_identifier isEqualToString:LANGUAGE_COLUMN] )
- {
- psz_value = input_item_GetLanguage( p_item->p_input ); \
- if (psz_value) { \
- o_value = [NSString stringWithUTF8String: psz_value]; \
- free( psz_value ); \
+ } else if ([o_identifier isEqualToString:LANGUAGE_COLUMN]) {
+ psz_value = input_item_GetLanguage(p_item->p_input);
+ if (psz_value) {
+ o_value = [NSString stringWithUTF8String: psz_value];
+ free(psz_value);
}
}
- else if( [o_identifier isEqualToString:URI_COLUMN] )
- {
- psz_value = decode_URI(input_item_GetURI( p_item->p_input )); \
- if (psz_value) { \
- o_value = [NSString stringWithUTF8String: psz_value]; \
- free( psz_value ); \
+ else if ([o_identifier isEqualToString:URI_COLUMN]) {
+ psz_value = decode_URI(input_item_GetURI(p_item->p_input));
+ if (psz_value) {
+ o_value = [NSString stringWithUTF8String: psz_value];
+ free(psz_value);
}
}
- else if( [o_identifier isEqualToString:@"status"] )
- {
- if( input_item_HasErrorWhenReading( p_item->p_input ) )
- {
+ else if ([o_identifier isEqualToString:@"status"]) {
+ if (input_item_HasErrorWhenReading(p_item->p_input)) {
o_value = [[NSWorkspace sharedWorkspace] iconForFileType:NSFileTypeForHFSTypeCode(kAlertCautionIcon)];
[o_value setSize: NSMakeSize(16,16)];
}
{
/* Only reload the outlineview if the wizard window is open since this can
be quite long on big playlists */
- if( [[o_outline_view window] isVisible] )
- {
+ if ([[o_outline_view window] isVisible])
[o_outline_view reloadData];
- }
}
@end
/*****************************************************************************
* VLCPlaylist implementation
*****************************************************************************/
+@interface VLCPlaylist (Internal)
+- (void)saveTableColumns;
+@end
+
@implementation VLCPlaylist
+ (void)initialize{
- (id)init
{
self = [super init];
- if ( self != nil )
- {
+ if (self != nil) {
o_nodes_array = [[NSMutableArray alloc] init];
o_items_array = [[NSMutableArray alloc] init];
}
- (void)awakeFromNib
{
- playlist_t * p_playlist = pl_Get( VLCIntf );
-
- int i;
+ playlist_t * p_playlist = pl_Get(VLCIntf);
[super awakeFromNib];
NSMenu *o_context_menu = [o_menu setupPlaylistTableColumnsMenu];
[o_playlist_header setMenu: o_context_menu];
- for (NSUInteger i = 0; i < count; i++)
- {
+ for (NSUInteger i = 0; i < count; i++) {
o_column = [[o_columnArray objectAtIndex:i] objectAtIndex:0];
if ([o_column isEqualToString:@"status"])
continue;
[o_save_accessory_text setStringValue: _NS("File Format:")];
[[o_save_accessory_popup itemAtIndex:0] setTitle: _NS("Extended M3U")];
[[o_save_accessory_popup itemAtIndex:1] setTitle: _NS("XML Shareable Playlist Format (XSPF)")];
- [[o_save_accessory_popup itemAtIndex:2] setTitle: _NS("HTML Playlist")];
+ [[o_save_accessory_popup itemAtIndex:2] setTitle: _NS("HTML playlist")];
}
- (void)playlistUpdated
{
/* Clear indications of any existing column sorting */
NSUInteger count = [[o_outline_view tableColumns] count];
- for( NSUInteger i = 0 ; i < count ; i++ )
- {
+ for (NSUInteger i = 0 ; i < count ; i++)
[o_outline_view setIndicatorImage:nil inTableColumn: [[o_outline_view tableColumns] objectAtIndex:i]];
- }
[o_outline_view setHighlightedTableColumn:nil];
o_tc_sortColumn = nil;
// FIXME: unsafe
playlist_item_t * p_item = [[o_outline_view itemAtRow:[o_outline_view selectedRow]] pointerValue];
- if( p_item )
- {
+ if (p_item) {
/* update the state of our Reveal-in-Finder menu items */
NSMutableString *o_mrl;
- char *psz_uri = input_item_GetURI( p_item->p_input );
+ char *psz_uri = input_item_GetURI(p_item->p_input);
[o_mi_revealInFinder setEnabled: NO];
[o_mm_mi_revealInFinder setEnabled: NO];
- if( psz_uri )
- {
+ if (psz_uri) {
o_mrl = [NSMutableString stringWithUTF8String: psz_uri];
/* perform some checks whether it is a file and if it is local at all... */
NSRange prefix_range = [o_mrl rangeOfString: @"file:"];
- if( prefix_range.location != NSNotFound )
+ if (prefix_range.location != NSNotFound)
[o_mrl deleteCharactersInRange: prefix_range];
- if( [o_mrl characterAtIndex:0] == '/' )
- {
+ if ([o_mrl characterAtIndex:0] == '/') {
[o_mi_revealInFinder setEnabled: YES];
[o_mm_mi_revealInFinder setEnabled: YES];
}
- free( psz_uri );
+ free(psz_uri);
}
/* update our info-panel to reflect the new item */
- (void)updateRowSelection
{
// FIXME: unsafe
- playlist_t *p_playlist = pl_Get( VLCIntf );
+ playlist_t *p_playlist = pl_Get(VLCIntf);
playlist_item_t *p_item, *p_temp_item;
NSMutableArray *o_array = [NSMutableArray array];
PL_LOCK;
- p_item = playlist_CurrentPlayingItem( p_playlist );
- if( p_item == NULL )
- {
+ p_item = playlist_CurrentPlayingItem(p_playlist);
+ if (p_item == NULL) {
PL_UNLOCK;
return;
}
p_temp_item = p_item;
- while( p_temp_item->p_parent )
- {
+ while(p_temp_item->p_parent) {
[o_array insertObject: [NSValue valueWithPointer: p_temp_item] atIndex: 0];
p_temp_item = p_temp_item->p_parent;
}
PL_UNLOCK;
NSUInteger count = [o_array count];
- for( NSUInteger j = 0; j < count - 1; j++ )
- {
+ for (NSUInteger j = 0; j < count - 1; j++) {
id o_item;
- if( ( o_item = [o_outline_dict objectForKey:
+ if ((o_item = [o_outline_dict objectForKey:
[NSString stringWithFormat: @"%p",
- [[o_array objectAtIndex:j] pointerValue]]] ) != nil )
- {
+ [[o_array objectAtIndex:j] pointerValue]]]) != nil) {
[o_outline_view expandItem: o_item];
}
}
deleted. We don't do it when not required since this verification takes
quite a long time on big playlists (yes, pretty hacky). */
-- (BOOL)isItem: (playlist_item_t *)p_item
- inNode: (playlist_item_t *)p_node
- checkItemExistence:(BOOL)b_check
- locked:(BOOL)b_locked
-
+- (BOOL)isItem: (playlist_item_t *)p_item inNode: (playlist_item_t *)p_node checkItemExistence:(BOOL)b_check locked:(BOOL)b_locked
{
- playlist_t * p_playlist = pl_Get( VLCIntf );
+ playlist_t * p_playlist = pl_Get(VLCIntf);
playlist_item_t *p_temp_item = p_item;
- if( p_node == p_item )
+ if (!p_node)
+ return NO;
+
+ if (p_node == p_item)
return YES;
- if( p_node->i_children < 1)
+ if (p_node->i_children < 1)
return NO;
- if ( p_temp_item )
- {
+ if (p_temp_item) {
int i;
- if(!b_locked) PL_LOCK;
+ if (!b_locked) PL_LOCK;
- if( b_check )
- {
+ if (b_check) {
/* Since outlineView: willDisplayCell:... may call this function with
p_items that don't exist anymore, first check if the item is still
in the playlist. Any cleaner solution welcomed. */
- for( i = 0; i < p_playlist->all_items.i_size; i++ )
- {
- if( ARRAY_VAL( p_playlist->all_items, i) == p_item ) break;
- else if ( i == p_playlist->all_items.i_size - 1 )
+ for (i = 0; i < p_playlist->all_items.i_size; i++) {
+ if (ARRAY_VAL(p_playlist->all_items, i) == p_item)
+ break;
+ else if (i == p_playlist->all_items.i_size - 1)
{
- if(!b_locked) PL_UNLOCK;
+ if (!b_locked) PL_UNLOCK;
return NO;
}
}
}
- while( p_temp_item )
- {
+ while(p_temp_item) {
p_temp_item = p_temp_item->p_parent;
- if( p_temp_item == p_node )
- {
- if(!b_locked) PL_UNLOCK;
+ if (p_temp_item == p_node) {
+ if (!b_locked) PL_UNLOCK;
return YES;
}
}
- if(!b_locked) PL_UNLOCK;
+ if (!b_locked) PL_UNLOCK;
}
return NO;
}
-- (BOOL)isItem: (playlist_item_t *)p_item
- inNode: (playlist_item_t *)p_node
- checkItemExistence:(BOOL)b_check
-{
- return [self isItem:p_item inNode:p_node checkItemExistence:b_check locked:NO];
-}
-
/* This method is useful for instance to remove the selected children of an
already selected node */
- (void)removeItemsFrom:(id)o_items ifChildrenOf:(id)o_nodes
{
NSUInteger itemCount = [o_items count];
NSUInteger nodeCount = [o_nodes count];
- for( NSUInteger i = 0 ; i < itemCount ; i++ )
- {
- for ( NSUInteger j = 0 ; j < nodeCount ; j++ )
- {
- if( o_items == o_nodes)
- {
- if( j == i ) continue;
+ for (NSUInteger i = 0 ; i < itemCount ; i++) {
+ for (NSUInteger j = 0 ; j < nodeCount ; j++) {
+ if (o_items == o_nodes) {
+ if (j == i) continue;
}
- if( [self isItem: [[o_items objectAtIndex:i] pointerValue]
+ if ([self isItem: [[o_items objectAtIndex:i] pointerValue]
inNode: [[o_nodes objectAtIndex:j] pointerValue]
- checkItemExistence: NO locked:NO] )
- {
+ checkItemExistence: NO locked:NO]) {
[o_items removeObjectAtIndex:i];
/* We need to execute the next iteration with the same index
since the current item has been deleted */
- (IBAction)savePlaylist:(id)sender
{
- playlist_t * p_playlist = pl_Get( VLCIntf );
+ playlist_t * p_playlist = pl_Get(VLCIntf);
NSSavePanel *o_save_panel = [NSSavePanel savePanel];
NSString * o_name = [NSString stringWithFormat: @"%@", _NS("Untitled")];
[o_save_panel setTitle: _NS("Save Playlist")];
[o_save_panel setPrompt: _NS("Save")];
[o_save_panel setAccessoryView: o_save_accessory_view];
+ [o_save_panel setNameFieldStringValue: o_name];
- if( [o_save_panel runModalForDirectory: nil
- file: o_name] == NSOKButton )
- {
+ if ([o_save_panel runModal] == NSFileHandlingPanelOKButton) {
NSString *o_filename = [[o_save_panel URL] path];
- if( [o_save_accessory_popup indexOfSelectedItem] == 0 )
- {
+ if ([o_save_accessory_popup indexOfSelectedItem] == 0) {
NSString * o_real_filename;
NSRange range;
range.location = [o_filename length] - [@".m3u" length];
range.length = [@".m3u" length];
- if( [o_filename compare:@".m3u" options: NSCaseInsensitiveSearch
- range: range] != NSOrderedSame )
- {
+ if ([o_filename compare:@".m3u" options: NSCaseInsensitiveSearch range: range] != NSOrderedSame)
o_real_filename = [NSString stringWithFormat: @"%@.m3u", o_filename];
- }
else
- {
o_real_filename = o_filename;
- }
- playlist_Export( p_playlist,
+
+ playlist_Export(p_playlist,
[o_real_filename fileSystemRepresentation],
- p_playlist->p_local_category, "export-m3u" );
- }
- else if( [o_save_accessory_popup indexOfSelectedItem] == 1 )
- {
+ p_playlist->p_local_category, "export-m3u");
+ } else if ([o_save_accessory_popup indexOfSelectedItem] == 1) {
NSString * o_real_filename;
NSRange range;
range.location = [o_filename length] - [@".xspf" length];
range.length = [@".xspf" length];
- if( [o_filename compare:@".xspf" options: NSCaseInsensitiveSearch
- range: range] != NSOrderedSame )
- {
+ if ([o_filename compare:@".xspf" options: NSCaseInsensitiveSearch range: range] != NSOrderedSame)
o_real_filename = [NSString stringWithFormat: @"%@.xspf", o_filename];
- }
else
- {
o_real_filename = o_filename;
- }
- playlist_Export( p_playlist,
+
+ playlist_Export(p_playlist,
[o_real_filename fileSystemRepresentation],
- p_playlist->p_local_category, "export-xspf" );
- }
- else
- {
+ p_playlist->p_local_category, "export-xspf");
+ } else {
NSString * o_real_filename;
NSRange range;
range.location = [o_filename length] - [@".html" length];
range.length = [@".html" length];
- if( [o_filename compare:@".html" options: NSCaseInsensitiveSearch
- range: range] != NSOrderedSame )
- {
+ if ([o_filename compare:@".html" options: NSCaseInsensitiveSearch range: range] != NSOrderedSame)
o_real_filename = [NSString stringWithFormat: @"%@.html", o_filename];
- }
else
- {
o_real_filename = o_filename;
- }
- playlist_Export( p_playlist,
+
+ playlist_Export(p_playlist,
[o_real_filename fileSystemRepresentation],
- p_playlist->p_local_category, "export-html" );
+ p_playlist->p_local_category, "export-html");
}
}
}
- (IBAction)playItem:(id)sender
{
intf_thread_t * p_intf = VLCIntf;
- playlist_t * p_playlist = pl_Get( p_intf );
+ playlist_t * p_playlist = pl_Get(p_intf);
playlist_item_t *p_item;
playlist_item_t *p_node = NULL;
// ignore clicks on column header when handling double action
- if( sender != nil && [o_outline_view clickedRow] == -1 && sender != o_mi_play)
+ if (sender != nil && [o_outline_view clickedRow] == -1 && sender != o_mi_play)
return;
p_item = [[o_outline_view itemAtRow:[o_outline_view selectedRow]] pointerValue];
PL_LOCK;
- if( p_item )
- {
- if( p_item->i_children == -1 )
- {
+ if (p_item) {
+ if (p_item->i_children == -1) {
p_node = p_item->p_parent;
- }
- else
- {
+ } else {
p_node = p_item;
- if( p_node->i_children > 0 && p_node->pp_children[0]->i_children == -1 )
- {
+ if (p_node->i_children > 0 && p_node->pp_children[0]->i_children == -1)
p_item = p_node->pp_children[0];
- }
else
- {
p_item = NULL;
- }
}
- playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, pl_Locked, p_node, p_item );
+ playlist_Control(p_playlist, PLAYLIST_VIEWPLAY, pl_Locked, p_node, p_item);
}
PL_UNLOCK;
}
for (NSUInteger i = 0; i < count; i++) {
p_item = [[o_outline_view itemAtRow:indexes[i]] pointerValue];
- if(! p_item || !p_item->p_input )
+ if (! p_item || !p_item->p_input)
continue;
- o_mrl = [[NSMutableString alloc] initWithFormat: @"%s", decode_URI( input_item_GetURI( p_item->p_input ))];
+ char * psz_url = decode_URI(input_item_GetURI(p_item->p_input));
+ o_mrl = [[NSMutableString alloc] initWithString: [NSString stringWithUTF8String: psz_url ? psz_url : ""]];
+ if (psz_url != NULL)
+ free( psz_url );
/* perform some checks whether it is a file and if it is local at all... */
- if ([o_mrl length] > 0)
- {
+ if ([o_mrl length] > 0) {
NSRange prefix_range = [o_mrl rangeOfString: @"file:"];
- if( prefix_range.location != NSNotFound )
+ if (prefix_range.location != NSNotFound)
[o_mrl deleteCharactersInRange: prefix_range];
- if( [o_mrl characterAtIndex:0] == '/' )
+ if ([o_mrl characterAtIndex:0] == '/')
[[NSWorkspace sharedWorkspace] selectFile: o_mrl inFileViewerRootedAtPath: o_mrl];
}
int i_count;
NSIndexSet *o_selected_indexes;
intf_thread_t * p_intf = VLCIntf;
- playlist_t * p_playlist = pl_Get( p_intf );
+ playlist_t * p_playlist = pl_Get(p_intf);
playlist_item_t *p_item = NULL;
o_selected_indexes = [o_outline_view selectedRowIndexes];
NSUInteger indexes[i_count];
[o_selected_indexes getIndexes:indexes maxCount:i_count inIndexRange:nil];
- for (int i = 0; i < i_count; i++)
- {
+ for (int i = 0; i < i_count; i++) {
p_item = [[o_outline_view itemAtRow:indexes[i]] pointerValue];
[o_outline_view deselectRow: indexes[i]];
- if( p_item )
- {
- if( p_item->i_children == -1 )
- playlist_PreparseEnqueue( p_playlist, p_item->p_input );
+ if (p_item) {
+ if (p_item->i_children == -1)
+ playlist_PreparseEnqueue(p_playlist, p_item->p_input);
else
- msg_Dbg( p_intf, "preparsing nodes not implemented" );
+ msg_Dbg(p_intf, "preparsing nodes not implemented");
}
}
[self playlistUpdated];
int i_count;
NSIndexSet *o_selected_indexes;
intf_thread_t * p_intf = VLCIntf;
- playlist_t * p_playlist = pl_Get( p_intf );
+ playlist_t * p_playlist = pl_Get(p_intf);
playlist_item_t *p_item = NULL;
o_selected_indexes = [o_outline_view selectedRowIndexes];
NSUInteger indexes[i_count];
[o_selected_indexes getIndexes:indexes maxCount:i_count inIndexRange:nil];
- for (int i = 0; i < i_count; i++)
- {
+ for (int i = 0; i < i_count; i++) {
p_item = [[o_outline_view itemAtRow: indexes[i]] pointerValue];
- if( p_item && p_item->i_children == -1 )
- playlist_AskForArtEnqueue( p_playlist, p_item->p_input );
+ if (p_item && p_item->i_children == -1)
+ playlist_AskForArtEnqueue(p_playlist, p_item->p_input);
}
[self playlistUpdated];
}
o_selected_indexes = [o_outline_view selectedRowIndexes];
i_count = [o_selected_indexes count];
- p_playlist = pl_Get( p_intf );
+ p_playlist = pl_Get(p_intf);
NSUInteger indexes[i_count];
- if (i_count == [o_outline_view numberOfRows])
- {
+ if (i_count == [o_outline_view numberOfRows]) {
#ifndef NDEBUG
- msg_Dbg( p_intf, "user selected entire list, deleting current playlist root instead of individual items" );
+ msg_Dbg(p_intf, "user selected entire list, deleting current playlist root instead of individual items");
#endif
PL_LOCK;
- playlist_NodeDelete( p_playlist, [self currentPlaylistRoot], true, false );
+ playlist_NodeDelete(p_playlist, [self currentPlaylistRoot], true, false);
PL_UNLOCK;
[self playlistUpdated];
return;
}
[o_selected_indexes getIndexes:indexes maxCount:i_count inIndexRange:nil];
- for (int i = 0; i < i_count; i++)
- {
+ for (int i = 0; i < i_count; i++) {
id o_item = [o_outline_view itemAtRow: indexes[i]];
[o_outline_view deselectRow: indexes[i]];
PL_LOCK;
playlist_item_t *p_item = [o_item pointerValue];
+ if (!p_item || !p_item->p_input) {
+ PL_UNLOCK;
+ continue;
+ }
#ifndef NDEBUG
- msg_Dbg( p_intf, "deleting item %i (of %i) with id \"%i\", pointerValue \"%p\" and %i children", i+1, i_count,
- p_item->p_input->i_id, [o_item pointerValue], p_item->i_children +1 );
+ msg_Dbg(p_intf, "deleting item %i (of %i) with id \"%i\", pointerValue \"%p\" and %i children", i+1, i_count,
+ p_item->p_input->i_id, [o_item pointerValue], p_item->i_children +1);
#endif
- if( p_item->i_children != -1 )
+ if (p_item->i_children != -1) {
//is a node and not an item
- {
- if( playlist_Status( p_playlist ) != PLAYLIST_STOPPED &&
- [self isItem: playlist_CurrentPlayingItem( p_playlist ) inNode: ((playlist_item_t *)[o_item pointerValue])
- checkItemExistence: NO locked:YES] == YES )
+ if (playlist_Status(p_playlist) != PLAYLIST_STOPPED &&
+ [self isItem: playlist_CurrentPlayingItem(p_playlist) inNode: ((playlist_item_t *)[o_item pointerValue])
+ checkItemExistence: NO locked:YES] == YES)
// if current item is in selected node and is playing then stop playlist
- playlist_Control(p_playlist, PLAYLIST_STOP, pl_Locked );
+ playlist_Control(p_playlist, PLAYLIST_STOP, pl_Locked);
- playlist_NodeDelete( p_playlist, p_item, true, false );
- }
- else
- playlist_DeleteFromInput( p_playlist, p_item->p_input, pl_Locked );
+ playlist_NodeDelete(p_playlist, p_item, true, false);
+ } else
+ playlist_DeleteFromInput(p_playlist, p_item->p_input, pl_Locked);
PL_UNLOCK;
[o_outline_dict removeObjectForKey:[NSString stringWithFormat:@"%p", [o_item pointerValue]]];
- (void)sortNode:(int)i_mode
{
- playlist_t * p_playlist = pl_Get( VLCIntf );
+ playlist_t * p_playlist = pl_Get(VLCIntf);
playlist_item_t * p_item;
- if( [o_outline_view selectedRow] > -1 )
- {
+ if ([o_outline_view selectedRow] > -1) {
p_item = [[o_outline_view itemAtRow: [o_outline_view selectedRow]] pointerValue];
- }
- else
- /*If no item is selected, sort the whole playlist*/
- {
- p_item = [self currentPlaylistRoot];
- }
+ if (!p_item)
+ return;
+ } else
+ p_item = [self currentPlaylistRoot]; // If no item is selected, sort the whole playlist
PL_LOCK;
- if( p_item->i_children > -1 ) // the item is a node
- {
- playlist_RecursiveNodeSort( p_playlist, p_item, i_mode, ORDER_NORMAL );
- }
+ if (p_item->i_children > -1) // the item is a node
+ playlist_RecursiveNodeSort(p_playlist, p_item, i_mode, ORDER_NORMAL);
else
- {
- playlist_RecursiveNodeSort( p_playlist,
- p_item->p_parent, i_mode, ORDER_NORMAL );
- }
+ playlist_RecursiveNodeSort(p_playlist, p_item->p_parent, i_mode, ORDER_NORMAL);
+
PL_UNLOCK;
[self playlistUpdated];
}
- (input_item_t *)createItem:(NSDictionary *)o_one_item
{
intf_thread_t * p_intf = VLCIntf;
- playlist_t * p_playlist = pl_Get( p_intf );
+ playlist_t * p_playlist = pl_Get(p_intf);
input_item_t *p_input;
BOOL b_rem = FALSE, b_dir = FALSE, b_writable = FALSE;
o_name = (NSString *)[o_one_item objectForKey: @"ITEM_NAME"];
o_options = (NSArray *)[o_one_item objectForKey: @"ITEM_OPTIONS"];
- if( [[NSFileManager defaultManager] fileExistsAtPath:o_path isDirectory:&b_dir] && b_dir &&
+ if ([[NSFileManager defaultManager] fileExistsAtPath:o_path isDirectory:&b_dir] && b_dir &&
[[NSWorkspace sharedWorkspace] getFileSystemInfoForPath:o_path isRemovable: &b_rem
- isWritable:&b_writable isUnmountable:NULL description:NULL type:NULL] && b_rem && !b_writable && [o_nsurl isFileURL] )
- {
-
+ isWritable:&b_writable isUnmountable:NULL description:NULL type:NULL] && b_rem && !b_writable && [o_nsurl isFileURL]) {
id o_vlc_open = [[VLCMain sharedInstance] open];
- char *diskType = [o_vlc_open getVolumeTypeFromMountPath: o_path];
- msg_Dbg( p_intf, "detected optical media of type '%s' in the file input", diskType );
+ NSString *diskType = [o_vlc_open getVolumeTypeFromMountPath: o_path];
+ msg_Dbg(p_intf, "detected optical media of type %s in the file input", [diskType UTF8String]);
- if (diskType == kVLCMediaDVD)
- {
+ if ([diskType isEqualToString: kVLCMediaDVD])
o_uri = [NSString stringWithFormat: @"dvdnav://%@", [o_vlc_open getBSDNodeFromMountPath: o_path]];
- }
- else if (diskType == kVLCMediaVideoTSFolder)
- {
+ else if ([diskType isEqualToString: kVLCMediaVideoTSFolder])
o_uri = [NSString stringWithFormat: @"dvdnav://%@", o_path];
- }
- else if (diskType == kVLCMediaAudioCD)
- {
+ else if ([diskType isEqualToString: kVLCMediaAudioCD])
o_uri = [NSString stringWithFormat: @"cdda://%@", [o_vlc_open getBSDNodeFromMountPath: o_path]];
- }
- else if (diskType == kVLCMediaVCD)
- {
+ else if ([diskType isEqualToString: kVLCMediaVCD])
o_uri = [NSString stringWithFormat: @"vcd://%@#0:0", [o_vlc_open getBSDNodeFromMountPath: o_path]];
- }
- else if (diskType == kVLCMediaSVCD)
- {
+ else if ([diskType isEqualToString: kVLCMediaSVCD])
o_uri = [NSString stringWithFormat: @"vcd://%@@0:0", [o_vlc_open getBSDNodeFromMountPath: o_path]];
- }
- else if (diskType == kVLCMediaBD || diskType == kVLCMediaBDMVFolder)
- {
+ else if ([diskType isEqualToString: kVLCMediaBD] || [diskType isEqualToString: kVLCMediaBDMVFolder])
o_uri = [NSString stringWithFormat: @"bluray://%@", o_path];
- }
else
- {
- msg_Warn( VLCIntf, "unknown disk type, treating %s as regular input", [o_path UTF8String] );
- }
+ msg_Warn(VLCIntf, "unknown disk type, treating %s as regular input", [o_path UTF8String]);
- p_input = input_item_New( [o_uri UTF8String], [[[NSFileManager defaultManager] displayNameAtPath: o_path] UTF8String] );
+ p_input = input_item_New([o_uri UTF8String], [[[NSFileManager defaultManager] displayNameAtPath: o_path] UTF8String]);
}
else
- p_input = input_item_New( [o_uri fileSystemRepresentation], o_name ? [o_name UTF8String] : NULL );
+ p_input = input_item_New([o_uri fileSystemRepresentation], o_name ? [o_name UTF8String] : NULL);
- if( !p_input )
+ if (!p_input)
return NULL;
- if( o_options )
- {
+ if (o_options) {
NSUInteger count = [o_options count];
- for( NSUInteger i = 0; i < count; i++ )
- {
- input_item_AddOption( p_input, [[o_options objectAtIndex:i] UTF8String],
- VLC_INPUT_OPTION_TRUSTED );
- }
+ for (NSUInteger i = 0; i < count; i++)
+ input_item_AddOption(p_input, [[o_options objectAtIndex:i] UTF8String], VLC_INPUT_OPTION_TRUSTED);
}
/* Recent documents menu */
- if( o_nsurl != nil && (BOOL)config_GetInt( p_playlist, "macosx-recentitems" ) == YES )
- {
+ if (o_nsurl != nil && (BOOL)config_GetInt(p_playlist, "macosx-recentitems") == YES)
[[NSDocumentController sharedDocumentController] noteNewRecentDocumentURL: o_nsurl];
- }
+
return p_input;
}
- (void)appendArray:(NSArray*)o_array atPos:(int)i_position enqueue:(BOOL)b_enqueue
{
- playlist_t * p_playlist = pl_Get( VLCIntf );
+ playlist_t * p_playlist = pl_Get(VLCIntf);
NSUInteger count = [o_array count];
BOOL b_usingPlaylist;
if ([self currentPlaylistRoot] == p_playlist->p_ml_category)
b_usingPlaylist = YES;
PL_LOCK;
- for( NSUInteger i_item = 0; i_item < count; i_item++ )
- {
+ for (NSUInteger i_item = 0; i_item < count; i_item++) {
input_item_t *p_input;
NSDictionary *o_one_item;
/* Get the item */
o_one_item = [o_array objectAtIndex: i_item];
p_input = [self createItem: o_one_item];
- if( !p_input )
- {
+ if (!p_input)
continue;
- }
/* Add the item */
- /* FIXME: playlist_AddInput() can fail */
-
- playlist_AddInput( p_playlist, p_input, PLAYLIST_INSERT, i_position == -1 ? PLAYLIST_END : i_position + i_item, b_usingPlaylist,
- pl_Locked );
+ int returnValue = playlist_AddInput(p_playlist, p_input, PLAYLIST_INSERT, i_position == -1 ? PLAYLIST_END : i_position + i_item, b_usingPlaylist, pl_Locked);
+ if (returnValue != VLC_SUCCESS) {
+ vlc_gc_decref(p_input);
+ continue;
+ }
- if( i_item == 0 && !b_enqueue )
- {
- playlist_item_t *p_item = playlist_ItemGetByInput( p_playlist, p_input );
- playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, pl_Locked, p_item->p_parent, p_item );
+ if (i_item == 0 && !b_enqueue) {
+ playlist_item_t *p_item = playlist_ItemGetByInput(p_playlist, p_input);
+ playlist_Control(p_playlist, PLAYLIST_VIEWPLAY, pl_Locked, p_item->p_parent, p_item);
}
- vlc_gc_decref( p_input );
+ vlc_gc_decref(p_input);
}
PL_UNLOCK;
[self playlistUpdated];
- (void)appendNodeArray:(NSArray*)o_array inNode:(playlist_item_t *)p_node atPos:(int)i_position enqueue:(BOOL)b_enqueue
{
- playlist_t * p_playlist = pl_Get( VLCIntf );
+ playlist_t * p_playlist = pl_Get(VLCIntf);
NSUInteger count = [o_array count];
- for( NSUInteger i_item = 0; i_item < count; i_item++ )
- {
+ for (NSUInteger i_item = 0; i_item < count; i_item++) {
input_item_t *p_input;
NSDictionary *o_one_item;
o_one_item = [o_array objectAtIndex: i_item];
p_input = [self createItem: o_one_item];
- if( !p_input ) continue;
+ if (!p_input)
+ continue;
/* Add the item */
PL_LOCK;
- playlist_NodeAddInput( p_playlist, p_input, p_node,
+ playlist_NodeAddInput(p_playlist, p_input, p_node,
PLAYLIST_INSERT,
i_position == -1 ?
PLAYLIST_END : i_position + i_item,
- pl_Locked );
+ pl_Locked);
- if( i_item == 0 && !b_enqueue )
- {
+ if (i_item == 0 && !b_enqueue) {
playlist_item_t *p_item;
- p_item = playlist_ItemGetByInput( p_playlist, p_input );
- playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, pl_Locked, p_node, p_item );
+ p_item = playlist_ItemGetByInput(p_playlist, p_input);
+ playlist_Control(p_playlist, PLAYLIST_VIEWPLAY, pl_Locked, p_node, p_item);
}
PL_UNLOCK;
- vlc_gc_decref( p_input );
+ vlc_gc_decref(p_input);
}
[self playlistUpdated];
}
- (NSMutableArray *)subSearchItem:(playlist_item_t *)p_item
{
- playlist_t *p_playlist = pl_Get( VLCIntf );
+ playlist_t *p_playlist = pl_Get(VLCIntf);
playlist_item_t *p_selected_item;
int i_selected_row;
p_selected_item = (playlist_item_t *)[[o_outline_view itemAtRow: i_selected_row] pointerValue];
- for( NSUInteger i_current = 0; i_current < p_item->i_children ; i_current++ )
- {
+ for (NSUInteger i_current = 0; i_current < p_item->i_children ; i_current++) {
char *psz_temp;
NSString *o_current_name, *o_current_author;
PL_LOCK;
o_current_name = [NSString stringWithUTF8String:
p_item->pp_children[i_current]->p_input->psz_name];
- psz_temp = input_item_GetInfo( p_item->p_input ,
- _("Meta-information"),_("Artist") );
+ psz_temp = input_item_GetInfo(p_item->p_input ,
+ _("Meta-information"),_("Artist"));
o_current_author = [NSString stringWithUTF8String: psz_temp];
- free( psz_temp);
+ free(psz_temp);
PL_UNLOCK;
- if( p_selected_item == p_item->pp_children[i_current] &&
- b_selected_item_met == NO )
- {
+ if (p_selected_item == p_item->pp_children[i_current] && b_selected_item_met == NO)
b_selected_item_met = YES;
- }
- else if( p_selected_item == p_item->pp_children[i_current] &&
- b_selected_item_met == YES )
- {
+ else if (p_selected_item == p_item->pp_children[i_current] && b_selected_item_met == YES)
return NULL;
- }
- else if( b_selected_item_met == YES &&
- ( [o_current_name rangeOfString:[o_search_field
+ else if (b_selected_item_met == YES &&
+ ([o_current_name rangeOfString:[o_search_field
stringValue] options:NSCaseInsensitiveSearch].length ||
[o_current_author rangeOfString:[o_search_field
- stringValue] options:NSCaseInsensitiveSearch].length ) )
- {
+ stringValue] options:NSCaseInsensitiveSearch].length))
/*Adds the parent items in the result array as well, so that we can
expand the tree*/
- return [NSMutableArray arrayWithObject: [NSValue
- valueWithPointer: p_item->pp_children[i_current]]];
- }
- if( p_item->pp_children[i_current]->i_children > 0 )
- {
+ return [NSMutableArray arrayWithObject: [NSValue valueWithPointer: p_item->pp_children[i_current]]];
+
+ if (p_item->pp_children[i_current]->i_children > 0) {
id o_result = [self subSearchItem:
p_item->pp_children[i_current]];
- if( o_result != NULL )
- {
+ if (o_result != NULL) {
[o_result insertObject: [NSValue valueWithPointer:
p_item->pp_children[i_current]] atIndex:0];
return o_result;
- (IBAction)searchItem:(id)sender
{
- playlist_t * p_playlist = pl_Get( VLCIntf );
+ playlist_t * p_playlist = pl_Get(VLCIntf);
id o_result;
int i_row = -1;
b_selected_item_met = NO;
- /*First, only search after the selected item:*
- *(b_selected_item_met = NO) */
+ /* First, only search after the selected item:
+ * (b_selected_item_met = NO) */
o_result = [self subSearchItem:[self currentPlaylistRoot]];
- if( o_result == NULL )
- {
+ if (o_result == NULL)
/* If the first search failed, search again from the beginning */
o_result = [self subSearchItem:[self currentPlaylistRoot]];
- }
- if( o_result != NULL )
- {
+
+ if (o_result != NULL) {
int i_start;
- if( [[o_result objectAtIndex: 0] pointerValue] == p_playlist->p_local_category )
+ if ([[o_result objectAtIndex: 0] pointerValue] == p_playlist->p_local_category)
i_start = 1;
else
i_start = 0;
NSUInteger count = [o_result count];
- for( NSUInteger i = i_start ; i < count - 1 ; i++ )
- {
+ for (NSUInteger i = i_start ; i < count - 1 ; i++) {
[o_outline_view expandItem: [o_outline_dict objectForKey:
[NSString stringWithFormat: @"%p",
[[o_result objectAtIndex: i] pointerValue]]]];
[[o_result objectAtIndex: count - 1 ]
pointerValue]]]];
}
- if( i_row > -1 )
- {
+ if (i_row > -1) {
[o_outline_view selectRowIndexes:[NSIndexSet indexSetWithIndex:i_row] byExtendingSelection:NO];
[o_outline_view scrollRowToVisible: i_row];
}
o_item = [o_outline_view itemAtRow: indexes[i]];
p_item = (playlist_item_t *)[o_item pointerValue];
- if( ![[o_outline_view dataSource] outlineView: o_outline_view isItemExpandable: o_item] )
+ if (![[o_outline_view dataSource] outlineView: o_outline_view isItemExpandable: o_item])
o_item = [o_outline_dict objectForKey: [NSString stringWithFormat: @"%p", p_item->p_parent]];
/* We need to collapse the node first, since OSX refuses to recursively
pt = [o_outline_view convertPoint: [o_event locationInWindow] fromView: nil];
int row = [o_outline_view rowAtPoint:pt];
- if( row != -1 && ![[o_outline_view selectedRowIndexes] containsIndex: row] )
+ if (row != -1 && ![[o_outline_view selectedRowIndexes] containsIndex: row])
[o_outline_view selectRowIndexes:[NSIndexSet indexSetWithIndex:row] byExtendingSelection:NO];
- b_item_sel = ( row != -1 && [o_outline_view selectedRow] != -1 );
+ b_item_sel = (row != -1 && [o_outline_view selectedRow] != -1);
b_rows = [o_outline_view numberOfRows] != 0;
[o_mi_play setEnabled: b_item_sel];
[o_mi_sort_name setEnabled: b_item_sel];
[o_mi_sort_author setEnabled: b_item_sel];
- return( o_ctx_menu );
+ return(o_ctx_menu);
}
- (void)outlineView: (NSOutlineView *)o_tv didClickTableColumn:(NSTableColumn *)o_tc
intf_thread_t *p_intf = VLCIntf;
NSString * o_identifier = [o_tc identifier];
- playlist_t *p_playlist = pl_Get( p_intf );
+ playlist_t *p_playlist = pl_Get(p_intf);
- if( [o_identifier isEqualToString:TRACKNUM_COLUMN] )
+ if ([o_identifier isEqualToString:TRACKNUM_COLUMN])
i_mode = SORT_TRACK_NUMBER;
- else if( [o_identifier isEqualToString:TITLE_COLUMN] )
+ else if ([o_identifier isEqualToString:TITLE_COLUMN])
i_mode = SORT_TITLE;
- else if( [o_identifier isEqualToString:ARTIST_COLUMN] )
+ else if ([o_identifier isEqualToString:ARTIST_COLUMN])
i_mode = SORT_ARTIST;
- else if( [o_identifier isEqualToString:GENRE_COLUMN] )
+ else if ([o_identifier isEqualToString:GENRE_COLUMN])
i_mode = SORT_GENRE;
- else if( [o_identifier isEqualToString:DURATION_COLUMN] )
+ else if ([o_identifier isEqualToString:DURATION_COLUMN])
i_mode = SORT_DURATION;
- else if( [o_identifier isEqualToString:ALBUM_COLUMN] )
+ else if ([o_identifier isEqualToString:ALBUM_COLUMN])
i_mode = SORT_ALBUM;
- else if( [o_identifier isEqualToString:DESCRIPTION_COLUMN] )
+ else if ([o_identifier isEqualToString:DESCRIPTION_COLUMN])
i_mode = SORT_DESCRIPTION;
- else if( [o_identifier isEqualToString:URI_COLUMN] )
+ else if ([o_identifier isEqualToString:URI_COLUMN])
i_mode = SORT_URI;
else
return;
- if( o_tc_sortColumn == o_tc )
+ if (o_tc_sortColumn == o_tc)
b_isSortDescending = !b_isSortDescending;
else
b_isSortDescending = false;
- if( b_isSortDescending )
+ if (b_isSortDescending)
i_type = ORDER_REVERSE;
else
i_type = ORDER_NORMAL;
PL_LOCK;
- playlist_RecursiveNodeSort( p_playlist, [self currentPlaylistRoot], i_mode, i_type );
+ playlist_RecursiveNodeSort(p_playlist, [self currentPlaylistRoot], i_mode, i_type);
PL_UNLOCK;
[self playlistUpdated];
o_tc_sortColumn = o_tc;
[o_outline_view setHighlightedTableColumn:o_tc];
- if( b_isSortDescending )
+ if (b_isSortDescending)
[o_outline_view setIndicatorImage:o_descendingSortingImage inTableColumn:o_tc];
else
[o_outline_view setIndicatorImage:o_ascendingSortingImage inTableColumn:o_tc];
intf_thread_t * p_intf = VLCIntf;
if (!p_intf)
return;
- playlist_t *p_playlist = pl_Get( p_intf );
+ playlist_t *p_playlist = pl_Get(p_intf);
if (!p_playlist)
return;
id o_playing_item;
PL_LOCK;
- o_playing_item = [o_outline_dict objectForKey: [NSString stringWithFormat:@"%p", playlist_CurrentPlayingItem( p_playlist )]];
+ o_playing_item = [o_outline_dict objectForKey: [NSString stringWithFormat:@"%p", playlist_CurrentPlayingItem(p_playlist)]];
PL_UNLOCK;
- if( [self isItem: [o_playing_item pointerValue] inNode:
- [item pointerValue] checkItemExistence: YES]
- || [o_playing_item isEqual: item] )
- {
+ if ([self isItem: [o_playing_item pointerValue] inNode: [item pointerValue] checkItemExistence:YES locked:NO]
+ || [o_playing_item isEqual: item])
[cell setFont: [[NSFontManager sharedFontManager] convertFont:[cell font] toHaveTrait:NSBoldFontMask]];
- }
else
- {
[cell setFont: [[NSFontManager sharedFontManager] convertFont:[cell font] toNotHaveTrait:NSBoldFontMask]];
- }
}
- (id)playingItem
{
- playlist_t *p_playlist = pl_Get( VLCIntf );
+ playlist_t *p_playlist = pl_Get(VLCIntf);
id o_playing_item;
PL_LOCK;
- o_playing_item = [o_outline_dict objectForKey: [NSString stringWithFormat:@"%p", playlist_CurrentPlayingItem( p_playlist )]];
+ o_playing_item = [o_outline_dict objectForKey: [NSString stringWithFormat:@"%p", playlist_CurrentPlayingItem(p_playlist)]];
PL_UNLOCK;
return o_playing_item;
{
NSTableColumn * o_work_tc;
- if (i_state == NSOnState)
- {
+ if (i_state == NSOnState) {
o_work_tc = [[NSTableColumn alloc] initWithIdentifier: o_column];
[o_work_tc setEditable: NO];
[[o_work_tc dataCell] setFont: [NSFont controlContentFontOfSize:11.]];
[[o_work_tc headerCell] setStringValue: [o_dict objectForKey:o_column]];
- if ([o_column isEqualToString: TRACKNUM_COLUMN])
- {
- [o_work_tc setMaxWidth: 20.];
+ if ([o_column isEqualToString: TRACKNUM_COLUMN]) {
+ [o_work_tc setWidth: 20.];
+ [o_work_tc setResizingMask: NSTableColumnNoResizing];
[[o_work_tc headerCell] setStringValue: @"#"];
}
- else if ([o_column isEqualToString: TITLE_COLUMN])
- {
- [o_work_tc setResizingMask: NSTableColumnAutoresizingMask | NSTableColumnUserResizingMask];
- }
[o_outline_view addTableColumn: o_work_tc];
[o_work_tc release];
}
else
[o_outline_view removeTableColumn: [o_outline_view tableColumnWithIdentifier: o_column]];
+
+ [o_outline_view setOutlineTableColumn: [o_outline_view tableColumnWithIdentifier:TITLE_COLUMN]];
}
- (void)saveTableColumns
NSArray * o_columns = [[NSArray alloc] initWithArray:[o_outline_view tableColumns]];
NSUInteger count = [o_columns count];
NSTableColumn * o_currentColumn;
- for (NSUInteger i = 0; i < count; i++)
- {
+ for (NSUInteger i = 0; i < count; i++) {
o_currentColumn = [o_columns objectAtIndex: i];
[o_arrayToSave addObject: [NSArray arrayWithObjects: [o_currentColumn identifier], [NSNumber numberWithFloat: [o_currentColumn width]], nil]];
}
/* Required for drag & drop and reordering */
- (BOOL)outlineView:(NSOutlineView *)outlineView writeItems:(NSArray *)items toPasteboard:(NSPasteboard *)pboard
{
- playlist_t *p_playlist = pl_Get( VLCIntf );
+ playlist_t *p_playlist = pl_Get(VLCIntf);
/* First remove the items that were moved during the last drag & drop
operation */
NSUInteger itemCount = [items count];
- for( NSUInteger i = 0 ; i < itemCount ; i++ )
- {
+ for (NSUInteger i = 0 ; i < itemCount ; i++) {
id o_item = [items objectAtIndex: i];
/* Fill the items and nodes to move in 2 different arrays */
- if( ((playlist_item_t *)[o_item pointerValue])->i_children > 0 )
+ if (((playlist_item_t *)[o_item pointerValue])->i_children > 0)
[o_nodes_array addObject: o_item];
else
[o_items_array addObject: o_item];
- (NSDragOperation)outlineView:(NSOutlineView *)outlineView validateDrop:(id <NSDraggingInfo>)info proposedItem:(id)item proposedChildIndex:(NSInteger)index
{
- playlist_t *p_playlist = pl_Get( VLCIntf );
+ playlist_t *p_playlist = pl_Get(VLCIntf);
NSPasteboard *o_pasteboard = [info draggingPasteboard];
- if( !p_playlist ) return NSDragOperationNone;
+ if (!p_playlist) return NSDragOperationNone;
/* Dropping ON items is not allowed if item is not a node */
- if( item )
- {
- if( index == NSOutlineViewDropOnItemIndex &&
- ((playlist_item_t *)[item pointerValue])->i_children == -1 )
- {
+ if (item) {
+ if (index == NSOutlineViewDropOnItemIndex &&
+ ((playlist_item_t *)[item pointerValue])->i_children == -1) {
return NSDragOperationNone;
}
}
/* We refuse to drop an item in anything else than a child of the General
Node. We still accept items that would be root nodes of the outlineview
however, to allow drop in an empty playlist. */
- if( !( ([self isItem: [item pointerValue] inNode: p_playlist->p_local_category checkItemExistence: NO] ||
- ( var_CreateGetBool( p_playlist, "media-library" ) && [self isItem: [item pointerValue] inNode: p_playlist->p_ml_category checkItemExistence: NO] ) ) || item == nil ) )
- {
+ if (!(([self isItem: [item pointerValue] inNode: p_playlist->p_local_category checkItemExistence: NO locked: NO] ||
+ (var_CreateGetBool(p_playlist, "media-library") && [self isItem: [item pointerValue] inNode: p_playlist->p_ml_category checkItemExistence: NO locked: NO])) || item == nil)) {
return NSDragOperationNone;
}
/* Drop from the Playlist */
- if( [[o_pasteboard types] containsObject: @"VLCPlaylistItemPboardType"] )
- {
+ if ([[o_pasteboard types] containsObject: @"VLCPlaylistItemPboardType"]) {
NSUInteger count = [o_nodes_array count];
- for( NSUInteger i = 0 ; i < count ; i++ )
- {
+ for (NSUInteger i = 0 ; i < count ; i++) {
/* We refuse to Drop in a child of an item we are moving */
- if( [self isItem: [item pointerValue] inNode:
- [[o_nodes_array objectAtIndex: i] pointerValue]
- checkItemExistence: NO] )
- {
+ if ([self isItem: [item pointerValue] inNode: [[o_nodes_array objectAtIndex: i] pointerValue] checkItemExistence: NO locked:NO]) {
return NSDragOperationNone;
}
}
return NSDragOperationMove;
}
-
/* Drop from the Finder */
- else if( [[o_pasteboard types] containsObject: NSFilenamesPboardType] )
- {
+ else if ([[o_pasteboard types] containsObject: NSFilenamesPboardType]) {
return NSDragOperationGeneric;
}
return NSDragOperationNone;
- (BOOL)outlineView:(NSOutlineView *)outlineView acceptDrop:(id <NSDraggingInfo>)info item:(id)item childIndex:(NSInteger)index
{
- playlist_t * p_playlist = pl_Get( VLCIntf );
+ playlist_t * p_playlist = pl_Get(VLCIntf);
NSPasteboard *o_pasteboard = [info draggingPasteboard];
/* Drag & Drop inside the playlist */
- if( [[o_pasteboard types] containsObject: @"VLCPlaylistItemPboardType"] )
- {
+ if ([[o_pasteboard types] containsObject: @"VLCPlaylistItemPboardType"]) {
+ if (index == -1) // this is no valid target, sanitize to top of table
+ index = 0;
+
int i_row = 0;
playlist_item_t *p_new_parent, *p_item = NULL;
NSArray *o_all_items = [o_nodes_array arrayByAddingObjectsFromArray: o_items_array];
/* If the item is to be dropped as root item of the outline, make it a
child of the respective general node, if is either the pl or the ml
Else, choose the proposed parent as parent. */
- if( item == nil )
- {
+ if (item == nil) {
if ([self currentPlaylistRoot] == p_playlist->p_local_category || [self currentPlaylistRoot] == p_playlist->p_ml_category)
p_new_parent = [self currentPlaylistRoot];
else
/* Make sure the proposed parent is a node.
(This should never be true) */
- if( p_new_parent->i_children < 0 )
- {
+ if (p_new_parent->i_children < 0)
return NO;
- }
NSUInteger count = [o_all_items count];
- if( count == 0 )
+ if (count == 0)
return NO;
- playlist_item_t **pp_items = (playlist_item_t **)calloc( count, sizeof( playlist_item_t* ) );
- if ( !pp_items )
+ playlist_item_t **pp_items = (playlist_item_t **)calloc(count, sizeof(playlist_item_t*));
+ if (!pp_items)
return NO;
PL_LOCK;
NSUInteger j = 0;
- for( NSUInteger i = 0; i < count; i++ )
- {
+ for (NSUInteger i = 0; i < count; i++) {
p_item = [[o_all_items objectAtIndex:i] pointerValue];
- if( p_item )
+ if (p_item)
pp_items[j++] = p_item;
}
- if( j == 0 || playlist_TreeMoveMany( p_playlist, j, pp_items, p_new_parent, index ) != VLC_SUCCESS )
- {
+ if (j == 0 || playlist_TreeMoveMany(p_playlist, j, pp_items, p_new_parent, index) != VLC_SUCCESS) {
PL_UNLOCK;
- free( pp_items );
+ free(pp_items);
return NO;
}
PL_UNLOCK;
- free( pp_items );
+ free(pp_items);
[self playlistUpdated];
i_row = [o_outline_view rowForItem:[o_outline_dict objectForKey:[NSString stringWithFormat: @"%p", [[o_all_items objectAtIndex: 0] pointerValue]]]];
- if( i_row == -1 )
- {
+ if (i_row == -1)
i_row = [o_outline_view rowForItem:[o_outline_dict objectForKey:[NSString stringWithFormat: @"%p", p_new_parent]]];
- }
[o_outline_view deselectAll: self];
[o_outline_view selectRowIndexes:[NSIndexSet indexSetWithIndex:i_row] byExtendingSelection:NO];
return YES;
}
- else if( [[o_pasteboard types] containsObject: NSFilenamesPboardType] )
- {
+ else if ([[o_pasteboard types] containsObject: NSFilenamesPboardType]) {
if ([self currentPlaylistRoot] != p_playlist->p_local_category && [self currentPlaylistRoot] != p_playlist->p_ml_category)
return NO;
sortedArrayUsingSelector: @selector(caseInsensitiveCompare:)];
NSUInteger count = [o_values count];
NSMutableArray *o_array = [NSMutableArray arrayWithCapacity:count];
- input_thread_t * p_input = pl_CurrentInput( VLCIntf );
+ input_thread_t * p_input = pl_CurrentInput(VLCIntf);
BOOL b_returned = NO;
- if (count == 1 && p_input)
- {
- b_returned = input_AddSubtitle( p_input, make_URI([[o_values objectAtIndex:0] UTF8String], NULL), true );
- vlc_object_release( p_input );
- if(!b_returned)
+ if (count == 1 && p_input) {
+ b_returned = input_AddSubtitle(p_input, vlc_path2uri([[o_values objectAtIndex:0] UTF8String], NULL), true);
+ vlc_object_release(p_input);
+ if (!b_returned)
return YES;
}
- else if( p_input )
- vlc_object_release( p_input );
+ else if (p_input)
+ vlc_object_release(p_input);
- for( NSUInteger i = 0; i < count; i++)
- {
+ for (NSUInteger i = 0; i < count; i++) {
NSDictionary *o_dic;
- char *psz_uri = make_URI([[o_values objectAtIndex:i] UTF8String], NULL);
- if( !psz_uri )
+ char *psz_uri = vlc_path2uri([[o_values objectAtIndex:i] UTF8String], NULL);
+ if (!psz_uri)
continue;
o_dic = [NSDictionary dictionaryWithObject:[NSString stringWithCString:psz_uri encoding:NSUTF8StringEncoding] forKey:@"ITEM_URL"];
- free( psz_uri );
+ free(psz_uri);
[o_array addObject: o_dic];
}
- if ( item == nil )
- {
+ if (item == nil)
[self appendArray:o_array atPos:index enqueue: YES];
- }
- else
- {
- assert( p_node->i_children != -1 );
+ else {
+ assert(p_node->i_children != -1);
[self appendNodeArray:o_array inNode: p_node atPos:index enqueue:YES];
}
return YES;