]> git.sesse.net Git - vlc/blobdiff - modules/gui/macosx/playlist.m
* MainMenu.nib, playlist.m: use NSSearchField instead of NSTextField, so we don't...
[vlc] / modules / gui / macosx / playlist.m
index ee3ac59cc306cd59cde6f5f46f795fd0d59090c8..9bf6fd8d9f5aa0c93bb9380d325f5e48ee00df75 100644 (file)
@@ -20,7 +20,7 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 
 /* TODO
@@ -49,7 +49,7 @@
 #import "bookmarks.h"
 #include "playlist.h"
 #include "controls.h"
-#include "osd.h"
+#include "vlc_osd.h"
 #include "misc.h"
 
 /*****************************************************************************
     [o_outline_view setDoubleAction: @selector(playItem:)];
 
     [o_outline_view registerForDraggedTypes:
-        [NSArray arrayWithObjects: NSFilenamesPboardType, nil]];
+        [NSArray arrayWithObjects: NSFilenamesPboardType,
+        @"VLCPlaylistItemPboardType", nil]];
     [o_outline_view setIntercellSpacing: NSMakeSize (0.0, 1.0)];
 
 /* We need to check whether _defaultTableHeaderSortImage exists, since it 
@@ -462,27 +463,6 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
     vlc_list_release( p_list );
     vlc_object_release( p_playlist );
 
-    /* Change the simple textfield into a searchField if we can... */
-#if 0
-    if( MACOS_VERSION >= 10.3 )
-    {
-        NSView *o_parentview = [o_status_field superview];
-        NSSearchField *o_better_search_field = [[NSSearchField alloc]initWithFrame:[o_search_field frame]];
-        [o_better_search_field setRecentsAutosaveName:@"VLC media player search"];
-        [o_better_search_field setDelegate:self];
-        [[NSNotificationCenter defaultCenter] addObserver: self
-            selector: @selector(searchfieldChanged:)
-            name: NSControlTextDidChangeNotification
-            object: o_better_search_field];
-
-        [o_better_search_field setTarget:self];
-        [o_better_search_field setAction:@selector(searchItem:)];
-
-        [o_better_search_field setAutoresizingMask:NSViewMinXMargin];
-        [o_parentview addSubview:o_better_search_field];
-        [o_search_field setHidden:YES];
-    }
-#endif
     //[self playlistUpdated];
 }
 
@@ -506,7 +486,7 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
     [o_mi_sort_author setTitle: _NS("Sort Node by Author")];
     [o_mi_services setTitle: _NS("Services discovery")];
     [o_status_field setStringValue: [NSString stringWithFormat:
-                        _NS("no items in playlist")]];
+                        _NS("No items in the playlist")]];
 
     [o_random_ckb setTitle: _NS("Random")];
 #if 0
@@ -516,13 +496,14 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
     [[o_loop_popup itemAtIndex:0] setTitle: _NS("Standard Play")];
     [[o_loop_popup itemAtIndex:1] setTitle: _NS("Repeat One")];
     [[o_loop_popup itemAtIndex:2] setTitle: _NS("Repeat All")];
+    [o_mi_addNode setTitle: _NS("Add Folder to Playlist")];
 }
 
 - (void)playlistUpdated
 {
     unsigned int i;
 
-    /* Clear indications of any existing column sorting*/
+    /* Clear indications of any existing column sorting */
     for( i = 0 ; i < [[o_outline_view tableColumns] count] ; i++ )
     {
         [o_outline_view setIndicatorImage:nil inTableColumn:
@@ -585,7 +566,6 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
 
 - (void)updateRowSelection
 {
-//    int i;
     int i_row;
     unsigned int j;
 
@@ -785,7 +765,6 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
     {
         playlist_item_t *p_item;
         playlist_item_t *p_node = NULL;
-//        int i;
 
         p_item = [[o_outline_view itemAtRow:[o_outline_view selectedRow]] pointerValue];
 
@@ -1495,6 +1474,28 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
     vlc_object_release( p_playlist );
 }
 
+- (IBAction)addNode:(id)sender
+{
+    /* simply adds a new node to the end of the playlist */
+    playlist_t * p_playlist = vlc_object_find( VLCIntf, VLC_OBJECT_PLAYLIST,
+                                          FIND_ANYWHERE );
+    if( !p_playlist )
+    {
+        msg_Err( VLCIntf, "Uh Oh! Unable to find playlist!" );
+        return;
+    }
+
+    playlist_item_t * p_item = playlist_NodeCreate( p_playlist, VIEW_CATEGORY, 
+        _("Empty Folder"), p_playlist->p_general );
+
+    if(! p_item )
+        msg_Warn( VLCIntf, "node creation failed, fix VLC!" );
+    
+    playlist_ViewUpdate( p_playlist, VIEW_CATEGORY );
+    
+    vlc_object_release( p_playlist );
+}
+
 @end
 
 @implementation VLCPlaylist (NSOutlineViewDataSource)
@@ -1510,19 +1511,17 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
     if( p_playlist->i_size >= 2 )
     {
         [o_status_field setStringValue: [NSString stringWithFormat:
-                    _NS("%i items in playlist"), p_playlist->i_size]];
+                    _NS("%i items in the playlist"), p_playlist->i_size]];
     }
     else
     {
         if( p_playlist->i_size == 0 )
         {
-            [o_status_field setStringValue: [NSString stringWithFormat:
-                    _NS("no items in playlist"), p_playlist->i_size]];
+            [o_status_field setStringValue: _NS("No items in the playlist")];
         }
         else
         {
-            [o_status_field setStringValue: [NSString stringWithFormat:
-                    _NS("1 item in playlist"), p_playlist->i_size]];
+            [o_status_field setStringValue: _NS("1 item in the playlist")];
         }
     }
     vlc_object_release( p_playlist );
@@ -1572,50 +1571,12 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
     [self removeItemsFrom: o_nodes_array ifChildrenOf: o_nodes_array];
     [self removeItemsFrom: o_items_array ifChildrenOf: o_nodes_array];
 
-#if 0
-    unsigned int j;
-
-    for( i = 0 ; i < [o_nodes_array count] ; i++ )
-    {
-        for ( j = 0 ; j < [o_nodes_array count] ; j++ )
-        {
-            if( j == i ) continue;
-            if( [self isItem: [[o_nodes_array objectAtIndex:i] pointerValue]
-                    inNode: [[o_nodes_array objectAtIndex:j] pointerValue]] )
-            {
-                [o_nodes_array removeObjectAtIndex:i];
-                /* We need to execute the next iteration with the same index
-                   since the current item has been deleted */
-                i--;
-                break;
-            }
-        }
-    }
-
-    for( i = 0 ; i < [o_items_array count] ; i++ )
-    {
-        for ( j = 0 ; j < [o_nodes_array count] ; j++ )
-        {
-            if( [self isItem: [[o_items_array objectAtIndex:i] pointerValue]
-                    inNode: [[o_nodes_array objectAtIndex:j] pointerValue]] )
-            {
-                [o_items_array removeObjectAtIndex:i];
-                i--;
-                break;
-            }
-        }
-    }
-#endif
     /* We add the "VLCPlaylistItemPboardType" type to be able to recognize
-       a Drop operation comçing from the playlist.
-       We need to add NSFilenamesPboardType otherwise the outlineview refuses
-       to the drop. */
+       a Drop operation coming from the playlist. */
 
     [pboard declareTypes: [NSArray arrayWithObjects:
-        @"VLCPlaylistItemPboardType",NSFilenamesPboardType, nil] owner: self];
+        @"VLCPlaylistItemPboardType", nil] owner: self];
     [pboard setData:[NSData data] forType:@"VLCPlaylistItemPboardType"];
-    [pboard setPropertyList:[NSArray array]
-                                        forType:NSFilenamesPboardType];
 
     vlc_object_release(p_playlist);
     return YES;
@@ -1628,12 +1589,16 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
     NSPasteboard *o_pasteboard = [info draggingPasteboard];
 
     if( !p_playlist ) return NSDragOperationNone;
-    
-    /* Dropping ON items is not allowed */
-    if( index == NSOutlineViewDropOnItemIndex )
+
+    /* Dropping ON items is not allowed if item is not a node */
+    if( item )
     {
-        vlc_object_release( p_playlist );
-        return NSDragOperationNone;
+        if( index == NSOutlineViewDropOnItemIndex &&
+                ((playlist_item_t *)[item pointerValue])->i_children == -1 )
+        {
+            vlc_object_release( p_playlist );
+            return NSDragOperationNone;
+        }
     }
 
     /* We refuse to drop an item in anything else than a child of the General
@@ -1686,7 +1651,7 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
     /* Drag & Drop inside the playlist */
     if( [[o_pasteboard types] containsObject: @"VLCPlaylistItemPboardType"] )
     {
-        int i_row;
+        int i_row, i_removed_from_node = 0;
         unsigned int i;
         playlist_item_t *p_new_parent, *p_item = NULL;
         NSArray *o_all_items = [o_nodes_array arrayByAddingObjectsFromArray:
@@ -1694,35 +1659,15 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
         /* If the item is to be dropped as root item of the outline, make it a
            child of the General node.
            Else, choose the proposed parent as parent. */
-        if( item == nil )
-        p_new_parent = p_playlist->p_general;
-        else
-        p_new_parent = [item pointerValue];
+        if( item == nil ) p_new_parent = p_playlist->p_general;
+        else p_new_parent = [item pointerValue];
 
-        /* If the proposed parent is not a node, then use the parent node of
-           this item. */
-        if( p_new_parent->i_children <= 0 )
+        /* Make sure the proposed parent is a node.
+           (This should never be true) */
+        if( p_new_parent->i_children < 0 )
         {
-            int j;
-            playlist_item_t *p_temp_item = p_new_parent;
-            p_new_parent = [self parentOfItem: p_new_parent];
-            if( !p_new_parent )
-            {
-                vlc_object_release(p_playlist);
-                return NO;
-            }
-            /* Calculate the position of the dropped item in this new parent:
-               following the first proposed parent. */
-            for( j = 0; j < p_new_parent->i_children; j++ )
-            {
-                if( p_new_parent->pp_children[j] == p_temp_item )
-                {
-                    index = j;
-                    break;
-                }
-                else if( j == p_new_parent->i_children - 1 )
-                index = -1;
-            }
+            vlc_object_release( p_playlist );
+            return NO;
         }
 
         for( i = 0; i < [o_all_items count]; i++ )
@@ -1748,18 +1693,6 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
                 }
             }
 
-
-            /* If we move the playing item in a different node or we move the
-               node containing the playing item in a different node, then stop
-               playback, or the playlist refuses to detach the item. */
-/*            if( p_playlist->status.i_status != PLAYLIST_STOPPED &&
-                (( p_item == p_playlist->status.p_item &&
-                p_new_parent != p_old_parent) ||
-                ( p_item->i_children > 0 &&
-                [self isItem: p_playlist->status.p_item inNode:p_item] == YES))
-            {
-                playlist_Stop( p_playlist );
-            }*/
             vlc_mutex_lock( &p_playlist->object_lock );
             // Acually detach the item from the old position
             if( playlist_NodeRemoveItem( p_playlist, p_item, p_old_parent ) ==
@@ -1773,12 +1706,15 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
                 i_new_index = -1;
                 /* If we move the item in the same node, we need to take into
                    account that one item will be deleted */
-                else if((p_new_parent == p_old_parent &&
-                                                i_old_index < index + (int)i)
-                       || p_new_parent == p_playlist->p_general || index == 0 )
-                i_new_index = index + i;
                 else
-                i_new_index = index + i + 1;
+                {
+                    if ((p_new_parent == p_old_parent &&
+                                   i_old_index < index + (int)i) )
+                    {
+                        i_removed_from_node++;
+                    }
+                    i_new_index = index + i - i_removed_from_node;
+                }
                 // Reattach the item to the new position
                 playlist_NodeInsert( p_playlist, i_current_view, p_item,
                                                     p_new_parent, i_new_index );
@@ -1827,26 +1763,11 @@ belongs to an Apple hidden private API, and then can "disapear" at any time*/
         {
             [self appendArray: o_array atPos: index enqueue: YES];
         }
+        /* This should never occur */
         else if( p_node->i_children == -1 )
         {
-            int i_counter;
-            playlist_item_t *p_real_node = NULL;
-
-            for( i_counter = 0 ; i_counter < p_node->i_parents ; i_counter++ )
-            {
-                if( p_node->pp_parents[i_counter]->i_view == i_current_view )
-                {
-                    p_real_node = p_node->pp_parents[i_counter]->p_parent;
-                    break;
-                }
-                if( i_counter == p_node->i_parents )
-                {
-                    vlc_object_release(p_playlist);
-                    return NO;
-                }
-            }
-            [self appendNodeArray: o_array inNode: p_real_node
-                atPos: index inView: i_current_view enqueue: YES];
+            vlc_object_release( p_playlist );
+            return NO;
         }
         else
         {