]> git.sesse.net Git - vlc/blobdiff - modules/gui/macosx/playlist.m
Check the return value of services_discovery_GetServicesNames.
[vlc] / modules / gui / macosx / playlist.m
index aeba4123db44de9b6e763d23d30dbbcd27ed9b5c..ae095c962a0ca54c86f641e375335d077e093dd8 100644 (file)
@@ -1,7 +1,7 @@
 /*****************************************************************************
  * playlist.m: MacOS X interface module
  *****************************************************************************
-* Copyright (C) 2002-2006 the VideoLAN team
+* Copyright (C) 2002-2008 the VideoLAN team
  * $Id$
  *
  * Authors: Jon Lech Johansen <jon-vl@nanocrew.net>
@@ -25,7 +25,6 @@
 
 /* TODO
  * add 'icons' for different types of nodes? (http://www.cocoadev.com/index.pl?IconAndTextInTableCell)
- * create toggle buttons for the shuffle, repeat one, repeat all functions.
  * reimplement enable/disable item
  * create a new 'tool' button (see the gear button in the Finder window) for 'actions'
    (adding service discovery, other views, new node/playlist, save node/playlist) stuff like that
@@ -53,7 +52,7 @@
 #import <vlc_interface.h>
 
 /*****************************************************************************
- * VLCPlaylistView implementation 
+ * VLCPlaylistView implementation
  *****************************************************************************/
 @implementation VLCPlaylistView
 
@@ -82,8 +81,7 @@
 
         case NSEnterCharacter:
         case NSCarriageReturnCharacter:
-            [(VLCPlaylist *)[[VLCMain sharedInstance] getPlaylist]
-                                                            playItem:self];
+            [(VLCPlaylist *)[[VLCMain sharedInstance] getPlaylist] playItem:self];
             break;
 
         default:
         p_item = (playlist_item_t *)[item pointerValue];
     }
     if( p_item )
-            i_return = p_item->i_children;
+        i_return = p_item->i_children;
     vlc_object_release( p_playlist );
 
-    if( i_return <= 0 )
-        i_return = 0;
-
-    return i_return;
+    return i_return > 0 ? i_return : 0;
 }
 
 /* return the child at index for the Obj-C pointer item */ /* DONE */
     }
     else
     {
-        p_item = (playlist_item_t *)[item pointerValue];      
+        p_item = (playlist_item_t *)[item pointerValue];
     }
     if( p_item && index < p_item->i_children && index >= 0 )
         p_return = p_item->pp_children[index];
-    
     vlc_object_release( p_playlist );
 
     o_value = [o_outline_dict objectForKey:[NSString stringWithFormat: @"%p", p_return]];
 
     if( o_value == nil )
     {
+        msg_Warn( VLCIntf, "playlist item misses pointer value, adding one" );
         o_value = [[NSValue valueWithPointer: p_return] retain];
-        msg_Err( VLCIntf, "missing playlist item's pointer value" );
     }
     return o_value;
 }
         }
         return @"error" ;
     }
-    
     p_item = (playlist_item_t *)[item pointerValue];
     if( !p_item || !p_item->p_input )
     {
         }
         return @"error";
     }
-    
     attempted_reload = NO;
 
     if( [[o_tc identifier] isEqualToString:@"1"] )
     {
         /* sanity check to prevent the NSString class from crashing */
-        if( p_item->p_input->p_meta && p_item->p_input->p_meta->psz_title && 
-            *p_item->p_input->p_meta->psz_title )
+        char *psz_title =  input_item_GetTitle( p_item->p_input );
+        if( !EMPTY_STR( psz_title ) )
         {
-            o_value = [NSString stringWithUTF8String:
-                p_item->p_input->p_meta->psz_title];
-            if( o_value == NULL )
-                o_value = [NSString stringWithCString:
-                    p_item->p_input->p_meta->psz_title];
-        } 
-        else if( p_item->p_input->psz_name != NULL )
+            o_value = [NSString stringWithUTF8String: psz_title];
+        }
+        else
         {
-            o_value = [NSString stringWithUTF8String:
-                p_item->p_input->psz_name];
-            if( o_value == NULL )
-                o_value = [NSString stringWithCString:
-                    p_item->p_input->psz_name];
+            char *psz_name = input_item_GetName( p_item->p_input );
+            if( psz_name != NULL )
+            {
+                o_value = [NSString stringWithUTF8String: psz_name];
+            }
+            free( psz_name );
         }
+        free( psz_title );
     }
-    else if( [[o_tc identifier] isEqualToString:@"2"] && p_item->p_input->p_meta &&
-        p_item->p_input->p_meta->psz_artist && *p_item->p_input->p_meta->psz_artist )
-    {
-        o_value = [NSString stringWithUTF8String:
-            p_item->p_input->p_meta->psz_artist];
-        if( o_value == NULL )
-            o_value = [NSString stringWithCString:
-                p_item->p_input->p_meta->psz_artist];
-    }
-    else if( [[o_tc identifier] isEqualToString:@"3"] )
+    else
     {
-        char psz_duration[MSTRTIME_MAX_SIZE];
-        mtime_t dur = p_item->p_input->i_duration;
-        if( dur != -1 )
+        char *psz_artist = input_item_GetArtist( p_item->p_input );
+        if( [[o_tc identifier] isEqualToString:@"2"] && !EMPTY_STR( psz_artist ) )
         {
-            secstotimestr( psz_duration, dur/1000000 );
-            o_value = [NSString stringWithUTF8String: psz_duration];
+            o_value = [NSString stringWithUTF8String: psz_artist];
         }
-        else
+        else if( [[o_tc identifier] isEqualToString:@"3"] )
         {
-            o_value = @"-:--:--";
+            char psz_duration[MSTRTIME_MAX_SIZE];
+            mtime_t dur = input_item_GetDuration( p_item->p_input );
+            if( dur != -1 )
+            {
+                secstotimestr( psz_duration, dur/1000000 );
+                o_value = [NSString stringWithUTF8String: psz_duration];
+            }
+            else
+            {
+                o_value = @"-:--:--";
+            }
         }
+        free( psz_artist );
     }
 
     return( o_value );
 - (void)awakeFromNib
 {
     playlist_t * p_playlist = pl_Yield( VLCIntf );
-    vlc_list_t *p_list = vlc_list_find( p_playlist, VLC_OBJECT_MODULE,
-                                        FIND_ANYWHERE );
 
-    int i_index;
+    int i;
 
     [super awakeFromNib];
 
         @"VLCPlaylistItemPboardType", nil]];
     [o_outline_view setIntercellSpacing: NSMakeSize (0.0, 1.0)];
 
-    /* this uses private Apple API which works fine until 10.4, 
-     * but keep checking in the future!
+    /* This uses private Apple API which works fine until 10.4.
+     * We need to keep checking in the future!
      * These methods are being added artificially to NSOutlineView's interface above */
     o_ascendingSortingImage = [[NSOutlineView class] _defaultTableHeaderSortImage];
     o_descendingSortingImage = [[NSOutlineView class] _defaultTableHeaderReverseSortImage];
 
     o_tc_sortColumn = nil;
 
-    for( i_index = 0; i_index < p_list->i_count; i_index++ )
+    char ** ppsz_name;
+    char ** ppsz_services = services_discovery_GetServicesNames( p_playlist, &ppsz_name );
+    if( !ppsz_services )
+    {
+        vlc_object_release( p_playlist );
+        return;
+    }
+    
+    for( i = 0; ppsz_services[i]; i++ )
     {
         vlc_bool_t  b_enabled;
         char        *objectname;
         NSMenuItem  *o_lmi;
-        module_t    *p_parser = (module_t *)p_list->p_values[i_index].p_object ;
 
-        if( !strcmp( p_parser->psz_capability, "services_discovery" ) )
-        {
-            /* Check for submodules */
-            int i = -1;
-            while( p_parser->pp_shortcuts[++i] != NULL ); i--;
-
-            /* Check whether to enable these menuitems */
-            objectname = i>=0 ? (char *)p_parser->pp_shortcuts[i] : (char *)p_parser->psz_object_name;
-            b_enabled = playlist_IsServicesDiscoveryLoaded( p_playlist, objectname );
-            
-            /* Create the menu entries used in the playlist menu */
-            o_lmi = [[o_mi_services submenu] addItemWithTitle:
-                     [NSString stringWithUTF8String:
-                     p_parser->psz_longname ? p_parser->psz_longname :
-                     ( p_parser->psz_shortname ? p_parser->psz_shortname:
-                     objectname)]
-                                             action: @selector(servicesChange:)
-                                             keyEquivalent: @""];
-            [o_lmi setTarget: self];
-            [o_lmi setRepresentedObject: [NSString stringWithCString: objectname]];
-            if( b_enabled ) [o_lmi setState: NSOnState];
-                
-            /* Create the menu entries for the main menu */
-            o_lmi = [[o_mm_mi_services submenu] addItemWithTitle:
-                     [NSString stringWithUTF8String:
-                     p_parser->psz_longname ? p_parser->psz_longname :
-                     ( p_parser->psz_shortname ? p_parser->psz_shortname:
-                     objectname)]
-                                             action: @selector(servicesChange:)
-                                             keyEquivalent: @""];
-            [o_lmi setTarget: self];
-            [o_lmi setRepresentedObject: [NSString stringWithCString:objectname]];
-            if( b_enabled ) [o_lmi setState: NSOnState];
-        }
-    }
-    vlc_list_release( p_list );
-    vlc_object_release( p_playlist );
+        char * name = ppsz_name[i] ? ppsz_name[i] : ppsz_services[i];
+        /* Check whether to enable these menuitems */
+        b_enabled = playlist_IsServicesDiscoveryLoaded( p_playlist, objectname );
+
+        /* Create the menu entries used in the playlist menu */
+        o_lmi = [[o_mi_services submenu] addItemWithTitle:
+                 [NSString stringWithUTF8String: name]
+                                         action: @selector(servicesChange:)
+                                         keyEquivalent: @""];
+        [o_lmi setTarget: self];
+        [o_lmi setRepresentedObject: [NSString stringWithUTF8String: ppsz_services[i]]];
+        if( b_enabled ) [o_lmi setState: NSOnState];
+
+        /* Create the menu entries for the main menu */
+        o_lmi = [[o_mm_mi_services submenu] addItemWithTitle:
+                 [NSString stringWithUTF8String: name]
+                                         action: @selector(servicesChange:)
+                                         keyEquivalent: @""];
+        [o_lmi setTarget: self];
+        [o_lmi setRepresentedObject: [NSString stringWithUTF8String: ppsz_services[i]]];
+        if( b_enabled ) [o_lmi setState: NSOnState];
+
+        free( ppsz_services[i] );
+        free( ppsz_name[i] );
+    }
+    free( ppsz_services );
+    free( ppsz_name );
 
-    //[self playlistUpdated];
+    vlc_object_release( p_playlist );
 }
 
 - (void)searchfieldChanged:(NSNotification *)o_notification
     [o_mi_sort_name setTitle: _NS("Sort Node by Name")];
     [o_mi_sort_author setTitle: _NS("Sort Node by Author")];
     [o_mi_services setTitle: _NS("Services discovery")];
-    [o_status_field setStringValue: [NSString stringWithFormat:
-                        _NS("No items in the playlist")]];
+    [o_status_field setStringValue: _NS("No items in the playlist")];
 
-#if 0
-    [o_search_button setTitle: _NS("Search")];
-#endif
     [o_search_field setToolTip: _NS("Search in Playlist")];
     [o_mi_addNode setTitle: _NS("Add Folder to Playlist")];
 
     {
         [o_status_field setStringValue: [NSString stringWithFormat:
                     _NS("%i items in the playlist"),
-                               playlist_CurrentSize( p_playlist )]];
+                playlist_CurrentSize( p_playlist )]];
     }
     else
     {
     {
         [o_array insertObject: [NSValue valueWithPointer: p_temp_item] atIndex: 0];
         p_temp_item = p_temp_item->p_parent;
-        /*for (i = 0 ; i < p_temp_item->i_parents ; i++)
-        {
-            if( p_temp_item->pp_parents[i]->i_view == i_current_view )
-            {
-                p_temp_item = p_temp_item->pp_parents[i]->p_parent;
-                break;
-            }
-        }*/
     }
 
     for( j = 0; j < [o_array count] - 1; j++ )
 
     }
 
-    i_row = [o_outline_view rowForItem:[o_outline_dict
-            objectForKey:[NSString stringWithFormat: @"%p", p_item]]];
-
-    [o_outline_view selectRow: i_row byExtendingSelection: NO];
-    [o_outline_view scrollRowToVisible: i_row];
-
     vlc_object_release( p_playlist );
 
     /* update our info-panel to reflect the new item */
 
 - (IBAction)savePlaylist:(id)sender
 {
-    intf_thread_t * p_intf = VLCIntf;
-    playlist_t * p_playlist = pl_Yield( p_intf );
+    playlist_t * p_playlist = pl_Yield( VLCIntf );
 
     NSSavePanel *o_save_panel = [NSSavePanel savePanel];
     NSString * o_name = [NSString stringWithFormat: @"%@", _NS("Untitled")];
             {
                 o_real_filename = o_filename;
             }
-            playlist_Export( p_playlist, 
-                [o_real_filename fileSystemRepresentation], 
+            playlist_Export( p_playlist,
+                [o_real_filename fileSystemRepresentation],
                 p_playlist->p_local_category, "export-xspf" );
         }
         else
             {
                 o_real_filename = o_filename;
             }
-            playlist_Export( p_playlist, 
+            playlist_Export( p_playlist,
                 [o_real_filename fileSystemRepresentation],
                 p_playlist->p_local_category, "export-m3u" );
         }
     NSMutableArray *o_to_preparse;
     intf_thread_t * p_intf = VLCIntf;
     playlist_t * p_playlist = pl_Yield( p_intf );
-                                                       
     o_to_preparse = [NSMutableArray arrayWithArray:[[o_outline_view selectedRowEnumerator] allObjects]];
     i_count = [o_to_preparse count];
 
             }
             else
             {
-                msg_Dbg( p_intf, "preparse of nodes not yet implemented" );
+                msg_Dbg( p_intf, "preparsing nodes not implemented" );
             }
         }
     }
     NSMenuItem *o_mi = (NSMenuItem *)sender;
     NSString *o_string = [o_mi representedObject];
     playlist_t * p_playlist = pl_Yield( VLCIntf );
-    if( !playlist_IsServicesDiscoveryLoaded( p_playlist, [o_string cString] ) )
-        playlist_ServicesDiscoveryAdd( p_playlist, [o_string cString] );
+    if( !playlist_IsServicesDiscoveryLoaded( p_playlist, [o_string UTF8String] ) )
+        playlist_ServicesDiscoveryAdd( p_playlist, [o_string UTF8String] );
     else
-        playlist_ServicesDiscoveryRemove( p_playlist, [o_string cString] );
+        playlist_ServicesDiscoveryRemove( p_playlist, [o_string UTF8String] );
 
     [o_mi setState: playlist_IsServicesDiscoveryLoaded( p_playlist,
-                                          [o_string cString] ) ? YES : NO];
+                                          [o_string UTF8String] ) ? YES : NO];
 
     vlc_object_release( p_playlist );
     [self playlistUpdated];
 
     if( [o_outline_view selectedRow] > -1 )
     {
-        p_item = [[o_outline_view itemAtRow: [o_outline_view selectedRow]]
-                                                                pointerValue];
+        p_item = [[o_outline_view itemAtRow: [o_outline_view selectedRow]] pointerValue];
     }
     else
     /*If no item is selected, sort the whole playlist*/
         {
             NSMutableString *o_temp, *o_temp2;
             o_temp = [NSMutableString stringWithString: o_uri];
-            o_temp2 = [NSMutableString stringWithCString: mounts[i_index].f_mntfromname];
-            [o_temp replaceOccurrencesOfString: @"/dev/rdisk" withString: @"/dev/disk" options:nil range:NSMakeRange(0, [o_temp length]) ];
-            [o_temp2 replaceOccurrencesOfString: @"s0" withString: @"" options:nil range:NSMakeRange(0, [o_temp2 length]) ];
-            [o_temp2 replaceOccurrencesOfString: @"s1" withString: @"" options:nil range:NSMakeRange(0, [o_temp2 length]) ];
+            o_temp2 = [NSMutableString stringWithUTF8String: mounts[i_index].f_mntfromname];
+            [o_temp replaceOccurrencesOfString: @"/dev/rdisk" withString: @"/dev/disk" options:NSLiteralSearch range:NSMakeRange(0, [o_temp length]) ];
+            [o_temp2 replaceOccurrencesOfString: @"s0" withString: @"" options:NSLiteralSearch range:NSMakeRange(0, [o_temp2 length]) ];
+            [o_temp2 replaceOccurrencesOfString: @"s1" withString: @"" options:NSLiteralSearch range:NSMakeRange(0, [o_temp2 length]) ];
 
             if( strstr( [o_temp fileSystemRepresentation], [o_temp2 fileSystemRepresentation] ) != NULL )
             {
-                o_name = [[NSFileManager defaultManager] displayNameAtPath: [NSString stringWithCString:mounts[i_index].f_mntonname]];
+                o_name = [[NSFileManager defaultManager] displayNameAtPath: [NSString stringWithUTF8String:mounts[i_index].f_mntonname]];
             }
         }
     }
         buf = (struct statfs *) malloc (sizeof(struct statfs));
         statfs( [o_uri fileSystemRepresentation], buf );
         psz_dev = strdup(buf->f_mntfromname);
-        o_temp = [NSMutableString stringWithCString: psz_dev ];
-        [o_temp replaceOccurrencesOfString: @"/dev/disk" withString: @"/dev/rdisk" options:nil range:NSMakeRange(0, [o_temp length]) ];
-        [o_temp replaceOccurrencesOfString: @"s0" withString: @"" options:nil range:NSMakeRange(0, [o_temp length]) ];
-        [o_temp replaceOccurrencesOfString: @"s1" withString: @"" options:nil range:NSMakeRange(0, [o_temp length]) ];
+        o_temp = [NSMutableString stringWithUTF8String: psz_dev ];
+        [o_temp replaceOccurrencesOfString: @"/dev/disk" withString: @"/dev/rdisk" options:NSLiteralSearch range:NSMakeRange(0, [o_temp length]) ];
+        [o_temp replaceOccurrencesOfString: @"s0" withString: @"" options:NSLiteralSearch range:NSMakeRange(0, [o_temp length]) ];
+        [o_temp replaceOccurrencesOfString: @"s1" withString: @"" options:NSLiteralSearch range:NSMakeRange(0, [o_temp length]) ];
         o_uri = o_temp;
     }
 
 
     /* Recent documents menu */
     o_true_file = [NSURL fileURLWithPath: o_uri];
-    if( o_true_file != nil )
+    if( o_true_file != nil && (BOOL)config_GetInt( p_playlist, "macosx-recentitems" ) == YES )
     {
         [[NSDocumentController sharedDocumentController]
             noteNewRecentDocumentURL: o_true_file];
         /* Add the item */
         playlist_AddInput( p_playlist, p_input, PLAYLIST_INSERT,
              i_position == -1 ? PLAYLIST_END : i_position + i_item, VLC_TRUE,
-            VLC_FALSE );
+         VLC_FALSE );
 
         if( i_item == 0 && !b_enqueue )
         {
         {
             playlist_item_t *p_item;
             p_item = playlist_ItemGetByInput( p_playlist, p_input, VLC_TRUE );
-            playlist_Control( p_playlist, PLAYLIST_PREPARSE, VLC_TRUE, p_item );
+            playlist_Control( p_playlist, PLAYLIST_SKIP, VLC_TRUE, p_item );
         }
     }
     [self playlistUpdated];
         {
             playlist_item_t *p_item;
             p_item = playlist_ItemGetByInput( p_playlist, p_input, VLC_TRUE );
-            playlist_Control( p_playlist, PLAYLIST_PREPARSE, VLC_TRUE, p_item );
+            playlist_Control( p_playlist, PLAYLIST_SKIP, VLC_TRUE, p_item );
         }
     }
     [self playlistUpdated];
     /* we have to create a new thread here because otherwise we would block the
      * interface since the interaction-stuff and this code would run in the same
      * thread */
-    [NSThread detachNewThreadSelector: @selector(addNodeThreadedly) 
+    [NSThread detachNewThreadSelector: @selector(addNodeThreadedly)
         toTarget: self withObject:nil];
     [self playlistUpdated];
 }
     int ret_v;
     char *psz_name = NULL;
     playlist_item_t * p_item;
-    ret_v = intf_UserStringInput( p_playlist, _("New Node"), 
+    ret_v = intf_UserStringInput( p_playlist, _("New Node"),
         _("Please enter a name for the new node."), &psz_name );
 
     if( psz_name != NULL && psz_name != "" )
-        p_item = playlist_NodeCreate( p_playlist, psz_name, 
-                                            p_playlist->p_local_category, 0 );
+        p_item = playlist_NodeCreate( p_playlist, psz_name,
+                                      p_playlist->p_local_category, 0, NULL );
     else if(! config_GetInt( p_playlist, "interact" ) )
     {
         /* in case that the interaction is disabled, just give it a bogus name */
-        p_item = playlist_NodeCreate( p_playlist, _("Empty Folder"), 
-                                            p_playlist->p_local_category, 0 );
+        p_item = playlist_NodeCreate( p_playlist, _("Empty Folder"),
+                                      p_playlist->p_local_category, 0, NULL );
     }
 
     if(! p_item )
     {
         [o_status_field setStringValue: [NSString stringWithFormat:
                     _NS("%i items in the playlist"),
-                       playlist_CurrentSize( p_playlist )]];
+             playlist_CurrentSize( p_playlist )]];
     }
     else
     {
 
     [o_outline_dict setObject:o_value forKey:[NSString stringWithFormat:@"%p",
                                                     [o_value pointerValue]]];
+#ifdef DEBUG
     msg_Dbg( VLCIntf, "adding item %p", [o_value pointerValue] );
+#endif
     return o_value;
 
 }
         /* Refuse to move items that are not in the General Node
            (Service Discovery) */
         if( ![self isItem: [o_item pointerValue] inNode:
-                        p_playlist->p_local_category checkItemExistence: NO])
+                        p_playlist->p_local_category checkItemExistence: NO] &&
+            ( var_CreateGetBool( p_playlist, "media-library" ) &&
+            ![self isItem: [o_item pointerValue] inNode:
+                        p_playlist->p_ml_category checkItemExistence: NO]) )
         {
             vlc_object_release(p_playlist);
             return NO;
     /* We refuse to drop an item in anything else than a child of the General
        Node. We still accept items that would be root nodes of the outlineview
        however, to allow drop in an empty playlist. */
-    if( !([self isItem: [item pointerValue] inNode: p_playlist->p_local_category
-                                    checkItemExistence: NO] || item == nil) )
+    if( !( ([self isItem: [item pointerValue] inNode: p_playlist->p_local_category checkItemExistence: NO] || 
+        ( var_CreateGetBool( p_playlist, "media-library" ) && [self isItem: [item pointerValue] inNode: p_playlist->p_ml_category checkItemExistence: NO] ) ) || item == nil ) )
     {
         vlc_object_release( p_playlist );
         return NSDragOperationNone;
     vlc_object_release( p_playlist );
     return NO;
 }
-
-/* Delegate method of NSWindow */
-/*- (void)windowWillClose:(NSNotification *)aNotification
-{
-    [o_btn_playlist setState: NSOffState];
-}
-*/
 @end